Compare commits
5 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 48899b41a9 | |||
| 2043fa5e9e | |||
| 79646bda13 | |||
| d4594d18b7 | |||
| 1176f7fd0b |
@@ -40,11 +40,13 @@ jobs:
|
|||||||
# The backup tests check this code against the age command itself: a
|
# The backup tests check this code against the age command itself: a
|
||||||
# pinned age release, its archive checked against the SHA-256 below,
|
# pinned age release, its archive checked against the SHA-256 below,
|
||||||
# and PRIVATAE_REQUIRE_AGE makes those tests fail rather than skip if
|
# and PRIVATAE_REQUIRE_AGE makes those tests fail rather than skip if
|
||||||
# it is missing.
|
# it is missing. openssl is what install.sh checks a release's
|
||||||
|
# signature with; PRIVATAE_REQUIRE_OPENSSL makes install_sig_sh_test.go
|
||||||
|
# fail rather than skip without one that does Ed25519.
|
||||||
run: |
|
run: |
|
||||||
docker run --rm --cpus 6 -e GOMAXPROCS=6 -v "$PWD":/src -w /src/client-go \
|
docker run --rm --cpus 6 -e GOMAXPROCS=6 -v "$PWD":/src -w /src/client-go \
|
||||||
-e GOTOOLCHAIN=local -e CGO_ENABLED=0 -e PRIVATAE_REQUIRE_AGE=1 "$GO_IMAGE" sh -euc '
|
-e GOTOOLCHAIN=local -e CGO_ENABLED=0 -e PRIVATAE_REQUIRE_AGE=1 -e PRIVATAE_REQUIRE_OPENSSL=1 "$GO_IMAGE" sh -euc '
|
||||||
apk add -q --no-cache poppler-utils python3 setpriv curl git git-daemon
|
apk add -q --no-cache poppler-utils python3 setpriv curl git git-daemon openssl
|
||||||
case "$(uname -m)" in
|
case "$(uname -m)" in
|
||||||
x86_64) a=amd64; sum=cbe24006683f8eb669266162894b9a522a1af52f2665fbc63a4bb032ed26ac10 ;;
|
x86_64) a=amd64; sum=cbe24006683f8eb669266162894b9a522a1af52f2665fbc63a4bb032ed26ac10 ;;
|
||||||
aarch64) a=arm64; sum=6b8dc4333c53a5a57c9e5834e3a48f92605d7154014cd07269ff3327db5d37f4 ;;
|
aarch64) a=arm64; sum=6b8dc4333c53a5a57c9e5834e3a48f92605d7154014cd07269ff3327db5d37f4 ;;
|
||||||
|
|||||||
@@ -243,6 +243,6 @@ jobs:
|
|||||||
sudo env PATH="/opt/go-pinned/bin:$PATH" HOME="$HOME" AGE_BIN="$AGE_BIN" PRIVATAE_REQUIRE_AGE=1 GOTOOLCHAIN=local CGO_ENABLED=0 \
|
sudo env PATH="/opt/go-pinned/bin:$PATH" HOME="$HOME" AGE_BIN="$AGE_BIN" PRIVATAE_REQUIRE_AGE=1 GOTOOLCHAIN=local CGO_ENABLED=0 \
|
||||||
GOFLAGS=-mod=readonly GOMODCACHE="$HOME/go/pkg/mod" GOCACHE="$HOME/.cache/go-build" \
|
GOFLAGS=-mod=readonly GOMODCACHE="$HOME/go/pkg/mod" GOCACHE="$HOME/.cache/go-build" \
|
||||||
go test -count=1 -json -run "^($tests)\$" . > "$RUNNER_TEMP/claims.json" || {
|
go test -count=1 -json -run "^($tests)\$" . > "$RUNNER_TEMP/claims.json" || {
|
||||||
grep -h '"Action":"fail"' "$RUNNER_TEMP/claims.json" | head -40; exit 1; }
|
bash ../deploy/check-claims.sh --failed "$RUNNER_TEMP/claims.json"; exit 1; }
|
||||||
- name: none of them skipped
|
- name: none of them skipped
|
||||||
run: bash deploy/check-claims.sh --skipped "$RUNNER_TEMP/claims.json"
|
run: bash deploy/check-claims.sh --skipped "$RUNNER_TEMP/claims.json"
|
||||||
|
|||||||
+251
@@ -22,6 +22,257 @@ From 0.39.1 on, a heading marks a version *not published* or *held* once
|
|||||||
that is settled. The newest entries may not be published yet; the manifest
|
that is settled. The newest entries may not be published yet; the manifest
|
||||||
says which version is. Older entries are not marked.
|
says which version is. Older entries are not marked.
|
||||||
|
|
||||||
|
## 0.63.1
|
||||||
|
|
||||||
|
The same program as 0.63.0; its source is now publishable.
|
||||||
|
|
||||||
|
## 0.63.0
|
||||||
|
|
||||||
|
One Host is in charge of each machine, every pairing comes along when the
|
||||||
|
machine moves to the service, a Host that waits says who admits it, and a Host
|
||||||
|
at home governs a server on the internet that can't reach it back.
|
||||||
|
|
||||||
|
- **Your Host connects to a server it can reach and that can't reach it
|
||||||
|
back.** A Host on your own computer, behind your home router, now governs a
|
||||||
|
server on the internet with no VPS and nothing opened at home. On the
|
||||||
|
server, `privatae-bastion pair --open` shows a code, good once and for 15
|
||||||
|
minutes; give your Host the server's address and the code. Your Host then
|
||||||
|
opens the connections, to TCP 8812 on the server, and every lane runs over
|
||||||
|
them as before: the bastion is still the TLS client, the Host's CA still
|
||||||
|
the only one it trusts, its own certificate still presented. The code is
|
||||||
|
proved by each side to the other over the Host's certificate on that
|
||||||
|
connection and never sent; a wrong one costs a wait that doubles, and the
|
||||||
|
fifth closes the window. The port is open only while such a Host is served
|
||||||
|
or a window is open, keeps nothing but its own Hosts' connections, and
|
||||||
|
forwards nothing; the audit records the window, each Host connecting and
|
||||||
|
going away, and refused connections. The wire contract a Host implements is
|
||||||
|
[docs/host-connects.md](docs/host-connects.md).
|
||||||
|
|
||||||
|
- **Nobody touches a firewall for it.** While that port is in use, the
|
||||||
|
bastion keeps its own rule allowing it inbound, and removes the rule when
|
||||||
|
the last such Host and window are gone, and on `uninstall`: in Windows
|
||||||
|
Firewall (inbound TCP 8812, every profile, for the bastion's own program
|
||||||
|
only), and on Linux in ufw or firewalld when one of them is on. It never
|
||||||
|
turns a firewall on or off or changes anything else in it, and leaves alone
|
||||||
|
a rule of the machine's own that already allows the port. A firewall it does
|
||||||
|
not manage (nftables or iptables rules, ufw for an account that can't change
|
||||||
|
it, macOS set to block all incoming) is said once, with what to allow, in
|
||||||
|
`status` and `doctor`. Each rule added or removed is in the audit. A cloud
|
||||||
|
provider's firewall still needs the port allowed.
|
||||||
|
- **Your own Host gets back in while strangers flood the port.** Of the 256
|
||||||
|
connections the port takes in their handshake at once, 64 are kept for
|
||||||
|
addresses a Host proved itself from in the last 7 days, so your Host gets in
|
||||||
|
at its first try however many addresses flood it. Any other address is
|
||||||
|
refused at random once 64 are running, more often as it fills, and always
|
||||||
|
at 192 (as OpenSSH's `MaxStartups` does), so a new Host still pairs on a
|
||||||
|
quiet port. The addresses are kept in memory only, never written anywhere;
|
||||||
|
a bastion that has just restarted knows none until its Hosts connect again.
|
||||||
|
- **A server you add has your Host in charge.** `pair --open`, run with
|
||||||
|
machine authority on a server no Host is in charge of, puts the Host that
|
||||||
|
pairs through it in charge (the anchor), so your Host counts the server as
|
||||||
|
yours. A local server becomes networked for it, unless it already serves
|
||||||
|
another Host you said yes to. A Host on the server itself still wins, and an
|
||||||
|
organisation's policy that names another Host still decides. With a Host in
|
||||||
|
charge, each terminal and write on the server waits for your approval, as on
|
||||||
|
any server a Host is in charge of: enrol a second factor there
|
||||||
|
(`stepup-enroll`), as `pair --open` says.
|
||||||
|
- **Adding the same server again just works.** The same Host pairing the
|
||||||
|
same server again through a fresh `pair --open` code replaces its pairing
|
||||||
|
in place, with no `unpair` first: new credentials, the same state, its grants
|
||||||
|
and its place in charge kept (also under a new name). It is the same Host
|
||||||
|
when its connection presents the CA the pairing already holds; another
|
||||||
|
Host with the same name is still refused.
|
||||||
|
- **`pair --open` right after `unpair`.** The running bastion lets go of
|
||||||
|
port 8812 only once it sees the pairing gone, within 15 seconds; `pair
|
||||||
|
--open` now waits up to 25 seconds for that, and says so, instead of
|
||||||
|
failing with "address already in use".
|
||||||
|
- **The tests can't touch a live bastion.** `scripts/e2e-host-connects.sh`
|
||||||
|
hid `/run/privatae` but not `/run/privatae-bastion`, and on a machine
|
||||||
|
running a real bastion it replaced that bastion's local sockets. It now puts
|
||||||
|
an empty mount over all of `/run` and `/tmp` and the bastion's state, and
|
||||||
|
refuses to start while it can still see the machine's bastion; a test holds
|
||||||
|
every namespace script in `scripts/` to that. A lane test that raced its
|
||||||
|
own workers' start no longer fails now and then.
|
||||||
|
|
||||||
|
- **The Host on your own computer is the one in charge of it.** A Host that
|
||||||
|
runs on the same machine as the bastion (over a socket, or on a loopback
|
||||||
|
lane port, as `npx cseries` sets up) takes charge when it is paired from an
|
||||||
|
Administrator terminal, also from a remote Host that held it before, and
|
||||||
|
never "whichever paired first". The Host it replaced is told so on its
|
||||||
|
last heartbeat, keeps its pairing, and waits for the Host on your computer
|
||||||
|
to admit it, as any other Host does. The change is recorded in the
|
||||||
|
machine's pairing audit. `claim-anchor` with no host picks the Host on
|
||||||
|
this machine, and naming another while one is paired is refused with the
|
||||||
|
reason.
|
||||||
|
- **An organisation's policy can name the Host in charge, and only that
|
||||||
|
overrides it.** On a machine an organisation manages, a policy it deploys
|
||||||
|
names the Host: on Windows the `AnchorHost` value under
|
||||||
|
`HKLM\SOFTWARE\Policies\Privatae\Bastion` (Group Policy, Intune), on macOS
|
||||||
|
the `AnchorHost` key of the managed preference `ai.privatae.bastion` (a
|
||||||
|
configuration profile), on Linux `anchor_host` in the root-owned
|
||||||
|
`/etc/privatae-bastion/policy.json`. That Host takes charge when it is
|
||||||
|
paired, every other Host waits for it, and `claim-anchor` for any other is
|
||||||
|
refused in words that say an organisation manages the machine. Joining a
|
||||||
|
domain is not a policy.
|
||||||
|
- **A Host that waits says who admits it.** `pair` on a machine with a Host
|
||||||
|
in charge says the code was used, that the new Host waits for that Host to
|
||||||
|
admit it, and that it asks you to approve it. `status`, `status --json`
|
||||||
|
(`waiting_for`), `doctor`, the console and the tray say "waiting for
|
||||||
|
<Host> to admit it", never "not answering". The heartbeat to the Host in
|
||||||
|
charge lists each waiting pairing with `waiting_for`, `transport`,
|
||||||
|
`same_machine` and `origin` (paired here, carried from your account, or the
|
||||||
|
Host that was in charge before), what that Host needs to ask you.
|
||||||
|
- **Moving to the service keeps every pairing, with no question.** The move
|
||||||
|
from your account's bastion to the bastion for the whole machine carries
|
||||||
|
every pairing your account had, also when the service already served a Host
|
||||||
|
of its own: each comes across with its keys and folders and a control port
|
||||||
|
of its own. Into a machine with a Host in charge each waits for that Host to
|
||||||
|
admit it; into one with none it is served as it was. The installer's last
|
||||||
|
words say what the service serves and what waits, instead of "no Host is
|
||||||
|
needed".
|
||||||
|
- **Each pairing runs on its own.** One Host's lanes failing (a port taken,
|
||||||
|
a certificate that does not read) stopped the whole bastion, and every other
|
||||||
|
Host with it. Now that pairing alone stops: it is said in the log, the
|
||||||
|
machine's events and `status`, and it is tried again by itself after a
|
||||||
|
pause that grows from 15 seconds to 5 minutes.
|
||||||
|
- **The model server on your machine is found by itself.** With
|
||||||
|
`PRIVATAE_LLM_ADDR` unset, the bastion looks on this machine's loopback, and
|
||||||
|
nowhere else, for an OpenAI-compatible server on its usual port: 8080
|
||||||
|
(llama.cpp), 8000 (vLLM), 1234 (LM Studio), in that order, and serves the
|
||||||
|
first whose `/v1/models` answers with a list of models; on Linux only one
|
||||||
|
run by root, the bastion's own account or the machine's owner, never another
|
||||||
|
account's. It asks again every
|
||||||
|
minute and as soon as the one it found stops answering, so what the
|
||||||
|
heartbeat says is served is what the lane reaches. The variable still
|
||||||
|
overrides it. The log says once what was found, or that nothing was, and
|
||||||
|
`status` and `doctor` show it.
|
||||||
|
- **Smaller ones, from a replay of a Windows desktop.** The service's log
|
||||||
|
names the Windows service manager when it stops the bastion, not the tray.
|
||||||
|
The owner's `status` and the other reads work over a network sign-in (ssh,
|
||||||
|
remote PowerShell), which the service's permissions refused with "Access is
|
||||||
|
denied". `pair` and `claim-anchor` no longer tell you to run or restart the
|
||||||
|
bastion when one is running: it serves a new pairing within 15 seconds.
|
||||||
|
|
||||||
|
## 0.62.1 (not published)
|
||||||
|
|
||||||
|
Superseded by 0.63.0, which carries these changes.
|
||||||
|
|
||||||
|
Windows, the installer for the whole machine:
|
||||||
|
|
||||||
|
- **Installing over a running bastion works.** The tray runs from the
|
||||||
|
service's own program in every signed-in session, and Windows will not
|
||||||
|
replace a running program, so a reinstall or upgrade stopped with "Cannot
|
||||||
|
create a file when that file already exists." The installer now moves the
|
||||||
|
program in place aside (the bastion removes it at its next start) and puts
|
||||||
|
the new one in its name, as the bastion's own self-update does.
|
||||||
|
- **A failed install never leaves the bastion stopped.** The service the
|
||||||
|
installer stopped is started again before the failure is reported, and the
|
||||||
|
message says what failed and whether the bastion is running.
|
||||||
|
- **Your tray is the new version too.** After the install, the tray in your
|
||||||
|
session is started again from the new program. Run from an Administrator
|
||||||
|
terminal by hand, the installer says an open tray changes at your next
|
||||||
|
sign-in. The trays of other people signed in are left running the earlier
|
||||||
|
program until their next sign-in, never stopped as an earlier install.
|
||||||
|
- **A reinstall for your account alone runs the new version.** With no
|
||||||
|
pairing code, it said the bastion was running while the copy already
|
||||||
|
running was still the earlier program; it now stops that copy before
|
||||||
|
starting the new one.
|
||||||
|
|
||||||
|
## 0.62.0
|
||||||
|
|
||||||
|
Windows, with the bastion installed for the whole machine (the
|
||||||
|
`PrivataeBastion` service), from the account that owns the machine:
|
||||||
|
|
||||||
|
- **`privatae-bastion ui` opens the console from your own account,** with no
|
||||||
|
Administrator terminal, as it does on Linux and macOS. It asks the service
|
||||||
|
over a new pipe, which knows your account from Windows and serves only the
|
||||||
|
account recorded as the machine's owner. Before this it signed in with a
|
||||||
|
key of your account's own, which the service's console refused with a bare
|
||||||
|
401.
|
||||||
|
- **Your agents and you reach the machine's bastion as on Linux and macOS:**
|
||||||
|
an agent asks to stop another (`stop`, `request`), reads the machine
|
||||||
|
(`agents`, `activity`, `status`, `doctor`, the `--json` reads), and you
|
||||||
|
answer from your own account (`approvals`, `approve`, `deny`, `switch`, the
|
||||||
|
drops). These were refused beside the service.
|
||||||
|
- **Moving to the service keeps the machine's pairings.** When an install
|
||||||
|
moves the bastion from your account to the service, the service takes over
|
||||||
|
your account's bastion state (pairings, keys, grants, audit) before it first
|
||||||
|
starts, and the copy in your profile is removed. Every Host it served goes
|
||||||
|
on being served, and nothing is paired again. The service started empty
|
||||||
|
before, and the machine went silent to its Hosts.
|
||||||
|
- **No dead ends.** A console page opened with no session names the command
|
||||||
|
that opens it on this machine. A second start says which bastion is already
|
||||||
|
running (its process, its program, how it was started) and how to open,
|
||||||
|
check or restart it. It no longer suggests ending the running one in Task
|
||||||
|
Manager.
|
||||||
|
- **An update never leaves a sign-in task's bastion stopped.** After a
|
||||||
|
self-update, the new copy waits for the old one to exit before it takes the
|
||||||
|
machine's run lock. It could find the lock still held, refuse as a second
|
||||||
|
copy, and leave nothing running.
|
||||||
|
|
||||||
|
## 0.61.2
|
||||||
|
|
||||||
|
- **A machine a Host holds stops dialling it.** When a Host's owner
|
||||||
|
quarantines this machine there, the Host refuses each of the bastion's lane
|
||||||
|
connections, and three of the five lanes dialled again at once, the other
|
||||||
|
two a second later: tens of connections a second, each a TLS handshake.
|
||||||
|
Now a refusal holds all of that pairing's lanes for 5 seconds, twice as long
|
||||||
|
after each further refusal up to 5 minutes; and while the Host's heartbeat
|
||||||
|
reply says the machine is quarantined, the lanes do not dial at all. The
|
||||||
|
first reply that no longer says so brings them back. Other Hosts the
|
||||||
|
machine is paired with are not slowed.
|
||||||
|
|
||||||
|
## 0.61.1
|
||||||
|
|
||||||
|
- **An op that creates a folder runs on every Linux kernel.** Where the
|
||||||
|
kernel's overlay keeps an index (or has `redirect_dir` or `metacopy` on, as
|
||||||
|
Azure's kernel does), it marks each new folder opaque, and the bastion took
|
||||||
|
that for a replaced folder: every op that created one was refused as "a path
|
||||||
|
outside the effects in disguise". A new folder is now read as created, with
|
||||||
|
what it holds; a folder that replaces one the machine holds is still
|
||||||
|
refused.
|
||||||
|
|
||||||
|
## 0.61.0
|
||||||
|
|
||||||
|
- **An agent on the machine reads the rest of it.** `agents show <pid|session>`
|
||||||
|
is one agent in full (its command line in `--json` only, since arguments can
|
||||||
|
carry a key). `switch --list`, `ops`, `device-approvals`, `backup key show`,
|
||||||
|
`backup requests` and `backup shares` print as one value with `--json`.
|
||||||
|
Beside a whole-machine install, the owner's account reads them from the
|
||||||
|
machine's bastion over its ask socket, as `agents` and `activity` already
|
||||||
|
were; no other account is answered.
|
||||||
|
- **`doctor [--json]` says what is wrong with the install**, each problem with
|
||||||
|
its fix: whether the bastion runs, whether a newer version is published, the
|
||||||
|
owner account, the machine's second factor, accounts whose asks are held,
|
||||||
|
each Host pairing, the switch list and the ops sandbox. Exit status 1 on a
|
||||||
|
problem.
|
||||||
|
- **The machine's owner answers from their own account.** `approve`, `deny`
|
||||||
|
and `switch` act on the machine's bastion over its ask socket instead of on
|
||||||
|
an empty bastion of the account's own. `approve` shows the request and takes
|
||||||
|
the owner's code at the terminal; `switch … on` takes the code; `deny` and
|
||||||
|
`switch … off` take nothing, since they only take reach away. Each act is a
|
||||||
|
line in the machine's audit log naming the account.
|
||||||
|
- **And takes reach back the same way:** `approvals drop`, `grants drop`,
|
||||||
|
`ops drop` and `device-deny`. Another account is refused each of them with
|
||||||
|
the command the administrator would type.
|
||||||
|
- **The installer checks the release's signature.** `install.sh` verifies the
|
||||||
|
manifest's signature against the release keys it carries before it downloads
|
||||||
|
the program, and refuses a signature that does not verify. Where no openssl can
|
||||||
|
check an Ed25519 signature it says so and keeps the digest check alone, as
|
||||||
|
before. `install.ps1` still checks the digest only.
|
||||||
|
- **One Host's folder is never answered for another's store.** On a machine
|
||||||
|
paired with two Hosts that each hold a store with the same id, one local agent
|
||||||
|
served both, so the second Host's searches and reads reached the first
|
||||||
|
Host's folder. Each pairing's stores now have their own agents, and each
|
||||||
|
Host's heartbeat reports only its own.
|
||||||
|
- **A stopped pairing's last heartbeat acts on nothing.** A beat out when its
|
||||||
|
pairing stopped (an unpair, a revoke) came back afterwards and could still
|
||||||
|
act on the reply, writing into the pairing's folder after an unpair had
|
||||||
|
removed it. A stopped pairing now waits for its heartbeat, whose request ends
|
||||||
|
with it.
|
||||||
|
- On Windows the owner's reads and acts are refused beside the bastion's
|
||||||
|
service with the administrator's command: there is no ask pipe there yet.
|
||||||
|
|
||||||
## 0.60.0
|
## 0.60.0
|
||||||
|
|
||||||
- **An agent can follow its own stop request to the end.** `request <id>
|
- **An agent can follow its own stop request to the end.** `request <id>
|
||||||
|
|||||||
@@ -3,7 +3,7 @@
|
|||||||
[](LICENSE)
|
[](LICENSE)
|
||||||
[](client-go/go.mod)
|
[](client-go/go.mod)
|
||||||
[](#supported-platforms)
|
[](#supported-platforms)
|
||||||
[](https://git.privatae.ai/privatae/privatae-bastion/actions)
|
[](https://github.com/Privatae/bastion/actions/workflows/ci.yml)
|
||||||
|
|
||||||
**See every AI agent running on your computer, what each one is doing and what it can reach, and stop any of them. One program, no account, no AI of its own.**
|
**See every AI agent running on your computer, what each one is doing and what it can reach, and stop any of them. One program, no account, no AI of its own.**
|
||||||
|
|
||||||
@@ -309,8 +309,9 @@ Each point in full: [docs/security-model.md](docs/security-model.md); the link a
|
|||||||
never read or moved. ([DCN stores](docs/context.md#distributed-context-network-dcn-stores))
|
never read or moved. ([DCN stores](docs/context.md#distributed-context-network-dcn-stores))
|
||||||
- **Verified releases.** The self-updater checks the manifest's signature and
|
- **Verified releases.** The self-updater checks the manifest's signature and
|
||||||
the binary's SHA-256 before swapping; the release key never reaches the
|
the binary's SHA-256 before swapping; the release key never reaches the
|
||||||
build machine. The installer checks the SHA-256 ([SECURITY.md](SECURITY.md)
|
build machine. The installer checks the SHA-256, and `install.sh` checks the
|
||||||
says what that proves). ([self-update](docs/updates.md))
|
manifest's signature where the machine's openssl can (OpenSSL 3)
|
||||||
|
([SECURITY.md](SECURITY.md) says what each proves). ([self-update](docs/updates.md))
|
||||||
- **No secrets cached for git.** The credential helper fetches a token on
|
- **No secrets cached for git.** The credential helper fetches a token on
|
||||||
every auth and stores nothing; which other helpers are kept out depends on
|
every auth and stores nothing; which other helpers are kept out depends on
|
||||||
the git version. ([git lane](docs/lanes.md#git-lane))
|
the git version. ([git lane](docs/lanes.md#git-lane))
|
||||||
|
|||||||
+16
-3
@@ -74,9 +74,22 @@ it was reinstalled by hand.
|
|||||||
|
|
||||||
**The first install.** `curl … | sudo sh` and `irm … | iex` run a script from
|
**The first install.** `curl … | sudo sh` and `irm … | iex` run a script from
|
||||||
our website before any bastion exists to check anything. The installer checks
|
our website before any bastion exists to check anything. The installer checks
|
||||||
the binary's digest against the manifest, but the installer and the manifest
|
the binary's digest against the manifest. `install.sh` also checks the
|
||||||
come from the same place. To avoid trusting that one download, build from
|
manifest's signature against the two pinned release keys, the ones a bastion
|
||||||
source (see the README) or run `deploy/verify-release.sh` before installing.
|
checks its updates with, where the machine's openssl can check Ed25519
|
||||||
|
(OpenSSL 3: most Linux, or `openssl@3` from Homebrew on a Mac); where it
|
||||||
|
cannot, it says so and keeps the digest check alone, and it refuses a
|
||||||
|
signature that does not verify. A script piped from our website is still our
|
||||||
|
website's, so what the signature adds is for a copy of `install.sh` you read
|
||||||
|
first, from this repository, and run as root (`sudo sh install.sh`) or for
|
||||||
|
your account alone (`sh install.sh --just-me`): that copy installs only a
|
||||||
|
release we signed, whatever the download host serves, though an older release
|
||||||
|
we signed passes as well as the newest. Run without sudo and without
|
||||||
|
`--just-me`, it installs for the whole machine through a root step that
|
||||||
|
fetches the installer from our website again and runs that one, not the copy
|
||||||
|
you read. `install.ps1` does not check the signature
|
||||||
|
yet. To avoid trusting any download, build from source (see the README) or
|
||||||
|
run `deploy/verify-release.sh` before installing.
|
||||||
|
|
||||||
**Bastion updates.** A bastion never replaces itself on its own. Your host has
|
**Bastion updates.** A bastion never replaces itself on its own. Your host has
|
||||||
to ask, and what it can ask for is limited to what we signed: the update goes
|
to ask, and what it can ask for is limited to what we signed: the update goes
|
||||||
|
|||||||
@@ -33,7 +33,7 @@ func cmdAddFolder(host, path, name string) error {
|
|||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
if len(cfgs) == 0 {
|
if len(cfgs) == 0 {
|
||||||
return fmt.Errorf("not paired yet — run `privatae-bastion pair <token>` first")
|
return fmt.Errorf("not paired yet — connect a Host first: %s", asAdmin("pair <token>"))
|
||||||
}
|
}
|
||||||
// Multi-homed boxes must NAME the host (0.10.0): guessing here is how a folder
|
// Multi-homed boxes must NAME the host (0.10.0): guessing here is how a folder
|
||||||
// ends up proposed to the wrong entity. One pairing needs no flag.
|
// ends up proposed to the wrong entity. One pairing needs no flag.
|
||||||
|
|||||||
+49
-24
@@ -8,7 +8,8 @@ package main
|
|||||||
// `stop` run by it had nowhere to ask, and asking is the one thing an agent
|
// `stop` run by it had nowhere to ask, and asking is the one thing an agent
|
||||||
// managing the bastion for the person must be able to do (2026-10-30).
|
// managing the bastion for the person must be able to do (2026-10-30).
|
||||||
// This is the context socket's mechanism (contextsock.go) for a second
|
// This is the context socket's mechanism (contextsock.go) for a second
|
||||||
// question: any local account may connect; WHO connected comes from the
|
// question, and on Windows the service's ask pipe (asklane_windows.go), which
|
||||||
|
// answers through the same askAnswer: any local account may connect; WHO connected comes from the
|
||||||
// kernel, never from the request; it may only ASK. The ask lands in the
|
// kernel, never from the request; it may only ASK. The ask lands in the
|
||||||
// owner's factor as a pending request (stepup_machine.go), shown on Waiting
|
// owner's factor as a pending request (stepup_machine.go), shown on Waiting
|
||||||
// for you and answered with the owner's code. Nothing here approves anything.
|
// for you and answered with the owner's code. Nothing here approves anything.
|
||||||
@@ -39,7 +40,7 @@ const (
|
|||||||
)
|
)
|
||||||
|
|
||||||
type agentAskRequest struct {
|
type agentAskRequest struct {
|
||||||
Op string `json:"op"` // "stop", "status" (askstatus.go), "console" (consolelane.go) or "read" (reads.go)
|
Op string `json:"op"` // "stop", "status" (askstatus.go), "console" (consolelane.go), "read" (reads.go) or "act" (owneracts.go)
|
||||||
PID int `json:"pid"`
|
PID int `json:"pid"`
|
||||||
Request string `json:"request,omitempty"` // "status": the id `stop` printed
|
Request string `json:"request,omitempty"` // "status": the id `stop` printed
|
||||||
// "read": which one, and its flags (readOpts).
|
// "read": which one, and its flags (readOpts).
|
||||||
@@ -48,6 +49,12 @@ type agentAskRequest struct {
|
|||||||
Prompts bool `json:"prompts,omitempty"`
|
Prompts bool `json:"prompts,omitempty"`
|
||||||
Host string `json:"host,omitempty"`
|
Host string `json:"host,omitempty"`
|
||||||
Machine bool `json:"machine,omitempty"`
|
Machine bool `json:"machine,omitempty"`
|
||||||
|
// "act": approve, deny or switch (owneracts.go), and what it acts on.
|
||||||
|
Act string `json:"act,omitempty"`
|
||||||
|
ID string `json:"id,omitempty"`
|
||||||
|
Code string `json:"code,omitempty"`
|
||||||
|
Family string `json:"family,omitempty"`
|
||||||
|
Off bool `json:"off,omitempty"`
|
||||||
}
|
}
|
||||||
|
|
||||||
type agentAskReply struct {
|
type agentAskReply struct {
|
||||||
@@ -75,7 +82,13 @@ var askPeerIdentityFn = contextPeerIdentity
|
|||||||
|
|
||||||
func startAskSock(done <-chan struct{}) {
|
func startAskSock(done <-chan struct{}) {
|
||||||
if runtime.GOOS == "windows" {
|
if runtime.GOOS == "windows" {
|
||||||
return // a named pipe, as context.sock has, is not built yet
|
// The ask pipe (asklane_windows.go). Only the service serves it: a
|
||||||
|
// bastion run by an account is that account's, and nobody else's
|
||||||
|
// requests are its to answer.
|
||||||
|
if runningAsService {
|
||||||
|
startAskPipe(done)
|
||||||
|
}
|
||||||
|
return
|
||||||
}
|
}
|
||||||
p := askSockPath()
|
p := askSockPath()
|
||||||
ln, err := contextSockListen(p)
|
ln, err := contextSockListen(p)
|
||||||
@@ -117,8 +130,7 @@ func askSockServe(c net.Conn) {
|
|||||||
_ = c.SetDeadline(time.Now().Add(10 * time.Second))
|
_ = c.SetDeadline(time.Now().Add(10 * time.Second))
|
||||||
uid, user, err := askPeerIdentityFn(c)
|
uid, user, err := askPeerIdentityFn(c)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
_ = json.NewEncoder(c).Encode(agentAskReply{Why: "this machine could not establish who is asking (" +
|
_ = json.NewEncoder(c).Encode(askUnattributable(err))
|
||||||
err.Error() + "), so nothing was asked. An ask nobody can attribute is one nobody can answer."})
|
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
var req agentAskRequest
|
var req agentAskRequest
|
||||||
@@ -126,26 +138,42 @@ func askSockServe(c net.Conn) {
|
|||||||
_ = json.NewEncoder(c).Encode(agentAskReply{User: user, Why: "the request could not be read"})
|
_ = json.NewEncoder(c).Encode(agentAskReply{User: user, Why: "the request could not be read"})
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
if req.Op == "console" {
|
extend := func(d time.Duration) { _ = c.SetDeadline(time.Now().Add(d)) }
|
||||||
r := agentAskReply{User: user}
|
_ = json.NewEncoder(c).Encode(askAnswer(askPeer{UID: uid, Name: user}, req, extend,
|
||||||
if link, err := consoleLaneEntry(uid, user); err != nil {
|
func() int { return askPeerPIDFn(c) }))
|
||||||
|
}
|
||||||
|
|
||||||
|
// askUnattributable is the answer to a connection whose account the
|
||||||
|
// operating system would not name.
|
||||||
|
func askUnattributable(err error) agentAskReply {
|
||||||
|
return agentAskReply{Why: "this machine could not establish who is asking (" + err.Error() +
|
||||||
|
"), so nothing was asked. An ask nobody can attribute is one nobody can answer."}
|
||||||
|
}
|
||||||
|
|
||||||
|
// askAnswer is the lane's answer to one request from peer, on either
|
||||||
|
// platform: ask.sock here, the ask pipe on Windows. extend gives the answer
|
||||||
|
// more time where it takes longer (a read, an act); pid is the connecting
|
||||||
|
// process, asked only for a stop.
|
||||||
|
func askAnswer(peer askPeer, req agentAskRequest, extend func(time.Duration), pid func() int) any {
|
||||||
|
switch req.Op {
|
||||||
|
case "console":
|
||||||
|
r := agentAskReply{User: peer.Name}
|
||||||
|
if link, err := consoleLaneEntryFor(peer); err != nil {
|
||||||
r.Why = err.Error()
|
r.Why = err.Error()
|
||||||
} else {
|
} else {
|
||||||
r.OK, r.URL = true, link
|
r.OK, r.URL = true, link
|
||||||
}
|
}
|
||||||
_ = json.NewEncoder(c).Encode(r)
|
return r
|
||||||
return
|
case "status":
|
||||||
|
return askStatus(existingMachineFactorDir(), req.Request, peer.Name, false)
|
||||||
|
case "read":
|
||||||
|
extend(readDeadline)
|
||||||
|
return serveReadFor(peer, req)
|
||||||
|
case "act":
|
||||||
|
extend(30 * time.Second)
|
||||||
|
return serveActFor(peer, req)
|
||||||
}
|
}
|
||||||
if req.Op == "status" {
|
return fileAsk(req, peer.Name, pid())
|
||||||
_ = json.NewEncoder(c).Encode(askStatus(existingMachineFactorDir(), req.Request, user, false))
|
|
||||||
return
|
|
||||||
}
|
|
||||||
if req.Op == "read" {
|
|
||||||
_ = c.SetDeadline(time.Now().Add(readDeadline))
|
|
||||||
_ = json.NewEncoder(c).Encode(serveRead(uid, user, req))
|
|
||||||
return
|
|
||||||
}
|
|
||||||
_ = json.NewEncoder(c).Encode(fileAsk(req, user, askPeerPIDFn(c)))
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// fileAsk turns one ask into a pending request of the machine, or says why not.
|
// fileAsk turns one ask into a pending request of the machine, or says why not.
|
||||||
@@ -247,10 +275,7 @@ func askPendingBy(dir, user, purpose string) (n int, same bool) {
|
|||||||
// askViaSock is the asking side: `stop` run where it cannot write the
|
// askViaSock is the asking side: `stop` run where it cannot write the
|
||||||
// machine's state itself.
|
// machine's state itself.
|
||||||
func askViaSock(req agentAskRequest) (agentAskReply, error) {
|
func askViaSock(req agentAskRequest) (agentAskReply, error) {
|
||||||
if runtime.GOOS == "windows" {
|
c, err := dialAskLane(askSockPath())
|
||||||
return agentAskReply{}, errors.New("asking another account's bastion is not built for Windows yet")
|
|
||||||
}
|
|
||||||
c, err := net.DialTimeout("unix", askSockPath(), 3*time.Second)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return agentAskReply{}, err
|
return agentAskReply{}, err
|
||||||
}
|
}
|
||||||
|
|||||||
+6
-3
@@ -528,10 +528,13 @@ type beatLanes struct {
|
|||||||
// noCoders: a tcp pairing, whose coder runs have no control plane to use
|
// noCoders: a tcp pairing, whose coder runs have no control plane to use
|
||||||
// (pair_tcp.go coderTransportRefusal), so it is never offered one.
|
// (pair_tcp.go coderTransportRefusal), so it is never offered one.
|
||||||
noCoders bool
|
noCoders bool
|
||||||
|
// dcnDir: the pairing's DCN state, whose managed agents this beat probes
|
||||||
|
// and reports (faManagedProbe, faManagedStatus); "" reports none.
|
||||||
|
dcnDir string
|
||||||
}
|
}
|
||||||
|
|
||||||
func beatLanesFor(cfg *Config) beatLanes {
|
func beatLanesFor(cfg *Config) beatLanes {
|
||||||
return beatLanes{local: cfg.localTransport(), noCoders: cfg.tcpTransport()}
|
return beatLanes{local: cfg.localTransport(), noCoders: cfg.tcpTransport(), dcnDir: cfg.dcnDir()}
|
||||||
}
|
}
|
||||||
|
|
||||||
// buildHeartbeatBodyOn is buildHeartbeatBody for a pairing whose lanes are lanes.
|
// buildHeartbeatBodyOn is buildHeartbeatBody for a pairing whose lanes are lanes.
|
||||||
@@ -658,7 +661,7 @@ func buildHeartbeatBodyOn(lanes beatLanes, self, hostname, platform, version, wg
|
|||||||
faAdvertised, faOK := freeagentProbe()
|
faAdvertised, faOK := freeagentProbe()
|
||||||
// managed instances (freeagent_managed.go) count the same way: any
|
// managed instances (freeagent_managed.go) count the same way: any
|
||||||
// serving instance advertises the capability; all must serve for ok
|
// serving instance advertises the capability; all must serve for ok
|
||||||
if mAdv, mOK := faManagedProbe(); mAdv {
|
if mAdv, mOK := faManagedProbe(lanes.dcnDir); mAdv {
|
||||||
if !faAdvertised {
|
if !faAdvertised {
|
||||||
faAdvertised, faOK = true, mOK
|
faAdvertised, faOK = true, mOK
|
||||||
} else {
|
} else {
|
||||||
@@ -1067,7 +1070,7 @@ func buildHeartbeatBodyOn(lanes beatLanes, self, hostname, platform, version, wg
|
|||||||
}
|
}
|
||||||
if faAdvertised {
|
if faAdvertised {
|
||||||
body["freeagent_ok"] = faOK
|
body["freeagent_ok"] = faOK
|
||||||
if st := faManagedStatus(); len(st) > 0 {
|
if st := faManagedStatus(lanes.dcnDir); len(st) > 0 {
|
||||||
body["freeagent_stores"] = st
|
body["freeagent_stores"] = st
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
+122
-3
@@ -18,11 +18,14 @@ import (
|
|||||||
"os"
|
"os"
|
||||||
"path/filepath"
|
"path/filepath"
|
||||||
"sort"
|
"sort"
|
||||||
|
"strconv"
|
||||||
"strings"
|
"strings"
|
||||||
"time"
|
"time"
|
||||||
|
"unicode"
|
||||||
)
|
)
|
||||||
|
|
||||||
const agentsUsage = "usage: privatae-bastion agents [--json] [--prompts]"
|
const agentsUsage = "usage: privatae-bastion agents [--json] [--prompts]\n" +
|
||||||
|
" privatae-bastion agents show <pid|session> [--json] [--prompts]"
|
||||||
|
|
||||||
var familyLabels = map[string]string{
|
var familyLabels = map[string]string{
|
||||||
"claude-code": "Claude Code", "aider": "aider", "goose": "goose", "cline": "Cline",
|
"claude-code": "Claude Code", "aider": "aider", "goose": "goose", "cline": "Cline",
|
||||||
@@ -75,6 +78,13 @@ func readAgents(o readOpts) (agentsRead, error) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func cmdAgents(args []string) error {
|
func cmdAgents(args []string) error {
|
||||||
|
show := ""
|
||||||
|
if len(args) >= 1 && args[0] == "show" {
|
||||||
|
if len(args) < 2 || strings.HasPrefix(args[1], "--") {
|
||||||
|
return errors.New(agentsUsage)
|
||||||
|
}
|
||||||
|
show, args = args[1], args[2:]
|
||||||
|
}
|
||||||
asJSON, prompts := false, false
|
asJSON, prompts := false, false
|
||||||
for _, a := range args {
|
for _, a := range args {
|
||||||
switch a {
|
switch a {
|
||||||
@@ -90,6 +100,17 @@ func cmdAgents(args []string) error {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
if show != "" {
|
||||||
|
a, err := pickAgentView(v.Agents, show)
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
if asJSON {
|
||||||
|
return printJSON(os.Stdout, a)
|
||||||
|
}
|
||||||
|
printAgentDetail(os.Stdout, a, sessionNowFn())
|
||||||
|
return nil
|
||||||
|
}
|
||||||
if asJSON {
|
if asJSON {
|
||||||
return printJSON(os.Stdout, v)
|
return printJSON(os.Stdout, v)
|
||||||
}
|
}
|
||||||
@@ -97,6 +118,104 @@ func cmdAgents(args []string) error {
|
|||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// pickAgentView is the agent `agents show` means: a pid, or a session's
|
||||||
|
// name as `agents` shows it, which must match exactly one (the rule `stop`
|
||||||
|
// keeps, resolveStopTarget).
|
||||||
|
func pickAgentView(views []agentView, key string) (agentView, error) {
|
||||||
|
if pid, err := strconv.Atoi(key); err == nil {
|
||||||
|
for _, v := range views {
|
||||||
|
if v.PID == pid {
|
||||||
|
return v, nil
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return agentView{}, fmt.Errorf("no AI agent here has pid %d; `privatae-bastion agents` lists them", pid)
|
||||||
|
}
|
||||||
|
var hits []agentView
|
||||||
|
for _, v := range views {
|
||||||
|
if v.Self != nil && v.Self.Name == key {
|
||||||
|
hits = append(hits, v)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
switch len(hits) {
|
||||||
|
case 0:
|
||||||
|
return agentView{}, fmt.Errorf("no running session is named %q; `privatae-bastion agents` lists them", key)
|
||||||
|
case 1:
|
||||||
|
return hits[0], nil
|
||||||
|
}
|
||||||
|
return agentView{}, fmt.Errorf("%d sessions are named %q; give the pid instead", len(hits), key)
|
||||||
|
}
|
||||||
|
|
||||||
|
// printAgentDetail is one agent with everything a read holds about it: the
|
||||||
|
// lines `agents` prints, then what it is, how it was recognised, and what it
|
||||||
|
// says about itself. Its command line is in --json only: arguments can carry
|
||||||
|
// a key, and words are what gets pasted.
|
||||||
|
func printAgentDetail(w io.Writer, v agentView, now time.Time) {
|
||||||
|
if v.Role == "service" {
|
||||||
|
fmt.Fprintf(w, "background service (pid %d): starts background sessions; not a session itself\n", v.PID)
|
||||||
|
} else {
|
||||||
|
l := agentLinesOf(v, now)
|
||||||
|
fmt.Fprintln(w, l.Head)
|
||||||
|
if l.State != "" {
|
||||||
|
fmt.Fprintln(w, " "+l.State)
|
||||||
|
}
|
||||||
|
if l.Where != "" {
|
||||||
|
fmt.Fprintln(w, " "+l.Where)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
row := func(k, val string) {
|
||||||
|
if val != "" {
|
||||||
|
fmt.Fprintf(w, " %-15s %s\n", k+":", val)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
row("agent", familyLabel(v.Signature))
|
||||||
|
row("kind", v.Kind)
|
||||||
|
row("pid", strconv.Itoa(v.PID))
|
||||||
|
if v.PPID > 0 {
|
||||||
|
row("parent pid", strconv.Itoa(v.PPID))
|
||||||
|
}
|
||||||
|
// The kernel names the file, but whoever placed it chose its path.
|
||||||
|
row("program", shownPath(v.Exe))
|
||||||
|
if v.Exe == "" {
|
||||||
|
row("program", "unknown (the system did not say which file it runs)")
|
||||||
|
}
|
||||||
|
row("account", v.User)
|
||||||
|
if len(v.RunningNow) > 0 {
|
||||||
|
row("running now", strings.Join(v.RunningNow, "; "))
|
||||||
|
}
|
||||||
|
if len(v.ToolServers) > 0 {
|
||||||
|
row("tool servers", strings.Join(v.ToolServers, ", "))
|
||||||
|
}
|
||||||
|
if s := v.Self; s != nil {
|
||||||
|
src := s.Source
|
||||||
|
if s.Verified {
|
||||||
|
src += " (names this process)"
|
||||||
|
} else {
|
||||||
|
src += " (does not name this process)"
|
||||||
|
}
|
||||||
|
row("self-reported", src)
|
||||||
|
row("session id", s.SessionID)
|
||||||
|
row("last asked", quoteIf(s.LastPrompt))
|
||||||
|
}
|
||||||
|
fmt.Fprintln(w, "Names, titles and statuses are what the agent says about itself.")
|
||||||
|
}
|
||||||
|
|
||||||
|
// shownPath is a path the agent chose (its folder) or placed (the file it
|
||||||
|
// runs), as printed: quoted when it holds control characters, so an escape
|
||||||
|
// sequence in a name never reaches the terminal or the page.
|
||||||
|
func shownPath(p string) string {
|
||||||
|
if strings.ContainsFunc(p, unicode.IsControl) {
|
||||||
|
return strconv.Quote(p)
|
||||||
|
}
|
||||||
|
return p
|
||||||
|
}
|
||||||
|
|
||||||
|
func quoteIf(s string) string {
|
||||||
|
if s == "" {
|
||||||
|
return ""
|
||||||
|
}
|
||||||
|
return "\"" + s + "\""
|
||||||
|
}
|
||||||
|
|
||||||
// printAgents writes the views grouped by agent, sessions waiting for the
|
// printAgents writes the views grouped by agent, sessions waiting for the
|
||||||
// person first, apps last.
|
// person first, apps last.
|
||||||
func printAgents(w io.Writer, views []agentView, now time.Time) {
|
func printAgents(w io.Writer, views []agentView, now time.Time) {
|
||||||
@@ -228,7 +347,7 @@ func agentLinesOf(v agentView, now time.Time) agentLines {
|
|||||||
// No session record: name it by what it is and where it works.
|
// No session record: name it by what it is and where it works.
|
||||||
l.Head = familyLabel(v.Signature)
|
l.Head = familyLabel(v.Signature)
|
||||||
if v.Folder != "" {
|
if v.Folder != "" {
|
||||||
l.Head += " in " + filepath.Base(v.Folder)
|
l.Head += " in " + shownPath(filepath.Base(v.Folder))
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
if v.Kind == kindApp {
|
if v.Kind == kindApp {
|
||||||
@@ -255,7 +374,7 @@ func agentLinesOf(v agentView, now time.Time) agentLines {
|
|||||||
l.State = strings.Join(state, " · ")
|
l.State = strings.Join(state, " · ")
|
||||||
var where []string
|
var where []string
|
||||||
if v.Folder != "" {
|
if v.Folder != "" {
|
||||||
f := "in " + v.Folder
|
f := "in " + shownPath(v.Folder)
|
||||||
if v.GitBranch != "" {
|
if v.GitBranch != "" {
|
||||||
f += " (" + v.GitBranch + ")"
|
f += " (" + v.GitBranch + ")"
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -380,7 +380,7 @@ func gitBranchOf(dir string) string {
|
|||||||
return cleanText(b, 80)
|
return cleanText(b, 80)
|
||||||
}
|
}
|
||||||
if len(h) >= 12 {
|
if len(h) >= 12 {
|
||||||
return "detached at " + h[:12]
|
return "detached at " + cleanText(h[:12], 12)
|
||||||
}
|
}
|
||||||
return ""
|
return ""
|
||||||
}
|
}
|
||||||
|
|||||||
+98
-10
@@ -799,13 +799,46 @@ func lastOK(host string) time.Time {
|
|||||||
|
|
||||||
// pairingEntry is one pairing on this box as told to the ANCHOR host: name,
|
// pairingEntry is one pairing on this box as told to the ANCHOR host: name,
|
||||||
// handle, state, since. Same privacy line as peers.go — never keys or grants.
|
// handle, state, since. Same privacy line as peers.go — never keys or grants.
|
||||||
|
//
|
||||||
|
// For a pairing that waits to be admitted it also says what the anchor Host
|
||||||
|
// needs to raise the approval prompt for the person (C-Series: the Network
|
||||||
|
// app's pending pairing, approved with approve_pairing):
|
||||||
|
//
|
||||||
|
// waiting_for the Host that admits it: the anchor, which reads its own
|
||||||
|
// name here (anchor_local.go admitter)
|
||||||
|
// transport how its lanes would run: "tunnel" (WireGuard through the
|
||||||
|
// relay, a Cloud Host), "tcp" (a Host's lane port) or "unix"
|
||||||
|
// (a socket on this machine)
|
||||||
|
// same_machine its Host runs on this machine (anchor_local.go
|
||||||
|
// sameMachineHost)
|
||||||
|
// origin how it came: "paired" (a code redeemed at this machine),
|
||||||
|
// "carried" (moved in from an account's own bastion when the
|
||||||
|
// machine moved to the system service, servicecarry.go), or
|
||||||
|
// "former_anchor" (it was in charge of this machine until a
|
||||||
|
// Host the rules put first took over, anchor_local.go)
|
||||||
|
//
|
||||||
|
// The approval itself is unchanged: pairing_grant_sync with terms the anchor
|
||||||
|
// signs, {kind: pairing_grant, server: the beat's hostname, anchor: this
|
||||||
|
// beat's anchor.anchor_host, subject: host_name, subject_handle: handle, caps,
|
||||||
|
// issued_at, expires}, over the anchor's own mgmt lane (pairing_ops.go).
|
||||||
type pairingEntry struct {
|
type pairingEntry struct {
|
||||||
HostName string `json:"host_name"`
|
HostName string `json:"host_name"`
|
||||||
Handle string `json:"handle"`
|
Handle string `json:"handle"`
|
||||||
State string `json:"state"`
|
State string `json:"state"`
|
||||||
Since string `json:"since,omitempty"`
|
Since string `json:"since,omitempty"`
|
||||||
|
WaitingFor string `json:"waiting_for,omitempty"`
|
||||||
|
Transport string `json:"transport,omitempty"`
|
||||||
|
SameMachine bool `json:"same_machine,omitempty"`
|
||||||
|
Origin string `json:"origin,omitempty"`
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// The origins pairingEntry reports.
|
||||||
|
const (
|
||||||
|
pairingOriginPaired = "paired"
|
||||||
|
pairingOriginCarried = "carried"
|
||||||
|
pairingOriginFormerAnchor = "former_anchor"
|
||||||
|
)
|
||||||
|
|
||||||
// pairingsReport lists EVERY pairing on the box, including the one asking.
|
// pairingsReport lists EVERY pairing on the box, including the one asking.
|
||||||
// "since" is first_seen — when the host was first paired here — kept across
|
// "since" is first_seen — when the host was first paired here — kept across
|
||||||
// --replace, so a pending host re-presenting a token keeps its original age
|
// --replace, so a pending host re-presenting a token keeps its original age
|
||||||
@@ -821,13 +854,41 @@ func pairingsReport() []pairingEntry {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
who := admitter()
|
||||||
|
replaced := ""
|
||||||
|
if p, err := anchorReplacedPath(); err == nil {
|
||||||
|
if raw, err := os.ReadFile(p); err == nil {
|
||||||
|
var r anchorReplaced
|
||||||
|
if json.Unmarshal(raw, &r) == nil {
|
||||||
|
replaced = r.Host
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
out := make([]pairingEntry, 0, len(cfgs))
|
out := make([]pairingEntry, 0, len(cfgs))
|
||||||
for _, c := range cfgs {
|
for _, c := range cfgs {
|
||||||
if c.HostName == "" || c.invalid != "" {
|
if c.HostName == "" || c.invalid != "" {
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
out = append(out, pairingEntry{HostName: c.HostName, Handle: handleOf(c.HostName),
|
e := pairingEntry{HostName: c.HostName, Handle: handleOf(c.HostName),
|
||||||
State: c.stateName(), Since: sinceOf(c)})
|
State: c.stateName(), Since: sinceOf(c)}
|
||||||
|
if c.State == pairingPending {
|
||||||
|
e.WaitingFor = who
|
||||||
|
e.Transport = "tunnel"
|
||||||
|
if c.unixTransport() {
|
||||||
|
e.Transport = "unix"
|
||||||
|
} else if c.tcpTransport() {
|
||||||
|
e.Transport = "tcp"
|
||||||
|
}
|
||||||
|
e.SameMachine = sameMachineHost(c)
|
||||||
|
e.Origin = pairingOriginPaired
|
||||||
|
if c.Origin == pairingOriginCarried {
|
||||||
|
e.Origin = pairingOriginCarried
|
||||||
|
}
|
||||||
|
if replaced != "" && replaced == c.HostName {
|
||||||
|
e.Origin = pairingOriginFormerAnchor
|
||||||
|
}
|
||||||
|
}
|
||||||
|
out = append(out, e)
|
||||||
}
|
}
|
||||||
return out
|
return out
|
||||||
}
|
}
|
||||||
@@ -855,7 +916,7 @@ func unapprovedAttempts(now time.Time) []peerAnnounce {
|
|||||||
if err != nil || now.Sub(since) < unapprovedAfter {
|
if err != nil || now.Sub(since) < unapprovedAfter {
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
out = append(out, peerAnnounce(e))
|
out = append(out, peerAnnounce{HostName: e.HostName, Handle: e.Handle, State: e.State, Since: e.Since})
|
||||||
}
|
}
|
||||||
return out
|
return out
|
||||||
}
|
}
|
||||||
@@ -874,6 +935,16 @@ func pairingEnforcing(self string) map[string]any {
|
|||||||
return out
|
return out
|
||||||
}
|
}
|
||||||
out["pairing_state"] = c.stateName()
|
out["pairing_state"] = c.stateName()
|
||||||
|
// A Host the rules put first took the anchor from this one (anchor_local.go):
|
||||||
|
// {by, at, why, waiting_for}. Its last beat before its lanes stop carries it.
|
||||||
|
if note := anchorReplacedNote(self); note != nil {
|
||||||
|
out["anchor_replaced"] = note
|
||||||
|
}
|
||||||
|
if c.State == pairingPending {
|
||||||
|
if who := admitter(); who != "" {
|
||||||
|
out["waiting_for"] = who
|
||||||
|
}
|
||||||
|
}
|
||||||
// The name THIS pairing is known by on this box — what a reach grant must
|
// The name THIS pairing is known by on this box — what a reach grant must
|
||||||
// name as its subject (service_reach.go). A host can hold more than one name
|
// name as its subject (service_reach.go). A host can hold more than one name
|
||||||
// (a legacy one and the current one); this says which one the box enforces.
|
// (a legacy one and the current one); this says which one the box enforces.
|
||||||
@@ -1001,7 +1072,7 @@ func anchorAlreadyHolds(cfgs []*Config, prev *anchorClaim, host string) bool {
|
|||||||
// pickPairing resolves --host against this box's pairings. It accepts the full
|
// pickPairing resolves --host against this box's pairings. It accepts the full
|
||||||
// host_name the box reports, or just the handle in front of it, because the
|
// host_name the box reports, or just the handle in front of it, because the
|
||||||
// name the user is looking at depends on which surface they read it from —
|
// name the user is looking at depends on which surface they read it from —
|
||||||
// `8abb770bbfde71d0` in Circles, `8abb770bbfde71d0.host.privatae.ai` in the
|
// `1b2c3d4e5f607182` in Circles, `1b2c3d4e5f607182.host.privatae.ai` in the
|
||||||
// claim-anchor error. Refusing the short form would mean refusing the thing the
|
// claim-anchor error. Refusing the short form would mean refusing the thing the
|
||||||
// user most obviously typed.
|
// user most obviously typed.
|
||||||
func pickPairing(cfgs []*Config, want string) (*Config, error) {
|
func pickPairing(cfgs []*Config, want string) (*Config, error) {
|
||||||
@@ -1041,6 +1112,12 @@ func cmdClaimAnchor(token string, rotate bool, owner, host string) error {
|
|||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
prev := currentAnchor()
|
prev := currentAnchor()
|
||||||
|
// Which Host is in charge (anchor_local.go): the one an organisation's
|
||||||
|
// policy names, else a Host on this machine. Either decides here, before
|
||||||
|
// the paths below, which know only "the box's pairings".
|
||||||
|
if handled, err := claimAnchorByRule(cfgs, prev, token, rotate, owner, host); handled {
|
||||||
|
return err
|
||||||
|
}
|
||||||
// Already anchored to the host this asks for (no token, no other host
|
// Already anchored to the host this asks for (no token, no other host
|
||||||
// named), and that host's pairing is active: done, not an error. `pair`
|
// named), and that host's pairing is active: done, not an error. `pair`
|
||||||
// anchors a networked box to its first host by itself, and an installer
|
// anchors a networked box to its first host by itself, and an installer
|
||||||
@@ -1236,11 +1313,22 @@ func cmdClaimAnchor(token string, rotate bool, owner, host string) error {
|
|||||||
// singleton on each one as it goes, rather than needing a separate pass.
|
// singleton on each one as it goes, rather than needing a separate pass.
|
||||||
_ = maybeWriteMarker()
|
_ = maybeWriteMarker()
|
||||||
fmt.Printf("anchored to %s (owner %q)\n", cfg.HostName, owner)
|
fmt.Printf("anchored to %s (owner %q)\n", cfg.HostName, owner)
|
||||||
fmt.Println(" Every host paired from now on waits, pending, until this anchor host approves it.")
|
fmt.Printf(" Every Host paired from now on waits until %s admits it: %s asks you to approve it.\n", cfg.HostName, cfg.HostName)
|
||||||
fmt.Println(" " + restartHint())
|
fmt.Println(" " + anchorFollowNote())
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// anchorFollowNote says how the change reaches the bastion: a running one
|
||||||
|
// reads the anchor on every op and follows the pairing files within
|
||||||
|
// supervisePeriod, so nothing is restarted.
|
||||||
|
func anchorFollowNote() string {
|
||||||
|
if pairDaemonRunning() {
|
||||||
|
return fmt.Sprintf("The bastion running on this machine follows within %d seconds; nothing needs restarting.",
|
||||||
|
int(supervisePeriod.Seconds()))
|
||||||
|
}
|
||||||
|
return "Start the bastion so it serves it: " + runCommandHint()
|
||||||
|
}
|
||||||
|
|
||||||
// writeAnchor signs and installs anchor.json under the box key. A fresh anchor
|
// writeAnchor signs and installs anchor.json under the box key. A fresh anchor
|
||||||
// (or a rotated one) starts with NO verify key: the new anchor host's key is
|
// (or a rotated one) starts with NO verify key: the new anchor host's key is
|
||||||
// pinned on first contact, never carried over from the previous host.
|
// pinned on first contact, never carried over from the previous host.
|
||||||
|
|||||||
@@ -0,0 +1,537 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
// anchor_local.go — who is in charge of this machine: one authoritative Host,
|
||||||
|
// the anchor (anchor.go), and which Host that is.
|
||||||
|
//
|
||||||
|
// A machine needs one authoritative Host, and the code already has that: the
|
||||||
|
// anchor. The anchor is still the one mechanism, with its signature and
|
||||||
|
// verification model unchanged (writeAnchor signs it
|
||||||
|
// under the box key; grants verify under the anchor Host's pinned key). What
|
||||||
|
// this file decides is WHICH Host holds it, by three rules, strongest first:
|
||||||
|
//
|
||||||
|
// 1. An ORGANISATION'S POLICY, explicitly deployed to the machine, names the
|
||||||
|
// Host in charge (anchorPolicy below). It is the only thing that overrides
|
||||||
|
// the rule after it, and it is meant for a machine owned by someone other
|
||||||
|
// than its local admin. Windows: the AnchorHost value under
|
||||||
|
// HKLM\SOFTWARE\Policies\Privatae\Bastion (Group Policy, Intune). macOS:
|
||||||
|
// the AnchorHost key of the managed preference domain ai.privatae.bastion
|
||||||
|
// (a configuration profile). Linux: anchor_host in the root-owned
|
||||||
|
// /etc/privatae-bastion/policy.json. Joining a domain is not a policy:
|
||||||
|
// nothing is read from the domain itself. With a policy, claim-anchor for
|
||||||
|
// any other Host is refused in words that say an organisation manages the
|
||||||
|
// machine, a new pairing of another Host waits for the named one, and the
|
||||||
|
// named one takes the anchor when it is paired with machine authority.
|
||||||
|
// 2. A HOST ON THIS MACHINE is always the one in charge, never "whichever
|
||||||
|
// paired first". Paired with machine authority it takes the anchor, from a
|
||||||
|
// remote anchor too; the replaced anchor becomes an ordinary pairing that
|
||||||
|
// waits for it to admit it (as claim-anchor --rotate leaves the old one),
|
||||||
|
// the change is recorded in the pairing audit, and the replaced anchor is
|
||||||
|
// told on one last heartbeat (anchorReplacedNote, run.go superviseOnce).
|
||||||
|
// A Host on this machine that already holds the anchor keeps it: a second
|
||||||
|
// one waits, as any other pairing does, and moving the anchor between two
|
||||||
|
// of them is claim-anchor --rotate as before.
|
||||||
|
// 3. Otherwise the first Host paired with a networked machine (cmdPair, as
|
||||||
|
// before this file).
|
||||||
|
//
|
||||||
|
// WHAT "ON THIS MACHINE" IS (sameMachineHost). A pairing whose lanes run over
|
||||||
|
// a unix socket (transport unix): the socket is a file on this machine's own
|
||||||
|
// disk. Or a pairing whose lane port is a loopback address (transport tcp,
|
||||||
|
// lane_addr 127.0.0.0/8, ::1 or localhost): loopback never leaves this
|
||||||
|
// machine's network stack, and it is how a C-Series Host in a VM on this
|
||||||
|
// computer is reached (npx cseries forwards the VM's lane ports to loopback,
|
||||||
|
// packages/cseries/src/vm/common.js). Something else forwarded onto loopback
|
||||||
|
// is something the machine's administrator set up, and taking the anchor needs
|
||||||
|
// that administrator's authority anyway. Any other address, a LAN one
|
||||||
|
// included, is another machine. The name the Host gives itself
|
||||||
|
// (home.cseries.localhost) is not used: it is the Host's word, not the
|
||||||
|
// machine's.
|
||||||
|
//
|
||||||
|
// It adds no power. With machine authority an administrator could already
|
||||||
|
// claim the anchor on an unanchored box, delete anchor.json, or release an
|
||||||
|
// anchor (anchor_release.go). What it changes is that the right Host is put in
|
||||||
|
// charge without anyone having to know the order things were paired in.
|
||||||
|
|
||||||
|
import (
|
||||||
|
"encoding/json"
|
||||||
|
"fmt"
|
||||||
|
"net"
|
||||||
|
"os"
|
||||||
|
"path/filepath"
|
||||||
|
"strings"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
// anchorPolicy is an organisation's deployed policy naming the Host in charge.
|
||||||
|
type anchorPolicy struct {
|
||||||
|
Host string // a host_name, or its handle
|
||||||
|
Source string // where it was read, as a person would look for it
|
||||||
|
}
|
||||||
|
|
||||||
|
// readAnchorPolicy reads the policy from this platform's managed store
|
||||||
|
// (anchorpolicy_*.go). A seam: the suite sets a policy without one.
|
||||||
|
var readAnchorPolicy = readAnchorPolicyOS
|
||||||
|
|
||||||
|
// currentAnchorPolicy is the deployed policy, or nil when there is none or it
|
||||||
|
// names nothing a host name can be.
|
||||||
|
func currentAnchorPolicy() *anchorPolicy {
|
||||||
|
p := readAnchorPolicy()
|
||||||
|
if p == nil {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
p.Host = strings.TrimSpace(p.Host)
|
||||||
|
if !validHostName(p.Host) {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
return p
|
||||||
|
}
|
||||||
|
|
||||||
|
// policyNames says whether the policy names host (its full name or handle).
|
||||||
|
func policyNames(p *anchorPolicy, host string) bool {
|
||||||
|
if p == nil || host == "" {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
return strings.EqualFold(p.Host, host) || strings.EqualFold(p.Host, handleOf(host)) ||
|
||||||
|
strings.EqualFold(handleOf(p.Host), host)
|
||||||
|
}
|
||||||
|
|
||||||
|
// orgManagedRefusal is the words for a Host the policy does not name.
|
||||||
|
func orgManagedRefusal(p *anchorPolicy, who string) error {
|
||||||
|
return fmt.Errorf("an organisation manages this machine: its policy (%s) names %s as the Host in charge of it, "+
|
||||||
|
"so %s cannot take charge here. Whoever manages this machine for the organisation changes that policy", p.Source, p.Host, who)
|
||||||
|
}
|
||||||
|
|
||||||
|
// sameMachineHost: the pairing's Host runs on this machine (see the header).
|
||||||
|
func sameMachineHost(c *Config) bool {
|
||||||
|
if c == nil {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
if c.unixTransport() {
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
if !c.tcpTransport() {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
return loopbackAddr(c.LaneAddr)
|
||||||
|
}
|
||||||
|
|
||||||
|
// loopbackAddr: host:port whose host is a loopback IP literal or localhost.
|
||||||
|
func loopbackAddr(hostPort string) bool {
|
||||||
|
h, _, err := net.SplitHostPort(strings.TrimSpace(hostPort))
|
||||||
|
if err != nil {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
if strings.EqualFold(h, "localhost") {
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
ip := net.ParseIP(h)
|
||||||
|
return ip != nil && ip.IsLoopback()
|
||||||
|
}
|
||||||
|
|
||||||
|
// admitter is the Host a pending pairing waits for: the anchor, or on a
|
||||||
|
// machine an organisation's policy governs and nobody holds yet, the Host the
|
||||||
|
// policy names. "" when nothing on this machine admits anyone.
|
||||||
|
func admitter() string {
|
||||||
|
if a := currentAnchor(); a != nil {
|
||||||
|
return a.AnchorHost
|
||||||
|
}
|
||||||
|
if boxMode() == modeNetworked {
|
||||||
|
if p := currentAnchorPolicy(); p != nil {
|
||||||
|
return p.Host
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return ""
|
||||||
|
}
|
||||||
|
|
||||||
|
// pendingUnderPolicy: on a networked machine with no anchor yet, a policy
|
||||||
|
// that names another Host makes a new pairing wait for that one.
|
||||||
|
func pendingUnderPolicy(handle string) bool {
|
||||||
|
if boxMode() != modeNetworked || currentAnchor() != nil {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
p := currentAnchorPolicy()
|
||||||
|
return p != nil && !policyNames(p, handle)
|
||||||
|
}
|
||||||
|
|
||||||
|
// anchorTake is what taking the anchor did, for `pair` and claim-anchor to say.
|
||||||
|
type anchorTake struct {
|
||||||
|
Taken bool
|
||||||
|
Why string // the rule, in words
|
||||||
|
Replaced string // the previous anchor, if there was one
|
||||||
|
Waiting []string // pairings that now wait for the new anchor to admit them
|
||||||
|
}
|
||||||
|
|
||||||
|
// The rules by name, in the audit and on the replaced anchor's beat.
|
||||||
|
const (
|
||||||
|
anchorWhyPolicy = "policy"
|
||||||
|
anchorWhyLocal = "same_machine"
|
||||||
|
anchorWhyFirst = "first_pairing"
|
||||||
|
)
|
||||||
|
|
||||||
|
func anchorWhyWords(why string, c *Config, p *anchorPolicy) string {
|
||||||
|
switch why {
|
||||||
|
case anchorWhyPolicy:
|
||||||
|
return "an organisation's policy (" + p.Source + ") names it as the Host in charge of this machine"
|
||||||
|
case anchorWhyLocal:
|
||||||
|
return "it runs on this machine (" + c.laneWhere() + "), and a Host on the machine is always the one in charge of it"
|
||||||
|
case anchorWhyWindow:
|
||||||
|
return "you opened the pairing window for it here (`pair --open`), and no Host was in charge of this machine"
|
||||||
|
}
|
||||||
|
return "it is the first Host paired with this networked machine"
|
||||||
|
}
|
||||||
|
|
||||||
|
// anchorAfterPair puts the right Host in charge after `pair` wrote cfg (see the
|
||||||
|
// header). Only on a networked machine and with machine authority, which
|
||||||
|
// claim-anchor needs anyway. Reports what it did.
|
||||||
|
func anchorAfterPair(cfg *Config, all []*Config) (anchorTake, error) {
|
||||||
|
if cfg == nil || boxMode() != modeNetworked || !machineAuthorityHeld() {
|
||||||
|
return anchorTake{}, nil
|
||||||
|
}
|
||||||
|
prev := currentAnchor()
|
||||||
|
if prev != nil && prev.AnchorHost == cfg.HostName {
|
||||||
|
return anchorTake{}, nil
|
||||||
|
}
|
||||||
|
pol := currentAnchorPolicy()
|
||||||
|
why := ""
|
||||||
|
switch {
|
||||||
|
case pol != nil:
|
||||||
|
if !policyNames(pol, cfg.HostName) {
|
||||||
|
return anchorTake{}, nil
|
||||||
|
}
|
||||||
|
why = anchorWhyPolicy
|
||||||
|
case sameMachineHost(cfg):
|
||||||
|
if prev != nil {
|
||||||
|
if pc := pairingFor(all, prev.AnchorHost); pc != nil && sameMachineHost(pc) && pc.active() {
|
||||||
|
// A Host on this machine already holds it: this one waits.
|
||||||
|
return anchorTake{}, nil
|
||||||
|
}
|
||||||
|
}
|
||||||
|
why = anchorWhyLocal
|
||||||
|
case prev == nil && len(all) == 1:
|
||||||
|
why = anchorWhyFirst
|
||||||
|
default:
|
||||||
|
return anchorTake{}, nil
|
||||||
|
}
|
||||||
|
t, err := takeAnchor(cfg, prev, why, pol, "")
|
||||||
|
if err != nil {
|
||||||
|
return anchorTake{}, fmt.Errorf("paired with %s, but putting it in charge of this machine failed: %w\n anchor it with: %s",
|
||||||
|
cfg.HostName, err, anchorCommandHint())
|
||||||
|
}
|
||||||
|
return t, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// anchorWhyWindow: the person opened a pairing window for this Host at this
|
||||||
|
// machine (`pair --open`), with machine authority, and nobody was in charge.
|
||||||
|
const anchorWhyWindow = "pair_open"
|
||||||
|
|
||||||
|
// anchorAfterWindow is anchorAfterPair for a Host paired through a window
|
||||||
|
// opened at this machine (pair_window.go). The window is the person's say-so,
|
||||||
|
// typed at this machine, for this one Host, so on a machine nobody is in
|
||||||
|
// charge of yet that Host takes the anchor, as the first Host of a networked
|
||||||
|
// machine does, whatever else is paired and in either mode. The rules above it
|
||||||
|
// still come first: an organisation's policy that names another Host leaves
|
||||||
|
// it waiting, and a Host on this machine wins (a paired one that is not
|
||||||
|
// revoked keeps the machine for itself, even before it holds the anchor).
|
||||||
|
//
|
||||||
|
// A LOCAL machine has no anchor (claim-anchor and set-mode refuse one there),
|
||||||
|
// so it is made networked first, which set-mode does with the same authority.
|
||||||
|
// On a local machine already serving another Host the person said yes to, the
|
||||||
|
// window's Host does not take it: that would leave the other one waiting.
|
||||||
|
//
|
||||||
|
// openerAuthority is whether the person who opened the window held machine
|
||||||
|
// authority; the process committing the pairing (pair --open's own door, or
|
||||||
|
// the running bastion's) must hold it too.
|
||||||
|
func anchorAfterWindow(cfg *Config, all []*Config, openerAuthority bool) (anchorTake, error) {
|
||||||
|
took, err := anchorAfterPair(cfg, all)
|
||||||
|
if err != nil || took.Taken {
|
||||||
|
return took, err
|
||||||
|
}
|
||||||
|
if cfg == nil || !openerAuthority || !machineAuthorityHeld() || currentAnchor() != nil ||
|
||||||
|
cfg.invalid != "" || cfg.State == pairingRevoked {
|
||||||
|
return anchorTake{}, nil
|
||||||
|
}
|
||||||
|
pol := currentAnchorPolicy()
|
||||||
|
why := anchorWhyWindow
|
||||||
|
if pol != nil {
|
||||||
|
if !policyNames(pol, cfg.HostName) {
|
||||||
|
return anchorTake{}, nil
|
||||||
|
}
|
||||||
|
why = anchorWhyPolicy
|
||||||
|
}
|
||||||
|
// On a networked machine nobody is in charge of, every pairing is refused
|
||||||
|
// every op (unanchoredNetworkedRefusal), so the others that takeAnchor
|
||||||
|
// leaves waiting lose nothing they had; they now have a Host to admit them.
|
||||||
|
// On a local machine the other Hosts are served, so they are not demoted.
|
||||||
|
local := boxMode() != modeNetworked
|
||||||
|
for _, o := range all {
|
||||||
|
if o.HostName == cfg.HostName {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
if why != anchorWhyPolicy && sameMachineHost(o) && o.invalid == "" && o.State != pairingRevoked {
|
||||||
|
return anchorTake{}, nil
|
||||||
|
}
|
||||||
|
if local && o.active() {
|
||||||
|
return anchorTake{}, nil
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if local {
|
||||||
|
if err := setBoxMode(modeNetworked); err != nil {
|
||||||
|
return anchorTake{}, fmt.Errorf("paired with %s, but making this machine one a Host is in charge of failed: %w", cfg.HostName, err)
|
||||||
|
}
|
||||||
|
pairingAudit("set_mode", cfg.HostName, "ok: networked, so the Host paired through the window opened here can be put in charge")
|
||||||
|
}
|
||||||
|
t, err := takeAnchor(cfg, nil, why, pol, "")
|
||||||
|
if err != nil {
|
||||||
|
return anchorTake{}, fmt.Errorf("paired with %s, but putting it in charge of this machine failed: %w\n anchor it with: %s",
|
||||||
|
cfg.HostName, err, anchorCommandHint())
|
||||||
|
}
|
||||||
|
return t, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// anchorReplaced is <configDir>/anchor.replaced.json: the last time a Host
|
||||||
|
// took the anchor from another. The replaced anchor's run reads it on its
|
||||||
|
// last beat (anchorReplacedNote); the audit keeps the history.
|
||||||
|
type anchorReplaced struct {
|
||||||
|
Host string `json:"host"` // the anchor that was replaced
|
||||||
|
By string `json:"by"`
|
||||||
|
At string `json:"at"`
|
||||||
|
Why string `json:"why"`
|
||||||
|
}
|
||||||
|
|
||||||
|
func anchorReplacedPath() (string, error) {
|
||||||
|
d, err := configDir()
|
||||||
|
if err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
return filepath.Join(d, "anchor.replaced.json"), nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// anchorReplacedNote is what the replaced anchor's heartbeat carries, or nil
|
||||||
|
// when self was not replaced as this machine's anchor.
|
||||||
|
func anchorReplacedNote(self string) map[string]any {
|
||||||
|
p, err := anchorReplacedPath()
|
||||||
|
if err != nil {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
raw, err := os.ReadFile(p)
|
||||||
|
if err != nil {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
var r anchorReplaced
|
||||||
|
if json.Unmarshal(raw, &r) != nil || r.Host == "" || r.Host != self {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
a := currentAnchor()
|
||||||
|
if a == nil || a.AnchorHost != r.By {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
return map[string]any{"by": r.By, "at": r.At, "why": r.Why, "waiting_for": r.By}
|
||||||
|
}
|
||||||
|
|
||||||
|
// clearAnchorReplacedFor removes the replaced-anchor record once that Host is
|
||||||
|
// admitted again.
|
||||||
|
func clearAnchorReplacedFor(host string) {
|
||||||
|
p, err := anchorReplacedPath()
|
||||||
|
if err != nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
raw, err := os.ReadFile(p)
|
||||||
|
if err != nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
var r anchorReplaced
|
||||||
|
if json.Unmarshal(raw, &r) == nil && r.Host == host {
|
||||||
|
_ = os.Remove(p)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// takeAnchor makes cfg this machine's anchor, under the box key as
|
||||||
|
// claim-anchor does (writeAnchor), and every other pairing that was served an
|
||||||
|
// ordinary one waiting for it. A previous anchor is recorded as replaced.
|
||||||
|
// owner "" keeps the machine's owner name.
|
||||||
|
func takeAnchor(cfg *Config, prev *anchorClaim, why string, pol *anchorPolicy, owner string) (anchorTake, error) {
|
||||||
|
if cfg.invalid != "" {
|
||||||
|
return anchorTake{}, fmt.Errorf("%s cannot hold the anchor: %s", cfg.HostName, cfg.invalid)
|
||||||
|
}
|
||||||
|
if cfg.State == pairingRevoked {
|
||||||
|
return anchorTake{}, fmt.Errorf("%s is REVOKED on this box — it will not be put in charge; pair that Host again first (`privatae-bastion pair --replace <token>`)", cfg.HostName)
|
||||||
|
}
|
||||||
|
owner = strings.TrimSpace(owner)
|
||||||
|
if owner == "" {
|
||||||
|
if oc := currentOwnerClaim(); oc != nil && oc.Owner != "" {
|
||||||
|
owner = oc.Owner
|
||||||
|
} else if prev != nil {
|
||||||
|
owner = prev.Owner
|
||||||
|
} else {
|
||||||
|
owner = handleOf(cfg.HostName)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if err := claimNameOK(owner); err != nil {
|
||||||
|
return anchorTake{}, fmt.Errorf("owner: %w", err)
|
||||||
|
}
|
||||||
|
// The anchor never waits on itself.
|
||||||
|
if !cfg.active() {
|
||||||
|
if err := cfg.updateOnDisk(func(d *Config) { d.State = pairingActive }); err != nil {
|
||||||
|
return anchorTake{}, err
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if err := writeAnchor(owner, cfg.HostName); err != nil {
|
||||||
|
return anchorTake{}, err
|
||||||
|
}
|
||||||
|
if _, err := writeOwnerClaim(owner); err != nil {
|
||||||
|
return anchorTake{}, err
|
||||||
|
}
|
||||||
|
// A consent the old anchor left for a rotation is not this.
|
||||||
|
if p, err := anchorConsentPath(); err == nil {
|
||||||
|
_ = os.Remove(p)
|
||||||
|
}
|
||||||
|
t := anchorTake{Taken: true, Why: anchorWhyWords(why, cfg, pol)}
|
||||||
|
if prev != nil && prev.AnchorHost != cfg.HostName {
|
||||||
|
t.Replaced = prev.AnchorHost
|
||||||
|
}
|
||||||
|
// Every other pairing that was served now waits for the new anchor: a
|
||||||
|
// grant from the old one does not verify under the new one's key, so
|
||||||
|
// "active" would be lanes that refuse every op.
|
||||||
|
cfgs, err := loadPairings()
|
||||||
|
if err != nil {
|
||||||
|
return t, err
|
||||||
|
}
|
||||||
|
for _, c := range cfgs {
|
||||||
|
if c.HostName == cfg.HostName || !c.active() {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
if err := c.updateOnDisk(func(d *Config) { d.State = pairingPending }); err != nil {
|
||||||
|
return t, err
|
||||||
|
}
|
||||||
|
t.Waiting = append(t.Waiting, c.HostName)
|
||||||
|
}
|
||||||
|
at := time.Now().UTC().Format(time.RFC3339)
|
||||||
|
if t.Replaced != "" {
|
||||||
|
if p, err := anchorReplacedPath(); err == nil {
|
||||||
|
if b, err := json.MarshalIndent(anchorReplaced{Host: t.Replaced, By: cfg.HostName, At: at, Why: why}, "", " "); err == nil {
|
||||||
|
_ = atomicWrite(p, b)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
decision := "ok: in charge of this machine because " + t.Why
|
||||||
|
if t.Replaced != "" {
|
||||||
|
decision += "; it replaced " + t.Replaced
|
||||||
|
}
|
||||||
|
pairingAudit("anchor_take", cfg.HostName, decision)
|
||||||
|
for _, h := range t.Waiting {
|
||||||
|
pairingAudit("anchor_take", h, "waits for "+cfg.HostName+" to admit it")
|
||||||
|
}
|
||||||
|
_ = maybeWriteMarker()
|
||||||
|
kickBeats()
|
||||||
|
return t, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// claimAnchorByRule is claim-anchor's part of the rules in the header, before
|
||||||
|
// its own paths run. handled: the command's answer is err. Not handled: the
|
||||||
|
// rest of claim-anchor decides, as before.
|
||||||
|
func claimAnchorByRule(cfgs []*Config, prev *anchorClaim, token string, rotate bool, owner, host string) (bool, error) {
|
||||||
|
named := strings.TrimSpace(host)
|
||||||
|
if token != "" {
|
||||||
|
h, _, err := decodeToken(token)
|
||||||
|
if err != nil {
|
||||||
|
return true, err
|
||||||
|
}
|
||||||
|
named = h
|
||||||
|
}
|
||||||
|
if pol := currentAnchorPolicy(); pol != nil {
|
||||||
|
want := pairingFor(cfgs, pol.Host)
|
||||||
|
if want == nil {
|
||||||
|
for _, c := range cfgs {
|
||||||
|
if policyNames(pol, c.HostName) {
|
||||||
|
want = c
|
||||||
|
break
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if named != "" && !policyNames(pol, named) {
|
||||||
|
if c, err := pickPairing(cfgs, named); err != nil || want == nil || c.HostName != want.HostName {
|
||||||
|
return true, orgManagedRefusal(pol, named)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if token != "" {
|
||||||
|
return false, nil // the token names the Host the policy names
|
||||||
|
}
|
||||||
|
if want == nil {
|
||||||
|
return true, fmt.Errorf("an organisation manages this machine: its policy (%s) names %s as the Host in charge "+
|
||||||
|
"of it, and %s is not paired with this machine yet. Pair it (`privatae-bastion pair <its code>`) and it takes charge",
|
||||||
|
pol.Source, pol.Host, pol.Host)
|
||||||
|
}
|
||||||
|
if prev != nil && prev.AnchorHost == want.HostName && want.active() {
|
||||||
|
fmt.Printf("already anchored to %s (owner %q)\n", prev.AnchorHost, prev.Owner)
|
||||||
|
return true, nil
|
||||||
|
}
|
||||||
|
t, err := takeAnchor(want, prev, anchorWhyPolicy, pol, owner)
|
||||||
|
if err != nil {
|
||||||
|
return true, err
|
||||||
|
}
|
||||||
|
printAnchorTake(want.HostName, t)
|
||||||
|
return true, nil
|
||||||
|
}
|
||||||
|
if rotate {
|
||||||
|
return false, nil
|
||||||
|
}
|
||||||
|
var locals []*Config
|
||||||
|
for _, c := range cfgs {
|
||||||
|
if sameMachineHost(c) && c.invalid == "" && c.State != pairingRevoked {
|
||||||
|
locals = append(locals, c)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if len(locals) == 0 {
|
||||||
|
return false, nil
|
||||||
|
}
|
||||||
|
var want *Config
|
||||||
|
switch {
|
||||||
|
case token != "":
|
||||||
|
if pairingFor(locals, named) == nil {
|
||||||
|
return true, fmt.Errorf("%s runs on this machine and is the Host in charge of it, so %s does not take the "+
|
||||||
|
"anchor here; %s admits it instead (it asks you to approve it)", locals[0].HostName, named, locals[0].HostName)
|
||||||
|
}
|
||||||
|
return false, nil
|
||||||
|
case named != "":
|
||||||
|
c, err := pickPairing(cfgs, named)
|
||||||
|
if err != nil {
|
||||||
|
return true, err
|
||||||
|
}
|
||||||
|
if !sameMachineHost(c) {
|
||||||
|
return true, fmt.Errorf("%s runs on this machine and is the Host in charge of it, so %s does not take the "+
|
||||||
|
"anchor here; %s admits it instead (it asks you to approve it)", locals[0].HostName, c.HostName, locals[0].HostName)
|
||||||
|
}
|
||||||
|
want = c
|
||||||
|
case len(locals) == 1:
|
||||||
|
want = locals[0]
|
||||||
|
default:
|
||||||
|
return false, nil // several Hosts on this machine: --host says which
|
||||||
|
}
|
||||||
|
if prev != nil && prev.AnchorHost == want.HostName && want.active() {
|
||||||
|
fmt.Printf("already anchored to %s (owner %q)\n", prev.AnchorHost, prev.Owner)
|
||||||
|
return true, nil
|
||||||
|
}
|
||||||
|
if prev != nil {
|
||||||
|
if pc := pairingFor(cfgs, prev.AnchorHost); pc != nil && sameMachineHost(pc) && pc.active() {
|
||||||
|
return false, nil // moving it between two Hosts on this machine is --rotate, as before
|
||||||
|
}
|
||||||
|
}
|
||||||
|
t, err := takeAnchor(want, prev, anchorWhyLocal, nil, owner)
|
||||||
|
if err != nil {
|
||||||
|
return true, err
|
||||||
|
}
|
||||||
|
printAnchorTake(want.HostName, t)
|
||||||
|
return true, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// printAnchorTake is claim-anchor's report of takeAnchor.
|
||||||
|
func printAnchorTake(host string, t anchorTake) {
|
||||||
|
fmt.Printf("anchored to %s: %s.\n", host, t.Why)
|
||||||
|
if t.Replaced != "" {
|
||||||
|
fmt.Printf(" %s was in charge before; it is told so, and now waits for %s to admit it.\n", t.Replaced, host)
|
||||||
|
}
|
||||||
|
if len(t.Waiting) > 0 {
|
||||||
|
fmt.Printf(" Waiting for %s to admit them: %s. %s asks you to approve each.\n", host, strings.Join(t.Waiting, ", "), host)
|
||||||
|
}
|
||||||
|
fmt.Println(" Every Host paired from now on waits until " + host + " admits it.")
|
||||||
|
fmt.Println(" " + anchorFollowNote())
|
||||||
|
}
|
||||||
@@ -0,0 +1,530 @@
|
|||||||
|
//go:build !windows
|
||||||
|
|
||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"encoding/json"
|
||||||
|
"os"
|
||||||
|
"path/filepath"
|
||||||
|
"strings"
|
||||||
|
"sync"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
const (
|
||||||
|
tLocal = "home.cseries.localhost"
|
||||||
|
tLocal2 = "second.cseries.localhost"
|
||||||
|
tRemote = "remote.host.privatae.ai"
|
||||||
|
)
|
||||||
|
|
||||||
|
// localBox is a networked box with machine authority in a temp config dir.
|
||||||
|
func localBox(t *testing.T) {
|
||||||
|
t.Helper()
|
||||||
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
||||||
|
withMarkerAt(t, filepath.Join(t.TempDir(), "machine.json"))
|
||||||
|
prev := machineAuthorityHeld
|
||||||
|
machineAuthorityHeld = func() bool { return true }
|
||||||
|
t.Cleanup(func() { machineAuthorityHeld = prev })
|
||||||
|
withPolicy(t, nil)
|
||||||
|
if err := setBoxMode(modeNetworked); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func withPolicy(t *testing.T, p *anchorPolicy) {
|
||||||
|
t.Helper()
|
||||||
|
prev := readAnchorPolicy
|
||||||
|
readAnchorPolicy = func() *anchorPolicy {
|
||||||
|
if p == nil {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
c := *p
|
||||||
|
return &c
|
||||||
|
}
|
||||||
|
t.Cleanup(func() { readAnchorPolicy = prev })
|
||||||
|
}
|
||||||
|
|
||||||
|
// writeTCPPairing is a Host reached on a lane port, as pair_tcp.go writes it.
|
||||||
|
func writeTCPPairing(t *testing.T, host, lane, state string) {
|
||||||
|
t.Helper()
|
||||||
|
pd, _ := pairingsDir()
|
||||||
|
// Its control port is one nothing listens on, whatever runs on the machine
|
||||||
|
// running the suite (a bastion of its own answers on 7878).
|
||||||
|
b, _ := json.Marshal(Config{HostName: host, Transport: transportTCP, LaneAddr: lane, WGPrivateKey: "k", State: state,
|
||||||
|
ListenAddr: "127.0.0.1:1"})
|
||||||
|
if err := os.WriteFile(filepath.Join(pd, host+".json"), b, 0o600); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func pairingNamed(t *testing.T, host string) (*Config, []*Config) {
|
||||||
|
t.Helper()
|
||||||
|
all, err := loadPairings()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
c := pairingFor(all, host)
|
||||||
|
if c == nil {
|
||||||
|
t.Fatalf("%s not paired", host)
|
||||||
|
}
|
||||||
|
return c, all
|
||||||
|
}
|
||||||
|
|
||||||
|
func auditLines(t *testing.T) string {
|
||||||
|
t.Helper()
|
||||||
|
d, _ := configDir()
|
||||||
|
b, _ := os.ReadFile(filepath.Join(d, "pairing_audit.jsonl"))
|
||||||
|
return string(b)
|
||||||
|
}
|
||||||
|
|
||||||
|
// What "on this machine" is: a unix socket, or a lane port on loopback. A LAN
|
||||||
|
// address, the relay's tunnel, and a Host's own name are not.
|
||||||
|
//
|
||||||
|
// MUTATION: return true for every tcp pairing in sameMachineHost. RESULT: red.
|
||||||
|
func TestSameMachineIsASocketOrALoopbackLane(t *testing.T) {
|
||||||
|
for _, c := range []struct {
|
||||||
|
cfg Config
|
||||||
|
want bool
|
||||||
|
}{
|
||||||
|
{Config{Transport: transportUnix, LaneSocket: "/run/h/lane.sock"}, true},
|
||||||
|
{Config{Transport: transportTCP, LaneAddr: "127.0.0.1:8811"}, true},
|
||||||
|
{Config{Transport: transportTCP, LaneAddr: "127.3.4.5:8811"}, true},
|
||||||
|
{Config{Transport: transportTCP, LaneAddr: "[::1]:8811"}, true},
|
||||||
|
{Config{Transport: transportTCP, LaneAddr: "localhost:8811"}, true},
|
||||||
|
{Config{Transport: transportTCP, LaneAddr: "10.0.2.2:28811"}, false},
|
||||||
|
{Config{Transport: transportTCP, LaneAddr: "192.168.1.20:8811"}, false},
|
||||||
|
{Config{Transport: transportTCP, LaneAddr: "home.cseries.localhost:8811"}, false},
|
||||||
|
{Config{HostName: "x.cseries.localhost", BastionTunnelIP: "fd12:3456::a:1"}, false},
|
||||||
|
} {
|
||||||
|
if got := sameMachineHost(&c.cfg); got != c.want {
|
||||||
|
t.Errorf("%+v: same machine = %v, want %v", c.cfg, got, c.want)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The S0 order the other way round: the machine was anchored to a remote Host,
|
||||||
|
// then a Host on this machine is paired with machine authority. It takes the
|
||||||
|
// anchor; the remote one becomes an ordinary pairing waiting for it, is told
|
||||||
|
// on its beat, and the audit says so.
|
||||||
|
//
|
||||||
|
// MUTATION: drop the sameMachineHost case from anchorAfterPair. RESULT: red.
|
||||||
|
// Leave the replaced anchor active in takeAnchor. RESULT: red.
|
||||||
|
func TestAHostOnThisMachineTakesTheAnchorFromARemoteOne(t *testing.T) {
|
||||||
|
localBox(t)
|
||||||
|
writePairing(t, tRemote)
|
||||||
|
if err := writeAnchor("the owner", tRemote); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
writeTCPPairing(t, tLocal, "127.0.0.1:8811", pairingPending)
|
||||||
|
cfg, all := pairingNamed(t, tLocal)
|
||||||
|
took, err := anchorAfterPair(cfg, all)
|
||||||
|
if err != nil || !took.Taken || took.Replaced != tRemote {
|
||||||
|
t.Fatalf("a Host on this machine must take the anchor: %+v %v", took, err)
|
||||||
|
}
|
||||||
|
if a := currentAnchor(); a == nil || a.AnchorHost != tLocal || a.Owner != "the owner" {
|
||||||
|
t.Fatalf("anchor = %+v", a)
|
||||||
|
}
|
||||||
|
if got := loadState(t, tLocal); got != pairingActive {
|
||||||
|
t.Errorf("the new anchor waits on itself: %q", got)
|
||||||
|
}
|
||||||
|
if got := loadState(t, tRemote); got != pairingPending {
|
||||||
|
t.Errorf("the replaced anchor is %q, want pending", got)
|
||||||
|
}
|
||||||
|
a := auditLines(t)
|
||||||
|
if !strings.Contains(a, `"op":"anchor_take"`) || !strings.Contains(a, "it replaced "+tRemote) ||
|
||||||
|
!strings.Contains(a, "waits for "+tLocal+" to admit it") {
|
||||||
|
t.Errorf("the audit does not record it:\n%s", a)
|
||||||
|
}
|
||||||
|
note := anchorReplacedNote(tRemote)
|
||||||
|
if note == nil || note["by"] != tLocal || note["why"] != anchorWhyLocal {
|
||||||
|
t.Fatalf("the replaced anchor's beat is not told: %v", note)
|
||||||
|
}
|
||||||
|
if e := pairingEnforcing(tRemote); e["anchor_replaced"] == nil || e["waiting_for"] != tLocal {
|
||||||
|
t.Errorf("the enforcing report of the replaced anchor: %v", e)
|
||||||
|
}
|
||||||
|
if anchorReplacedNote(tLocal) != nil {
|
||||||
|
t.Error("the new anchor is told it was replaced")
|
||||||
|
}
|
||||||
|
var former *pairingEntry
|
||||||
|
for _, e := range pairingsReport() {
|
||||||
|
if e.HostName == tRemote {
|
||||||
|
e := e
|
||||||
|
former = &e
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if former == nil || former.Origin != pairingOriginFormerAnchor || former.WaitingFor != tLocal || former.Transport != "tunnel" || former.SameMachine {
|
||||||
|
t.Errorf("the anchor's report of the former anchor: %+v", former)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A networked box with no anchor and a remote Host already serving: the Host on
|
||||||
|
// this machine takes the anchor, and the remote one waits for it.
|
||||||
|
func TestAHostOnThisMachineAnchorsABoxThatAlreadyServesARemoteHost(t *testing.T) {
|
||||||
|
localBox(t)
|
||||||
|
writePairing(t, tRemote)
|
||||||
|
writeTCPPairing(t, tLocal, "127.0.0.1:8811", "")
|
||||||
|
cfg, all := pairingNamed(t, tLocal)
|
||||||
|
took, err := anchorAfterPair(cfg, all)
|
||||||
|
if err != nil || !took.Taken || took.Replaced != "" || strings.Join(took.Waiting, ",") != tRemote {
|
||||||
|
t.Fatalf("%+v %v", took, err)
|
||||||
|
}
|
||||||
|
if got := loadState(t, tRemote); got != pairingPending {
|
||||||
|
t.Errorf("the remote Host holds no grant from the new anchor and must wait: %q", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Never "whichever paired first": a remote Host never takes the anchor from a
|
||||||
|
// Host on this machine, and a second Host on this machine does not either.
|
||||||
|
//
|
||||||
|
// MUTATION: drop the "a Host on this machine already holds it" return.
|
||||||
|
// RESULT: red.
|
||||||
|
func TestTheAnchorOnThisMachineIsNotReplaced(t *testing.T) {
|
||||||
|
for _, newcomer := range []struct{ host, lane string }{{tRemote, "10.0.2.2:28811"}, {tLocal2, "127.0.0.1:9811"}} {
|
||||||
|
t.Run(newcomer.host, func(t *testing.T) {
|
||||||
|
localBox(t)
|
||||||
|
writeTCPPairing(t, tLocal, "127.0.0.1:8811", "")
|
||||||
|
if err := writeAnchor("the owner", tLocal); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
writeTCPPairing(t, newcomer.host, newcomer.lane, pairingPending)
|
||||||
|
cfg, all := pairingNamed(t, newcomer.host)
|
||||||
|
if took, err := anchorAfterPair(cfg, all); took.Taken || err != nil {
|
||||||
|
t.Fatalf("%s took the anchor: %+v %v", newcomer.host, took, err)
|
||||||
|
}
|
||||||
|
if a := currentAnchor(); a == nil || a.AnchorHost != tLocal {
|
||||||
|
t.Fatalf("anchor moved: %+v", a)
|
||||||
|
}
|
||||||
|
if got := loadState(t, newcomer.host); got != pairingPending {
|
||||||
|
t.Errorf("state %q", got)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Without machine authority, or on a local machine, nothing is anchored.
|
||||||
|
func TestTakingTheAnchorNeedsANetworkedMachineAndItsAuthority(t *testing.T) {
|
||||||
|
localBox(t)
|
||||||
|
writePairing(t, tRemote)
|
||||||
|
if err := writeAnchor("the owner", tRemote); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
writeTCPPairing(t, tLocal, "127.0.0.1:8811", pairingPending)
|
||||||
|
machineAuthorityHeld = func() bool { return false }
|
||||||
|
cfg, all := pairingNamed(t, tLocal)
|
||||||
|
if took, _ := anchorAfterPair(cfg, all); took.Taken {
|
||||||
|
t.Fatal("anchored without machine authority")
|
||||||
|
}
|
||||||
|
machineAuthorityHeld = func() bool { return true }
|
||||||
|
localBox(t)
|
||||||
|
if err := setBoxMode(modeLocal); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
writeTCPPairing(t, tLocal, "127.0.0.1:8811", "")
|
||||||
|
cfg, all = pairingNamed(t, tLocal)
|
||||||
|
if took, _ := anchorAfterPair(cfg, all); took.Taken || currentAnchor() != nil {
|
||||||
|
t.Fatal("anchored a local machine")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// An organisation's policy wins over the Host on this machine: the Host it
|
||||||
|
// names takes the anchor, from a Host on this machine too; any other Host
|
||||||
|
// waits for it; and claim-anchor for any other Host is refused in words that
|
||||||
|
// say an organisation manages the machine.
|
||||||
|
//
|
||||||
|
// MUTATION: check sameMachineHost before the policy in anchorAfterPair.
|
||||||
|
// RESULT: red. Drop the policy refusal in claimAnchorByRule. RESULT: red.
|
||||||
|
func TestAnOrganisationsPolicyNamesTheHostInCharge(t *testing.T) {
|
||||||
|
localBox(t)
|
||||||
|
withPolicy(t, &anchorPolicy{Host: tRemote, Source: "HKLM\\SOFTWARE\\Policies\\Privatae\\Bastion AnchorHost"})
|
||||||
|
|
||||||
|
// Unanchored: the Host on this machine waits for the one the policy names.
|
||||||
|
if _, state, err := pairPrecheckState(false, handleOf(tLocal)); err != nil || state != pairingPending {
|
||||||
|
t.Fatalf("a Host the policy does not name must wait: %q %v", state, err)
|
||||||
|
}
|
||||||
|
if _, state, _ := pairPrecheckState(false, handleOf(tRemote)); state != "" {
|
||||||
|
t.Fatalf("the Host the policy names waits for nobody: %q", state)
|
||||||
|
}
|
||||||
|
writeTCPPairing(t, tLocal, "127.0.0.1:8811", pairingPending)
|
||||||
|
cfg, all := pairingNamed(t, tLocal)
|
||||||
|
if took, _ := anchorAfterPair(cfg, all); took.Taken {
|
||||||
|
t.Fatal("the Host on this machine took the anchor against the organisation's policy")
|
||||||
|
}
|
||||||
|
if got := admitter(); got != tRemote {
|
||||||
|
t.Errorf("a pending pairing waits for %q, want the policy's Host", got)
|
||||||
|
}
|
||||||
|
err := cmdClaimAnchor("", false, "", tLocal)
|
||||||
|
if err == nil || !strings.Contains(err.Error(), "an organisation manages this machine") ||
|
||||||
|
!strings.Contains(err.Error(), "names "+tRemote) {
|
||||||
|
t.Fatalf("claim-anchor for another Host: %v", err)
|
||||||
|
}
|
||||||
|
if err := cmdClaimAnchor("", false, "", ""); err == nil || !strings.Contains(err.Error(), "not paired with this machine yet") {
|
||||||
|
t.Fatalf("claim-anchor before the policy's Host is paired: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
// The policy's Host is paired: it takes the anchor, the other one waits.
|
||||||
|
writePairingState(t, tRemote, "")
|
||||||
|
cfg, all = pairingNamed(t, tRemote)
|
||||||
|
took, err := anchorAfterPair(cfg, all)
|
||||||
|
if err != nil || !took.Taken {
|
||||||
|
t.Fatalf("the policy's Host must take the anchor: %+v %v", took, err)
|
||||||
|
}
|
||||||
|
if a := currentAnchor(); a == nil || a.AnchorHost != tRemote {
|
||||||
|
t.Fatalf("anchor = %+v", a)
|
||||||
|
}
|
||||||
|
if !strings.Contains(auditLines(t), "an organisation's policy") {
|
||||||
|
t.Errorf("the audit does not name the policy: %s", auditLines(t))
|
||||||
|
}
|
||||||
|
if err := cmdClaimAnchor("", true, "", tLocal); err == nil || !strings.Contains(err.Error(), "an organisation manages this machine") {
|
||||||
|
t.Fatalf("claim-anchor --rotate to another Host: %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A policy deployed after a Host on this machine took the anchor: claim-anchor
|
||||||
|
// with no argument hands it to the Host the policy names, without --rotate.
|
||||||
|
func TestClaimAnchorFollowsAPolicyDeployedLater(t *testing.T) {
|
||||||
|
localBox(t)
|
||||||
|
writeTCPPairing(t, tLocal, "127.0.0.1:8811", "")
|
||||||
|
if err := writeAnchor("the owner", tLocal); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
writePairingState(t, tRemote, pairingPending)
|
||||||
|
withPolicy(t, &anchorPolicy{Host: handleOf(tRemote), Source: "/etc/privatae-bastion/policy.json anchor_host"})
|
||||||
|
if err := cmdClaimAnchor("", false, "", ""); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if a := currentAnchor(); a == nil || a.AnchorHost != tRemote {
|
||||||
|
t.Fatalf("anchor = %+v", a)
|
||||||
|
}
|
||||||
|
if got := loadState(t, tLocal); got != pairingPending {
|
||||||
|
t.Errorf("the Host on this machine is %q, want waiting for the policy's Host", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// claim-anchor with no argument on a box that serves a remote Host and a Host
|
||||||
|
// on this machine picks the one on this machine; naming the remote one is
|
||||||
|
// refused while a Host on this machine is paired.
|
||||||
|
//
|
||||||
|
// MUTATION: return false at the top of claimAnchorByRule's same-machine part.
|
||||||
|
// RESULT: red (the old "say which one" refusal).
|
||||||
|
func TestClaimAnchorPicksTheHostOnThisMachine(t *testing.T) {
|
||||||
|
localBox(t)
|
||||||
|
writePairing(t, tRemote)
|
||||||
|
writeTCPPairing(t, tLocal, "127.0.0.1:8811", "")
|
||||||
|
if err := cmdClaimAnchor("", false, "", tRemote); err == nil || !strings.Contains(err.Error(), "runs on this machine and is the Host in charge") {
|
||||||
|
t.Fatalf("naming the remote Host: %v", err)
|
||||||
|
}
|
||||||
|
if err := cmdClaimAnchor("", false, "", ""); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if a := currentAnchor(); a == nil || a.AnchorHost != tLocal {
|
||||||
|
t.Fatalf("anchor = %+v", a)
|
||||||
|
}
|
||||||
|
if got := loadState(t, tRemote); got != pairingPending {
|
||||||
|
t.Errorf("the remote Host is %q", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The replaced anchor's running beat is beaten once more before its lanes stop.
|
||||||
|
//
|
||||||
|
// MUTATION: drop the tellReplacedAnchor call in superviseOnce, or the
|
||||||
|
// tellReplacedAnchorsBeforeStop body. RESULT: red.
|
||||||
|
func TestTheReplacedAnchorIsToldOnALastBeat(t *testing.T) {
|
||||||
|
localBox(t)
|
||||||
|
writePairing(t, tRemote)
|
||||||
|
if err := writeAnchor("the owner", tRemote); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
writeTCPPairing(t, tLocal, "127.0.0.1:8811", pairingPending)
|
||||||
|
remote, _ := pairingNamed(t, tRemote)
|
||||||
|
cfg, all := pairingNamed(t, tLocal)
|
||||||
|
if took, err := anchorAfterPair(cfg, all); err != nil || !took.Taken {
|
||||||
|
t.Fatal(took, err)
|
||||||
|
}
|
||||||
|
var told any
|
||||||
|
beat := func() { told = pairingEnforcing(tRemote)["anchor_replaced"] }
|
||||||
|
_, unregister := registerRunBeat(tRemote, beat)
|
||||||
|
defer unregister()
|
||||||
|
done := make(chan struct{})
|
||||||
|
close(done)
|
||||||
|
supervisor.Lock()
|
||||||
|
supervisor.runs = map[string]*pairingRun{tRemote: {cancel: func() {}, done: done, cfg: remote}}
|
||||||
|
supervisor.Unlock()
|
||||||
|
t.Cleanup(func() { supervisor.Lock(); supervisor.runs = nil; supervisor.Unlock() })
|
||||||
|
// The daemon stopping first (an installer's Restart-Service right after
|
||||||
|
// `pair`) tells it as well.
|
||||||
|
tellReplacedAnchorsBeforeStop()
|
||||||
|
if told == nil {
|
||||||
|
t.Fatal("the daemon stopped without a last beat to the replaced anchor")
|
||||||
|
}
|
||||||
|
told = nil
|
||||||
|
superviseOnce()
|
||||||
|
if told == nil {
|
||||||
|
t.Fatal("the replaced anchor was stopped without a last beat that says so")
|
||||||
|
}
|
||||||
|
// Admitted again, it is no longer told.
|
||||||
|
clearAnchorReplacedFor(tRemote)
|
||||||
|
if anchorReplacedNote(tRemote) != nil {
|
||||||
|
t.Error("an admitted former anchor still hears it was replaced")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// One pairing's fatal error stops that pairing alone: nothing reaches the
|
||||||
|
// daemon's fatal channel, the failure is recorded for status, and it is tried
|
||||||
|
// again after a pause.
|
||||||
|
//
|
||||||
|
// MUTATION: send the error to supervisor.errc again. RESULT: red.
|
||||||
|
func TestOnePairingsFatalErrorStopsOnlyThatPairing(t *testing.T) {
|
||||||
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
||||||
|
freshLocalEvents(t)
|
||||||
|
// A Host over TCP whose CA does not read: runUnixPairing fails at once.
|
||||||
|
bad := &Config{HostName: "broken.example.test", Transport: transportTCP, LaneAddr: "127.0.0.1:1", Bearer: "b",
|
||||||
|
CACert: "not a certificate", ListenAddr: "127.0.0.1:0"}
|
||||||
|
ctx, cancel := context.WithCancel(context.Background())
|
||||||
|
defer cancel()
|
||||||
|
errc := make(chan error, 4)
|
||||||
|
supervisor.Lock()
|
||||||
|
prevCtx, prevErrc, prevRuns := supervisor.ctx, supervisor.errc, supervisor.runs
|
||||||
|
supervisor.ctx, supervisor.errc, supervisor.runs = ctx, errc, nil
|
||||||
|
supervisor.Unlock()
|
||||||
|
t.Cleanup(func() {
|
||||||
|
supervisor.Lock()
|
||||||
|
supervisor.ctx, supervisor.errc, supervisor.runs = prevCtx, prevErrc, prevRuns
|
||||||
|
supervisor.Unlock()
|
||||||
|
pairingRecovered(bad.HostName)
|
||||||
|
})
|
||||||
|
if !startPairing(bad) {
|
||||||
|
t.Fatal("not started")
|
||||||
|
}
|
||||||
|
deadline := time.Now().Add(5 * time.Second)
|
||||||
|
for time.Now().Before(deadline) {
|
||||||
|
if _, ok := loadPairingFailures()[bad.HostName]; ok {
|
||||||
|
break
|
||||||
|
}
|
||||||
|
time.Sleep(20 * time.Millisecond)
|
||||||
|
}
|
||||||
|
select {
|
||||||
|
case err := <-errc:
|
||||||
|
t.Fatalf("one pairing's error went to the whole daemon: %v", err)
|
||||||
|
case <-time.After(100 * time.Millisecond):
|
||||||
|
}
|
||||||
|
f, ok := loadPairingFailures()[bad.HostName]
|
||||||
|
if !ok || f.Error == "" || f.Tries != 1 {
|
||||||
|
t.Fatalf("the failure is not recorded: %+v", f)
|
||||||
|
}
|
||||||
|
if pairingRetryDue(bad.HostName) {
|
||||||
|
t.Error("tried again with no pause")
|
||||||
|
}
|
||||||
|
if retryPause(1) != supervisePeriod || retryPause(3) != 4*supervisePeriod || retryPause(40) != retryMaxPause {
|
||||||
|
t.Errorf("pauses %v %v %v", retryPause(1), retryPause(3), retryPause(40))
|
||||||
|
}
|
||||||
|
found := false
|
||||||
|
for _, e := range localEventsNewestFirst() {
|
||||||
|
found = found || strings.Contains(e.Text, "The other Hosts go on being served")
|
||||||
|
}
|
||||||
|
if !found {
|
||||||
|
t.Error("the machine's events do not say so")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The Windows service manager's stop is logged as its own, not the tray's.
|
||||||
|
// The service handler cannot run here, so its source is read.
|
||||||
|
//
|
||||||
|
// MUTATION: call requestShutdown() in sysservice_windows.go. RESULT: red.
|
||||||
|
func TestTheServiceManagersStopIsNotLoggedAsTheTrays(t *testing.T) {
|
||||||
|
src, err := os.ReadFile("sysservice_windows.go")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if !strings.Contains(string(src), "requestShutdownFor(shutdownFromService)") || strings.Contains(string(src), "requestShutdown()") {
|
||||||
|
t.Error("the service's stop does not name the service manager")
|
||||||
|
}
|
||||||
|
run, _ := os.ReadFile("run.go")
|
||||||
|
if !strings.Contains(string(run), `"\nstopping — " + shutdownWhy`) {
|
||||||
|
t.Error("cmdRun does not log who asked it to stop")
|
||||||
|
}
|
||||||
|
if strings.Contains(shutdownFromService, "tray") {
|
||||||
|
t.Error(shutdownFromService)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Over a network logon (ssh) the service cannot be queried for its process id;
|
||||||
|
// the ask pipe is then checked by its owner, SYSTEM, instead of refused.
|
||||||
|
//
|
||||||
|
// MUTATION: drop the ERROR_ACCESS_DENIED branch. RESULT: red.
|
||||||
|
func TestTheAskPipeIsCheckedByItsOwnerWhenTheServiceCannotBeQueried(t *testing.T) {
|
||||||
|
src, err := os.ReadFile("approvalpipe_windows.go")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
s := string(src)
|
||||||
|
i := strings.Index(s, "func pipeServerIsService(")
|
||||||
|
if i < 0 {
|
||||||
|
t.Fatal("no pipeServerIsService")
|
||||||
|
}
|
||||||
|
body := s[i : i+strings.Index(s[i:], "\n}\n")]
|
||||||
|
if !strings.Contains(body, "errors.Is(err, windows.ERROR_ACCESS_DENIED)") || !strings.Contains(body, "return pipeOwnedBySystem(h)") {
|
||||||
|
t.Error("a network logon is still refused")
|
||||||
|
}
|
||||||
|
if !strings.Contains(s, "!owner.IsWellKnown(windows.WinLocalSystemSid) && !owner.IsWellKnown(windows.WinBuiltinAdministratorsSid)") {
|
||||||
|
t.Error("the owner check does not require LocalSystem or the Administrators group")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The last beat to a replaced anchor (lastBeat, from superviseOnce's
|
||||||
|
// goroutine) never runs beside the run's own beat or path failover: both write
|
||||||
|
// cfg.Endpoints and the WG device, and before lastBeat a run's beats all came
|
||||||
|
// from its one loop.
|
||||||
|
func TestTheLastBeatNeverRunsBesideTheRunsOwnBeat(t *testing.T) {
|
||||||
|
const host = "serial-beat.host.privatae.ai"
|
||||||
|
var mu sync.Mutex
|
||||||
|
in, most := 0, 0
|
||||||
|
entered := make(chan struct{}, 4)
|
||||||
|
release := make(chan struct{})
|
||||||
|
beat := func() {
|
||||||
|
mu.Lock()
|
||||||
|
in++
|
||||||
|
if in > most {
|
||||||
|
most = in
|
||||||
|
}
|
||||||
|
mu.Unlock()
|
||||||
|
entered <- struct{}{}
|
||||||
|
<-release
|
||||||
|
mu.Lock()
|
||||||
|
in--
|
||||||
|
mu.Unlock()
|
||||||
|
}
|
||||||
|
rb, unregister := registerRunBeat(host, beat)
|
||||||
|
defer unregister()
|
||||||
|
old := lastBeatWait
|
||||||
|
lastBeatWait = 200 * time.Millisecond
|
||||||
|
t.Cleanup(func() { lastBeatWait = old })
|
||||||
|
|
||||||
|
loopDone := make(chan struct{})
|
||||||
|
go func() { defer close(loopDone); rb.run() }() // the run's own beat, in flight
|
||||||
|
<-entered
|
||||||
|
failoverRan := make(chan struct{})
|
||||||
|
go func() { rb.do(func() {}); close(failoverRan) }() // the tick's failover waits too
|
||||||
|
if !lastBeat(host) {
|
||||||
|
t.Fatal("lastBeat found no beat for a running pairing")
|
||||||
|
}
|
||||||
|
select {
|
||||||
|
case <-entered:
|
||||||
|
t.Fatal("the last beat ran beside the run's own beat")
|
||||||
|
default:
|
||||||
|
}
|
||||||
|
select {
|
||||||
|
case <-failoverRan:
|
||||||
|
t.Fatal("path failover ran beside a beat")
|
||||||
|
default:
|
||||||
|
}
|
||||||
|
close(release)
|
||||||
|
<-loopDone
|
||||||
|
<-failoverRan
|
||||||
|
mu.Lock()
|
||||||
|
defer mu.Unlock()
|
||||||
|
if most != 1 {
|
||||||
|
t.Fatalf("%d beats ran at once, want 1", most)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,35 @@
|
|||||||
|
//go:build darwin
|
||||||
|
|
||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"os"
|
||||||
|
"os/exec"
|
||||||
|
"strings"
|
||||||
|
"syscall"
|
||||||
|
)
|
||||||
|
|
||||||
|
// anchorPolicyPlist is the machine-wide managed preference domain a
|
||||||
|
// configuration profile (MDM) installs for the bastion. The folder is root's
|
||||||
|
// and the system writes it; a file there not owned by root is not a policy.
|
||||||
|
const anchorPolicyPlist = "/Library/Managed Preferences/ai.privatae.bastion.plist"
|
||||||
|
|
||||||
|
func readAnchorPolicyOS() *anchorPolicy {
|
||||||
|
fi, err := os.Lstat(anchorPolicyPlist)
|
||||||
|
if err != nil || !fi.Mode().IsRegular() || fi.Mode().Perm()&0o022 != 0 {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
if st, ok := fi.Sys().(*syscall.Stat_t); !ok || st.Uid != 0 {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
// defaults reads the binary and the XML form alike.
|
||||||
|
out, err := exec.Command("/usr/bin/defaults", "read", strings.TrimSuffix(anchorPolicyPlist, ".plist"), "AnchorHost").Output()
|
||||||
|
if err != nil {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
v := strings.TrimSpace(string(out))
|
||||||
|
if v == "" {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
return &anchorPolicy{Host: v, Source: "the managed preference ai.privatae.bastion AnchorHost"}
|
||||||
|
}
|
||||||
@@ -0,0 +1,37 @@
|
|||||||
|
//go:build linux
|
||||||
|
|
||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"os"
|
||||||
|
"path/filepath"
|
||||||
|
"testing"
|
||||||
|
)
|
||||||
|
|
||||||
|
// The policy readers accept only what the machine's administrator or policy
|
||||||
|
// engine could have written: on Linux a file root owns that nobody else can
|
||||||
|
// write. Run as an ordinary user, the suite's own file is not root's, so it is
|
||||||
|
// no policy.
|
||||||
|
func TestALinuxPolicyFileMustBeRoots(t *testing.T) {
|
||||||
|
dir := t.TempDir()
|
||||||
|
prev := anchorPolicyFile
|
||||||
|
anchorPolicyFile = filepath.Join(dir, "policy.json")
|
||||||
|
t.Cleanup(func() { anchorPolicyFile = prev })
|
||||||
|
if err := os.WriteFile(anchorPolicyFile, []byte(`{"anchor_host":"`+"managed.host.privatae.ai"+`"}`), 0o644); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
p := readAnchorPolicyOS()
|
||||||
|
if os.Geteuid() == 0 {
|
||||||
|
if p == nil || p.Host != "managed.host.privatae.ai" {
|
||||||
|
t.Fatalf("root's own policy file was not read: %+v", p)
|
||||||
|
}
|
||||||
|
_ = os.Chmod(anchorPolicyFile, 0o666)
|
||||||
|
if readAnchorPolicyOS() != nil {
|
||||||
|
t.Error("a policy file anyone can write was read")
|
||||||
|
}
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if p != nil {
|
||||||
|
t.Errorf("a policy file root does not own was read: %+v", p)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,37 @@
|
|||||||
|
//go:build !windows && !darwin
|
||||||
|
|
||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"encoding/json"
|
||||||
|
"os"
|
||||||
|
"strings"
|
||||||
|
"syscall"
|
||||||
|
)
|
||||||
|
|
||||||
|
// anchorPolicyFile is the managed configuration an organisation deploys to a
|
||||||
|
// Linux machine (by its configuration management) for the bastion: root's,
|
||||||
|
// and writable by nobody else. A file anyone else could have written is not a
|
||||||
|
// policy.
|
||||||
|
var anchorPolicyFile = "/etc/privatae-bastion/policy.json"
|
||||||
|
|
||||||
|
func readAnchorPolicyOS() *anchorPolicy {
|
||||||
|
fi, err := os.Lstat(anchorPolicyFile)
|
||||||
|
if err != nil || !fi.Mode().IsRegular() || fi.Mode().Perm()&0o022 != 0 {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
if st, ok := fi.Sys().(*syscall.Stat_t); !ok || st.Uid != 0 {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
raw, err := os.ReadFile(anchorPolicyFile)
|
||||||
|
if err != nil {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
var p struct {
|
||||||
|
AnchorHost string `json:"anchor_host"`
|
||||||
|
}
|
||||||
|
if json.Unmarshal(raw, &p) != nil || strings.TrimSpace(p.AnchorHost) == "" {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
return &anchorPolicy{Host: p.AnchorHost, Source: anchorPolicyFile + " anchor_host"}
|
||||||
|
}
|
||||||
@@ -0,0 +1,27 @@
|
|||||||
|
//go:build windows
|
||||||
|
|
||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"strings"
|
||||||
|
|
||||||
|
"golang.org/x/sys/windows/registry"
|
||||||
|
)
|
||||||
|
|
||||||
|
// anchorPolicyKey is where Group Policy and Intune deploy a machine policy for
|
||||||
|
// the bastion: under HKLM\SOFTWARE\Policies, which only an administrator or
|
||||||
|
// the policy engine writes. Domain membership is not read.
|
||||||
|
const anchorPolicyKey = `SOFTWARE\Policies\Privatae\Bastion`
|
||||||
|
|
||||||
|
func readAnchorPolicyOS() *anchorPolicy {
|
||||||
|
k, err := registry.OpenKey(registry.LOCAL_MACHINE, anchorPolicyKey, registry.QUERY_VALUE)
|
||||||
|
if err != nil {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
defer k.Close()
|
||||||
|
v, _, err := k.GetStringValue("AnchorHost")
|
||||||
|
if err != nil || strings.TrimSpace(v) == "" {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
return &anchorPolicy{Host: v, Source: `HKLM\` + anchorPolicyKey + ` AnchorHost`}
|
||||||
|
}
|
||||||
@@ -177,6 +177,15 @@ func winPersonSID(sid string) bool {
|
|||||||
return strings.HasPrefix(sid, "S-1-5-21-") || strings.HasPrefix(sid, "S-1-12-1-")
|
return strings.HasPrefix(sid, "S-1-5-21-") || strings.HasPrefix(sid, "S-1-12-1-")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// pipeClientNewer: a process created after the connection was made cannot be
|
||||||
|
// the one that made it. The service finds the connecting process by its id
|
||||||
|
// (GetNamedPipeClientProcessId), and an id is reused once its process has
|
||||||
|
// exited and nothing holds it, so a client that hands its pipe to another
|
||||||
|
// process and exits could otherwise be answered as whoever got its id next.
|
||||||
|
// The connection time is taken as the service starts serving it, a moment
|
||||||
|
// after the connect.
|
||||||
|
func pipeClientNewer(created, connected time.Time) bool { return created.After(connected) }
|
||||||
|
|
||||||
// pipeClientRefusal says why a connected process may not use the lane, or ""
|
// pipeClientRefusal says why a connected process may not use the lane, or ""
|
||||||
// when it may: it must run as the person signed in to its own session, in a
|
// when it may: it must run as the person signed in to its own session, in a
|
||||||
// session someone is in front of.
|
// session someone is in front of.
|
||||||
|
|||||||
@@ -157,10 +157,11 @@ func (c *pipeConn) readLine(max int, timeout time.Duration) ([]byte, error) {
|
|||||||
// approvalPipeServer tracks how many of our instances are open, so an instance
|
// approvalPipeServer tracks how many of our instances are open, so an instance
|
||||||
// created while none is open asks for the name to be ours alone.
|
// created while none is open asks for the name to be ours alone.
|
||||||
type approvalPipeServer struct {
|
type approvalPipeServer struct {
|
||||||
mu sync.Mutex
|
mu sync.Mutex
|
||||||
open int
|
open int
|
||||||
sa *windows.SecurityAttributes
|
sa *windows.SecurityAttributes
|
||||||
name *uint16
|
name *uint16
|
||||||
|
label string // the pipe's name, for a message
|
||||||
// stopEv is set when the service stops; it ends a connect that is waiting.
|
// stopEv is set when the service stops; it ends a connect that is waiting.
|
||||||
stopEv windows.Handle
|
stopEv windows.Handle
|
||||||
}
|
}
|
||||||
@@ -190,7 +191,7 @@ func (s *approvalPipeServer) create() (*pipeConn, error) {
|
|||||||
windows.PIPE_UNLIMITED_INSTANCES, 64<<10, 64<<10, 0, s.sa)
|
windows.PIPE_UNLIMITED_INSTANCES, 64<<10, 64<<10, 0, s.sa)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
if s.open == 0 {
|
if s.open == 0 {
|
||||||
return nil, fmt.Errorf("cannot create %s; if another program holds that name the tray stays off: %w", approvalPipeName, err)
|
return nil, fmt.Errorf("cannot create %s; if another program holds that name, this lane stays off: %w", s.label, err)
|
||||||
}
|
}
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
@@ -230,11 +231,17 @@ func startApprovalPipe(stop <-chan struct{}) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func serveApprovalPipe(stop <-chan struct{}, ready func()) error {
|
func serveApprovalPipe(stop <-chan struct{}, ready func()) error {
|
||||||
sd, err := windows.SecurityDescriptorFromString(approvalPipeSDDL)
|
return servePipe(stop, ready, approvalPipeName, approvalPipeSDDL, servePipeConn)
|
||||||
|
}
|
||||||
|
|
||||||
|
// servePipe serves one of the service's pipes, name with the ACL sddl, until
|
||||||
|
// stop is closed, handing each connection to serve.
|
||||||
|
func servePipe(stop <-chan struct{}, ready func(), pipeName, sddl string, serve func(*pipeConn)) error {
|
||||||
|
sd, err := windows.SecurityDescriptorFromString(sddl)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return fmt.Errorf("cannot build the pipe's permissions: %w", err)
|
return fmt.Errorf("cannot build the pipe's permissions: %w", err)
|
||||||
}
|
}
|
||||||
name, err := windows.UTF16PtrFromString(approvalPipeName)
|
name, err := windows.UTF16PtrFromString(pipeName)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
@@ -249,11 +256,12 @@ func serveApprovalPipe(stop <-chan struct{}, ready func()) error {
|
|||||||
s := &approvalPipeServer{
|
s := &approvalPipeServer{
|
||||||
sa: &windows.SecurityAttributes{Length: uint32(unsafe.Sizeof(windows.SecurityAttributes{})), SecurityDescriptor: sd},
|
sa: &windows.SecurityAttributes{Length: uint32(unsafe.Sizeof(windows.SecurityAttributes{})), SecurityDescriptor: sd},
|
||||||
name: name,
|
name: name,
|
||||||
|
label: pipeName,
|
||||||
stopEv: stopEv,
|
stopEv: stopEv,
|
||||||
}
|
}
|
||||||
// The loop and its no-gap rule are in approvalpipe.go, where the suite runs them.
|
// The loop and its no-gap rule are in approvalpipe.go, where the suite runs them.
|
||||||
return pipeAcceptLoop[*pipeConn](s, stop, pipeMaxClients, time.Second,
|
return pipeAcceptLoop[*pipeConn](s, stop, pipeMaxClients, time.Second,
|
||||||
func(f string, a ...any) { fmt.Printf(f, a...) }, ready, servePipeConn)
|
func(f string, a ...any) { fmt.Printf(f, a...) }, ready, serve)
|
||||||
}
|
}
|
||||||
|
|
||||||
// servePipeConn answers one request and waits, briefly, for the client to
|
// servePipeConn answers one request and waits, briefly, for the client to
|
||||||
@@ -291,7 +299,12 @@ func servePipeConn(c *pipeConn) {
|
|||||||
// (GetNamedPipeClientProcessId), its user and session from that process's
|
// (GetNamedPipeClientProcessId), its user and session from that process's
|
||||||
// token, and the person signed in to that session from the session's own token
|
// token, and the person signed in to that session from the session's own token
|
||||||
// (WTSQueryUserToken, which LocalSystem may call).
|
// (WTSQueryUserToken, which LocalSystem may call).
|
||||||
|
//
|
||||||
|
// The process is found by its id, after it connected. An id that was freed
|
||||||
|
// and given to a new process in between would name the wrong one, so a
|
||||||
|
// process created after the connection is refused (pipeClientNewer).
|
||||||
func pipeClientOf(h windows.Handle) (pipeClient, error) {
|
func pipeClientOf(h windows.Handle) (pipeClient, error) {
|
||||||
|
connected := time.Now()
|
||||||
var c pipeClient
|
var c pipeClient
|
||||||
if err := windows.GetNamedPipeClientProcessId(h, &c.PID); err != nil {
|
if err := windows.GetNamedPipeClientProcessId(h, &c.PID); err != nil {
|
||||||
return c, fmt.Errorf("cannot tell which process connected: %w", err)
|
return c, fmt.Errorf("cannot tell which process connected: %w", err)
|
||||||
@@ -301,6 +314,13 @@ func pipeClientOf(h windows.Handle) (pipeClient, error) {
|
|||||||
return c, fmt.Errorf("cannot open the connecting process (pid %d): %w", c.PID, err)
|
return c, fmt.Errorf("cannot open the connecting process (pid %d): %w", c.PID, err)
|
||||||
}
|
}
|
||||||
defer windows.CloseHandle(p)
|
defer windows.CloseHandle(p)
|
||||||
|
var created, exited, kernel, user windows.Filetime
|
||||||
|
if err := windows.GetProcessTimes(p, &created, &exited, &kernel, &user); err != nil {
|
||||||
|
return c, fmt.Errorf("cannot read when the connecting process started (pid %d): %w", c.PID, err)
|
||||||
|
}
|
||||||
|
if pipeClientNewer(time.Unix(0, created.Nanoseconds()), connected) {
|
||||||
|
return c, fmt.Errorf("process %d started after the connection was made, so it is not the process that connected", c.PID)
|
||||||
|
}
|
||||||
var tok windows.Token
|
var tok windows.Token
|
||||||
if err := windows.OpenProcessToken(p, windows.TOKEN_QUERY, &tok); err != nil {
|
if err := windows.OpenProcessToken(p, windows.TOKEN_QUERY, &tok); err != nil {
|
||||||
return c, fmt.Errorf("cannot read the connecting process's account (pid %d): %w", c.PID, err)
|
return c, fmt.Errorf("cannot read the connecting process's account (pid %d): %w", c.PID, err)
|
||||||
@@ -381,7 +401,12 @@ func pipeCall(req pipeRequest) (pipeResponse, error) {
|
|||||||
// (read, write data, synchronize; never FILE_APPEND_DATA, which GENERIC_WRITE
|
// (read, write data, synchronize; never FILE_APPEND_DATA, which GENERIC_WRITE
|
||||||
// would ask for), and lets the server identify this process but not act as it.
|
// would ask for), and lets the server identify this process but not act as it.
|
||||||
func dialApprovalPipe() (*pipeConn, error) {
|
func dialApprovalPipe() (*pipeConn, error) {
|
||||||
name, err := windows.UTF16PtrFromString(approvalPipeName)
|
return dialServicePipe(approvalPipeName)
|
||||||
|
}
|
||||||
|
|
||||||
|
// dialServicePipe opens one of the service's pipes (dialApprovalPipe).
|
||||||
|
func dialServicePipe(pipeName string) (*pipeConn, error) {
|
||||||
|
name, err := windows.UTF16PtrFromString(pipeName)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
@@ -401,7 +426,7 @@ func dialApprovalPipe() (*pipeConn, error) {
|
|||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
if errors.Is(err, windows.ERROR_FILE_NOT_FOUND) {
|
if errors.Is(err, windows.ERROR_FILE_NOT_FOUND) {
|
||||||
return nil, errors.New("the bastion service is not running, or is older than this tray")
|
return nil, errors.New("the bastion service is not running, or is older than this program")
|
||||||
}
|
}
|
||||||
return nil, fmt.Errorf("cannot reach the bastion service: %w", err)
|
return nil, fmt.Errorf("cannot reach the bastion service: %w", err)
|
||||||
}
|
}
|
||||||
@@ -413,14 +438,43 @@ func dialApprovalPipe() (*pipeConn, error) {
|
|||||||
func pipeServerIsService(h windows.Handle) error {
|
func pipeServerIsService(h windows.Handle) error {
|
||||||
var pid uint32
|
var pid uint32
|
||||||
if err := windows.GetNamedPipeServerProcessId(h, &pid); err != nil {
|
if err := windows.GetNamedPipeServerProcessId(h, &pid); err != nil {
|
||||||
return fmt.Errorf("cannot tell which process serves the approvals pipe: %w", err)
|
return fmt.Errorf("cannot tell which process serves the pipe: %w", err)
|
||||||
}
|
}
|
||||||
svcPID, err := bastionServicePID()
|
svcPID, err := bastionServicePID()
|
||||||
|
if errors.Is(err, windows.ERROR_ACCESS_DENIED) {
|
||||||
|
// The service's default permissions let an INTERACTIVE logon query it,
|
||||||
|
// not a network one (ssh, a remote PowerShell): the owner's own
|
||||||
|
// `status` over ssh was refused as "Access is denied". The pipe's
|
||||||
|
// owner says what the process id would: servePipe sets no owner, so
|
||||||
|
// the pipe's is the creating token's default owner, which for
|
||||||
|
// LocalSystem is BUILTIN\Administrators (seen on Windows Server 2022)
|
||||||
|
// or SYSTEM, and no program of an ordinary account can make an object
|
||||||
|
// either owns. An administrator's own program could; an administrator
|
||||||
|
// already holds the service itself.
|
||||||
|
return pipeOwnedBySystem(h)
|
||||||
|
}
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
if svcPID == 0 || pid != svcPID {
|
if svcPID == 0 || pid != svcPID {
|
||||||
return fmt.Errorf("the approvals pipe is served by process %d, not by the %s service; nothing was sent", pid, winServiceName)
|
return fmt.Errorf("the pipe is served by process %d, not by the %s service; nothing was sent", pid, winServiceName)
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// pipeOwnedBySystem refuses a pipe whose owner is not LocalSystem or the
|
||||||
|
// Administrators group, the two owners LocalSystem's objects get.
|
||||||
|
func pipeOwnedBySystem(h windows.Handle) error {
|
||||||
|
sd, err := windows.GetSecurityInfo(h, windows.SE_FILE_OBJECT, windows.OWNER_SECURITY_INFORMATION)
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("cannot tell who made the pipe: %w", err)
|
||||||
|
}
|
||||||
|
owner, _, err := sd.Owner()
|
||||||
|
if err != nil || owner == nil {
|
||||||
|
return fmt.Errorf("cannot tell who made the pipe: %v", err)
|
||||||
|
}
|
||||||
|
if !owner.IsWellKnown(windows.WinLocalSystemSid) && !owner.IsWellKnown(windows.WinBuiltinAdministratorsSid) {
|
||||||
|
return fmt.Errorf("the pipe was made by %s, not by the %s service; nothing was sent", owner.String(), winServiceName)
|
||||||
}
|
}
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,19 @@
|
|||||||
|
//go:build !windows
|
||||||
|
|
||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"net"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
// dialAskLane connects to the machine's bastion's ask socket at p.
|
||||||
|
func dialAskLane(p string) (askConn, error) {
|
||||||
|
return net.DialTimeout("unix", p, 3*time.Second)
|
||||||
|
}
|
||||||
|
|
||||||
|
// askLaneAddr is where the lane is, as a message names it.
|
||||||
|
func askLaneAddr(p string) string { return p }
|
||||||
|
|
||||||
|
// startAskPipe is the Windows service's; ask.sock serves here (agentask.go).
|
||||||
|
func startAskPipe(<-chan struct{}) {}
|
||||||
@@ -0,0 +1,153 @@
|
|||||||
|
//go:build windows
|
||||||
|
|
||||||
|
package main
|
||||||
|
|
||||||
|
// The ask pipe: ask.sock (agentask.go) for a bastion that runs as the Windows
|
||||||
|
// service.
|
||||||
|
//
|
||||||
|
// Installed for the whole machine, the bastion is a LocalSystem service and
|
||||||
|
// its state sits in LocalSystem's profile, where the person's own account can
|
||||||
|
// neither read nor write it. Before this pipe, that account had no way to the
|
||||||
|
// machine's bastion at all: `privatae-bastion ui` signed in with a key of its
|
||||||
|
// own and the console answered 401, the reads and owner acts were refused
|
||||||
|
// beside the service, and an agent could not ask for a stop. The pipe answers
|
||||||
|
// exactly what ask.sock answers, through the same code (askAnswer): a stop
|
||||||
|
// asked by any account, and the console, the reads and the owner's acts for
|
||||||
|
// the account recorded as the machine's owner (approvals-owner --sid), with
|
||||||
|
// the caller taken from the pipe client's token, never from the request.
|
||||||
|
//
|
||||||
|
// The pipe is the approvals pipe's machinery (approvalpipe_windows.go):
|
||||||
|
// overlapped I/O with a timeout on every call, a new instance created before
|
||||||
|
// the one it replaces is handed out, the first instance created with
|
||||||
|
// FILE_FLAG_FIRST_PIPE_INSTANCE, and the asking side checking the pipe's
|
||||||
|
// server is the service's own process before it sends anything, since an act
|
||||||
|
// carries the owner's code.
|
||||||
|
|
||||||
|
import (
|
||||||
|
"encoding/json"
|
||||||
|
"errors"
|
||||||
|
"fmt"
|
||||||
|
"io"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"golang.org/x/sys/windows"
|
||||||
|
)
|
||||||
|
|
||||||
|
// startAskPipe serves the ask pipe until done is closed, retrying with backoff
|
||||||
|
// when it cannot (pipeServeRetrying), as the approvals pipe does.
|
||||||
|
func startAskPipe(done <-chan struct{}) {
|
||||||
|
wait := func(d time.Duration) bool {
|
||||||
|
select {
|
||||||
|
case <-done:
|
||||||
|
return false
|
||||||
|
case <-time.After(d):
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
}
|
||||||
|
go pipeServeRetrying(func(ready func()) error {
|
||||||
|
return servePipe(done, ready, askPipeName, askPipeSDDL, serveAskPipeConn)
|
||||||
|
}, wait, func(f string, a ...any) { fmt.Printf(f, a...) })
|
||||||
|
}
|
||||||
|
|
||||||
|
// serveAskPipeConn answers one ask, then waits briefly for the client to
|
||||||
|
// close: closing first would discard an answer it has not read yet.
|
||||||
|
func serveAskPipeConn(c *pipeConn) {
|
||||||
|
client, cerr := pipeClientOf(c.h)
|
||||||
|
raw, err := c.readLine(askMaxBytes, pipeIOTimeout)
|
||||||
|
if err != nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
var reply any
|
||||||
|
switch {
|
||||||
|
case cerr != nil:
|
||||||
|
reply = askUnattributable(cerr)
|
||||||
|
default:
|
||||||
|
who := pipeWho(client)
|
||||||
|
var req agentAskRequest
|
||||||
|
if err := json.Unmarshal(raw, &req); err != nil {
|
||||||
|
reply = agentAskReply{User: who, Why: "the request could not be read"}
|
||||||
|
break
|
||||||
|
}
|
||||||
|
peer := askPeer{SID: client.UserSID, Name: who, PID: int(client.PID)}
|
||||||
|
reply = askAnswer(peer, req, func(time.Duration) {}, func() int { return int(client.PID) })
|
||||||
|
}
|
||||||
|
out, _ := json.Marshal(reply)
|
||||||
|
if err := c.write(append(out, '\n'), pipeIOTimeout); err != nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
_, _ = c.read(pipeIOTimeout)
|
||||||
|
}
|
||||||
|
|
||||||
|
// dialAskLane opens the service's ask pipe; p, ask.sock's path, does not
|
||||||
|
// apply here.
|
||||||
|
func dialAskLane(string) (askConn, error) {
|
||||||
|
c, err := dialServicePipe(askPipeName)
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
if err := pipeServerIsService(c.h); err != nil {
|
||||||
|
c.close()
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
return &askPipeClient{c: c}, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// askLaneAddr is where the lane is, as a message names it.
|
||||||
|
func askLaneAddr(string) string { return askPipeName }
|
||||||
|
|
||||||
|
// askPipeClient is the asking side's end of the pipe, read and written the
|
||||||
|
// way the lane's code reads and writes a socket: a deadline for the whole
|
||||||
|
// exchange, bytes in, bytes out.
|
||||||
|
type askPipeClient struct {
|
||||||
|
c *pipeConn
|
||||||
|
deadline time.Time
|
||||||
|
pending []byte
|
||||||
|
}
|
||||||
|
|
||||||
|
func (a *askPipeClient) SetDeadline(t time.Time) error {
|
||||||
|
a.deadline = t
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// left is what remains of the deadline for one call; 0 waits as long as it
|
||||||
|
// takes, which only a caller that set no deadline gets.
|
||||||
|
func (a *askPipeClient) left() time.Duration {
|
||||||
|
if a.deadline.IsZero() {
|
||||||
|
return 0
|
||||||
|
}
|
||||||
|
if d := time.Until(a.deadline); d > 0 {
|
||||||
|
return d
|
||||||
|
}
|
||||||
|
return time.Millisecond
|
||||||
|
}
|
||||||
|
|
||||||
|
func (a *askPipeClient) Read(b []byte) (int, error) {
|
||||||
|
for len(a.pending) == 0 {
|
||||||
|
n, err := a.c.read(a.left())
|
||||||
|
a.pending = append(a.pending, a.c.buf[:n]...)
|
||||||
|
if err != nil && !errors.Is(err, windows.ERROR_MORE_DATA) {
|
||||||
|
if len(a.pending) > 0 {
|
||||||
|
break
|
||||||
|
}
|
||||||
|
if errors.Is(err, windows.ERROR_BROKEN_PIPE) || errors.Is(err, windows.ERROR_PIPE_NOT_CONNECTED) {
|
||||||
|
return 0, io.EOF
|
||||||
|
}
|
||||||
|
return 0, err
|
||||||
|
}
|
||||||
|
}
|
||||||
|
n := copy(b, a.pending)
|
||||||
|
a.pending = a.pending[n:]
|
||||||
|
return n, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func (a *askPipeClient) Write(b []byte) (int, error) {
|
||||||
|
if err := a.c.write(b, a.left()); err != nil {
|
||||||
|
return 0, err
|
||||||
|
}
|
||||||
|
return len(b), nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func (a *askPipeClient) Close() error {
|
||||||
|
a.c.close()
|
||||||
|
return nil
|
||||||
|
}
|
||||||
@@ -0,0 +1,89 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
// askpeer.go — who is on the other end of the owner's lane, on every platform.
|
||||||
|
//
|
||||||
|
// The lane (agentask.go: ask.sock on Linux and macOS, the ask pipe on Windows,
|
||||||
|
// asklane_windows.go) learns the connecting account from the operating system,
|
||||||
|
// never from the request: a uid from the socket's peer credentials, or a SID
|
||||||
|
// from the pipe client's token. The machine's owner is recorded the same two
|
||||||
|
// ways (approvals_owner.go). Every refusal on the lane asks here, so both
|
||||||
|
// platforms answer with the same rules, and only the commands they name differ.
|
||||||
|
|
||||||
|
import (
|
||||||
|
"strconv"
|
||||||
|
"strings"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
type askPeer struct {
|
||||||
|
UID uint32 // Linux and macOS: the connecting process's account
|
||||||
|
SID string // Windows: the pipe client's token user; "" elsewhere
|
||||||
|
Name string // the account as messages name it
|
||||||
|
PID int // the connecting process; 0 when the platform does not say
|
||||||
|
}
|
||||||
|
|
||||||
|
// windows reports whether the peer came over the Windows pipe.
|
||||||
|
func (p askPeer) windows() bool { return p.SID != "" }
|
||||||
|
|
||||||
|
// laneOwnerMatch reads the recorded owner the way peer's platform names
|
||||||
|
// accounts. present is true when a record exists, readable or not; ownerName
|
||||||
|
// is how a refusal names the owner.
|
||||||
|
func laneOwnerMatch(p askPeer) (match bool, ownerName string, present bool, err error) {
|
||||||
|
if p.windows() {
|
||||||
|
sid, present, err := approvalsOwnerLoad()
|
||||||
|
if err != nil || !present {
|
||||||
|
return false, "", present, err
|
||||||
|
}
|
||||||
|
return strings.EqualFold(sid, p.SID), sid, true, nil
|
||||||
|
}
|
||||||
|
uid, name, present, err := ownerAccountLoad()
|
||||||
|
if err != nil || !present {
|
||||||
|
return false, "", present, err
|
||||||
|
}
|
||||||
|
if name == "" {
|
||||||
|
name = "uid " + strconv.FormatUint(uint64(uid), 10)
|
||||||
|
}
|
||||||
|
return uid == p.UID, name, true, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// ownerRecordCommand is the administrator's command that records peer's
|
||||||
|
// account as the machine's owner.
|
||||||
|
func ownerRecordCommand(p askPeer) string {
|
||||||
|
if p.windows() {
|
||||||
|
return adminCommandFor(true, "approvals-owner --sid "+p.SID)
|
||||||
|
}
|
||||||
|
return "sudo -H privatae-bastion approvals-owner --account " + accountForHint(p.Name)
|
||||||
|
}
|
||||||
|
|
||||||
|
// adminCommandFor is `privatae-bastion <cmd>` as the machine's administrator
|
||||||
|
// types it: in an Administrator terminal on Windows, with `sudo -H` elsewhere.
|
||||||
|
func adminCommandFor(windows bool, cmd string) string {
|
||||||
|
if windows {
|
||||||
|
return "privatae-bastion " + cmd + " (from an Administrator terminal)"
|
||||||
|
}
|
||||||
|
return "sudo -H privatae-bastion " + cmd
|
||||||
|
}
|
||||||
|
|
||||||
|
// askConn is one connection of the lane as the asking side holds it: a unix
|
||||||
|
// socket (net.Conn), or the Windows pipe client (asklane_windows.go).
|
||||||
|
type askConn interface {
|
||||||
|
Read(b []byte) (int, error)
|
||||||
|
Write(b []byte) (int, error)
|
||||||
|
Close() error
|
||||||
|
SetDeadline(t time.Time) error
|
||||||
|
}
|
||||||
|
|
||||||
|
const (
|
||||||
|
// askPipeName is the Windows service's ask pipe, the counterpart of
|
||||||
|
// ask.sock: any account on the machine may connect and ask; who it is
|
||||||
|
// comes from the pipe client's token.
|
||||||
|
askPipeName = `\\.\pipe\privatae-bastion-ask`
|
||||||
|
|
||||||
|
// askPipeSDDL: SYSTEM and Administrators full control; Authenticated
|
||||||
|
// Users (AU) read, write and synchronize, as any local account may
|
||||||
|
// connect to ask.sock. Not FILE_CREATE_PIPE_INSTANCE (FILE_APPEND_DATA,
|
||||||
|
// 0x4, on a pipe): 0x12019b is the approvals pipe's mask for the same
|
||||||
|
// reason (approvalpipe.go), so no client can stand up its own end of this
|
||||||
|
// name. P protects the DACL from inheritance.
|
||||||
|
askPipeSDDL = "D:P(A;;GA;;;SY)(A;;GA;;;BA)(A;;0x12019b;;;AU)"
|
||||||
|
)
|
||||||
@@ -0,0 +1,248 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"encoding/json"
|
||||||
|
"os"
|
||||||
|
"path/filepath"
|
||||||
|
"strings"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
const (
|
||||||
|
testOwnerSID = "S-1-5-21-1111111111-2222222222-3333333333-1001"
|
||||||
|
testOtherSID = "S-1-5-21-1111111111-2222222222-3333333333-1002"
|
||||||
|
)
|
||||||
|
|
||||||
|
// writeSIDOwner records sid as the machine's owner, as `approvals-owner --sid`
|
||||||
|
// writes it on Windows.
|
||||||
|
func writeSIDOwner(t *testing.T, dir, sid string) {
|
||||||
|
t.Helper()
|
||||||
|
if err := os.MkdirAll(dir, 0o700); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
raw, _ := json.Marshal(approvalsOwnerRecord{SID: sid, SetAt: time.Now().UTC().Format(time.RFC3339)})
|
||||||
|
if err := os.WriteFile(filepath.Join(dir, approvalsOwnerFile), raw, 0o600); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The Windows ask pipe answers the owner's reads, acts and console for the
|
||||||
|
// account whose SID the installer recorded, and refuses every other one, in
|
||||||
|
// Windows' own commands: no sudo anywhere.
|
||||||
|
//
|
||||||
|
// MUTATION: compare p.UID in laneOwnerMatch for a Windows peer. RESULT: red
|
||||||
|
// (the owner's SID is refused).
|
||||||
|
func TestTheAskPipeServesTheOwnersSIDOnly(t *testing.T) {
|
||||||
|
dir := isolateConfigDir(t)
|
||||||
|
owner := askPeer{SID: testOwnerSID, Name: `DESKTOP\owner (` + testOwnerSID + `)`}
|
||||||
|
other := askPeer{SID: testOtherSID, Name: `DESKTOP\other (` + testOtherSID + `)`}
|
||||||
|
|
||||||
|
why := readLaneRefusalFor(owner)
|
||||||
|
if !strings.Contains(why, "approvals-owner --sid "+testOwnerSID) || !strings.Contains(why, "Administrator terminal") {
|
||||||
|
t.Errorf("with no owner recorded, the refusal does not give Windows' command: %q", why)
|
||||||
|
}
|
||||||
|
writeSIDOwner(t, dir, testOwnerSID)
|
||||||
|
if why := readLaneRefusalFor(owner); why != "" {
|
||||||
|
t.Errorf("the owner's SID was refused a read: %s", why)
|
||||||
|
}
|
||||||
|
if why := consoleLaneRefusalFor(owner); why != "" {
|
||||||
|
t.Errorf("the owner's SID was refused the console: %s", why)
|
||||||
|
}
|
||||||
|
// Case differs between a SID read from a token and one typed.
|
||||||
|
if why := readLaneRefusalFor(askPeer{SID: strings.ToLower(testOwnerSID), Name: "owner"}); why != "" {
|
||||||
|
t.Errorf("the owner's SID in other case was refused: %s", why)
|
||||||
|
}
|
||||||
|
for _, why := range []string{readLaneRefusalFor(other), consoleLaneRefusalFor(other)} {
|
||||||
|
if why == "" || !strings.Contains(why, testOwnerSID) || !strings.Contains(why, other.Name) {
|
||||||
|
t.Errorf("another account was not refused, naming both: %q", why)
|
||||||
|
}
|
||||||
|
if strings.Contains(why, "sudo") {
|
||||||
|
t.Errorf("a Windows refusal names sudo: %q", why)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if r := serveActFor(other, agentAskRequest{Act: "deny", ID: "abcd1234"}); r.OK || r.User != other.Name {
|
||||||
|
t.Errorf("another account's act: %+v", r)
|
||||||
|
}
|
||||||
|
// A record of the other platform's kind is no owner here.
|
||||||
|
uid := uint32(1000)
|
||||||
|
raw, _ := json.Marshal(approvalsOwnerRecord{UID: &uid, Account: "someone"})
|
||||||
|
if err := os.WriteFile(filepath.Join(dir, approvalsOwnerFile), raw, 0o600); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if why := readLaneRefusalFor(owner); why == "" {
|
||||||
|
t.Error("a uid record let a Windows SID through")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// One dispatcher answers both lanes, so the pipe answers what the socket does.
|
||||||
|
func TestAskAnswerIsTheSocketsAnswer(t *testing.T) {
|
||||||
|
isolateConfigDir(t)
|
||||||
|
peer := askPeer{SID: testOwnerSID, Name: "owner"}
|
||||||
|
var extended []time.Duration
|
||||||
|
extend := func(d time.Duration) { extended = append(extended, d) }
|
||||||
|
if r, ok := askAnswer(peer, agentAskRequest{Op: "read", Read: "approvals"}, extend, func() int { return 0 }).(agentReadReply); !ok || r.OK {
|
||||||
|
t.Errorf("a read with no owner recorded: %+v", r)
|
||||||
|
}
|
||||||
|
if r, ok := askAnswer(peer, agentAskRequest{Op: "console"}, extend, func() int { return 0 }).(agentAskReply); !ok || r.OK || r.Why == "" {
|
||||||
|
t.Errorf("the console with no owner recorded: %+v", r)
|
||||||
|
}
|
||||||
|
pid := 0
|
||||||
|
if r, ok := askAnswer(peer, agentAskRequest{Op: "stop", PID: 4242}, extend, func() int { pid = 7; return 7 }).(agentAskReply); !ok || r.OK {
|
||||||
|
t.Errorf("a stop with no code set up: %+v", r)
|
||||||
|
}
|
||||||
|
if pid != 7 {
|
||||||
|
t.Error("a stop was filed without asking which process asked")
|
||||||
|
}
|
||||||
|
if len(extended) != 1 || extended[0] != readDeadline {
|
||||||
|
t.Errorf("deadlines given: %v", extended)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestAdminCommandsAreEachPlatformsOwn(t *testing.T) {
|
||||||
|
if got := adminCommandFor(true, "ui"); strings.Contains(got, "sudo") || !strings.Contains(got, "Administrator terminal") {
|
||||||
|
t.Errorf("windows: %q", got)
|
||||||
|
}
|
||||||
|
if got := adminCommandFor(false, "ui"); got != "sudo -H privatae-bastion ui" {
|
||||||
|
t.Errorf("unix: %q", got)
|
||||||
|
}
|
||||||
|
if !strings.Contains(askPipeSDDL, "0x12019b;;;AU") || strings.Contains(askPipeSDDL, "GW;;;AU") || strings.Contains(askPipeSDDL, "GA;;;AU") {
|
||||||
|
t.Errorf("the ask pipe's ACL gives every account more than read and write: %s", askPipeSDDL)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A page with no session names the command that opens it on this machine.
|
||||||
|
// The machine's console is not opened by "privatae-bastion ui" from just any
|
||||||
|
// account, and telling a person only that sent them back to a 401.
|
||||||
|
func TestNotSignedInNamesTheCommandThatOpensThisConsole(t *testing.T) {
|
||||||
|
if got := notSignedIn("ui", "windows", true); !strings.Contains(got, "Administrator terminal") ||
|
||||||
|
!strings.Contains(got, "owns this machine") || strings.Contains(got, "sudo") {
|
||||||
|
t.Errorf("the Windows service's console: %q", got)
|
||||||
|
}
|
||||||
|
if got := notSignedIn("ui", "linux", true); !strings.Contains(got, "sudo -H privatae-bastion ui") ||
|
||||||
|
!strings.Contains(got, "owns this machine") {
|
||||||
|
t.Errorf("the root bastion's console: %q", got)
|
||||||
|
}
|
||||||
|
if got := notSignedIn("ui", "windows", false); !strings.Contains(got, "`privatae-bastion ui`") || strings.Contains(got, "Administrator") {
|
||||||
|
t.Errorf("an account's own bastion: %q", got)
|
||||||
|
}
|
||||||
|
err := uiKeyRefused("127.0.0.1:7880", "401 Unauthorized", "windows", true, false)
|
||||||
|
if s := err.Error(); !strings.Contains(s, winServiceName) || strings.Contains(s, "sudo") || strings.Contains(s, "restart it") {
|
||||||
|
t.Errorf("a 401 beside the Windows service: %q", s)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A second start says what is running and how to reach it, and never that it
|
||||||
|
// should be ended: ending it was what the old words sent a person to do.
|
||||||
|
//
|
||||||
|
// MUTATION: drop the PID from secondRunWords. RESULT: red.
|
||||||
|
func TestASecondStartNamesTheRunningBastion(t *testing.T) {
|
||||||
|
task := runHolder{PID: 4242, Program: `C:\Users\someone\AppData\Local\Programs\privatae-bastion\privatae-bastion.exe`,
|
||||||
|
Started: "2026-11-02T18:02:00Z"}
|
||||||
|
console, dialog := secondRunWords(task, true)
|
||||||
|
for _, want := range []string{"4242", task.Program, "privatae-bastion ui", "Stop-Process -Id 4242"} {
|
||||||
|
if !strings.Contains(console, want) || !strings.Contains(dialog.Body, want) {
|
||||||
|
t.Errorf("the refusal does not say %q:\n%s\n%s", want, console, dialog.Body)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
svc, _ := secondRunWords(runHolder{PID: 9, Service: true}, true)
|
||||||
|
if !strings.Contains(svc, "as the "+winServiceName+" service") || !strings.Contains(svc, "Restart-Service "+winServiceName) {
|
||||||
|
t.Errorf("the service: %s", svc)
|
||||||
|
}
|
||||||
|
old, _ := secondRunWords(runHolder{}, false)
|
||||||
|
if !strings.Contains(old, "Get-Process privatae-bastion") {
|
||||||
|
t.Errorf("an older bastion holding the lock: %s", old)
|
||||||
|
}
|
||||||
|
for _, s := range []string{console, svc, old, dialog.Body} {
|
||||||
|
if strings.Contains(s, "Task Manager") || strings.Contains(s, "believe the running one is dead") {
|
||||||
|
t.Errorf("the refusal sends the person to end the running bastion: %s", s)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
dir := t.TempDir()
|
||||||
|
writeRunHolder(dir, true)
|
||||||
|
if h, ok := readRunHolder(dir); !ok || h.PID != os.Getpid() || !h.Console {
|
||||||
|
t.Errorf("the holder record: %+v, %v", h, ok)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A bastion relaunched by its predecessor's update waits for it to exit and
|
||||||
|
// then takes the lock, where it used to refuse as a second copy and leave the
|
||||||
|
// machine with none.
|
||||||
|
func TestARelaunchedBastionWaitsForThePredecessorsLock(t *testing.T) {
|
||||||
|
clock := time.Unix(0, 0)
|
||||||
|
now := func() time.Time { return clock }
|
||||||
|
sleep := func(d time.Duration) { clock = clock.Add(d) }
|
||||||
|
held := 3
|
||||||
|
try := func() error {
|
||||||
|
if held > 0 {
|
||||||
|
held--
|
||||||
|
return os.ErrExist
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
waited := 0
|
||||||
|
waitExit := func(pid int, d time.Duration) { waited = pid }
|
||||||
|
if err := takeRunLock(try, 4242, waitExit, 30*time.Second, now, sleep); err != nil {
|
||||||
|
t.Fatalf("the lock was not taken once the predecessor let go: %v", err)
|
||||||
|
}
|
||||||
|
if waited != 4242 {
|
||||||
|
t.Errorf("waited on process %d", waited)
|
||||||
|
}
|
||||||
|
held = 1 << 30
|
||||||
|
if err := takeRunLock(try, 4242, waitExit, 30*time.Second, now, sleep); err == nil {
|
||||||
|
t.Fatal("a lock held for ever was taken")
|
||||||
|
}
|
||||||
|
held, waited = 1, 0
|
||||||
|
if err := takeRunLock(try, 0, waitExit, 30*time.Second, now, sleep); err == nil || waited != 0 {
|
||||||
|
t.Errorf("a start that replaces nothing waited, or retried: %v, %d", err, waited)
|
||||||
|
}
|
||||||
|
t.Setenv(relaunchOfEnv, "4242")
|
||||||
|
if got := relaunchOf(); got != 4242 {
|
||||||
|
t.Errorf("relaunchOf = %d", got)
|
||||||
|
}
|
||||||
|
if _, set := os.LookupEnv(relaunchOfEnv); set {
|
||||||
|
t.Error("the predecessor's pid would pass on to what this bastion starts")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The Windows files wire it together: they are not built on Linux, so this
|
||||||
|
// reads them, as TestServiceModeOpensNothingOnTheDesktop does.
|
||||||
|
func TestTheWindowsFilesWireTheLaneTheCarryAndTheRelaunchWait(t *testing.T) {
|
||||||
|
for file, wants := range map[string][]string{
|
||||||
|
"relaunch_windows.go": {`relaunchOfEnv+"="+strconv.Itoa(os.Getpid())`},
|
||||||
|
"runguard_windows.go": {"takeRunLock(", "relaunchOf()", "writeRunHolder(d,", "secondRunWords("},
|
||||||
|
"sysservice_windows.go": {"carryStateInto(from, to)", "serviceCarrySource(serviceCarryFromSID)"},
|
||||||
|
"asklane_windows.go": {"askAnswer(peer, req", "pipeServerIsService(c.h)", "askPipeSDDL"},
|
||||||
|
"agentask.go": {"startAskPipe(done)"},
|
||||||
|
"../deploy/install.ps1": {"service install --from-account $owner"},
|
||||||
|
} {
|
||||||
|
src, err := os.ReadFile(file)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
for _, w := range wants {
|
||||||
|
if !strings.Contains(string(src), w) {
|
||||||
|
t.Errorf("%s no longer has %s", file, w)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
// The carry runs before the service's first start, not after it.
|
||||||
|
src, _ := os.ReadFile("sysservice_windows.go")
|
||||||
|
s := string(src)
|
||||||
|
if c, st := strings.Index(s, "carryStateInto(from, to)"), strings.Index(s, "s.Start()"); c < 0 || st < 0 || c > st {
|
||||||
|
t.Error("the carry is not before the service starts, so the service would start with no pairing")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A process that started after the connection was made is not the one that
|
||||||
|
// made it: its id was freed and reused, and answering it would answer a
|
||||||
|
// stranger as whoever holds that id now.
|
||||||
|
func TestAPipeClientStartedAfterItsConnectionIsNotTheCaller(t *testing.T) {
|
||||||
|
connected := time.Unix(1000, 0)
|
||||||
|
if !pipeClientNewer(connected.Add(time.Millisecond), connected) {
|
||||||
|
t.Error("a process created after the connection was taken for the caller")
|
||||||
|
}
|
||||||
|
if pipeClientNewer(connected.Add(-time.Hour), connected) {
|
||||||
|
t.Error("the process that connected was refused")
|
||||||
|
}
|
||||||
|
}
|
||||||
+90
-27
@@ -9,6 +9,7 @@ import (
|
|||||||
"encoding/json"
|
"encoding/json"
|
||||||
"errors"
|
"errors"
|
||||||
"fmt"
|
"fmt"
|
||||||
|
"io"
|
||||||
"os"
|
"os"
|
||||||
"path/filepath"
|
"path/filepath"
|
||||||
"sort"
|
"sort"
|
||||||
@@ -22,13 +23,13 @@ const backupUsage = `usage:
|
|||||||
make this bastion's backup key here and print what to register on your
|
make this bastion's backup key here and print what to register on your
|
||||||
host (Settings > Backup > keys: kind, label, public key). --replace makes
|
host (Settings > Backup > keys: kind, label, public key). --replace makes
|
||||||
a new one and keeps the old one, which still opens the backups made with it
|
a new one and keeps the old one, which still opens the backups made with it
|
||||||
privatae-bastion backup key show
|
privatae-bastion backup key show [--json]
|
||||||
the key this bastion holds, its fingerprint, and any older keys it keeps
|
the key this bastion holds, its fingerprint, and any older keys it keeps
|
||||||
privatae-bastion backup reseal --sidecar <file> --to <host key> [--stamp <stamp>]
|
privatae-bastion backup reseal --sidecar <file> --to <host key> [--stamp <stamp>]
|
||||||
[--out <file>] [--identity <key file>]
|
[--out <file>] [--identity <key file>]
|
||||||
seal one backup's key to a host's own key (age1... or base64), so that
|
seal one backup's key to a host's own key (age1... or base64), so that
|
||||||
host, and only it, can open that one backup
|
host, and only it, can open that one backup
|
||||||
privatae-bastion backup requests [--host <host>]
|
privatae-bastion backup requests [--host <host>] [--json]
|
||||||
restore requests your host sent this machine
|
restore requests your host sent this machine
|
||||||
privatae-bastion backup approve [--host <host>] <id> | deny [--host <host>] <id>
|
privatae-bastion backup approve [--host <host>] <id> | deny [--host <host>] <id>
|
||||||
answer one
|
answer one
|
||||||
@@ -39,7 +40,7 @@ const backupUsage = `usage:
|
|||||||
let the host paired as <host> list and send the backups in another
|
let the host paired as <host> list and send the backups in another
|
||||||
host's backup folder here (or any folder) — how a host that replaces a
|
host's backup folder here (or any folder) — how a host that replaces a
|
||||||
lost one reaches the copies the lost one kept on this machine
|
lost one reaches the copies the lost one kept on this machine
|
||||||
privatae-bastion backup shares --with <host> / unshare --with <host> <name>
|
privatae-bastion backup shares --with <host> [--json] / unshare --with <host> <name>
|
||||||
the folders shared with a host, and taking one back`
|
the folders shared with a host, and taking one back`
|
||||||
|
|
||||||
func cmdBackup(args []string) error {
|
func cmdBackup(args []string) error {
|
||||||
@@ -65,7 +66,11 @@ func cmdBackup(args []string) error {
|
|||||||
return cmdBackupKeyInit(replace, flags["--label"])
|
return cmdBackupKeyInit(replace, flags["--label"])
|
||||||
}
|
}
|
||||||
if len(args) >= 2 && args[1] == "show" {
|
if len(args) >= 2 && args[1] == "show" {
|
||||||
return cmdBackupKeyShow()
|
asJSON, err := jsonOnly(backupUsage, args[2:])
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
return cmdBackupKeyShow(asJSON)
|
||||||
}
|
}
|
||||||
case "reseal":
|
case "reseal":
|
||||||
flags, rest := backupFlags(args[1:], "--sidecar", "--to", "--stamp", "--out", "--identity")
|
flags, rest := backupFlags(args[1:], "--sidecar", "--to", "--stamp", "--out", "--identity")
|
||||||
@@ -75,10 +80,11 @@ func cmdBackup(args []string) error {
|
|||||||
return cmdBackupReseal(flags["--sidecar"], flags["--to"], flags["--stamp"], flags["--out"], flags["--identity"])
|
return cmdBackupReseal(flags["--sidecar"], flags["--to"], flags["--stamp"], flags["--out"], flags["--identity"])
|
||||||
case "requests":
|
case "requests":
|
||||||
host, rest := takeHostFlag(args[1:])
|
host, rest := takeHostFlag(args[1:])
|
||||||
if len(rest) != 0 {
|
asJSON, err := jsonOnly(backupUsage, rest)
|
||||||
return errors.New(backupUsage)
|
if err != nil {
|
||||||
|
return err
|
||||||
}
|
}
|
||||||
return cmdBackupRequests(host)
|
return cmdBackupRequests(host, asJSON)
|
||||||
case "approve", "deny":
|
case "approve", "deny":
|
||||||
host, rest := takeHostFlag(args[1:])
|
host, rest := takeHostFlag(args[1:])
|
||||||
if len(rest) != 1 {
|
if len(rest) != 1 {
|
||||||
@@ -93,10 +99,11 @@ func cmdBackup(args []string) error {
|
|||||||
return cmdBackupShare(flags["--with"], flags["--from"], flags["--dir"])
|
return cmdBackupShare(flags["--with"], flags["--from"], flags["--dir"])
|
||||||
case "shares":
|
case "shares":
|
||||||
flags, rest := backupFlags(args[1:], "--with")
|
flags, rest := backupFlags(args[1:], "--with")
|
||||||
if len(rest) != 0 || flags["--with"] == "" {
|
asJSON, err := jsonOnly(backupUsage, rest)
|
||||||
|
if err != nil || flags["--with"] == "" {
|
||||||
return errors.New(backupUsage)
|
return errors.New(backupUsage)
|
||||||
}
|
}
|
||||||
return cmdBackupShares(flags["--with"])
|
return cmdBackupShares(flags["--with"], asJSON)
|
||||||
case "unshare":
|
case "unshare":
|
||||||
flags, rest := backupFlags(args[1:], "--with")
|
flags, rest := backupFlags(args[1:], "--with")
|
||||||
if len(rest) != 1 || flags["--with"] == "" {
|
if len(rest) != 1 || flags["--with"] == "" {
|
||||||
@@ -163,24 +170,53 @@ func cmdBackupKeyInit(replace bool, label string) error {
|
|||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func cmdBackupKeyShow() error {
|
// backupKeysRead is every backup key this bastion holds, the current one
|
||||||
|
// marked. The secret half never leaves its file (backupKeyFile.Identity).
|
||||||
|
type backupKeysRead struct {
|
||||||
|
Keys []*backupKeyFile `json:"keys"`
|
||||||
|
Current string `json:"current,omitempty"` // its fingerprint
|
||||||
|
}
|
||||||
|
|
||||||
|
func readBackupKeys(readOpts) (backupKeysRead, error) {
|
||||||
active, all, err := backupKeysLoad()
|
active, all, err := backupKeysLoad()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return backupKeysRead{}, err
|
||||||
}
|
}
|
||||||
if len(all) == 0 {
|
v := backupKeysRead{Keys: all}
|
||||||
fmt.Println("no backup key on this machine — make one with `privatae-bastion backup key init`")
|
if v.Keys == nil {
|
||||||
return nil
|
v.Keys = []*backupKeyFile{}
|
||||||
}
|
}
|
||||||
for _, k := range all {
|
if active != nil {
|
||||||
|
v.Current = active.Fingerprint
|
||||||
|
}
|
||||||
|
return v, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func cmdBackupKeyShow(asJSON bool) error {
|
||||||
|
v, err := readMachine("backup-keys", readOpts{}, readBackupKeys)
|
||||||
|
if err != nil {
|
||||||
|
return laneRefusalError("backup key show", err)
|
||||||
|
}
|
||||||
|
if asJSON {
|
||||||
|
return printJSON(os.Stdout, v)
|
||||||
|
}
|
||||||
|
printBackupKeys(os.Stdout, v)
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func printBackupKeys(w io.Writer, v backupKeysRead) {
|
||||||
|
if len(v.Keys) == 0 {
|
||||||
|
fmt.Fprintln(w, "no backup key on this machine — make one with `privatae-bastion backup key init`")
|
||||||
|
return
|
||||||
|
}
|
||||||
|
for _, k := range v.Keys {
|
||||||
state := "older key (still opens the backups made with it)"
|
state := "older key (still opens the backups made with it)"
|
||||||
if active != nil && k.Fingerprint == active.Fingerprint {
|
if k.Fingerprint == v.Current {
|
||||||
state = "current key"
|
state = "current key"
|
||||||
}
|
}
|
||||||
fmt.Printf("%s %s\n public key: %s\n age recipient: %s\n made: %s\n key file: %s\n\n",
|
fmt.Fprintf(w, "%s %s\n public key: %s\n age recipient: %s\n made: %s\n key file: %s\n\n",
|
||||||
k.Fingerprint, state, k.PubB64, k.Recipient, k.CreatedAt, k.Path)
|
k.Fingerprint, state, k.PubB64, k.Recipient, k.CreatedAt, k.Path)
|
||||||
}
|
}
|
||||||
return nil
|
|
||||||
}
|
}
|
||||||
|
|
||||||
func backupIDs(identityFile string) ([]age.Identity, error) {
|
func backupIDs(identityFile string) ([]age.Identity, error) {
|
||||||
@@ -339,6 +375,9 @@ func pairingByName(name string) (*Config, error) {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
|
if cfg == nil && len(cfgs) == 0 {
|
||||||
|
return nil, fmt.Errorf("no host is paired with this bastion, so none is named '%s'", name)
|
||||||
|
}
|
||||||
if cfg == nil {
|
if cfg == nil {
|
||||||
return nil, fmt.Errorf("no pairing matches '%s' — paired hosts:\n %s", name, strings.Join(hostNames(cfgs), "\n "))
|
return nil, fmt.Errorf("no pairing matches '%s' — paired hosts:\n %s", name, strings.Join(hostNames(cfgs), "\n "))
|
||||||
}
|
}
|
||||||
@@ -379,22 +418,46 @@ func cmdBackupShare(with, from, dir string) error {
|
|||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func cmdBackupShares(with string) error {
|
// backupSharesRead is the folders shared with one pairing.
|
||||||
reader, err := pairingByName(with)
|
type backupSharesRead struct {
|
||||||
|
With string `json:"with"`
|
||||||
|
Shares []backupShare `json:"shares"`
|
||||||
|
}
|
||||||
|
|
||||||
|
func readBackupShares(o readOpts) (backupSharesRead, error) {
|
||||||
|
reader, err := pairingByName(o.Host)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return backupSharesRead{}, err
|
||||||
}
|
}
|
||||||
list := sharesFor(reader.HostName)
|
v := backupSharesRead{With: reader.HostName, Shares: sharesFor(reader.HostName)}
|
||||||
if len(list) == 0 {
|
if v.Shares == nil {
|
||||||
fmt.Println("no folders are shared with", reader.HostName)
|
v.Shares = []backupShare{}
|
||||||
return nil
|
|
||||||
}
|
}
|
||||||
for _, s := range list {
|
return v, nil
|
||||||
fmt.Printf("shared/%s %s (shared %s)\n", s.Slug, s.Dir, s.Added)
|
}
|
||||||
|
|
||||||
|
func cmdBackupShares(with string, asJSON bool) error {
|
||||||
|
v, err := readMachine("backup-shares", readOpts{Host: with}, readBackupShares)
|
||||||
|
if err != nil {
|
||||||
|
return laneRefusalError("backup shares --with "+with, err)
|
||||||
}
|
}
|
||||||
|
if asJSON {
|
||||||
|
return printJSON(os.Stdout, v)
|
||||||
|
}
|
||||||
|
printBackupShares(os.Stdout, v)
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func printBackupShares(w io.Writer, v backupSharesRead) {
|
||||||
|
if len(v.Shares) == 0 {
|
||||||
|
fmt.Fprintln(w, "no folders are shared with", v.With)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
for _, s := range v.Shares {
|
||||||
|
fmt.Fprintf(w, "shared/%s %s (shared %s)\n", s.Slug, s.Dir, s.Added)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func cmdBackupUnshare(with, slug string) error {
|
func cmdBackupUnshare(with, slug string) error {
|
||||||
reader, err := pairingByName(with)
|
reader, err := pairingByName(with)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
|
|||||||
+68
-17
@@ -45,6 +45,7 @@ import (
|
|||||||
"encoding/json"
|
"encoding/json"
|
||||||
"errors"
|
"errors"
|
||||||
"fmt"
|
"fmt"
|
||||||
|
"io"
|
||||||
"net/netip"
|
"net/netip"
|
||||||
"os"
|
"os"
|
||||||
"path/filepath"
|
"path/filepath"
|
||||||
@@ -579,28 +580,46 @@ func describeReseal(r *resealRequest) string {
|
|||||||
|
|
||||||
// ── the person's side, on this machine ──────────────────────────────────────
|
// ── the person's side, on this machine ──────────────────────────────────────
|
||||||
|
|
||||||
func cmdBackupRequests(host string) error {
|
// backupRequestView is one restore request as a read shows it: the armored
|
||||||
cfg, err := stepupPairing(host)
|
// key the host sent, and the one resealed for it, are left out (the digest of
|
||||||
|
// the one the host sent stays); both are sealed, and a read has no use for
|
||||||
|
// them.
|
||||||
|
type backupRequestView struct {
|
||||||
|
ID string `json:"id"`
|
||||||
|
State string `json:"state"`
|
||||||
|
Stamp string `json:"stamp"`
|
||||||
|
Pairing string `json:"pairing"`
|
||||||
|
HostNumber int64 `json:"host_number"`
|
||||||
|
HostLabel string `json:"host_label"`
|
||||||
|
To string `json:"to"`
|
||||||
|
ToFP string `json:"to_fp"`
|
||||||
|
SidecarSHA string `json:"sidecar_sha256"`
|
||||||
|
At string `json:"at"`
|
||||||
|
DecidedAt string `json:"decided_at,omitempty"`
|
||||||
|
Error string `json:"error,omitempty"`
|
||||||
|
Words string `json:"words"`
|
||||||
|
}
|
||||||
|
|
||||||
|
type backupRequestsRead struct {
|
||||||
|
Host string `json:"host"`
|
||||||
|
Requests []backupRequestView `json:"requests"`
|
||||||
|
// SetAside are request files found unreadable and kept, not read.
|
||||||
|
SetAside []string `json:"set_aside,omitempty"`
|
||||||
|
}
|
||||||
|
|
||||||
|
func readBackupRequests(o readOpts) (backupRequestsRead, error) {
|
||||||
|
cfg, err := stepupPairing(o.Host)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return backupRequestsRead{}, err
|
||||||
}
|
}
|
||||||
dir := cfg.dcnDir()
|
dir := cfg.dcnDir()
|
||||||
|
v := backupRequestsRead{Host: cfg.HostName, Requests: []backupRequestView{}}
|
||||||
// Request files set aside as unreadable (resealLoad) are named here, so
|
// Request files set aside as unreadable (resealLoad) are named here, so
|
||||||
// the person learns of them whichever process found them.
|
// the person learns of them whichever process found them.
|
||||||
if aside, _ := filepath.Glob(resealPath(dir) + resealAsideSuffix + "*"); len(aside) > 0 {
|
v.SetAside, _ = filepath.Glob(resealPath(dir) + resealAsideSuffix + "*")
|
||||||
fmt.Println("set aside as unreadable (kept, not read):")
|
|
||||||
for _, a := range aside {
|
|
||||||
fmt.Println(" " + a)
|
|
||||||
}
|
|
||||||
fmt.Println()
|
|
||||||
}
|
|
||||||
m, err := resealRead(dir)
|
m, err := resealRead(dir)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return v, err
|
||||||
}
|
|
||||||
if len(m) == 0 {
|
|
||||||
fmt.Println("no backup requests from", cfg.HostName)
|
|
||||||
return nil
|
|
||||||
}
|
}
|
||||||
ids := make([]string, 0, len(m))
|
ids := make([]string, 0, len(m))
|
||||||
for id := range m {
|
for id := range m {
|
||||||
@@ -608,12 +627,44 @@ func cmdBackupRequests(host string) error {
|
|||||||
}
|
}
|
||||||
sort.Slice(ids, func(i, j int) bool { return m[ids[i]].At < m[ids[j]].At })
|
sort.Slice(ids, func(i, j int) bool { return m[ids[i]].At < m[ids[j]].At })
|
||||||
for _, id := range ids {
|
for _, id := range ids {
|
||||||
fmt.Println(describeReseal(m[id]))
|
r := m[id]
|
||||||
fmt.Println()
|
v.Requests = append(v.Requests, backupRequestView{ID: r.ID, State: r.State, Stamp: r.Stamp,
|
||||||
|
Pairing: r.Pairing, HostNumber: r.HostNumber, HostLabel: r.HostLabel, To: r.To, ToFP: r.ToFP,
|
||||||
|
SidecarSHA: r.SidecarSH, At: r.At, DecidedAt: r.DecidedAt, Error: r.Error, Words: describeReseal(r)})
|
||||||
}
|
}
|
||||||
|
return v, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func cmdBackupRequests(host string, asJSON bool) error {
|
||||||
|
v, err := readMachine("backup-requests", readOpts{Host: host}, readBackupRequests)
|
||||||
|
if err != nil {
|
||||||
|
return laneRefusalError("backup requests", err)
|
||||||
|
}
|
||||||
|
if asJSON {
|
||||||
|
return printJSON(os.Stdout, v)
|
||||||
|
}
|
||||||
|
printBackupRequests(os.Stdout, v)
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func printBackupRequests(w io.Writer, v backupRequestsRead) {
|
||||||
|
if len(v.SetAside) > 0 {
|
||||||
|
fmt.Fprintln(w, "set aside as unreadable (kept, not read):")
|
||||||
|
for _, a := range v.SetAside {
|
||||||
|
fmt.Fprintln(w, " "+a)
|
||||||
|
}
|
||||||
|
fmt.Fprintln(w)
|
||||||
|
}
|
||||||
|
if len(v.Requests) == 0 {
|
||||||
|
fmt.Fprintln(w, "no backup requests from", v.Host)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
for _, r := range v.Requests {
|
||||||
|
fmt.Fprintln(w, r.Words)
|
||||||
|
fmt.Fprintln(w)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func cmdBackupDecide(host, prefix string, approve bool) error {
|
func cmdBackupDecide(host, prefix string, approve bool) error {
|
||||||
cfg, err := stepupPairing(host)
|
cfg, err := stepupPairing(host)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
|
|||||||
@@ -377,6 +377,12 @@ func TestEveryListenerThisPackageOpensIsInTheTable(t *testing.T) {
|
|||||||
"ops_action_linux.go:opActionProbeUnit:net.Listen": {"tcp", 1, "the action-op probe, 127.0.0.1:0, open while one probe unit dials it"},
|
"ops_action_linux.go:opActionProbeUnit:net.Listen": {"tcp", 1, "the action-op probe, 127.0.0.1:0, open while one probe unit dials it"},
|
||||||
"coders_linux.go:coderListenUnix:net.Listen": {"unix", 1, "a coder run's egress.sock, a unix socket file in its run dir, not a network port"},
|
"coders_linux.go:coderListenUnix:net.Listen": {"unix", 1, "a coder run's egress.sock, a unix socket file in its run dir, not a network port"},
|
||||||
"coders_other.go:coderListenUnix:net.Listen": {"unix", 1, "the same, off Linux (coder mode refuses there)"},
|
"coders_other.go:coderListenUnix:net.Listen": {"unix", 1, "the same, off Linux (coder mode refuses there)"},
|
||||||
|
// The one listener on every address, by design: the door a Host that
|
||||||
|
// this server can't reach connects to (hostdoor.go). Bound only while
|
||||||
|
// such a pairing is served or a pairing window is open; it keeps only
|
||||||
|
// connections whose certificate verifies under a served pairing's
|
||||||
|
// pinned CA, and forwards nothing (TestTheDoorRefusesAnythingButItsPinnedHost).
|
||||||
|
"hostdoor.go:listenDoor:lc.Listen": {"tcp", 1, "the door your Host connects to, every address, TCP 8812 (docs/host-connects.md)"},
|
||||||
// Beside a Windows system service: the tray's own approvals window,
|
// Beside a Windows system service: the tray's own approvals window,
|
||||||
// and the service's approvals pipe (approvalpipe.go), which takes no
|
// and the service's approvals pipe (approvalpipe.go), which takes no
|
||||||
// remote client (PIPE_REJECT_REMOTE_CLIENTS) and, by its ACL, only
|
// remote client (PIPE_REJECT_REMOTE_CLIENTS) and, by its ACL, only
|
||||||
|
|||||||
+19
-1
@@ -52,6 +52,11 @@ type Config struct {
|
|||||||
// pairing's age and not the time its credentials were last rotated (the
|
// pairing's age and not the time its credentials were last rotated (the
|
||||||
// file's mtime, which is what pairings from before this field fall back to).
|
// file's mtime, which is what pairings from before this field fall back to).
|
||||||
FirstSeen string `json:"first_seen,omitempty"`
|
FirstSeen string `json:"first_seen,omitempty"`
|
||||||
|
// Origin: how the pairing came to this bastion, for the Host that admits
|
||||||
|
// it (pairingsReport). "" was paired here; "carried" was moved in from an
|
||||||
|
// account's own bastion when the machine moved to the system service
|
||||||
|
// (servicecarry.go).
|
||||||
|
Origin string `json:"origin,omitempty"`
|
||||||
|
|
||||||
// How this pairing reaches its host (lane_socket.go). "" is WireGuard
|
// How this pairing reaches its host (lane_socket.go). "" is WireGuard
|
||||||
// through the relay to the host's tunnel address on :8443, which is every
|
// through the relay to the host's tunnel address on :8443, which is every
|
||||||
@@ -66,6 +71,12 @@ type Config struct {
|
|||||||
LaneSocket string `json:"lane_socket,omitempty"`
|
LaneSocket string `json:"lane_socket,omitempty"`
|
||||||
RunsDir string `json:"runs_dir,omitempty"`
|
RunsDir string `json:"runs_dir,omitempty"`
|
||||||
LaneAddr string `json:"lane_addr,omitempty"`
|
LaneAddr string `json:"lane_addr,omitempty"`
|
||||||
|
// HostDials marks a "tcp" pairing whose Host opens the connections
|
||||||
|
// (hostdoor.go): a Host this server can't reach, behind a home router,
|
||||||
|
// connects to this server's door at DoorAddr, and the lanes run over the
|
||||||
|
// connections it opens. LaneAddr is empty: nothing here ever dials it.
|
||||||
|
HostDials bool `json:"host_dials,omitempty"`
|
||||||
|
DoorAddr string `json:"door_addr,omitempty"`
|
||||||
|
|
||||||
// retired is set, under saveMu, once the run holding this copy has been
|
// retired is set, under saveMu, once the run holding this copy has been
|
||||||
// stopped or has ended (retireRun, run.go), and is never cleared; from then
|
// stopped or has ended (retireRun, run.go), and is never cleared; from then
|
||||||
@@ -101,9 +112,13 @@ const (
|
|||||||
// unixTransport says whether this pairing's lanes go over a local socket.
|
// unixTransport says whether this pairing's lanes go over a local socket.
|
||||||
func (c *Config) unixTransport() bool { return c.Transport == transportUnix }
|
func (c *Config) unixTransport() bool { return c.Transport == transportUnix }
|
||||||
|
|
||||||
// tcpTransport says whether this pairing's lanes go to a Host's lane port.
|
// tcpTransport says whether this pairing's lanes go to a Host's lane port,
|
||||||
|
// or come from a Host that connects to this server (hostDials).
|
||||||
func (c *Config) tcpTransport() bool { return c.Transport == transportTCP }
|
func (c *Config) tcpTransport() bool { return c.Transport == transportTCP }
|
||||||
|
|
||||||
|
// hostDials: a tcp pairing whose Host connects to this server (hostdoor.go).
|
||||||
|
func (c *Config) hostDials() bool { return c.tcpTransport() && c.HostDials }
|
||||||
|
|
||||||
// localTransport: a Host with no platform, over either local transport. Its
|
// localTransport: a Host with no platform, over either local transport. Its
|
||||||
// lanes run without a WireGuard device (run.go runUnixPairing).
|
// lanes run without a WireGuard device (run.go runUnixPairing).
|
||||||
func (c *Config) localTransport() bool { return c.unixTransport() || c.tcpTransport() }
|
func (c *Config) localTransport() bool { return c.unixTransport() || c.tcpTransport() }
|
||||||
@@ -419,6 +434,9 @@ func cmdUnpair(key string) error {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
// With the daemon running, its door's close does this too; stopped, it
|
||||||
|
// is done here, so the rule never outlives the last pairing that used it.
|
||||||
|
doorFirewallReleaseUnused()
|
||||||
fmt.Printf("unpaired %s — its tunnel and lanes are down; the context store and DCN state stay on disk\n", host)
|
fmt.Printf("unpaired %s — its tunnel and lanes are down; the context store and DCN state stay on disk\n", host)
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|||||||
+20
-20
@@ -35,7 +35,7 @@ func TestLegacyConfigMigration(t *testing.T) {
|
|||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
legacy := map[string]string{
|
legacy := map[string]string{
|
||||||
"host_name": "tenant-3.host.privatae.ai",
|
"host_name": "tenant-9003.host.privatae.ai",
|
||||||
"bearer": "mcp_x",
|
"bearer": "mcp_x",
|
||||||
"listen_addr": "127.0.0.1:7878",
|
"listen_addr": "127.0.0.1:7878",
|
||||||
}
|
}
|
||||||
@@ -48,7 +48,7 @@ func TestLegacyConfigMigration(t *testing.T) {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatalf("loadPairings: %v", err)
|
t.Fatalf("loadPairings: %v", err)
|
||||||
}
|
}
|
||||||
if len(cfgs) != 1 || cfgs[0].HostName != "tenant-3.host.privatae.ai" {
|
if len(cfgs) != 1 || cfgs[0].HostName != "tenant-9003.host.privatae.ai" {
|
||||||
t.Fatalf("migrated pairings = %+v, want the one legacy host", cfgs)
|
t.Fatalf("migrated pairings = %+v, want the one legacy host", cfgs)
|
||||||
}
|
}
|
||||||
if got, want := cfgs[0].ContextRoot, filepath.Join(cd, "context"); got != want {
|
if got, want := cfgs[0].ContextRoot, filepath.Join(cd, "context"); got != want {
|
||||||
@@ -57,7 +57,7 @@ func TestLegacyConfigMigration(t *testing.T) {
|
|||||||
if got, want := cfgs[0].DCNDir, filepath.Join(cd, "dcn"); got != want {
|
if got, want := cfgs[0].DCNDir, filepath.Join(cd, "dcn"); got != want {
|
||||||
t.Errorf("DCNDir = %q, want the explicit legacy default %q", got, want)
|
t.Errorf("DCNDir = %q, want the explicit legacy default %q", got, want)
|
||||||
}
|
}
|
||||||
if _, err := os.Stat(filepath.Join(cd, "pairings", "tenant-3.host.privatae.ai.json")); err != nil {
|
if _, err := os.Stat(filepath.Join(cd, "pairings", "tenant-9003.host.privatae.ai.json")); err != nil {
|
||||||
t.Errorf("pairings/<host>.json missing after migration: %v", err)
|
t.Errorf("pairings/<host>.json missing after migration: %v", err)
|
||||||
}
|
}
|
||||||
if _, err := os.Stat(filepath.Join(cd, "config.json")); !os.IsNotExist(err) {
|
if _, err := os.Stat(filepath.Join(cd, "config.json")); !os.IsNotExist(err) {
|
||||||
@@ -76,27 +76,27 @@ func TestLegacyConfigMigration(t *testing.T) {
|
|||||||
// existing pairing — both checked pre-redeem so a refusal can't burn the token.
|
// existing pairing — both checked pre-redeem so a refusal can't burn the token.
|
||||||
func TestCheckPairConflict(t *testing.T) {
|
func TestCheckPairConflict(t *testing.T) {
|
||||||
cfgs := []*Config{
|
cfgs := []*Config{
|
||||||
{HostName: "tenant-3.host.privatae.ai"},
|
{HostName: "tenant-9003.host.privatae.ai"},
|
||||||
{HostName: "tenant-122.host.privatae.ai"},
|
{HostName: "tenant-9122.host.privatae.ai"},
|
||||||
}
|
}
|
||||||
|
|
||||||
if _, err := checkPairConflict(cfgs, "tenant-122", false); err == nil {
|
if _, err := checkPairConflict(cfgs, "tenant-9122", false); err == nil {
|
||||||
t.Fatal("pairing an already-paired host must be refused without --replace")
|
t.Fatal("pairing an already-paired host must be refused without --replace")
|
||||||
}
|
}
|
||||||
got, err := checkPairConflict(cfgs, "tenant-122", true)
|
got, err := checkPairConflict(cfgs, "tenant-9122", true)
|
||||||
if err != nil || got == nil || got.HostName != "tenant-122.host.privatae.ai" {
|
if err != nil || got == nil || got.HostName != "tenant-9122.host.privatae.ai" {
|
||||||
t.Fatalf("--replace on a paired host = (%v, %v), want its existing pairing", got, err)
|
t.Fatalf("--replace on a paired host = (%v, %v), want its existing pairing", got, err)
|
||||||
}
|
}
|
||||||
if got, err := checkPairConflict(cfgs, "tenant-9", false); err != nil || got != nil {
|
if got, err := checkPairConflict(cfgs, "tenant-9500", false); err != nil || got != nil {
|
||||||
t.Fatalf("a NEW host must pair cleanly, got (%v, %v)", got, err)
|
t.Fatalf("a NEW host must pair cleanly, got (%v, %v)", got, err)
|
||||||
}
|
}
|
||||||
if _, err := checkPairConflict(cfgs, "tenant-9", true); err == nil {
|
if _, err := checkPairConflict(cfgs, "tenant-9500", true); err == nil {
|
||||||
t.Fatal("--replace on an unpaired host must be refused (nothing to replace)")
|
t.Fatal("--replace on an unpaired host must be refused (nothing to replace)")
|
||||||
}
|
}
|
||||||
// "tenant-1" is a prefix of tenant-122's host name but a different handle —
|
// "tenant-91" is a prefix of tenant-9122's host name but a different handle —
|
||||||
// it must NOT collide.
|
// it must NOT collide.
|
||||||
if got, err := checkPairConflict(cfgs, "tenant-1", false); err != nil || got != nil {
|
if got, err := checkPairConflict(cfgs, "tenant-91", false); err != nil || got != nil {
|
||||||
t.Fatalf("handle 'tenant-1' must not match tenant-122, got (%v, %v)", got, err)
|
t.Fatalf("handle 'tenant-91' must not match tenant-9122, got (%v, %v)", got, err)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -124,13 +124,13 @@ func TestNextListenAddr(t *testing.T) {
|
|||||||
// prefix; ambiguity is an error, not a guess.
|
// prefix; ambiguity is an error, not a guess.
|
||||||
func TestFindPairingHostFlag(t *testing.T) {
|
func TestFindPairingHostFlag(t *testing.T) {
|
||||||
cfgs := []*Config{
|
cfgs := []*Config{
|
||||||
{HostName: "tenant-3.host.privatae.ai"},
|
{HostName: "tenant-9003.host.privatae.ai"},
|
||||||
{HostName: "tenant-122.host.privatae.ai"},
|
{HostName: "tenant-9122.host.privatae.ai"},
|
||||||
}
|
}
|
||||||
for _, key := range []string{"tenant-3.host.privatae.ai", "tenant-3", "tenant-3."} {
|
for _, key := range []string{"tenant-9003.host.privatae.ai", "tenant-9003", "tenant-9003."} {
|
||||||
c, err := findPairing(cfgs, key)
|
c, err := findPairing(cfgs, key)
|
||||||
if err != nil || c == nil || c.HostName != "tenant-3.host.privatae.ai" {
|
if err != nil || c == nil || c.HostName != "tenant-9003.host.privatae.ai" {
|
||||||
t.Errorf("findPairing(%q) = (%v, %v), want tenant-3", key, c, err)
|
t.Errorf("findPairing(%q) = (%v, %v), want tenant-9003", key, c, err)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
if c, err := findPairing(cfgs, "nope"); err != nil || c != nil {
|
if c, err := findPairing(cfgs, "nope"); err != nil || c != nil {
|
||||||
@@ -145,8 +145,8 @@ func TestFindPairingHostFlag(t *testing.T) {
|
|||||||
// a pin synced for one host may never verify (or even be visible to) another's ops.
|
// a pin synced for one host may never verify (or even be visible to) another's ops.
|
||||||
func TestPerHostDcnDirs(t *testing.T) {
|
func TestPerHostDcnDirs(t *testing.T) {
|
||||||
cd := isolateConfigDir(t)
|
cd := isolateConfigDir(t)
|
||||||
a := &Config{HostName: "tenant-3.host.privatae.ai"}
|
a := &Config{HostName: "tenant-9003.host.privatae.ai"}
|
||||||
b := &Config{HostName: "tenant-122.host.privatae.ai"}
|
b := &Config{HostName: "tenant-9122.host.privatae.ai"}
|
||||||
dirA, dirB := a.dcnDir(), b.dcnDir()
|
dirA, dirB := a.dcnDir(), b.dcnDir()
|
||||||
if dirA == "" || dirB == "" || dirA == dirB {
|
if dirA == "" || dirB == "" || dirA == dirB {
|
||||||
t.Fatalf("per-host dcn dirs must differ: %q vs %q", dirA, dirB)
|
t.Fatalf("per-host dcn dirs must differ: %q vs %q", dirA, dirB)
|
||||||
|
|||||||
+156
-44
@@ -8,22 +8,32 @@ package main
|
|||||||
import (
|
import (
|
||||||
"errors"
|
"errors"
|
||||||
"fmt"
|
"fmt"
|
||||||
|
"io"
|
||||||
"os"
|
"os"
|
||||||
|
"sort"
|
||||||
"strconv"
|
"strconv"
|
||||||
"strings"
|
"strings"
|
||||||
"time"
|
"time"
|
||||||
)
|
)
|
||||||
|
|
||||||
// cmdStepupDrop revokes one unused approval this box issued for a pairing.
|
// cmdStepupDrop revokes one unused approval this box issued for a pairing.
|
||||||
|
// From the owner's account beside the machine's bastion it asks that
|
||||||
|
// bastion (owneracts.go): dropping only takes reach away, so no code.
|
||||||
func cmdStepupDrop(host string, machine bool, prefix string) error {
|
func cmdStepupDrop(host string, machine bool, prefix string) error {
|
||||||
|
return printOrAct(agentAskRequest{Act: "approvals-drop", Host: host, Machine: machine, ID: prefix},
|
||||||
|
stepupCommand("approvals drop", host, machine, prefix),
|
||||||
|
func() (string, error) { return stepupDropText(host, machine, prefix) })
|
||||||
|
}
|
||||||
|
|
||||||
|
func stepupDropText(host string, machine bool, prefix string) (string, error) {
|
||||||
t, err := resolveStepupTarget(host, machine)
|
t, err := resolveStepupTarget(host, machine)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return "", err
|
||||||
}
|
}
|
||||||
dir := t.dir
|
dir := t.dir
|
||||||
prefix = strings.TrimSpace(prefix)
|
prefix = strings.TrimSpace(prefix)
|
||||||
if prefix == "" {
|
if prefix == "" {
|
||||||
return errors.New("which approval? (the id `approve` printed)")
|
return "", errors.New("which approval? (the id `approve` printed)")
|
||||||
}
|
}
|
||||||
stepupMu.Lock()
|
stepupMu.Lock()
|
||||||
defer stepupMu.Unlock()
|
defer stepupMu.Unlock()
|
||||||
@@ -36,42 +46,45 @@ func cmdStepupDrop(host string, machine bool, prefix string) error {
|
|||||||
}
|
}
|
||||||
switch len(hits) {
|
switch len(hits) {
|
||||||
case 0:
|
case 0:
|
||||||
return fmt.Errorf("no unused approval starts with %q %s", prefix, t.forWhom())
|
return "", fmt.Errorf("no unused approval starts with %q %s", prefix, t.forWhom())
|
||||||
case 1:
|
case 1:
|
||||||
default:
|
default:
|
||||||
return fmt.Errorf("%d approvals start with %q — give more of the id", len(hits), prefix)
|
return "", fmt.Errorf("%d approvals start with %q — give more of the id", len(hits), prefix)
|
||||||
}
|
}
|
||||||
a := m[hits[0]]
|
a := m[hits[0]]
|
||||||
a.Used = true // burned without ever having run: the same end state a use reaches
|
a.Used = true // burned without ever having run: the same end state a use reaches
|
||||||
m[hits[0]] = a
|
m[hits[0]] = a
|
||||||
if err := approvalsSave(dir, m); err != nil {
|
if err := approvalsSave(dir, m); err != nil {
|
||||||
return err
|
return "", err
|
||||||
}
|
}
|
||||||
fmt.Printf("dropped approval %s (%s) — nothing can run on it now\n", hits[0][:8], a.Purpose)
|
return fmt.Sprintf("dropped approval %s (%s) — nothing can run on it now", hits[0][:8], a.Purpose), nil
|
||||||
return nil
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// cmdGrantsDrop removes a held store grant from this box.
|
// cmdGrantsDrop removes a held store grant from this box (through the
|
||||||
|
// owner's lane beside the machine's bastion, as cmdStepupDrop).
|
||||||
func cmdGrantsDrop(host, store string) error {
|
func cmdGrantsDrop(host, store string) error {
|
||||||
|
return printOrAct(agentAskRequest{Act: "grants-drop", Host: host, ID: store},
|
||||||
|
"grants drop "+store+hostFlagWords(host), func() (string, error) { return grantsDropText(host, store) })
|
||||||
|
}
|
||||||
|
|
||||||
|
func grantsDropText(host, store string) (string, error) {
|
||||||
cfg, err := stepupPairing(host)
|
cfg, err := stepupPairing(host)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return "", err
|
||||||
}
|
}
|
||||||
id, err := strconv.ParseInt(strings.TrimSpace(store), 10, 64)
|
id, err := strconv.ParseInt(strings.TrimSpace(store), 10, 64)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return errors.New("store id must be a number (the id on the host's store card)")
|
return "", errors.New("store id must be a number (the id on the host's store card)")
|
||||||
}
|
}
|
||||||
dir := cfg.dcnDir()
|
dir := cfg.dcnDir()
|
||||||
present, err := dcnDropStore(dir, id, "dropped at this machine's console")
|
present, err := dcnDropStore(dir, id, "dropped at this machine's console")
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return "", err
|
||||||
}
|
}
|
||||||
if !present {
|
if !present {
|
||||||
fmt.Printf("store %d was not held here for %s\n", id, cfg.HostName)
|
return fmt.Sprintf("store %d was not held here for %s", id, cfg.HostName), nil
|
||||||
return nil
|
|
||||||
}
|
}
|
||||||
fmt.Printf("store %d dropped for %s — the host's reads of it stop now and it learns on the next check-in\n", id, cfg.HostName)
|
return fmt.Sprintf("store %d dropped for %s — the host's reads of it stop now and it learns on the next check-in", id, cfg.HostName), nil
|
||||||
return nil
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// cmdQuarantineClear lifts this box's hold on a pairing's write lanes.
|
// cmdQuarantineClear lifts this box's hold on a pairing's write lanes.
|
||||||
@@ -90,65 +103,140 @@ func cmdQuarantineClear(host string) error {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// cmdOpsList prints the ops and op grants a pairing holds here (ops.go).
|
// cmdOpsList prints the ops and op grants a pairing holds here (ops.go).
|
||||||
func cmdOpsList(host string) error {
|
// opRow is one op a Host holds here, verified against its signature or not.
|
||||||
cfg, err := stepupPairing(host)
|
type opRow struct {
|
||||||
|
ID string `json:"id"`
|
||||||
|
Name string `json:"name,omitempty"`
|
||||||
|
Version string `json:"version,omitempty"`
|
||||||
|
Privilege string `json:"privilege,omitempty"`
|
||||||
|
Summary string `json:"summary,omitempty"`
|
||||||
|
NotVerified string `json:"not_verified,omitempty"`
|
||||||
|
}
|
||||||
|
|
||||||
|
// opGrantRow is one op grant this machine holds and has not dropped.
|
||||||
|
type opGrantRow struct {
|
||||||
|
ID string `json:"id"`
|
||||||
|
Op string `json:"op,omitempty"`
|
||||||
|
Version string `json:"version,omitempty"`
|
||||||
|
RunsLeft int `json:"runs_left"`
|
||||||
|
Until string `json:"until,omitempty"`
|
||||||
|
Within string `json:"within,omitempty"`
|
||||||
|
NotVerified string `json:"not_verified,omitempty"`
|
||||||
|
}
|
||||||
|
|
||||||
|
// opsRead is what ops and op grants one pairing holds on this machine.
|
||||||
|
type opsRead struct {
|
||||||
|
Host string `json:"host"`
|
||||||
|
Sandbox bool `json:"sandbox"`
|
||||||
|
SandboxUnavailable string `json:"sandbox_unavailable,omitempty"`
|
||||||
|
Ops []opRow `json:"ops"`
|
||||||
|
Grants []opGrantRow `json:"grants"`
|
||||||
|
}
|
||||||
|
|
||||||
|
func readOps(o readOpts) (opsRead, error) {
|
||||||
|
cfg, err := stepupPairing(o.Host)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return opsRead{}, err
|
||||||
}
|
}
|
||||||
dir := cfg.dcnDir()
|
dir := cfg.dcnDir()
|
||||||
ok, why := opSandboxAvailable()
|
v := opsRead{Host: cfg.HostName, Ops: []opRow{}, Grants: []opGrantRow{}}
|
||||||
if ok {
|
v.Sandbox, v.SandboxUnavailable = opSandboxAvailable()
|
||||||
fmt.Println("sandbox: available")
|
|
||||||
} else {
|
|
||||||
fmt.Println("sandbox: NOT available —", why)
|
|
||||||
}
|
|
||||||
n := 0
|
|
||||||
if entries, err := os.ReadDir(opsDir(dir)); err == nil {
|
if entries, err := os.ReadDir(opsDir(dir)); err == nil {
|
||||||
for _, e := range entries {
|
for _, e := range entries {
|
||||||
if !e.IsDir() || e.Name() == opsRunsDirName || strings.HasSuffix(e.Name(), ".tmp") {
|
if !e.IsDir() || e.Name() == opsRunsDirName || strings.HasSuffix(e.Name(), ".tmp") {
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
n++
|
r := opRow{ID: e.Name()[:12]}
|
||||||
if m, err := opLoad(dir, e.Name()); err == nil {
|
if m, err := opLoad(dir, e.Name()); err == nil {
|
||||||
fmt.Printf("op %s %s as %s [%s]\n %s\n", m.Name, m.Version, m.Privilege, e.Name()[:12], m.Summary)
|
r.Name, r.Version, r.Privilege, r.Summary = m.Name, m.Version, m.Privilege, m.Summary
|
||||||
} else {
|
} else {
|
||||||
fmt.Printf("op [%s] NOT VERIFIED: %v\n", e.Name()[:12], err)
|
r.NotVerified = err.Error()
|
||||||
}
|
}
|
||||||
|
v.Ops = append(v.Ops, r)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
f := opsLoad(dir)
|
f := opsLoad(dir)
|
||||||
|
nonces := make([]string, 0, len(f.Grants))
|
||||||
for nonce, rec := range f.Grants {
|
for nonce, rec := range f.Grants {
|
||||||
if rec.Dropped != "" {
|
if rec.Dropped == "" {
|
||||||
continue
|
nonces = append(nonces, nonce)
|
||||||
}
|
}
|
||||||
t, err := verifyOpTerms(dir, rec.TermsCanonical, rec.Signature, opKindGrant)
|
}
|
||||||
if err != nil {
|
sort.Strings(nonces)
|
||||||
fmt.Printf("grant [%s] NOT VERIFIED: %v\n", nonce[:8], err)
|
for _, nonce := range nonces {
|
||||||
continue
|
rec := f.Grants[nonce]
|
||||||
|
r := opGrantRow{ID: nonce[:8], RunsLeft: rec.UsesLeft}
|
||||||
|
if t, err := verifyOpTerms(dir, rec.TermsCanonical, rec.Signature, opKindGrant); err != nil {
|
||||||
|
r.NotVerified = err.Error()
|
||||||
|
} else {
|
||||||
|
r.Op, r.Version, r.Until, r.Within = t.Op, t.Version, t.Expires, t.Bounds
|
||||||
}
|
}
|
||||||
fmt.Printf("grant [%s] %s %s %d run(s) left, until %s\n within: %s\n", nonce[:8], t.Op, t.Version, rec.UsesLeft, t.Expires, t.Bounds)
|
v.Grants = append(v.Grants, r)
|
||||||
}
|
}
|
||||||
if n == 0 && len(f.Grants) == 0 {
|
return v, nil
|
||||||
fmt.Println("no ops held for", cfg.HostName)
|
}
|
||||||
|
|
||||||
|
func cmdOpsList(host string, asJSON bool) error {
|
||||||
|
v, err := readMachine("ops", readOpts{Host: host}, readOps)
|
||||||
|
if err != nil {
|
||||||
|
return laneRefusalError("ops", err)
|
||||||
}
|
}
|
||||||
|
if asJSON {
|
||||||
|
return printJSON(os.Stdout, v)
|
||||||
|
}
|
||||||
|
printOps(os.Stdout, v)
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func printOps(w io.Writer, v opsRead) {
|
||||||
|
if v.Sandbox {
|
||||||
|
fmt.Fprintln(w, "sandbox: available")
|
||||||
|
} else {
|
||||||
|
fmt.Fprintln(w, "sandbox: NOT available —", v.SandboxUnavailable)
|
||||||
|
}
|
||||||
|
for _, r := range v.Ops {
|
||||||
|
if r.NotVerified != "" {
|
||||||
|
fmt.Fprintf(w, "op [%s] NOT VERIFIED: %s\n", r.ID, r.NotVerified)
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
fmt.Fprintf(w, "op %s %s as %s [%s]\n %s\n", r.Name, r.Version, r.Privilege, r.ID, r.Summary)
|
||||||
|
}
|
||||||
|
for _, r := range v.Grants {
|
||||||
|
if r.NotVerified != "" {
|
||||||
|
fmt.Fprintf(w, "grant [%s] NOT VERIFIED: %s\n", r.ID, r.NotVerified)
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
fmt.Fprintf(w, "grant [%s] %s %s %d run(s) left, until %s\n within: %s\n", r.ID, r.Op, r.Version, r.RunsLeft, r.Until, r.Within)
|
||||||
|
}
|
||||||
|
if len(v.Ops) == 0 && len(v.Grants) == 0 {
|
||||||
|
fmt.Fprintln(w, "no ops held for", v.Host)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// cmdOpsDrop takes a held op grant back at the console.
|
// cmdOpsDrop takes a held op grant back at the console.
|
||||||
func cmdOpsDrop(host, prefix string) error {
|
func cmdOpsDrop(host, prefix string) error {
|
||||||
|
return printOrAct(agentAskRequest{Act: "ops-drop", Host: host, ID: prefix},
|
||||||
|
"ops drop "+prefix+hostFlagWords(host), func() (string, error) { return opsDropText(host, prefix) })
|
||||||
|
}
|
||||||
|
|
||||||
|
func opsDropText(host, prefix string) (string, error) {
|
||||||
cfg, err := stepupPairing(host)
|
cfg, err := stepupPairing(host)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return "", err
|
||||||
}
|
}
|
||||||
dir := cfg.dcnDir()
|
dir := cfg.dcnDir()
|
||||||
prefix = strings.TrimSpace(prefix)
|
prefix = strings.TrimSpace(prefix)
|
||||||
|
if prefix == "" {
|
||||||
|
// Every nonce starts with "": with one grant held, an empty id
|
||||||
|
// would drop it unnamed.
|
||||||
|
return "", errors.New("which op grant? (the id `privatae-bastion ops` lists, or --all)")
|
||||||
|
}
|
||||||
if prefix == "--all" {
|
if prefix == "--all" {
|
||||||
dropped, err := opsDropWhere(dir, "dropped at this machine's console", func(string, *opGrantRec) bool { return true })
|
dropped, err := opsDropWhere(dir, "dropped at this machine's console", func(string, *opGrantRec) bool { return true })
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return "", err
|
||||||
}
|
}
|
||||||
fmt.Printf("%d op grant(s) dropped — the host cannot run under any of them again\n", len(dropped))
|
return fmt.Sprintf("%d op grant(s) dropped — the host cannot run under any of them again", len(dropped)), nil
|
||||||
return nil
|
|
||||||
}
|
}
|
||||||
var hits []string
|
var hits []string
|
||||||
for nonce, rec := range opsLoad(dir).Grants {
|
for nonce, rec := range opsLoad(dir).Grants {
|
||||||
@@ -158,14 +246,38 @@ func cmdOpsDrop(host, prefix string) error {
|
|||||||
}
|
}
|
||||||
switch len(hits) {
|
switch len(hits) {
|
||||||
case 0:
|
case 0:
|
||||||
return fmt.Errorf("no held op grant starts with %q", prefix)
|
return "", fmt.Errorf("no held op grant starts with %q", prefix)
|
||||||
case 1:
|
case 1:
|
||||||
default:
|
default:
|
||||||
return fmt.Errorf("%d grants start with %q — give more of the id", len(hits), prefix)
|
return "", fmt.Errorf("%d grants start with %q — give more of the id", len(hits), prefix)
|
||||||
}
|
}
|
||||||
if _, err := opsDropGrant(dir, hits[0], "dropped at this machine's console"); err != nil {
|
if _, err := opsDropGrant(dir, hits[0], "dropped at this machine's console"); err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
return fmt.Sprintf("op grant %s dropped — the host cannot run under it again", hits[0][:8]), nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// printOrAct runs a narrowing act: through the owner's lane beside the
|
||||||
|
// machine's bastion (owneracts.go), else here, printing what it did either way.
|
||||||
|
func printOrAct(req agentAskRequest, adminCmd string, here func() (string, error)) error {
|
||||||
|
var done string
|
||||||
|
var err error
|
||||||
|
if readsGoThroughLane() {
|
||||||
|
done, err = actViaSock(req)
|
||||||
|
if err != nil {
|
||||||
|
return laneRefusalError(adminCmd, err)
|
||||||
|
}
|
||||||
|
} else if done, err = here(); err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
fmt.Printf("op grant %s dropped — the host cannot run under it again\n", hits[0][:8])
|
fmt.Println(done)
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// hostFlagWords is " --host <host>" when one was named.
|
||||||
|
func hostFlagWords(host string) string {
|
||||||
|
if host == "" {
|
||||||
|
return ""
|
||||||
|
}
|
||||||
|
return " --host " + host
|
||||||
|
}
|
||||||
|
|||||||
+67
-31
@@ -1,7 +1,8 @@
|
|||||||
package main
|
package main
|
||||||
|
|
||||||
// consolelane.go — the machine owner's own account opens the console of the
|
// consolelane.go — the machine owner's own account opens the console of the
|
||||||
// bastion installed for the whole machine, without sudo (Linux and macOS).
|
// bastion installed for the whole machine, without sudo on Linux and macOS
|
||||||
|
// and without an Administrator terminal on Windows.
|
||||||
//
|
//
|
||||||
// THE PROBLEM. Installed for the whole machine, the bastion runs as root and
|
// THE PROBLEM. Installed for the whole machine, the bastion runs as root and
|
||||||
// its console signs in with root's ui.secret. `privatae-bastion ui` run by the
|
// its console signs in with root's ui.secret. `privatae-bastion ui` run by the
|
||||||
@@ -9,7 +10,8 @@ package main
|
|||||||
// account's key, so the person reached their own machine's console only
|
// account's key, so the person reached their own machine's console only
|
||||||
// through sudo, and a browser started by sudo is root's, not theirs.
|
// through sudo, and a browser started by sudo is root's, not theirs.
|
||||||
//
|
//
|
||||||
// THE LANE. ask.sock (agentask.go) already tells the daemon, from the kernel,
|
// THE LANE. ask.sock (agentask.go), and on Windows the service's ask pipe
|
||||||
|
// (asklane_windows.go), already tells the daemon, from the operating system,
|
||||||
// which account connected. Asked for "console" by the account recorded as the
|
// which account connected. Asked for "console" by the account recorded as the
|
||||||
// machine's owner (owner_account.go), the daemon mints a one-use ticket of a
|
// machine's owner (owner_account.go), the daemon mints a one-use ticket of a
|
||||||
// LIMITED kind and answers with the link; `ui` opens it in the person's own
|
// LIMITED kind and answers with the link; `ui` opens it in the person's own
|
||||||
@@ -21,17 +23,18 @@ package main
|
|||||||
// read on this install. It is refused what widens access with no code today:
|
// read on this install. It is refused what widens access with no code today:
|
||||||
// pairing a Host, setting up or rotating the owner's code, choosing the Host
|
// pairing a Host, setting up or rotating the owner's code, choosing the Host
|
||||||
// in charge, proposing a folder, and the approval device's approvals. Those
|
// in charge, proposing a folder, and the approval device's approvals. Those
|
||||||
// stay with the administrator (`sudo -H privatae-bastion ui`). Codes typed for
|
// stay with the administrator (`sudo -H privatae-bastion ui`, or `ui` from an
|
||||||
|
// Administrator terminal on Windows). Codes typed for
|
||||||
// a Host's requests in a limited session are throttled as the owner's are
|
// a Host's requests in a limited session are throttled as the owner's are
|
||||||
// (machineCodeSpend), because guessing is the only attack left there.
|
// (machineCodeSpend), because guessing is the only attack left there.
|
||||||
|
|
||||||
import (
|
import (
|
||||||
"errors"
|
"errors"
|
||||||
|
"fmt"
|
||||||
"net/http"
|
"net/http"
|
||||||
"net/url"
|
"net/url"
|
||||||
"os"
|
"os"
|
||||||
"runtime"
|
"runtime"
|
||||||
"strconv"
|
|
||||||
"sync/atomic"
|
"sync/atomic"
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -45,21 +48,27 @@ var consoleLaneServer atomic.Pointer[uiServer]
|
|||||||
// consoleLaneRefusal says why account uid may not open the console through
|
// consoleLaneRefusal says why account uid may not open the console through
|
||||||
// the lane, or "" when it may.
|
// the lane, or "" when it may.
|
||||||
func consoleLaneRefusal(uid uint32, who string) string {
|
func consoleLaneRefusal(uid uint32, who string) string {
|
||||||
owner, ownerName, present, err := ownerAccountLoad()
|
return consoleLaneRefusalFor(askPeer{UID: uid, Name: who})
|
||||||
|
}
|
||||||
|
|
||||||
|
// consoleLaneRefusalFor is consoleLaneRefusal for a peer of either platform.
|
||||||
|
func consoleLaneRefusalFor(p askPeer) string {
|
||||||
|
admin := adminCommandFor(p.windows(), "ui")
|
||||||
|
match, ownerName, present, err := laneOwnerMatch(p)
|
||||||
switch {
|
switch {
|
||||||
case err != nil:
|
case err != nil:
|
||||||
return "this machine's owner account cannot be read (" + err.Error() + "); the administrator opens " +
|
return "this machine's owner account cannot be read (" + err.Error() + "); the administrator opens " +
|
||||||
"the console with: sudo -H privatae-bastion ui"
|
"the console with: " + admin
|
||||||
case !present:
|
case !present:
|
||||||
return "no account is recorded as this machine's owner, so the console opens only for the administrator: " +
|
return "no account is recorded as this machine's owner, so the console opens only for the administrator: " +
|
||||||
"sudo -H privatae-bastion ui. To open it from your own account, the administrator records it once: " +
|
admin + ". To open it from your own account, the administrator records it once: " + ownerRecordCommand(p)
|
||||||
"sudo -H privatae-bastion approvals-owner --account " + accountForHint(who)
|
case !match:
|
||||||
case owner != uid:
|
without := "without sudo"
|
||||||
name := ownerName
|
if p.windows() {
|
||||||
if name == "" {
|
without = "without an Administrator terminal"
|
||||||
name = "uid " + strconv.FormatUint(uint64(owner), 10)
|
|
||||||
}
|
}
|
||||||
return "this machine's console opens without sudo only for its owner's account (" + name + "), not " + who
|
return "this machine's console opens " + without + " only for its owner's account (" + ownerName + "), not " +
|
||||||
|
p.Name + ". The administrator opens it with: " + admin
|
||||||
}
|
}
|
||||||
return ""
|
return ""
|
||||||
}
|
}
|
||||||
@@ -74,7 +83,11 @@ func accountForHint(who string) string {
|
|||||||
// consoleLaneEntry is what the daemon answers an owner's "console" ask with:
|
// consoleLaneEntry is what the daemon answers an owner's "console" ask with:
|
||||||
// the link that redeems a fresh limited ticket.
|
// the link that redeems a fresh limited ticket.
|
||||||
func consoleLaneEntry(uid uint32, who string) (string, error) {
|
func consoleLaneEntry(uid uint32, who string) (string, error) {
|
||||||
if why := consoleLaneRefusal(uid, who); why != "" {
|
return consoleLaneEntryFor(askPeer{UID: uid, Name: who})
|
||||||
|
}
|
||||||
|
|
||||||
|
func consoleLaneEntryFor(p askPeer) (string, error) {
|
||||||
|
if why := consoleLaneRefusalFor(p); why != "" {
|
||||||
return "", errors.New(why)
|
return "", errors.New(why)
|
||||||
}
|
}
|
||||||
u := consoleLaneServer.Load()
|
u := consoleLaneServer.Load()
|
||||||
@@ -104,8 +117,9 @@ func (u *uiServer) signedIn(r *http.Request) bool {
|
|||||||
return u.sessions.valid(tok) || (u.limitedSessions != nil && u.limitedSessions.valid(tok))
|
return u.sessions.valid(tok) || (u.limitedSessions != nil && u.limitedSessions.valid(tok))
|
||||||
}
|
}
|
||||||
|
|
||||||
const consoleLaneAdminOnly = "From your own account the console does not do this: it widens what reaches this machine " +
|
var consoleLaneAdminOnly = "From your own account the console does not do this: it widens what reaches this machine " +
|
||||||
"with no code, or reads beyond your own account. The machine's administrator does it: sudo -H privatae-bastion ui"
|
"with no code, or reads beyond your own account. The machine's administrator does it: " +
|
||||||
|
adminCommandFor(runtime.GOOS == "windows", "ui")
|
||||||
|
|
||||||
// adminOnly wraps a route a limited session may not use.
|
// adminOnly wraps a route a limited session may not use.
|
||||||
func (u *uiServer) adminOnly(h http.HandlerFunc) http.HandlerFunc {
|
func (u *uiServer) adminOnly(h http.HandlerFunc) http.HandlerFunc {
|
||||||
@@ -120,32 +134,54 @@ func (u *uiServer) adminOnly(h http.HandlerFunc) http.HandlerFunc {
|
|||||||
|
|
||||||
// consoleEntryForThisAccount is the link `ui` opens. An account with a
|
// consoleEntryForThisAccount is the link `ui` opens. An account with a
|
||||||
// bastion of its own signs in with its own key (localUIEntryURL). An ordinary
|
// bastion of its own signs in with its own key (localUIEntryURL). An ordinary
|
||||||
// account beside the machine's root bastion asks the lane, and is told why
|
// account beside the machine's bastion asks the lane, and is told why not
|
||||||
// not when it is not the owner's.
|
// when it is not the owner's.
|
||||||
func consoleEntryForThisAccount() (entry, addr string, err error) {
|
func consoleEntryForThisAccount() (entry, addr string, err error) {
|
||||||
if runtime.GOOS != "windows" && os.Geteuid() != 0 && !uiDaemonListening() {
|
if runtime.GOOS == "windows" {
|
||||||
|
if systemService.installed && !machineAuthorityHeld() {
|
||||||
|
return consoleEntryThroughLane()
|
||||||
|
}
|
||||||
|
return localUIEntryURL()
|
||||||
|
}
|
||||||
|
if os.Geteuid() != 0 && !uiDaemonListening() {
|
||||||
p := askSockPath()
|
p := askSockPath()
|
||||||
if why := contextSockDialable(p); why != "" {
|
if why := contextSockDialable(p); why != "" {
|
||||||
return "", "", errors.New(why)
|
return "", "", errors.New(why)
|
||||||
}
|
}
|
||||||
if _, statErr := os.Stat(p); statErr == nil {
|
if _, statErr := os.Stat(p); statErr == nil {
|
||||||
r, err := askViaSock(agentAskRequest{Op: "console"})
|
return consoleEntryThroughLane()
|
||||||
if err != nil {
|
|
||||||
return "", "", errors.New("could not reach this machine's bastion at " + p + ": " + err.Error())
|
|
||||||
}
|
|
||||||
if !r.OK {
|
|
||||||
return "", "", errors.New(r.Why)
|
|
||||||
}
|
|
||||||
u, err := url.Parse(r.URL)
|
|
||||||
if err != nil || u.Scheme != "http" || !uiLoopbackHost(u.Host, u.Port()) {
|
|
||||||
return "", "", errors.New("this machine's bastion answered with a link that is not its own console")
|
|
||||||
}
|
|
||||||
return r.URL, u.Host, nil
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
return localUIEntryURL()
|
return localUIEntryURL()
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// consoleEntryThroughLane asks the machine's bastion for the owner's link.
|
||||||
|
func consoleEntryThroughLane() (entry, addr string, err error) {
|
||||||
|
p := askLaneAddr(askSockPath())
|
||||||
|
r, err := askViaSock(agentAskRequest{Op: "console"})
|
||||||
|
if err != nil {
|
||||||
|
if runtime.GOOS == "windows" {
|
||||||
|
// The service is there (systemService.installed) but its pipe is
|
||||||
|
// not: a service older than this command, or one not running.
|
||||||
|
return "", "", fmt.Errorf("this machine's bastion runs as the %s service, and it did not answer your "+
|
||||||
|
"account's request for its console on %s (%v).\n"+
|
||||||
|
" If the service is not running, start it: %s\n"+
|
||||||
|
" If it is older than this command, update it by running the installer again.\n"+
|
||||||
|
" Either way the administrator can open the console now: %s",
|
||||||
|
winServiceName, p, err, serviceRunHintFor("windows"), adminCommandFor(true, "ui"))
|
||||||
|
}
|
||||||
|
return "", "", errors.New("could not reach this machine's bastion at " + p + ": " + err.Error())
|
||||||
|
}
|
||||||
|
if !r.OK {
|
||||||
|
return "", "", errors.New(r.Why)
|
||||||
|
}
|
||||||
|
u, err := url.Parse(r.URL)
|
||||||
|
if err != nil || u.Scheme != "http" || !uiLoopbackHost(u.Host, u.Port()) {
|
||||||
|
return "", "", errors.New("this machine's bastion answered with a link that is not its own console")
|
||||||
|
}
|
||||||
|
return r.URL, u.Host, nil
|
||||||
|
}
|
||||||
|
|
||||||
// uiLimitedWriter marks a response as drawn for a limited session, so a page
|
// uiLimitedWriter marks a response as drawn for a limited session, so a page
|
||||||
// shows the administrator's command in place of a form the session would be
|
// shows the administrator's command in place of a form the session would be
|
||||||
// refused (Settings, Approvals). It changes what is drawn, never what is
|
// refused (Settings, Approvals). It changes what is drawn, never what is
|
||||||
|
|||||||
+5
-3
@@ -680,7 +680,7 @@ func handleDcnGrantSync(ws *websocket.Conn, dir string, args []string) {
|
|||||||
if dcnHasMask(terms, "search") {
|
if dcnHasMask(terms, "search") {
|
||||||
faEnsureStore(dir, payload.StoreID, terms, sweepFromCanonical(rec.TermsCanonical), rec.SealRecipient)
|
faEnsureStore(dir, payload.StoreID, terms, sweepFromCanonical(rec.TermsCanonical), rec.SealRecipient)
|
||||||
} else {
|
} else {
|
||||||
faStop(payload.StoreID)
|
faStop(dir, payload.StoreID)
|
||||||
}
|
}
|
||||||
dcnResult(ws, dir, "grant_sync", payload.StoreID, "", map[string]any{
|
dcnResult(ws, dir, "grant_sync", payload.StoreID, "", map[string]any{
|
||||||
"state": "ok", "root": terms.Root, "mask": terms.Mask,
|
"state": "ok", "root": terms.Root, "mask": terms.Mask,
|
||||||
@@ -708,14 +708,16 @@ func dcnDropStoreLocked(dir string, storeID int64, why string) (bool, error) {
|
|||||||
}
|
}
|
||||||
key := strconv.FormatInt(storeID, 10)
|
key := strconv.FormatInt(storeID, 10)
|
||||||
if _, ok := f.Stores[key]; !ok {
|
if _, ok := f.Stores[key]; !ok {
|
||||||
faStop(storeID) // nothing on disk, but never leave an orphan instance running
|
// Nothing on disk, but never leave an orphan instance running: this
|
||||||
|
// pairing's own (faKey), never another Host's for the same store id.
|
||||||
|
faStop(dir, storeID)
|
||||||
return false, nil
|
return false, nil
|
||||||
}
|
}
|
||||||
delete(f.Stores, key)
|
delete(f.Stores, key)
|
||||||
if err := dcnSaveFile(dir, f); err != nil {
|
if err := dcnSaveFile(dir, f); err != nil {
|
||||||
return true, err
|
return true, err
|
||||||
}
|
}
|
||||||
faStop(storeID)
|
faStop(dir, storeID)
|
||||||
dcnAudit(dir, "grant_drop", storeID, "", why)
|
dcnAudit(dir, "grant_drop", storeID, "", why)
|
||||||
return true, nil
|
return true, nil
|
||||||
}
|
}
|
||||||
|
|||||||
+73
-15
@@ -33,6 +33,7 @@ import (
|
|||||||
"encoding/json"
|
"encoding/json"
|
||||||
"errors"
|
"errors"
|
||||||
"fmt"
|
"fmt"
|
||||||
|
"io"
|
||||||
"os"
|
"os"
|
||||||
"path/filepath"
|
"path/filepath"
|
||||||
"sort"
|
"sort"
|
||||||
@@ -847,31 +848,82 @@ func deviceShownPath() (string, error) {
|
|||||||
return filepath.Join(d, "device_shown.json"), nil
|
return filepath.Join(d, "device_shown.json"), nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func cmdDeviceApprovals() error {
|
// deviceAsk is one ask waiting on this approval device.
|
||||||
|
type deviceAsk struct {
|
||||||
|
ID string `json:"id"`
|
||||||
|
Server string `json:"server"`
|
||||||
|
At string `json:"at"`
|
||||||
|
Words string `json:"words"`
|
||||||
|
}
|
||||||
|
|
||||||
|
type deviceApprovalsRead struct {
|
||||||
|
Asks []deviceAsk `json:"asks"`
|
||||||
|
}
|
||||||
|
|
||||||
|
func readDeviceApprovals(readOpts) (deviceApprovalsRead, error) {
|
||||||
deviceMu.Lock()
|
deviceMu.Lock()
|
||||||
m := deviceRequestsLoad()
|
m := deviceRequestsLoad()
|
||||||
deviceMu.Unlock()
|
deviceMu.Unlock()
|
||||||
shown := []string{}
|
v := deviceApprovalsRead{Asks: []deviceAsk{}}
|
||||||
for _, id := range sortedDeviceRequests(m) {
|
for _, id := range sortedDeviceRequests(m) {
|
||||||
r := m[id]
|
r := m[id]
|
||||||
if r.State != "pending" {
|
if r.State != "pending" {
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
shown = append(shown, id)
|
v.Asks = append(v.Asks, deviceAsk{ID: id, Server: r.Server, At: r.At, Words: r.Words})
|
||||||
fmt.Printf("[%s] on %s, asked %s\n%s\n\n", id[:8], r.Server, r.At, r.Words)
|
|
||||||
}
|
}
|
||||||
if p, err := deviceShownPath(); err == nil {
|
return v, nil
|
||||||
raw, _ := json.Marshal(shown)
|
}
|
||||||
_ = atomicWrite(p, raw)
|
|
||||||
|
// cmdDeviceApprovals lists the asks waiting here. Read in words by this
|
||||||
|
// process, it records them as shown, which is all `device-approve all` will
|
||||||
|
// sign. --json is for a program, not a person, and records nothing; nor does
|
||||||
|
// a list read through the lane, which `device-approve` from this account
|
||||||
|
// would not find.
|
||||||
|
func cmdDeviceApprovals(args []string) error {
|
||||||
|
asJSON, err := jsonOnly("usage: privatae-bastion device-approvals [--json]", args)
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
}
|
}
|
||||||
if len(shown) == 0 {
|
lane := readsGoThroughLane()
|
||||||
fmt.Println("nothing is waiting for your approval")
|
v, err := readMachine("device-approvals", readOpts{}, readDeviceApprovals)
|
||||||
return nil
|
if err != nil {
|
||||||
|
return laneRefusalError("device-approvals", err)
|
||||||
|
}
|
||||||
|
if asJSON {
|
||||||
|
return printJSON(os.Stdout, v)
|
||||||
|
}
|
||||||
|
printDeviceApprovals(os.Stdout, v, lane)
|
||||||
|
if !lane {
|
||||||
|
shown := []string{}
|
||||||
|
for _, a := range v.Asks {
|
||||||
|
shown = append(shown, a.ID)
|
||||||
|
}
|
||||||
|
if p, err := deviceShownPath(); err == nil {
|
||||||
|
raw, _ := json.Marshal(shown)
|
||||||
|
_ = atomicWrite(p, raw)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
fmt.Printf("approve one: privatae-bastion device-approve <id> all of the above: privatae-bastion device-approve all\n")
|
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// printDeviceApprovals prints the asks; lane: they were read from the
|
||||||
|
// machine's bastion, so they are answered as its administrator.
|
||||||
|
func printDeviceApprovals(w io.Writer, v deviceApprovalsRead, lane bool) {
|
||||||
|
for _, a := range v.Asks {
|
||||||
|
fmt.Fprintf(w, "[%s] on %s, asked %s\n%s\n\n", a.ID[:min(8, len(a.ID))], a.Server, a.At, a.Words)
|
||||||
|
}
|
||||||
|
switch {
|
||||||
|
case len(v.Asks) == 0:
|
||||||
|
fmt.Fprintln(w, "nothing is waiting for your approval")
|
||||||
|
case lane:
|
||||||
|
fmt.Fprintln(w, "These wait on the machine's bastion. As the administrator: sudo -H privatae-bastion device-approvals, "+
|
||||||
|
"then device-approve <id> or device-approve all")
|
||||||
|
default:
|
||||||
|
fmt.Fprintln(w, "approve one: privatae-bastion device-approve <id> all of the above: privatae-bastion device-approve all")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func cmdDeviceApprove(prefix string) error { return cmdDeviceApproveCode(prefix, "") }
|
func cmdDeviceApprove(prefix string) error { return cmdDeviceApproveCode(prefix, "") }
|
||||||
|
|
||||||
func cmdDeviceApproveCode(prefix, code string) error {
|
func cmdDeviceApproveCode(prefix, code string) error {
|
||||||
@@ -947,19 +999,25 @@ func cmdDeviceApproveCode(prefix, code string) error {
|
|||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// cmdDeviceDeny refuses one ask waiting on this approval device (through the
|
||||||
|
// owner's lane beside the machine's bastion: denying takes nothing).
|
||||||
func cmdDeviceDeny(prefix string) error {
|
func cmdDeviceDeny(prefix string) error {
|
||||||
|
return printOrAct(agentAskRequest{Act: "device-deny", ID: prefix}, "device-deny "+prefix,
|
||||||
|
func() (string, error) { return deviceDenyText(prefix) })
|
||||||
|
}
|
||||||
|
|
||||||
|
func deviceDenyText(prefix string) (string, error) {
|
||||||
deviceMu.Lock()
|
deviceMu.Lock()
|
||||||
m := deviceRequestsLoad()
|
m := deviceRequestsLoad()
|
||||||
deviceMu.Unlock()
|
deviceMu.Unlock()
|
||||||
id, err := findDeviceRequest(m, prefix)
|
id, err := findDeviceRequest(m, prefix)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return "", err
|
||||||
}
|
}
|
||||||
if err := deviceDeny(id); err != nil {
|
if err := deviceDeny(id); err != nil {
|
||||||
return err
|
return "", err
|
||||||
}
|
}
|
||||||
fmt.Printf("denied %s\n", id)
|
return "denied " + id, nil
|
||||||
return nil
|
|
||||||
}
|
}
|
||||||
|
|
||||||
func findDeviceRequest(m map[string]deviceRequest, prefix string) (string, error) {
|
func findDeviceRequest(m map[string]deviceRequest, prefix string) (string, error) {
|
||||||
|
|||||||
@@ -0,0 +1,369 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
// doctor.go — what is wrong with this install, and the fix for each one
|
||||||
|
// (plan Addendum 6, slice 3).
|
||||||
|
//
|
||||||
|
// privatae-bastion doctor [--json]
|
||||||
|
//
|
||||||
|
// Each check is a fact the bastion already holds, said as a problem and the
|
||||||
|
// command that fixes it. The machine's checks are built where its state is:
|
||||||
|
// in the daemon for the owner's account, through the lane (reads.go), or
|
||||||
|
// directly for the administrator and a per-account install. The one thing
|
||||||
|
// only the asking side can find out is whether the lane answers it at all,
|
||||||
|
// and that becomes the check when it does not. Exit status 1 when any check
|
||||||
|
// finds a problem, so a script can branch on it.
|
||||||
|
|
||||||
|
import (
|
||||||
|
"encoding/json"
|
||||||
|
"errors"
|
||||||
|
"fmt"
|
||||||
|
"io"
|
||||||
|
"os"
|
||||||
|
"path/filepath"
|
||||||
|
"runtime"
|
||||||
|
"sort"
|
||||||
|
"strings"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
const doctorUsage = "usage: privatae-bastion doctor [--json]"
|
||||||
|
|
||||||
|
type doctorCheck struct {
|
||||||
|
Name string `json:"name"`
|
||||||
|
OK bool `json:"ok"`
|
||||||
|
Detail string `json:"detail,omitempty"` // what was found, when all is well
|
||||||
|
Problem string `json:"problem,omitempty"`
|
||||||
|
Fix string `json:"fix,omitempty"` // the command, or what to do
|
||||||
|
}
|
||||||
|
|
||||||
|
type doctorRead struct {
|
||||||
|
Version string `json:"version"`
|
||||||
|
Checks []doctorCheck `json:"checks"`
|
||||||
|
}
|
||||||
|
|
||||||
|
func (d doctorRead) problems() int {
|
||||||
|
n := 0
|
||||||
|
for _, c := range d.Checks {
|
||||||
|
if !c.OK {
|
||||||
|
n++
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return n
|
||||||
|
}
|
||||||
|
|
||||||
|
// systemInstalled: the bastion is installed for the whole machine.
|
||||||
|
var systemInstalled = func() bool {
|
||||||
|
if runtime.GOOS == "linux" {
|
||||||
|
return linuxSystemUnitPresent()
|
||||||
|
}
|
||||||
|
return systemService.installed
|
||||||
|
}
|
||||||
|
|
||||||
|
// doctorSandbox is opSandboxAvailable, replaceable in a test: its probe
|
||||||
|
// re-executes this binary.
|
||||||
|
var doctorSandbox = opSandboxAvailable
|
||||||
|
|
||||||
|
// asAdmin is a bastion command said the way it has to be typed here: the
|
||||||
|
// machine's bastion keeps its state as the administrator when it is
|
||||||
|
// installed for the whole machine.
|
||||||
|
func asAdmin(cmd string) string {
|
||||||
|
switch {
|
||||||
|
case !systemInstalled():
|
||||||
|
return "privatae-bastion " + cmd
|
||||||
|
case runtime.GOOS == "windows":
|
||||||
|
return "privatae-bastion " + cmd + " (from an Administrator terminal)"
|
||||||
|
}
|
||||||
|
return "sudo -H privatae-bastion " + cmd
|
||||||
|
}
|
||||||
|
|
||||||
|
// installerCommand is how this platform installs the bastion, and so how a
|
||||||
|
// machine no Host updates moves to a newer version.
|
||||||
|
func installerCommand() string {
|
||||||
|
if runtime.GOOS == "windows" {
|
||||||
|
return "irm https://privatae.ai/bastion/install.ps1 | iex"
|
||||||
|
}
|
||||||
|
return "curl -fsSL https://privatae.ai/bastion/install.sh | sh"
|
||||||
|
}
|
||||||
|
|
||||||
|
// doctorLatest is the newest published version, or "" when it cannot be
|
||||||
|
// known: the daemon's last answer, else the last time doctor asked
|
||||||
|
// privatae.ai, if that was within updateCheckEvery, else one fetch that
|
||||||
|
// waits at most doctorLatestWait. A request to privatae.ai carries this
|
||||||
|
// machine's address to the platform, so doctor keeps update.go's rate
|
||||||
|
// (four a day): a run in its own process, or an agent polling it, asks again
|
||||||
|
// only once that time has passed, whether the last ask was answered or not.
|
||||||
|
// Running with no route to privatae.ai is supported (update.go), so "" is
|
||||||
|
// not a problem.
|
||||||
|
var (
|
||||||
|
doctorLatestWait = 10 * time.Second
|
||||||
|
doctorLatest = func() string {
|
||||||
|
latestMu.Lock()
|
||||||
|
v := latestPublished
|
||||||
|
latestMu.Unlock()
|
||||||
|
if v != "" {
|
||||||
|
return v
|
||||||
|
}
|
||||||
|
if r, ok := doctorAskedLoad(); ok && doctorNow().Sub(r.AskedAt) < updateCheckEvery {
|
||||||
|
return r.Version
|
||||||
|
}
|
||||||
|
got := make(chan string, 1)
|
||||||
|
go func() {
|
||||||
|
v, err := doctorFetch()
|
||||||
|
if err != nil {
|
||||||
|
v = ""
|
||||||
|
}
|
||||||
|
got <- strings.TrimSpace(v)
|
||||||
|
}()
|
||||||
|
select {
|
||||||
|
case v = <-got:
|
||||||
|
case <-time.After(doctorLatestWait):
|
||||||
|
}
|
||||||
|
if v != "" {
|
||||||
|
recordLatestPublished(v)
|
||||||
|
} else if r, ok := doctorAskedLoad(); ok {
|
||||||
|
v = r.Version // no answer this time: the last one stands, as in update.go
|
||||||
|
}
|
||||||
|
doctorAskedSave(doctorAsked{Version: v, AskedAt: doctorNow()})
|
||||||
|
return v
|
||||||
|
}
|
||||||
|
doctorNow = time.Now
|
||||||
|
doctorFetch = func() (string, error) {
|
||||||
|
m, err := fetchManifest()
|
||||||
|
if err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
return m.Version, nil
|
||||||
|
}
|
||||||
|
)
|
||||||
|
|
||||||
|
// doctorAsked is when doctor last asked privatae.ai, and what it knew after.
|
||||||
|
type doctorAsked struct {
|
||||||
|
Version string `json:"version"`
|
||||||
|
AskedAt time.Time `json:"asked_at"`
|
||||||
|
}
|
||||||
|
|
||||||
|
func doctorAskedPath() (string, error) {
|
||||||
|
d, err := configDir()
|
||||||
|
if err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
return filepath.Join(d, "doctor_latest.json"), nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func doctorAskedLoad() (doctorAsked, bool) {
|
||||||
|
var r doctorAsked
|
||||||
|
p, err := doctorAskedPath()
|
||||||
|
if err != nil {
|
||||||
|
return r, false
|
||||||
|
}
|
||||||
|
raw, err := os.ReadFile(p)
|
||||||
|
if err != nil || json.Unmarshal(raw, &r) != nil || r.AskedAt.IsZero() {
|
||||||
|
return doctorAsked{}, false
|
||||||
|
}
|
||||||
|
return r, true
|
||||||
|
}
|
||||||
|
|
||||||
|
func doctorAskedSave(r doctorAsked) {
|
||||||
|
p, err := doctorAskedPath()
|
||||||
|
if err != nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if raw, err := json.Marshal(r); err == nil {
|
||||||
|
_ = atomicWrite(p, raw)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// logHint is where the bastion's own log is read on this platform.
|
||||||
|
func logHint() string {
|
||||||
|
switch runtime.GOOS {
|
||||||
|
case "linux":
|
||||||
|
if systemInstalled() {
|
||||||
|
return "journalctl -u privatae-bastion"
|
||||||
|
}
|
||||||
|
return "journalctl --user -u privatae-bastion"
|
||||||
|
case "windows":
|
||||||
|
return "the bastion's window, or Event Viewer when it runs as a service"
|
||||||
|
}
|
||||||
|
return "Console.app, process privatae-bastion"
|
||||||
|
}
|
||||||
|
|
||||||
|
func readDoctor(readOpts) (doctorRead, error) {
|
||||||
|
d := doctorRead{Version: clientVersion, Checks: []doctorCheck{}}
|
||||||
|
add := func(c doctorCheck) { d.Checks = append(d.Checks, c) }
|
||||||
|
|
||||||
|
s, err := readStatus(readOpts{})
|
||||||
|
if err != nil {
|
||||||
|
add(doctorCheck{Name: "pairings", Problem: sentenceCase(err.Error()) + ".",
|
||||||
|
Fix: "The bastion's log says why: " + logHint()})
|
||||||
|
return d, nil
|
||||||
|
}
|
||||||
|
paired := len(s.Pairings) > 0
|
||||||
|
start := runCommandHint()
|
||||||
|
if runtime.GOOS == "linux" && systemInstalled() {
|
||||||
|
start = "sudo " + start
|
||||||
|
}
|
||||||
|
switch {
|
||||||
|
case s.Running == "no":
|
||||||
|
add(doctorCheck{Name: "running", Problem: "The bastion is not running, so nothing on this machine is watched.",
|
||||||
|
Fix: start})
|
||||||
|
case !paired:
|
||||||
|
add(doctorCheck{Name: "running", OK: true, Detail: "Running on its own; no Host is connected."})
|
||||||
|
default:
|
||||||
|
add(doctorCheck{Name: "running", OK: true, Detail: fmt.Sprintf("Running, paired with %d Host(s).", len(s.Pairings))})
|
||||||
|
}
|
||||||
|
|
||||||
|
switch latest := doctorLatest(); {
|
||||||
|
case latest == "":
|
||||||
|
add(doctorCheck{Name: "version", OK: true, Detail: "This is " + clientVersion +
|
||||||
|
"; the latest published version could not be read from privatae.ai."})
|
||||||
|
case versionNewer(latest, clientVersion):
|
||||||
|
fix := "Run the installer again: " + installerCommand()
|
||||||
|
if paired {
|
||||||
|
fix = "Your Host can update it (Network app, Update), or run the installer again: " + installerCommand()
|
||||||
|
}
|
||||||
|
add(doctorCheck{Name: "version", Problem: "Version " + latest + " is published; this machine runs " +
|
||||||
|
clientVersion + ".", Fix: fix})
|
||||||
|
default:
|
||||||
|
add(doctorCheck{Name: "version", OK: true, Detail: clientVersion + " is the latest published version."})
|
||||||
|
}
|
||||||
|
|
||||||
|
if systemInstalled() {
|
||||||
|
_, name, present, err := ownerAccountLoad()
|
||||||
|
fix := "sudo -H privatae-bastion approvals-owner --account <your account>"
|
||||||
|
if runtime.GOOS == "windows" {
|
||||||
|
fix = "privatae-bastion approvals-owner --sid <your account's SID> (from an Administrator terminal)"
|
||||||
|
}
|
||||||
|
switch {
|
||||||
|
case err != nil:
|
||||||
|
add(doctorCheck{Name: "owner", Problem: "This machine's owner account cannot be read (" + err.Error() + ").",
|
||||||
|
Fix: strings.Replace(fix, "approvals-owner ", "approvals-owner --replace ", 1)})
|
||||||
|
case !present:
|
||||||
|
add(doctorCheck{Name: "owner", Problem: "No account is recorded as this machine's owner, so the console " +
|
||||||
|
"opens only for the administrator, and agents in your account can neither read the machine nor ask it " +
|
||||||
|
"to stop an agent.", Fix: fix})
|
||||||
|
default:
|
||||||
|
add(doctorCheck{Name: "owner", OK: true, Detail: "The machine's owner account is " + name + "."})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
factor := existingMachineFactorDir()
|
||||||
|
if stepupEnrolled(factor) {
|
||||||
|
add(doctorCheck{Name: "second factor", OK: true, Detail: "The machine's owner has a second factor here."})
|
||||||
|
} else {
|
||||||
|
add(doctorCheck{Name: "second factor", Problem: "This machine has no second factor of its own, so a stop, " +
|
||||||
|
"and every ask an agent files, cannot be approved.", Fix: asAdmin("stepup-enroll --machine")})
|
||||||
|
}
|
||||||
|
|
||||||
|
now := time.Now()
|
||||||
|
var held []string
|
||||||
|
for account, e := range askQuarantineLoad(factor) {
|
||||||
|
if quarantinedAt(e, now) {
|
||||||
|
held = append(held, account)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
sort.Strings(held)
|
||||||
|
for _, account := range held {
|
||||||
|
add(doctorCheck{Name: "held asker", Problem: sentenceCase(askHoldRefusal(account, askHeldUntil(factor, account, now))) + ".",
|
||||||
|
Fix: asAdmin("quarantine clear --asker " + account)})
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, c := range doorFirewallChecks(s.Firewall) {
|
||||||
|
add(c)
|
||||||
|
}
|
||||||
|
if s.LLM != nil {
|
||||||
|
add(doctorCheck{Name: "model server", OK: true, Detail: sentenceCase(s.LLM.words()) + "."})
|
||||||
|
}
|
||||||
|
for _, p := range s.Pairings {
|
||||||
|
switch {
|
||||||
|
case p.Problem != "":
|
||||||
|
add(doctorCheck{Name: "host " + p.Host, Problem: "The pairing with " + p.Host + " is not usable: " +
|
||||||
|
p.Problem + ".", Fix: "The bastion's log says more: " + logHint()})
|
||||||
|
case p.WaitingFor != "":
|
||||||
|
add(doctorCheck{Name: "host " + p.Host, OK: true, Detail: p.Host + " waits for " + p.WaitingFor +
|
||||||
|
" to admit it; " + p.WaitingFor + " asks you to approve it."})
|
||||||
|
case !p.Answering && s.Running != "no":
|
||||||
|
add(doctorCheck{Name: "host " + p.Host, Problem: "The bastion is not serving " + p.Host +
|
||||||
|
" (nothing answers on " + p.Local + ").", Fix: "The bastion's log says why: " + logHint()})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if paired {
|
||||||
|
localDenyMu.Lock()
|
||||||
|
_, derr := localDenyLoad()
|
||||||
|
localDenyMu.Unlock()
|
||||||
|
if derr != nil {
|
||||||
|
add(doctorCheck{Name: "switches", Problem: localDenyUnreadableText(derr), Fix: asAdmin("switch --reset")})
|
||||||
|
}
|
||||||
|
if ok, why := doctorSandbox(); !ok {
|
||||||
|
c := doctorCheck{Name: "sandbox", Problem: "Ops a Host sends cannot run sandboxed here: " + why + "."}
|
||||||
|
if !processIsRoot() {
|
||||||
|
c.Fix = "Install the bastion for the whole machine: run the installer again without --just-me: " +
|
||||||
|
installerCommand()
|
||||||
|
}
|
||||||
|
add(c)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return d, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func cmdDoctor(args []string) error {
|
||||||
|
asJSON, err := jsonOnly(doctorUsage, args)
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
d, err := readMachine("doctor", readOpts{}, readDoctor)
|
||||||
|
var le *laneError
|
||||||
|
if errors.As(err, &le) {
|
||||||
|
// The one check the machine cannot make for this account.
|
||||||
|
d = doctorRead{Version: clientVersion, Checks: []doctorCheck{laneCheck(le)}}
|
||||||
|
err = nil
|
||||||
|
}
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
if asJSON {
|
||||||
|
if err := printJSON(os.Stdout, d); err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
printDoctor(os.Stdout, d)
|
||||||
|
}
|
||||||
|
if d.problems() > 0 {
|
||||||
|
return quietExit{code: 1}
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// laneCheck is the lane not answering this account, as a check.
|
||||||
|
func laneCheck(le *laneError) doctorCheck {
|
||||||
|
if le.down {
|
||||||
|
fix := "Start it: sudo " + runCommandHintFor(runtime.GOOS) + " (see whether it runs: systemctl status privatae-bastion)"
|
||||||
|
if runtime.GOOS != "linux" {
|
||||||
|
fix = "Start it: " + runCommandHint()
|
||||||
|
}
|
||||||
|
return doctorCheck{Name: "running", Problem: "The machine's bastion does not answer this account: " + le.why + ".",
|
||||||
|
Fix: fix}
|
||||||
|
}
|
||||||
|
return doctorCheck{Name: "reads", Problem: sentenceCase(le.why) + ".",
|
||||||
|
Fix: "As the administrator: sudo -H privatae-bastion doctor"}
|
||||||
|
}
|
||||||
|
|
||||||
|
func printDoctor(w io.Writer, d doctorRead) {
|
||||||
|
switch n := d.problems(); n {
|
||||||
|
case 0:
|
||||||
|
fmt.Fprintf(w, "privatae-bastion %s: nothing wrong found.\n", d.Version)
|
||||||
|
case 1:
|
||||||
|
fmt.Fprintf(w, "privatae-bastion %s: 1 problem.\n", d.Version)
|
||||||
|
default:
|
||||||
|
fmt.Fprintf(w, "privatae-bastion %s: %d problems.\n", d.Version, n)
|
||||||
|
}
|
||||||
|
for _, c := range d.Checks {
|
||||||
|
if c.OK {
|
||||||
|
fmt.Fprintln(w, " ok "+c.Detail)
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
fmt.Fprintln(w, " PROBLEM "+c.Problem)
|
||||||
|
if c.Fix != "" {
|
||||||
|
fmt.Fprintln(w, " Fix: "+c.Fix)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
+1059
File diff suppressed because it is too large
Load Diff
@@ -0,0 +1,50 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
import "testing"
|
||||||
|
|
||||||
|
// --listapps as macOS prints it before 15 (the state on the entry's line, or
|
||||||
|
// on the next) and from 15 (names alone, "(state: 1)" allowed, 4 blocked),
|
||||||
|
// as shown in developer.apple.com/forums/thread/757909.
|
||||||
|
func TestTheMacListOfAppsIsReadEntryByEntry(t *testing.T) {
|
||||||
|
const before15 = "ALF: total number of apps = 4 \n\n" +
|
||||||
|
"1 : /Applications/Google Chrome.app ( Block incoming connections )\n" +
|
||||||
|
"2 : /usr/local/bin/privatae-bastion.old ( Allow incoming connections )\n" +
|
||||||
|
"3 : /usr/local/bin/privatae-bastion \n \t ( Allow incoming connections ) \n\n" +
|
||||||
|
"4 : /opt/example/privatae-bastion ( Block incoming connections )\n"
|
||||||
|
apps := parseMacListApps(before15)
|
||||||
|
if len(apps) != 4 {
|
||||||
|
t.Fatalf("entries: %+v", apps)
|
||||||
|
}
|
||||||
|
for _, c := range []struct {
|
||||||
|
prog string
|
||||||
|
listed, allowed bool
|
||||||
|
}{
|
||||||
|
{"/usr/local/bin/privatae-bastion", true, true},
|
||||||
|
{"/opt/example/privatae-bastion", true, false},
|
||||||
|
{"/usr/local/bin/privatae", false, false},
|
||||||
|
{"/Applications/Google Chrome.app", true, false},
|
||||||
|
{"/usr/local/bin/privatae-bastion.old", true, true},
|
||||||
|
} {
|
||||||
|
if l, a := macAppState(apps, c.prog); l != c.listed || a != c.allowed {
|
||||||
|
t.Fatalf("%s: listed %v allowed %v", c.prog, l, a)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
const from15 = "2024-06-24 16:21:15.599 socketfilterfw[2988:52866] ApplicationFirewall::AFGetAllApplications() processing response dictionary\n\n" +
|
||||||
|
"Total number of apps = 3 \n\n" +
|
||||||
|
"privatae-bastion.old (state: 1)\n" +
|
||||||
|
"privatae-bastion (state: 4)\n" +
|
||||||
|
"cupsd (state: 1)\n"
|
||||||
|
apps = parseMacListApps(from15)
|
||||||
|
if len(apps) != 3 {
|
||||||
|
t.Fatalf("entries: %+v", apps)
|
||||||
|
}
|
||||||
|
if l, a := macAppState(apps, "/usr/local/bin/privatae-bastion"); !l || a {
|
||||||
|
t.Fatalf("blocked by name: listed %v allowed %v", l, a)
|
||||||
|
}
|
||||||
|
if l, a := macAppState(apps, "/usr/sbin/cupsd"); !l || !a {
|
||||||
|
t.Fatalf("allowed by name: listed %v allowed %v", l, a)
|
||||||
|
}
|
||||||
|
// MUTATION: the next line's state ignored. RESULT: red, /usr/local/bin/privatae-bastion not allowed.
|
||||||
|
// MUTATION: any state counts as allowed. RESULT: red, blocked read as allowed.
|
||||||
|
}
|
||||||
@@ -0,0 +1,7 @@
|
|||||||
|
//go:build !windows
|
||||||
|
|
||||||
|
package main
|
||||||
|
|
||||||
|
// systemDir is System32 on Windows; elsewhere the Windows firewall is never
|
||||||
|
// used, and the tests read the path the rule commands are built with.
|
||||||
|
func systemDir() string { return `C:\Windows\System32` }
|
||||||
@@ -0,0 +1,13 @@
|
|||||||
|
//go:build windows
|
||||||
|
|
||||||
|
package main
|
||||||
|
|
||||||
|
import "golang.org/x/sys/windows"
|
||||||
|
|
||||||
|
// systemDir is System32, from Windows itself rather than the environment.
|
||||||
|
func systemDir() string {
|
||||||
|
if d, err := windows.GetSystemDirectory(); err == nil && d != "" {
|
||||||
|
return d
|
||||||
|
}
|
||||||
|
return `C:\Windows\System32`
|
||||||
|
}
|
||||||
@@ -0,0 +1,811 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"errors"
|
||||||
|
"fmt"
|
||||||
|
"os"
|
||||||
|
"path"
|
||||||
|
"path/filepath"
|
||||||
|
"sort"
|
||||||
|
"strings"
|
||||||
|
"sync"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
// fwStandin plays this machine's firewall commands: netsh, ufw, firewall-cmd,
|
||||||
|
// socketfilterfw, nft and iptables, each with the state it would keep. Every
|
||||||
|
// command run is recorded, so a test can say what was never run.
|
||||||
|
type fwStandin struct {
|
||||||
|
mu sync.Mutex
|
||||||
|
ran []string
|
||||||
|
fail map[string]bool // a verb that fails ("add")
|
||||||
|
|
||||||
|
// Windows: rule name -> its add arguments.
|
||||||
|
win map[string]string
|
||||||
|
// ufw: on or off, and its rules as `ufw status` lists them.
|
||||||
|
ufwOn bool
|
||||||
|
ufwRules []string
|
||||||
|
// firewalld: running, ports now and permanently.
|
||||||
|
fwdOn bool
|
||||||
|
fwdNow, fwdPerm map[string]bool
|
||||||
|
macOn, macAllIn bool
|
||||||
|
macApps map[string]bool
|
||||||
|
nftRuleset, ipts string
|
||||||
|
}
|
||||||
|
|
||||||
|
func newFWStandin() *fwStandin {
|
||||||
|
return &fwStandin{fail: map[string]bool{}, win: map[string]string{}, fwdNow: map[string]bool{},
|
||||||
|
fwdPerm: map[string]bool{}, macApps: map[string]bool{}}
|
||||||
|
}
|
||||||
|
|
||||||
|
var errExit1 = errors.New("exit status 1")
|
||||||
|
|
||||||
|
func (f *fwStandin) exec(name string, args ...string) (string, error) {
|
||||||
|
f.mu.Lock()
|
||||||
|
defer f.mu.Unlock()
|
||||||
|
line := path.Base(strings.ReplaceAll(name, `\`, "/")) + " " + strings.Join(args, " ")
|
||||||
|
f.ran = append(f.ran, line)
|
||||||
|
a := strings.Join(args, " ")
|
||||||
|
switch path.Base(strings.ReplaceAll(name, `\`, "/")) {
|
||||||
|
case "netsh.exe":
|
||||||
|
if !strings.HasPrefix(a, "advfirewall firewall ") || len(args) < 5 {
|
||||||
|
return "", fmt.Errorf("netsh: %s", a)
|
||||||
|
}
|
||||||
|
rule := strings.TrimPrefix(args[4], "name=")
|
||||||
|
switch args[2] {
|
||||||
|
case "show":
|
||||||
|
if _, ok := f.win[rule]; ok {
|
||||||
|
return "Rule Name: " + rule + "\n", nil
|
||||||
|
}
|
||||||
|
return "No rules match the specified criteria.\n", errExit1
|
||||||
|
case "add":
|
||||||
|
if f.fail["add"] {
|
||||||
|
return "The requested operation requires elevation (Run as administrator).", errExit1
|
||||||
|
}
|
||||||
|
f.win[rule] = strings.Join(args[5:], " ")
|
||||||
|
return "Ok.\n", nil
|
||||||
|
case "delete":
|
||||||
|
if _, ok := f.win[rule]; !ok {
|
||||||
|
return "No rules match the specified criteria.\n", errExit1
|
||||||
|
}
|
||||||
|
delete(f.win, rule)
|
||||||
|
return "\nDeleted 1 rule(s).\nOk.\n", nil
|
||||||
|
}
|
||||||
|
case "ufw":
|
||||||
|
switch {
|
||||||
|
case a == "status":
|
||||||
|
if !f.ufwOn {
|
||||||
|
return "Status: inactive\n", nil
|
||||||
|
}
|
||||||
|
return "Status: active\n\nTo Action From\n-- ------ ----\n" +
|
||||||
|
strings.Join(f.ufwRules, "\n") + "\n", nil
|
||||||
|
case strings.HasPrefix(a, "allow "):
|
||||||
|
port := args[1]
|
||||||
|
c := ""
|
||||||
|
if len(args) == 4 && args[2] == "comment" {
|
||||||
|
c = " # " + args[3]
|
||||||
|
}
|
||||||
|
f.ufwRules = append(f.ufwRules, port+" ALLOW Anywhere"+c,
|
||||||
|
port+" (v6) ALLOW Anywhere (v6)"+c)
|
||||||
|
return "Rule added\nRule added (v6)\n", nil
|
||||||
|
case strings.HasPrefix(a, "delete allow "):
|
||||||
|
port := args[2]
|
||||||
|
var keep []string
|
||||||
|
for _, r := range f.ufwRules {
|
||||||
|
if strings.Fields(r)[0] != port {
|
||||||
|
keep = append(keep, r)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if len(keep) == len(f.ufwRules) {
|
||||||
|
return "Could not delete non-existent rule\n", errExit1
|
||||||
|
}
|
||||||
|
f.ufwRules = keep
|
||||||
|
return "Rule deleted\nRule deleted (v6)\n", nil
|
||||||
|
}
|
||||||
|
case "firewall-cmd":
|
||||||
|
perm := len(args) > 0 && args[0] == "--permanent"
|
||||||
|
set := f.fwdNow
|
||||||
|
if perm {
|
||||||
|
set, args = f.fwdPerm, args[1:]
|
||||||
|
}
|
||||||
|
if len(args) == 0 {
|
||||||
|
break
|
||||||
|
}
|
||||||
|
switch {
|
||||||
|
case args[0] == "--state":
|
||||||
|
if f.fwdOn {
|
||||||
|
return "running\n", nil
|
||||||
|
}
|
||||||
|
return "not running\n", errors.New("exit status 252")
|
||||||
|
case strings.HasPrefix(args[0], "--query-port="):
|
||||||
|
if set[strings.TrimPrefix(args[0], "--query-port=")] {
|
||||||
|
return "yes\n", nil
|
||||||
|
}
|
||||||
|
return "no\n", errExit1
|
||||||
|
case strings.HasPrefix(args[0], "--add-port="):
|
||||||
|
if perm && f.fail["permanent"] {
|
||||||
|
return "Error: COMMAND_FAILED\n", errExit1
|
||||||
|
}
|
||||||
|
set[strings.TrimPrefix(args[0], "--add-port=")] = true
|
||||||
|
return "success\n", nil
|
||||||
|
case strings.HasPrefix(args[0], "--remove-port="):
|
||||||
|
p := strings.TrimPrefix(args[0], "--remove-port=")
|
||||||
|
if !set[p] {
|
||||||
|
return "Warning: NOT_ENABLED: " + p + "\nsuccess\n", nil
|
||||||
|
}
|
||||||
|
delete(set, p)
|
||||||
|
return "success\n", nil
|
||||||
|
}
|
||||||
|
case "socketfilterfw":
|
||||||
|
switch args[0] {
|
||||||
|
case "--getglobalstate":
|
||||||
|
if f.macOn {
|
||||||
|
return "Firewall is enabled. (State = 1)\n", nil
|
||||||
|
}
|
||||||
|
return "Firewall is disabled. (State = 0)\n", nil
|
||||||
|
case "--getblockall":
|
||||||
|
if f.macAllIn {
|
||||||
|
return "Firewall is set to block all non-essential incoming connections\nBlock all ENABLED!\n", nil
|
||||||
|
}
|
||||||
|
return "Block all DISABLED!\n", nil
|
||||||
|
case "--listapps":
|
||||||
|
// As macOS before 15 prints it (developer.apple.com/forums/thread/757909).
|
||||||
|
var b strings.Builder
|
||||||
|
fmt.Fprintf(&b, "ALF: total number of apps = %d \n\n", len(f.macApps))
|
||||||
|
var ps []string
|
||||||
|
for p := range f.macApps {
|
||||||
|
ps = append(ps, p)
|
||||||
|
}
|
||||||
|
sort.Strings(ps)
|
||||||
|
for i, p := range ps {
|
||||||
|
st := "Block"
|
||||||
|
if f.macApps[p] {
|
||||||
|
st = "Allow"
|
||||||
|
}
|
||||||
|
fmt.Fprintf(&b, "%d : %s ( %s incoming connections )\n", i+1, p, st)
|
||||||
|
}
|
||||||
|
return b.String(), nil
|
||||||
|
case "--add":
|
||||||
|
f.macApps[args[1]] = false
|
||||||
|
return "The file " + args[1] + " added to firewall\n", nil
|
||||||
|
case "--unblockapp":
|
||||||
|
if f.fail["unblock"] {
|
||||||
|
return "Error\n", errExit1
|
||||||
|
}
|
||||||
|
f.macApps[args[1]] = true
|
||||||
|
return "Incoming connection to the application is permitted\n", nil
|
||||||
|
case "--remove":
|
||||||
|
delete(f.macApps, args[1])
|
||||||
|
return "The file " + args[1] + " removed from firewall\n", nil
|
||||||
|
}
|
||||||
|
case "nft":
|
||||||
|
return f.nftRuleset, nil
|
||||||
|
case "iptables":
|
||||||
|
return f.ipts, nil
|
||||||
|
}
|
||||||
|
return "", fmt.Errorf("the stand-in does not know %s", line)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (f *fwStandin) commands() []string {
|
||||||
|
f.mu.Lock()
|
||||||
|
defer f.mu.Unlock()
|
||||||
|
return append([]string(nil), f.ran...)
|
||||||
|
}
|
||||||
|
|
||||||
|
// fwWorld stands the firewall in for goos, with the door wanted while *want.
|
||||||
|
func fwWorld(t *testing.T, goos string, root bool) (*fwStandin, *bool) {
|
||||||
|
t.Helper()
|
||||||
|
uiTestConfigDir(t)
|
||||||
|
f := newFWStandin()
|
||||||
|
want := true
|
||||||
|
prevExec, prevFor, prevBy, prevHave, prevRoot, prevProg, prevWant, prevRead :=
|
||||||
|
doorFWExec, doorFirewallFor, doorFirewallByID, doorFWHave, doorFWRoot, doorFWProgram, doorPortWanted, doorFWReadFile
|
||||||
|
t.Cleanup(func() {
|
||||||
|
doorFWExec, doorFirewallFor, doorFirewallByID, doorFWHave, doorFWRoot, doorFWProgram, doorPortWanted, doorFWReadFile =
|
||||||
|
prevExec, prevFor, prevBy, prevHave, prevRoot, prevProg, prevWant, prevRead
|
||||||
|
})
|
||||||
|
doorFWExec = f.exec
|
||||||
|
doorFirewallFor = func(port string) (doorFirewall, string) { return detectDoorFirewall(goos, port) }
|
||||||
|
doorFirewallByID = func(id string) doorFirewall { return doorFirewallOf(goos, id) }
|
||||||
|
doorFWHave = func(paths ...string) string { return paths[0] }
|
||||||
|
doorFWRoot = func() bool { return root }
|
||||||
|
doorFWProgram = func() (string, error) { return `C:\Program Files\Privatae\privatae-bastion.exe`, nil }
|
||||||
|
doorPortWanted = func(string) bool { return want }
|
||||||
|
doorFWReadFile = func(string) ([]byte, error) { return nil, errors.New("no such file") }
|
||||||
|
return f, &want
|
||||||
|
}
|
||||||
|
|
||||||
|
func fwAudit(t *testing.T) string {
|
||||||
|
t.Helper()
|
||||||
|
d, _ := configDir()
|
||||||
|
b, _ := os.ReadFile(filepath.Join(d, "pairing_audit.jsonl"))
|
||||||
|
return string(b)
|
||||||
|
}
|
||||||
|
|
||||||
|
func countOp(t *testing.T, op string) int {
|
||||||
|
return strings.Count(fwAudit(t), `"op":"`+op+`"`)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Windows: the rule is the bastion's own by name, inbound, TCP on the door's
|
||||||
|
// port only, every profile, for this program only, made by netsh from
|
||||||
|
// System32. It is made once, kept while the door is in use, and removed when
|
||||||
|
// the last pairing and window are gone, each step in the audit and in status.
|
||||||
|
func TestTheWindowsRuleIsTheBastionsOwnAndGoesWithTheDoor(t *testing.T) {
|
||||||
|
f, want := fwWorld(t, "windows", false)
|
||||||
|
said := doorFirewallEnsure(":8812")
|
||||||
|
rule := doorFWRuleName("8812")
|
||||||
|
got, ok := f.win[rule]
|
||||||
|
if !ok {
|
||||||
|
t.Fatalf("no rule %q: %v", rule, f.commands())
|
||||||
|
}
|
||||||
|
for _, part := range []string{"dir=in", "action=allow", "protocol=TCP", "localport=8812",
|
||||||
|
`program=C:\Program Files\Privatae\privatae-bastion.exe`, "profile=any", "enable=yes"} {
|
||||||
|
if !strings.Contains(got, part) {
|
||||||
|
t.Fatalf("the rule lacks %s: %s", part, got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
for _, c := range f.commands() {
|
||||||
|
if !strings.HasPrefix(c, "netsh.exe advfirewall firewall ") {
|
||||||
|
t.Fatalf("ran %q", c)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if !strings.HasPrefix(netshPath(), `C:\Windows\System32`) {
|
||||||
|
t.Fatalf("netsh is not run by its absolute path: %s", netshPath())
|
||||||
|
}
|
||||||
|
if !strings.Contains(said, "added its own rule in Windows Firewall") {
|
||||||
|
t.Fatalf("said %q", said)
|
||||||
|
}
|
||||||
|
// Again (the daemon's door after the window's): kept, not doubled.
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
if n := strings.Count(strings.Join(f.commands(), "\n"), " add rule "); n != 1 {
|
||||||
|
t.Fatalf("%d adds", n)
|
||||||
|
}
|
||||||
|
s := readDoorFirewallStatus()
|
||||||
|
if s == nil || len(s.Rules) != 1 || !strings.Contains(s.Rules[0], "Windows Firewall allows TCP 8812") {
|
||||||
|
t.Fatalf("status: %+v", s)
|
||||||
|
}
|
||||||
|
// Still in use: the rule stays.
|
||||||
|
doorFirewallRelease(":8812")
|
||||||
|
if _, ok := f.win[rule]; !ok {
|
||||||
|
t.Fatal("removed while the door is still in use")
|
||||||
|
}
|
||||||
|
// The last pairing and window gone: removed.
|
||||||
|
*want = false
|
||||||
|
doorFirewallRelease(":8812")
|
||||||
|
if _, ok := f.win[rule]; ok {
|
||||||
|
t.Fatal("the rule outlived the door")
|
||||||
|
}
|
||||||
|
if s := readDoorFirewallStatus(); s != nil {
|
||||||
|
t.Fatalf("status after: %+v", s)
|
||||||
|
}
|
||||||
|
if countOp(t, "door_firewall_opened") != 1 || countOp(t, "door_firewall_closed") != 1 {
|
||||||
|
t.Fatalf("the audit:\n%s", fwAudit(t))
|
||||||
|
}
|
||||||
|
// MUTATION: release removes nothing. RESULT: red, "the rule outlived the door".
|
||||||
|
// MUTATION: the add drops program=. RESULT: red, "the rule lacks program=".
|
||||||
|
// MUTATION: ensure adds without asking has(). RESULT: red, "2 adds".
|
||||||
|
}
|
||||||
|
|
||||||
|
// Windows: the bastion moved (another path): its rule is replaced by one for
|
||||||
|
// the new path; and an add refused (no administrator) is said once, with the
|
||||||
|
// command that does it by hand, in status and doctor.
|
||||||
|
func TestTheWindowsRuleFollowsTheProgramAndAFailureIsSaidOnce(t *testing.T) {
|
||||||
|
f, _ := fwWorld(t, "windows", false)
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
doorFWProgram = func() (string, error) { return `D:\Privatae\privatae-bastion.exe`, nil }
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
if got := f.win[doorFWRuleName("8812")]; !strings.Contains(got, `program=D:\Privatae\privatae-bastion.exe`) {
|
||||||
|
t.Fatalf("the rule names %s", got)
|
||||||
|
}
|
||||||
|
if st := loadDoorFW(); len(st.Rules) != 1 || st.Rules[0].Program != `D:\Privatae\privatae-bastion.exe` {
|
||||||
|
t.Fatalf("the record: %+v", st.Rules)
|
||||||
|
}
|
||||||
|
|
||||||
|
g, _ := fwWorld(t, "windows", false)
|
||||||
|
g.fail["add"] = true
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
if n := countOp(t, "door_firewall_failed"); n != 1 {
|
||||||
|
t.Fatalf("the failure audited %d times", n)
|
||||||
|
}
|
||||||
|
s := readDoorFirewallStatus()
|
||||||
|
if s == nil || len(s.Needs) != 1 || !strings.Contains(s.Needs[0], "New-NetFirewallRule") {
|
||||||
|
t.Fatalf("status: %+v", s)
|
||||||
|
}
|
||||||
|
cs := doorFirewallChecks(s)
|
||||||
|
if len(cs) != 1 || cs[0].OK || !strings.Contains(cs[0].Problem, "TCP 8812") {
|
||||||
|
t.Fatalf("doctor: %+v", cs)
|
||||||
|
}
|
||||||
|
// MUTATION: the program is not compared. RESULT: red, the rule names the old path.
|
||||||
|
// MUTATION: the note is audited on every ensure. RESULT: red, audited 2 times.
|
||||||
|
}
|
||||||
|
|
||||||
|
// Linux ufw: a rule only while ufw is on, with the bastion's comment; ufw is
|
||||||
|
// never turned on, off or reset; a rule of the machine's own for the port is
|
||||||
|
// neither doubled nor removed.
|
||||||
|
func TestTheUfwRuleIsAddedOnlyWhenUfwIsOnAndNeverTheMachinesOwn(t *testing.T) {
|
||||||
|
f, want := fwWorld(t, "linux", true)
|
||||||
|
// Off: nothing at all.
|
||||||
|
if said := doorFirewallEnsure(":8812"); said != "" || len(loadDoorFW().Rules) != 0 {
|
||||||
|
t.Fatalf("ufw off: %q %v", said, f.commands())
|
||||||
|
}
|
||||||
|
f.ufwOn = true
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
st := strings.Join(f.ufwRules, "\n")
|
||||||
|
if !strings.Contains(st, "8812/tcp") || !strings.Contains(st, "# "+doorFWComment) {
|
||||||
|
t.Fatalf("ufw rules: %s", st)
|
||||||
|
}
|
||||||
|
if s := readDoorFirewallStatus(); s == nil || len(s.Rules) != 1 || !strings.Contains(s.Rules[0], "ufw allows TCP 8812") {
|
||||||
|
t.Fatalf("status: %+v", s)
|
||||||
|
}
|
||||||
|
*want = false
|
||||||
|
doorFirewallRelease(":8812")
|
||||||
|
if len(f.ufwRules) != 0 {
|
||||||
|
t.Fatalf("left: %v", f.ufwRules)
|
||||||
|
}
|
||||||
|
for _, c := range f.commands() {
|
||||||
|
for _, never := range []string{"ufw enable", "ufw disable", "ufw reset", "ufw default", "ufw reload"} {
|
||||||
|
if strings.HasPrefix(c, never) {
|
||||||
|
t.Fatalf("ran %q", c)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The machine's own rule for the port.
|
||||||
|
g, want2 := fwWorld(t, "linux", true)
|
||||||
|
g.ufwOn = true
|
||||||
|
g.ufwRules = []string{"8812/tcp ALLOW Anywhere", "8812/tcp (v6) ALLOW Anywhere (v6)"}
|
||||||
|
said := doorFirewallEnsure(":8812")
|
||||||
|
if !strings.Contains(said, "already allowed") || len(g.ufwRules) != 2 {
|
||||||
|
t.Fatalf("said %q, rules %v", said, g.ufwRules)
|
||||||
|
}
|
||||||
|
*want2 = false
|
||||||
|
doorFirewallRelease(":8812")
|
||||||
|
if len(g.ufwRules) != 2 {
|
||||||
|
t.Fatalf("the machine's own rule was removed: %v", g.commands())
|
||||||
|
}
|
||||||
|
// MUTATION: ufwRuleFor counts any ALLOW as ours. RESULT: red, the machine's own rule was removed.
|
||||||
|
// MUTATION: detection ignores "Status: inactive". RESULT: red, ufw off.
|
||||||
|
}
|
||||||
|
|
||||||
|
// Linux firewalld: the port added now and permanently, and removed the same
|
||||||
|
// way; a port already open in it is the machine's own.
|
||||||
|
func TestTheFirewalldPortIsAddedAndRemovedNowAndPermanently(t *testing.T) {
|
||||||
|
f, want := fwWorld(t, "linux", true)
|
||||||
|
f.fwdOn = true
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
if !f.fwdNow["8812/tcp"] || !f.fwdPerm["8812/tcp"] {
|
||||||
|
t.Fatalf("firewalld: %v %v", f.fwdNow, f.fwdPerm)
|
||||||
|
}
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
if n := strings.Count(strings.Join(f.commands(), "\n"), "--add-port"); n != 2 {
|
||||||
|
t.Fatalf("%d adds: %v", n, f.commands())
|
||||||
|
}
|
||||||
|
*want = false
|
||||||
|
doorFirewallRelease(":8812")
|
||||||
|
if f.fwdNow["8812/tcp"] || f.fwdPerm["8812/tcp"] {
|
||||||
|
t.Fatalf("left: %v %v", f.fwdNow, f.fwdPerm)
|
||||||
|
}
|
||||||
|
|
||||||
|
g, want2 := fwWorld(t, "linux", true)
|
||||||
|
g.fwdOn = true
|
||||||
|
g.fwdNow["8812/tcp"], g.fwdPerm["8812/tcp"] = true, true
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
*want2 = false
|
||||||
|
doorFirewallRelease(":8812")
|
||||||
|
if !g.fwdNow["8812/tcp"] || !g.fwdPerm["8812/tcp"] {
|
||||||
|
t.Fatal("the machine's own open port was closed")
|
||||||
|
}
|
||||||
|
// MUTATION: remove only the runtime port. RESULT: red, left permanently.
|
||||||
|
// MUTATION: has() reports a port it did not add as ours. RESULT: red, the machine's own port closed.
|
||||||
|
}
|
||||||
|
|
||||||
|
// Linux: a firewall the bastion does not manage (nftables, iptables), or ufw
|
||||||
|
// it may not change, is said once, with what to allow, in status and doctor,
|
||||||
|
// and nothing in it is changed.
|
||||||
|
func TestAFirewallTheBastionDoesNotManageIsSaidOnceAndLeftAlone(t *testing.T) {
|
||||||
|
f, want := fwWorld(t, "linux", true)
|
||||||
|
f.nftRuleset = "table inet filter {\n\tchain input {\n\t\ttype filter hook input priority filter; policy drop;\n\t}\n}\n"
|
||||||
|
said := doorFirewallEnsure(":8812")
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
if !strings.Contains(said, "nftables") || !strings.Contains(said, "tcp dport 8812 accept") {
|
||||||
|
t.Fatalf("said %q", said)
|
||||||
|
}
|
||||||
|
if n := countOp(t, "door_firewall_unmanaged"); n != 1 {
|
||||||
|
t.Fatalf("said %d times", n)
|
||||||
|
}
|
||||||
|
for _, c := range f.commands() {
|
||||||
|
if strings.HasPrefix(c, "nft ") && c != "nft list ruleset" {
|
||||||
|
t.Fatalf("ran %q", c)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
s := readDoorFirewallStatus()
|
||||||
|
if s == nil || len(s.Needs) != 1 || !strings.Contains(s.Needs[0], "nftables") {
|
||||||
|
t.Fatalf("status: %+v", s)
|
||||||
|
}
|
||||||
|
if cs := doorFirewallChecks(s); len(cs) != 1 || cs[0].OK {
|
||||||
|
t.Fatalf("doctor: %+v", cs)
|
||||||
|
}
|
||||||
|
*want = false
|
||||||
|
doorFirewallRelease(":8812")
|
||||||
|
if s := readDoorFirewallStatus(); s != nil {
|
||||||
|
t.Fatalf("still said with no door: %+v", s)
|
||||||
|
}
|
||||||
|
|
||||||
|
// iptables, and an account that may not change ufw.
|
||||||
|
g, _ := fwWorld(t, "linux", true)
|
||||||
|
g.ipts = "-P INPUT DROP\n"
|
||||||
|
if said := doorFirewallEnsure(":8812"); !strings.Contains(said, "iptables -I INPUT -p tcp --dport 8812 -j ACCEPT") {
|
||||||
|
t.Fatalf("iptables: %q", said)
|
||||||
|
}
|
||||||
|
h, _ := fwWorld(t, "linux", false)
|
||||||
|
doorFWReadFile = func(string) ([]byte, error) { return []byte("ENABLED=yes\n"), nil }
|
||||||
|
if said := doorFirewallEnsure(":8812"); !strings.Contains(said, "sudo ufw allow 8812/tcp") {
|
||||||
|
t.Fatalf("not root: %q", said)
|
||||||
|
}
|
||||||
|
for _, c := range h.commands() {
|
||||||
|
if strings.HasPrefix(c, "ufw ") {
|
||||||
|
t.Fatalf("an account that may not change ufw ran %q", c)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
// MUTATION: nftFiltersInput always false. RESULT: red, said "".
|
||||||
|
// MUTATION: the note is not cleared at release. RESULT: red, still said with no door.
|
||||||
|
}
|
||||||
|
|
||||||
|
// macOS: with the application firewall on, this program is allowed; with it
|
||||||
|
// off nothing is done; "block all incoming" is only said.
|
||||||
|
func TestTheMacFirewallAllowsTheProgramOnlyWhenItIsOn(t *testing.T) {
|
||||||
|
f, want := fwWorld(t, "darwin", true)
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
if len(f.macApps) != 0 {
|
||||||
|
t.Fatal("added with the firewall off")
|
||||||
|
}
|
||||||
|
f.macOn = true
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
prog, _ := doorFWProgram()
|
||||||
|
if allowed, ok := f.macApps[prog]; !ok || !allowed {
|
||||||
|
t.Fatalf("apps: %v", f.macApps)
|
||||||
|
}
|
||||||
|
*want = false
|
||||||
|
doorFirewallRelease(":8812")
|
||||||
|
if len(f.macApps) != 0 {
|
||||||
|
t.Fatalf("left: %v", f.macApps)
|
||||||
|
}
|
||||||
|
g, _ := fwWorld(t, "darwin", true)
|
||||||
|
g.macOn, g.macAllIn = true, true
|
||||||
|
if said := doorFirewallEnsure(":8812"); !strings.Contains(said, "blocks all incoming") || len(g.macApps) != 0 {
|
||||||
|
t.Fatalf("block all: %q %v", said, g.macApps)
|
||||||
|
}
|
||||||
|
// MUTATION: --unblockapp not run. RESULT: red, apps not allowed.
|
||||||
|
}
|
||||||
|
|
||||||
|
// uninstall removes every rule the bastion added, whatever uses the door.
|
||||||
|
func TestUninstallRemovesTheDoorsOwnRules(t *testing.T) {
|
||||||
|
f, _ := fwWorld(t, "windows", false)
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
doorFirewallEnsure(":9443")
|
||||||
|
said, err := doorFirewallRemoveAll()
|
||||||
|
if err != nil || len(said) != 2 || len(f.win) != 0 {
|
||||||
|
t.Fatalf("uninstall: %v %v, left %v", said, err, f.win)
|
||||||
|
}
|
||||||
|
if len(loadDoorFW().Rules) != 0 {
|
||||||
|
t.Fatal("the record outlived the rules")
|
||||||
|
}
|
||||||
|
// MUTATION: RemoveAll skips the removal. RESULT: red, rules left.
|
||||||
|
}
|
||||||
|
|
||||||
|
// A rule left behind (a `pair --open` killed before its release, a pairing
|
||||||
|
// that went while nothing ran) is removed by the daemon's sweep once nothing
|
||||||
|
// uses its port, and kept while something does.
|
||||||
|
func TestTheDaemonsSweepRemovesARuleNothingUses(t *testing.T) {
|
||||||
|
f, want := fwWorld(t, "windows", false)
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
ctx, cancel := context.WithCancel(context.Background())
|
||||||
|
done := make(chan struct{})
|
||||||
|
go func() { doorFirewallSweep(ctx); close(done) }()
|
||||||
|
cancel()
|
||||||
|
<-done
|
||||||
|
if _, ok := f.win[doorFWRuleName("8812")]; !ok {
|
||||||
|
t.Fatal("the sweep removed a rule in use")
|
||||||
|
}
|
||||||
|
*want = false
|
||||||
|
doorFirewallReleaseUnused()
|
||||||
|
if _, ok := f.win[doorFWRuleName("8812")]; ok {
|
||||||
|
t.Fatal("the sweep left a rule nothing uses")
|
||||||
|
}
|
||||||
|
// MUTATION: doorFirewallReleaseUnused skips recorded rules. RESULT: red, the sweep left a rule.
|
||||||
|
}
|
||||||
|
|
||||||
|
// ufw deletes by rule, whatever its comment: a rule the bastion recorded and
|
||||||
|
// the person later replaced with their own, or a record that names a port the
|
||||||
|
// bastion never opened, is the machine's, and is never removed.
|
||||||
|
func TestUfwNeverRemovesARuleThatIsNotItsOwnWhateverTheRecordSays(t *testing.T) {
|
||||||
|
f, want := fwWorld(t, "linux", true)
|
||||||
|
f.ufwOn = true
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
// The person deletes the bastion's rule and puts their own in its place.
|
||||||
|
f.ufwRules = []string{"8812/tcp ALLOW Anywhere", "8812/tcp (v6) ALLOW Anywhere (v6)"}
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
*want = false
|
||||||
|
doorFirewallRelease(":8812")
|
||||||
|
if len(f.ufwRules) != 2 {
|
||||||
|
t.Fatalf("the person's own rule was removed: %v", f.commands())
|
||||||
|
}
|
||||||
|
|
||||||
|
// A record naming a port the bastion never opened (written by hand, or
|
||||||
|
// left from another time): the sweep leaves the machine's rule there.
|
||||||
|
g, want2 := fwWorld(t, "linux", true)
|
||||||
|
g.ufwOn = true
|
||||||
|
g.ufwRules = []string{"22/tcp ALLOW Anywhere"}
|
||||||
|
if err := saveDoorFW(doorFWState{Rules: []doorFWRule{{Firewall: "ufw", Port: "22", Added: "2026-01-01T00:00:00Z"}}}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
*want2 = false
|
||||||
|
doorFirewallReleaseUnused()
|
||||||
|
for _, c := range g.commands() {
|
||||||
|
if strings.HasPrefix(c, "ufw delete") {
|
||||||
|
t.Fatalf("ran %q on a rule that is not the bastion's", c)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if len(g.ufwRules) != 1 || len(loadDoorFW().Rules) != 0 {
|
||||||
|
t.Fatalf("rules %v, record %+v", g.ufwRules, loadDoorFW().Rules)
|
||||||
|
}
|
||||||
|
// MUTATION: ufw remove deletes without reading the comment. RESULT: red, the person's own rule was removed.
|
||||||
|
}
|
||||||
|
|
||||||
|
// Only a rule that lets a Host in from anywhere counts as the machine's own
|
||||||
|
// allow: an outbound rule, or one for one source or interface, does not, so
|
||||||
|
// the bastion adds its own rather than saying the port is already allowed.
|
||||||
|
func TestUfwAnOutboundOrOneSourceRuleIsNotTheWayIn(t *testing.T) {
|
||||||
|
for _, r := range []string{
|
||||||
|
"8812/tcp ALLOW OUT Anywhere",
|
||||||
|
"8812/tcp ALLOW 10.0.0.0/8",
|
||||||
|
"8812/tcp on eth1 ALLOW Anywhere",
|
||||||
|
"8812/tcp DENY Anywhere",
|
||||||
|
} {
|
||||||
|
f, _ := fwWorld(t, "linux", true)
|
||||||
|
f.ufwOn = true
|
||||||
|
f.ufwRules = []string{r}
|
||||||
|
said := doorFirewallEnsure(":8812")
|
||||||
|
if !strings.Contains(said, "added its own rule in ufw") {
|
||||||
|
t.Fatalf("with %q: said %q", r, said)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
for _, r := range []string{
|
||||||
|
"8812/tcp ALLOW Anywhere",
|
||||||
|
"8812/tcp ALLOW IN Anywhere",
|
||||||
|
"8812 (v6) ALLOW Anywhere (v6)",
|
||||||
|
} {
|
||||||
|
if _, other := ufwRuleFor(r, "8812"); !other {
|
||||||
|
t.Fatalf("%q lets a Host in from anywhere", r)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
// MUTATION: any line with ALLOW counts. RESULT: red, said "already allowed".
|
||||||
|
}
|
||||||
|
|
||||||
|
// firewalld: a permanent add that fails takes the runtime port back out, so
|
||||||
|
// no open port is left that no record says is the bastion's.
|
||||||
|
func TestFirewalldAFailedPermanentAddLeavesNoPortOpen(t *testing.T) {
|
||||||
|
f, _ := fwWorld(t, "linux", true)
|
||||||
|
f.fwdOn = true
|
||||||
|
f.fail["permanent"] = true
|
||||||
|
said := doorFirewallEnsure(":8812")
|
||||||
|
if !strings.Contains(said, "could not add") {
|
||||||
|
t.Fatalf("said %q", said)
|
||||||
|
}
|
||||||
|
if f.fwdNow["8812/tcp"] {
|
||||||
|
t.Fatalf("the runtime port was left open with no record: %v", f.commands())
|
||||||
|
}
|
||||||
|
// Next time it is tried again, not taken for the machine's own.
|
||||||
|
f.fail["permanent"] = false
|
||||||
|
if said := doorFirewallEnsure(":8812"); !strings.Contains(said, "added its own rule") {
|
||||||
|
t.Fatalf("said %q", said)
|
||||||
|
}
|
||||||
|
// MUTATION: no undo of the runtime add. RESULT: red, the runtime port was left open.
|
||||||
|
}
|
||||||
|
|
||||||
|
// macOS: an --unblockapp that fails takes the --add back out, so no entry is
|
||||||
|
// left that would read as the machine's own and never go.
|
||||||
|
func TestTheMacAFailedUnblockLeavesNoEntry(t *testing.T) {
|
||||||
|
f, _ := fwWorld(t, "darwin", true)
|
||||||
|
f.macOn = true
|
||||||
|
f.fail["unblock"] = true
|
||||||
|
if said := doorFirewallEnsure(":8812"); !strings.Contains(said, "could not add") {
|
||||||
|
t.Fatalf("said %q", said)
|
||||||
|
}
|
||||||
|
if len(f.macApps) != 0 {
|
||||||
|
t.Fatalf("left an entry with no record: %v", f.macApps)
|
||||||
|
}
|
||||||
|
// MUTATION: no --remove after a failed --unblockapp. RESULT: red, left an entry.
|
||||||
|
}
|
||||||
|
|
||||||
|
// realDoorPortWanted is the door-in-use check fwWorld stands in.
|
||||||
|
var realDoorPortWanted = doorPortWanted
|
||||||
|
|
||||||
|
// sweepOnce runs the daemon's sweep's first pass.
|
||||||
|
func sweepOnce() {
|
||||||
|
ctx, cancel := context.WithCancel(context.Background())
|
||||||
|
cancel()
|
||||||
|
doorFirewallSweep(ctx)
|
||||||
|
}
|
||||||
|
|
||||||
|
// A door claims the window (its file is moved aside) before the pairing is
|
||||||
|
// saved: between the two, neither is there to read. The window is still in
|
||||||
|
// use then, so a sweep in that gap keeps the rule, and puts it back if it had
|
||||||
|
// gone; once the window has its result and no pairing uses the port, the
|
||||||
|
// rule goes.
|
||||||
|
func TestAWindowClaimedForAPairingStillBeingSavedKeepsTheRule(t *testing.T) {
|
||||||
|
f, _ := fwWorld(t, "windows", false)
|
||||||
|
doorPortWanted = realDoorPortWanted
|
||||||
|
code, err := newWindowCode()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
now := time.Now().UTC()
|
||||||
|
w := &pairWindow{ID: "w-claimed", Code: code, Door: ":8812", Opened: now.Format(time.RFC3339),
|
||||||
|
Expires: now.Add(windowLifetime).Format(time.RFC3339)}
|
||||||
|
if err := saveWindowFile(w); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
rule := doorFWRuleName("8812")
|
||||||
|
if _, ok := f.win[rule]; !ok {
|
||||||
|
t.Fatalf("no rule for the open window: %v", f.commands())
|
||||||
|
}
|
||||||
|
if !claimWindow(w.ID) {
|
||||||
|
t.Fatal("the window could not be claimed")
|
||||||
|
}
|
||||||
|
sweepOnce()
|
||||||
|
if _, ok := f.win[rule]; !ok {
|
||||||
|
t.Fatal("the sweep removed the rule while a pairing on the window was being saved")
|
||||||
|
}
|
||||||
|
// The rule gone in that gap (by hand, or a release that ran then): back.
|
||||||
|
delete(f.win, rule)
|
||||||
|
sweepOnce()
|
||||||
|
if _, ok := f.win[rule]; !ok {
|
||||||
|
t.Fatal("the sweep did not put back the rule of a window still in use")
|
||||||
|
}
|
||||||
|
endWindow(w.ID, windowResult{Error: "the Host refused"})
|
||||||
|
sweepOnce()
|
||||||
|
if _, ok := f.win[rule]; ok {
|
||||||
|
t.Fatal("the rule outlived the window")
|
||||||
|
}
|
||||||
|
// MUTATION: doorPortsInUse ignores a claimed window. RESULT: red, the sweep removed the rule while a pairing ... was being saved.
|
||||||
|
// MUTATION: claimedWindowUnderWay counts a window with its result. RESULT: red, the rule outlived the window.
|
||||||
|
}
|
||||||
|
|
||||||
|
// A rule that goes while its door is in use (removed by hand, the firewall
|
||||||
|
// reset) is put back by the daemon's sweep; a port a rule of the machine's
|
||||||
|
// own allows is still never given a second one; nothing in use, nothing added.
|
||||||
|
func TestTheSweepPutsBackARuleThatWentWhileTheDoorIsInUse(t *testing.T) {
|
||||||
|
f, want := fwWorld(t, "windows", false)
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
rule := doorFWRuleName("8812")
|
||||||
|
delete(f.win, rule) // removed by hand
|
||||||
|
sweepOnce()
|
||||||
|
if got, ok := f.win[rule]; !ok || !strings.Contains(got, "localport=8812") {
|
||||||
|
t.Fatalf("not put back: %v", f.commands())
|
||||||
|
}
|
||||||
|
if n := countOp(t, "door_firewall_opened"); n != 2 {
|
||||||
|
t.Fatalf("opened %d times:\n%s", n, fwAudit(t))
|
||||||
|
}
|
||||||
|
*want = false
|
||||||
|
sweepOnce()
|
||||||
|
if _, ok := f.win[rule]; ok {
|
||||||
|
t.Fatal("a rule nothing uses was kept")
|
||||||
|
}
|
||||||
|
sweepOnce()
|
||||||
|
if _, ok := f.win[rule]; ok {
|
||||||
|
t.Fatal("the sweep added a rule nothing uses")
|
||||||
|
}
|
||||||
|
|
||||||
|
// ufw: the bastion's rule deleted while the door is in use, back with its comment.
|
||||||
|
g, _ := fwWorld(t, "linux", true)
|
||||||
|
g.ufwOn = true
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
g.ufwRules = nil
|
||||||
|
sweepOnce()
|
||||||
|
if st := strings.Join(g.ufwRules, "\n"); !strings.Contains(st, "8812/tcp") || !strings.Contains(st, "# "+doorFWComment) {
|
||||||
|
t.Fatalf("ufw not put back: %v", g.commands())
|
||||||
|
}
|
||||||
|
|
||||||
|
// ufw: the machine's own rule allows the port: never a second one.
|
||||||
|
h, _ := fwWorld(t, "linux", true)
|
||||||
|
h.ufwOn = true
|
||||||
|
h.ufwRules = []string{"8812/tcp ALLOW Anywhere"}
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
sweepOnce()
|
||||||
|
sweepOnce()
|
||||||
|
for _, c := range h.commands() {
|
||||||
|
if strings.HasPrefix(c, "ufw allow") {
|
||||||
|
t.Fatalf("ran %q with the machine's own rule there", c)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
// MUTATION: the sweep only releases. RESULT: red, not put back (and in
|
||||||
|
// TestAWindowClaimedForAPairingStillBeingSavedKeepsTheRule).
|
||||||
|
}
|
||||||
|
|
||||||
|
// macOS: an entry is for one program path; the bastion that moved removes the
|
||||||
|
// entry by the path it recorded, both when its door is released and when it
|
||||||
|
// makes the entry for its new path.
|
||||||
|
func TestTheMacEntryIsRemovedByThePathItWasAddedFor(t *testing.T) {
|
||||||
|
const a, b = "/usr/local/bin/privatae-bastion", "/opt/example/privatae-bastion"
|
||||||
|
f, want := fwWorld(t, "darwin", true)
|
||||||
|
f.macOn = true
|
||||||
|
doorFWProgram = func() (string, error) { return a, nil }
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
if !f.macApps[a] {
|
||||||
|
t.Fatalf("apps: %v", f.macApps)
|
||||||
|
}
|
||||||
|
doorFWProgram = func() (string, error) { return b, nil }
|
||||||
|
*want = false
|
||||||
|
doorFirewallRelease(":8812")
|
||||||
|
if len(f.macApps) != 0 {
|
||||||
|
t.Fatalf("the moved bastion left its old path allowed: %v", f.macApps)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Moved while the door is in use: the old path's entry goes, the new one's is made.
|
||||||
|
g, _ := fwWorld(t, "darwin", true)
|
||||||
|
g.macOn = true
|
||||||
|
doorFWProgram = func() (string, error) { return a, nil }
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
doorFWProgram = func() (string, error) { return b, nil }
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
if _, ok := g.macApps[a]; ok || !g.macApps[b] {
|
||||||
|
t.Fatalf("apps: %v", g.macApps)
|
||||||
|
}
|
||||||
|
if st := loadDoorFW(); len(st.Rules) != 1 || st.Rules[0].Program != b {
|
||||||
|
t.Fatalf("the record: %+v", st.Rules)
|
||||||
|
}
|
||||||
|
// MUTATION: remove uses this program's path, not the record's. RESULT: red, the moved bastion left its old path allowed.
|
||||||
|
// MUTATION: the moved case removes this program's path. RESULT: red, apps: both paths.
|
||||||
|
}
|
||||||
|
|
||||||
|
// macOS: --listapps is read entry by entry, by the exact path, and only an
|
||||||
|
// "allow incoming" entry counts: a blocked entry is the person's setting and
|
||||||
|
// is said, not changed; a longer path (…/privatae-bastion.old) is not this
|
||||||
|
// program's.
|
||||||
|
func TestTheMacReadsEachEntryAndCountsOnlyAnAllow(t *testing.T) {
|
||||||
|
const prog = "/usr/local/bin/privatae-bastion"
|
||||||
|
f, _ := fwWorld(t, "darwin", true)
|
||||||
|
f.macOn = true
|
||||||
|
doorFWProgram = func() (string, error) { return prog, nil }
|
||||||
|
f.macApps[prog] = false // the person blocked it
|
||||||
|
said := doorFirewallEnsure(":8812")
|
||||||
|
if !strings.Contains(said, "block incoming connections for this program") {
|
||||||
|
t.Fatalf("said %q", said)
|
||||||
|
}
|
||||||
|
for _, c := range f.commands() {
|
||||||
|
if strings.Contains(c, "--unblockapp") || strings.Contains(c, "--add") || strings.Contains(c, "--remove") {
|
||||||
|
t.Fatalf("changed the person's setting: %q", c)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if s := readDoorFirewallStatus(); s == nil || len(s.Needs) != 1 {
|
||||||
|
t.Fatalf("status: %+v", s)
|
||||||
|
}
|
||||||
|
|
||||||
|
g, _ := fwWorld(t, "darwin", true)
|
||||||
|
g.macOn = true
|
||||||
|
doorFWProgram = func() (string, error) { return prog, nil }
|
||||||
|
g.macApps[prog+".old"] = true
|
||||||
|
if said := doorFirewallEnsure(":8812"); !strings.Contains(said, "added its own rule") || !g.macApps[prog] {
|
||||||
|
t.Fatalf("a longer path counted as this program: said %q, apps %v", said, g.macApps)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Its own entry, later set to block by the person: left as it is at release.
|
||||||
|
h, want := fwWorld(t, "darwin", true)
|
||||||
|
h.macOn = true
|
||||||
|
doorFWProgram = func() (string, error) { return prog, nil }
|
||||||
|
doorFirewallEnsure(":8812")
|
||||||
|
h.macApps[prog] = false
|
||||||
|
*want = false
|
||||||
|
doorFirewallRelease(":8812")
|
||||||
|
if allowed, ok := h.macApps[prog]; !ok || allowed {
|
||||||
|
t.Fatalf("the person's block was removed: %v", h.macApps)
|
||||||
|
}
|
||||||
|
// MUTATION: has() counts a listed program whatever its state. RESULT: red, said "already allowed".
|
||||||
|
// MUTATION: the path is matched as a prefix. RESULT: red, a longer path counted as this program.
|
||||||
|
// MUTATION: remove runs --remove on a blocked entry. RESULT: red, the person's block was removed.
|
||||||
|
}
|
||||||
@@ -0,0 +1,206 @@
|
|||||||
|
//go:build linux
|
||||||
|
|
||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"crypto/tls"
|
||||||
|
"errors"
|
||||||
|
"net"
|
||||||
|
"strings"
|
||||||
|
"sync"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
// fwFake is a firewall the bastion manages, kept in memory.
|
||||||
|
type fwFake struct {
|
||||||
|
mu sync.Mutex
|
||||||
|
rules map[string]bool
|
||||||
|
adds int
|
||||||
|
}
|
||||||
|
|
||||||
|
func (f *fwFake) id() string { return "ufw" }
|
||||||
|
func (f *fwFake) name() string { return "ufw" }
|
||||||
|
func (f *fwFake) has(port string) (bool, bool, error) {
|
||||||
|
f.mu.Lock()
|
||||||
|
defer f.mu.Unlock()
|
||||||
|
return f.rules[port], false, nil
|
||||||
|
}
|
||||||
|
func (f *fwFake) add(port string) error {
|
||||||
|
f.mu.Lock()
|
||||||
|
defer f.mu.Unlock()
|
||||||
|
f.rules[port] = true
|
||||||
|
f.adds++
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
func (f *fwFake) remove(port, _ string) error {
|
||||||
|
f.mu.Lock()
|
||||||
|
defer f.mu.Unlock()
|
||||||
|
if !f.rules[port] {
|
||||||
|
return errors.New("no such rule")
|
||||||
|
}
|
||||||
|
delete(f.rules, port)
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
func (f *fwFake) manual(port string) string { return "allow " + port }
|
||||||
|
func (f *fwFake) open(port string) bool { ok, _, _ := f.has(port); return ok }
|
||||||
|
|
||||||
|
func fwFakeWorld(t *testing.T) *fwFake {
|
||||||
|
t.Helper()
|
||||||
|
f := &fwFake{rules: map[string]bool{}}
|
||||||
|
prevFor, prevBy := doorFirewallFor, doorFirewallByID
|
||||||
|
t.Cleanup(func() { doorFirewallFor, doorFirewallByID = prevFor, prevBy })
|
||||||
|
doorFirewallFor = func(string) (doorFirewall, string) { return f, "" }
|
||||||
|
doorFirewallByID = func(string) doorFirewall { return f }
|
||||||
|
return f
|
||||||
|
}
|
||||||
|
|
||||||
|
// The window's own door opens the way in while the window is open, and a
|
||||||
|
// window that ends with nothing paired takes it away again.
|
||||||
|
func TestAPairingWindowOpensTheFirewallAndClosingItRemovesTheRule(t *testing.T) {
|
||||||
|
pairingBox(t)
|
||||||
|
f := fwFakeWorld(t)
|
||||||
|
addr := freeDoorAddr(t)
|
||||||
|
port := doorPort(addr)
|
||||||
|
_, out, res := openWindowFor(t, addr)
|
||||||
|
if !f.open(port) || !strings.Contains(out.String(), "added its own rule in ufw") {
|
||||||
|
t.Fatalf("the window is open and the firewall is not: %v\n%s", f.rules, out.String())
|
||||||
|
}
|
||||||
|
w := loadOpenWindow()
|
||||||
|
removeWindow(w.ID) // closed at the terminal, as Ctrl-C does
|
||||||
|
select {
|
||||||
|
case <-res:
|
||||||
|
case <-time.After(5 * time.Second):
|
||||||
|
t.Fatal("pair --open did not end")
|
||||||
|
}
|
||||||
|
if f.open(port) {
|
||||||
|
t.Fatal("the rule outlived a window that paired nothing")
|
||||||
|
}
|
||||||
|
a := pairingAuditText(t)
|
||||||
|
if !strings.Contains(a, `"door_firewall_opened"`) || !strings.Contains(a, `"door_firewall_closed"`) {
|
||||||
|
t.Fatalf("the audit:\n%s", a)
|
||||||
|
}
|
||||||
|
// MUTATION: pair --open does not release. RESULT: red, the rule outlived the window.
|
||||||
|
}
|
||||||
|
|
||||||
|
// A pairing made through the window keeps the rule; the daemon's door keeps
|
||||||
|
// it while it serves the pairing and when the bastion stops (the pairing has
|
||||||
|
// not gone); unpairing removes it.
|
||||||
|
func TestThePairingsDoorKeepsTheRuleUntilThePairingGoes(t *testing.T) {
|
||||||
|
pairingBox(t)
|
||||||
|
laneTestProcess(t)
|
||||||
|
// Opened without machine authority, so the Host is not put in charge
|
||||||
|
// (anchorAfterWindow) and `unpair` below may remove it: which Host is in
|
||||||
|
// charge is TestAServerPairedThroughTheWindowHasThatHostInCharge's.
|
||||||
|
prevAuth := machineAuthorityHeld
|
||||||
|
machineAuthorityHeld = func() bool { return false }
|
||||||
|
t.Cleanup(func() { machineAuthorityHeld = prevAuth })
|
||||||
|
f := fwFakeWorld(t)
|
||||||
|
addr := freeDoorAddr(t)
|
||||||
|
port := doorPort(addr)
|
||||||
|
code, _, res := openWindowFor(t, addr)
|
||||||
|
ca := newTestCA(t, "home host CA")
|
||||||
|
h := newStandinHost(t, ca, "home", "home.cseries.localhost", addr)
|
||||||
|
if done, err := h.pair(formatWindowCode(code)); err != nil || done.State != pairingActive {
|
||||||
|
t.Fatalf("pair: %+v %v", done, err)
|
||||||
|
}
|
||||||
|
if err := <-res; err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if !f.open(port) {
|
||||||
|
t.Fatal("the window's end removed the rule its active pairing needs")
|
||||||
|
}
|
||||||
|
cfgs, _ := loadPairings()
|
||||||
|
cfg := pairingFor(cfgs, "home")
|
||||||
|
// Its local control on a free port: the machine running the suite may
|
||||||
|
// have its own bastion on the default one.
|
||||||
|
cfg.ListenAddr = freeDoorAddr(t)
|
||||||
|
stop := runPairingBG(t, cfg)
|
||||||
|
doorWaitFor(t, 5*time.Second, "the door to bind", func() bool {
|
||||||
|
c, err := net.DialTimeout("tcp", addr, time.Second)
|
||||||
|
if err == nil {
|
||||||
|
_ = c.Close()
|
||||||
|
}
|
||||||
|
return err == nil
|
||||||
|
})
|
||||||
|
if err := stop(); err != nil && !errors.Is(err, errPairingNotActive) {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if !f.open(port) {
|
||||||
|
t.Fatal("the bastion stopping removed the rule of a pairing that is still there")
|
||||||
|
}
|
||||||
|
if f.adds != 1 {
|
||||||
|
t.Fatalf("%d adds", f.adds)
|
||||||
|
}
|
||||||
|
if err := cmdUnpair("home"); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if f.open(port) {
|
||||||
|
t.Fatal("the rule outlived the last pairing")
|
||||||
|
}
|
||||||
|
// MUTATION: cmdUnpair does not release. RESULT: red, the rule outlived the last pairing.
|
||||||
|
// MUTATION: doorPortWanted ignores pairings. RESULT: red, the window's end removed the rule.
|
||||||
|
}
|
||||||
|
|
||||||
|
// The daemon's door alone: bound, it opens the way in; its last pairing
|
||||||
|
// stopped and gone, the rule goes with it.
|
||||||
|
func TestTheDaemonsDoorRemovesTheRuleWhenItsLastPairingGoes(t *testing.T) {
|
||||||
|
pairingBox(t)
|
||||||
|
laneTestProcess(t)
|
||||||
|
f := fwFakeWorld(t)
|
||||||
|
ca := newTestCA(t, "home host CA")
|
||||||
|
addr := freeDoorAddr(t)
|
||||||
|
cfg := hostDialsPairingFor(t, ca, "home.cseries.localhost", addr) // never saved: gone once it stops
|
||||||
|
stop := runPairingBG(t, cfg)
|
||||||
|
doorWaitFor(t, 5*time.Second, "the rule", func() bool { return f.open(doorPort(addr)) })
|
||||||
|
if err := stop(); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
doorWaitFor(t, 5*time.Second, "the rule to go", func() bool { return !f.open(doorPort(addr)) })
|
||||||
|
// MUTATION: the door's release does not call doorFirewallRelease. RESULT: red, timed out waiting for the rule to go.
|
||||||
|
// MUTATION: bindLoop does not ensure. RESULT: red, timed out waiting for the rule.
|
||||||
|
}
|
||||||
|
|
||||||
|
// fwHung is a firewall whose commands hang until let go.
|
||||||
|
type fwHung struct {
|
||||||
|
*fwFake
|
||||||
|
gate chan struct{}
|
||||||
|
}
|
||||||
|
|
||||||
|
func (f *fwHung) has(port string) (bool, bool, error) { <-f.gate; return f.fwFake.has(port) }
|
||||||
|
|
||||||
|
// A firewall command that hangs never holds the daemon's door shut: the door
|
||||||
|
// serves while the bastion waits on the firewall.
|
||||||
|
func TestTheDoorServesWhileTheFirewallHangs(t *testing.T) {
|
||||||
|
pairingBox(t)
|
||||||
|
laneTestProcess(t)
|
||||||
|
f := &fwHung{fwFake: &fwFake{rules: map[string]bool{}}, gate: make(chan struct{})}
|
||||||
|
prevFor, prevBy := doorFirewallFor, doorFirewallByID
|
||||||
|
t.Cleanup(func() { doorFirewallFor, doorFirewallByID = prevFor, prevBy })
|
||||||
|
doorFirewallFor = func(string) (doorFirewall, string) { return f, "" }
|
||||||
|
doorFirewallByID = func(string) doorFirewall { return f }
|
||||||
|
var once sync.Once
|
||||||
|
release := func() { once.Do(func() { close(f.gate) }) }
|
||||||
|
t.Cleanup(release)
|
||||||
|
ca := newTestCA(t, "home host CA")
|
||||||
|
addr := freeDoorAddr(t)
|
||||||
|
cfg := hostDialsPairingFor(t, ca, "home.cseries.localhost", addr)
|
||||||
|
stop := runPairingBG(t, cfg)
|
||||||
|
doorWaitFor(t, 5*time.Second, "the door to answer a handshake", func() bool {
|
||||||
|
c, err := net.DialTimeout("tcp", addr, time.Second)
|
||||||
|
if err != nil {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
defer c.Close()
|
||||||
|
_ = c.SetDeadline(time.Now().Add(time.Second))
|
||||||
|
err = tls.Client(c, &tls.Config{InsecureSkipVerify: true, ServerName: tcpServerName}).Handshake()
|
||||||
|
var ne net.Error
|
||||||
|
return err == nil || !(errors.As(err, &ne) && ne.Timeout())
|
||||||
|
})
|
||||||
|
release()
|
||||||
|
doorWaitFor(t, 5*time.Second, "the rule", func() bool { return f.open(doorPort(addr)) })
|
||||||
|
if err := stop(); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
// MUTATION: bindLoop ensures before it serves. RESULT: red, timed out waiting for the door to answer a handshake.
|
||||||
|
}
|
||||||
@@ -114,17 +114,17 @@ func (c *wsConn) SetWriteDeadline(t time.Time) error { return c.ws.SetWriteDeadl
|
|||||||
func runEgressWorkers(pctx context.Context, self string, wsURL string, tlsCfg *tls.Config,
|
func runEgressWorkers(pctx context.Context, self string, wsURL string, tlsCfg *tls.Config,
|
||||||
dialHost func(ctx context.Context) (net.Conn, error), bearer string,
|
dialHost func(ctx context.Context) (net.Conn, error), bearer string,
|
||||||
dialOut egressDialer, n int) (wait func()) {
|
dialOut egressDialer, n int) (wait func()) {
|
||||||
dialer := &websocket.Dialer{
|
dialer := laneWSDialer(tlsCfg, dialHost)
|
||||||
NetDialContext: func(ctx context.Context, network, addr string) (net.Conn, error) { return dialHost(ctx) },
|
|
||||||
TLSClientConfig: tlsCfg,
|
|
||||||
HandshakeTimeout: 20 * time.Second,
|
|
||||||
}
|
|
||||||
var wg sync.WaitGroup
|
var wg sync.WaitGroup
|
||||||
for i := 0; i < n; i++ {
|
for i := 0; i < n; i++ {
|
||||||
wg.Add(1)
|
wg.Add(1)
|
||||||
go func() {
|
go func() {
|
||||||
defer wg.Done()
|
defer wg.Done()
|
||||||
|
hold := laneHoldFor(self)
|
||||||
for pctx.Err() == nil {
|
for pctx.Err() == nil {
|
||||||
|
if !hold.waitClear(pctx) {
|
||||||
|
return
|
||||||
|
}
|
||||||
ctx, cancel := context.WithTimeout(pctx, 25*time.Second)
|
ctx, cancel := context.WithTimeout(pctx, 25*time.Second)
|
||||||
ws, _, err := dialer.DialContext(ctx, wsURL, http.Header{})
|
ws, _, err := dialer.DialContext(ctx, wsURL, http.Header{})
|
||||||
cancel()
|
cancel()
|
||||||
@@ -137,12 +137,17 @@ func runEgressWorkers(pctx context.Context, self string, wsURL string, tlsCfg *t
|
|||||||
sleepCtx(pctx, time.Second)
|
sleepCtx(pctx, time.Second)
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
|
held := watchHeldClose(ws)
|
||||||
stopKA := armWSKeepalive(ws) // ping/read-deadline: a dead tunnel unblocks the park
|
stopKA := armWSKeepalive(ws) // ping/read-deadline: a dead tunnel unblocks the park
|
||||||
unpark := context.AfterFunc(pctx, func() { _ = ws.Close() })
|
unpark := context.AfterFunc(pctx, func() { _ = ws.Close() })
|
||||||
took := handleEgressConn(&wsConn{ws: ws}, dialOut, self) // blocks until a job, serves it, then returns
|
took := handleEgressConn(&wsConn{ws: ws}, dialOut, self) // blocks until a job, serves it, then returns
|
||||||
unpark()
|
unpark()
|
||||||
stopKA()
|
stopKA()
|
||||||
_ = ws.Close()
|
_ = ws.Close()
|
||||||
|
if held() {
|
||||||
|
hold.refused(self) // the Host holds this machine (lanehold.go)
|
||||||
|
continue
|
||||||
|
}
|
||||||
if !took {
|
if !took {
|
||||||
sleepCtx(pctx, egressRefusedWait)
|
sleepCtx(pctx, egressRefusedWait)
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -117,7 +117,7 @@ func buildEnforcingReport(dir string, allowed []string) map[string]any {
|
|||||||
b, _ := strconv.ParseInt(ids[j], 10, 64)
|
b, _ := strconv.ParseInt(ids[j], 10, 64)
|
||||||
return a < b
|
return a < b
|
||||||
})
|
})
|
||||||
status := faManagedStatus()
|
status := faManagedStatus(dir)
|
||||||
for _, k := range ids {
|
for _, k := range ids {
|
||||||
id, err := strconv.ParseInt(k, 10, 64)
|
id, err := strconv.ParseInt(k, 10, 64)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
|
|||||||
+8
-1
@@ -31,4 +31,11 @@ var agentTokenEnvNames = []string{"PRIVATAE_AGENT_TOKEN", "SKEMA_AGENT_TOKEN"}
|
|||||||
// written.
|
// written.
|
||||||
func piiTarget() string { return os.Getenv("PRIVATAE_PII_ADDR") }
|
func piiTarget() string { return os.Getenv("PRIVATAE_PII_ADDR") }
|
||||||
|
|
||||||
func llmTarget() string { return os.Getenv("PRIVATAE_LLM_ADDR") }
|
// llmTarget is PRIVATAE_LLM_ADDR, or, unset, the OpenAI-compatible server
|
||||||
|
// found on this machine's loopback (llmlocal.go), "" when there is none.
|
||||||
|
func llmTarget() string {
|
||||||
|
if v := os.Getenv("PRIVATAE_LLM_ADDR"); v != "" {
|
||||||
|
return v
|
||||||
|
}
|
||||||
|
return discoveredLLM().Addr
|
||||||
|
}
|
||||||
|
|||||||
+10
-10
@@ -223,8 +223,8 @@ func freeagentDo(c freeagentConfig, method, path string, body any, d time.Durati
|
|||||||
// faConfigFor is the client config for a store: the MANAGED instance the
|
// faConfigFor is the client config for a store: the MANAGED instance the
|
||||||
// bastion runs for it (freeagent_managed.go) when there is one, else the
|
// bastion runs for it (freeagent_managed.go) when there is one, else the
|
||||||
// operator's PRIVATAE_BASTION_AGENT_* env for a hand-run agent.
|
// operator's PRIVATAE_BASTION_AGENT_* env for a hand-run agent.
|
||||||
func faConfigFor(storeID int64) (freeagentConfig, bool) {
|
func faConfigFor(dcnDir string, storeID int64) (freeagentConfig, bool) {
|
||||||
if c, ok := faManagedConfig(storeID); ok {
|
if c, ok := faManagedConfig(dcnDir, storeID); ok {
|
||||||
return c, true
|
return c, true
|
||||||
}
|
}
|
||||||
return freeagentEnv()
|
return freeagentEnv()
|
||||||
@@ -232,8 +232,8 @@ func faConfigFor(storeID int64) (freeagentConfig, bool) {
|
|||||||
|
|
||||||
// faAbsentReason says WHY there is no local agent to ask, in the words the
|
// faAbsentReason says WHY there is no local agent to ask, in the words the
|
||||||
// host should relay: a missing Python is the member's one manual step.
|
// host should relay: a missing Python is the member's one manual step.
|
||||||
func faAbsentReason(storeID int64) string {
|
func faAbsentReason(dcnDir string, storeID int64) string {
|
||||||
inst, ok := faSnapshot(storeID)
|
inst, ok := faSnapshot(dcnDir, storeID)
|
||||||
if ok {
|
if ok {
|
||||||
switch inst.State {
|
switch inst.State {
|
||||||
case "missing-python":
|
case "missing-python":
|
||||||
@@ -358,9 +358,9 @@ func handleDcnSearch(ws *websocket.Conn, dir string, args []string) {
|
|||||||
if terms == nil {
|
if terms == nil {
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
c, on := faConfigFor(storeID)
|
c, on := faConfigFor(dir, storeID)
|
||||||
if !on {
|
if !on {
|
||||||
dcnRefuse(ws, dir, "search", storeID, "", faAbsentReason(storeID))
|
dcnRefuse(ws, dir, "search", storeID, "", faAbsentReason(dir, storeID))
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
q := strings.TrimSpace(a.Query)
|
q := strings.TrimSpace(a.Query)
|
||||||
@@ -419,9 +419,9 @@ func handleDcnCatalog(ws *websocket.Conn, dir string, args []string) {
|
|||||||
"catalog needs the 'index' mask on this grant (re-approve the store with index)")
|
"catalog needs the 'index' mask on this grant (re-approve the store with index)")
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
c, on := faConfigFor(storeID)
|
c, on := faConfigFor(dir, storeID)
|
||||||
if !on {
|
if !on {
|
||||||
dcnRefuse(ws, dir, "catalog", storeID, "kind:"+kind, faAbsentReason(storeID))
|
dcnRefuse(ws, dir, "catalog", storeID, "kind:"+kind, faAbsentReason(dir, storeID))
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
path := "/catalog"
|
path := "/catalog"
|
||||||
@@ -471,9 +471,9 @@ func handleDcnReadRangeDoc(ws *websocket.Conn, dir string, storeID int64, a *dcn
|
|||||||
if terms == nil {
|
if terms == nil {
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
c, on := faConfigFor(storeID)
|
c, on := faConfigFor(dir, storeID)
|
||||||
if !on {
|
if !on {
|
||||||
dcnRefuse(ws, dir, "read_range", storeID, "doc:"+a.Doc, faAbsentReason(storeID))
|
dcnRefuse(ws, dir, "read_range", storeID, "doc:"+a.Doc, faAbsentReason(dir, storeID))
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
start := a.StartByte
|
start := a.StartByte
|
||||||
|
|||||||
@@ -123,20 +123,29 @@ type faInstance struct {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// faSnapshot copies the fields a reader needs, under the lock.
|
// faSnapshot copies the fields a reader needs, under the lock.
|
||||||
func faSnapshot(storeID int64) (faInstance, bool) {
|
func faSnapshot(dcnDir string, storeID int64) (faInstance, bool) {
|
||||||
faMgr.Lock()
|
faMgr.Lock()
|
||||||
defer faMgr.Unlock()
|
defer faMgr.Unlock()
|
||||||
inst, ok := faMgr.inst[storeID]
|
inst, ok := faMgr.inst[faKey{dcnDir, storeID}]
|
||||||
if !ok {
|
if !ok {
|
||||||
return faInstance{}, false
|
return faInstance{}, false
|
||||||
}
|
}
|
||||||
return *inst, true
|
return *inst, true
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// faKey is one pairing's store: store ids are each Host's own, so the same id
|
||||||
|
// from two Hosts is two stores. Keyed by store id alone, a machine paired with
|
||||||
|
// two Hosts ran one agent for both, and a search from one Host for its store
|
||||||
|
// was answered by the agent over the other Host's folder.
|
||||||
|
type faKey struct {
|
||||||
|
Dir string // the pairing's DCN state dir (Config.dcnDir)
|
||||||
|
ID int64
|
||||||
|
}
|
||||||
|
|
||||||
var faMgr = struct {
|
var faMgr = struct {
|
||||||
sync.Mutex
|
sync.Mutex
|
||||||
inst map[int64]*faInstance
|
inst map[faKey]*faInstance
|
||||||
}{inst: map[int64]*faInstance{}}
|
}{inst: map[faKey]*faInstance{}}
|
||||||
|
|
||||||
// ── locations ───────────────────────────────────────────────────────────────
|
// ── locations ───────────────────────────────────────────────────────────────
|
||||||
|
|
||||||
@@ -664,8 +673,8 @@ func faRecipientOf(inst *faInstance) string {
|
|||||||
|
|
||||||
// faManagedConfig is the client config for a store's managed instance, or
|
// faManagedConfig is the client config for a store's managed instance, or
|
||||||
// false when none is running (port file absent).
|
// false when none is running (port file absent).
|
||||||
func faManagedConfig(storeID int64) (freeagentConfig, bool) {
|
func faManagedConfig(dcnDir string, storeID int64) (freeagentConfig, bool) {
|
||||||
inst, ok := faSnapshot(storeID)
|
inst, ok := faSnapshot(dcnDir, storeID)
|
||||||
if !ok {
|
if !ok {
|
||||||
return freeagentConfig{}, false
|
return freeagentConfig{}, false
|
||||||
}
|
}
|
||||||
@@ -697,10 +706,11 @@ func faEnsureStore(dcnDir string, storeID int64, terms *dcnTerms, sweep, recipie
|
|||||||
}
|
}
|
||||||
cn := "store-" + strconv.FormatInt(storeID, 10)
|
cn := "store-" + strconv.FormatInt(storeID, 10)
|
||||||
faMgr.Lock()
|
faMgr.Lock()
|
||||||
inst, ok := faMgr.inst[storeID]
|
key := faKey{dcnDir, storeID}
|
||||||
|
inst, ok := faMgr.inst[key]
|
||||||
if !ok {
|
if !ok {
|
||||||
inst = &faInstance{StoreID: storeID, Dir: dir, PrivDir: priv, PubDir: pub, CN: cn, State: "installing"}
|
inst = &faInstance{StoreID: storeID, Dir: dir, PrivDir: priv, PubDir: pub, CN: cn, State: "installing"}
|
||||||
faMgr.inst[storeID] = inst
|
faMgr.inst[key] = inst
|
||||||
} else if inst.State == "installing" || inst.ensuring {
|
} else if inst.State == "installing" || inst.ensuring {
|
||||||
faMgr.Unlock()
|
faMgr.Unlock()
|
||||||
return // one ensure at a time per store — see faInstance.ensuring
|
return // one ensure at a time per store — see faInstance.ensuring
|
||||||
@@ -993,22 +1003,27 @@ func sweepFromCanonical(termsB64 string) string {
|
|||||||
return ""
|
return ""
|
||||||
}
|
}
|
||||||
|
|
||||||
// faManagedProbe reports (anyManaged, allServing) and refreshes each
|
// faManagedProbe reports (anyManaged, allServing) for ONE pairing's instances
|
||||||
// instance's Serving flag by probing its /health over mTLS.
|
// and refreshes their Serving flags by probing each /health over mTLS. Another
|
||||||
func faManagedProbe() (bool, bool) {
|
// pairing's agents are never counted: its health is not this Host's to hear,
|
||||||
|
// and this Host reads the capability as "my stores here are served" when its
|
||||||
|
// own freeagent_stores is empty (faManagedStatus). "" probes none.
|
||||||
|
func faManagedProbe(dcnDir string) (bool, bool) {
|
||||||
faMgr.Lock()
|
faMgr.Lock()
|
||||||
ids := make([]int64, 0, len(faMgr.inst))
|
keys := make([]faKey, 0, len(faMgr.inst))
|
||||||
for id := range faMgr.inst {
|
for k := range faMgr.inst {
|
||||||
ids = append(ids, id)
|
if dcnDir != "" && k.Dir == dcnDir {
|
||||||
|
keys = append(keys, k)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
faMgr.Unlock()
|
faMgr.Unlock()
|
||||||
if len(ids) == 0 {
|
if len(keys) == 0 {
|
||||||
return false, false
|
return false, false
|
||||||
}
|
}
|
||||||
all := true
|
all := true
|
||||||
for _, id := range ids {
|
for _, k := range keys {
|
||||||
serving := false
|
serving := false
|
||||||
if c, ok := faManagedConfig(id); ok {
|
if c, ok := faManagedConfig(k.Dir, k.ID); ok {
|
||||||
status, body, err := freeagentCallTimeout(c, http.MethodGet, "/health", nil, freeagentProbeTimeout)
|
status, body, err := freeagentCallTimeout(c, http.MethodGet, "/health", nil, freeagentProbeTimeout)
|
||||||
if err == nil && status == http.StatusOK {
|
if err == nil && status == http.StatusOK {
|
||||||
var h struct {
|
var h struct {
|
||||||
@@ -1019,7 +1034,7 @@ func faManagedProbe() (bool, bool) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
faMgr.Lock()
|
faMgr.Lock()
|
||||||
if inst, ok := faMgr.inst[id]; ok {
|
if inst, ok := faMgr.inst[k]; ok {
|
||||||
inst.Serving = serving
|
inst.Serving = serving
|
||||||
}
|
}
|
||||||
faMgr.Unlock()
|
faMgr.Unlock()
|
||||||
@@ -1030,13 +1045,20 @@ func faManagedProbe() (bool, bool) {
|
|||||||
return true, all
|
return true, all
|
||||||
}
|
}
|
||||||
|
|
||||||
// faManagedStatus is the heartbeat's per-store detail.
|
// faManagedStatus is one pairing's per-store detail for its heartbeat: only
|
||||||
func faManagedStatus() map[string]any {
|
// its own stores, never another Host's.
|
||||||
|
func faManagedStatus(dcnDir string) map[string]any {
|
||||||
faMgr.Lock()
|
faMgr.Lock()
|
||||||
defer faMgr.Unlock()
|
defer faMgr.Unlock()
|
||||||
out := map[string]any{}
|
out := map[string]any{}
|
||||||
for id, inst := range faMgr.inst {
|
if dcnDir == "" {
|
||||||
out[strconv.FormatInt(id, 10)] = map[string]any{
|
return out
|
||||||
|
}
|
||||||
|
for k, inst := range faMgr.inst {
|
||||||
|
if k.Dir != dcnDir {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
out[strconv.FormatInt(k.ID, 10)] = map[string]any{
|
||||||
"state": inst.State, "serving": inst.Serving, "version": inst.Version, "detail": inst.Detail,
|
"state": inst.State, "serving": inst.Serving, "version": inst.Version, "detail": inst.Detail,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -1045,14 +1067,15 @@ func faManagedStatus() map[string]any {
|
|||||||
|
|
||||||
// faStop tears down a store's managed instance (grant revoked / re-synced
|
// faStop tears down a store's managed instance (grant revoked / re-synced
|
||||||
// without search).
|
// without search).
|
||||||
func faStop(storeID int64) {
|
func faStop(dcnDir string, storeID int64) {
|
||||||
faMgr.Lock()
|
faMgr.Lock()
|
||||||
defer faMgr.Unlock()
|
defer faMgr.Unlock()
|
||||||
if inst, ok := faMgr.inst[storeID]; ok {
|
key := faKey{dcnDir, storeID}
|
||||||
|
if inst, ok := faMgr.inst[key]; ok {
|
||||||
if inst.cancel != nil {
|
if inst.cancel != nil {
|
||||||
inst.cancel()
|
inst.cancel()
|
||||||
}
|
}
|
||||||
delete(faMgr.inst, storeID)
|
delete(faMgr.inst, key)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -182,29 +182,64 @@ func TestFaManifestText(t *testing.T) {
|
|||||||
func TestFaManagedConfigFromPortFile(t *testing.T) {
|
func TestFaManagedConfigFromPortFile(t *testing.T) {
|
||||||
dir := t.TempDir()
|
dir := t.TempDir()
|
||||||
faMgr.Lock()
|
faMgr.Lock()
|
||||||
faMgr.inst[4242] = &faInstance{StoreID: 4242, Dir: dir, Cert: "c", Key: "k"}
|
faMgr.inst[faKey{"dcn-test", 4242}] = &faInstance{StoreID: 4242, Dir: dir, Cert: "c", Key: "k"}
|
||||||
faMgr.Unlock()
|
faMgr.Unlock()
|
||||||
t.Cleanup(func() { faStop(4242) })
|
t.Cleanup(func() { faStop("dcn-test", 4242) })
|
||||||
if _, ok := faManagedConfig(4242); ok {
|
if _, ok := faManagedConfig("dcn-test", 4242); ok {
|
||||||
t.Fatal("no port file → not configured")
|
t.Fatal("no port file → not configured")
|
||||||
}
|
}
|
||||||
os.WriteFile(filepath.Join(dir, "port"), []byte("18473\n"), 0o600)
|
os.WriteFile(filepath.Join(dir, "port"), []byte("18473\n"), 0o600)
|
||||||
c, ok := faManagedConfig(4242)
|
c, ok := faManagedConfig("dcn-test", 4242)
|
||||||
if !ok || c.Addr != "127.0.0.1:18473" || c.CA != "c" {
|
if !ok || c.Addr != "127.0.0.1:18473" || c.CA != "c" {
|
||||||
t.Fatalf("port file → config, got %+v %v", c, ok)
|
t.Fatalf("port file → config, got %+v %v", c, ok)
|
||||||
}
|
}
|
||||||
if _, ok := faConfigFor(4242); !ok {
|
if _, ok := faConfigFor("dcn-test", 4242); !ok {
|
||||||
t.Fatal("faConfigFor must prefer the managed instance")
|
t.Fatal("faConfigFor must prefer the managed instance")
|
||||||
}
|
}
|
||||||
t.Setenv("PRIVATAE_BASTION_AGENT_ADDR", "")
|
t.Setenv("PRIVATAE_BASTION_AGENT_ADDR", "")
|
||||||
if _, ok := faConfigFor(1); ok {
|
if _, ok := faConfigFor("dcn-test", 1); ok {
|
||||||
t.Fatal("unknown store with no env → absent")
|
t.Fatal("unknown store with no env → absent")
|
||||||
}
|
}
|
||||||
if !strings.Contains(faAbsentReason(1), "no local agent") {
|
if !strings.Contains(faAbsentReason("dcn-test", 1), "no local agent") {
|
||||||
t.Fatal("absent reason for an unknown store")
|
t.Fatal("absent reason for an unknown store")
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// A beat's freeagent capability and freeagent_ok are its own pairing's agents
|
||||||
|
// only. Probed across every pairing, Host B's beat carried Host A's agent's
|
||||||
|
// health, and with B's freeagent_stores now empty the Host reads the
|
||||||
|
// capability alone (the Host's store-card check: `"freeagent"
|
||||||
|
// in caps and not stores`), so A's serving agent marked every one of B's
|
||||||
|
// stores on this machine as served.
|
||||||
|
func TestHeartbeatProbesOnlyItsOwnPairingsAgents(t *testing.T) {
|
||||||
|
t.Setenv("PRIVATAE_BASTION_AGENT_ADDR", "") // no hand-run agent
|
||||||
|
dcnA, dcnB := t.TempDir(), t.TempDir()
|
||||||
|
faMgr.Lock()
|
||||||
|
// no port file: A's agent is managed and not serving
|
||||||
|
faMgr.inst[faKey{dcnA, 7}] = &faInstance{StoreID: 7, Dir: t.TempDir(), Cert: "a", Key: "a"}
|
||||||
|
faMgr.Unlock()
|
||||||
|
t.Cleanup(func() { faStop(dcnA, 7) })
|
||||||
|
beat := func(dir string) map[string]any {
|
||||||
|
var body map[string]any
|
||||||
|
raw := buildHeartbeatBodyOn(beatLanes{dcnDir: dir}, "", "box", "linux", "test", "pub", "fp", "", "", false, nil, nil, nil)
|
||||||
|
if err := json.Unmarshal([]byte(raw), &body); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
return body
|
||||||
|
}
|
||||||
|
// MUTATION: probe every pairing's instances (no k.Dir filter in
|
||||||
|
// faManagedProbe). RESULT: red, B's beat carries freeagent_ok false.
|
||||||
|
if b, ok := beat(dcnB)["freeagent_ok"]; ok {
|
||||||
|
t.Errorf("Host B holds no agent here, yet its beat says freeagent_ok %v", b)
|
||||||
|
}
|
||||||
|
if b, ok := beat(dcnA)["freeagent_ok"]; !ok || b != false {
|
||||||
|
t.Errorf("Host A's beat must carry its own agent's health: %v %v", b, ok)
|
||||||
|
}
|
||||||
|
if b, ok := beat("")["freeagent_ok"]; ok {
|
||||||
|
t.Errorf("a beat with no DCN state probes no managed agent: %v", b)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// End to end with the real artifact: FREEAGENT_TEST_PYZ=/path/to/freeagent-x.pyz
|
// End to end with the real artifact: FREEAGENT_TEST_PYZ=/path/to/freeagent-x.pyz
|
||||||
func TestFaManagedEndToEnd(t *testing.T) {
|
func TestFaManagedEndToEnd(t *testing.T) {
|
||||||
pyzPath := os.Getenv("FREEAGENT_TEST_PYZ")
|
pyzPath := os.Getenv("FREEAGENT_TEST_PYZ")
|
||||||
@@ -264,7 +299,7 @@ func TestFaManagedEndToEnd(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
faReconcile(dcnDir) // what the daemon does at start
|
faReconcile(dcnDir) // what the daemon does at start
|
||||||
t.Cleanup(func() { faStop(1) })
|
t.Cleanup(func() { faStop(dcnDir, 1) })
|
||||||
stateDir, err := faStoreDir(dcnDir, 1)
|
stateDir, err := faStoreDir(dcnDir, 1)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
@@ -274,7 +309,7 @@ func TestFaManagedEndToEnd(t *testing.T) {
|
|||||||
var c freeagentConfig
|
var c freeagentConfig
|
||||||
for time.Now().Before(deadline) {
|
for time.Now().Before(deadline) {
|
||||||
faMgr.Lock()
|
faMgr.Lock()
|
||||||
inst := faMgr.inst[1]
|
inst := faMgr.inst[faKey{dcnDir, 1}]
|
||||||
state, detail := "", ""
|
state, detail := "", ""
|
||||||
if inst != nil {
|
if inst != nil {
|
||||||
state, detail = inst.State, inst.Detail
|
state, detail = inst.State, inst.Detail
|
||||||
@@ -283,7 +318,7 @@ func TestFaManagedEndToEnd(t *testing.T) {
|
|||||||
if state == "failed" || state == "missing-python" {
|
if state == "failed" || state == "missing-python" {
|
||||||
t.Fatalf("managed install %s: %s", state, detail)
|
t.Fatalf("managed install %s: %s", state, detail)
|
||||||
}
|
}
|
||||||
if cfg, ok := faManagedConfig(1); ok {
|
if cfg, ok := faManagedConfig(dcnDir, 1); ok {
|
||||||
c = cfg
|
c = cfg
|
||||||
break
|
break
|
||||||
}
|
}
|
||||||
@@ -395,11 +430,11 @@ func TestFaManagedEndToEnd(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
// heartbeat sees it
|
// heartbeat sees it
|
||||||
adv, allOK := faManagedProbe()
|
adv, allOK := faManagedProbe(dcnDir)
|
||||||
if !adv || !allOK {
|
if !adv || !allOK {
|
||||||
t.Fatalf("managed probe: %v %v", adv, allOK)
|
t.Fatalf("managed probe: %v %v", adv, allOK)
|
||||||
}
|
}
|
||||||
st := faManagedStatus()["1"].(map[string]any)
|
st := faManagedStatus(dcnDir)["1"].(map[string]any)
|
||||||
if st["state"] != "running" || st["serving"] != true || st["version"] != "9.9.9" {
|
if st["state"] != "running" || st["serving"] != true || st["version"] != "9.9.9" {
|
||||||
t.Fatalf("status: %v", st)
|
t.Fatalf("status: %v", st)
|
||||||
}
|
}
|
||||||
@@ -417,7 +452,7 @@ func TestFaManagedEndToEnd(t *testing.T) {
|
|||||||
|
|
||||||
// a re-approved grant with narrower terms restarts
|
// a re-approved grant with narrower terms restarts
|
||||||
// the instance under the new manifest (new excludes, new serve port)
|
// the instance under the new manifest (new excludes, new serve port)
|
||||||
before, _ := faSnapshot(1)
|
before, _ := faSnapshot(dcnDir, 1)
|
||||||
terms2 := map[string]any{}
|
terms2 := map[string]any{}
|
||||||
for k, v := range terms {
|
for k, v := range terms {
|
||||||
terms2[k] = v
|
terms2[k] = v
|
||||||
@@ -432,9 +467,9 @@ func TestFaManagedEndToEnd(t *testing.T) {
|
|||||||
deadline = time.Now().Add(60 * time.Second)
|
deadline = time.Now().Add(60 * time.Second)
|
||||||
var after faInstance
|
var after faInstance
|
||||||
for time.Now().Before(deadline) {
|
for time.Now().Before(deadline) {
|
||||||
after, _ = faSnapshot(1)
|
after, _ = faSnapshot(dcnDir, 1)
|
||||||
if after.State == "running" && after.Text != before.Text {
|
if after.State == "running" && after.Text != before.Text {
|
||||||
if c2, ok := faManagedConfig(1); ok && c2.Addr != c.Addr {
|
if c2, ok := faManagedConfig(dcnDir, 1); ok && c2.Addr != c.Addr {
|
||||||
break
|
break
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -448,10 +483,10 @@ func TestFaManagedEndToEnd(t *testing.T) {
|
|||||||
t.Fatal("re-rendered manifest must carry the new excludes and be re-signed")
|
t.Fatal("re-rendered manifest must carry the new excludes and be re-signed")
|
||||||
}
|
}
|
||||||
// unchanged terms on the next reconcile: no restart (same port)
|
// unchanged terms on the next reconcile: no restart (same port)
|
||||||
c3, _ := faManagedConfig(1)
|
c3, _ := faManagedConfig(dcnDir, 1)
|
||||||
faReconcile(dcnDir)
|
faReconcile(dcnDir)
|
||||||
time.Sleep(time.Second)
|
time.Sleep(time.Second)
|
||||||
c4, _ := faManagedConfig(1)
|
c4, _ := faManagedConfig(dcnDir, 1)
|
||||||
if c3.Addr != c4.Addr {
|
if c3.Addr != c4.Addr {
|
||||||
t.Fatal("identical terms must not restart the instance")
|
t.Fatal("identical terms must not restart the instance")
|
||||||
}
|
}
|
||||||
@@ -459,7 +494,7 @@ func TestFaManagedEndToEnd(t *testing.T) {
|
|||||||
// A fresh identity with a surviving manifest (new layout, wiped base, a
|
// A fresh identity with a surviving manifest (new layout, wiped base, a
|
||||||
// re-pair): the manifest must be re-signed under the new cert, or the
|
// re-pair): the manifest must be re-signed under the new cert, or the
|
||||||
// gate refuses it and serve answers 503 forever.
|
// gate refuses it and serve answers 503 forever.
|
||||||
faStop(1)
|
faStop(dcnDir, 1)
|
||||||
_, privDir, _, _ := faStoreDirs(dcnDir, 1)
|
_, privDir, _, _ := faStoreDirs(dcnDir, 1)
|
||||||
if err := os.RemoveAll(filepath.Join(privDir, "host.key")); err != nil {
|
if err := os.RemoveAll(filepath.Join(privDir, "host.key")); err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
@@ -470,15 +505,15 @@ func TestFaManagedEndToEnd(t *testing.T) {
|
|||||||
deadline = time.Now().Add(60 * time.Second)
|
deadline = time.Now().Add(60 * time.Second)
|
||||||
var c9 freeagentConfig
|
var c9 freeagentConfig
|
||||||
for time.Now().Before(deadline) {
|
for time.Now().Before(deadline) {
|
||||||
if cfg, ok := faManagedConfig(1); ok && cfg.Addr != "" {
|
if cfg, ok := faManagedConfig(dcnDir, 1); ok && cfg.Addr != "" {
|
||||||
if st, _ := faSnapshot(1); st.State == "running" && st.Cert != "" {
|
if st, _ := faSnapshot(dcnDir, 1); st.State == "running" && st.Cert != "" {
|
||||||
if _, body, err := freeagentCall(cfg, http.MethodGet, "/health", nil); err == nil && strings.Contains(string(body), `"serving": true`) {
|
if _, body, err := freeagentCall(cfg, http.MethodGet, "/health", nil); err == nil && strings.Contains(string(body), `"serving": true`) {
|
||||||
c9 = cfg
|
c9 = cfg
|
||||||
break
|
break
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
if st, _ := faSnapshot(1); st.State == "failed" {
|
if st, _ := faSnapshot(dcnDir, 1); st.State == "failed" {
|
||||||
t.Fatalf("re-identity: %s", st.Detail)
|
t.Fatalf("re-identity: %s", st.Detail)
|
||||||
}
|
}
|
||||||
time.Sleep(500 * time.Millisecond)
|
time.Sleep(500 * time.Millisecond)
|
||||||
|
|||||||
@@ -41,11 +41,7 @@ const gitForgeHost = "git.privatae.ai"
|
|||||||
// runGitLane serves the loopback git proxy: one host WebSocket per local connection.
|
// runGitLane serves the loopback git proxy: one host WebSocket per local connection.
|
||||||
func runGitLane(ln net.Listener, wsURL string, tlsCfg *tls.Config,
|
func runGitLane(ln net.Listener, wsURL string, tlsCfg *tls.Config,
|
||||||
dialHost func(ctx context.Context) (net.Conn, error), bearer string) {
|
dialHost func(ctx context.Context) (net.Conn, error), bearer string) {
|
||||||
dialer := &websocket.Dialer{
|
dialer := laneWSDialer(tlsCfg, dialHost)
|
||||||
NetDialContext: func(ctx context.Context, network, addr string) (net.Conn, error) { return dialHost(ctx) },
|
|
||||||
TLSClientConfig: tlsCfg,
|
|
||||||
HandshakeTimeout: 20 * time.Second,
|
|
||||||
}
|
|
||||||
for {
|
for {
|
||||||
local, err := ln.Accept()
|
local, err := ln.Accept()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
@@ -149,7 +145,7 @@ func cmdGitCredential(host string, action string) error {
|
|||||||
case len(cfgs) == 1:
|
case len(cfgs) == 1:
|
||||||
cfg = cfgs[0]
|
cfg = cfgs[0]
|
||||||
case len(cfgs) == 0:
|
case len(cfgs) == 0:
|
||||||
return fmt.Errorf("not paired yet — run `privatae-bastion pair <token>` first")
|
return fmt.Errorf("not paired yet — connect a Host first: %s", asAdmin("pair <token>"))
|
||||||
default:
|
default:
|
||||||
return fmt.Errorf("%d hosts are paired — configure the helper with --host: "+
|
return fmt.Errorf("%d hosts are paired — configure the helper with --host: "+
|
||||||
"credential.https://git.privatae.ai.helper \"!privatae-bastion git-credential --host <host>\"", len(cfgs))
|
"credential.https://git.privatae.ai.helper \"!privatae-bastion git-credential --host <host>\"", len(cfgs))
|
||||||
|
|||||||
@@ -107,14 +107,14 @@ type harnessSpec struct {
|
|||||||
// instead of re-dialing a closed tunnel for the life of the process.
|
// instead of re-dialing a closed tunnel for the life of the process.
|
||||||
func runHarnessWorkers(pctx context.Context, self, dcnDir string, wsURL string, tlsCfg *tls.Config,
|
func runHarnessWorkers(pctx context.Context, self, dcnDir string, wsURL string, tlsCfg *tls.Config,
|
||||||
dialHost func(ctx context.Context) (net.Conn, error), bearer string, n int) {
|
dialHost func(ctx context.Context) (net.Conn, error), bearer string, n int) {
|
||||||
dialer := &websocket.Dialer{
|
dialer := laneWSDialer(tlsCfg, dialHost)
|
||||||
NetDialContext: func(ctx context.Context, network, addr string) (net.Conn, error) { return dialHost(ctx) },
|
|
||||||
TLSClientConfig: tlsCfg,
|
|
||||||
HandshakeTimeout: 20 * time.Second,
|
|
||||||
}
|
|
||||||
for i := 0; i < n; i++ {
|
for i := 0; i < n; i++ {
|
||||||
go func() {
|
go func() {
|
||||||
|
hold := laneHoldFor(self)
|
||||||
for pctx.Err() == nil {
|
for pctx.Err() == nil {
|
||||||
|
if !hold.waitClear(pctx) {
|
||||||
|
return
|
||||||
|
}
|
||||||
ctx, cancel := context.WithTimeout(pctx, 25*time.Second)
|
ctx, cancel := context.WithTimeout(pctx, 25*time.Second)
|
||||||
ws, _, err := dialer.DialContext(ctx, wsURL, http.Header{})
|
ws, _, err := dialer.DialContext(ctx, wsURL, http.Header{})
|
||||||
cancel()
|
cancel()
|
||||||
@@ -127,12 +127,16 @@ func runHarnessWorkers(pctx context.Context, self, dcnDir string, wsURL string,
|
|||||||
sleepCtx(pctx, time.Second)
|
sleepCtx(pctx, time.Second)
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
|
held := watchHeldClose(ws)
|
||||||
stopKA := armWSKeepalive(ws) // ping/read-deadline: a dead tunnel unblocks the park
|
stopKA := armWSKeepalive(ws) // ping/read-deadline: a dead tunnel unblocks the park
|
||||||
unpark := context.AfterFunc(pctx, func() { _ = ws.Close() })
|
unpark := context.AfterFunc(pctx, func() { _ = ws.Close() })
|
||||||
handleHarnessConn(ws, self, dcnDir) // blocks until a job, serves it, then returns
|
handleHarnessConn(ws, self, dcnDir) // blocks until a job, serves it, then returns
|
||||||
unpark()
|
unpark()
|
||||||
stopKA()
|
stopKA()
|
||||||
_ = ws.Close()
|
_ = ws.Close()
|
||||||
|
if held() {
|
||||||
|
hold.refused(self) // the Host holds this machine (lanehold.go)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}()
|
}()
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,778 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
// hostdoor.go: the door a Host connects to when this server can't reach it.
|
||||||
|
//
|
||||||
|
// A Host on a person's own computer sits behind their home router: a server
|
||||||
|
// on the internet can't open a connection to it, but it can open one to the
|
||||||
|
// server. So for such a pairing (Config.HostDials) the Host opens the TCP
|
||||||
|
// connections, to this server's door, and the lanes run over them exactly as
|
||||||
|
// they run over a connection this bastion dialled to a Host's lane port: this
|
||||||
|
// bastion is the TLS client, the Host's CA is the only root, the Host's
|
||||||
|
// certificate must name host.cseries.internal, and this bastion presents its
|
||||||
|
// operator certificate. Only the TCP direction is the other way round.
|
||||||
|
//
|
||||||
|
// One port serves every such pairing, and the Host's certificate says which
|
||||||
|
// pairing a connection is for: the door does the TLS handshake itself, as the
|
||||||
|
// client, and a connection whose Host certificate does not verify under the
|
||||||
|
// pinned CA of exactly one pairing it serves is closed before a byte of a lane
|
||||||
|
// crosses it. What passes is held, idle, in that pairing's pool, and a lane
|
||||||
|
// that would have dialled takes one from there instead (hostDoorDial). The TLS
|
||||||
|
// is already done, so the lane runs on it as it is (lanedial.go).
|
||||||
|
//
|
||||||
|
// The door is bound only while a pairing of this kind is served here (or the
|
||||||
|
// person has a pairing window open on it, pair_window.go). It never dials,
|
||||||
|
// never forwards a byte anywhere (a connection it keeps is a lane of a pairing
|
||||||
|
// it already serves, and nothing else is ever read from it), and the only
|
||||||
|
// thing it answers before a Host has proved itself is the TLS handshake. The
|
||||||
|
// Host keeps a few idle connections open and opens another each time one is
|
||||||
|
// taken; when it goes away, its connections close and it opens new ones when
|
||||||
|
// it is back. This server never reconnects to it: it can't.
|
||||||
|
//
|
||||||
|
// The wire contract the Host implements is docs/host-connects.md.
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"crypto/tls"
|
||||||
|
"crypto/x509"
|
||||||
|
"errors"
|
||||||
|
"fmt"
|
||||||
|
"math/rand/v2"
|
||||||
|
"net"
|
||||||
|
"strings"
|
||||||
|
"sync"
|
||||||
|
"sync/atomic"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
const (
|
||||||
|
// doorDefaultAddr is where the door listens: every address of the
|
||||||
|
// machine, IPv4 and IPv6, port 8812 (beside the Host's own 8810/8811).
|
||||||
|
doorDefaultAddr = ":8812"
|
||||||
|
// The two protocols a Host can name in the handshake (ALPN): a lane
|
||||||
|
// connection of a pairing this server serves, or a pairing through an
|
||||||
|
// open window. The Host chooses; the door offers the second only while a
|
||||||
|
// window is open.
|
||||||
|
laneALPN = "privatae-lane/1"
|
||||||
|
pairALPN = "privatae-pair/1"
|
||||||
|
// A connection has this long to finish its TLS handshake.
|
||||||
|
doorHandshakeTimeout = 10 * time.Second
|
||||||
|
// At most this many handshakes are in progress at once, and this many
|
||||||
|
// from one address (an IPv6 address counts as its /64, which one machine
|
||||||
|
// is commonly given whole): a scan or a flood costs the door a bounded
|
||||||
|
// number of goroutines.
|
||||||
|
doorMaxHandshakes = 256
|
||||||
|
doorMaxHandshakesPerSource = 8
|
||||||
|
// Of those, this many are kept for addresses a Host proved itself from
|
||||||
|
// within doorKnownHostFor (doorRememberHost): a stranger is admitted only
|
||||||
|
// while fewer than doorMaxHandshakes-doorReservedHandshakes are in
|
||||||
|
// progress, so strangers from any number of addresses never hold the last
|
||||||
|
// slots, and the person's own Host reconnects at its first try while the
|
||||||
|
// port is flooded. The reserve holds every handshake of 8 such addresses
|
||||||
|
// at once; one Host connects from one.
|
||||||
|
doorReservedHandshakes = 64
|
||||||
|
// Random early drop for strangers, as OpenSSH's MaxStartups (default
|
||||||
|
// 10:30:100): with fewer than doorEarlyDropStart handshakes in progress a
|
||||||
|
// stranger is always admitted (a new Host pairing, Hosts redialling after
|
||||||
|
// this bastion restarted); from there a stranger is refused with a chance
|
||||||
|
// that starts at doorEarlyDropRate and rises in a line to certain at the
|
||||||
|
// strangers' limit. A flood then fills the strangers' share slowly and
|
||||||
|
// never the reserve.
|
||||||
|
doorEarlyDropStart = 64
|
||||||
|
doorEarlyDropRate = 0.3
|
||||||
|
// An address a Host proved itself from is remembered for this long after
|
||||||
|
// its last verified handshake, in memory only (never written anywhere,
|
||||||
|
// gone when the bastion stops), at most doorKnownHostsMax of them. A Host
|
||||||
|
// connected keeps it fresh; this covers one away for a week (a laptop
|
||||||
|
// shut over a holiday) whose home address did not change.
|
||||||
|
doorKnownHostFor = 7 * 24 * time.Hour
|
||||||
|
doorKnownHostsMax = 64
|
||||||
|
// A pairing holds at most this many idle connections; one more is closed.
|
||||||
|
// The Host keeps hostSpareConns idle (docs/host-connects.md), so this is
|
||||||
|
// far above anything a well-behaved Host opens.
|
||||||
|
doorMaxIdle = 32
|
||||||
|
// TCP keepalive on every connection the door keeps, under the 30 s a
|
||||||
|
// home router's NAT may forget an idle connection after.
|
||||||
|
doorKeepAlive = 25 * time.Second
|
||||||
|
// A refusal from one address is written to the audit once per this, and
|
||||||
|
// at most doorRefusalAuditSources addresses are written per period: a
|
||||||
|
// scan from many addresses must not fill the audit or this map either.
|
||||||
|
doorRefusalAuditEvery = 10 * time.Minute
|
||||||
|
doorRefusalAuditSources = 256
|
||||||
|
)
|
||||||
|
|
||||||
|
// doorTakeWait is how long a lane waits for its Host's next connection. A
|
||||||
|
// lane's own context can cut it shorter.
|
||||||
|
const doorTakeWait = egressDialTimeout
|
||||||
|
|
||||||
|
// hostOpenedConn is a connection a Host opened to the door, its TLS done. Idle
|
||||||
|
// in a pool, a watcher reads it, so a connection the Host or the network closed
|
||||||
|
// leaves the pool at once; a lane that takes one stops the watcher first.
|
||||||
|
type hostOpenedConn struct {
|
||||||
|
*tls.Conn
|
||||||
|
p *doorPairing
|
||||||
|
state atomic.Int32 // connIdle, connTaken, connDead
|
||||||
|
done chan struct{}
|
||||||
|
werr error // the watcher's read result, set before done closes
|
||||||
|
closed atomic.Bool
|
||||||
|
}
|
||||||
|
|
||||||
|
const (
|
||||||
|
connIdle int32 = iota
|
||||||
|
connTaken
|
||||||
|
connDead
|
||||||
|
)
|
||||||
|
|
||||||
|
// Close closes the connection and counts it gone, once. It audits nothing
|
||||||
|
// and calls nothing but the close: every Close in this program can reach it
|
||||||
|
// as far as the static checks can tell (claims_static_test.go), so the
|
||||||
|
// "disconnected" audit is written by the pairing's own loop (auditLoop).
|
||||||
|
func (c *hostOpenedConn) Close() error {
|
||||||
|
err := c.Conn.Close()
|
||||||
|
if c.closed.CompareAndSwap(false, true) {
|
||||||
|
c.p.connClosed()
|
||||||
|
}
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
|
||||||
|
// watch reads the idle connection. A Host sends nothing on a connection until
|
||||||
|
// a lane has spoken on it, so any read that returns is the end of it, unless
|
||||||
|
// the read was the take's own stop.
|
||||||
|
func (c *hostOpenedConn) watch() {
|
||||||
|
var b [1]byte
|
||||||
|
n, err := c.Conn.Read(b[:])
|
||||||
|
if n > 0 {
|
||||||
|
err = errors.New("the Host sent data on a connection no lane had used")
|
||||||
|
}
|
||||||
|
c.werr = err
|
||||||
|
close(c.done)
|
||||||
|
if c.state.CompareAndSwap(connIdle, connDead) {
|
||||||
|
_ = c.Close()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// claim takes an idle connection for a lane: the watcher stopped, its read
|
||||||
|
// deadline cleared. False when the connection is dead (and it is closed).
|
||||||
|
func (c *hostOpenedConn) claim() bool {
|
||||||
|
if !c.state.CompareAndSwap(connIdle, connTaken) {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
_ = c.Conn.SetReadDeadline(time.Unix(1, 0))
|
||||||
|
<-c.done
|
||||||
|
var ne net.Error
|
||||||
|
if c.werr != nil && !(errors.As(c.werr, &ne) && ne.Timeout()) {
|
||||||
|
_ = c.Close()
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
_ = c.Conn.SetReadDeadline(time.Time{})
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
|
||||||
|
// doorPairing is one pairing the door serves: its pinned CA, the operator
|
||||||
|
// certificate it presents, and its idle connections.
|
||||||
|
type doorPairing struct {
|
||||||
|
host string
|
||||||
|
roots *x509.CertPool
|
||||||
|
cert tls.Certificate
|
||||||
|
idle chan *hostOpenedConn
|
||||||
|
gone chan struct{} // the last connection closed (auditLoop)
|
||||||
|
live atomic.Int32 // connections open now, idle or taken
|
||||||
|
from atomic.Value // string: the address the last connection came from
|
||||||
|
|
||||||
|
// mu orders put against drain: once stopped, no connection is held.
|
||||||
|
mu sync.Mutex
|
||||||
|
stopped bool
|
||||||
|
}
|
||||||
|
|
||||||
|
func (p *doorPairing) connClosed() {
|
||||||
|
if p.live.Add(-1) == 0 {
|
||||||
|
select {
|
||||||
|
case p.gone <- struct{}{}:
|
||||||
|
default:
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// auditLoop writes "disconnected" each time the pairing's last connection
|
||||||
|
// closes, until quit. Off Close's path on purpose (hostOpenedConn.Close).
|
||||||
|
func (p *doorPairing) auditLoop(quit <-chan struct{}) {
|
||||||
|
for {
|
||||||
|
select {
|
||||||
|
case <-p.gone:
|
||||||
|
if p.live.Load() == 0 {
|
||||||
|
from, _ := p.from.Load().(string)
|
||||||
|
pairingAudit("host_disconnected", p.host, "its last connection to this server closed (from "+from+")")
|
||||||
|
}
|
||||||
|
case <-quit:
|
||||||
|
return
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// put holds a verified connection for the pairing's lanes.
|
||||||
|
func (p *doorPairing) put(tc *tls.Conn, src string) {
|
||||||
|
p.mu.Lock()
|
||||||
|
defer p.mu.Unlock()
|
||||||
|
if p.stopped {
|
||||||
|
// The pairing stopped while this connection was in its handshake.
|
||||||
|
_ = tc.Close()
|
||||||
|
return
|
||||||
|
}
|
||||||
|
c := &hostOpenedConn{Conn: tc, p: p, done: make(chan struct{})}
|
||||||
|
p.from.Store(src)
|
||||||
|
if p.live.Add(1) == 1 {
|
||||||
|
pairingAudit("host_connected", p.host, "connected to this server from "+src)
|
||||||
|
// Back from away: it hears from this server now, not on the minute.
|
||||||
|
defer kickBeats()
|
||||||
|
}
|
||||||
|
select {
|
||||||
|
case p.idle <- c:
|
||||||
|
go c.watch()
|
||||||
|
default:
|
||||||
|
// More idle connections than any Host keeps: this one is closed.
|
||||||
|
c.state.Store(connDead)
|
||||||
|
_ = c.Close()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// take is a lane's dial: the next idle connection the Host opened, waiting at
|
||||||
|
// most doorTakeWait for one.
|
||||||
|
func (p *doorPairing) take(ctx context.Context) (net.Conn, error) {
|
||||||
|
ctx, cancel := context.WithTimeout(ctx, doorTakeWait)
|
||||||
|
defer cancel()
|
||||||
|
for {
|
||||||
|
select {
|
||||||
|
case c := <-p.idle:
|
||||||
|
if c.claim() {
|
||||||
|
return c, nil
|
||||||
|
}
|
||||||
|
case <-ctx.Done():
|
||||||
|
return nil, fmt.Errorf("%s has not connected to this server within %s (your Host connects to this server; "+
|
||||||
|
"it does when it is running and can reach it)", p.host, doorTakeWait)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// drain closes every idle connection: the pairing stopped.
|
||||||
|
func (p *doorPairing) drain() {
|
||||||
|
p.mu.Lock()
|
||||||
|
p.stopped = true
|
||||||
|
p.mu.Unlock()
|
||||||
|
for {
|
||||||
|
select {
|
||||||
|
case c := <-p.idle:
|
||||||
|
if c.state.CompareAndSwap(connIdle, connDead) {
|
||||||
|
_ = c.Close()
|
||||||
|
}
|
||||||
|
default:
|
||||||
|
return
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// hostDoor is one listening door.
|
||||||
|
type hostDoor struct {
|
||||||
|
addr string
|
||||||
|
// lanes: this door serves pairings' lanes (the running bastion's door).
|
||||||
|
// A pairing window opened with no bastion holding the port is served by
|
||||||
|
// a door of its own that serves the window alone.
|
||||||
|
lanes bool
|
||||||
|
|
||||||
|
mu sync.Mutex
|
||||||
|
ln net.Listener
|
||||||
|
pairings map[string]*doorPairing
|
||||||
|
refs int
|
||||||
|
inflight int
|
||||||
|
perSource map[string]int
|
||||||
|
refused map[string]time.Time
|
||||||
|
win windowState
|
||||||
|
closed bool
|
||||||
|
// draw is the early drop's random number in [0, 1) (doorDraw).
|
||||||
|
draw func() float64
|
||||||
|
}
|
||||||
|
|
||||||
|
// doorDraw is where a new door's early drop draws from. A variable so a test
|
||||||
|
// can fix it; nothing else assigns it.
|
||||||
|
var doorDraw = rand.Float64
|
||||||
|
|
||||||
|
func newHostDoor(addr string, lanes bool) *hostDoor {
|
||||||
|
return &hostDoor{addr: addr, lanes: lanes, pairings: map[string]*doorPairing{},
|
||||||
|
perSource: map[string]int{}, refused: map[string]time.Time{}, draw: doorDraw}
|
||||||
|
}
|
||||||
|
|
||||||
|
// listenDoor binds addr with keepalive on every accepted connection.
|
||||||
|
func listenDoor(addr string) (net.Listener, error) {
|
||||||
|
lc := net.ListenConfig{KeepAlive: doorKeepAlive}
|
||||||
|
return lc.Listen(context.Background(), "tcp", addr)
|
||||||
|
}
|
||||||
|
|
||||||
|
// serve accepts until the listener closes.
|
||||||
|
func (d *hostDoor) serve(ln net.Listener) {
|
||||||
|
for {
|
||||||
|
raw, err := ln.Accept()
|
||||||
|
if err != nil {
|
||||||
|
if errors.Is(err, net.ErrClosed) {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
time.Sleep(50 * time.Millisecond)
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
src := remoteHost(raw.RemoteAddr())
|
||||||
|
if !d.admitHandshake(sourceKey(src)) {
|
||||||
|
_ = raw.Close()
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
go d.handle(raw, src)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func remoteHost(a net.Addr) string {
|
||||||
|
if a == nil {
|
||||||
|
return ""
|
||||||
|
}
|
||||||
|
h, _, err := net.SplitHostPort(a.String())
|
||||||
|
if err != nil {
|
||||||
|
return a.String()
|
||||||
|
}
|
||||||
|
return h
|
||||||
|
}
|
||||||
|
|
||||||
|
// sourceKey is the address the per-source limits count: an IPv4 address as
|
||||||
|
// it is, an IPv6 address as its /64.
|
||||||
|
func sourceKey(h string) string {
|
||||||
|
ip := net.ParseIP(h)
|
||||||
|
if ip == nil || ip.To4() != nil {
|
||||||
|
return h
|
||||||
|
}
|
||||||
|
return (&net.IPNet{IP: ip.Mask(net.CIDRMask(64, 128)), Mask: net.CIDRMask(64, 128)}).String()
|
||||||
|
}
|
||||||
|
|
||||||
|
// admitHandshake takes a handshake slot for src (a sourceKey), or refuses:
|
||||||
|
// the global and per-source limits for everyone, and for a source no Host
|
||||||
|
// proved itself from lately, the strangers' share and its early drop.
|
||||||
|
func (d *hostDoor) admitHandshake(src string) bool {
|
||||||
|
known := doorKnownHost(src, time.Now())
|
||||||
|
d.mu.Lock()
|
||||||
|
defer d.mu.Unlock()
|
||||||
|
if d.inflight >= doorMaxHandshakes || d.perSource[src] >= doorMaxHandshakesPerSource {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
if !known && !d.admitStranger(d.inflight) {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
d.inflight++
|
||||||
|
d.perSource[src]++
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
|
||||||
|
// admitStranger is the early drop for a stranger's handshake with n in
|
||||||
|
// progress. Called with d.mu held.
|
||||||
|
func (d *hostDoor) admitStranger(n int) bool {
|
||||||
|
full := doorMaxHandshakes - doorReservedHandshakes
|
||||||
|
switch {
|
||||||
|
case n < doorEarlyDropStart:
|
||||||
|
return true
|
||||||
|
case n >= full:
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
drop := doorEarlyDropRate + (1-doorEarlyDropRate)*float64(n-doorEarlyDropStart)/float64(full-doorEarlyDropStart)
|
||||||
|
return d.draw() >= drop
|
||||||
|
}
|
||||||
|
|
||||||
|
// doorKnown is the addresses (sourceKeys) a Host proved itself from, each
|
||||||
|
// with when it is forgotten. In memory only: an address is never written to
|
||||||
|
// disk, and a bastion that restarts knows none until its Hosts connect again.
|
||||||
|
var doorKnown struct {
|
||||||
|
sync.Mutex
|
||||||
|
until map[string]time.Time
|
||||||
|
}
|
||||||
|
|
||||||
|
// doorRememberHost notes that a Host proved itself from src (a sourceKey):
|
||||||
|
// its certificate verified under a pairing's pinned CA, or it paired through
|
||||||
|
// the window with the code.
|
||||||
|
func doorRememberHost(src string, now time.Time) {
|
||||||
|
doorKnown.Lock()
|
||||||
|
defer doorKnown.Unlock()
|
||||||
|
if doorKnown.until == nil {
|
||||||
|
doorKnown.until = map[string]time.Time{}
|
||||||
|
}
|
||||||
|
if _, ok := doorKnown.until[src]; !ok && len(doorKnown.until) >= doorKnownHostsMax {
|
||||||
|
oldest := ""
|
||||||
|
for k, t := range doorKnown.until {
|
||||||
|
if !now.Before(t) {
|
||||||
|
delete(doorKnown.until, k)
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
if oldest == "" || t.Before(doorKnown.until[oldest]) {
|
||||||
|
oldest = k
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if len(doorKnown.until) >= doorKnownHostsMax {
|
||||||
|
delete(doorKnown.until, oldest)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
doorKnown.until[src] = now.Add(doorKnownHostFor)
|
||||||
|
}
|
||||||
|
|
||||||
|
// doorKnownHost is whether a Host proved itself from src within
|
||||||
|
// doorKnownHostFor.
|
||||||
|
func doorKnownHost(src string, now time.Time) bool {
|
||||||
|
doorKnown.Lock()
|
||||||
|
defer doorKnown.Unlock()
|
||||||
|
t, ok := doorKnown.until[src]
|
||||||
|
if ok && !now.Before(t) {
|
||||||
|
delete(doorKnown.until, src)
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
return ok
|
||||||
|
}
|
||||||
|
|
||||||
|
func (d *hostDoor) handshakeDone(src string) {
|
||||||
|
d.mu.Lock()
|
||||||
|
defer d.mu.Unlock()
|
||||||
|
d.inflight--
|
||||||
|
if d.perSource[src]--; d.perSource[src] <= 0 {
|
||||||
|
delete(d.perSource, src)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// match is the pairing whose pinned CA the Host's certificate verifies under,
|
||||||
|
// for host.cseries.internal: exactly one, or a refusal.
|
||||||
|
func (d *hostDoor) match(chain []*x509.Certificate) (*doorPairing, error) {
|
||||||
|
if len(chain) == 0 {
|
||||||
|
return nil, errors.New("the connection presented no certificate")
|
||||||
|
}
|
||||||
|
inter := x509.NewCertPool()
|
||||||
|
for _, c := range chain[1:] {
|
||||||
|
inter.AddCert(c)
|
||||||
|
}
|
||||||
|
d.mu.Lock()
|
||||||
|
defer d.mu.Unlock()
|
||||||
|
var hit *doorPairing
|
||||||
|
for _, p := range d.pairings {
|
||||||
|
if _, err := chain[0].Verify(x509.VerifyOptions{Roots: p.roots, Intermediates: inter, DNSName: tcpServerName}); err != nil {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
if hit != nil {
|
||||||
|
return nil, errors.New("the certificate verifies for more than one pairing here — refusing")
|
||||||
|
}
|
||||||
|
hit = p
|
||||||
|
}
|
||||||
|
if hit == nil {
|
||||||
|
return nil, errors.New("the certificate is not that of a Host this server serves")
|
||||||
|
}
|
||||||
|
return hit, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// handle does the TLS handshake as the client and keeps the connection only
|
||||||
|
// for what the Host proved: a lane of the one pairing its certificate names,
|
||||||
|
// or a pairing through the open window.
|
||||||
|
func (d *hostDoor) handle(raw net.Conn, src string) {
|
||||||
|
released := false
|
||||||
|
release := func() {
|
||||||
|
if !released {
|
||||||
|
released = true
|
||||||
|
d.handshakeDone(sourceKey(src))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
defer release()
|
||||||
|
_ = raw.SetDeadline(time.Now().Add(doorHandshakeTimeout))
|
||||||
|
win := d.openWindow()
|
||||||
|
var protos []string
|
||||||
|
if d.lanes {
|
||||||
|
protos = append(protos, laneALPN)
|
||||||
|
}
|
||||||
|
if win != nil {
|
||||||
|
protos = append(protos, pairALPN)
|
||||||
|
}
|
||||||
|
if len(protos) == 0 {
|
||||||
|
_ = raw.Close()
|
||||||
|
return
|
||||||
|
}
|
||||||
|
var matched *doorPairing
|
||||||
|
var pairCA *x509.Certificate
|
||||||
|
cfg := &tls.Config{
|
||||||
|
ServerName: tcpServerName, MinVersion: tls.VersionTLS13, NextProtos: protos,
|
||||||
|
// The chain is checked in VerifyConnection against the pinned CAs
|
||||||
|
// alone (or, for a pairing, against the CA it carries, which the code
|
||||||
|
// then vouches for): the system roots play no part.
|
||||||
|
InsecureSkipVerify: true,
|
||||||
|
VerifyConnection: func(cs tls.ConnectionState) error {
|
||||||
|
var err error
|
||||||
|
switch {
|
||||||
|
case cs.NegotiatedProtocol == laneALPN && d.lanes:
|
||||||
|
matched, err = d.match(cs.PeerCertificates)
|
||||||
|
case cs.NegotiatedProtocol == pairALPN && win != nil:
|
||||||
|
pairCA, err = chainCA(cs.PeerCertificates)
|
||||||
|
default:
|
||||||
|
err = fmt.Errorf("the connection named no protocol this server speaks (%q)", cs.NegotiatedProtocol)
|
||||||
|
}
|
||||||
|
return err
|
||||||
|
},
|
||||||
|
GetClientCertificate: func(*tls.CertificateRequestInfo) (*tls.Certificate, error) {
|
||||||
|
if matched != nil {
|
||||||
|
return &matched.cert, nil
|
||||||
|
}
|
||||||
|
// A pairing: this bastion holds no certificate from the Host yet.
|
||||||
|
return &tls.Certificate{}, nil
|
||||||
|
},
|
||||||
|
}
|
||||||
|
tc := tls.Client(raw, cfg)
|
||||||
|
if err := tc.Handshake(); err != nil {
|
||||||
|
d.refuse(src, err)
|
||||||
|
_ = raw.Close()
|
||||||
|
return
|
||||||
|
}
|
||||||
|
release()
|
||||||
|
switch tc.ConnectionState().NegotiatedProtocol {
|
||||||
|
case laneALPN:
|
||||||
|
_ = raw.SetDeadline(time.Time{})
|
||||||
|
d.mu.Lock()
|
||||||
|
live := !d.closed && d.pairings[matched.host] == matched
|
||||||
|
d.mu.Unlock()
|
||||||
|
if !live {
|
||||||
|
_ = tc.Close()
|
||||||
|
return
|
||||||
|
}
|
||||||
|
doorRememberHost(sourceKey(src), time.Now())
|
||||||
|
matched.put(tc, src)
|
||||||
|
case pairALPN:
|
||||||
|
d.serveWindow(tc, win, pairCA, src)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// refuse audits a refused connection, once per address per
|
||||||
|
// doorRefusalAuditEvery: a scan of the port must not fill the audit.
|
||||||
|
func (d *hostDoor) refuse(src string, err error) {
|
||||||
|
key := sourceKey(src)
|
||||||
|
d.mu.Lock()
|
||||||
|
last, seen := d.refused[key]
|
||||||
|
now := time.Now()
|
||||||
|
if seen && now.Sub(last) < doorRefusalAuditEvery {
|
||||||
|
d.mu.Unlock()
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if len(d.refused) >= doorRefusalAuditSources {
|
||||||
|
for k, t := range d.refused {
|
||||||
|
if now.Sub(t) >= doorRefusalAuditEvery {
|
||||||
|
delete(d.refused, k)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if len(d.refused) >= doorRefusalAuditSources {
|
||||||
|
// This period's share of the audit is spent.
|
||||||
|
d.mu.Unlock()
|
||||||
|
return
|
||||||
|
}
|
||||||
|
}
|
||||||
|
d.refused[key] = now
|
||||||
|
d.mu.Unlock()
|
||||||
|
pairingAudit("door_refused", src, "refused: "+err.Error())
|
||||||
|
}
|
||||||
|
|
||||||
|
// chainCA is the CA a pairing Host's chain carries, checked to sign its leaf
|
||||||
|
// for host.cseries.internal. The code proves the Host holds it
|
||||||
|
// (pair_window.go); nothing else does.
|
||||||
|
func chainCA(chain []*x509.Certificate) (*x509.Certificate, error) {
|
||||||
|
if len(chain) < 2 {
|
||||||
|
return nil, errors.New("the Host presented no certificate authority with its certificate")
|
||||||
|
}
|
||||||
|
for _, c := range chain[1:] {
|
||||||
|
if !c.IsCA {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
roots := x509.NewCertPool()
|
||||||
|
roots.AddCert(c)
|
||||||
|
if _, err := chain[0].Verify(x509.VerifyOptions{Roots: roots, DNSName: tcpServerName}); err == nil {
|
||||||
|
return c, nil
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return nil, errors.New("the Host's certificate is not signed by a certificate authority it presented, for " + tcpServerName)
|
||||||
|
}
|
||||||
|
|
||||||
|
// ── the running bastion's doors ─────────────────────────────────────────────
|
||||||
|
|
||||||
|
var doors struct {
|
||||||
|
sync.Mutex
|
||||||
|
m map[string]*hostDoor
|
||||||
|
}
|
||||||
|
|
||||||
|
// doorBindRetry is how often a door that could not bind tries again (the
|
||||||
|
// port is held by a pairing window's own door until that window closes).
|
||||||
|
var doorBindRetry = 2 * time.Second
|
||||||
|
|
||||||
|
// newDoorPairing is cfg as the door serves it: its pinned CA, its operator
|
||||||
|
// certificate, an empty pool.
|
||||||
|
func newDoorPairing(cfg *Config) (*doorPairing, error) {
|
||||||
|
cert, err := tls.X509KeyPair([]byte(cfg.OperatorCert), []byte(cfg.OperatorKey))
|
||||||
|
if err != nil {
|
||||||
|
return nil, fmt.Errorf("operator cert/key: %w", err)
|
||||||
|
}
|
||||||
|
roots := x509.NewCertPool()
|
||||||
|
if !roots.AppendCertsFromPEM([]byte(cfg.CACert)) {
|
||||||
|
return nil, errors.New("bad CA cert in config")
|
||||||
|
}
|
||||||
|
return &doorPairing{host: cfg.HostName, roots: roots, cert: cert, idle: make(chan *hostOpenedConn, doorMaxIdle),
|
||||||
|
gone: make(chan struct{}, 1)}, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// doorOpen registers an active host-dials pairing with the door on its
|
||||||
|
// address, binding the door if this is its first pairing. The returned
|
||||||
|
// release unregisters it and closes the door after its last pairing.
|
||||||
|
func doorOpen(cfg *Config) (func(), error) {
|
||||||
|
p, err := newDoorPairing(cfg)
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
addr := cfg.doorAddr()
|
||||||
|
quit := make(chan struct{})
|
||||||
|
go p.auditLoop(quit)
|
||||||
|
doors.Lock()
|
||||||
|
if doors.m == nil {
|
||||||
|
doors.m = map[string]*hostDoor{}
|
||||||
|
}
|
||||||
|
d := doors.m[addr]
|
||||||
|
first := d == nil
|
||||||
|
if first {
|
||||||
|
d = newHostDoor(addr, true)
|
||||||
|
doors.m[addr] = d
|
||||||
|
}
|
||||||
|
d.mu.Lock()
|
||||||
|
if _, dup := d.pairings[cfg.HostName]; dup {
|
||||||
|
d.mu.Unlock()
|
||||||
|
doors.Unlock()
|
||||||
|
close(quit)
|
||||||
|
return nil, fmt.Errorf("%s is already served on %s", cfg.HostName, addr)
|
||||||
|
}
|
||||||
|
d.pairings[cfg.HostName] = p
|
||||||
|
d.refs++
|
||||||
|
d.mu.Unlock()
|
||||||
|
doors.Unlock()
|
||||||
|
if first {
|
||||||
|
go d.bindLoop()
|
||||||
|
}
|
||||||
|
return func() {
|
||||||
|
defer close(quit)
|
||||||
|
doors.Lock()
|
||||||
|
d.mu.Lock()
|
||||||
|
if d.pairings[cfg.HostName] == p {
|
||||||
|
delete(d.pairings, cfg.HostName)
|
||||||
|
}
|
||||||
|
d.refs--
|
||||||
|
last := d.refs == 0
|
||||||
|
if last {
|
||||||
|
d.closed = true
|
||||||
|
delete(doors.m, addr)
|
||||||
|
}
|
||||||
|
ln := d.ln
|
||||||
|
d.mu.Unlock()
|
||||||
|
doors.Unlock()
|
||||||
|
p.drain()
|
||||||
|
if last && ln != nil {
|
||||||
|
_ = ln.Close()
|
||||||
|
}
|
||||||
|
if last {
|
||||||
|
// The rule stays while a pairing on this port is still active
|
||||||
|
// (the bastion stopping is not the pairing going) or a window
|
||||||
|
// is open on it; otherwise it goes now.
|
||||||
|
doorFirewallRelease(addr)
|
||||||
|
}
|
||||||
|
}, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// bindLoop binds the door and serves it, trying again while the port is held
|
||||||
|
// and the door still has a pairing.
|
||||||
|
func (d *hostDoor) bindLoop() {
|
||||||
|
logged := false
|
||||||
|
for {
|
||||||
|
d.mu.Lock()
|
||||||
|
if d.closed {
|
||||||
|
d.mu.Unlock()
|
||||||
|
return
|
||||||
|
}
|
||||||
|
d.mu.Unlock()
|
||||||
|
ln, err := listenDoor(d.addr)
|
||||||
|
if err == nil {
|
||||||
|
d.mu.Lock()
|
||||||
|
if d.closed {
|
||||||
|
d.mu.Unlock()
|
||||||
|
_ = ln.Close()
|
||||||
|
return
|
||||||
|
}
|
||||||
|
d.ln = ln
|
||||||
|
d.mu.Unlock()
|
||||||
|
fmt.Printf("door: your Host connects to this server on %s (TCP)\n", d.addr)
|
||||||
|
// The way in through this machine's own firewall, while the door
|
||||||
|
// is in use (doorfw.go); removed when its last pairing goes. Beside
|
||||||
|
// serving, never before it: a firewall command that hangs (each
|
||||||
|
// may take doorFWExecWait) never holds the door shut.
|
||||||
|
go func() {
|
||||||
|
still := func() bool { d.mu.Lock(); defer d.mu.Unlock(); return !d.closed }
|
||||||
|
if said := doorFirewallEnsureWhile(d.addr, still); said != "" {
|
||||||
|
fmt.Println("door: " + said)
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
d.serve(ln)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if !logged {
|
||||||
|
fmt.Printf("door: cannot listen on %s yet (%v); trying again every %s\n", d.addr, err, doorBindRetry)
|
||||||
|
logged = true
|
||||||
|
}
|
||||||
|
time.Sleep(doorBindRetry)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// hostDoorDial is a host-dials pairing's lane dial: the next connection its
|
||||||
|
// Host opened to the door.
|
||||||
|
func hostDoorDial(cfg *Config) func(ctx context.Context) (net.Conn, error) {
|
||||||
|
addr, host := cfg.doorAddr(), cfg.HostName
|
||||||
|
return func(ctx context.Context) (net.Conn, error) {
|
||||||
|
doors.Lock()
|
||||||
|
d := doors.m[addr]
|
||||||
|
doors.Unlock()
|
||||||
|
if d == nil {
|
||||||
|
return nil, fmt.Errorf("no door is open on %s for %s", addr, host)
|
||||||
|
}
|
||||||
|
d.mu.Lock()
|
||||||
|
p := d.pairings[host]
|
||||||
|
d.mu.Unlock()
|
||||||
|
if p == nil {
|
||||||
|
return nil, fmt.Errorf("%s is not served on %s", host, addr)
|
||||||
|
}
|
||||||
|
return p.take(ctx)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// hostDialsLaneDialer is localLaneDialer for a pairing whose Host connects
|
||||||
|
// to this server. The TLS configuration is the one the door uses, kept for
|
||||||
|
// the lanes' own use; every connection the dial returns has it done.
|
||||||
|
func hostDialsLaneDialer(cfg *Config) (func(ctx context.Context) (net.Conn, error), *tls.Config, error) {
|
||||||
|
if cfg.Bearer == "" {
|
||||||
|
return nil, nil, errors.New("this pairing holds no bearer, and its lane never opens without one")
|
||||||
|
}
|
||||||
|
cert, err := tls.X509KeyPair([]byte(cfg.OperatorCert), []byte(cfg.OperatorKey))
|
||||||
|
if err != nil {
|
||||||
|
return nil, nil, fmt.Errorf("operator cert/key: %w", err)
|
||||||
|
}
|
||||||
|
tc, err := hostCATLS(cfg.CACert, &cert)
|
||||||
|
if err != nil {
|
||||||
|
return nil, nil, fmt.Errorf("bad CA cert in config: %w", err)
|
||||||
|
}
|
||||||
|
return hostDoorDial(cfg), tc, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// doorAddr is where this pairing's Host connects: the address it was paired
|
||||||
|
// on, or the default.
|
||||||
|
func (c *Config) doorAddr() string {
|
||||||
|
if strings.TrimSpace(c.DoorAddr) != "" {
|
||||||
|
return c.DoorAddr
|
||||||
|
}
|
||||||
|
return doorDefaultAddr
|
||||||
|
}
|
||||||
|
|
||||||
|
// doorPort is the door's port, for the person's words.
|
||||||
|
func doorPort(addr string) string {
|
||||||
|
if _, p, err := net.SplitHostPort(addr); err == nil {
|
||||||
|
return p
|
||||||
|
}
|
||||||
|
return addr
|
||||||
|
}
|
||||||
@@ -0,0 +1,309 @@
|
|||||||
|
//go:build linux
|
||||||
|
|
||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"crypto/ed25519"
|
||||||
|
"encoding/base64"
|
||||||
|
"net"
|
||||||
|
"os"
|
||||||
|
"strings"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
// windowBox is a pairing box whose `pair --open` runs with machine authority
|
||||||
|
// (held) and no organisation's policy, in the given mode.
|
||||||
|
func windowBox(t *testing.T, networked, held bool) {
|
||||||
|
t.Helper()
|
||||||
|
pairingBox(t)
|
||||||
|
prev := machineAuthorityHeld
|
||||||
|
machineAuthorityHeld = func() bool { return true }
|
||||||
|
t.Cleanup(func() { machineAuthorityHeld = prev })
|
||||||
|
withPolicy(t, nil)
|
||||||
|
if networked {
|
||||||
|
if err := setBoxMode(modeNetworked); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
machineAuthorityHeld = func() bool { return held }
|
||||||
|
}
|
||||||
|
|
||||||
|
// pairThroughWindow opens a window on a free port, pairs h's Host through it,
|
||||||
|
// and waits for `pair --open` to finish. h is made for that port.
|
||||||
|
func pairThroughWindow(t *testing.T, ca *testCA, handle, name string) (windowDoneReq, string) {
|
||||||
|
t.Helper()
|
||||||
|
addr := freeDoorAddr(t)
|
||||||
|
code, out, res := openWindowFor(t, addr)
|
||||||
|
h := newStandinHost(t, ca, handle, name, addr)
|
||||||
|
done, err := h.pair(formatWindowCode(code))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("pair: %v\n%s", err, pairingAuditText(t))
|
||||||
|
}
|
||||||
|
select {
|
||||||
|
case err := <-res:
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("pair --open: %v\n%s", err, out.String())
|
||||||
|
}
|
||||||
|
case <-time.After(15 * time.Second):
|
||||||
|
t.Fatal("pair --open never ended")
|
||||||
|
}
|
||||||
|
return done, out.String()
|
||||||
|
}
|
||||||
|
|
||||||
|
// 1. A server paired through `pair --open`, by someone with machine
|
||||||
|
// authority, on a machine nobody is in charge of, has that Host in charge:
|
||||||
|
// the anchor, the existing mechanism. A local machine is made networked for
|
||||||
|
// it (an anchor is a networked machine's). The rules before it still win: a
|
||||||
|
// Host on this machine, an organisation's policy naming another Host. Nobody
|
||||||
|
// without machine authority puts anyone in charge, and a local machine that
|
||||||
|
// already serves a Host the person said yes to keeps serving it.
|
||||||
|
//
|
||||||
|
// MUTATION: windowCommit calls anchorAfterPair instead of anchorAfterWindow.
|
||||||
|
// RESULT: red (local, and networked beside another pairing: no anchor).
|
||||||
|
// MUTATION: drop the sameMachineHost check in anchorAfterWindow. RESULT: red.
|
||||||
|
// MUTATION: drop the local-mode active check. RESULT: red.
|
||||||
|
// MUTATION: anchorAfterWindow ignores openerAuthority. RESULT: red.
|
||||||
|
func TestAServerPairedThroughTheWindowHasThatHostInCharge(t *testing.T) {
|
||||||
|
const name = "home201721e4.cseries.localhost"
|
||||||
|
t.Run("local machine, nobody in charge: networked, anchored, active", func(t *testing.T) {
|
||||||
|
windowBox(t, false, true)
|
||||||
|
done, out := pairThroughWindow(t, newTestCA(t, "home CA"), "home", name)
|
||||||
|
if done.State != pairingActive {
|
||||||
|
t.Fatalf("done: %+v", done)
|
||||||
|
}
|
||||||
|
if a := currentAnchor(); a == nil || a.AnchorHost != name {
|
||||||
|
t.Fatalf("anchor = %+v, want %s", a, name)
|
||||||
|
}
|
||||||
|
if boxMode() != modeNetworked {
|
||||||
|
t.Fatalf("mode %s: a machine with an anchor is networked", boxMode())
|
||||||
|
}
|
||||||
|
if !strings.Contains(out, name+" is now the Host in charge of this machine") || !strings.Contains(out, "pair --open") {
|
||||||
|
t.Fatalf("the person is not told who is in charge:\n%s", out)
|
||||||
|
}
|
||||||
|
if a := pairingAuditText(t); !strings.Contains(a, `"op":"anchor_take"`) {
|
||||||
|
t.Fatalf("no anchor_take in the audit:\n%s", a)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
t.Run("networked, unanchored, another pairing already there: anchored, the other waits", func(t *testing.T) {
|
||||||
|
windowBox(t, true, true)
|
||||||
|
writePairing(t, tRemote)
|
||||||
|
_, _ = pairThroughWindow(t, newTestCA(t, "home CA"), "home", name)
|
||||||
|
if a := currentAnchor(); a == nil || a.AnchorHost != name {
|
||||||
|
t.Fatalf("anchor = %+v, want %s", a, name)
|
||||||
|
}
|
||||||
|
if got := loadState(t, name); got != pairingActive {
|
||||||
|
t.Fatalf("the anchor never waits on itself: %q", got)
|
||||||
|
}
|
||||||
|
if got := loadState(t, tRemote); got != pairingPending {
|
||||||
|
t.Fatalf("the other Host is %q, want pending (waiting for %s)", got, name)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
t.Run("a Host on this machine is paired: it stays the one in charge", func(t *testing.T) {
|
||||||
|
windowBox(t, true, true)
|
||||||
|
writeTCPPairing(t, tLocal2, "127.0.0.1:8811", pairingPending)
|
||||||
|
_, _ = pairThroughWindow(t, newTestCA(t, "home CA"), "home", name)
|
||||||
|
if a := currentAnchor(); a != nil {
|
||||||
|
t.Fatalf("a Host on this machine lost the machine to the window's Host: anchor %+v", a)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
t.Run("an organisation's policy names another Host: it waits for that one", func(t *testing.T) {
|
||||||
|
windowBox(t, true, true)
|
||||||
|
withPolicy(t, &anchorPolicy{Host: "corp.host.privatae.ai", Source: "test policy"})
|
||||||
|
done, _ := pairThroughWindow(t, newTestCA(t, "home CA"), "home", name)
|
||||||
|
if a := currentAnchor(); a != nil {
|
||||||
|
t.Fatalf("anchor %+v against the policy", a)
|
||||||
|
}
|
||||||
|
if done.State != pairingPending || done.AdmittedBy != "corp.host.privatae.ai" {
|
||||||
|
t.Fatalf("done: %+v, want pending for the Host the policy names", done)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
t.Run("an organisation's policy names this Host: in charge, on a local machine too", func(t *testing.T) {
|
||||||
|
windowBox(t, false, true)
|
||||||
|
withPolicy(t, &anchorPolicy{Host: name, Source: "test policy"})
|
||||||
|
writeTCPPairing(t, tLocal2, "127.0.0.1:8811", pairingRevoked)
|
||||||
|
_, _ = pairThroughWindow(t, newTestCA(t, "home CA"), "home", name)
|
||||||
|
if a := currentAnchor(); a == nil || a.AnchorHost != name {
|
||||||
|
t.Fatalf("anchor = %+v, want %s (the policy names it)", a, name)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
t.Run("no machine authority: nobody is put in charge, the mode is left", func(t *testing.T) {
|
||||||
|
windowBox(t, false, false)
|
||||||
|
_, _ = pairThroughWindow(t, newTestCA(t, "home CA"), "home", name)
|
||||||
|
if a := currentAnchor(); a != nil || boxMode() != modeLocal {
|
||||||
|
t.Fatalf("without authority: anchor %+v, mode %s", a, boxMode())
|
||||||
|
}
|
||||||
|
})
|
||||||
|
t.Run("opened without machine authority, committed by a door that has it: nobody in charge", func(t *testing.T) {
|
||||||
|
windowBox(t, false, true)
|
||||||
|
cfg := Config{HostName: name, State: ""}
|
||||||
|
if took, err := anchorAfterWindow(&cfg, []*Config{&cfg}, false); took.Taken || err != nil || currentAnchor() != nil {
|
||||||
|
t.Fatalf("a window opened without authority put %s in charge: %+v %v", name, took, err)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
t.Run("a local machine already serving another Host: it keeps serving it", func(t *testing.T) {
|
||||||
|
windowBox(t, false, true)
|
||||||
|
writePairing(t, tRemote)
|
||||||
|
_, _ = pairThroughWindow(t, newTestCA(t, "home CA"), "home", name)
|
||||||
|
if a := currentAnchor(); a != nil || boxMode() != modeLocal {
|
||||||
|
t.Fatalf("anchor %+v, mode %s: the Host already served here would wait", a, boxMode())
|
||||||
|
}
|
||||||
|
if got := loadState(t, tRemote); got == pairingPending {
|
||||||
|
t.Fatal("the Host already served here was left waiting")
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
// 2. The same Host pairing the same server again, through a fresh window,
|
||||||
|
// replaces its pairing: no `unpair` first. The same CA is the same Host,
|
||||||
|
// whatever handle it gives (a C-Series Host's handle is "home" while its name
|
||||||
|
// carries an id). Its state, the anchor and its grants are kept, and the old
|
||||||
|
// credentials are gone.
|
||||||
|
//
|
||||||
|
// MUTATION: drop the doorPairingWithCA lookup in windowCommit. RESULT: red,
|
||||||
|
// "this Host is already paired with this server as ...".
|
||||||
|
func TestTheSameHostPairingAgainReplacesItsPairing(t *testing.T) {
|
||||||
|
const name = "home201721e4.cseries.localhost"
|
||||||
|
windowBox(t, true, true)
|
||||||
|
ca := newTestCA(t, "home CA")
|
||||||
|
_, _ = pairThroughWindow(t, ca, "home", name)
|
||||||
|
if a := currentAnchor(); a == nil || a.AnchorHost != name {
|
||||||
|
t.Fatalf("first pairing: anchor %+v", a)
|
||||||
|
}
|
||||||
|
before, _ := pairingNamed(t, name)
|
||||||
|
gp, err := pairingGrantPath(name)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if err := os.WriteFile(gp, []byte(`{"kept":true}`), 0o600); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
done, out := pairThroughWindow(t, ca, "home", name)
|
||||||
|
if done.State != pairingActive || done.HostName != name {
|
||||||
|
t.Fatalf("pairing again: %+v\n%s", done, out)
|
||||||
|
}
|
||||||
|
after, all := pairingNamed(t, name)
|
||||||
|
if len(all) != 1 {
|
||||||
|
t.Fatalf("%d pairings after pairing again, want the one", len(all))
|
||||||
|
}
|
||||||
|
if after.OperatorCert == before.OperatorCert || after.OperatorKey == before.OperatorKey || after.WGPrivateKey == before.WGPrivateKey {
|
||||||
|
t.Fatal("the old credentials were kept")
|
||||||
|
}
|
||||||
|
if after.ListenAddr != before.ListenAddr || after.FirstSeen != before.FirstSeen || after.State != before.State {
|
||||||
|
t.Fatalf("the pairing was not kept in place: %+v -> %+v", before, after)
|
||||||
|
}
|
||||||
|
if a := currentAnchor(); a == nil || a.AnchorHost != name {
|
||||||
|
t.Fatalf("the anchor was not kept: %+v", a)
|
||||||
|
}
|
||||||
|
if b, err := os.ReadFile(gp); err != nil || string(b) != `{"kept":true}` {
|
||||||
|
t.Fatalf("the grant was not kept: %q %v", b, err)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Another Host (another CA) with the same handle is never this one.
|
||||||
|
done, err = func() (windowDoneReq, error) {
|
||||||
|
addr := freeDoorAddr(t)
|
||||||
|
code, _, res := openWindowFor(t, addr)
|
||||||
|
h := newStandinHost(t, newTestCA(t, "another CA"), "home", name, addr)
|
||||||
|
d, err := h.pair(formatWindowCode(code))
|
||||||
|
<-res
|
||||||
|
return d, err
|
||||||
|
}()
|
||||||
|
if err != nil || done.State != "refused" || !strings.Contains(done.Error, "different Host") {
|
||||||
|
t.Fatalf("another Host of the same name: %+v %v", done, err)
|
||||||
|
}
|
||||||
|
if c, _ := pairingNamed(t, name); c.Bearer != after.Bearer {
|
||||||
|
t.Fatal("another Host's pairing replaced this one's")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The same Host paired again under a new name (same CA) stays in charge under
|
||||||
|
// that name: the anchor follows it, its pinned key kept.
|
||||||
|
//
|
||||||
|
// MUTATION: drop carryAnchorToNewName from windowCommit. RESULT: red.
|
||||||
|
func TestTheAnchorFollowsItsHostToANewName(t *testing.T) {
|
||||||
|
windowBox(t, true, true)
|
||||||
|
ca := newTestCA(t, "home CA")
|
||||||
|
_, _ = pairThroughWindow(t, ca, "home", "home1.cseries.localhost")
|
||||||
|
pub, _, _ := ed25519.GenerateKey(nil)
|
||||||
|
if err := pinAnchorVerifyKey(base64.StdEncoding.EncodeToString(pub)); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
f, _ := loadAnchorFile()
|
||||||
|
pin := f.VerifyPubkey
|
||||||
|
_, _ = pairThroughWindow(t, ca, "home", "home2.cseries.localhost")
|
||||||
|
all, _ := loadPairings()
|
||||||
|
if len(all) != 1 || all[0].HostName != "home2.cseries.localhost" {
|
||||||
|
t.Fatalf("pairings: %v", hostNames(all))
|
||||||
|
}
|
||||||
|
f, _ = loadAnchorFile()
|
||||||
|
if a := currentAnchor(); a == nil || a.AnchorHost != "home2.cseries.localhost" || f.VerifyPubkey != pin || pin == "" {
|
||||||
|
t.Fatalf("anchor %+v (pin kept: %v)", a, f != nil && f.VerifyPubkey == pin)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The anchor moves only with machine authority, as every other anchor write
|
||||||
|
// (claim-anchor --repin's wall): a process without it leaves anchor.json as
|
||||||
|
// it is.
|
||||||
|
//
|
||||||
|
// MUTATION: drop the machineAuthorityHeld check in carryAnchorToNewName.
|
||||||
|
// RESULT: red, the anchor names the new name.
|
||||||
|
func TestTheAnchorMovesToANewNameOnlyWithMachineAuthority(t *testing.T) {
|
||||||
|
windowBox(t, true, true)
|
||||||
|
ca := newTestCA(t, "home CA")
|
||||||
|
_, _ = pairThroughWindow(t, ca, "home", "home1.cseries.localhost")
|
||||||
|
if a := currentAnchor(); a == nil || a.AnchorHost != "home1.cseries.localhost" {
|
||||||
|
t.Fatalf("first pairing: anchor %+v", a)
|
||||||
|
}
|
||||||
|
machineAuthorityHeld = func() bool { return false }
|
||||||
|
_, _ = pairThroughWindow(t, ca, "home", "home2.cseries.localhost")
|
||||||
|
if a := currentAnchor(); a == nil || a.AnchorHost != "home1.cseries.localhost" {
|
||||||
|
t.Fatalf("without machine authority the anchor was rewritten: %+v", a)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// 3. Right after `unpair` the running bastion still holds the door's port
|
||||||
|
// until it sees the pairing gone (a supervision period). `pair --open` waits
|
||||||
|
// for it to let go instead of failing "address already in use".
|
||||||
|
//
|
||||||
|
// MUTATION: drop the awaitDoorReleased call in cmdPairOpen. RESULT: red.
|
||||||
|
func TestPairOpenWaitsForTheRunningBastionToLetGoOfThePort(t *testing.T) {
|
||||||
|
pairingBox(t)
|
||||||
|
prevRunning, prevWait := pairDaemonRunning, doorReleaseWait
|
||||||
|
pairDaemonRunning = func() bool { return true }
|
||||||
|
doorReleaseWait = 10 * time.Second
|
||||||
|
t.Cleanup(func() { pairDaemonRunning, doorReleaseWait = prevRunning, prevWait })
|
||||||
|
addr := freeDoorAddr(t)
|
||||||
|
held, err := listenDoor(addr) // the running bastion's door, its pairing just removed
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
time.AfterFunc(1500*time.Millisecond, func() { _ = held.Close() })
|
||||||
|
code, out, res := openWindowFor(t, addr)
|
||||||
|
if !strings.Contains(out.String(), "waiting for it to let go") {
|
||||||
|
t.Fatalf("the person is not told why it waits:\n%s", out.String())
|
||||||
|
}
|
||||||
|
h := newStandinHost(t, newTestCA(t, "home CA"), "home", "home.cseries.localhost", addr)
|
||||||
|
if done, err := h.pair(formatWindowCode(code)); err != nil || done.State != pairingActive {
|
||||||
|
t.Fatalf("pair after the port was let go: %+v %v", done, err)
|
||||||
|
}
|
||||||
|
if err := <-res; err != nil {
|
||||||
|
t.Fatalf("pair --open: %v\n%s", err, out.String())
|
||||||
|
}
|
||||||
|
|
||||||
|
// Another program that never lets go: it still fails, after the wait, and
|
||||||
|
// says what to do.
|
||||||
|
doorReleaseWait = 300 * time.Millisecond
|
||||||
|
addr2 := freeDoorAddr(t)
|
||||||
|
other, err := net.Listen("tcp", addr2)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
defer other.Close()
|
||||||
|
err = cmdPairOpen(addr2, &syncBuf{})
|
||||||
|
if err == nil || !strings.Contains(err.Error(), "choose another with --port") {
|
||||||
|
t.Fatalf("a port another program holds: %v", err)
|
||||||
|
}
|
||||||
|
if !strings.Contains(err.Error(), "address already in use") {
|
||||||
|
t.Fatalf("not refused for the address in use: %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,479 @@
|
|||||||
|
//go:build linux
|
||||||
|
|
||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"bytes"
|
||||||
|
"context"
|
||||||
|
"crypto/tls"
|
||||||
|
"net"
|
||||||
|
"os"
|
||||||
|
"path/filepath"
|
||||||
|
"strings"
|
||||||
|
"sync"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
// freeDoorAddr is a loopback port nothing listens on.
|
||||||
|
func freeDoorAddr(t *testing.T) string {
|
||||||
|
t.Helper()
|
||||||
|
ln, err := net.Listen("tcp", "127.0.0.1:0")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
a := ln.Addr().String()
|
||||||
|
_ = ln.Close()
|
||||||
|
return a
|
||||||
|
}
|
||||||
|
|
||||||
|
// syncBuf is a bytes.Buffer two goroutines can share.
|
||||||
|
type syncBuf struct {
|
||||||
|
mu sync.Mutex
|
||||||
|
b bytes.Buffer
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *syncBuf) Write(p []byte) (int, error) { s.mu.Lock(); defer s.mu.Unlock(); return s.b.Write(p) }
|
||||||
|
func (s *syncBuf) String() string { s.mu.Lock(); defer s.mu.Unlock(); return s.b.String() }
|
||||||
|
|
||||||
|
// openWindowFor runs `pair --open` on addr in the background and returns the
|
||||||
|
// code it shows, its output, and its result.
|
||||||
|
func openWindowFor(t *testing.T, addr string) (code string, out *syncBuf, result <-chan error) {
|
||||||
|
t.Helper()
|
||||||
|
prevPoll := windowPollEvery
|
||||||
|
windowPollEvery = 20 * time.Millisecond
|
||||||
|
t.Cleanup(func() { windowPollEvery = prevPoll })
|
||||||
|
out = &syncBuf{}
|
||||||
|
res := make(chan error, 1)
|
||||||
|
go func() { res <- cmdPairOpen(addr, out) }()
|
||||||
|
deadline := time.Now().Add(5 * time.Second)
|
||||||
|
for time.Now().Before(deadline) {
|
||||||
|
if w := loadOpenWindow(); w != nil && strings.Contains(out.String(), formatWindowCode(w.Code)) {
|
||||||
|
return w.Code, out, res
|
||||||
|
}
|
||||||
|
time.Sleep(10 * time.Millisecond)
|
||||||
|
}
|
||||||
|
t.Fatalf("pair --open showed no code: %q", out.String())
|
||||||
|
return "", nil, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func pairingAuditText(t *testing.T) string {
|
||||||
|
t.Helper()
|
||||||
|
d, _ := configDir()
|
||||||
|
b, _ := os.ReadFile(filepath.Join(d, "pairing_audit.jsonl"))
|
||||||
|
return string(b)
|
||||||
|
}
|
||||||
|
|
||||||
|
// The code the person reads is the code both sides key the proofs with,
|
||||||
|
// however it is typed back.
|
||||||
|
func TestTheWindowCodeIsReadBackHoweverItIsTyped(t *testing.T) {
|
||||||
|
c, err := newWindowCode()
|
||||||
|
if err != nil || normalizeWindowCode(c) != c || len(c) != windowCodeLen {
|
||||||
|
t.Fatalf("a fresh code is not normalised: %q %v", c, err)
|
||||||
|
}
|
||||||
|
f := formatWindowCode(c)
|
||||||
|
if strings.Count(f, "-") != 3 || normalizeWindowCode(f) != c || normalizeWindowCode(strings.ToLower(f)) != c {
|
||||||
|
t.Fatalf("the shown code %q does not read back as %q", f, c)
|
||||||
|
}
|
||||||
|
if normalizeWindowCode("O1IL0-00000-00000-00000") != "01110000000000000000" {
|
||||||
|
t.Fatal("O, I and L read as the digits they look like")
|
||||||
|
}
|
||||||
|
for _, bad := range []string{"", "ABCDE", c + "0", strings.Replace(c, c[:1], "U", 1)} {
|
||||||
|
if normalizeWindowCode(bad) != "" {
|
||||||
|
t.Fatalf("%q is not a code", bad)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
for args, want := range map[string]string{"--open": doorDefaultAddr, "--open --port 9443": ":9443", "--port=9443 --open": ":9443"} {
|
||||||
|
got, ok, err := parsePairOpenArgs(strings.Fields(args))
|
||||||
|
if !ok || err != nil || got != want {
|
||||||
|
t.Fatalf("%s: %q %v %v", args, got, ok, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
for _, args := range []string{"--open --port 0", "--open --port x", "--open skb_x"} {
|
||||||
|
if _, ok, err := parsePairOpenArgs(strings.Fields(args)); !ok || err == nil {
|
||||||
|
t.Fatalf("%s must be refused", args)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if _, ok, _ := parsePairOpenArgs([]string{"skb_x"}); ok {
|
||||||
|
t.Fatal("a token pair is not --open")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A Host that connects pairs through the window: the code proved both ways,
|
||||||
|
// the pairing saved with its CA pinned and no address to dial, the window
|
||||||
|
// closed after one use, and each step in the audit.
|
||||||
|
func TestAHostThatConnectsPairsThroughTheWindow(t *testing.T) {
|
||||||
|
pairingBox(t)
|
||||||
|
addr := freeDoorAddr(t)
|
||||||
|
code, out, res := openWindowFor(t, addr)
|
||||||
|
ca := newTestCA(t, "home host CA")
|
||||||
|
h := newStandinHost(t, ca, "home", "home.cseries.localhost", addr)
|
||||||
|
done, err := h.pair(formatWindowCode(code))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("%v\n%s", err, pairingAuditText(t))
|
||||||
|
}
|
||||||
|
if done.State != pairingActive || done.HostName != "home.cseries.localhost" {
|
||||||
|
t.Fatalf("done: %+v", done)
|
||||||
|
}
|
||||||
|
select {
|
||||||
|
case err := <-res:
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("pair --open: %v\n%s", err, out.String())
|
||||||
|
}
|
||||||
|
case <-time.After(10 * time.Second):
|
||||||
|
t.Fatal("pair --open never saw the pairing end its window")
|
||||||
|
}
|
||||||
|
if !strings.Contains(out.String(), "Your Host connects to this server") || !strings.Contains(out.String(), "Paired with home.cseries.localhost") {
|
||||||
|
t.Fatalf("what the person reads:\n%s", out.String())
|
||||||
|
}
|
||||||
|
cfgs, _ := loadPairings()
|
||||||
|
c := pairingFor(cfgs, "home")
|
||||||
|
if c == nil || !c.hostDials() || c.DoorAddr != addr || c.LaneAddr != "" || !sameCAs(c.CACert, ca.pem) ||
|
||||||
|
!strings.HasPrefix(c.Bearer, "mcp_dials_home_") || operatorCertRefusal(c.OperatorCert, ca.pem, c.OperatorKey) != nil {
|
||||||
|
t.Fatalf("the pairing: %+v", c)
|
||||||
|
}
|
||||||
|
if w := readWindowFile(); w != nil {
|
||||||
|
t.Fatalf("the window outlived its pairing: %+v", w)
|
||||||
|
}
|
||||||
|
// One use: the same code again finds no window.
|
||||||
|
if _, err := h.pair(code); err == nil {
|
||||||
|
t.Fatal("a used code paired again")
|
||||||
|
}
|
||||||
|
a := pairingAuditText(t)
|
||||||
|
for _, op := range []string{`"window_opened"`, `"window_paired"`} {
|
||||||
|
if !strings.Contains(a, op) {
|
||||||
|
t.Fatalf("the audit has no %s:\n%s", op, a)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// SECURITY: a wrong code gets nothing, costs a wait that doubles, and the
|
||||||
|
// fifth closes the window. A proof made over another certificate (one
|
||||||
|
// relayed from another connection) is a wrong code. A Host never signs for a
|
||||||
|
// server that did not prove the code.
|
||||||
|
func TestAWrongCodeIsThrottledAndClosesTheWindow(t *testing.T) {
|
||||||
|
pairingBox(t)
|
||||||
|
prev := windowFailWait
|
||||||
|
windowFailWait = 100 * time.Millisecond
|
||||||
|
t.Cleanup(func() { windowFailWait = prev })
|
||||||
|
addr := freeDoorAddr(t)
|
||||||
|
code, _, res := openWindowFor(t, addr)
|
||||||
|
ca := newTestCA(t, "home host CA")
|
||||||
|
h := newStandinHost(t, ca, "home", "home.cseries.localhost", addr)
|
||||||
|
|
||||||
|
relayed := newStandinHost(t, ca, "home", "home.cseries.localhost", addr)
|
||||||
|
relayed.lieLeaf = true
|
||||||
|
if _, err := relayed.pair(code); err == nil {
|
||||||
|
t.Fatal("a proof over another certificate paired")
|
||||||
|
}
|
||||||
|
// The wait after it: the next try, at once, is not even offered a pairing.
|
||||||
|
if _, err := h.pair(code); err == nil || !strings.Contains(err.Error(), "handshake") {
|
||||||
|
t.Fatalf("a try inside the wait must be refused at the handshake, got %v", err)
|
||||||
|
}
|
||||||
|
wrong := "ZZZZZ-ZZZZZ-ZZZZZ-ZZZZZ"
|
||||||
|
for i := 2; i <= windowMaxFailures; i++ {
|
||||||
|
time.Sleep(time.Duration(1<<(i-2))*windowFailWait + 50*time.Millisecond)
|
||||||
|
if _, err := h.pair(wrong); err == nil {
|
||||||
|
t.Fatalf("wrong code %d paired", i)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
select {
|
||||||
|
case err := <-res:
|
||||||
|
if err == nil || !strings.Contains(err.Error(), "wrong codes") {
|
||||||
|
t.Fatalf("pair --open after %d wrong codes: %v", windowMaxFailures, err)
|
||||||
|
}
|
||||||
|
case <-time.After(5 * time.Second):
|
||||||
|
t.Fatal("the window stayed open after five wrong codes")
|
||||||
|
}
|
||||||
|
if _, err := h.pair(code); err == nil {
|
||||||
|
t.Fatal("the right code paired after the window closed")
|
||||||
|
}
|
||||||
|
cfgs, _ := loadPairings()
|
||||||
|
if len(cfgs) != 0 || h.csrs != 0 || relayed.csrs != 0 {
|
||||||
|
t.Fatalf("a wrong code got something: %d pairings, %d CSRs signed", len(cfgs), h.csrs+relayed.csrs)
|
||||||
|
}
|
||||||
|
if n := strings.Count(pairingAuditText(t), `"window_wrong_code"`); n != windowMaxFailures {
|
||||||
|
t.Fatalf("%d wrong codes audited, want %d", n, windowMaxFailures)
|
||||||
|
}
|
||||||
|
|
||||||
|
// The Host's side: a server whose proof does not check gets no signature.
|
||||||
|
addr2 := freeDoorAddr(t)
|
||||||
|
code2, _, res2 := openWindowFor(t, addr2)
|
||||||
|
strict := newStandinHost(t, ca, "home", "home.cseries.localhost", addr2)
|
||||||
|
strict.badProof = true
|
||||||
|
if d, err := strict.pair(code2); err != nil || d.State != "refused" {
|
||||||
|
t.Fatalf("a Host refusing the server's proof: %+v %v", d, err)
|
||||||
|
}
|
||||||
|
if err := <-res2; err == nil {
|
||||||
|
t.Fatal("the window reported a pairing the Host refused")
|
||||||
|
}
|
||||||
|
if cfgs, _ := loadPairings(); len(cfgs) != 0 || strict.csrs != 0 {
|
||||||
|
t.Fatal("a pairing was kept that the Host never signed for")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// hostDialsPairingFor is a host-dials pairing with an operator certificate
|
||||||
|
// from ca and its door on addr.
|
||||||
|
func hostDialsPairingFor(t *testing.T, ca *testCA, host, addr string) *Config {
|
||||||
|
t.Helper()
|
||||||
|
c := tcpPairingFor(t, ca, host, "")
|
||||||
|
c.HostDials, c.DoorAddr = true, addr
|
||||||
|
c.Bearer = "mcp_dials_lane_bearer"
|
||||||
|
return c
|
||||||
|
}
|
||||||
|
|
||||||
|
// runPairingBG runs the pairing until the returned stop.
|
||||||
|
func runPairingBG(t *testing.T, cfg *Config) (stop func() error) {
|
||||||
|
ctx, cancel := context.WithCancel(context.Background())
|
||||||
|
errc := make(chan error, 1)
|
||||||
|
go func() { errc <- runPairing(ctx, cfg) }()
|
||||||
|
return func() error {
|
||||||
|
cancel()
|
||||||
|
select {
|
||||||
|
case err := <-errc:
|
||||||
|
return err
|
||||||
|
case <-time.After(10 * time.Second):
|
||||||
|
t.Fatal("the pairing did not stop")
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func doorWaitFor(t *testing.T, d time.Duration, what string, ok func() bool) {
|
||||||
|
t.Helper()
|
||||||
|
deadline := time.Now().Add(d)
|
||||||
|
for time.Now().Before(deadline) {
|
||||||
|
if ok() {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
time.Sleep(20 * time.Millisecond)
|
||||||
|
}
|
||||||
|
t.Fatalf("timed out waiting for %s", what)
|
||||||
|
}
|
||||||
|
|
||||||
|
// The lanes run over the connections the Host opens, exactly as over a
|
||||||
|
// dialled lane port: the heartbeat with the bearer, every worker pool, a
|
||||||
|
// harness job on a parked worker, every handshake under host.cseries.internal
|
||||||
|
// and with the operator certificate (the stand-in requires and verifies it).
|
||||||
|
// The door is bound only while the pairing is served, and the bastion never
|
||||||
|
// dials anything.
|
||||||
|
func TestTheLanesRunOverTheConnectionsTheHostOpens(t *testing.T) {
|
||||||
|
pairingBox(t)
|
||||||
|
laneTestProcess(t)
|
||||||
|
ca := newTestCA(t, "home host CA")
|
||||||
|
addr := freeDoorAddr(t)
|
||||||
|
cfg := hostDialsPairingFor(t, ca, "home.cseries.localhost", addr)
|
||||||
|
h := newStandinHost(t, ca, "home", cfg.HostName, addr)
|
||||||
|
h.lane.jobs <- []byte(`{"harness_id":"h1","mode":"echo","prompt":"hello over a Host-opened connection"}`)
|
||||||
|
ctx, cancel := context.WithCancel(context.Background())
|
||||||
|
defer cancel()
|
||||||
|
go h.serveLanes(ctx)
|
||||||
|
|
||||||
|
stop := runPairingBG(t, cfg)
|
||||||
|
doorWaitFor(t, 10*time.Second, "the heartbeat and every worker", func() bool {
|
||||||
|
hellos, beats := h.lane.snapshot()
|
||||||
|
return len(beats) > 0 && len(hellos) >= harnessWorkerCount+sessionWorkerCount+mgmtWorkerCount+egressWorkerCount+serveWorkerCount
|
||||||
|
})
|
||||||
|
select {
|
||||||
|
case r := <-h.lane.replies:
|
||||||
|
if !strings.HasSuffix(r, "exit=0") {
|
||||||
|
t.Fatalf("the harness job: %s", r)
|
||||||
|
}
|
||||||
|
case <-time.After(10 * time.Second):
|
||||||
|
t.Fatal("a parked harness worker served no job")
|
||||||
|
}
|
||||||
|
hellos, beats := h.lane.snapshot()
|
||||||
|
if beats[0] != "Bearer "+cfg.Bearer {
|
||||||
|
t.Fatalf("the heartbeat carries the bearer: %q", beats)
|
||||||
|
}
|
||||||
|
count := map[string]int{}
|
||||||
|
for _, hl := range hellos {
|
||||||
|
path, msg, _ := strings.Cut(hl, " ")
|
||||||
|
if !strings.HasPrefix(msg, "BEARER "+cfg.Bearer) {
|
||||||
|
t.Fatalf("a worker opened without the bearer: %q", hl)
|
||||||
|
}
|
||||||
|
if strings.Contains(msg, "lane=session") {
|
||||||
|
path += " session"
|
||||||
|
}
|
||||||
|
count[path]++
|
||||||
|
}
|
||||||
|
if count["/bastion-harness"] < harnessWorkerCount || count["/bastion-harness session"] != sessionWorkerCount ||
|
||||||
|
count["/bastion-mgmt"] != mgmtWorkerCount || count["/bastion-egress"] != egressWorkerCount ||
|
||||||
|
count["/bastion-serve"] != serveWorkerCount {
|
||||||
|
t.Fatalf("the worker pools over Host-opened connections: %v", count)
|
||||||
|
}
|
||||||
|
h.lane.mu.Lock()
|
||||||
|
sni := append([]string(nil), h.lane.sni...)
|
||||||
|
h.lane.mu.Unlock()
|
||||||
|
for _, n := range sni {
|
||||||
|
if n != tcpServerName {
|
||||||
|
t.Fatalf("a handshake asked for %q", n)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if !strings.Contains(pairingAuditText(t), `"host_connected"`) {
|
||||||
|
t.Fatal("the Host's connection is not in the audit")
|
||||||
|
}
|
||||||
|
if err := stop(); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
// Closed with its last pairing.
|
||||||
|
doorWaitFor(t, 5*time.Second, "the door to close", func() bool {
|
||||||
|
ln, err := net.Listen("tcp", addr)
|
||||||
|
if err == nil {
|
||||||
|
_ = ln.Close()
|
||||||
|
}
|
||||||
|
return err == nil
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
// SECURITY: the door keeps a connection only from the Host whose pinned CA
|
||||||
|
// its certificate verifies under, for host.cseries.internal, naming the lane
|
||||||
|
// protocol. Another CA, the right CA under another name, no protocol, and a
|
||||||
|
// pairing protocol with no window open all end at the handshake: nothing is
|
||||||
|
// pooled and no lane ever runs on them.
|
||||||
|
func TestTheDoorRefusesAnythingButItsPinnedHost(t *testing.T) {
|
||||||
|
pairingBox(t)
|
||||||
|
laneTestProcess(t)
|
||||||
|
ca := newTestCA(t, "home host CA")
|
||||||
|
addr := freeDoorAddr(t)
|
||||||
|
cfg := hostDialsPairingFor(t, ca, "home.cseries.localhost", addr)
|
||||||
|
stop := runPairingBG(t, cfg)
|
||||||
|
defer stop()
|
||||||
|
doorWaitFor(t, 5*time.Second, "the door", func() bool {
|
||||||
|
c, err := net.Dial("tcp", addr)
|
||||||
|
if err == nil {
|
||||||
|
_ = c.Close()
|
||||||
|
}
|
||||||
|
return err == nil
|
||||||
|
})
|
||||||
|
impostor := newTestCA(t, "impostor")
|
||||||
|
cases := map[string]struct {
|
||||||
|
cert tls.Certificate
|
||||||
|
protos []string
|
||||||
|
}{
|
||||||
|
"another CA": {impostor.serverCert(t, tcpServerName), []string{laneALPN}},
|
||||||
|
"the Host's own name": {ca.serverCert(t, "home.cseries.localhost"), []string{laneALPN}},
|
||||||
|
"no protocol": {ca.serverCert(t, tcpServerName), nil},
|
||||||
|
"pairing, no window": {ca.serverCert(t, tcpServerName), []string{pairALPN}},
|
||||||
|
}
|
||||||
|
for name, tc := range cases {
|
||||||
|
raw, err := net.Dial("tcp", addr)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
s := tls.Server(raw, &tls.Config{Certificates: []tls.Certificate{tc.cert}, NextProtos: tc.protos,
|
||||||
|
ClientAuth: tls.RequestClientCert})
|
||||||
|
_ = s.SetDeadline(time.Now().Add(5 * time.Second))
|
||||||
|
herr := s.Handshake()
|
||||||
|
if herr == nil {
|
||||||
|
// TLS 1.3: the server's side can finish before the client's
|
||||||
|
// verdict arrives; the verdict is the connection closing.
|
||||||
|
_, herr = s.Read(make([]byte, 1))
|
||||||
|
}
|
||||||
|
if herr == nil {
|
||||||
|
t.Fatalf("%s: the door kept the connection", name)
|
||||||
|
}
|
||||||
|
if got := len(s.ConnectionState().PeerCertificates); got != 0 {
|
||||||
|
t.Fatalf("%s: the door presented this bastion's certificate to a stranger", name)
|
||||||
|
}
|
||||||
|
_ = raw.Close()
|
||||||
|
}
|
||||||
|
// Nothing was pooled: a lane's dial finds no connection. Its wait is
|
||||||
|
// cut short by the context: doorTakeWait is a constant, read by every
|
||||||
|
// lane, an earlier test's still running ones too.
|
||||||
|
short, cancelShort := context.WithTimeout(context.Background(), 500*time.Millisecond)
|
||||||
|
defer cancelShort()
|
||||||
|
if c, err := hostDoorDial(cfg)(short); err == nil {
|
||||||
|
_ = c.Close()
|
||||||
|
t.Fatal("a refused connection reached the pool")
|
||||||
|
}
|
||||||
|
if !strings.Contains(pairingAuditText(t), `"door_refused"`) {
|
||||||
|
t.Fatal("the refusals are not in the audit")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The Host redials, the bastion never does: a Host that stops and comes back
|
||||||
|
// gets its lanes again, and so does a bastion that restarts, all on
|
||||||
|
// connections the Host opens. A connection the Host closes while idle leaves
|
||||||
|
// the pool at once.
|
||||||
|
func TestTheHostReconnectsAfterEitherSideRestarts(t *testing.T) {
|
||||||
|
pairingBox(t)
|
||||||
|
laneTestProcess(t)
|
||||||
|
ca := newTestCA(t, "home host CA")
|
||||||
|
addr := freeDoorAddr(t)
|
||||||
|
cfg := hostDialsPairingFor(t, ca, "home.cseries.localhost", addr)
|
||||||
|
h := newStandinHost(t, ca, "home", cfg.HostName, addr)
|
||||||
|
beats := func() int { _, b := h.lane.snapshot(); return len(b) }
|
||||||
|
|
||||||
|
stop := runPairingBG(t, cfg)
|
||||||
|
ctx, cancel := context.WithCancel(context.Background())
|
||||||
|
go h.serveLanes(ctx)
|
||||||
|
doorWaitFor(t, 10*time.Second, "the first heartbeat", func() bool { return beats() >= 1 })
|
||||||
|
|
||||||
|
// The Host stops: every connection closes, and the pool empties.
|
||||||
|
cancel()
|
||||||
|
doorWaitFor(t, 5*time.Second, "the pool to empty", func() bool {
|
||||||
|
doors.Lock()
|
||||||
|
d := doors.m[addr]
|
||||||
|
doors.Unlock()
|
||||||
|
d.mu.Lock()
|
||||||
|
p := d.pairings[cfg.HostName]
|
||||||
|
d.mu.Unlock()
|
||||||
|
return p.live.Load() == 0
|
||||||
|
})
|
||||||
|
doorWaitFor(t, 5*time.Second, "the Host going away in the audit", func() bool {
|
||||||
|
return strings.Contains(pairingAuditText(t), `"host_disconnected"`)
|
||||||
|
})
|
||||||
|
// It comes back: a beat at once (the reconnect brings the lanes up; the
|
||||||
|
// beat loop's next tick or a new run sends it).
|
||||||
|
n := beats()
|
||||||
|
ctx2, cancel2 := context.WithCancel(context.Background())
|
||||||
|
defer cancel2()
|
||||||
|
go h.serveLanes(ctx2)
|
||||||
|
if err := stop(); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
// The bastion restarts while the Host keeps redialling.
|
||||||
|
stop = runPairingBG(t, cfg)
|
||||||
|
defer stop()
|
||||||
|
doorWaitFor(t, 15*time.Second, "a heartbeat after both restarts", func() bool { return beats() > n })
|
||||||
|
if h.dials.Load() < 2*hostSpareConns {
|
||||||
|
t.Fatalf("the Host opened %d connections over two runs", h.dials.Load())
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The terminal closing the window and a door committing a pairing on it are
|
||||||
|
// one rename each, across processes: whichever comes first wins. A window
|
||||||
|
// closed first is never claimed; a window claimed first is reported as the
|
||||||
|
// pairing it made, never "nothing was paired".
|
||||||
|
func TestClosingAWindowAndClaimingItCannotBothWin(t *testing.T) {
|
||||||
|
pairingBox(t)
|
||||||
|
open := func(id string) {
|
||||||
|
w := &pairWindow{ID: id, Code: "0123456789ABCDEFGHJK", Door: ":8812", Opened: time.Now().UTC().Format(time.RFC3339),
|
||||||
|
Expires: time.Now().Add(time.Minute).UTC().Format(time.RFC3339)}
|
||||||
|
if err := saveWindowFile(w); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
open("a")
|
||||||
|
if removeWindow("a") {
|
||||||
|
t.Fatal("an unclaimed window closed as claimed")
|
||||||
|
}
|
||||||
|
if claimWindow("a") {
|
||||||
|
t.Fatal("a window closed at the terminal was claimed")
|
||||||
|
}
|
||||||
|
open("b")
|
||||||
|
if !claimWindow("b") {
|
||||||
|
t.Fatal("an open window could not be claimed")
|
||||||
|
}
|
||||||
|
if !removeWindow("b") {
|
||||||
|
t.Fatal("closing a claimed window did not say it was claimed")
|
||||||
|
}
|
||||||
|
endWindow("b", windowResult{Host: "home.cseries.localhost", State: pairingActive})
|
||||||
|
if res := awaitClaimedResult("b"); res == nil || res.Host != "home.cseries.localhost" {
|
||||||
|
t.Fatalf("the claimed window's result: %+v", res)
|
||||||
|
}
|
||||||
|
if claimedWindow("b") != nil {
|
||||||
|
t.Fatal("the claimed file outlived its result")
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,123 @@
|
|||||||
|
//go:build linux
|
||||||
|
|
||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"crypto/tls"
|
||||||
|
"errors"
|
||||||
|
"fmt"
|
||||||
|
"io"
|
||||||
|
"net"
|
||||||
|
"net/http"
|
||||||
|
"strings"
|
||||||
|
"sync"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
// A connection that finishes its handshake after its pairing stopped is
|
||||||
|
// closed, never held idle with a watcher nobody will ever stop.
|
||||||
|
func TestAConnectionPutAfterThePairingStoppedIsClosed(t *testing.T) {
|
||||||
|
pairingBox(t)
|
||||||
|
p := &doorPairing{host: "home", idle: make(chan *hostOpenedConn, doorMaxIdle)}
|
||||||
|
p.drain()
|
||||||
|
a, b := net.Pipe()
|
||||||
|
t.Cleanup(func() { _ = a.Close(); _ = b.Close() })
|
||||||
|
p.put(tls.Client(a, &tls.Config{InsecureSkipVerify: true}), "192.0.2.1")
|
||||||
|
if n, live := len(p.idle), p.live.Load(); n != 0 || live != 0 {
|
||||||
|
t.Fatalf("a stopped pairing holds %d idle connections, %d live", n, live)
|
||||||
|
}
|
||||||
|
_ = b.SetReadDeadline(time.Now().Add(2 * time.Second))
|
||||||
|
if n, err := b.Read(make([]byte, 1)); err != io.EOF {
|
||||||
|
t.Fatalf("the connection was left open (read %d, %v)", n, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Every connection that was offered the window while it was open runs into
|
||||||
|
// the same rules when its exchange starts: a window closed by the fifth wrong
|
||||||
|
// code, inside a wrong code's wait, or closed at the terminal, starts nothing.
|
||||||
|
func TestAWindowClosedDuringAHandshakeStartsNothing(t *testing.T) {
|
||||||
|
pairingBox(t)
|
||||||
|
addr := freeDoorAddr(t)
|
||||||
|
w := &pairWindow{ID: "w1", Code: strings.Repeat("A", windowCodeLen), Door: addr,
|
||||||
|
Expires: time.Now().Add(time.Minute).UTC().Format(time.RFC3339)}
|
||||||
|
if err := saveWindowFile(w); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
d := newHostDoor(addr, false)
|
||||||
|
if d.openWindow() == nil {
|
||||||
|
t.Fatal("the window is not offered")
|
||||||
|
}
|
||||||
|
|
||||||
|
d.win.failures = windowMaxFailures
|
||||||
|
if d.windowBegin(w) {
|
||||||
|
t.Fatal("a pairing started after the fifth wrong code")
|
||||||
|
}
|
||||||
|
d.win.failures, d.win.next = 1, time.Now().Add(time.Hour)
|
||||||
|
if d.windowBegin(w) {
|
||||||
|
t.Fatal("a pairing started inside a wrong code's wait")
|
||||||
|
}
|
||||||
|
d.win.failures, d.win.next = 0, time.Time{}
|
||||||
|
removeWindow(w.ID)
|
||||||
|
if d.windowBegin(w) {
|
||||||
|
t.Fatal("a pairing started on a window closed at the terminal")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A window closed at the terminal while the exchange runs: the Host is not
|
||||||
|
// asked to sign anything.
|
||||||
|
func TestAWindowClosedDuringTheExchangeIsNeverRedeemed(t *testing.T) {
|
||||||
|
pairingBox(t)
|
||||||
|
ca := newTestCA(t, "home host CA")
|
||||||
|
var mu sync.Mutex
|
||||||
|
var paths []string
|
||||||
|
c := &http.Client{Transport: roundTripFunc(func(r *http.Request) (*http.Response, error) {
|
||||||
|
mu.Lock()
|
||||||
|
paths = append(paths, r.URL.Path)
|
||||||
|
mu.Unlock()
|
||||||
|
return nil, fmt.Errorf("no Host here")
|
||||||
|
})}
|
||||||
|
w := &pairWindow{ID: "gone", Code: strings.Repeat("A", windowCodeLen), Door: ":8812"}
|
||||||
|
_, res := windowCommit(c, w, windowHelloResp{HostHandle: "home", HostName: "home.cseries.localhost"}, ca.pem,
|
||||||
|
func() string { return "proof" })
|
||||||
|
mu.Lock()
|
||||||
|
defer mu.Unlock()
|
||||||
|
if len(paths) != 0 || !strings.Contains(res.Error, "window closed") {
|
||||||
|
t.Fatalf("a closed window was redeemed: requests %v, result %+v", paths, res)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
type roundTripFunc func(*http.Request) (*http.Response, error)
|
||||||
|
|
||||||
|
func (f roundTripFunc) RoundTrip(r *http.Request) (*http.Response, error) { return f(r) }
|
||||||
|
|
||||||
|
// One IPv6 machine is one source: its /64 counts as one address.
|
||||||
|
func TestTheHandshakeLimitCountsAnIPv6NetworkAsOneSource(t *testing.T) {
|
||||||
|
d := newHostDoor(":0", true)
|
||||||
|
for i := 1; i <= doorMaxHandshakesPerSource; i++ {
|
||||||
|
if !d.admitHandshake(sourceKey(fmt.Sprintf("2001:db8:1:2::%x", i))) {
|
||||||
|
t.Fatalf("handshake %d refused", i)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if d.admitHandshake(sourceKey("2001:db8:1:2::ffff")) {
|
||||||
|
t.Fatal("a ninth handshake from one /64 was admitted")
|
||||||
|
}
|
||||||
|
if !d.admitHandshake(sourceKey("2001:db8:1:3::1")) || !d.admitHandshake(sourceKey("192.0.2.7")) {
|
||||||
|
t.Fatal("another source was refused")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A scan from many addresses writes a bounded number of refusals.
|
||||||
|
func TestAScanFromManyAddressesDoesNotFillTheAudit(t *testing.T) {
|
||||||
|
pairingBox(t)
|
||||||
|
d := newHostDoor(":0", true)
|
||||||
|
for i := 0; i < 4*doorRefusalAuditSources; i++ {
|
||||||
|
d.refuse(fmt.Sprintf("2001:db8:%x::1", i), errors.New("scan"))
|
||||||
|
}
|
||||||
|
if n := strings.Count(pairingAuditText(t), `"door_refused"`); n > doorRefusalAuditSources {
|
||||||
|
t.Fatalf("%d refusals audited from a scan, at most %d", n, doorRefusalAuditSources)
|
||||||
|
}
|
||||||
|
if len(d.refused) > doorRefusalAuditSources {
|
||||||
|
t.Fatalf("the refusal map grew to %d", len(d.refused))
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,402 @@
|
|||||||
|
//go:build linux
|
||||||
|
|
||||||
|
package main
|
||||||
|
|
||||||
|
// The door's handshake slots under a flood: the global and per-source caps,
|
||||||
|
// the share kept for addresses a Host proved itself from, and the random
|
||||||
|
// early drop for strangers (hostdoor.go, admitHandshake).
|
||||||
|
|
||||||
|
import (
|
||||||
|
"crypto/tls"
|
||||||
|
"fmt"
|
||||||
|
"io"
|
||||||
|
"math"
|
||||||
|
"net"
|
||||||
|
"sync"
|
||||||
|
"sync/atomic"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
// freshDoorMemory forgets every Host address, before and after the test.
|
||||||
|
func freshDoorMemory(t *testing.T) {
|
||||||
|
t.Helper()
|
||||||
|
reset := func() {
|
||||||
|
doorKnown.Lock()
|
||||||
|
doorKnown.until = nil
|
||||||
|
doorKnown.Unlock()
|
||||||
|
}
|
||||||
|
reset()
|
||||||
|
t.Cleanup(reset)
|
||||||
|
}
|
||||||
|
|
||||||
|
// neverDrops is a draw the early drop never refuses on (it refuses when the
|
||||||
|
// draw is below the drop chance, which is under 1 short of the limit).
|
||||||
|
func neverDrops() float64 { return math.Nextafter(1, 0) }
|
||||||
|
|
||||||
|
// alwaysDrops is a draw the early drop refuses on wherever it applies.
|
||||||
|
func alwaysDrops() float64 { return 0 }
|
||||||
|
|
||||||
|
func strangersShare() int { return doorMaxHandshakes - doorReservedHandshakes }
|
||||||
|
|
||||||
|
// The global and per-source caps hold for everyone, a known Host's address
|
||||||
|
// included, and strangers never take the reserved share, however lucky.
|
||||||
|
func TestTheHandshakeCapsStillHold(t *testing.T) {
|
||||||
|
freshDoorMemory(t)
|
||||||
|
now := time.Now()
|
||||||
|
d := newHostDoor(":0", true)
|
||||||
|
d.draw = neverDrops
|
||||||
|
// Strangers: admitted up to their share, from enough addresses, and not
|
||||||
|
// one more.
|
||||||
|
for i := 0; i < strangersShare(); i++ {
|
||||||
|
if !d.admitHandshake(fmt.Sprintf("203.0.113.%d", i/doorMaxHandshakesPerSource)) {
|
||||||
|
t.Fatalf("stranger handshake %d refused below the strangers' share", i)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if d.admitHandshake("198.51.100.200") {
|
||||||
|
t.Fatalf("a stranger took a slot of the reserve (%d in progress)", d.inflight)
|
||||||
|
}
|
||||||
|
// Known addresses: the rest, 8 from each, and then nothing for anyone.
|
||||||
|
for i := 0; d.inflight < doorMaxHandshakes; i++ {
|
||||||
|
src := fmt.Sprintf("198.51.100.%d", i)
|
||||||
|
doorRememberHost(src, now)
|
||||||
|
for j := 0; j < doorMaxHandshakesPerSource; j++ {
|
||||||
|
if !d.admitHandshake(src) {
|
||||||
|
t.Fatalf("handshake %d of known %s refused with %d in progress", j, src, d.inflight)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if d.inflight < doorMaxHandshakes && d.admitHandshake(src) {
|
||||||
|
t.Fatalf("known %s got a ninth handshake", src)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
doorRememberHost("192.0.2.1", now)
|
||||||
|
if d.inflight != doorMaxHandshakes || d.admitHandshake("192.0.2.1") {
|
||||||
|
t.Fatalf("a handshake past the global cap of %d (%d in progress)", doorMaxHandshakes, d.inflight)
|
||||||
|
}
|
||||||
|
// A known address is held to 8 at once on an empty door too.
|
||||||
|
e := newHostDoor(":0", true)
|
||||||
|
for j := 0; j < doorMaxHandshakesPerSource; j++ {
|
||||||
|
if !e.admitHandshake("192.0.2.1") {
|
||||||
|
t.Fatal("a known address was refused on an empty door")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if e.admitHandshake("192.0.2.1") {
|
||||||
|
t.Fatal("a known address got a ninth handshake at once")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Strangers are dropped early as the door fills: never below the start,
|
||||||
|
// with the chance rising from the rate to certain at the strangers' share.
|
||||||
|
// A known Host's address is never early-dropped.
|
||||||
|
func TestStrangersAreDroppedEarlyAsTheDoorFills(t *testing.T) {
|
||||||
|
freshDoorMemory(t)
|
||||||
|
d := newHostDoor(":0", true)
|
||||||
|
full := strangersShare()
|
||||||
|
for _, c := range []struct {
|
||||||
|
n int
|
||||||
|
draw float64
|
||||||
|
admits bool
|
||||||
|
}{
|
||||||
|
{0, 0, true},
|
||||||
|
{doorEarlyDropStart - 1, 0, true},
|
||||||
|
{doorEarlyDropStart, doorEarlyDropRate - 0.01, false},
|
||||||
|
{doorEarlyDropStart, doorEarlyDropRate + 0.01, true},
|
||||||
|
{(doorEarlyDropStart + full) / 2, (1+doorEarlyDropRate)/2 - 0.01, false},
|
||||||
|
{(doorEarlyDropStart + full) / 2, (1+doorEarlyDropRate)/2 + 0.01, true},
|
||||||
|
{full - 1, 0.99, false},
|
||||||
|
{full - 1, neverDrops(), true},
|
||||||
|
{full, neverDrops(), false},
|
||||||
|
} {
|
||||||
|
draw := c.draw
|
||||||
|
d.draw = func() float64 { return draw }
|
||||||
|
if got := d.admitStranger(c.n); got != c.admits {
|
||||||
|
t.Fatalf("with %d in progress and a draw of %v: admitted %v, want %v", c.n, c.draw, got, c.admits)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
// Through admitHandshake: an unlucky stranger is refused at the start,
|
||||||
|
// a known address with the same draw is not, up to the global cap.
|
||||||
|
d = newHostDoor(":0", true)
|
||||||
|
d.draw = alwaysDrops
|
||||||
|
for i := 0; i < doorEarlyDropStart; i++ {
|
||||||
|
if !d.admitHandshake(fmt.Sprintf("203.0.113.%d", i)) {
|
||||||
|
t.Fatalf("stranger %d refused below the start", i)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if d.admitHandshake("203.0.113.250") {
|
||||||
|
t.Fatal("an unlucky stranger was admitted past the start")
|
||||||
|
}
|
||||||
|
doorRememberHost("198.51.100.7", time.Now())
|
||||||
|
d.inflight = doorMaxHandshakes - 1
|
||||||
|
if !d.admitHandshake("198.51.100.7") {
|
||||||
|
t.Fatal("a known Host's address was early-dropped")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// An address is remembered for doorKnownHostFor after its last verified
|
||||||
|
// handshake, in a bounded memory that forgets the oldest first.
|
||||||
|
func TestAHostAddressIsRememberedForAWhileAndBounded(t *testing.T) {
|
||||||
|
freshDoorMemory(t)
|
||||||
|
now := time.Now()
|
||||||
|
doorRememberHost("198.51.100.7", now)
|
||||||
|
if !doorKnownHost("198.51.100.7", now.Add(doorKnownHostFor-time.Second)) {
|
||||||
|
t.Fatal("forgotten before its time")
|
||||||
|
}
|
||||||
|
if doorKnownHost("198.51.100.7", now.Add(doorKnownHostFor)) {
|
||||||
|
t.Fatal("remembered past its time")
|
||||||
|
}
|
||||||
|
if doorKnownHost("198.51.100.8", now) {
|
||||||
|
t.Fatal("an address no Host proved itself from is known")
|
||||||
|
}
|
||||||
|
// A fresh handshake renews it.
|
||||||
|
doorRememberHost("198.51.100.7", now)
|
||||||
|
doorRememberHost("198.51.100.7", now.Add(doorKnownHostFor-time.Second))
|
||||||
|
if !doorKnownHost("198.51.100.7", now.Add(doorKnownHostFor+time.Hour)) {
|
||||||
|
t.Fatal("a renewed address was forgotten")
|
||||||
|
}
|
||||||
|
// Bounded: the oldest goes first, the newest stays.
|
||||||
|
for i := 0; i < 2*doorKnownHostsMax; i++ {
|
||||||
|
doorRememberHost(fmt.Sprintf("2001:db8:%x::/64", i), now.Add(time.Duration(i)*time.Second))
|
||||||
|
}
|
||||||
|
doorKnown.Lock()
|
||||||
|
n := len(doorKnown.until)
|
||||||
|
doorKnown.Unlock()
|
||||||
|
if n > doorKnownHostsMax {
|
||||||
|
t.Fatalf("the memory holds %d addresses, at most %d", n, doorKnownHostsMax)
|
||||||
|
}
|
||||||
|
last := now.Add(time.Duration(2*doorKnownHostsMax) * time.Second)
|
||||||
|
if !doorKnownHost(fmt.Sprintf("2001:db8:%x::/64", 2*doorKnownHostsMax-1), last) {
|
||||||
|
t.Fatal("the newest address was forgotten")
|
||||||
|
}
|
||||||
|
if doorKnownHost("2001:db8:0::/64", last) {
|
||||||
|
t.Fatal("the oldest address outlived a full memory")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// pipeDoor is a door served over in-memory connections from any address the
|
||||||
|
// test names, with one pairing for ca's Host.
|
||||||
|
type pipeDoor struct {
|
||||||
|
d *hostDoor
|
||||||
|
p *doorPairing
|
||||||
|
ca *testCA
|
||||||
|
conns chan net.Conn
|
||||||
|
quit chan struct{}
|
||||||
|
accepts atomic.Int64
|
||||||
|
pushed int64
|
||||||
|
mu sync.Mutex
|
||||||
|
ends []net.Conn
|
||||||
|
}
|
||||||
|
|
||||||
|
func (l *pipeDoor) Accept() (net.Conn, error) {
|
||||||
|
l.accepts.Add(1)
|
||||||
|
select {
|
||||||
|
case c := <-l.conns:
|
||||||
|
return c, nil
|
||||||
|
case <-l.quit:
|
||||||
|
return nil, net.ErrClosed
|
||||||
|
}
|
||||||
|
}
|
||||||
|
func (l *pipeDoor) Close() error { return nil }
|
||||||
|
func (l *pipeDoor) Addr() net.Addr { return &net.TCPAddr{Port: 8812} }
|
||||||
|
|
||||||
|
type fromConn struct {
|
||||||
|
net.Conn
|
||||||
|
from net.Addr
|
||||||
|
}
|
||||||
|
|
||||||
|
func (c fromConn) RemoteAddr() net.Addr { return c.from }
|
||||||
|
|
||||||
|
func newPipeDoor(t *testing.T) *pipeDoor {
|
||||||
|
t.Helper()
|
||||||
|
ca := newTestCA(t, "home host CA")
|
||||||
|
cfg := hostDialsPairingFor(t, ca, "home.cseries.localhost", ":8812")
|
||||||
|
p, err := newDoorPairing(cfg)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
l := &pipeDoor{d: newHostDoor(":8812", true), p: p, ca: ca, conns: make(chan net.Conn), quit: make(chan struct{})}
|
||||||
|
l.d.pairings[cfg.HostName] = p
|
||||||
|
go l.d.serve(l)
|
||||||
|
t.Cleanup(func() {
|
||||||
|
close(l.quit)
|
||||||
|
l.mu.Lock()
|
||||||
|
for _, c := range l.ends {
|
||||||
|
_ = c.Close()
|
||||||
|
}
|
||||||
|
l.mu.Unlock()
|
||||||
|
p.drain()
|
||||||
|
doorWaitFor(t, 15*time.Second, "every handshake to end", func() bool { return l.inflight() == 0 })
|
||||||
|
})
|
||||||
|
return l
|
||||||
|
}
|
||||||
|
|
||||||
|
// connect hands the door a connection from ip and waits until the door has
|
||||||
|
// admitted or closed it. It returns the far end.
|
||||||
|
func (l *pipeDoor) connect(t *testing.T, ip string) net.Conn {
|
||||||
|
t.Helper()
|
||||||
|
near, far := net.Pipe()
|
||||||
|
l.mu.Lock()
|
||||||
|
l.ends = append(l.ends, far)
|
||||||
|
l.mu.Unlock()
|
||||||
|
l.conns <- fromConn{Conn: near, from: &net.TCPAddr{IP: net.ParseIP(ip), Port: 40000}}
|
||||||
|
l.pushed++
|
||||||
|
for l.accepts.Load() <= l.pushed {
|
||||||
|
time.Sleep(50 * time.Microsecond)
|
||||||
|
}
|
||||||
|
return far
|
||||||
|
}
|
||||||
|
|
||||||
|
// stranger connects from ip and never answers the handshake: a slot held
|
||||||
|
// until the handshake's time runs out.
|
||||||
|
func (l *pipeDoor) stranger(t *testing.T, ip string) {
|
||||||
|
far := l.connect(t, ip)
|
||||||
|
go func() { _, _ = io.Copy(io.Discard, far) }()
|
||||||
|
}
|
||||||
|
|
||||||
|
// host connects from ip as the pairing's Host and returns how long its
|
||||||
|
// handshake took, or the error that ended it.
|
||||||
|
func (l *pipeDoor) host(t *testing.T, ip string, within time.Duration) (time.Duration, error) {
|
||||||
|
t.Helper()
|
||||||
|
start := time.Now()
|
||||||
|
far := l.connect(t, ip)
|
||||||
|
s := tls.Server(far, &tls.Config{Certificates: []tls.Certificate{l.ca.serverCert(t, tcpServerName)},
|
||||||
|
NextProtos: []string{laneALPN}, MinVersion: tls.VersionTLS13, ClientAuth: tls.RequireAnyClientCert})
|
||||||
|
_ = s.SetDeadline(start.Add(within))
|
||||||
|
err := s.Handshake()
|
||||||
|
_ = s.SetDeadline(time.Time{})
|
||||||
|
return time.Since(start), err
|
||||||
|
}
|
||||||
|
|
||||||
|
func (l *pipeDoor) inflight() int {
|
||||||
|
l.d.mu.Lock()
|
||||||
|
defer l.d.mu.Unlock()
|
||||||
|
return l.d.inflight
|
||||||
|
}
|
||||||
|
|
||||||
|
// hostReconnectBound is how long the person's own Host may take to get a
|
||||||
|
// connection through a flooded door: its first try is admitted, so this is
|
||||||
|
// one handshake over an in-memory connection, with room for -race and a
|
||||||
|
// loaded machine. A refused try instead costs the Host's backoff (1 s, then
|
||||||
|
// doubling to 30 s, docs/host-connects.md).
|
||||||
|
const hostReconnectBound = 2 * time.Second
|
||||||
|
|
||||||
|
// SECURITY: 64 addresses flooding the door hold every slot strangers may
|
||||||
|
// take, and the person's own Host, connecting from the address it proved
|
||||||
|
// itself from, gets in at its first try, every time, within
|
||||||
|
// hostReconnectBound. The same Host from an address it never proved itself
|
||||||
|
// from waits like any stranger; what the reserve keeps is the address.
|
||||||
|
func TestTheOwnHostGetsInWhileStrangersFloodTheDoor(t *testing.T) {
|
||||||
|
pairingBox(t)
|
||||||
|
freshDoorMemory(t)
|
||||||
|
l := newPipeDoor(t)
|
||||||
|
const home = "198.51.100.7"
|
||||||
|
// Before the flood: a Host that connected once is known by its address.
|
||||||
|
if _, err := l.host(t, home, hostReconnectBound); err != nil {
|
||||||
|
t.Fatalf("the Host's first connection: %v", err)
|
||||||
|
}
|
||||||
|
doorWaitFor(t, 5*time.Second, "the connection in the pool", func() bool { return l.p.live.Load() == 1 })
|
||||||
|
if !doorKnownHost(home, time.Now()) {
|
||||||
|
t.Fatal("a Host's verified connection did not make its address known")
|
||||||
|
}
|
||||||
|
// The flood: 64 addresses, round and round, until every slot strangers
|
||||||
|
// may hold is held, with the real random early drop.
|
||||||
|
attempts := 0
|
||||||
|
for l.inflight() < strangersShare() {
|
||||||
|
if attempts++; attempts > 50000 {
|
||||||
|
t.Fatalf("the flood holds %d slots after %d connections", l.inflight(), attempts)
|
||||||
|
}
|
||||||
|
l.stranger(t, fmt.Sprintf("203.0.113.%d", attempts%64))
|
||||||
|
}
|
||||||
|
// Full for strangers: from any address, new or flooding, none gets in.
|
||||||
|
for i := 0; i < 64; i++ {
|
||||||
|
l.stranger(t, fmt.Sprintf("192.0.2.%d", i))
|
||||||
|
}
|
||||||
|
if n := l.inflight(); n != strangersShare() {
|
||||||
|
t.Fatalf("strangers hold %d slots, at most %d", n, strangersShare())
|
||||||
|
}
|
||||||
|
// The Host reconnects: each of its spare connections at the first try.
|
||||||
|
for i := 0; i < hostSpareConns; i++ {
|
||||||
|
took, err := l.host(t, home, hostReconnectBound)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("the Host's connection %d during the flood (after %d flood connections): %v", i, attempts, err)
|
||||||
|
}
|
||||||
|
if took > hostReconnectBound {
|
||||||
|
t.Fatalf("the Host's connection %d took %s, bound %s", i, took, hostReconnectBound)
|
||||||
|
}
|
||||||
|
t.Logf("the Host's connection %d through the flood (%d flood connections): %s", i, attempts, took)
|
||||||
|
}
|
||||||
|
doorWaitFor(t, 5*time.Second, "the Host's connections in the pool", func() bool {
|
||||||
|
return l.p.live.Load() == 1+hostSpareConns
|
||||||
|
})
|
||||||
|
// The same Host from an address it never proved itself from: refused.
|
||||||
|
if _, err := l.host(t, "198.51.100.99", hostReconnectBound); err == nil {
|
||||||
|
t.Fatal("an unknown address got past a door full for strangers")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A Host never seen before pairs through the window when nobody floods the
|
||||||
|
// door, even with a draw the early drop would refuse on, and its address is
|
||||||
|
// known from then on, so its lane connections count as its own.
|
||||||
|
func TestANewHostPairsWhenNobodyFloods(t *testing.T) {
|
||||||
|
pairingBox(t)
|
||||||
|
freshDoorMemory(t)
|
||||||
|
prev := doorDraw
|
||||||
|
doorDraw = alwaysDrops
|
||||||
|
t.Cleanup(func() { doorDraw = prev })
|
||||||
|
addr := freeDoorAddr(t)
|
||||||
|
code, out, res := openWindowFor(t, addr)
|
||||||
|
ca := newTestCA(t, "home host CA")
|
||||||
|
h := newStandinHost(t, ca, "home", "home.cseries.localhost", addr)
|
||||||
|
done, err := h.pair(formatWindowCode(code))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("%v\n%s", err, pairingAuditText(t))
|
||||||
|
}
|
||||||
|
if done.State != pairingActive {
|
||||||
|
t.Fatalf("done: %+v", done)
|
||||||
|
}
|
||||||
|
select {
|
||||||
|
case err := <-res:
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("pair --open: %v\n%s", err, out.String())
|
||||||
|
}
|
||||||
|
case <-time.After(10 * time.Second):
|
||||||
|
t.Fatal("pair --open never saw the pairing end its window")
|
||||||
|
}
|
||||||
|
host, _, _ := net.SplitHostPort(addr)
|
||||||
|
if !doorKnownHost(sourceKey(host), time.Now()) {
|
||||||
|
t.Fatal("a Host that paired through the window is not known by its address")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// SECURITY: only a verified handshake for a pairing the door still serves
|
||||||
|
// makes an address known: a certificate under another CA does not, nor the
|
||||||
|
// Host's own certificate once the door has stopped serving its pairing.
|
||||||
|
func TestOnlyAServedHostsVerifiedHandshakeMakesItsAddressKnown(t *testing.T) {
|
||||||
|
pairingBox(t)
|
||||||
|
freshDoorMemory(t)
|
||||||
|
l := newPipeDoor(t)
|
||||||
|
// handshake connects from ip with cert and waits for the door's verdict,
|
||||||
|
// the connection closing, so whatever the door does for it is done.
|
||||||
|
handshake := func(ip string, cert tls.Certificate) {
|
||||||
|
far := l.connect(t, ip)
|
||||||
|
s := tls.Server(far, &tls.Config{Certificates: []tls.Certificate{cert}, NextProtos: []string{laneALPN},
|
||||||
|
MinVersion: tls.VersionTLS13, ClientAuth: tls.RequireAnyClientCert})
|
||||||
|
_ = s.SetDeadline(time.Now().Add(5 * time.Second))
|
||||||
|
if err := s.Handshake(); err == nil {
|
||||||
|
_, _ = s.Read(make([]byte, 1))
|
||||||
|
}
|
||||||
|
_ = s.Close()
|
||||||
|
}
|
||||||
|
const impostorIP, stoppedIP = "198.51.100.60", "198.51.100.61"
|
||||||
|
impostor := newTestCA(t, "impostor")
|
||||||
|
handshake(impostorIP, impostor.serverCert(t, tcpServerName))
|
||||||
|
if doorKnownHost(impostorIP, time.Now()) {
|
||||||
|
t.Fatal("a certificate under another CA made its address known")
|
||||||
|
}
|
||||||
|
l.d.mu.Lock()
|
||||||
|
l.d.closed = true
|
||||||
|
l.d.mu.Unlock()
|
||||||
|
handshake(stoppedIP, l.ca.serverCert(t, tcpServerName))
|
||||||
|
if doorKnownHost(stoppedIP, time.Now()) {
|
||||||
|
t.Fatal("a handshake for a pairing the door no longer serves made its address known")
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,371 @@
|
|||||||
|
//go:build linux
|
||||||
|
|
||||||
|
package main
|
||||||
|
|
||||||
|
// A stand-in for a Host that connects to a server (docs/host-connects.md):
|
||||||
|
// it pairs through a window with the code, then keeps hostSpareConns idle
|
||||||
|
// lane connections open to the server's door and serves the lane routes of
|
||||||
|
// newLaneHost over them. The end-to-end run (hostdoor_e2e_linux_test.go)
|
||||||
|
// runs it in a network namespace behind a NAT.
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"crypto/rand"
|
||||||
|
"crypto/sha256"
|
||||||
|
"crypto/tls"
|
||||||
|
"crypto/x509"
|
||||||
|
"encoding/hex"
|
||||||
|
"encoding/json"
|
||||||
|
"encoding/pem"
|
||||||
|
"errors"
|
||||||
|
"fmt"
|
||||||
|
"io"
|
||||||
|
"log"
|
||||||
|
"net"
|
||||||
|
"net/http"
|
||||||
|
"os"
|
||||||
|
"path/filepath"
|
||||||
|
"sync"
|
||||||
|
"sync/atomic"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
// hostSpareConns is how many idle connections the stand-in keeps open, the
|
||||||
|
// number docs/host-connects.md asks a Host to keep.
|
||||||
|
const hostSpareConns = 4
|
||||||
|
|
||||||
|
type standinHost struct {
|
||||||
|
ca *testCA
|
||||||
|
handle string
|
||||||
|
name string
|
||||||
|
server string // the door, host:port
|
||||||
|
|
||||||
|
// pairing
|
||||||
|
pairLeaf tls.Certificate // leaf + CA, as a pairing presents them
|
||||||
|
lieLeaf bool // prove over another certificate (a relayed proof)
|
||||||
|
badProof bool // check the bastion's proof against the wrong code
|
||||||
|
bearerN atomic.Int32
|
||||||
|
mu sync.Mutex
|
||||||
|
done []windowDoneReq
|
||||||
|
csrs int
|
||||||
|
|
||||||
|
// lanes
|
||||||
|
lane *laneHost
|
||||||
|
handler http.Handler
|
||||||
|
laneTLS *tls.Config
|
||||||
|
dials atomic.Int32
|
||||||
|
idle atomic.Int32
|
||||||
|
open atomic.Int32
|
||||||
|
}
|
||||||
|
|
||||||
|
func newStandinHost(t *testing.T, ca *testCA, handle, name, server string) *standinHost {
|
||||||
|
t.Helper()
|
||||||
|
pl := ca.serverCert(t, tcpServerName)
|
||||||
|
pl.Certificate = append(pl.Certificate, ca.cert.Raw)
|
||||||
|
h := &standinHost{ca: ca, handle: handle, name: name, server: server, pairLeaf: pl}
|
||||||
|
h.lane, h.handler, h.laneTLS = newLaneHost(ca.serverCert(t, tcpServerName), ca)
|
||||||
|
return h
|
||||||
|
}
|
||||||
|
|
||||||
|
// pair connects to the door and pairs with code. It returns what the
|
||||||
|
// bastion's done said, or the error that ended the exchange.
|
||||||
|
func (h *standinHost) pair(code string) (windowDoneReq, error) {
|
||||||
|
norm := normalizeWindowCode(code)
|
||||||
|
raw, err := net.DialTimeout("tcp", h.server, 5*time.Second)
|
||||||
|
if err != nil {
|
||||||
|
return windowDoneReq{}, err
|
||||||
|
}
|
||||||
|
tc := tls.Server(raw, &tls.Config{Certificates: []tls.Certificate{h.pairLeaf}, NextProtos: []string{pairALPN},
|
||||||
|
MinVersion: tls.VersionTLS13})
|
||||||
|
_ = tc.SetDeadline(time.Now().Add(20 * time.Second))
|
||||||
|
if err := tc.Handshake(); err != nil {
|
||||||
|
_ = raw.Close()
|
||||||
|
return windowDoneReq{}, fmt.Errorf("handshake: %w", err)
|
||||||
|
}
|
||||||
|
leafSum := sha256.Sum256(h.pairLeaf.Certificate[0])
|
||||||
|
if h.lieLeaf {
|
||||||
|
leafSum = sha256.Sum256([]byte("another connection's certificate"))
|
||||||
|
}
|
||||||
|
caSum := sha256.Sum256(h.ca.cert.Raw)
|
||||||
|
var nb, nh []byte
|
||||||
|
gotDone := make(chan windowDoneReq, 1)
|
||||||
|
mux := http.NewServeMux()
|
||||||
|
mux.HandleFunc("/v1/pair/hello", func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
var req windowHelloReq
|
||||||
|
_ = json.NewDecoder(r.Body).Decode(&req)
|
||||||
|
nb, _ = hex.DecodeString(req.Nonce)
|
||||||
|
nh = make([]byte, 32)
|
||||||
|
_, _ = rand.Read(nh)
|
||||||
|
_ = json.NewEncoder(w).Encode(windowHelloResp{V: 1, HostHandle: h.handle, HostName: h.name,
|
||||||
|
Nonce: hex.EncodeToString(nh), Proof: windowProof(norm, "host", leafSum[:], caSum[:], nb, nh)})
|
||||||
|
})
|
||||||
|
mux.HandleFunc("/v1/pair/redeem", func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
var req windowRedeemReq
|
||||||
|
_ = json.NewDecoder(r.Body).Decode(&req)
|
||||||
|
key := norm
|
||||||
|
if h.badProof {
|
||||||
|
key = "0000000000000000000Z"
|
||||||
|
}
|
||||||
|
real := sha256.Sum256(h.pairLeaf.Certificate[0])
|
||||||
|
if req.Proof != windowProof(key, "bastion", real[:], caSum[:], nb, nh) {
|
||||||
|
w.WriteHeader(http.StatusForbidden)
|
||||||
|
_ = json.NewEncoder(w).Encode(map[string]string{"error": "this server did not prove the code"})
|
||||||
|
return
|
||||||
|
}
|
||||||
|
h.mu.Lock()
|
||||||
|
h.csrs++
|
||||||
|
h.mu.Unlock()
|
||||||
|
_ = json.NewEncoder(w).Encode(map[string]any{"operator_cert": h.ca.signCSR(req.OperatorCSR), "ca_cert": h.ca.pem,
|
||||||
|
"bearer": fmt.Sprintf("mcp_dials_%s_%d", h.handle, h.bearerN.Add(1)), "transport": windowTransport,
|
||||||
|
"host_handle": h.handle, "host_name": h.name})
|
||||||
|
})
|
||||||
|
mux.HandleFunc("/v1/pair/done", func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
var req windowDoneReq
|
||||||
|
_ = json.NewDecoder(r.Body).Decode(&req)
|
||||||
|
h.mu.Lock()
|
||||||
|
h.done = append(h.done, req)
|
||||||
|
h.mu.Unlock()
|
||||||
|
_, _ = w.Write([]byte("{}"))
|
||||||
|
gotDone <- req
|
||||||
|
})
|
||||||
|
ln := &oneConnListener{c: tc, closed: make(chan struct{})}
|
||||||
|
srv := &http.Server{Handler: mux, ErrorLog: log.New(io.Discard, "", 0)}
|
||||||
|
go func() { _ = srv.Serve(ln) }()
|
||||||
|
defer srv.Close()
|
||||||
|
select {
|
||||||
|
case d := <-gotDone:
|
||||||
|
return d, nil
|
||||||
|
case <-ln.gone():
|
||||||
|
return windowDoneReq{}, errors.New("the server closed the pairing connection")
|
||||||
|
case <-time.After(20 * time.Second):
|
||||||
|
return windowDoneReq{}, errors.New("no done within 20 s")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// oneConnListener hands out one connection, then blocks until closed.
|
||||||
|
type oneConnListener struct {
|
||||||
|
c net.Conn
|
||||||
|
once sync.Once
|
||||||
|
closed chan struct{}
|
||||||
|
cmu sync.Mutex
|
||||||
|
shut bool
|
||||||
|
}
|
||||||
|
|
||||||
|
func (l *oneConnListener) Accept() (net.Conn, error) {
|
||||||
|
var c net.Conn
|
||||||
|
l.once.Do(func() { c = &watchClose{Conn: l.c, l: l} })
|
||||||
|
if c != nil {
|
||||||
|
return c, nil
|
||||||
|
}
|
||||||
|
<-l.closed
|
||||||
|
return nil, net.ErrClosed
|
||||||
|
}
|
||||||
|
|
||||||
|
func (l *oneConnListener) gone() <-chan struct{} { return l.closed }
|
||||||
|
|
||||||
|
func (l *oneConnListener) Close() error {
|
||||||
|
l.cmu.Lock()
|
||||||
|
defer l.cmu.Unlock()
|
||||||
|
if !l.shut {
|
||||||
|
l.shut = true
|
||||||
|
close(l.closed)
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func (l *oneConnListener) Addr() net.Addr { return l.c.LocalAddr() }
|
||||||
|
|
||||||
|
type watchClose struct {
|
||||||
|
net.Conn
|
||||||
|
l *oneConnListener
|
||||||
|
}
|
||||||
|
|
||||||
|
func (w *watchClose) Read(b []byte) (int, error) {
|
||||||
|
n, err := w.Conn.Read(b)
|
||||||
|
var ne net.Error
|
||||||
|
if err != nil && !(errors.As(err, &ne) && ne.Timeout()) {
|
||||||
|
_ = w.l.Close() // the http server's own read aborts are timeouts
|
||||||
|
}
|
||||||
|
return n, err
|
||||||
|
}
|
||||||
|
|
||||||
|
// serveLanes keeps hostSpareConns idle connections open to the door until
|
||||||
|
// ctx ends, serving the lane routes over each, and closes them all at the end
|
||||||
|
// (a Host that stops). Redials back off from 100 ms to 2 s.
|
||||||
|
func (h *standinHost) serveLanes(ctx context.Context) {
|
||||||
|
acc := make(chan net.Conn)
|
||||||
|
ln := &chanListener{c: acc, done: ctx.Done(), addr: &net.TCPAddr{}}
|
||||||
|
srv := &http.Server{Handler: h.handler, ErrorLog: log.New(io.Discard, "", 0)}
|
||||||
|
go func() { _ = srv.Serve(ln) }()
|
||||||
|
var all sync.Map
|
||||||
|
kick := make(chan struct{}, 64)
|
||||||
|
wait := 100 * time.Millisecond
|
||||||
|
for ctx.Err() == nil {
|
||||||
|
if h.idle.Load() >= hostSpareConns || h.open.Load() >= 64 {
|
||||||
|
select {
|
||||||
|
case <-kick:
|
||||||
|
case <-time.After(time.Second):
|
||||||
|
case <-ctx.Done():
|
||||||
|
}
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
h.dials.Add(1)
|
||||||
|
d := net.Dialer{Timeout: 5 * time.Second, KeepAlive: 25 * time.Second}
|
||||||
|
raw, err := d.DialContext(ctx, "tcp", h.server)
|
||||||
|
if err == nil {
|
||||||
|
tc := tls.Server(raw, h.laneTLS)
|
||||||
|
_ = tc.SetDeadline(time.Now().Add(10 * time.Second))
|
||||||
|
if err = tc.HandshakeContext(ctx); err == nil {
|
||||||
|
_ = tc.SetDeadline(time.Time{})
|
||||||
|
h.idle.Add(1)
|
||||||
|
h.open.Add(1)
|
||||||
|
c := &usedConn{Conn: tc, h: h, kick: kick}
|
||||||
|
all.Store(c, true)
|
||||||
|
select {
|
||||||
|
case acc <- c:
|
||||||
|
case <-ctx.Done():
|
||||||
|
_ = c.Close()
|
||||||
|
}
|
||||||
|
wait = 100 * time.Millisecond
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
_ = raw.Close()
|
||||||
|
}
|
||||||
|
select {
|
||||||
|
case <-time.After(wait):
|
||||||
|
case <-ctx.Done():
|
||||||
|
}
|
||||||
|
wait = min(2*wait, 2*time.Second)
|
||||||
|
}
|
||||||
|
_ = srv.Close()
|
||||||
|
all.Range(func(k, _ any) bool { _ = k.(*usedConn).Close(); return true })
|
||||||
|
}
|
||||||
|
|
||||||
|
// usedConn tells the stand-in when a lane first speaks on a connection (it
|
||||||
|
// is no longer idle) and when it closes.
|
||||||
|
type usedConn struct {
|
||||||
|
net.Conn
|
||||||
|
h *standinHost
|
||||||
|
kick chan struct{}
|
||||||
|
used atomic.Bool
|
||||||
|
closed atomic.Bool
|
||||||
|
}
|
||||||
|
|
||||||
|
func (c *usedConn) Read(b []byte) (int, error) {
|
||||||
|
n, err := c.Conn.Read(b)
|
||||||
|
if n > 0 && c.used.CompareAndSwap(false, true) {
|
||||||
|
c.h.idle.Add(-1)
|
||||||
|
c.nudge()
|
||||||
|
}
|
||||||
|
return n, err
|
||||||
|
}
|
||||||
|
|
||||||
|
func (c *usedConn) Close() error {
|
||||||
|
if c.closed.CompareAndSwap(false, true) {
|
||||||
|
if c.used.CompareAndSwap(false, true) {
|
||||||
|
c.h.idle.Add(-1)
|
||||||
|
}
|
||||||
|
c.h.open.Add(-1)
|
||||||
|
c.nudge()
|
||||||
|
}
|
||||||
|
return c.Conn.Close()
|
||||||
|
}
|
||||||
|
|
||||||
|
func (c *usedConn) nudge() {
|
||||||
|
select {
|
||||||
|
case c.kick <- struct{}{}:
|
||||||
|
default:
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
type chanListener struct {
|
||||||
|
c chan net.Conn
|
||||||
|
done <-chan struct{}
|
||||||
|
addr net.Addr
|
||||||
|
}
|
||||||
|
|
||||||
|
func (l *chanListener) Accept() (net.Conn, error) {
|
||||||
|
select {
|
||||||
|
case c := <-l.c:
|
||||||
|
return c, nil
|
||||||
|
case <-l.done:
|
||||||
|
return nil, net.ErrClosed
|
||||||
|
}
|
||||||
|
}
|
||||||
|
func (l *chanListener) Close() error { return nil }
|
||||||
|
func (l *chanListener) Addr() net.Addr { return l.addr }
|
||||||
|
|
||||||
|
// TestStandinHostProcess is the stand-in as a process of its own, for the
|
||||||
|
// end-to-end run behind a NAT (scripts/e2e-host-connects.sh) and on another
|
||||||
|
// machine's bastion. Skipped unless STANDIN_MODE is set:
|
||||||
|
//
|
||||||
|
// STANDIN_MODE=pair STANDIN_STATE=<dir> STANDIN_SERVER=<host:port> STANDIN_CODE=<code>
|
||||||
|
// STANDIN_MODE=serve STANDIN_STATE=<dir> STANDIN_SERVER=<host:port>
|
||||||
|
//
|
||||||
|
// The CA is kept in STANDIN_STATE, so a restarted stand-in is the same Host.
|
||||||
|
func TestStandinHostProcess(t *testing.T) {
|
||||||
|
mode := os.Getenv("STANDIN_MODE")
|
||||||
|
if mode == "" {
|
||||||
|
t.Skip("the stand-in Host process (scripts/e2e-host-connects.sh)")
|
||||||
|
}
|
||||||
|
dir, server := os.Getenv("STANDIN_STATE"), os.Getenv("STANDIN_SERVER")
|
||||||
|
handle := firstNonEmpty(os.Getenv("STANDIN_HANDLE"), "home")
|
||||||
|
name := firstNonEmpty(os.Getenv("STANDIN_NAME"), handle+".cseries.localhost")
|
||||||
|
ca := standinCA(t, dir, name)
|
||||||
|
h := newStandinHost(t, ca, handle, name, server)
|
||||||
|
logf := func(f string, a ...any) {
|
||||||
|
fmt.Printf(time.Now().UTC().Format("15:04:05.000Z ")+"standin "+f+"\n", a...)
|
||||||
|
}
|
||||||
|
switch mode {
|
||||||
|
case "pair":
|
||||||
|
d, err := h.pair(os.Getenv("STANDIN_CODE"))
|
||||||
|
if err != nil {
|
||||||
|
logf("PAIR FAILED: %v", err)
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
logf("PAIRED: done=%+v csrs=%d", d, h.csrs)
|
||||||
|
case "serve":
|
||||||
|
h.lane.jobs <- []byte(`{"harness_id":"e2e","mode":"echo","prompt":"a job over a connection the Host opened"}`)
|
||||||
|
ctx, cancel := context.WithCancel(context.Background())
|
||||||
|
defer cancel()
|
||||||
|
go h.serveLanes(ctx)
|
||||||
|
var lb, lh int
|
||||||
|
for {
|
||||||
|
time.Sleep(time.Second)
|
||||||
|
hellos, beats := h.lane.snapshot()
|
||||||
|
if len(beats) != lb || len(hellos) != lh {
|
||||||
|
logf("lanes: dials=%d open=%d idle=%d beats=%d worker-hellos=%d", h.dials.Load(), h.open.Load(), h.idle.Load(), len(beats), len(hellos))
|
||||||
|
lb, lh = len(beats), len(hellos)
|
||||||
|
}
|
||||||
|
select {
|
||||||
|
case r := <-h.lane.replies:
|
||||||
|
logf("HARNESS JOB served over a Host-opened connection: %s", r)
|
||||||
|
default:
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// standinCA is the stand-in's CA, made once and kept in dir.
|
||||||
|
func standinCA(t *testing.T, dir, cn string) *testCA {
|
||||||
|
_ = os.MkdirAll(dir, 0o700)
|
||||||
|
cp, kp := filepath.Join(dir, "ca.pem"), filepath.Join(dir, "ca.key")
|
||||||
|
if c, err := os.ReadFile(cp); err == nil {
|
||||||
|
k, _ := os.ReadFile(kp)
|
||||||
|
cb, _ := pem.Decode(c)
|
||||||
|
kb, _ := pem.Decode(k)
|
||||||
|
if cb != nil && kb != nil {
|
||||||
|
cert, err1 := x509.ParseCertificate(cb.Bytes)
|
||||||
|
key, err2 := x509.ParseECPrivateKey(kb.Bytes)
|
||||||
|
if err1 == nil && err2 == nil {
|
||||||
|
return &testCA{cert: cert, key: key, pem: string(c)}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
ca := newTestCA(t, cn+" stand-in CA")
|
||||||
|
kd, _ := x509.MarshalECPrivateKey(ca.key)
|
||||||
|
_ = os.WriteFile(cp, []byte(ca.pem), 0o600)
|
||||||
|
_ = os.WriteFile(kp, pem.EncodeToMemory(&pem.Block{Type: "EC PRIVATE KEY", Bytes: kd}), 0o600)
|
||||||
|
return ca
|
||||||
|
}
|
||||||
@@ -915,7 +915,7 @@ func TestDeviceApproveAllSignsOnlyWhatWasShown(t *testing.T) {
|
|||||||
if err := cmdDeviceApprove("all"); err == nil {
|
if err := cmdDeviceApprove("all"); err == nil {
|
||||||
t.Fatal("nothing shown yet: all must refuse")
|
t.Fatal("nothing shown yet: all must refuse")
|
||||||
}
|
}
|
||||||
if err := cmdDeviceApprovals(); err != nil {
|
if err := cmdDeviceApprovals(nil); err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
b := file("harness:run") // filed AFTER the person looked
|
b := file("harness:run") // filed AFTER the person looked
|
||||||
|
|||||||
@@ -74,3 +74,83 @@ func TestInstallPs1ElevatesForTheWholeMachineUnderPwsh(t *testing.T) {
|
|||||||
t.Fatalf("%v\n%s", err, out)
|
t.Fatalf("%v\n%s", err, out)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// A whole-machine install replaces a program the tray holds open. The tray
|
||||||
|
// runs from the service's own file in every session, Windows will not replace
|
||||||
|
// a running program, and the install stopped with "Cannot create a file when
|
||||||
|
// that file already exists." with the service it had stopped left stopped.
|
||||||
|
// The program is moved aside instead, a failure starts the service again, and
|
||||||
|
// this person's tray is started from the new program.
|
||||||
|
//
|
||||||
|
// MUTATIONS (run with testdata/install_ps1_swap.ps1 under pwsh): drop the move
|
||||||
|
// aside from Install-Program; drop Start-Service from Stop-InstallFailed; drop
|
||||||
|
// the session filter from Restart-Tray; let Unregister-ScheduledTask's failure
|
||||||
|
// escape; drop the .old/.bak exclusion from the earlier-install stop. RESULT:
|
||||||
|
// each red.
|
||||||
|
func TestInstallPs1ReplacesAProgramTheTrayHoldsOpen(t *testing.T) {
|
||||||
|
raw, err := os.ReadFile(filepath.Join("..", "deploy", "install.ps1"))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
s := string(raw)
|
||||||
|
for _, want := range []string{
|
||||||
|
"Install-Program $tmp $exe",
|
||||||
|
"Move-Item -LiteralPath $target -Destination $aside",
|
||||||
|
`foreach ($name in @("$target.old", "$target.bak"))`,
|
||||||
|
"$stoppedService = $true",
|
||||||
|
`Stop-InstallFailed $stoppedService "The Windows service could not be registered`,
|
||||||
|
"Start-Service -Name 'PrivataeBastion' -ErrorAction Stop",
|
||||||
|
"if (Restart-Tray $installedExe)",
|
||||||
|
// The logon task is removed with the service stopped: a failure starts it again.
|
||||||
|
`Stop-InstallFailed $stoppedService ("The logon task from an earlier install could not be removed`,
|
||||||
|
// The trays running from the program moved aside are not an earlier install.
|
||||||
|
"($asideNames -notcontains $_.Path)",
|
||||||
|
} {
|
||||||
|
if !strings.Contains(s, want) {
|
||||||
|
t.Errorf("install.ps1 lacks %q", want)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if strings.Contains(s, "Move-Item -Force -Path $tmp -Destination $exe") {
|
||||||
|
t.Error("install.ps1 moves the download over the program in place, which fails while a tray runs it")
|
||||||
|
}
|
||||||
|
// A per-user reinstall with no -Pair stops the copy already running (the
|
||||||
|
// old program, moved aside) before it starts the task again, or it would
|
||||||
|
// say "running now" over the old version.
|
||||||
|
//
|
||||||
|
// MUTATION: drop the Stop-Process loop from that branch. RESULT: red.
|
||||||
|
if i := strings.Index(s, "# Started now, not only at the next sign-in"); i < 0 {
|
||||||
|
t.Error("install.ps1 no longer starts a per-user bastion at install")
|
||||||
|
} else if seg := s[i:]; !strings.Contains(seg[:strings.Index(seg, "Start-ScheduledTask")], "Stop-Process -Id $_.Id -Force") {
|
||||||
|
t.Error("a per-user reinstall starts the task without stopping the copy already running the old program")
|
||||||
|
}
|
||||||
|
if strings.Contains(s, `throw "could not register the Windows service`) {
|
||||||
|
t.Error("a failed service registration throws with the service it stopped left stopped")
|
||||||
|
}
|
||||||
|
// The aside names are ones the bastion clears at its next start.
|
||||||
|
src, err := os.ReadFile("update.go")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if !strings.Contains(string(src), `[]string{".old", ".new", ".bak"}`) {
|
||||||
|
t.Error("cleanupStaleBinaries no longer clears .old and .bak, which the installer leaves beside the program")
|
||||||
|
}
|
||||||
|
// The tray is started from the ordinary account, after the elevated step.
|
||||||
|
if r, e := strings.Index(s, "if (Restart-Tray $installedExe)"), strings.Index(s, "-Verb RunAs"); r < 0 || e < 0 || r < e {
|
||||||
|
t.Error("the tray is not restarted after the elevated step")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Install-Program, Stop-InstallFailed and Restart-Tray, run by pwsh with
|
||||||
|
// Windows stood in (testdata/install_ps1_swap.ps1). Skipped where pwsh is not
|
||||||
|
// installed.
|
||||||
|
func TestInstallPs1SwapRunsUnderPwsh(t *testing.T) {
|
||||||
|
pwsh, err := exec.LookPath("pwsh")
|
||||||
|
if err != nil {
|
||||||
|
t.Skip("pwsh is not installed: install.ps1's swap is checked only by TestInstallPs1ReplacesAProgramTheTrayHoldsOpen here")
|
||||||
|
}
|
||||||
|
out, err := exec.Command(pwsh, "-NoProfile", "-NonInteractive", "-File",
|
||||||
|
filepath.Join("testdata", "install_ps1_swap.ps1"), filepath.Join("..", "deploy", "install.ps1")).CombinedOutput()
|
||||||
|
if err != nil || !strings.HasPrefix(strings.TrimSpace(string(out)), "ok:") {
|
||||||
|
t.Fatalf("%v\n%s", err, out)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|||||||
@@ -377,6 +377,10 @@ exit 0
|
|||||||
"id": `case "$1" in -u) echo 1000 ;; -un) echo tester ;; *) echo "uid=1000(tester)" ;; esac`,
|
"id": `case "$1" in -u) echo 1000 ;; -un) echo tester ;; *) echo "uid=1000(tester)" ;; esac`,
|
||||||
"curl": `for a; do o=$a; done; case "$2" in */version.json) cp "$STAND/version.json" "$o" ;; *) cp "$STAND/bastion.bin" "$o" ;; esac`,
|
"curl": `for a; do o=$a; done; case "$2" in */version.json) cp "$STAND/version.json" "$o" ;; *) cp "$STAND/bastion.bin" "$o" ;; esac`,
|
||||||
"printf": `exec /usr/bin/printf "$@"`,
|
"printf": `exec /usr/bin/printf "$@"`,
|
||||||
|
// No openssl that does Ed25519 here, so the release signature is
|
||||||
|
// noted as not checked (install_sig_sh_test.go tests the check): this
|
||||||
|
// stand-in manifest is signed by no release key.
|
||||||
|
"openssl": `exit 1`,
|
||||||
}
|
}
|
||||||
for name, body := range stand {
|
for name, body := range stand {
|
||||||
s.write(t, filepath.Join(s.path, name), "#!/bin/sh\n"+record+body+"\n")
|
s.write(t, filepath.Join(s.path, name), "#!/bin/sh\n"+record+body+"\n")
|
||||||
|
|||||||
@@ -0,0 +1,327 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"bytes"
|
||||||
|
"crypto/ed25519"
|
||||||
|
"crypto/rand"
|
||||||
|
"crypto/sha256"
|
||||||
|
"encoding/base64"
|
||||||
|
"encoding/hex"
|
||||||
|
"net/http"
|
||||||
|
"net/http/httptest"
|
||||||
|
"os"
|
||||||
|
"os/exec"
|
||||||
|
"path/filepath"
|
||||||
|
"regexp"
|
||||||
|
"strings"
|
||||||
|
"testing"
|
||||||
|
)
|
||||||
|
|
||||||
|
// ed25519SPKIPrefix is the DER that wraps a raw Ed25519 public key in the
|
||||||
|
// SubjectPublicKeyInfo openssl reads (RFC 8410).
|
||||||
|
var ed25519SPKIPrefix = []byte{0x30, 0x2a, 0x30, 0x05, 0x06, 0x03, 0x2b, 0x65, 0x70, 0x03, 0x21, 0x00}
|
||||||
|
|
||||||
|
func installShVar(t *testing.T, name string) string {
|
||||||
|
t.Helper()
|
||||||
|
raw, err := os.ReadFile(filepath.Join("..", "deploy", "install.sh"))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
m := regexp.MustCompile(`(?m)^` + name + `='([^']*)'$`).FindSubmatch(raw)
|
||||||
|
if m == nil {
|
||||||
|
t.Fatalf("install.sh sets no %s", name)
|
||||||
|
}
|
||||||
|
return string(m[1])
|
||||||
|
}
|
||||||
|
|
||||||
|
func spkiToRaw(t *testing.T, b64 string) []byte {
|
||||||
|
t.Helper()
|
||||||
|
der, err := base64.StdEncoding.DecodeString(b64)
|
||||||
|
if err != nil || len(der) != len(ed25519SPKIPrefix)+ed25519.PublicKeySize || !bytes.HasPrefix(der, ed25519SPKIPrefix) {
|
||||||
|
t.Fatalf("not an Ed25519 public key: %q (%v)", b64, err)
|
||||||
|
}
|
||||||
|
return der[len(ed25519SPKIPrefix):]
|
||||||
|
}
|
||||||
|
|
||||||
|
// The installer checks a release with exactly the keys a bastion checks its
|
||||||
|
// updates with: a key rotated in release_sign.go and not here would make
|
||||||
|
// every install refuse, or accept a key the bastions no longer do.
|
||||||
|
func TestInstallShPinsTheReleaseKeysTheBastionChecks(t *testing.T) {
|
||||||
|
keys := strings.Fields(installShVar(t, "RELEASE_KEYS"))
|
||||||
|
if len(keys) != len(productionReleaseKeys) {
|
||||||
|
t.Fatalf("install.sh pins %d release keys, release_sign.go %d", len(keys), len(productionReleaseKeys))
|
||||||
|
}
|
||||||
|
for i, k := range keys {
|
||||||
|
if got := base64.StdEncoding.EncodeToString(spkiToRaw(t, k)); got != productionReleaseKeys[i] {
|
||||||
|
t.Errorf("install.sh key %d is %s, release_sign.go has %s", i, got, productionReleaseKeys[i])
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The probe is what tells "this openssl cannot check" from "the signature is
|
||||||
|
// wrong". A probe that did not verify would make every system read as unable,
|
||||||
|
// and every install skip the signature with a note.
|
||||||
|
func TestInstallShProbeSignatureVerifies(t *testing.T) {
|
||||||
|
pub := spkiToRaw(t, installShVar(t, "SIG_PROBE_KEY"))
|
||||||
|
sig, err := base64.StdEncoding.DecodeString(installShVar(t, "SIG_PROBE_SIG"))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if !ed25519.Verify(ed25519.PublicKey(pub), []byte("privatae-installer-probe-v1\n"), sig) {
|
||||||
|
t.Fatal("the probe signature does not verify under the probe key")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// sigHarness is release_signature_check from install.sh, with the release
|
||||||
|
// keys replaced by key and the download host by base, run on manifest.
|
||||||
|
func sigHarness(t *testing.T, pub ed25519.PublicKey, base string, manifest []byte, onlyPATH ...bool) (string, error) {
|
||||||
|
t.Helper()
|
||||||
|
raw, err := os.ReadFile(filepath.Join("..", "deploy", "install.sh"))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
s := string(raw)
|
||||||
|
vars := regexp.MustCompile(`(?ms)^RELEASE_KEYS=.*?^SIG_PROBE_SIG='[^']*'$`).FindString(s)
|
||||||
|
fn := regexp.MustCompile(`(?ms)^release_signature_check\(\) \{.*?^\}$`).FindString(s)
|
||||||
|
if vars == "" || fn == "" {
|
||||||
|
t.Fatal("install.sh's release_signature_check or its keys moved")
|
||||||
|
}
|
||||||
|
if len(onlyPATH) > 0 && onlyPATH[0] {
|
||||||
|
// Only the openssl on PATH: a Mac with Homebrew's openssl@3 would
|
||||||
|
// otherwise find a real one at its fixed path.
|
||||||
|
loop := regexp.MustCompile(`(?m)^ for c in openssl [^;]*; do$`)
|
||||||
|
if !loop.MatchString(fn) {
|
||||||
|
t.Fatal("install.sh's openssl candidates moved")
|
||||||
|
}
|
||||||
|
fn = loop.ReplaceAllString(fn, " for c in openssl; do")
|
||||||
|
}
|
||||||
|
der := append(append([]byte{}, ed25519SPKIPrefix...), pub...)
|
||||||
|
vars = regexp.MustCompile(`(?m)^RELEASE_KEYS='[^']*'$`).ReplaceAllString(vars,
|
||||||
|
"RELEASE_KEYS='"+base64.StdEncoding.EncodeToString(der)+"'")
|
||||||
|
d := t.TempDir()
|
||||||
|
if err := os.WriteFile(filepath.Join(d, "man.json"), manifest, 0o600); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if err := os.Mkdir(filepath.Join(d, "v"), 0o700); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
script := "die() { echo \"ERROR: $*\" >&2; exit 1; }\nSHACMD=sha256sum\nsha_of() { $SHACMD \"$1\" | cut -d' ' -f1; }\n" +
|
||||||
|
"base='" + base + "'\n" + vars + "\n" + fn + "\nrelease_signature_check \"$1\" \"$2\"\necho RETURNED\n"
|
||||||
|
sh := filepath.Join(d, "h.sh")
|
||||||
|
if err := os.WriteFile(sh, []byte(script), 0o600); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
out, err := exec.Command("sh", sh, filepath.Join(d, "man.json"), filepath.Join(d, "v")).CombinedOutput()
|
||||||
|
return string(out), err
|
||||||
|
}
|
||||||
|
|
||||||
|
func releaseSigFor(priv ed25519.PrivateKey, manifest []byte, version string) (name, b64 string) {
|
||||||
|
sum := sha256.Sum256(manifest)
|
||||||
|
stmt := releaseStatement("bastion", version, hex.EncodeToString(sum[:]))
|
||||||
|
return "/version.json." + hex.EncodeToString(sum[:8]) + ".sig",
|
||||||
|
base64.StdEncoding.EncodeToString(ed25519.Sign(priv, stmt))
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestInstallShRefusesAReleaseWhoseSignatureDoesNotVerify(t *testing.T) {
|
||||||
|
requireTools(t, "sh", "openssl", "sha256sum", "curl")
|
||||||
|
pub, priv, _ := ed25519.GenerateKey(rand.Reader)
|
||||||
|
_, other, _ := ed25519.GenerateKey(rand.Reader)
|
||||||
|
manifest := []byte("{\n \"version\": \"9.9.9\",\n \"binaries\": {}\n}\n")
|
||||||
|
name, good := releaseSigFor(priv, manifest, "9.9.9")
|
||||||
|
_, wrongKey := releaseSigFor(other, manifest, "9.9.9")
|
||||||
|
_, wrongVersion := releaseSigFor(priv, manifest, "9.9.8")
|
||||||
|
serve := map[string]string{}
|
||||||
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
v, ok := serve[r.URL.Path]
|
||||||
|
if !ok {
|
||||||
|
http.NotFound(w, r)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
_, _ = w.Write([]byte(v))
|
||||||
|
}))
|
||||||
|
defer srv.Close()
|
||||||
|
|
||||||
|
// The check needs an openssl that does Ed25519; without one it only
|
||||||
|
// notes it, which TestInstallShSaysWhenItCannotCheckTheSignature covers.
|
||||||
|
// Whether this one can is asked of openssl here, never read off the
|
||||||
|
// installer's note: a probe broken in install.sh would print that note on
|
||||||
|
// every machine, and this test would skip while every install skipped the
|
||||||
|
// signature.
|
||||||
|
// MUTATION: break the probe's pkeyutl flags in install.sh. RESULT: red here
|
||||||
|
// (it skipped before).
|
||||||
|
if !opensslChecksEd25519(t) {
|
||||||
|
skipOrFail(t, "the openssl here does not check Ed25519 signatures")
|
||||||
|
}
|
||||||
|
serve[name] = good
|
||||||
|
out, err := sigHarness(t, pub, srv.URL, manifest)
|
||||||
|
if err != nil || strings.Contains(out, "no openssl here can check") ||
|
||||||
|
!strings.Contains(out, "Release signature verified (version 9.9.9)") || !strings.Contains(out, "RETURNED") {
|
||||||
|
t.Fatalf("a good signature: %v\n%s", err, out)
|
||||||
|
}
|
||||||
|
for what, sig := range map[string]string{"another key's": wrongKey, "another version's": wrongVersion} {
|
||||||
|
serve[name] = sig
|
||||||
|
// MUTATION: return 0 after the key loop. RESULT: red, these install.
|
||||||
|
if out, err := sigHarness(t, pub, srv.URL, manifest); err == nil || strings.Contains(out, "RETURNED") ||
|
||||||
|
!strings.Contains(out, "does not verify") {
|
||||||
|
t.Errorf("%s signature: %v\n%s", what, err, out)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
serve[name] = "not base64 at all !"
|
||||||
|
if out, err := sigHarness(t, pub, srv.URL, manifest); err == nil || !strings.Contains(out, "malformed") {
|
||||||
|
t.Errorf("a malformed signature: %v\n%s", err, out)
|
||||||
|
}
|
||||||
|
delete(serve, name)
|
||||||
|
if out, err := sigHarness(t, pub, srv.URL, manifest); err == nil || !strings.Contains(out, "cannot fetch the release's signature") {
|
||||||
|
t.Errorf("no signature: %v\n%s", err, out)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// opensslChecksEd25519 says, without install.sh, whether the openssl on PATH
|
||||||
|
// verifies an Ed25519 signature made here, and refuses one over another
|
||||||
|
// message.
|
||||||
|
func opensslChecksEd25519(t *testing.T) bool {
|
||||||
|
t.Helper()
|
||||||
|
if _, err := exec.LookPath("openssl"); err != nil {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
pub, priv, _ := ed25519.GenerateKey(rand.Reader)
|
||||||
|
der := append(append([]byte{}, ed25519SPKIPrefix...), pub...)
|
||||||
|
d := t.TempDir()
|
||||||
|
files := map[string][]byte{
|
||||||
|
"k.pem": []byte("-----BEGIN PUBLIC KEY-----\n" + base64.StdEncoding.EncodeToString(der) + "\n-----END PUBLIC KEY-----\n"),
|
||||||
|
"m": []byte("capability\n"),
|
||||||
|
"other": []byte("capability?\n"),
|
||||||
|
"s": ed25519.Sign(priv, []byte("capability\n")),
|
||||||
|
}
|
||||||
|
for n, b := range files {
|
||||||
|
if err := os.WriteFile(filepath.Join(d, n), b, 0o600); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
verify := func(msg string) bool {
|
||||||
|
return exec.Command("openssl", "pkeyutl", "-verify", "-pubin", "-inkey", filepath.Join(d, "k.pem"), "-rawin",
|
||||||
|
"-in", filepath.Join(d, msg), "-sigfile", filepath.Join(d, "s")).Run() == nil
|
||||||
|
}
|
||||||
|
return verify("m") && !verify("other")
|
||||||
|
}
|
||||||
|
|
||||||
|
// An openssl that passes every signature is no check: the installer must not
|
||||||
|
// take it for one and print "verified" over a signature no pinned key made.
|
||||||
|
// It is set aside like one that cannot check; a later candidate that can
|
||||||
|
// still checks.
|
||||||
|
func TestInstallShTakesNoOpensslThatPassesEverySignature(t *testing.T) {
|
||||||
|
requireTools(t, "sh", "openssl", "sha256sum", "curl")
|
||||||
|
systemSSL, _ := exec.LookPath("openssl")
|
||||||
|
fake := t.TempDir()
|
||||||
|
if err := os.WriteFile(filepath.Join(fake, "openssl"),
|
||||||
|
[]byte("#!/bin/sh\ncase \"$1\" in pkeyutl) exit 0 ;; esac\nexec '"+systemSSL+"' \"$@\"\n"), 0o700); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
t.Setenv("PATH", fake+string(os.PathListSeparator)+os.Getenv("PATH"))
|
||||||
|
pub, _, _ := ed25519.GenerateKey(rand.Reader)
|
||||||
|
_, other, _ := ed25519.GenerateKey(rand.Reader)
|
||||||
|
manifest := []byte("{\n \"version\": \"9.9.9\",\n \"binaries\": {}\n}\n")
|
||||||
|
name, forged := releaseSigFor(other, manifest, "9.9.9")
|
||||||
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
if r.URL.Path != name {
|
||||||
|
http.NotFound(w, r)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
_, _ = w.Write([]byte(forged))
|
||||||
|
}))
|
||||||
|
defer srv.Close()
|
||||||
|
// MUTATION: drop the probe's second verify (the one that must fail).
|
||||||
|
// RESULT: red, "Release signature verified" over the forged signature.
|
||||||
|
out, _ := sigHarness(t, pub, srv.URL, manifest)
|
||||||
|
if strings.Contains(out, "Release signature verified") ||
|
||||||
|
!(strings.Contains(out, "no openssl here can check") || strings.Contains(out, "does not verify")) {
|
||||||
|
t.Errorf("an openssl that passes everything was taken for a check:\n%s", out)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// SECURITY.md sends a reader who does not trust our website to a copy of
|
||||||
|
// install.sh read from this repository. Run without sudo, that copy installs
|
||||||
|
// for the whole machine through a root step that fetches the installer from
|
||||||
|
// the website again (whole_machine_script) and runs that, so the copy read
|
||||||
|
// checks nothing itself. The page has to say how the copy must be run.
|
||||||
|
func TestSecurityMdSaysHowAReadCopyOfTheInstallerMustRun(t *testing.T) {
|
||||||
|
sh, err := os.ReadFile(filepath.Join("..", "deploy", "install.sh"))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if !strings.Contains(string(sh), `whole_machine_script="https://privatae.ai/bastion/install.sh"`) {
|
||||||
|
t.Fatal("install.sh's root step no longer fetches the website's installer: re-read SECURITY.md's first-install paragraph, then this test")
|
||||||
|
}
|
||||||
|
raw, err := os.ReadFile(filepath.Join("..", "SECURITY.md"))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
sec := strings.Join(strings.Fields(string(raw)), " ")
|
||||||
|
for _, want := range []string{
|
||||||
|
"`sudo sh install.sh`",
|
||||||
|
"`sh install.sh --just-me`",
|
||||||
|
"fetches the installer from our website again",
|
||||||
|
"an older release we signed",
|
||||||
|
} {
|
||||||
|
if !strings.Contains(sec, want) {
|
||||||
|
t.Errorf("SECURITY.md does not say %q", want)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// With no openssl that can check Ed25519, the check says so and returns, so
|
||||||
|
// the digest check still runs; it never reads as verified.
|
||||||
|
func TestInstallShSaysWhenItCannotCheckTheSignature(t *testing.T) {
|
||||||
|
if _, err := exec.LookPath("sh"); err != nil {
|
||||||
|
t.Skip("no sh")
|
||||||
|
}
|
||||||
|
fake := t.TempDir()
|
||||||
|
if err := os.WriteFile(filepath.Join(fake, "openssl"), []byte("#!/bin/sh\nexit 1\n"), 0o700); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
t.Setenv("PATH", fake+string(os.PathListSeparator)+os.Getenv("PATH"))
|
||||||
|
pub, _, _ := ed25519.GenerateKey(rand.Reader)
|
||||||
|
out, err := sigHarness(t, pub, "http://127.0.0.1:1", []byte("{\"version\": \"9.9.9\"}\n"), true)
|
||||||
|
if err != nil || !strings.Contains(out, "no openssl here can check") || strings.Contains(out, "verified") ||
|
||||||
|
!strings.Contains(out, "RETURNED") {
|
||||||
|
t.Errorf("no capable openssl: %v\n%s", err, out)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The check runs on every install, after the manifest is fetched and before
|
||||||
|
// any digest is read out of it: a digest from an unchecked manifest is the
|
||||||
|
// thing the signature exists to stop.
|
||||||
|
func TestInstallShChecksTheSignatureBeforeReadingTheDigest(t *testing.T) {
|
||||||
|
raw, err := os.ReadFile(filepath.Join("..", "deploy", "install.sh"))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
s := string(raw)
|
||||||
|
fetch := strings.Index(s, `curl -fsSL "$base/version.json" -o "$man"`)
|
||||||
|
check := strings.Index(s, "\nrelease_signature_check \"$man\" \"$vdir\"\n")
|
||||||
|
digest := strings.Index(s, "expected=$(awk")
|
||||||
|
if fetch < 0 || check < 0 || digest < 0 || !(fetch < check && check < digest) {
|
||||||
|
t.Fatalf("install.sh must fetch the manifest, check its signature, then read its digest (at %d, %d, %d)",
|
||||||
|
fetch, check, digest)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// requireTools skips without one of these tools, unless CI says the check
|
||||||
|
// must run (PRIVATAE_REQUIRE_OPENSSL=1, .gitea/workflows/ci.yml): there a
|
||||||
|
// missing tool is a failure, so the signature check cannot quietly go untested.
|
||||||
|
func requireTools(t *testing.T, tools ...string) {
|
||||||
|
t.Helper()
|
||||||
|
for _, tool := range tools {
|
||||||
|
if _, err := exec.LookPath(tool); err != nil {
|
||||||
|
skipOrFail(t, tool+" is not installed here")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func skipOrFail(t *testing.T, why string) {
|
||||||
|
t.Helper()
|
||||||
|
if os.Getenv("PRIVATAE_REQUIRE_OPENSSL") == "1" {
|
||||||
|
t.Fatalf("%s, and PRIVATAE_REQUIRE_OPENSSL=1 says this check must run", why)
|
||||||
|
}
|
||||||
|
t.Skip(why)
|
||||||
|
}
|
||||||
@@ -0,0 +1,81 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
// lanedial.go: the one place a lane turns the connection its pairing's
|
||||||
|
// transport hands it into the mutual TLS the lane runs inside.
|
||||||
|
//
|
||||||
|
// Every transport but one hands a lane a plain connection (the tunnel, the
|
||||||
|
// lane socket, a Host's lane port), and the TLS is done here exactly as the
|
||||||
|
// WebSocket library did it before: the pairing's lane configuration, the
|
||||||
|
// server name it names, the handshake under the dial's context, and the name
|
||||||
|
// checked once more. A Host that connects to this server (hostdoor.go) hands
|
||||||
|
// the lane a connection whose TLS the door already did, under the same
|
||||||
|
// configuration (the Host's CA pinned, host.cseries.internal, this bastion's
|
||||||
|
// operator certificate): that one is passed on as it is. So the lane code is
|
||||||
|
// the same for every pairing; only the dial differs.
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"crypto/tls"
|
||||||
|
"net"
|
||||||
|
"net/http"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"github.com/gorilla/websocket"
|
||||||
|
)
|
||||||
|
|
||||||
|
// laneTLSDial is the TLS dial every lane uses: dialHost's connection with the
|
||||||
|
// lane's TLS done on it, or a Host-opened connection as the door left it.
|
||||||
|
func laneTLSDial(dialHost func(ctx context.Context) (net.Conn, error), tlsCfg *tls.Config) func(ctx context.Context, network, addr string) (net.Conn, error) {
|
||||||
|
return func(ctx context.Context, _, addr string) (net.Conn, error) {
|
||||||
|
c, err := dialHost(ctx)
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
if hc, ok := c.(*hostOpenedConn); ok {
|
||||||
|
return hc, nil
|
||||||
|
}
|
||||||
|
cfg := tlsCfg.Clone()
|
||||||
|
if cfg == nil {
|
||||||
|
cfg = &tls.Config{}
|
||||||
|
}
|
||||||
|
if cfg.ServerName == "" {
|
||||||
|
if h, _, err := net.SplitHostPort(addr); err == nil {
|
||||||
|
cfg.ServerName = h
|
||||||
|
} else {
|
||||||
|
cfg.ServerName = addr
|
||||||
|
}
|
||||||
|
}
|
||||||
|
tc := tls.Client(c, cfg)
|
||||||
|
if err := tc.HandshakeContext(ctx); err != nil {
|
||||||
|
_ = c.Close()
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
if !cfg.InsecureSkipVerify {
|
||||||
|
if err := tc.VerifyHostname(cfg.ServerName); err != nil {
|
||||||
|
_ = tc.Close()
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return tc, nil
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// laneWSDialer is the WebSocket dialer every lane worker pool uses.
|
||||||
|
func laneWSDialer(tlsCfg *tls.Config, dialHost func(ctx context.Context) (net.Conn, error)) *websocket.Dialer {
|
||||||
|
return &websocket.Dialer{
|
||||||
|
NetDialContext: func(ctx context.Context, network, addr string) (net.Conn, error) { return dialHost(ctx) },
|
||||||
|
NetDialTLSContext: laneTLSDial(dialHost, tlsCfg),
|
||||||
|
TLSClientConfig: tlsCfg,
|
||||||
|
HandshakeTimeout: 20 * time.Second,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// laneHTTPTransport is the HTTP transport of a local pairing's requests (the
|
||||||
|
// heartbeat, git credentials, store proposals, context pulls).
|
||||||
|
func laneHTTPTransport(dialHost func(ctx context.Context) (net.Conn, error), tlsCfg *tls.Config) *http.Transport {
|
||||||
|
return &http.Transport{
|
||||||
|
DialContext: func(ctx context.Context, _, _ string) (net.Conn, error) { return dialHost(ctx) },
|
||||||
|
DialTLSContext: laneTLSDial(dialHost, tlsCfg),
|
||||||
|
TLSClientConfig: tlsCfg.Clone(),
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,157 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
// When a Host holds this machine (its owner quarantined it there), the Host
|
||||||
|
// refuses every worker socket of every lane with close code 4403, and says
|
||||||
|
// "quarantined": true on each beat it answers. The lane workers park a pool of
|
||||||
|
// sockets per lane and used to dial again at once (mgmt, harness, session) or
|
||||||
|
// a second after a close (egress, serve), so one held machine whose tunnel
|
||||||
|
// stayed up dialled the Host 30 to 80 times a second, each one a TLS
|
||||||
|
// handshake. A pairing's workers now share one hold:
|
||||||
|
//
|
||||||
|
// - a socket the Host closes with 4403 holds every worker of that pairing for
|
||||||
|
// laneHoldFirst, doubling with each hold up to laneHoldMax;
|
||||||
|
// - a beat that says quarantined stops them dialling until a beat no longer
|
||||||
|
// does, which is how the owner's release reaches this machine.
|
||||||
|
//
|
||||||
|
// The hold is the pairing's, so another Host this machine is paired with is
|
||||||
|
// never slowed by it.
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"encoding/json"
|
||||||
|
"fmt"
|
||||||
|
"math/rand/v2"
|
||||||
|
"sync"
|
||||||
|
"sync/atomic"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"github.com/gorilla/websocket"
|
||||||
|
)
|
||||||
|
|
||||||
|
// laneHeldCloseCode is the close code a Host gives a worker socket of a
|
||||||
|
// machine it holds (the Host's quarantine gate).
|
||||||
|
const laneHeldCloseCode = 4403
|
||||||
|
|
||||||
|
// The first hold, and the longest. Variables so a test can shorten them.
|
||||||
|
var (
|
||||||
|
laneHoldFirst = 5 * time.Second
|
||||||
|
laneHoldMax = 5 * time.Minute
|
||||||
|
)
|
||||||
|
|
||||||
|
type laneHold struct {
|
||||||
|
mu sync.Mutex
|
||||||
|
wait time.Duration // the last hold's length; the next one doubles it
|
||||||
|
until time.Time // no worker of the pairing dials before this
|
||||||
|
last time.Time // when the last hold began
|
||||||
|
quarantined bool // what the last beat said
|
||||||
|
wake chan struct{} // closed when the beat lifts a quarantine
|
||||||
|
}
|
||||||
|
|
||||||
|
var laneHolds sync.Map // host name -> *laneHold
|
||||||
|
|
||||||
|
func laneHoldFor(host string) *laneHold {
|
||||||
|
if h, ok := laneHolds.Load(host); ok {
|
||||||
|
return h.(*laneHold)
|
||||||
|
}
|
||||||
|
h, _ := laneHolds.LoadOrStore(host, &laneHold{wake: make(chan struct{})})
|
||||||
|
return h.(*laneHold)
|
||||||
|
}
|
||||||
|
|
||||||
|
// refused is a worker socket the Host closed with 4403. The workers of a pool
|
||||||
|
// are refused together, so a refusal while a hold is on is that hold's and
|
||||||
|
// does not lengthen it. A refusal long after the last hold starts again from
|
||||||
|
// laneHoldFirst.
|
||||||
|
func (h *laneHold) refused(host string) {
|
||||||
|
h.mu.Lock()
|
||||||
|
defer h.mu.Unlock()
|
||||||
|
now := time.Now()
|
||||||
|
if now.Before(h.until) {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
switch {
|
||||||
|
case h.wait == 0 || now.Sub(h.last) > 2*laneHoldMax:
|
||||||
|
h.wait = laneHoldFirst
|
||||||
|
default:
|
||||||
|
h.wait = min(2*h.wait, laneHoldMax)
|
||||||
|
}
|
||||||
|
h.last = now
|
||||||
|
h.until = now.Add(h.wait)
|
||||||
|
fmt.Printf("[%s] the Host refused a lane: it holds this machine; its lanes dial again in %s\n", host, h.wait)
|
||||||
|
}
|
||||||
|
|
||||||
|
// fromBeat is what a beat's reply said. A release ends the hold at once and
|
||||||
|
// starts the next one from laneHoldFirst.
|
||||||
|
func (h *laneHold) fromBeat(host string, quarantined bool) {
|
||||||
|
h.mu.Lock()
|
||||||
|
defer h.mu.Unlock()
|
||||||
|
switch {
|
||||||
|
case quarantined && !h.quarantined:
|
||||||
|
h.quarantined = true
|
||||||
|
fmt.Printf("[%s] the Host holds this machine (quarantined there): its lanes wait until its owner releases it\n", host)
|
||||||
|
case !quarantined && h.quarantined:
|
||||||
|
h.quarantined = false
|
||||||
|
h.wait, h.until = 0, time.Time{}
|
||||||
|
close(h.wake)
|
||||||
|
h.wake = make(chan struct{})
|
||||||
|
fmt.Printf("[%s] the Host released this machine: its lanes are back\n", host)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// waitClear blocks a worker until it may dial: the hold is over and the last
|
||||||
|
// beat did not say quarantined. A worker waits a little past the hold's end,
|
||||||
|
// a different little for each, so a pool does not dial in one burst. False
|
||||||
|
// when ctx ends first.
|
||||||
|
func (h *laneHold) waitClear(ctx context.Context) bool {
|
||||||
|
for {
|
||||||
|
h.mu.Lock()
|
||||||
|
quarantined, until, wake := h.quarantined, h.until, h.wake
|
||||||
|
h.mu.Unlock()
|
||||||
|
if ctx.Err() != nil {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
var t *time.Timer
|
||||||
|
var timer <-chan time.Time
|
||||||
|
switch {
|
||||||
|
case quarantined:
|
||||||
|
// Only a beat lifts it.
|
||||||
|
case time.Now().Before(until):
|
||||||
|
d := time.Until(until)
|
||||||
|
t = time.NewTimer(d + rand.N(d/10+time.Millisecond))
|
||||||
|
timer = t.C
|
||||||
|
default:
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
select {
|
||||||
|
case <-ctx.Done():
|
||||||
|
case <-wake:
|
||||||
|
case <-timer:
|
||||||
|
}
|
||||||
|
if t != nil {
|
||||||
|
t.Stop()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// watchHeldClose reports, once the socket has been read to its end, whether
|
||||||
|
// the Host closed it with laneHeldCloseCode.
|
||||||
|
func watchHeldClose(ws *websocket.Conn) (held func() bool) {
|
||||||
|
var got atomic.Bool
|
||||||
|
def := ws.CloseHandler()
|
||||||
|
ws.SetCloseHandler(func(code int, text string) error {
|
||||||
|
if code == laneHeldCloseCode {
|
||||||
|
got.Store(true)
|
||||||
|
}
|
||||||
|
return def(code, text)
|
||||||
|
})
|
||||||
|
return got.Load
|
||||||
|
}
|
||||||
|
|
||||||
|
// beatSaysQuarantined reads the "quarantined" a Host puts on the beat's reply
|
||||||
|
// for a machine it holds. A reply without it, or one that cannot be read, is
|
||||||
|
// not a hold.
|
||||||
|
func beatSaysQuarantined(body []byte) bool {
|
||||||
|
var r struct {
|
||||||
|
Quarantined bool `json:"quarantined"`
|
||||||
|
}
|
||||||
|
return json.Unmarshal(body, &r) == nil && r.Quarantined
|
||||||
|
}
|
||||||
@@ -0,0 +1,251 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"crypto/tls"
|
||||||
|
"crypto/x509"
|
||||||
|
"net"
|
||||||
|
"net/http"
|
||||||
|
"net/http/httptest"
|
||||||
|
"strings"
|
||||||
|
"sync/atomic"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"github.com/gorilla/websocket"
|
||||||
|
)
|
||||||
|
|
||||||
|
// heldHost stands in for a Host's lane port: it counts each worker's hello,
|
||||||
|
// then either closes the socket with the code a Host gives a machine it holds,
|
||||||
|
// or parks it.
|
||||||
|
type heldHost struct {
|
||||||
|
hellos atomic.Int32
|
||||||
|
hold atomic.Bool
|
||||||
|
// together: a held socket is closed only once this many hellos came in
|
||||||
|
// (or after barrierWait), so every worker of a pool has dialled before
|
||||||
|
// the first refusal starts the hold. 0 closes each at once.
|
||||||
|
together atomic.Int32
|
||||||
|
tls *tls.Config
|
||||||
|
dial func(ctx context.Context) (net.Conn, error)
|
||||||
|
url string
|
||||||
|
}
|
||||||
|
|
||||||
|
func startHeldHost(t *testing.T) *heldHost {
|
||||||
|
t.Helper()
|
||||||
|
h := &heldHost{}
|
||||||
|
h.hold.Store(true)
|
||||||
|
up := websocket.Upgrader{}
|
||||||
|
srv := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
c, err := up.Upgrade(w, r, nil)
|
||||||
|
if err != nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
defer c.Close()
|
||||||
|
if _, _, err := c.ReadMessage(); err != nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
h.hellos.Add(1)
|
||||||
|
if h.hold.Load() {
|
||||||
|
for end := time.Now().Add(barrierWait); h.hellos.Load() < h.together.Load() && time.Now().Before(end); {
|
||||||
|
time.Sleep(5 * time.Millisecond)
|
||||||
|
}
|
||||||
|
_ = c.WriteControl(websocket.CloseMessage,
|
||||||
|
websocket.FormatCloseMessage(laneHeldCloseCode, "this bastion is quarantined"), time.Now().Add(time.Second))
|
||||||
|
return
|
||||||
|
}
|
||||||
|
for {
|
||||||
|
if _, _, err := c.ReadMessage(); err != nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}))
|
||||||
|
srv.StartTLS()
|
||||||
|
t.Cleanup(srv.Close)
|
||||||
|
pool := x509.NewCertPool()
|
||||||
|
pool.AddCert(srv.Certificate())
|
||||||
|
h.tls = &tls.Config{RootCAs: pool, ServerName: "example.com"}
|
||||||
|
addr := srv.Listener.Addr().String()
|
||||||
|
h.dial = func(ctx context.Context) (net.Conn, error) {
|
||||||
|
var d net.Dialer
|
||||||
|
return d.DialContext(ctx, "tcp", addr)
|
||||||
|
}
|
||||||
|
h.url = "wss://example.com/lane"
|
||||||
|
return h
|
||||||
|
}
|
||||||
|
|
||||||
|
// barrierWait bounds how long a held socket waits for the rest of its pool.
|
||||||
|
const barrierWait = 15 * time.Second
|
||||||
|
|
||||||
|
// shortHolds makes the holds short enough for a test. Set before any worker
|
||||||
|
// runs, and never from a parallel subtest.
|
||||||
|
func shortHolds(t *testing.T, first, max time.Duration) {
|
||||||
|
t.Helper()
|
||||||
|
f, m := laneHoldFirst, laneHoldMax
|
||||||
|
laneHoldFirst, laneHoldMax = first, max
|
||||||
|
t.Cleanup(func() { laneHoldFirst, laneHoldMax = f, m })
|
||||||
|
}
|
||||||
|
|
||||||
|
// ownHold gives a test its own pairing's hold, and forgets it after.
|
||||||
|
func ownHold(t *testing.T, host string) {
|
||||||
|
t.Helper()
|
||||||
|
laneHolds.Delete(host)
|
||||||
|
t.Cleanup(func() { laneHolds.Delete(host) })
|
||||||
|
}
|
||||||
|
|
||||||
|
// Every lane's pool, so a lane added later without the hold is caught.
|
||||||
|
func lanePools(dir string) map[string]func(ctx context.Context, host string, h *heldHost, n int) {
|
||||||
|
return map[string]func(ctx context.Context, host string, h *heldHost, n int){
|
||||||
|
"egress": func(ctx context.Context, host string, h *heldHost, n int) {
|
||||||
|
var d net.Dialer
|
||||||
|
runEgressWorkers(ctx, host, h.url, h.tls, h.dial, "b", d.DialContext, n)
|
||||||
|
},
|
||||||
|
"serve": func(ctx context.Context, host string, h *heldHost, n int) {
|
||||||
|
runServeWorkers(ctx, host, dir, h.url, h.tls, h.dial, "b", n)
|
||||||
|
},
|
||||||
|
"mgmt": func(ctx context.Context, host string, h *heldHost, n int) {
|
||||||
|
runMgmtWorkers(ctx, host, h.url, h.tls, h.dial, "b", dir, dir, dir, n)
|
||||||
|
},
|
||||||
|
"harness": func(ctx context.Context, host string, h *heldHost, n int) {
|
||||||
|
runHarnessWorkers(ctx, host, dir, h.url, h.tls, h.dial, "b", n)
|
||||||
|
},
|
||||||
|
"session": func(ctx context.Context, host string, h *heldHost, n int) {
|
||||||
|
runSessionWorkers(ctx, host, h.url, h.tls, h.dial, "b", n,
|
||||||
|
sessionEnv{CtxRoot: dir, DcnDir: dir, HostName: host, Server: "test"})
|
||||||
|
},
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A Host that holds this machine closes every worker socket with 4403. No
|
||||||
|
// worker of any lane dials it again before the hold is over: one hello per
|
||||||
|
// worker, where a pool used to dial again at once or a second later, 30 to 80
|
||||||
|
// times a second from one held machine.
|
||||||
|
//
|
||||||
|
// The Host closes the sockets only once every worker has said hello
|
||||||
|
// (together). Closing the first at once made the test race the pool's own
|
||||||
|
// start: a worker not yet past its first waitClear when another was refused
|
||||||
|
// rightly waited out the hold before dialling, and the count read one of two
|
||||||
|
// (a full gate, 2026-11-03). The hold is timed from the refusals, which come
|
||||||
|
// after the last hello, so the 2 s look is inside the 3 s hold however slowly
|
||||||
|
// the workers start.
|
||||||
|
//
|
||||||
|
// MUTATION: drop hold.refused from a lane's worker (mgmt.go). RESULT: red,
|
||||||
|
// that lane dials again within the hold.
|
||||||
|
func TestEveryLanePoolWaitsOutAHostThatHoldsThisMachine(t *testing.T) {
|
||||||
|
shortHolds(t, 3*time.Second, time.Minute)
|
||||||
|
for lane, run := range lanePools(t.TempDir()) {
|
||||||
|
t.Run(lane, func(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
host := "held-" + lane + ".example.test"
|
||||||
|
ownHold(t, host)
|
||||||
|
h := startHeldHost(t)
|
||||||
|
const n = 2
|
||||||
|
h.together.Store(n)
|
||||||
|
ctx, cancel := context.WithCancel(context.Background())
|
||||||
|
t.Cleanup(cancel)
|
||||||
|
go run(ctx, host, h, n)
|
||||||
|
for end := time.Now().Add(barrierWait); h.hellos.Load() < n && time.Now().Before(end); {
|
||||||
|
time.Sleep(5 * time.Millisecond)
|
||||||
|
}
|
||||||
|
if got := h.hellos.Load(); got < n {
|
||||||
|
t.Fatalf("only %d of %d workers dialled the Host in %s", got, n, barrierWait)
|
||||||
|
}
|
||||||
|
time.Sleep(2 * time.Second)
|
||||||
|
if got := h.hellos.Load(); got != n {
|
||||||
|
t.Fatalf("%d dials within the hold from %d workers; want one each", got, n)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A beat whose reply says quarantined stops the lanes before any of them
|
||||||
|
// dials, and the first beat that no longer says it brings them back at once.
|
||||||
|
func TestABeatThatSaysQuarantinedStopsTheLanesUntilOneDoesNot(t *testing.T) {
|
||||||
|
host := "quarantined.example.test"
|
||||||
|
shortHolds(t, time.Hour, time.Hour)
|
||||||
|
ownHold(t, host)
|
||||||
|
h := startHeldHost(t)
|
||||||
|
h.hold.Store(false)
|
||||||
|
laneHoldFor(host).fromBeat(host, beatSaysQuarantined([]byte(`{"ok":true,"quarantined":true}`)))
|
||||||
|
ctx, cancel := context.WithCancel(context.Background())
|
||||||
|
t.Cleanup(cancel)
|
||||||
|
const n = 2
|
||||||
|
go lanePools(t.TempDir())["mgmt"](ctx, host, h, n)
|
||||||
|
time.Sleep(700 * time.Millisecond)
|
||||||
|
if got := h.hellos.Load(); got != 0 {
|
||||||
|
t.Fatalf("%d dials while the Host says it holds this machine", got)
|
||||||
|
}
|
||||||
|
laneHoldFor(host).fromBeat(host, beatSaysQuarantined([]byte(`{"ok":true}`)))
|
||||||
|
deadline := time.Now().Add(3 * time.Second)
|
||||||
|
for h.hellos.Load() < n && time.Now().Before(deadline) {
|
||||||
|
time.Sleep(20 * time.Millisecond)
|
||||||
|
}
|
||||||
|
if got := h.hellos.Load(); got != n {
|
||||||
|
t.Fatalf("after the release, %d of %d workers parked again", got, n)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A pool's workers are refused together, so a refusal inside a hold is that
|
||||||
|
// hold's; each hold after one runs out is twice as long, up to the most; a
|
||||||
|
// refusal long after the last starts again from the first; a release ends a
|
||||||
|
// hold at once.
|
||||||
|
func TestAHoldDoublesOncePerHoldUpToItsMost(t *testing.T) {
|
||||||
|
host := "doubling.example.test"
|
||||||
|
shortHolds(t, time.Second, 4*time.Second)
|
||||||
|
ownHold(t, host)
|
||||||
|
h := laneHoldFor(host)
|
||||||
|
expire := func() {
|
||||||
|
h.mu.Lock()
|
||||||
|
h.until = time.Now().Add(-time.Millisecond)
|
||||||
|
h.mu.Unlock()
|
||||||
|
}
|
||||||
|
wait := func() time.Duration {
|
||||||
|
h.mu.Lock()
|
||||||
|
defer h.mu.Unlock()
|
||||||
|
return h.wait
|
||||||
|
}
|
||||||
|
h.refused(host)
|
||||||
|
h.refused(host)
|
||||||
|
h.refused(host)
|
||||||
|
if got := wait(); got != time.Second {
|
||||||
|
t.Fatalf("three refusals in one hold: %s, want the first hold", got)
|
||||||
|
}
|
||||||
|
var got []string
|
||||||
|
for range 3 {
|
||||||
|
expire()
|
||||||
|
h.refused(host)
|
||||||
|
got = append(got, wait().String())
|
||||||
|
}
|
||||||
|
if strings.Join(got, " ") != "2s 4s 4s" {
|
||||||
|
t.Fatalf("holds after the first: %v, want 2s 4s 4s", got)
|
||||||
|
}
|
||||||
|
expire()
|
||||||
|
h.mu.Lock()
|
||||||
|
h.last = time.Now().Add(-9 * time.Second)
|
||||||
|
h.mu.Unlock()
|
||||||
|
h.refused(host)
|
||||||
|
if got := wait(); got != time.Second {
|
||||||
|
t.Fatalf("a refusal after a long quiet: %s, want the first hold again", got)
|
||||||
|
}
|
||||||
|
h.fromBeat(host, true)
|
||||||
|
h.fromBeat(host, false)
|
||||||
|
ctx, cancel := context.WithTimeout(context.Background(), 100*time.Millisecond)
|
||||||
|
defer cancel()
|
||||||
|
if !h.waitClear(ctx) {
|
||||||
|
t.Fatal("a release must end the hold at once")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestBeatSaysQuarantinedReadsOnlyTheHostsTrue(t *testing.T) {
|
||||||
|
for body, want := range map[string]bool{
|
||||||
|
`{"ok":true,"quarantined":true}`: true,
|
||||||
|
`{"ok":true,"quarantined":false}`: false,
|
||||||
|
`{"ok":true}`: false,
|
||||||
|
`{"quarantined":"yes"}`: false,
|
||||||
|
`not json`: false,
|
||||||
|
``: false,
|
||||||
|
} {
|
||||||
|
if got := beatSaysQuarantined([]byte(body)); got != want {
|
||||||
|
t.Errorf("%q: %v, want %v", body, got, want)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,207 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
// llmlocal.go — finding the OpenAI-compatible model server on this machine
|
||||||
|
// when PRIVATAE_LLM_ADDR names none.
|
||||||
|
//
|
||||||
|
// Before 0.63.0 that lane existed only when someone set the variable in the
|
||||||
|
// bastion's environment, which no installer does, so a machine running
|
||||||
|
// llama.cpp on its usual port served no model to its Host. Now, with the
|
||||||
|
// variable unset, the bastion looks on this machine's loopback, and nowhere
|
||||||
|
// else, at the ports the common servers
|
||||||
|
// listen on by default: 127.0.0.1:8080 (llama.cpp's llama-server), :8000
|
||||||
|
// (vLLM), :1234 (LM Studio), in that order. Each is asked GET /v1/models with a
|
||||||
|
// short timeout, and the first whose answer is OpenAI-shaped (a "data" list of
|
||||||
|
// models, each with an "id") is the server. Something else answering on one of
|
||||||
|
// those ports (a web app on 8080, say) is not taken for a model server, nor,
|
||||||
|
// on Linux, a server another account runs (llmListenerTrusted).
|
||||||
|
//
|
||||||
|
// The answer is kept and asked again every llmReprobeEvery, and at once after
|
||||||
|
// it failed (llmTargetFailed: the beat's probe of it, a dial of it), so the
|
||||||
|
// heartbeat that advertises the lane and the forward that serves it read the
|
||||||
|
// same address: both call llmTarget (env.go), the one function for the lane.
|
||||||
|
// The variable, when set, overrides all of this, as before. What was found, or
|
||||||
|
// that nothing was, is logged once per change and shown by `status` and
|
||||||
|
// `doctor`.
|
||||||
|
|
||||||
|
import (
|
||||||
|
"encoding/json"
|
||||||
|
"fmt"
|
||||||
|
"io"
|
||||||
|
"net/http"
|
||||||
|
"os"
|
||||||
|
"strings"
|
||||||
|
"sync"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
// llmCandidate is one place a local OpenAI-compatible server listens by
|
||||||
|
// default. Loopback only, by construction: the addresses are fixed here.
|
||||||
|
type llmCandidate struct {
|
||||||
|
Addr string
|
||||||
|
Server string // whose default port it is, for the words
|
||||||
|
}
|
||||||
|
|
||||||
|
var llmCandidates = []llmCandidate{
|
||||||
|
{"127.0.0.1:8080", "llama.cpp"},
|
||||||
|
{"127.0.0.1:8000", "vLLM"},
|
||||||
|
{"127.0.0.1:1234", "LM Studio"},
|
||||||
|
}
|
||||||
|
|
||||||
|
const (
|
||||||
|
llmReprobeEvery = 60 * time.Second
|
||||||
|
llmProbeTimeout = 800 * time.Millisecond
|
||||||
|
)
|
||||||
|
|
||||||
|
// llmProbe asks addr for its models; ok only for an OpenAI-shaped answer. A
|
||||||
|
// seam for the suite.
|
||||||
|
var llmProbe = probeOpenAIShaped
|
||||||
|
|
||||||
|
// llmTrusted: the program on that port may be handed the Host's prompts
|
||||||
|
// (llmlocal_linux.go: root's, this bastion's user's or the owner's). A seam.
|
||||||
|
var llmTrusted = llmListenerTrusted
|
||||||
|
|
||||||
|
// probeOpenAIShaped is GET http://addr/v1/models: a 200 whose body is
|
||||||
|
// {"data": [{"id": "..."}, ...]} with at least one model and an id on each.
|
||||||
|
func probeOpenAIShaped(addr string) ([]string, bool) {
|
||||||
|
cl := &http.Client{Timeout: llmProbeTimeout}
|
||||||
|
resp, err := cl.Get("http://" + addr + "/v1/models")
|
||||||
|
if err != nil {
|
||||||
|
return nil, false
|
||||||
|
}
|
||||||
|
defer resp.Body.Close()
|
||||||
|
if resp.StatusCode != http.StatusOK {
|
||||||
|
return nil, false
|
||||||
|
}
|
||||||
|
return openAIShapedModels(io.LimitReader(resp.Body, 1<<20))
|
||||||
|
}
|
||||||
|
|
||||||
|
// openAIShapedModels reads an OpenAI /v1/models answer: the model ids, and
|
||||||
|
// whether it is one.
|
||||||
|
func openAIShapedModels(r io.Reader) ([]string, bool) {
|
||||||
|
var list struct {
|
||||||
|
Data []map[string]any `json:"data"`
|
||||||
|
}
|
||||||
|
if err := json.NewDecoder(r).Decode(&list); err != nil || len(list.Data) == 0 {
|
||||||
|
return nil, false
|
||||||
|
}
|
||||||
|
var ids []string
|
||||||
|
for _, m := range list.Data {
|
||||||
|
id, _ := m["id"].(string)
|
||||||
|
if strings.TrimSpace(id) == "" {
|
||||||
|
return nil, false
|
||||||
|
}
|
||||||
|
ids = append(ids, id)
|
||||||
|
}
|
||||||
|
return ids, true
|
||||||
|
}
|
||||||
|
|
||||||
|
// llmFound is what the bastion found on this machine.
|
||||||
|
type llmFound struct {
|
||||||
|
Addr string `json:"addr,omitempty"`
|
||||||
|
Server string `json:"server,omitempty"` // whose default port it answered on
|
||||||
|
Models []string `json:"models,omitempty"`
|
||||||
|
}
|
||||||
|
|
||||||
|
var llmLocal = struct {
|
||||||
|
sync.Mutex
|
||||||
|
found llmFound
|
||||||
|
at time.Time
|
||||||
|
probed bool
|
||||||
|
said string // what was last logged
|
||||||
|
}{}
|
||||||
|
|
||||||
|
// discoveredLLM is the server found on this machine, asked again when the
|
||||||
|
// last answer is older than llmReprobeEvery or was marked failed.
|
||||||
|
func discoveredLLM() llmFound {
|
||||||
|
llmLocal.Lock()
|
||||||
|
defer llmLocal.Unlock()
|
||||||
|
if llmLocal.probed && time.Since(llmLocal.at) < llmReprobeEvery {
|
||||||
|
return llmLocal.found
|
||||||
|
}
|
||||||
|
f := llmFound{}
|
||||||
|
for _, c := range llmCandidates {
|
||||||
|
if models, ok := llmProbe(c.Addr); ok && llmTrusted(c.Addr) {
|
||||||
|
f = llmFound{Addr: c.Addr, Server: c.Server, Models: models}
|
||||||
|
break
|
||||||
|
}
|
||||||
|
}
|
||||||
|
llmLocal.found, llmLocal.at, llmLocal.probed = f, time.Now(), true
|
||||||
|
// Said in the running bastion's log, once per change; a command such as
|
||||||
|
// `status` shows it in its own words instead.
|
||||||
|
if line := llmFoundWords(f); line != llmLocal.said && daemonRunningHere() {
|
||||||
|
llmLocal.said = line
|
||||||
|
fmt.Printf("[llm] %s\n", line)
|
||||||
|
}
|
||||||
|
return f
|
||||||
|
}
|
||||||
|
|
||||||
|
// daemonRunningHere: this process is the running bastion (cmdRun set up its
|
||||||
|
// supervisor), not a command beside it.
|
||||||
|
func daemonRunningHere() bool {
|
||||||
|
supervisor.Lock()
|
||||||
|
defer supervisor.Unlock()
|
||||||
|
return supervisor.ctx != nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// llmTargetFailed marks the found server as failed when addr is it, so the
|
||||||
|
// next llmTarget asks again rather than serve a server that went away.
|
||||||
|
func llmTargetFailed(addr string) {
|
||||||
|
if addr == "" || os.Getenv("PRIVATAE_LLM_ADDR") != "" {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
llmLocal.Lock()
|
||||||
|
defer llmLocal.Unlock()
|
||||||
|
if llmLocal.found.Addr == addr {
|
||||||
|
llmLocal.probed = false
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// llmCandidateList is the places looked, for the words.
|
||||||
|
func llmCandidateList() string {
|
||||||
|
var out []string
|
||||||
|
for _, c := range llmCandidates {
|
||||||
|
out = append(out, c.Addr+" ("+c.Server+")")
|
||||||
|
}
|
||||||
|
return strings.Join(out, ", ")
|
||||||
|
}
|
||||||
|
|
||||||
|
func llmFoundWords(f llmFound) string {
|
||||||
|
if f.Addr == "" {
|
||||||
|
return "no OpenAI-compatible model server found on this machine (looked on " + llmCandidateList() +
|
||||||
|
"); set PRIVATAE_LLM_ADDR to name another on this machine"
|
||||||
|
}
|
||||||
|
s := fmt.Sprintf("found an OpenAI-compatible model server on %s, %s's port", f.Addr, f.Server)
|
||||||
|
if len(f.Models) > 0 {
|
||||||
|
s += ": " + strings.Join(f.Models, ", ")
|
||||||
|
}
|
||||||
|
return s
|
||||||
|
}
|
||||||
|
|
||||||
|
// statusLLM is the model-server line `status` and `doctor` show.
|
||||||
|
type statusLLM struct {
|
||||||
|
Addr string `json:"addr,omitempty"`
|
||||||
|
Source string `json:"source"` // "PRIVATAE_LLM_ADDR", "found" or "none"
|
||||||
|
Server string `json:"server,omitempty"`
|
||||||
|
Models []string `json:"models,omitempty"`
|
||||||
|
}
|
||||||
|
|
||||||
|
func llmStatus() *statusLLM {
|
||||||
|
if v := os.Getenv("PRIVATAE_LLM_ADDR"); v != "" {
|
||||||
|
return &statusLLM{Addr: v, Source: "PRIVATAE_LLM_ADDR"}
|
||||||
|
}
|
||||||
|
f := discoveredLLM()
|
||||||
|
if f.Addr == "" {
|
||||||
|
return &statusLLM{Source: "none"}
|
||||||
|
}
|
||||||
|
return &statusLLM{Addr: f.Addr, Source: "found", Server: f.Server, Models: f.Models}
|
||||||
|
}
|
||||||
|
|
||||||
|
func (l *statusLLM) words() string {
|
||||||
|
switch l.Source {
|
||||||
|
case "PRIVATAE_LLM_ADDR":
|
||||||
|
return l.Addr + " (set by PRIVATAE_LLM_ADDR)"
|
||||||
|
case "found":
|
||||||
|
return llmFoundWords(llmFound{Addr: l.Addr, Server: l.Server, Models: l.Models})
|
||||||
|
}
|
||||||
|
return llmFoundWords(llmFound{})
|
||||||
|
}
|
||||||
@@ -0,0 +1,75 @@
|
|||||||
|
//go:build linux
|
||||||
|
|
||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"os"
|
||||||
|
"strconv"
|
||||||
|
"strings"
|
||||||
|
)
|
||||||
|
|
||||||
|
// llmListenerTrusted: the program listening on the loopback port addr names
|
||||||
|
// runs as root, as this bastion's own user, or as the machine's recorded
|
||||||
|
// owner. Found without anyone setting PRIVATAE_LLM_ADDR, a model server is
|
||||||
|
// handed the Host's prompts, and any account on the machine can listen on
|
||||||
|
// 127.0.0.1:8080 while llama.cpp is not running; a server of another account
|
||||||
|
// is not taken (the variable still names one on purpose). The kernel's own
|
||||||
|
// table says who owns each listening socket (/proc/net/tcp, tcp6).
|
||||||
|
func llmListenerTrusted(addr string) bool {
|
||||||
|
port := portOfAddr(addr)
|
||||||
|
if port <= 0 {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
var uids []uint32
|
||||||
|
for _, f := range []string{"/proc/net/tcp", "/proc/net/tcp6"} {
|
||||||
|
if raw, err := os.ReadFile(f); err == nil {
|
||||||
|
uids = append(uids, loopbackListenerUIDs(string(raw), port)...)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
owner, _, ownerKnown, _ := ownerAccountLoad()
|
||||||
|
return listenersTrusted(uids, uint32(os.Getuid()), owner, ownerKnown)
|
||||||
|
}
|
||||||
|
|
||||||
|
// listenersTrusted: there is a listener, and every one is root's, self's or
|
||||||
|
// the owner's.
|
||||||
|
func listenersTrusted(uids []uint32, self, owner uint32, ownerKnown bool) bool {
|
||||||
|
if len(uids) == 0 {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
for _, u := range uids {
|
||||||
|
if u != 0 && u != self && (!ownerKnown || u != owner) {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
|
||||||
|
// loopbackListenerUIDs reads a /proc/net/tcp table: the uid of every socket
|
||||||
|
// LISTENing on port at a loopback or any-address local address.
|
||||||
|
func loopbackListenerUIDs(table string, port int) []uint32 {
|
||||||
|
var out []uint32
|
||||||
|
for _, line := range strings.Split(table, "\n")[1:] {
|
||||||
|
f := strings.Fields(line)
|
||||||
|
if len(f) < 8 || f[3] != "0A" {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
host, p, ok := strings.Cut(f[1], ":")
|
||||||
|
if !ok {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
if n, err := strconv.ParseUint(p, 16, 16); err != nil || int(n) != port {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
switch host {
|
||||||
|
case "0100007F", "00000000", "00000000000000000000000001000000", "00000000000000000000000000000000":
|
||||||
|
default:
|
||||||
|
if !strings.HasSuffix(host, "7F") || len(host) != 8 { // 127.x.y.z, little-endian
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if u, err := strconv.ParseUint(f[7], 10, 32); err == nil {
|
||||||
|
out = append(out, uint32(u))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return out
|
||||||
|
}
|
||||||
@@ -0,0 +1,64 @@
|
|||||||
|
//go:build linux
|
||||||
|
|
||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"net"
|
||||||
|
"os"
|
||||||
|
"strconv"
|
||||||
|
"testing"
|
||||||
|
)
|
||||||
|
|
||||||
|
// Found without PRIVATAE_LLM_ADDR, a model server another account runs on the
|
||||||
|
// port is not handed the Host's prompts; root's, this bastion's and its own
|
||||||
|
// listener are.
|
||||||
|
//
|
||||||
|
// MUTATION: accept any uid in listenersTrusted. RESULT: red.
|
||||||
|
func TestAModelServerOfAnotherAccountIsNotTaken(t *testing.T) {
|
||||||
|
table := " sl local_address rem_address st tx_queue rx_queue tr tm->when retrnsmt uid timeout inode\n" +
|
||||||
|
" 0: 0100007F:1F90 00000000:0000 0A 00000000:00000000 00:00000000 00000000 1001 0 1 1 0 100 0 0 10 0\n" +
|
||||||
|
" 1: 0100007F:1F40 00000000:0000 0A 00000000:00000000 00:00000000 00000000 0 0 2 1 0 100 0 0 10 0\n" +
|
||||||
|
" 2: 0100007F:1F40 0100007F:9999 01 00000000:00000000 00:00000000 00000000 1002 0 3 1 0 100 0 0 10 0\n"
|
||||||
|
if got := loopbackListenerUIDs(table, 8080); len(got) != 1 || got[0] != 1001 {
|
||||||
|
t.Errorf("8080: %v", got)
|
||||||
|
}
|
||||||
|
if got := loopbackListenerUIDs(table, 8000); len(got) != 1 || got[0] != 0 {
|
||||||
|
t.Errorf("8000 (an established connection is not a listener): %v", got)
|
||||||
|
}
|
||||||
|
for _, c := range []struct {
|
||||||
|
uids []uint32
|
||||||
|
owner bool
|
||||||
|
want bool
|
||||||
|
}{
|
||||||
|
{[]uint32{0}, false, true}, {[]uint32{1000}, false, true}, {[]uint32{1001}, true, true},
|
||||||
|
{[]uint32{1001}, false, false}, {[]uint32{1002}, true, false}, {[]uint32{0, 1002}, true, false}, {nil, true, false},
|
||||||
|
} {
|
||||||
|
if got := listenersTrusted(c.uids, 1000, 1001, c.owner); got != c.want {
|
||||||
|
t.Errorf("listeners %v (owner recorded %v): trusted %v, want %v", c.uids, c.owner, got, c.want)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
// A listener of this process's own is trusted, a port nobody listens on is not.
|
||||||
|
ln, err := net.Listen("tcp", "127.0.0.1:0")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
defer ln.Close()
|
||||||
|
if !llmListenerTrusted(ln.Addr().String()) {
|
||||||
|
t.Errorf("this process's own listener (uid %d) is not trusted", os.Getuid())
|
||||||
|
}
|
||||||
|
_, p, _ := net.SplitHostPort(ln.Addr().String())
|
||||||
|
n, _ := strconv.Atoi(p)
|
||||||
|
_ = ln.Close()
|
||||||
|
if llmListenerTrusted("127.0.0.1:" + strconv.Itoa(n)) {
|
||||||
|
t.Error("a port nobody listens on is trusted")
|
||||||
|
}
|
||||||
|
// Discovery skips an untrusted server for the next one.
|
||||||
|
bad, good := openAIServer(t, oneModel), openAIServer(t, oneModel)
|
||||||
|
withLLMCandidates(t, bad, good)
|
||||||
|
prev := llmTrusted
|
||||||
|
llmTrusted = func(a string) bool { return a != bad }
|
||||||
|
t.Cleanup(func() { llmTrusted = prev })
|
||||||
|
if got := llmTarget(); got != good {
|
||||||
|
t.Errorf("llmTarget = %q, want the trusted one", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,8 @@
|
|||||||
|
//go:build !linux
|
||||||
|
|
||||||
|
package main
|
||||||
|
|
||||||
|
// llmListenerTrusted is Linux's check of who listens (llmlocal_linux.go). On
|
||||||
|
// Windows and macOS the found server is taken as it answers; who owns the
|
||||||
|
// port is not checked there yet.
|
||||||
|
func llmListenerTrusted(string) bool { return true }
|
||||||
@@ -0,0 +1,189 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"encoding/json"
|
||||||
|
"net"
|
||||||
|
"net/http"
|
||||||
|
"net/http/httptest"
|
||||||
|
"strings"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
// withLLMCandidates points the discovery at addrs (in order) with the real
|
||||||
|
// probe, and starts from no answer.
|
||||||
|
func withLLMCandidates(t *testing.T, addrs ...string) {
|
||||||
|
t.Helper()
|
||||||
|
prevC, prevP := llmCandidates, llmProbe
|
||||||
|
llmCandidates = nil
|
||||||
|
for i, a := range addrs {
|
||||||
|
llmCandidates = append(llmCandidates, llmCandidate{Addr: a, Server: []string{"llama.cpp", "vLLM", "LM Studio"}[i%3]})
|
||||||
|
}
|
||||||
|
llmProbe = probeOpenAIShaped
|
||||||
|
resetLLMDiscovery()
|
||||||
|
t.Cleanup(func() { llmCandidates, llmProbe = prevC, prevP; resetLLMDiscovery() })
|
||||||
|
t.Setenv("PRIVATAE_LLM_ADDR", "")
|
||||||
|
}
|
||||||
|
|
||||||
|
func resetLLMDiscovery() {
|
||||||
|
llmLocal.Lock()
|
||||||
|
llmLocal.found, llmLocal.probed, llmLocal.said = llmFound{}, false, ""
|
||||||
|
llmLocal.Unlock()
|
||||||
|
}
|
||||||
|
|
||||||
|
// openAIServer answers /v1/models with body.
|
||||||
|
func openAIServer(t *testing.T, body string) string {
|
||||||
|
t.Helper()
|
||||||
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
if r.URL.Path != "/v1/models" {
|
||||||
|
http.NotFound(w, r)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
_, _ = w.Write([]byte(body))
|
||||||
|
}))
|
||||||
|
t.Cleanup(srv.Close)
|
||||||
|
return strings.TrimPrefix(srv.URL, "http://")
|
||||||
|
}
|
||||||
|
|
||||||
|
// deadAddr is a loopback port nothing listens on.
|
||||||
|
func deadAddr(t *testing.T) string {
|
||||||
|
t.Helper()
|
||||||
|
ln, err := net.Listen("tcp", "127.0.0.1:0")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
a := ln.Addr().String()
|
||||||
|
_ = ln.Close()
|
||||||
|
return a
|
||||||
|
}
|
||||||
|
|
||||||
|
const oneModel = `{"object":"list","data":[{"id":"qwen3-4b-q4_k_m.gguf","object":"model"}]}`
|
||||||
|
|
||||||
|
// None answering: no lane, and status says where it looked.
|
||||||
|
//
|
||||||
|
// MUTATION: return the first candidate whatever it answers. RESULT: red.
|
||||||
|
func TestNoLocalModelServerMeansNoLane(t *testing.T) {
|
||||||
|
withLLMCandidates(t, deadAddr(t), deadAddr(t))
|
||||||
|
if got := llmTarget(); got != "" {
|
||||||
|
t.Fatalf("llmTarget = %q with nothing answering", got)
|
||||||
|
}
|
||||||
|
if ok, _ := openAICompatModels(); ok {
|
||||||
|
t.Error("the beat would advertise a model server that is not there")
|
||||||
|
}
|
||||||
|
if l := llmStatus(); l.Source != "none" || !strings.Contains(l.words(), "no OpenAI-compatible model server found") {
|
||||||
|
t.Errorf("status: %+v %q", l, l.words())
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// One answering: the lane names it, the beat's probe and the forward agree,
|
||||||
|
// and status says which server it is.
|
||||||
|
//
|
||||||
|
// MUTATION: have llmTarget return only the variable. RESULT: red.
|
||||||
|
func TestALocalModelServerIsFound(t *testing.T) {
|
||||||
|
a := openAIServer(t, oneModel)
|
||||||
|
withLLMCandidates(t, deadAddr(t), a)
|
||||||
|
if got := llmTarget(); got != a {
|
||||||
|
t.Fatalf("llmTarget = %q, want %q", got, a)
|
||||||
|
}
|
||||||
|
ok, models := openAICompatModels()
|
||||||
|
if !ok || strings.Join(models, ",") != "qwen3-4b-q4_k_m.gguf" {
|
||||||
|
t.Errorf("the beat's probe: %v %v", ok, models)
|
||||||
|
}
|
||||||
|
if s, _ := serveServiceNamed("llm"); s.target() != a {
|
||||||
|
t.Error("the serve lane reads another address than the beat")
|
||||||
|
}
|
||||||
|
l := llmStatus()
|
||||||
|
if l.Source != "found" || l.Addr != a || !strings.Contains(l.words(), "found an OpenAI-compatible model server on "+a) {
|
||||||
|
t.Errorf("status: %+v %q", l, l.words())
|
||||||
|
}
|
||||||
|
raw, _ := json.Marshal(statusRead{LLM: l})
|
||||||
|
if !strings.Contains(string(raw), `"source":"found"`) {
|
||||||
|
t.Errorf("status --json: %s", raw)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Several answering: the first in the order wins (llama.cpp, vLLM, LM Studio).
|
||||||
|
//
|
||||||
|
// MUTATION: keep looking after the first answer and take the last. RESULT: red.
|
||||||
|
func TestTheFirstLocalModelServerInOrderWins(t *testing.T) {
|
||||||
|
first, second := openAIServer(t, oneModel), openAIServer(t, `{"data":[{"id":"other"}]}`)
|
||||||
|
withLLMCandidates(t, first, second)
|
||||||
|
if got := llmTarget(); got != first {
|
||||||
|
t.Fatalf("llmTarget = %q, want the first, %q", got, first)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The variable overrides what is found.
|
||||||
|
//
|
||||||
|
// MUTATION: look before reading the variable. RESULT: red.
|
||||||
|
func TestTheVariableOverridesTheLocalModelServer(t *testing.T) {
|
||||||
|
a := openAIServer(t, oneModel)
|
||||||
|
withLLMCandidates(t, a)
|
||||||
|
t.Setenv("PRIVATAE_LLM_ADDR", "127.0.0.1:18080")
|
||||||
|
if got := llmTarget(); got != "127.0.0.1:18080" {
|
||||||
|
t.Fatalf("llmTarget = %q", got)
|
||||||
|
}
|
||||||
|
if l := llmStatus(); l.Source != "PRIVATAE_LLM_ADDR" {
|
||||||
|
t.Errorf("status: %+v", l)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Something else on the port (a web app, a server whose list is not OpenAI's)
|
||||||
|
// is not taken for a model server.
|
||||||
|
//
|
||||||
|
// MUTATION: accept any 200 in probeOpenAIShaped. RESULT: red.
|
||||||
|
func TestAnAnswerThatIsNotOpenAIShapedIsIgnored(t *testing.T) {
|
||||||
|
for _, body := range []string{`<html>hello</html>`, `{"models":[{"name":"x"}]}`, `{"data":[]}`, `{"data":[{"name":"x"}]}`, `{"data":"x"}`} {
|
||||||
|
bad := openAIServer(t, body)
|
||||||
|
good := openAIServer(t, oneModel)
|
||||||
|
withLLMCandidates(t, bad, good)
|
||||||
|
if got := llmTarget(); got != good {
|
||||||
|
t.Errorf("%s: llmTarget = %q, want the OpenAI-shaped one", body, got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Only loopback is ever asked.
|
||||||
|
//
|
||||||
|
// MUTATION: add a LAN address to llmCandidates. RESULT: red.
|
||||||
|
func TestOnlyLoopbackIsAskedForAModelServer(t *testing.T) {
|
||||||
|
want := []string{"127.0.0.1:8080", "127.0.0.1:8000", "127.0.0.1:1234"}
|
||||||
|
if len(llmCandidates) != len(want) {
|
||||||
|
t.Fatalf("%+v", llmCandidates)
|
||||||
|
}
|
||||||
|
for i, c := range llmCandidates {
|
||||||
|
if c.Addr != want[i] || !loopbackAddr(c.Addr) {
|
||||||
|
t.Errorf("candidate %d is %q", i, c.Addr)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A found server that goes away is asked for again at once after a failure,
|
||||||
|
// not served for the rest of the interval; one that starts later is found at
|
||||||
|
// the next interval.
|
||||||
|
//
|
||||||
|
// MUTATION: drop llmTargetFailed from openAICompatModels. RESULT: red.
|
||||||
|
func TestAModelServerThatWentAwayIsAskedForAgain(t *testing.T) {
|
||||||
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { _, _ = w.Write([]byte(oneModel)) }))
|
||||||
|
a := strings.TrimPrefix(srv.URL, "http://")
|
||||||
|
withLLMCandidates(t, a)
|
||||||
|
if llmTarget() != a {
|
||||||
|
t.Fatal("not found")
|
||||||
|
}
|
||||||
|
srv.Close()
|
||||||
|
if ok, _ := openAICompatModels(); ok {
|
||||||
|
t.Fatal("a closed server answered")
|
||||||
|
}
|
||||||
|
if got := llmTarget(); got != "" {
|
||||||
|
t.Errorf("after a failed probe llmTarget still names %q", got)
|
||||||
|
}
|
||||||
|
// Later: the cached "none" is asked again once the interval is over.
|
||||||
|
b := openAIServer(t, oneModel)
|
||||||
|
llmCandidates = []llmCandidate{{Addr: b, Server: "llama.cpp"}}
|
||||||
|
llmLocal.Lock()
|
||||||
|
llmLocal.at = time.Now().Add(-llmReprobeEvery - time.Second)
|
||||||
|
llmLocal.Unlock()
|
||||||
|
if got := llmTarget(); got != b {
|
||||||
|
t.Errorf("a server that started later is not found: %q", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -423,17 +423,30 @@ func startLaneHost(t *testing.T, sock string, cert tls.Certificate, clientCA *te
|
|||||||
// socket, or a Host's lane port (local_host_tcp_linux_test.go).
|
// socket, or a Host's lane port (local_host_tcp_linux_test.go).
|
||||||
func startLaneHostOn(t *testing.T, raw net.Listener, cert tls.Certificate, clientCA *testCA) *laneHost {
|
func startLaneHostOn(t *testing.T, raw net.Listener, cert tls.Certificate, clientCA *testCA) *laneHost {
|
||||||
t.Helper()
|
t.Helper()
|
||||||
|
h, mux, tc := newLaneHost(cert, clientCA)
|
||||||
|
ln := tls.NewListener(countingListener{raw, &h.accepted}, tc)
|
||||||
|
srv := &http.Server{Handler: mux, ErrorLog: log.New(io.Discard, "", 0)}
|
||||||
|
go func() { _ = srv.Serve(ln) }()
|
||||||
|
t.Cleanup(func() { _ = srv.Close() })
|
||||||
|
return h
|
||||||
|
}
|
||||||
|
|
||||||
|
// newLaneHost is a lane Host's routes and its TLS server configuration,
|
||||||
|
// served on a listener (startLaneHostOn) or over connections it opens itself
|
||||||
|
// (hostdoor_linux_test.go). It speaks the lane protocol name a Host that
|
||||||
|
// connects to a server chooses (laneALPN); a bastion that dials offers none.
|
||||||
|
func newLaneHost(cert tls.Certificate, clientCA *testCA) (*laneHost, http.Handler, *tls.Config) {
|
||||||
h := &laneHost{jobs: make(chan []byte, 4), replies: make(chan string, 4)}
|
h := &laneHost{jobs: make(chan []byte, 4), replies: make(chan string, 4)}
|
||||||
pool := x509.NewCertPool()
|
pool := x509.NewCertPool()
|
||||||
pool.AddCert(clientCA.cert)
|
pool.AddCert(clientCA.cert)
|
||||||
ln := tls.NewListener(countingListener{raw, &h.accepted}, &tls.Config{Certificates: []tls.Certificate{cert},
|
tc := &tls.Config{Certificates: []tls.Certificate{cert}, NextProtos: []string{laneALPN},
|
||||||
ClientCAs: pool, ClientAuth: tls.RequireAndVerifyClientCert,
|
ClientCAs: pool, ClientAuth: tls.RequireAndVerifyClientCert,
|
||||||
VerifyConnection: func(cs tls.ConnectionState) error {
|
VerifyConnection: func(cs tls.ConnectionState) error {
|
||||||
h.mu.Lock()
|
h.mu.Lock()
|
||||||
h.sni = append(h.sni, cs.ServerName)
|
h.sni = append(h.sni, cs.ServerName)
|
||||||
h.mu.Unlock()
|
h.mu.Unlock()
|
||||||
return nil
|
return nil
|
||||||
}})
|
}}
|
||||||
up := websocket.Upgrader{}
|
up := websocket.Upgrader{}
|
||||||
mux := http.NewServeMux()
|
mux := http.NewServeMux()
|
||||||
mux.HandleFunc("/api/network/bastions/heartbeat", func(w http.ResponseWriter, r *http.Request) {
|
mux.HandleFunc("/api/network/bastions/heartbeat", func(w http.ResponseWriter, r *http.Request) {
|
||||||
@@ -496,10 +509,7 @@ func startLaneHostOn(t *testing.T, raw net.Listener, cert tls.Certificate, clien
|
|||||||
for _, p := range []string{"/bastion-harness", "/bastion-mgmt", "/bastion-egress", "/bastion-serve"} {
|
for _, p := range []string{"/bastion-harness", "/bastion-mgmt", "/bastion-egress", "/bastion-serve"} {
|
||||||
mux.HandleFunc(p, ws)
|
mux.HandleFunc(p, ws)
|
||||||
}
|
}
|
||||||
srv := &http.Server{Handler: mux, ErrorLog: log.New(io.Discard, "", 0)}
|
return h, mux, tc
|
||||||
go func() { _ = srv.Serve(ln) }()
|
|
||||||
t.Cleanup(func() { _ = srv.Close() })
|
|
||||||
return h
|
|
||||||
}
|
}
|
||||||
|
|
||||||
func (h *laneHost) snapshot() (hellos, beats []string) {
|
func (h *laneHost) snapshot() (hellos, beats []string) {
|
||||||
|
|||||||
+43
-11
@@ -111,22 +111,25 @@ Usage:
|
|||||||
anchor anywhere.
|
anchor anywhere.
|
||||||
privatae-bastion approvals [--host <host> | --machine] [--json]
|
privatae-bastion approvals [--host <host> | --machine] [--json]
|
||||||
show what your host is asking to do on this machine, in plain words
|
show what your host is asking to do on this machine, in plain words
|
||||||
privatae-bastion approve [--host <host>] <id>
|
privatae-bastion approve [--host <host> | --machine] <id>
|
||||||
approve one request with a code from the authenticator enrolled here
|
approve one request with a code from the authenticator enrolled here
|
||||||
privatae-bastion deny [--host <host>] <id>
|
privatae-bastion deny [--host <host> | --machine] <id>
|
||||||
refuse one request
|
refuse one request. From the machine's owner account, beside the
|
||||||
|
bastion installed for the whole machine, both act on that bastion,
|
||||||
|
and so do switch (off with nothing, on with the owner's code) and,
|
||||||
|
with nothing, approvals drop, grants drop, ops drop and device-deny
|
||||||
privatae-bastion approvals drop [--host <host>] <id>
|
privatae-bastion approvals drop [--host <host>] <id>
|
||||||
take back an approval this machine issued and has not used yet
|
take back an approval this machine issued and has not used yet
|
||||||
privatae-bastion grants drop <store id> [--host <host>]
|
privatae-bastion grants drop <store id> [--host <host>]
|
||||||
remove a folder grant held on this machine; the host is told
|
remove a folder grant held on this machine; the host is told
|
||||||
privatae-bastion device-init make THIS machine your approval device: from then on a write a
|
privatae-bastion device-init make THIS machine your approval device: from then on a write a
|
||||||
host asks of any machine you govern is approved with a tap here
|
host asks of any machine you govern is approved with a tap here
|
||||||
privatae-bastion device-approvals what your machines are asking you to approve, in their words
|
privatae-bastion device-approvals [--json] what your machines are asking you to approve, in their words
|
||||||
privatae-bastion device-approve <id>|all / device-deny <id>
|
privatae-bastion device-approve <id>|all / device-deny <id>
|
||||||
sudo -H privatae-bastion pin-device <key>
|
sudo -H privatae-bastion pin-device <key>
|
||||||
on a machine you govern: accept approvals signed by your device
|
on a machine you govern: accept approvals signed by your device
|
||||||
(the key device-init printed). unpin-device <key> withdraws it
|
(the key device-init printed). unpin-device <key> withdraws it
|
||||||
privatae-bastion ops [--host <host>] the ops your host wrote that this machine holds, and the
|
privatae-bastion ops [--host <host>] [--json] the ops your host wrote that this machine holds, and the
|
||||||
standing op grants; ops drop <grant> takes one back
|
standing op grants; ops drop <grant> takes one back
|
||||||
sudo -H privatae-bastion root-exec grant [--host <host>] --for <30d>
|
sudo -H privatae-bastion root-exec grant [--host <host>] --for <30d>
|
||||||
let the anchor host run commands AS ROOT here, one at a time,
|
let the anchor host run commands AS ROOT here, one at a time,
|
||||||
@@ -145,11 +148,18 @@ Usage:
|
|||||||
switch one capability family off for a host on this machine,
|
switch one capability family off for a host on this machine,
|
||||||
or clear that refusal (the console page's switch). Off only
|
or clear that refusal (the console page's switch). Off only
|
||||||
removes reach; on grants nothing past the host's signed grant
|
removes reach; on grants nothing past the host's signed grant
|
||||||
privatae-bastion switch --list every paired host's families, on or off, one per line
|
privatae-bastion switch --list [--json]
|
||||||
|
every paired host's families, on or off, one per line
|
||||||
privatae-bastion agents [--json] [--prompts]
|
privatae-bastion agents [--json] [--prompts]
|
||||||
every AI agent on this machine and what it is doing: its
|
every AI agent on this machine and what it is doing: its
|
||||||
session name and title, whether it waits for you, its folder
|
session name and title, whether it waits for you, its folder
|
||||||
and branch, what it is running now (--prompts: its last prompt)
|
and branch, what it is running now (--prompts: its last prompt)
|
||||||
|
privatae-bastion agents show <pid or session> [--json] [--prompts]
|
||||||
|
one agent with everything known about it: what it is, the file
|
||||||
|
it runs, how it was recognised, what it says about itself
|
||||||
|
privatae-bastion doctor [--json]
|
||||||
|
what is wrong with this install, and the fix for each one.
|
||||||
|
Exit 1 when something is
|
||||||
privatae-bastion report [--since 7d] [--json] [--out FILE | --out -]
|
privatae-bastion report [--since 7d] [--json] [--out FILE | --out -]
|
||||||
write what this bastion knows as one Markdown file: agents,
|
write what this bastion knows as one Markdown file: agents,
|
||||||
scheduled agents, MCP tool-server problems, the baseline, activity.
|
scheduled agents, MCP tool-server problems, the baseline, activity.
|
||||||
@@ -173,8 +183,10 @@ Usage:
|
|||||||
denied. Exit 0 stopped (or asked), 1 not, 3 still waiting
|
denied. Exit 0 stopped (or asked), 1 not, 3 still waiting
|
||||||
From the machine's owner account, beside the bastion installed for
|
From the machine's owner account, beside the bastion installed for
|
||||||
the whole machine, the reads (status, agents, schedules,
|
the whole machine, the reads (status, agents, schedules,
|
||||||
tool-servers, posture, baseline, activity, report, approvals)
|
tool-servers, posture, baseline, activity, report, approvals,
|
||||||
ask that bastion and show the whole machine
|
switch --list, ops, device-approvals, backup key show,
|
||||||
|
backup requests, backup shares, doctor) ask that bastion and
|
||||||
|
show the whole machine
|
||||||
privatae-bastion help this text
|
privatae-bastion help this text
|
||||||
privatae-bastion coders set [--max N] [--mem MB] [--cpus F] [--engines a,b|all] [--allow-lan h[:p],...]
|
privatae-bastion coders set [--max N] [--mem MB] [--cpus F] [--engines a,b|all] [--allow-lan h[:p],...]
|
||||||
[--image-prefix <registry/path/>|default]
|
[--image-prefix <registry/path/>|default]
|
||||||
@@ -241,6 +253,7 @@ func takeHostFlag(args []string) (string, []string) {
|
|||||||
|
|
||||||
const pairUsage = "usage: privatae-bastion pair [--replace] [--redeem-url unix:///<socket> | --redeem-url https://<host>:<port>/<path> --host-ca <pem file>] <token> | -\n" +
|
const pairUsage = "usage: privatae-bastion pair [--replace] [--redeem-url unix:///<socket> | --redeem-url https://<host>:<port>/<path> --host-ca <pem file>] <token> | -\n" +
|
||||||
" privatae-bastion pair <pairing code skp_…> | -\n" +
|
" privatae-bastion pair <pairing code skp_…> | -\n" +
|
||||||
|
" privatae-bastion pair --open [--port 8812] (on a server: your Host connects to it with the code this shows)\n" +
|
||||||
" - reads the token or pairing code from standard input, so it stays out of the process list and shell history\n" +
|
" - reads the token or pairing code from standard input, so it stays out of the process list and shell history\n" +
|
||||||
" exit status: 0 paired, 3 already paired with this Host (nothing changed), anything else a failure"
|
" exit status: 0 paired, 3 already paired with this Host (nothing changed), anything else a failure"
|
||||||
|
|
||||||
@@ -303,6 +316,16 @@ func main() {
|
|||||||
case "service":
|
case "service":
|
||||||
err = cmdService(os.Args[2:])
|
err = cmdService(os.Args[2:])
|
||||||
case "pair":
|
case "pair":
|
||||||
|
// pair --open: a pairing window for a Host that connects to this
|
||||||
|
// server (pair_window.go).
|
||||||
|
if addr, open, oerr := parsePairOpenArgs(os.Args[2:]); open {
|
||||||
|
if oerr != nil {
|
||||||
|
fmt.Fprintln(os.Stderr, oerr)
|
||||||
|
os.Exit(2)
|
||||||
|
}
|
||||||
|
err = cmdPairOpen(addr, os.Stdout)
|
||||||
|
break
|
||||||
|
}
|
||||||
token, redeemURL, hostCA, replace, perr := parsePairArgs(os.Args[2:])
|
token, redeemURL, hostCA, replace, perr := parsePairArgs(os.Args[2:])
|
||||||
if perr == nil {
|
if perr == nil {
|
||||||
token, perr = pairToken(token, os.Stdin, stdinIsConsole(), os.Stderr)
|
token, perr = pairToken(token, os.Stdin, stdinIsConsole(), os.Stderr)
|
||||||
@@ -613,7 +636,7 @@ func main() {
|
|||||||
case "device-init":
|
case "device-init":
|
||||||
err = cmdDeviceInit()
|
err = cmdDeviceInit()
|
||||||
case "device-approvals":
|
case "device-approvals":
|
||||||
err = cmdDeviceApprovals()
|
err = cmdDeviceApprovals(os.Args[2:])
|
||||||
case "device-approve", "device-deny":
|
case "device-approve", "device-deny":
|
||||||
if len(os.Args) < 3 {
|
if len(os.Args) < 3 {
|
||||||
fmt.Fprintln(os.Stderr, "usage: privatae-bastion "+os.Args[1]+" <request id> [--code <code>]")
|
fmt.Fprintln(os.Stderr, "usage: privatae-bastion "+os.Args[1]+" <request id> [--code <code>]")
|
||||||
@@ -685,7 +708,7 @@ func main() {
|
|||||||
}
|
}
|
||||||
os.Exit(opActionChildMain(os.Args[2]))
|
os.Exit(opActionChildMain(os.Args[2]))
|
||||||
case "ops":
|
case "ops":
|
||||||
// ops [--host <host>] what ops and op grants this machine holds
|
// ops [--host <host>] [--json] what ops and op grants this machine holds
|
||||||
// ops drop <grant> [--host <host>] take back a held op grant (the host is told)
|
// ops drop <grant> [--host <host>] take back a held op grant (the host is told)
|
||||||
// ops drop --all [--host <host>] take back every op grant the host holds here
|
// ops drop --all [--host <host>] take back every op grant the host holds here
|
||||||
host, args := takeHostFlag(os.Args[2:])
|
host, args := takeHostFlag(os.Args[2:])
|
||||||
@@ -693,7 +716,12 @@ func main() {
|
|||||||
err = cmdOpsDrop(host, args[1])
|
err = cmdOpsDrop(host, args[1])
|
||||||
break
|
break
|
||||||
}
|
}
|
||||||
err = cmdOpsList(host)
|
asJSON, jerr := jsonOnly("usage: privatae-bastion ops [--host <host>] [--json] | ops drop <grant>|--all [--host <host>]", args)
|
||||||
|
if jerr != nil {
|
||||||
|
fmt.Fprintln(os.Stderr, jerr)
|
||||||
|
os.Exit(2)
|
||||||
|
}
|
||||||
|
err = cmdOpsList(host, asJSON)
|
||||||
case "root-exec":
|
case "root-exec":
|
||||||
// root-exec [--host <host>] [grant --for <d> | revoke] (rootexec.go): the
|
// root-exec [--host <host>] [grant --for <d> | revoke] (rootexec.go): the
|
||||||
// standing grant for the anchor host's root commands, given and taken
|
// standing grant for the anchor host's root commands, given and taken
|
||||||
@@ -752,6 +780,10 @@ func main() {
|
|||||||
// baseline show|diff [--json], baseline record [--force]
|
// baseline show|diff [--json], baseline record [--force]
|
||||||
// (machine_cli.go): observe:baseline* under the words people use.
|
// (machine_cli.go): observe:baseline* under the words people use.
|
||||||
err = cmdBaseline(os.Args[2:])
|
err = cmdBaseline(os.Args[2:])
|
||||||
|
case "doctor":
|
||||||
|
// doctor [--json] (doctor.go): what is wrong with this install, and
|
||||||
|
// the fix for each one.
|
||||||
|
err = cmdDoctor(os.Args[2:])
|
||||||
case "help", "-h", "--help":
|
case "help", "-h", "--help":
|
||||||
usage()
|
usage()
|
||||||
case "switch":
|
case "switch":
|
||||||
|
|||||||
@@ -59,6 +59,10 @@ func TestMain(m *testing.M) {
|
|||||||
if len(os.Args) >= 3 && os.Args[1] == opActionChildSubcommand {
|
if len(os.Args) >= 3 && os.Args[1] == opActionChildSubcommand {
|
||||||
os.Exit(opActionChildMain(os.Args[2]))
|
os.Exit(opActionChildMain(os.Args[2]))
|
||||||
}
|
}
|
||||||
|
// The suite never asks the build machine's own loopback for a model
|
||||||
|
// server (llmlocal.go): a llama.cpp left running on 8080 there would make
|
||||||
|
// every lane test depend on it. llmlocal_test.go sets its own.
|
||||||
|
llmProbe = func(string) ([]string, bool) { return nil, false }
|
||||||
if len(os.Args) >= 3 && os.Args[1] == opActionProbeSubcommand {
|
if len(os.Args) >= 3 && os.Args[1] == opActionProbeSubcommand {
|
||||||
os.Exit(opActionProbeMain(os.Args[2]))
|
os.Exit(opActionProbeMain(os.Args[2]))
|
||||||
}
|
}
|
||||||
@@ -138,6 +142,14 @@ func TestMain(m *testing.M) {
|
|||||||
// stops every op unit its names match: the suite's names are its own, so
|
// stops every op unit its names match: the suite's names are its own, so
|
||||||
// it never stops an op the machine's own bastion is running.
|
// it never stops an op the machine's own bastion is running.
|
||||||
opIsolateOpsUnits()
|
opIsolateOpsUnits()
|
||||||
|
// THE FIREWALL IS THE MACHINE'S. A door the suite binds asks for its own
|
||||||
|
// inbound rule (doorfw.go): never in the firewall of the machine running
|
||||||
|
// the suite. The firewall tests stand their own firewalls in.
|
||||||
|
doorFirewallFor = func(string) (doorFirewall, string) { return nil, "" }
|
||||||
|
doorFirewallByID = func(string) doorFirewall { return nil }
|
||||||
|
doorFWExec = func(name string, _ ...string) (string, error) {
|
||||||
|
return "", fmt.Errorf("the suite never runs the machine's firewall (%s)", name)
|
||||||
|
}
|
||||||
|
|
||||||
code := m.Run()
|
code := m.Run()
|
||||||
opIsolatedOpsUnitsDone()
|
opIsolatedOpsUnitsDone()
|
||||||
|
|||||||
+9
-5
@@ -340,14 +340,14 @@ func refuseMgmt(ws *websocket.Conn, why string) {
|
|||||||
// the identity the pairing_* ops are gated on.
|
// the identity the pairing_* ops are gated on.
|
||||||
func runMgmtWorkers(pctx context.Context, self string, wsURL string, tlsCfg *tls.Config,
|
func runMgmtWorkers(pctx context.Context, self string, wsURL string, tlsCfg *tls.Config,
|
||||||
dialHost func(ctx context.Context) (net.Conn, error), bearer, ctxRoot, dcnDir, backupRoot string, n int) {
|
dialHost func(ctx context.Context) (net.Conn, error), bearer, ctxRoot, dcnDir, backupRoot string, n int) {
|
||||||
dialer := &websocket.Dialer{
|
dialer := laneWSDialer(tlsCfg, dialHost)
|
||||||
NetDialContext: func(ctx context.Context, network, addr string) (net.Conn, error) { return dialHost(ctx) },
|
|
||||||
TLSClientConfig: tlsCfg,
|
|
||||||
HandshakeTimeout: 20 * time.Second,
|
|
||||||
}
|
|
||||||
for i := 0; i < n; i++ {
|
for i := 0; i < n; i++ {
|
||||||
go func() {
|
go func() {
|
||||||
|
hold := laneHoldFor(self)
|
||||||
for pctx.Err() == nil {
|
for pctx.Err() == nil {
|
||||||
|
if !hold.waitClear(pctx) {
|
||||||
|
return
|
||||||
|
}
|
||||||
ctx, cancel := context.WithTimeout(pctx, 25*time.Second)
|
ctx, cancel := context.WithTimeout(pctx, 25*time.Second)
|
||||||
ws, _, err := dialer.DialContext(ctx, wsURL, http.Header{})
|
ws, _, err := dialer.DialContext(ctx, wsURL, http.Header{})
|
||||||
cancel()
|
cancel()
|
||||||
@@ -360,6 +360,7 @@ func runMgmtWorkers(pctx context.Context, self string, wsURL string, tlsCfg *tls
|
|||||||
sleepCtx(pctx, time.Second)
|
sleepCtx(pctx, time.Second)
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
|
held := watchHeldClose(ws)
|
||||||
stopKA := armWSKeepalive(ws) // ping/read-deadline: a dead tunnel unblocks the park
|
stopKA := armWSKeepalive(ws) // ping/read-deadline: a dead tunnel unblocks the park
|
||||||
// A revoke while parked: closing the socket is what unblocks the read.
|
// A revoke while parked: closing the socket is what unblocks the read.
|
||||||
unpark := context.AfterFunc(pctx, func() { _ = ws.Close() })
|
unpark := context.AfterFunc(pctx, func() { _ = ws.Close() })
|
||||||
@@ -367,6 +368,9 @@ func runMgmtWorkers(pctx context.Context, self string, wsURL string, tlsCfg *tls
|
|||||||
unpark()
|
unpark()
|
||||||
stopKA()
|
stopKA()
|
||||||
_ = ws.Close()
|
_ = ws.Close()
|
||||||
|
if held() {
|
||||||
|
hold.refused(self) // the Host holds this machine (lanehold.go)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}()
|
}()
|
||||||
}
|
}
|
||||||
|
|||||||
+1
-5
@@ -502,11 +502,7 @@ const mirrorForwardMaxConns = 8
|
|||||||
// inventing a framing layer for no gain.
|
// inventing a framing layer for no gain.
|
||||||
func serveMirrorForward(ctx context.Context, gw, subnet, wsURL string,
|
func serveMirrorForward(ctx context.Context, gw, subnet, wsURL string,
|
||||||
tlsCfg *tls.Config, dialHost func(ctx context.Context) (net.Conn, error), bearer string) {
|
tlsCfg *tls.Config, dialHost func(ctx context.Context) (net.Conn, error), bearer string) {
|
||||||
dialer := &websocket.Dialer{
|
dialer := laneWSDialer(tlsCfg, dialHost)
|
||||||
NetDialContext: func(ctx context.Context, network, addr string) (net.Conn, error) { return dialHost(ctx) },
|
|
||||||
TLSClientConfig: tlsCfg,
|
|
||||||
HandshakeTimeout: 20 * time.Second,
|
|
||||||
}
|
|
||||||
var allowed *net.IPNet
|
var allowed *net.IPNet
|
||||||
if subnet != "" {
|
if subnet != "" {
|
||||||
if _, n, err := net.ParseCIDR(subnet); err == nil {
|
if _, n, err := net.ParseCIDR(subnet); err == nil {
|
||||||
|
|||||||
+3
-2
@@ -129,8 +129,9 @@ func cmdSetMode(mode string) error {
|
|||||||
if mode == modeNetworked {
|
if mode == modeNetworked {
|
||||||
// Platform-correct, for the same reason the refusal text is: telling a
|
// Platform-correct, for the same reason the refusal text is: telling a
|
||||||
// Windows user to run `sudo` is how a real instruction becomes noise.
|
// Windows user to run `sudo` is how a real instruction becomes noise.
|
||||||
fmt.Printf(" Next: anchor this machine to your host — %s\n", anchorCommandHint())
|
fmt.Println(" Next: pair it with the Host that should be in charge of it. That Host takes charge as it is")
|
||||||
fmt.Println(" Every host paired after the anchor waits, pending, until the anchor host approves it.")
|
fmt.Println(" paired (a Host on this machine always does; so does one an organisation's policy names), and every")
|
||||||
|
fmt.Println(" other Host waits until it admits it. To put a Host already paired in charge: " + anchorCommandHint())
|
||||||
}
|
}
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -362,26 +362,3 @@ func utf16Len(s string) int {
|
|||||||
}
|
}
|
||||||
return n
|
return n
|
||||||
}
|
}
|
||||||
|
|
||||||
// secondRunNotice is runguard_windows.go's refusal, written for a dialog box
|
|
||||||
// rather than for a terminal.
|
|
||||||
//
|
|
||||||
// It is deliberately NOT the same string as the error that goes to stderr. That
|
|
||||||
// one is laid out for a console — indented continuation lines, "you can close
|
|
||||||
// this window" meaning the console window — and the two media want different
|
|
||||||
// words for the same fact. They live next to each other (runguard_windows.go) so
|
|
||||||
// they are maintained together.
|
|
||||||
//
|
|
||||||
// The length caps above do NOT apply here: MessageBoxW takes an ordinary
|
|
||||||
// null-terminated string with no fixed buffer, unlike the notification-area
|
|
||||||
// struct.
|
|
||||||
func secondRunNotice() uiNotice {
|
|
||||||
return uiNotice{
|
|
||||||
Title: "Privatae bastion is already running",
|
|
||||||
Body: "This machine is already serving your hosts.\r\n\r\n" +
|
|
||||||
"A second copy would fight the first one for the same local ports, so this " +
|
|
||||||
"one is stopping. Nothing is wrong and nothing has stopped working.\r\n\r\n" +
|
|
||||||
"If you believe the running one is dead, end privatae-bastion.exe in Task " +
|
|
||||||
"Manager and start this again.",
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|||||||
@@ -53,6 +53,7 @@ import (
|
|||||||
"errors"
|
"errors"
|
||||||
"fmt"
|
"fmt"
|
||||||
"io"
|
"io"
|
||||||
|
"io/fs"
|
||||||
"os"
|
"os"
|
||||||
"os/exec"
|
"os/exec"
|
||||||
"os/user"
|
"os/user"
|
||||||
@@ -648,7 +649,12 @@ func opUpperChanges(upper, hostRoot string) ([]opChange, error) {
|
|||||||
out = append(out, opChange{Path: real, Kind: "special"})
|
out = append(out, opChange{Path: real, Kind: "special"})
|
||||||
return nil
|
return nil
|
||||||
case mode.IsDir():
|
case mode.IsDir():
|
||||||
if opaque, _ := opXattrOpaque(p); opaque {
|
// Opaque hides what the lower holds at this path: a replaced
|
||||||
|
// tree, refused. With nothing there it hides nothing. A kernel
|
||||||
|
// whose overlay has index, redirect_dir or metacopy on marks every
|
||||||
|
// new folder under an existing one opaque, so such a folder is
|
||||||
|
// created, and its contents are read like any other.
|
||||||
|
if opaque, _ := opXattrOpaque(p); opaque && !errors.Is(lowerErr, fs.ErrNotExist) {
|
||||||
out = append(out, opChange{Path: real, Kind: "opaque"})
|
out = append(out, opChange{Path: real, Kind: "opaque"})
|
||||||
return filepath.SkipDir
|
return filepath.SkipDir
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -13,6 +13,8 @@ import (
|
|||||||
"strings"
|
"strings"
|
||||||
"testing"
|
"testing"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
|
"golang.org/x/sys/unix"
|
||||||
)
|
)
|
||||||
|
|
||||||
// ── the upper-dir reader (no sandbox needed) ────────────────────────────────
|
// ── the upper-dir reader (no sandbox needed) ────────────────────────────────
|
||||||
@@ -102,6 +104,42 @@ func TestUpperChangesReadCreatedModifiedAndLinks(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// A kernel whose overlay has index, redirect_dir or metacopy on marks each
|
||||||
|
// new folder under an existing one opaque. Over nothing the machine holds,
|
||||||
|
// such a folder is created and what it holds is read; over a folder the
|
||||||
|
// machine holds, opaque is a replaced tree, and refused.
|
||||||
|
func TestAnOpaqueNewFolderIsCreatedAndAReplacedOneIsRefused(t *testing.T) {
|
||||||
|
lower := t.TempDir()
|
||||||
|
upper := t.TempDir()
|
||||||
|
_ = os.MkdirAll(filepath.Join(lower, "srv/kept"), 0o755)
|
||||||
|
_ = os.WriteFile(filepath.Join(lower, "srv/kept/old.txt"), []byte("old\n"), 0o644)
|
||||||
|
for _, d := range []string{"srv/new", "srv/kept"} {
|
||||||
|
_ = os.MkdirAll(filepath.Join(upper, d), 0o755)
|
||||||
|
if err := unix.Setxattr(filepath.Join(upper, d), "trusted.overlay.opaque", []byte("y"), 0); err != nil {
|
||||||
|
t.Skipf("cannot set an overlay attribute here (%v): needs root on a filesystem with trusted attributes", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
_ = os.WriteFile(filepath.Join(upper, "srv/new/hello.txt"), []byte("hi\n"), 0o644)
|
||||||
|
changes, err := opUpperChanges(upper, lower)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
got := map[string]string{}
|
||||||
|
for _, c := range changes {
|
||||||
|
got[strings.TrimPrefix(c.Path, lower)] = c.Kind
|
||||||
|
}
|
||||||
|
if got["/srv/new"] != "created_dir" || got["/srv/new/hello.txt"] != "created" {
|
||||||
|
t.Fatalf("an opaque folder over nothing is created, with what it holds: %v", got)
|
||||||
|
}
|
||||||
|
if got["/srv/kept"] != "opaque" {
|
||||||
|
t.Fatalf("an opaque folder over one the machine holds is a replaced tree: %v", got)
|
||||||
|
}
|
||||||
|
m := &opManifest{Effects: opEffects{Files: []string{lower + "/srv/"}}}
|
||||||
|
if why := opEffectsViolation(m, &opReport{Changes: changes}); !strings.Contains(why, "opaque") {
|
||||||
|
t.Fatalf("the replaced tree is refused even inside the effects: %q", why)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func TestHostMountsAndEffectPrefix(t *testing.T) {
|
func TestHostMountsAndEffectPrefix(t *testing.T) {
|
||||||
mounts := []opHostMount{{"/", "ext4"}, {"/srv", "xfs"}, {"/srv/share", "nfs4"}, {"/proc", "proc"}, {"/home", "ext4"}}
|
mounts := []opHostMount{{"/", "ext4"}, {"/srv", "xfs"}, {"/srv/share", "nfs4"}, {"/proc", "proc"}, {"/home", "ext4"}}
|
||||||
for p, want := range map[string]string{
|
for p, want := range map[string]string{
|
||||||
|
|||||||
@@ -0,0 +1,319 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
// owneracts.go — the machine's owner acts on its bastion from their own
|
||||||
|
// account (plan Addendum 6, slice 4).
|
||||||
|
//
|
||||||
|
// Installed for the whole machine, the bastion keeps its approvals and its
|
||||||
|
// local switch in root's state, so `approve`, `deny` and `switch` from the
|
||||||
|
// owner's account acted on an empty bastion of that account's own: an ask
|
||||||
|
// waiting for the owner was "not found", and a switch was refused for want of
|
||||||
|
// sudo. The owner's console session (consolelane.go) has always been able to
|
||||||
|
// do these, so ask.sock now does exactly the same for the same account, with
|
||||||
|
// the same rules:
|
||||||
|
//
|
||||||
|
// - approve (the machine's own asks, or a Host's) takes the owner's code,
|
||||||
|
// spent and counted as the console spends it (machineCodeSpend for the
|
||||||
|
// machine's, codeSpend for a Host's), so wrong codes lock the same way;
|
||||||
|
// - switching a family back on takes the owner's code (ownerCodeRefusal),
|
||||||
|
// as the console's switch does;
|
||||||
|
// - deny, and switching a family off, never do: they only take reach away.
|
||||||
|
//
|
||||||
|
// Only the owner's account is answered (readLaneRefusal), as for the reads.
|
||||||
|
// Each act is one line in the machine's audit log naming the account, beside
|
||||||
|
// the approve or deny row its own function writes.
|
||||||
|
|
||||||
|
import (
|
||||||
|
"bufio"
|
||||||
|
"encoding/json"
|
||||||
|
"errors"
|
||||||
|
"fmt"
|
||||||
|
"io"
|
||||||
|
"os"
|
||||||
|
"strings"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
type agentActReply struct {
|
||||||
|
OK bool `json:"ok"`
|
||||||
|
Why string `json:"why,omitempty"`
|
||||||
|
Done string `json:"done,omitempty"`
|
||||||
|
// Failed: answered for this account, and not done (Why says why); the
|
||||||
|
// administrator would be told the same, so it is not a refusal.
|
||||||
|
Failed bool `json:"failed,omitempty"`
|
||||||
|
User string `json:"user,omitempty"`
|
||||||
|
}
|
||||||
|
|
||||||
|
var actNow = time.Now
|
||||||
|
|
||||||
|
func serveAct(uid uint32, user string, req agentAskRequest) (r agentActReply) {
|
||||||
|
return serveActFor(askPeer{UID: uid, Name: user}, req)
|
||||||
|
}
|
||||||
|
|
||||||
|
func serveActFor(peer askPeer, req agentAskRequest) (r agentActReply) {
|
||||||
|
user := peer.Name
|
||||||
|
r.User = user
|
||||||
|
if why := readLaneRefusalFor(peer); why != "" {
|
||||||
|
r.Why = actWording(why)
|
||||||
|
return r
|
||||||
|
}
|
||||||
|
defer func() {
|
||||||
|
// The root daemon serves every pairing: an act that panics is that
|
||||||
|
// act's failure, never the daemon's end (as runMachineRead does).
|
||||||
|
if p := recover(); p != nil {
|
||||||
|
uilogf("owner act %q panicked: %v\n", req.Act, p)
|
||||||
|
r = agentActReply{User: user, Failed: true, Why: "this act failed inside the machine's bastion; its log says why"}
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
done, what, err := runOwnerAct(req)
|
||||||
|
if err != nil {
|
||||||
|
r.Failed, r.Why = true, err.Error()
|
||||||
|
return r
|
||||||
|
}
|
||||||
|
ownerActAudit(what, user, peer.windows())
|
||||||
|
r.OK, r.Done = true, done
|
||||||
|
return r
|
||||||
|
}
|
||||||
|
|
||||||
|
// runOwnerAct does one act; what names it, as resolved, for the audit row.
|
||||||
|
func runOwnerAct(req agentAskRequest) (done, what string, err error) {
|
||||||
|
switch req.Act {
|
||||||
|
case "approve", "deny":
|
||||||
|
t, err := resolveStepupTarget(req.Host, req.Machine)
|
||||||
|
if err != nil {
|
||||||
|
return "", "", err
|
||||||
|
}
|
||||||
|
if !t.machine() {
|
||||||
|
// The console's rule for a Host's request, approve and deny alike
|
||||||
|
// (ui.go approve and deny both take approvalTarget): only a pairing
|
||||||
|
// this machine serves is answered.
|
||||||
|
if _, err := approvalTarget(t.host); err != nil {
|
||||||
|
return "", "", err
|
||||||
|
}
|
||||||
|
}
|
||||||
|
m := lockedRequests(t.dir)
|
||||||
|
id, err := findRequest(m, req.ID)
|
||||||
|
if err != nil {
|
||||||
|
return "", "", err
|
||||||
|
}
|
||||||
|
target := "the machine's"
|
||||||
|
if !t.machine() {
|
||||||
|
target = "a Host's (" + t.host + ")"
|
||||||
|
}
|
||||||
|
what = req.Act + " " + target + " request " + id
|
||||||
|
if req.Act == "deny" {
|
||||||
|
if err := stepupDenyRequest(t.dir, id); err != nil {
|
||||||
|
return "", "", err
|
||||||
|
}
|
||||||
|
return "denied.", what, nil
|
||||||
|
}
|
||||||
|
if !stepupEnrolled(t.dir) {
|
||||||
|
return "", "", fmt.Errorf("no second factor is enrolled %s", t.forWhom())
|
||||||
|
}
|
||||||
|
code := strings.TrimSpace(req.Code)
|
||||||
|
if code == "" {
|
||||||
|
return "", "", errors.New("approving takes the code from your authenticator")
|
||||||
|
}
|
||||||
|
spend := func() (string, error) { return stepupApproveRequest(t.dir, id, code) }
|
||||||
|
var err2 error
|
||||||
|
if t.machine() {
|
||||||
|
_, err2 = machineCodeSpend(t.dir, actNow(), spend)
|
||||||
|
} else {
|
||||||
|
_, err2 = codeSpend(t.dir, actNow(), hostCodeLockedHint, spend)
|
||||||
|
}
|
||||||
|
if err2 != nil {
|
||||||
|
return "", "", err2
|
||||||
|
}
|
||||||
|
if t.machine() {
|
||||||
|
return "approved.", what, nil
|
||||||
|
}
|
||||||
|
return "approved. " + t.host + " picks this up on its next check-in, within a minute.", what, nil
|
||||||
|
case "switch":
|
||||||
|
host, err := switchResolveHost(req.Host)
|
||||||
|
if err != nil {
|
||||||
|
return "", "", err
|
||||||
|
}
|
||||||
|
family := strings.TrimSpace(req.Family)
|
||||||
|
if !req.Off {
|
||||||
|
if why := ownerCodeRefusal(req.Code, "local_switch_on|"+host+"|"+family); why != "" {
|
||||||
|
return "", "", errors.New(strings.TrimSuffix(why, "."))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if err := localDenySet(host, family, req.Off); err != nil {
|
||||||
|
return "", "", err
|
||||||
|
}
|
||||||
|
state := "on"
|
||||||
|
if req.Off {
|
||||||
|
state = "off"
|
||||||
|
}
|
||||||
|
return switchDoneText(host, family, req.Off), "switch " + cleanText(host, 80) + " " + cleanText(family, 40) + " " + state, nil
|
||||||
|
case "approvals-drop", "grants-drop", "ops-drop", "device-deny":
|
||||||
|
// Narrowing acts: each only takes reach away, so no code, and each
|
||||||
|
// is the command's own core, run where the machine's state is.
|
||||||
|
var run func() (string, error)
|
||||||
|
switch req.Act {
|
||||||
|
case "approvals-drop":
|
||||||
|
run = func() (string, error) { return stepupDropText(req.Host, req.Machine, req.ID) }
|
||||||
|
case "grants-drop":
|
||||||
|
run = func() (string, error) { return grantsDropText(req.Host, req.ID) }
|
||||||
|
case "ops-drop":
|
||||||
|
run = func() (string, error) { return opsDropText(req.Host, req.ID) }
|
||||||
|
default:
|
||||||
|
run = func() (string, error) { return deviceDenyText(req.ID) }
|
||||||
|
}
|
||||||
|
done, err := run()
|
||||||
|
if err != nil {
|
||||||
|
return "", "", err
|
||||||
|
}
|
||||||
|
what = req.Act + " " + cleanText(req.ID, 40)
|
||||||
|
if req.Host != "" {
|
||||||
|
what += " for " + cleanText(req.Host, 80)
|
||||||
|
}
|
||||||
|
return done, what, nil
|
||||||
|
}
|
||||||
|
return "", "", fmt.Errorf("this bastion has no act called %q", cleanText(req.Act, 40))
|
||||||
|
}
|
||||||
|
|
||||||
|
// lockedRequests reads a factor's requests under stepupMu, released however
|
||||||
|
// the read ends: the daemon recovers a panicking act (serveAct), and a lock
|
||||||
|
// left held would hang every approval after it.
|
||||||
|
func lockedRequests(dir string) map[string]stepupRequest {
|
||||||
|
stepupMu.Lock()
|
||||||
|
defer stepupMu.Unlock()
|
||||||
|
requestsLoadHook()
|
||||||
|
return requestsLoad(dir)
|
||||||
|
}
|
||||||
|
|
||||||
|
// requestsLoadHook is a seam for a test that makes the read panic.
|
||||||
|
var requestsLoadHook = func() {}
|
||||||
|
|
||||||
|
// switchDoneText is what a switch says it did, from the terminal or the lane.
|
||||||
|
func switchDoneText(host, family string, off bool) string {
|
||||||
|
if off {
|
||||||
|
return host + " " + family + " off: this machine now refuses it, and tells the host why. Its grant is untouched."
|
||||||
|
}
|
||||||
|
return host + " " + family + " on: the refusal is cleared, up to whatever its signed grant already allowed."
|
||||||
|
}
|
||||||
|
|
||||||
|
// ownerActAudit is the act's line in the machine's audit log. The owner's
|
||||||
|
// factor directory is made if it is not there yet (a deny or a switch off
|
||||||
|
// needs no code set up): dcnAuditWith joins its directory onto audit.jsonl,
|
||||||
|
// and "" would be the daemon's working directory.
|
||||||
|
func ownerActAudit(what, user string, pipe bool) {
|
||||||
|
dir, err := machineFactorDir()
|
||||||
|
if err != nil {
|
||||||
|
uilogf("owner act not audited (%v): %s, from %s\n", err, what, user)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
lane := "its ask socket"
|
||||||
|
if pipe {
|
||||||
|
lane = "its ask pipe"
|
||||||
|
}
|
||||||
|
dcnAuditWith(dir, "owner_lane_act", 0, "",
|
||||||
|
what+", from the owner's account "+user+" through "+lane, nil)
|
||||||
|
}
|
||||||
|
|
||||||
|
// ── the asking side ─────────────────────────────────────────────────────────
|
||||||
|
|
||||||
|
func actViaSock(req agentAskRequest) (string, error) {
|
||||||
|
p := askLaneAddr(readSockPath())
|
||||||
|
c, err := dialAskLane(readSockPath())
|
||||||
|
if err != nil {
|
||||||
|
return "", &laneError{down: true, why: "nothing answers on " + p + " (" + err.Error() + ")"}
|
||||||
|
}
|
||||||
|
defer c.Close()
|
||||||
|
_ = c.SetDeadline(time.Now().Add(30 * time.Second))
|
||||||
|
req.Op = "act"
|
||||||
|
if err := json.NewEncoder(c).Encode(req); err != nil {
|
||||||
|
return "", &laneError{down: true, why: "the act could not be sent (" + err.Error() + ")"}
|
||||||
|
}
|
||||||
|
var r agentActReply
|
||||||
|
if err := json.NewDecoder(io.LimitReader(c, askMaxBytes)).Decode(&r); err != nil {
|
||||||
|
return "", &laneError{down: true, why: "the machine's bastion did not answer (" + err.Error() + ")"}
|
||||||
|
}
|
||||||
|
if !r.OK && r.Failed {
|
||||||
|
return "", errors.New(r.Why)
|
||||||
|
}
|
||||||
|
if !r.OK {
|
||||||
|
return "", &laneError{why: r.Why}
|
||||||
|
}
|
||||||
|
return r.Done, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// ownerApproveViaLane shows the request the machine's bastion holds, takes
|
||||||
|
// the owner's code at this terminal, and asks the bastion to approve it.
|
||||||
|
func ownerApproveViaLane(host string, machine bool, prefix string) error {
|
||||||
|
v, err := readMachine("approvals", readOpts{Host: host, Machine: machine}, readApprovals)
|
||||||
|
if err != nil {
|
||||||
|
// Refused, the read is refused as the approve it was read for.
|
||||||
|
var le *laneError
|
||||||
|
if errors.As(err, &le) && !le.down {
|
||||||
|
err = &laneError{why: actWording(le.why)}
|
||||||
|
}
|
||||||
|
return laneRefusalError(stepupCommand("approve", host, machine, prefix), err)
|
||||||
|
}
|
||||||
|
if !v.CodeSetUp {
|
||||||
|
return fmt.Errorf("no second factor is enrolled %s, so nothing can be approved yet", v.For)
|
||||||
|
}
|
||||||
|
var hit *approvalWaiting
|
||||||
|
for i := range v.Waiting {
|
||||||
|
if strings.HasPrefix(v.Waiting[i].ID, prefix) || strings.HasPrefix(prefix, v.Waiting[i].ID) {
|
||||||
|
if hit != nil {
|
||||||
|
return fmt.Errorf("more than one waiting request starts with %q; give more of its id", prefix)
|
||||||
|
}
|
||||||
|
hit = &v.Waiting[i]
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if hit == nil {
|
||||||
|
return fmt.Errorf("nothing waiting %s starts with %q; `privatae-bastion approvals%s` lists them",
|
||||||
|
v.For, prefix, map[bool]string{true: " --machine", false: ""}[machine])
|
||||||
|
}
|
||||||
|
fmt.Println(hit.Text)
|
||||||
|
fmt.Println()
|
||||||
|
code, ok := promptOwnerCode("Approve this? Enter the code from your authenticator (or leave empty to cancel): ")
|
||||||
|
if !ok {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
// The bastion finds the request again by this id: the one shown, never
|
||||||
|
// fewer characters of it than shown. Sent as typed, a short prefix would
|
||||||
|
// approve whatever request matched it by then (one an agent filed while
|
||||||
|
// the person typed, say), which is not what they read.
|
||||||
|
id := hit.ID
|
||||||
|
if len(prefix) > len(id) {
|
||||||
|
id = prefix
|
||||||
|
}
|
||||||
|
done, err := actViaSock(agentAskRequest{Act: "approve", Host: host, Machine: machine, ID: id, Code: code})
|
||||||
|
if err != nil {
|
||||||
|
return laneRefusalError(stepupCommand("approve", host, machine, prefix), err)
|
||||||
|
}
|
||||||
|
fmt.Println(done)
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// actWording is the reads' refusal said of an act.
|
||||||
|
func actWording(why string) string {
|
||||||
|
return strings.Replace(why, "answers reads only for", "acts only for", 1)
|
||||||
|
}
|
||||||
|
|
||||||
|
// stepupCommand is approve or deny as the administrator would type it here.
|
||||||
|
func stepupCommand(verb, host string, machine bool, id string) string {
|
||||||
|
switch {
|
||||||
|
case machine:
|
||||||
|
return verb + " --machine " + id
|
||||||
|
case host != "":
|
||||||
|
return verb + " --host " + host + " " + id
|
||||||
|
}
|
||||||
|
return verb + " " + id
|
||||||
|
}
|
||||||
|
|
||||||
|
// promptOwnerCode reads a code from this terminal; ok is false when the
|
||||||
|
// person left it empty, and then nothing is done (said here).
|
||||||
|
var promptOwnerCode = func(prompt string) (string, bool) {
|
||||||
|
fmt.Print(prompt)
|
||||||
|
code, _ := bufio.NewReader(os.Stdin).ReadString('\n')
|
||||||
|
code = strings.TrimSpace(code)
|
||||||
|
if code == "" {
|
||||||
|
fmt.Println("cancelled — nothing done")
|
||||||
|
return "", false
|
||||||
|
}
|
||||||
|
return code, true
|
||||||
|
}
|
||||||
@@ -0,0 +1,504 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"errors"
|
||||||
|
"os"
|
||||||
|
"path/filepath"
|
||||||
|
"strings"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
// stubCode answers the owner's code prompt with code ("" = left empty).
|
||||||
|
func stubCode(t *testing.T, code string) *int {
|
||||||
|
t.Helper()
|
||||||
|
asked := 0
|
||||||
|
prev := promptOwnerCode
|
||||||
|
t.Cleanup(func() { promptOwnerCode = prev })
|
||||||
|
promptOwnerCode = func(string) (string, bool) { asked++; return code, code != "" }
|
||||||
|
return &asked
|
||||||
|
}
|
||||||
|
|
||||||
|
// From the owner's account, beside the machine's bastion, approve answers a
|
||||||
|
// stop ask the machine holds, with the owner's code: before, it looked in
|
||||||
|
// that account's own empty state and said the request did not exist.
|
||||||
|
func TestTheOwnerApprovesTheMachinesAskThroughTheLane(t *testing.T) {
|
||||||
|
d := askFlowWorld(t)
|
||||||
|
r := fileAsk(agentAskRequest{Op: "stop", PID: 101}, "u", 311)
|
||||||
|
if !r.OK {
|
||||||
|
t.Fatalf("ask refused: %s", r.Why)
|
||||||
|
}
|
||||||
|
laneOwner(t, laneTestUID)
|
||||||
|
laneSock(t)
|
||||||
|
out := captureStdout(t)
|
||||||
|
stubCode(t, codeFor(t, machineTestSecret))
|
||||||
|
if err := cmdStepupApprove("", true, r.Request); err != nil {
|
||||||
|
t.Fatalf("approve through the lane: %v", err)
|
||||||
|
}
|
||||||
|
if got := requestsLoad(d)[fullRequestID(t, d, r.Request)].State; got != "approved" {
|
||||||
|
t.Errorf("the machine's request is %q after the owner approved it", got)
|
||||||
|
}
|
||||||
|
if got := printedSince(out, 0, "approved."); !strings.Contains(got, "approved.") {
|
||||||
|
t.Errorf("printed %q", got)
|
||||||
|
}
|
||||||
|
// The kernel's name for this account: the harness maps only its uid to
|
||||||
|
// the owner's, so the name is the test process's own.
|
||||||
|
raw, _ := os.ReadFile(filepath.Join(d, "audit.jsonl"))
|
||||||
|
if !strings.Contains(string(raw), `"op":"owner_lane_act"`) ||
|
||||||
|
!strings.Contains(string(raw), "from the owner's account ") {
|
||||||
|
t.Errorf("the act is not in the audit log with the account that acted:\n%s", raw)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A wrong code approves nothing and counts against the owner's code, as the
|
||||||
|
// console's does; an empty one sends nothing.
|
||||||
|
func TestAWrongCodeThroughTheLaneApprovesNothing(t *testing.T) {
|
||||||
|
d := askFlowWorld(t)
|
||||||
|
r := fileAsk(agentAskRequest{Op: "stop", PID: 101}, "u", 311)
|
||||||
|
laneOwner(t, laneTestUID)
|
||||||
|
laneSock(t)
|
||||||
|
captureStdout(t)
|
||||||
|
stubCode(t, "000000")
|
||||||
|
err := cmdStepupApprove("", true, r.Request)
|
||||||
|
var le *laneError
|
||||||
|
if err == nil || errors.As(err, &le) {
|
||||||
|
t.Errorf("a wrong code: %v (want the bastion's refusal, not a lane refusal)", err)
|
||||||
|
}
|
||||||
|
if got := requestsLoad(d)[fullRequestID(t, d, r.Request)].State; got != "pending" {
|
||||||
|
t.Errorf("a wrong code left the request %q", got)
|
||||||
|
}
|
||||||
|
asked := stubCode(t, "")
|
||||||
|
if err := cmdStepupApprove("", true, r.Request); err != nil || *asked != 1 {
|
||||||
|
t.Errorf("an empty code: %v, asked %d", err, *asked)
|
||||||
|
}
|
||||||
|
// MUTATION: spend the code without machineCodeSpend. RESULT: red, a wrong
|
||||||
|
// code no longer counts.
|
||||||
|
stepupMu.Lock()
|
||||||
|
n := pipeThrottleLoad(d).Failures
|
||||||
|
stepupMu.Unlock()
|
||||||
|
if n < 1 {
|
||||||
|
t.Errorf("the wrong code was not counted (%d)", n)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Deny takes no code: refusing only takes reach away.
|
||||||
|
func TestTheOwnerDeniesThroughTheLaneWithNoCode(t *testing.T) {
|
||||||
|
d := askFlowWorld(t)
|
||||||
|
r := fileAsk(agentAskRequest{Op: "stop", PID: 101}, "u", 311)
|
||||||
|
laneOwner(t, laneTestUID)
|
||||||
|
laneSock(t)
|
||||||
|
captureStdout(t)
|
||||||
|
asked := stubCode(t, "")
|
||||||
|
if err := cmdStepupDeny("", true, r.Request); err != nil {
|
||||||
|
t.Fatalf("deny through the lane: %v", err)
|
||||||
|
}
|
||||||
|
if got := requestsLoad(d)[fullRequestID(t, d, r.Request)].State; got != "denied" || *asked != 0 {
|
||||||
|
t.Errorf("deny left %q, asked for a code %d times", got, *asked)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The local switch from the owner's account: off with nothing, on only with
|
||||||
|
// the owner's code (the console's switch rule).
|
||||||
|
func TestTheOwnerSwitchesThroughTheLane(t *testing.T) {
|
||||||
|
askFlowWorld(t)
|
||||||
|
const host = "box-one.example"
|
||||||
|
givenPairing(t, host, pairingActive)
|
||||||
|
laneOwner(t, laneTestUID)
|
||||||
|
laneSock(t)
|
||||||
|
captureStdout(t)
|
||||||
|
if err := cmdSwitch([]string{host, "ops", "off"}); err != nil {
|
||||||
|
t.Fatalf("switch off: %v", err)
|
||||||
|
}
|
||||||
|
if !localDenied(host, "ops") {
|
||||||
|
t.Fatal("ops is not off after the owner switched it off")
|
||||||
|
}
|
||||||
|
stubCode(t, "000000")
|
||||||
|
if err := cmdSwitch([]string{host, "ops", "on"}); err == nil || !localDenied(host, "ops") {
|
||||||
|
t.Errorf("switch on with a wrong code: %v, still off %v", err, localDenied(host, "ops"))
|
||||||
|
}
|
||||||
|
stubCode(t, codeFor(t, machineTestSecret))
|
||||||
|
if err := cmdSwitch([]string{host, "ops", "on"}); err != nil || localDenied(host, "ops") {
|
||||||
|
t.Errorf("switch on with the owner's code: %v, still off %v", err, localDenied(host, "ops"))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Any other account is refused every act, with the administrator's command.
|
||||||
|
func TestAnotherAccountIsRefusedEveryAct(t *testing.T) {
|
||||||
|
d := askFlowWorld(t)
|
||||||
|
r := fileAsk(agentAskRequest{Op: "stop", PID: 101}, "u", 311)
|
||||||
|
laneOwner(t, laneTestUID+1)
|
||||||
|
laneSock(t)
|
||||||
|
captureStdout(t)
|
||||||
|
stubCode(t, codeFor(t, machineTestSecret))
|
||||||
|
for name, run := range map[string]func() error{
|
||||||
|
"approve": func() error { return cmdStepupApprove("", true, r.Request) },
|
||||||
|
"deny": func() error { return cmdStepupDeny("", true, r.Request) },
|
||||||
|
"switch off": func() error { return cmdSwitch([]string{"box-one.example", "ops", "off"}) },
|
||||||
|
} {
|
||||||
|
err := run()
|
||||||
|
if err == nil || !strings.Contains(err.Error(), "acts only for its owner's account") || !strings.Contains(err.Error(), "sudo -H") {
|
||||||
|
t.Errorf("%s from another account: %v", name, err)
|
||||||
|
}
|
||||||
|
if (name == "approve" || name == "deny") && !strings.Contains(err.Error(), "sudo -H privatae-bastion "+name+" --machine "+r.Request) {
|
||||||
|
t.Errorf("the administrator's command does not name the request: %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
// The list, refused, is given back as the administrator types it for the
|
||||||
|
// same requests: the machine's own, not a Host's.
|
||||||
|
if err := cmdStepupApprovals("", true, false); err == nil || !strings.Contains(err.Error(), "answers reads only for its owner's account") ||
|
||||||
|
!strings.HasSuffix(err.Error(), "sudo -H privatae-bastion approvals --machine") {
|
||||||
|
t.Errorf("approvals --machine from another account: %v", err)
|
||||||
|
}
|
||||||
|
if got := requestsLoad(d)[fullRequestID(t, d, r.Request)].State; got != "pending" {
|
||||||
|
t.Errorf("another account's deny left the request %q", got)
|
||||||
|
}
|
||||||
|
if rep := serveAct(laneTestUID, "lee", agentAskRequest{Act: "approve", Machine: true, ID: r.Request,
|
||||||
|
Code: codeFor(t, machineTestSecret)}); rep.OK {
|
||||||
|
t.Error("another account approved the machine's request")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestAnActTheBastionDoesNotHaveFails(t *testing.T) {
|
||||||
|
askFlowWorld(t)
|
||||||
|
laneOwner(t, laneTestUID)
|
||||||
|
if rep := serveAct(laneTestUID, "sam", agentAskRequest{Act: "uninstall"}); rep.OK || !rep.Failed ||
|
||||||
|
!strings.Contains(rep.Why, "no act called") {
|
||||||
|
t.Errorf("an unknown act: %+v", rep)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Approve through the lane approves the request it showed, or nothing: a
|
||||||
|
// short prefix sent as typed was found again by the bastion after the code was
|
||||||
|
// entered, so a request that came to match it meanwhile (the shown one denied,
|
||||||
|
// another filed) was approved in its place.
|
||||||
|
func TestTheLaneApprovesOnlyTheRequestItShowed(t *testing.T) {
|
||||||
|
d := askFlowWorld(t)
|
||||||
|
r := fileAsk(agentAskRequest{Op: "stop", PID: 101}, "u", 311)
|
||||||
|
if !r.OK {
|
||||||
|
t.Fatalf("ask refused: %s", r.Why)
|
||||||
|
}
|
||||||
|
shown := fullRequestID(t, d, r.Request)
|
||||||
|
// Same first character, different from the second on.
|
||||||
|
other := shown[:1] + string("0123456789abcdef"[(strings.IndexByte("0123456789abcdef", shown[1])+1)%16]) + shown[2:]
|
||||||
|
laneOwner(t, laneTestUID)
|
||||||
|
laneSock(t)
|
||||||
|
captureStdout(t)
|
||||||
|
code := codeFor(t, machineTestSecret)
|
||||||
|
prev := promptOwnerCode
|
||||||
|
t.Cleanup(func() { promptOwnerCode = prev })
|
||||||
|
promptOwnerCode = func(string) (string, bool) {
|
||||||
|
// While the person types: the shown request is answered, and another
|
||||||
|
// matching the typed prefix is waiting.
|
||||||
|
stepupMu.Lock()
|
||||||
|
m := requestsLoad(d)
|
||||||
|
rec := m[shown]
|
||||||
|
m[other] = rec
|
||||||
|
_ = requestsSave(d, m)
|
||||||
|
stepupMu.Unlock()
|
||||||
|
if err := stepupDenyRequest(d, shown); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
return code, true
|
||||||
|
}
|
||||||
|
// MUTATION: send the typed prefix (ID: prefix). RESULT: red, the other
|
||||||
|
// request is approved.
|
||||||
|
err := cmdStepupApprove("", true, shown[:1])
|
||||||
|
if got := requestsLoad(d)[other].State; got != "pending" {
|
||||||
|
t.Fatalf("a request the person was never shown is %q after they approved the one they were shown (%v)", got, err)
|
||||||
|
}
|
||||||
|
if err == nil {
|
||||||
|
t.Error("approving a request answered meanwhile said nothing")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A Host's request is approved through the lane only for a pairing this
|
||||||
|
// machine serves, as the console's approve (approvalTarget) refuses the rest.
|
||||||
|
func TestTheLaneDoesNotApproveForAPairingThisMachineDoesNotServe(t *testing.T) {
|
||||||
|
askFlowWorld(t)
|
||||||
|
laneOwner(t, laneTestUID)
|
||||||
|
const host, id = "box-two.example", "c0ffee00c0ffee00c0ffee00c0ffee00"
|
||||||
|
waiting := func(state string) string {
|
||||||
|
dcn := givenPairing(t, host, state)
|
||||||
|
enrolFactorAt(t, dcn, hostTestSecret)
|
||||||
|
if err := requestsSave(dcn, map[string]stepupRequest{id: {Purpose: "test|host", State: "pending",
|
||||||
|
At: time.Now().UTC().Format(time.RFC3339)}}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
return dcn
|
||||||
|
}
|
||||||
|
dcn := waiting(pairingPending)
|
||||||
|
// MUTATION: drop the approvalTarget check. RESULT: red, approved.
|
||||||
|
rep := serveAct(laneTestUID, "sam", agentAskRequest{Act: "approve", Host: host, ID: id[:8], Code: codeFor(t, hostTestSecret)})
|
||||||
|
if rep.OK || !strings.Contains(rep.Why, "does not serve") {
|
||||||
|
t.Errorf("approve for a pairing the anchor has not approved: %+v", rep)
|
||||||
|
}
|
||||||
|
if got := requestsLoad(dcn)[id].State; got != "pending" {
|
||||||
|
t.Errorf("the request of a pairing this machine does not serve is %q", got)
|
||||||
|
}
|
||||||
|
// The same act for an active pairing is answered: the refusal above is
|
||||||
|
// the pairing's state, not the test's setup.
|
||||||
|
dcn = waiting(pairingActive)
|
||||||
|
if rep := serveAct(laneTestUID, "sam", agentAskRequest{Act: "approve", Host: host, ID: id[:8],
|
||||||
|
Code: codeFor(t, hostTestSecret)}); !rep.OK {
|
||||||
|
t.Errorf("approve for an active pairing: %+v", rep)
|
||||||
|
}
|
||||||
|
if got := requestsLoad(dcn)[id].State; got != "approved" {
|
||||||
|
t.Errorf("the active pairing's request is %q", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The act's audit line lands in the machine's log, and says what was acted
|
||||||
|
// on as the bastion resolved it. With no owner's code set up (a switch off
|
||||||
|
// needs none) it was written to audit.jsonl in the daemon's working
|
||||||
|
// directory; and a request reached with no --machine, the machine's because
|
||||||
|
// no Host is paired, was logged as a Host's.
|
||||||
|
func TestAnOwnerActIsAuditedInTheMachinesLogAsResolved(t *testing.T) {
|
||||||
|
uiTestConfigDir(t)
|
||||||
|
const host = "box-one.example"
|
||||||
|
givenPairing(t, host, pairingActive)
|
||||||
|
laneOwner(t, laneTestUID)
|
||||||
|
cwd := t.TempDir()
|
||||||
|
t.Chdir(cwd)
|
||||||
|
if rep := serveAct(laneTestUID, "sam", agentAskRequest{Act: "switch", Host: host, Family: "ops", Off: true}); !rep.OK {
|
||||||
|
t.Fatalf("switch off: %+v", rep)
|
||||||
|
}
|
||||||
|
// MUTATION: audit to existingMachineFactorDir(). RESULT: red, the line is
|
||||||
|
// in the working directory.
|
||||||
|
if _, err := os.Stat(filepath.Join(cwd, "audit.jsonl")); err == nil {
|
||||||
|
t.Error("the act's audit line was written into the daemon's working directory")
|
||||||
|
}
|
||||||
|
dir, err := machineFactorDir()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
raw, _ := os.ReadFile(filepath.Join(dir, "audit.jsonl"))
|
||||||
|
if !strings.Contains(string(raw), `"op":"owner_lane_act"`) || !strings.Contains(string(raw), "switch "+host+" ops off") {
|
||||||
|
t.Errorf("the switch is not in the machine's audit log:\n%s", raw)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestAnOwnerActOnTheMachinesRequestIsAuditedAsTheMachines(t *testing.T) {
|
||||||
|
d := askFlowWorld(t)
|
||||||
|
r := fileAsk(agentAskRequest{Op: "stop", PID: 101}, "u", 311)
|
||||||
|
laneOwner(t, laneTestUID)
|
||||||
|
// No --machine, and no Host paired: the machine's request.
|
||||||
|
if rep := serveAct(laneTestUID, "sam", agentAskRequest{Act: "deny", ID: r.Request}); !rep.OK {
|
||||||
|
t.Fatalf("deny: %+v", rep)
|
||||||
|
}
|
||||||
|
raw, _ := os.ReadFile(filepath.Join(d, "audit.jsonl"))
|
||||||
|
// MUTATION: name the target from req.Machine. RESULT: red, "a Host's ()".
|
||||||
|
if want := "deny the machine's request " + fullRequestID(t, d, r.Request); !strings.Contains(string(raw), want) {
|
||||||
|
t.Errorf("the audit line does not say %q:\n%s", want, raw)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Deny for a Host's request is refused, as the console refuses it, for a
|
||||||
|
// pairing this machine does not serve.
|
||||||
|
func TestTheLaneDoesNotDenyForAPairingThisMachineDoesNotServe(t *testing.T) {
|
||||||
|
askFlowWorld(t)
|
||||||
|
const host = "box-pending.example"
|
||||||
|
givenPairing(t, host, pairingPending)
|
||||||
|
laneOwner(t, laneTestUID)
|
||||||
|
rep := serveAct(laneTestUID, "sam", agentAskRequest{Act: "deny", Host: host, ID: "abcd1234"})
|
||||||
|
if rep.OK || !strings.Contains(rep.Why, "does not serve") {
|
||||||
|
t.Errorf("deny for a pending pairing: %+v", rep)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// An act that panics inside the daemon leaves the request lock free: the
|
||||||
|
// next approval does not hang.
|
||||||
|
func TestAPanickingActLeavesTheRequestLockFree(t *testing.T) {
|
||||||
|
askFlowWorld(t)
|
||||||
|
laneOwner(t, laneTestUID)
|
||||||
|
prev := requestsLoadHook
|
||||||
|
t.Cleanup(func() { requestsLoadHook = prev })
|
||||||
|
requestsLoadHook = func() { panic("boom") }
|
||||||
|
if rep := serveAct(laneTestUID, "sam", agentAskRequest{Act: "deny", Machine: true, ID: "abcd1234"}); rep.OK || !rep.Failed {
|
||||||
|
t.Fatalf("a panicking act: %+v", rep)
|
||||||
|
}
|
||||||
|
requestsLoadHook = func() {}
|
||||||
|
done := make(chan struct{})
|
||||||
|
go func() { lockedRequests(existingMachineFactorDir()); close(done) }()
|
||||||
|
select {
|
||||||
|
case <-done:
|
||||||
|
case <-time.After(2 * time.Second):
|
||||||
|
t.Fatal("the request lock was left held by the panicking act")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The narrowing acts go through the lane from the owner's account with no
|
||||||
|
// code: an unused approval is dropped, a device ask denied, a store grant
|
||||||
|
// dropped, every op grant dropped.
|
||||||
|
func TestTheOwnerTakesReachBackThroughTheLane(t *testing.T) {
|
||||||
|
d := askFlowWorld(t)
|
||||||
|
const host = "box-one.example"
|
||||||
|
dcn := givenPairing(t, host, pairingActive)
|
||||||
|
givenStoreGrants(t, dcn, map[string]map[string]any{"7": givenMachineStore("/srv/data", nil, nil, "")})
|
||||||
|
approval, err := stepupIssueApproval(d, codeFor(t, machineTestSecret), "local_stop|101|aider")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if _, err := deviceInit(); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
ask, err := deviceNewRequest(map[string]any{"kind": "mgmt_op", "op": "ctx_del", "server": "box-7", "args": []any{}})
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
laneOwner(t, laneTestUID)
|
||||||
|
laneSock(t)
|
||||||
|
out := captureStdout(t)
|
||||||
|
asked := stubCode(t, "")
|
||||||
|
|
||||||
|
if err := cmdStepupDrop("", true, approval[:8]); err != nil {
|
||||||
|
t.Fatalf("approvals drop: %v", err)
|
||||||
|
}
|
||||||
|
if !approvalsLoad(d)[approval].Used {
|
||||||
|
t.Error("the machine's approval is still usable after the owner dropped it")
|
||||||
|
}
|
||||||
|
if err := cmdDeviceDeny(ask[:8]); err != nil {
|
||||||
|
t.Fatalf("device-deny: %v", err)
|
||||||
|
}
|
||||||
|
deviceMu.Lock()
|
||||||
|
state := deviceRequestsLoad()[ask].State
|
||||||
|
deviceMu.Unlock()
|
||||||
|
if state != "denied" {
|
||||||
|
t.Errorf("the device ask is %q after the owner denied it", state)
|
||||||
|
}
|
||||||
|
if err := cmdGrantsDrop(host, "7"); err != nil {
|
||||||
|
t.Fatalf("grants drop: %v", err)
|
||||||
|
}
|
||||||
|
if err := cmdOpsDrop(host, "--all"); err != nil {
|
||||||
|
t.Fatalf("ops drop --all: %v", err)
|
||||||
|
}
|
||||||
|
got := printedSince(out, 0, "op grant(s) dropped")
|
||||||
|
for _, want := range []string{"dropped approval " + approval[:8], "denied " + ask, "store 7 dropped for " + host,
|
||||||
|
"0 op grant(s) dropped"} {
|
||||||
|
if !strings.Contains(got, want) {
|
||||||
|
t.Errorf("printed no %q:\n%s", want, got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if *asked != 0 {
|
||||||
|
t.Errorf("a narrowing act asked for a code %d times", *asked)
|
||||||
|
}
|
||||||
|
// MUTATION: route grants-drop to the account's own state. RESULT: red,
|
||||||
|
// a second drop through the lane still finds the store.
|
||||||
|
if err := cmdGrantsDrop(host, "7"); err != nil || !strings.Contains(printedSince(out, len(got), "not held"), "was not held here") {
|
||||||
|
t.Errorf("a second drop of the same store: %v", err)
|
||||||
|
}
|
||||||
|
raw, _ := os.ReadFile(filepath.Join(d, "audit.jsonl"))
|
||||||
|
for _, act := range []string{"approvals-drop", "device-deny", "grants-drop 7 for " + host, "ops-drop --all for " + host} {
|
||||||
|
if !strings.Contains(string(raw), act) {
|
||||||
|
t.Errorf("no audit row for %s", act)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Any other account is refused the narrowing acts too, with the
|
||||||
|
// administrator's command.
|
||||||
|
func TestAnotherAccountIsRefusedTheNarrowingActs(t *testing.T) {
|
||||||
|
askFlowWorld(t)
|
||||||
|
givenPairing(t, "box-one.example", pairingActive)
|
||||||
|
laneOwner(t, laneTestUID+1)
|
||||||
|
laneSock(t)
|
||||||
|
captureStdout(t)
|
||||||
|
for name, run := range map[string]func() error{
|
||||||
|
"approvals drop": func() error { return cmdStepupDrop("", true, "abcd1234") },
|
||||||
|
"device-deny": func() error { return cmdDeviceDeny("abcd1234") },
|
||||||
|
"grants drop": func() error { return cmdGrantsDrop("box-one.example", "7") },
|
||||||
|
"ops drop": func() error { return cmdOpsDrop("box-one.example", "--all") },
|
||||||
|
} {
|
||||||
|
err := run()
|
||||||
|
if err == nil || !strings.Contains(err.Error(), "acts only for its owner's account") ||
|
||||||
|
!strings.Contains(err.Error(), "sudo -H privatae-bastion ") {
|
||||||
|
t.Errorf("%s from another account: %v", name, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// `ops drop ""` (an unset variable in a script, say) names no grant: it is
|
||||||
|
// refused, as an empty id is for approvals drop and device-deny, and the one
|
||||||
|
// grant held is kept. It used to match every nonce, so with one grant held
|
||||||
|
// it dropped that one.
|
||||||
|
//
|
||||||
|
// MUTATION: take the empty-id refusal out of opsDropText. RESULT: red, the
|
||||||
|
// held grant is dropped.
|
||||||
|
func TestAnEmptyOpGrantIDDropsNothing(t *testing.T) {
|
||||||
|
askFlowWorld(t)
|
||||||
|
const host = "box-one.example"
|
||||||
|
dcn := givenPairing(t, host, pairingActive)
|
||||||
|
const nonce = "0123456789abcdef0123"
|
||||||
|
f := opsLoad(dcn)
|
||||||
|
f.Grants[nonce] = opGrantRec{UsesLeft: 1}
|
||||||
|
if err := opsSave(dcn, f); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
laneOwner(t, laneTestUID)
|
||||||
|
laneSock(t)
|
||||||
|
captureStdout(t)
|
||||||
|
for _, id := range []string{"", " "} {
|
||||||
|
err := cmdOpsDrop(host, id)
|
||||||
|
if err == nil || !strings.Contains(err.Error(), "which op grant") {
|
||||||
|
t.Errorf("ops drop %q: %v", id, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if rec := opsLoad(dcn).Grants[nonce]; rec.Dropped != "" || rec.UsesLeft != 1 {
|
||||||
|
t.Errorf("an empty id dropped the one grant held: %+v", rec)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Store ids are each Host's own: two Hosts' store 7 are two stores, with two
|
||||||
|
// agents. Kept by store id alone, a machine paired with both ran one agent,
|
||||||
|
// so a search from one Host for its store 7 was answered by the agent over the
|
||||||
|
// other Host's folder, and dropping one Host's store stopped the other's.
|
||||||
|
func TestTwoHostsWithTheSameStoreIDGetTheirOwnAgents(t *testing.T) {
|
||||||
|
uiTestConfigDir(t)
|
||||||
|
dcnA := givenPairing(t, "box-a.example", pairingActive)
|
||||||
|
dcnB := givenPairing(t, "box-b.example", pairingActive)
|
||||||
|
givenStoreGrants(t, dcnB, map[string]map[string]any{"7": givenMachineStore("/srv/b", nil, nil, "")})
|
||||||
|
dirA, dirB := t.TempDir(), t.TempDir()
|
||||||
|
for _, d := range []string{dirA, dirB} {
|
||||||
|
if err := os.WriteFile(filepath.Join(d, "port"), []byte(map[string]string{dirA: "41001", dirB: "41002"}[d]), 0o600); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
stopped := map[string]int{}
|
||||||
|
faMgr.Lock()
|
||||||
|
faMgr.inst[faKey{dcnA, 7}] = &faInstance{StoreID: 7, Dir: dirA, Cert: "a", Key: "a", cancel: func() { stopped["a"]++ }}
|
||||||
|
faMgr.inst[faKey{dcnB, 7}] = &faInstance{StoreID: 7, Dir: dirB, Cert: "b", Key: "b", cancel: func() { stopped["b"]++ }}
|
||||||
|
faMgr.inst[faKey{dcnB, 9}] = &faInstance{StoreID: 9, Dir: dirB, State: "running"}
|
||||||
|
faMgr.Unlock()
|
||||||
|
t.Cleanup(func() {
|
||||||
|
faMgr.Lock()
|
||||||
|
delete(faMgr.inst, faKey{dcnA, 7})
|
||||||
|
delete(faMgr.inst, faKey{dcnB, 7})
|
||||||
|
delete(faMgr.inst, faKey{dcnB, 9})
|
||||||
|
faMgr.Unlock()
|
||||||
|
})
|
||||||
|
// A search on each pairing's lane goes to that pairing's own agent.
|
||||||
|
if c, ok := faConfigFor(dcnA, 7); !ok || c.Addr != "127.0.0.1:41001" {
|
||||||
|
t.Errorf("Host A's store 7 resolves to %+v", c)
|
||||||
|
}
|
||||||
|
if c, ok := faConfigFor(dcnB, 7); !ok || c.Addr != "127.0.0.1:41002" {
|
||||||
|
t.Errorf("Host B's store 7 resolves to %+v", c)
|
||||||
|
}
|
||||||
|
// Each beat reports its own pairing's stores only: B's store 9 is not
|
||||||
|
// A's to hear about.
|
||||||
|
// MUTATION: drop the k.Dir filter in faManagedStatus. RESULT: red.
|
||||||
|
if st := faManagedStatus(dcnA); len(st) != 1 || st["9"] != nil {
|
||||||
|
t.Errorf("Host A's beat reports %v", st)
|
||||||
|
}
|
||||||
|
if st := faManagedStatus(dcnB); len(st) != 2 {
|
||||||
|
t.Errorf("Host B's beat reports %v", st)
|
||||||
|
}
|
||||||
|
if st := faManagedStatus(""); len(st) != 0 {
|
||||||
|
t.Errorf("a beat with no DCN state reports %d stores", len(st))
|
||||||
|
}
|
||||||
|
// A's drop of a store it does not hold stops A's own orphan, never B's.
|
||||||
|
if present, err := dcnDropStore(dcnA, 7, "test"); err != nil || present || stopped["a"] != 1 || stopped["b"] != 0 {
|
||||||
|
t.Fatalf("A's drop: present %v err %v, stopped %v", present, err, stopped)
|
||||||
|
}
|
||||||
|
if present, err := dcnDropStore(dcnB, 7, "test"); err != nil || !present || stopped["b"] != 1 {
|
||||||
|
t.Fatalf("B's drop of its own store: present %v err %v, stopped %v", present, err, stopped)
|
||||||
|
}
|
||||||
|
}
|
||||||
+101
-52
@@ -195,16 +195,18 @@ func pairPrecheck(cfgs []*Config, handle string, replace, forceActive bool) (exi
|
|||||||
if boxMode() == modeLocal && len(cfgs) > 0 {
|
if boxMode() == modeLocal && len(cfgs) > 0 {
|
||||||
return nil, "", &localSecondHostError{serving: cfgs[0].HostName}
|
return nil, "", &localSecondHostError{serving: cfgs[0].HostName}
|
||||||
}
|
}
|
||||||
return pairPrecheckState(forceActive)
|
return pairPrecheckState(forceActive, handle)
|
||||||
}
|
}
|
||||||
|
|
||||||
// pairPrecheckState is the state a new pairing gets once pairPrecheck's walls
|
// pairPrecheckState is the state a new pairing gets once pairPrecheck's walls
|
||||||
// are passed: active for claim-anchor, pending behind an anchor, else "".
|
// are passed: active for claim-anchor, pending behind an anchor (or, on a
|
||||||
func pairPrecheckState(forceActive bool) (*Config, string, error) {
|
// machine an organisation's policy governs and no Host holds yet, behind the
|
||||||
|
// Host the policy names: anchor_local.go), else "".
|
||||||
|
func pairPrecheckState(forceActive bool, handle string) (*Config, string, error) {
|
||||||
if forceActive {
|
if forceActive {
|
||||||
return nil, pairingActive, nil
|
return nil, pairingActive, nil
|
||||||
}
|
}
|
||||||
if currentAnchor() != nil {
|
if currentAnchor() != nil || pendingUnderPolicy(handle) {
|
||||||
return nil, pairingPending, nil
|
return nil, pairingPending, nil
|
||||||
}
|
}
|
||||||
return nil, "", nil
|
return nil, "", nil
|
||||||
@@ -280,29 +282,29 @@ func cmdPair(token, redeemURL, hostCAFile string, replace bool) error {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
// A networked machine is a server. Left unanchored it refuses every op to
|
// A networked machine is a server, with one Host in charge of it: the
|
||||||
// every host (capsAllowIn: unanchoredNetworkedRefusal) until someone runs
|
// anchor (anchor.go). Left unanchored it refuses every op to every host
|
||||||
// claim-anchor, a step people missed. So the first pairing on a networked
|
// (capsAllowIn: unanchoredNetworkedRefusal) until someone runs
|
||||||
// box with no anchor anchors it, as `claim-anchor` with no token would, and
|
// claim-anchor, a step people missed. So with machine authority, which
|
||||||
// from then on every terminal and write waits for the person's approval and
|
// claim-anchor needs anyway, `pair` puts the right Host in charge by
|
||||||
// every later pairing for this host's. Only with machine authority, which
|
// itself (anchor_local.go anchorAfterPair): the Host an organisation's
|
||||||
// claim-anchor needs anyway.
|
// policy names, else a Host on this machine, else the first Host paired.
|
||||||
// The pairing itself succeeded, so a failed anchor is reported, not
|
// The pairing itself succeeded, so a failed anchor is reported, not
|
||||||
// returned: `pair` failing here would read as "could not pair" to a caller
|
// returned: `pair` failing here would read as "could not pair" to a caller
|
||||||
// (npx cseries exits on it) when the pairing exists. claim-anchor, which
|
// (npx cseries exits on it) when the pairing exists. claim-anchor, which
|
||||||
// such a caller runs next, reports the anchor's own failure.
|
// such a caller runs next, reports the anchor's own failure.
|
||||||
anchored, err := anchorFirstNetworkedPairing(cfg, all)
|
took, err := anchorAfterPair(cfg, all)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
fmt.Fprintf(os.Stderr, "warning: %v\n", err)
|
fmt.Fprintf(os.Stderr, "warning: %v\n", err)
|
||||||
}
|
}
|
||||||
if anchored {
|
if took.Taken {
|
||||||
if fresh, lerr := loadPairings(); lerr == nil {
|
if fresh, lerr := loadPairings(); lerr == nil {
|
||||||
if c := pairingFor(fresh, cfg.HostName); c != nil {
|
if c := pairingFor(fresh, cfg.HostName); c != nil {
|
||||||
cfg, all = c, fresh
|
cfg, all = c, fresh
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
pairReport(os.Stdout, cfg, all, anchored)
|
pairReport(os.Stdout, cfg, all, took)
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -327,45 +329,77 @@ func pairOptsFor(token, redeemURL, hostCAFile string, replace bool) (string, pai
|
|||||||
}
|
}
|
||||||
|
|
||||||
// pairReport is what `pair` prints once the pairing stands. Whatever the form
|
// pairReport is what `pair` prints once the pairing stands. Whatever the form
|
||||||
// (anchored just now, over TCP, over a unix socket, pending, or over the
|
// (put in charge just now, over TCP, over a unix socket, waiting to be
|
||||||
// tunnel), it ends by saying to enrol a second factor when this pairing has
|
// admitted, or over the tunnel), it ends by saying to enrol a second factor
|
||||||
// none and no approval device is pinned: without one, a local machine installs
|
// when this pairing has none and no approval device is pinned: without one, a
|
||||||
// a folder grant on the host's signed grant alone, and an anchored one has no
|
// local machine installs a folder grant on the host's signed grant alone, and
|
||||||
// way to approve anything the host asks for.
|
// an anchored one has no way to approve anything the host asks for.
|
||||||
func pairReport(w io.Writer, cfg *Config, all []*Config, anchored bool) {
|
//
|
||||||
|
// It never tells the person to start a bastion that is already running: a
|
||||||
|
// running bastion serves a new pairing by itself within supervisePeriod
|
||||||
|
// (run.go superviseLoop), and on a machine whose bastion is a system service
|
||||||
|
// the command that starts it is the service manager's (pairServeNote).
|
||||||
|
func pairReport(w io.Writer, cfg *Config, all []*Config, took anchorTake) {
|
||||||
enrol := ""
|
enrol := ""
|
||||||
if !secondFactorAvailable(cfg.dcnDir()) {
|
if !secondFactorAvailable(cfg.dcnDir()) {
|
||||||
enrol = stepupEnrollHint(cfg.HostName, len(all))
|
enrol = stepupEnrollHint(cfg.HostName, len(all))
|
||||||
}
|
}
|
||||||
defer func() { pairEnrolNote(w, cfg.HostName, enrol) }()
|
defer func() { pairEnrolNote(w, cfg.HostName, enrol) }()
|
||||||
if anchored {
|
if took.Taken {
|
||||||
fmt.Fprintf(w, "\nThis machine is networked and anchored to %s: every terminal and every write\n", cfg.HostName)
|
fmt.Fprintf(w, "\n%s is now the Host in charge of this machine: %s.\n", cfg.HostName, took.Why)
|
||||||
fmt.Fprintln(w, "waits for your approval, and any later host waits for this one to approve it.")
|
if took.Replaced != "" {
|
||||||
|
fmt.Fprintf(w, "%s was in charge before. It is told so, and waits for %s to admit it, as any other Host does.\n",
|
||||||
|
took.Replaced, cfg.HostName)
|
||||||
|
}
|
||||||
|
if others := without(took.Waiting, took.Replaced); len(others) > 0 {
|
||||||
|
fmt.Fprintf(w, "Waiting for %s to admit them: %s.\n", cfg.HostName, strings.Join(others, ", "))
|
||||||
|
}
|
||||||
|
fmt.Fprintln(w, "Every terminal and every write waits for your approval, and any other Host waits")
|
||||||
|
fmt.Fprintf(w, "until %s admits it: %s asks you to approve it.\n", cfg.HostName, cfg.HostName)
|
||||||
if enrol != "" {
|
if enrol != "" {
|
||||||
fmt.Fprintf(w, "Enrol your second factor now, so you can approve here:\n %s\n\n", enrol)
|
fmt.Fprintf(w, "Enrol your second factor now, so you can approve here:\n %s\n\n", enrol)
|
||||||
enrol = ""
|
enrol = ""
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
if cfg.tcpTransport() && cfg.active() {
|
if !cfg.active() {
|
||||||
|
who := admitter()
|
||||||
|
if who == "" {
|
||||||
|
fmt.Fprintf(w, "Paired with %s — PENDING. Nothing runs for it until it is admitted.\n", cfg.HostName)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
why := "the Host in charge of this computer"
|
||||||
|
if p := currentAnchorPolicy(); p != nil && boxMode() == modeNetworked && policyNames(p, who) {
|
||||||
|
why += ", named by an organisation's policy (" + p.Source + ")"
|
||||||
|
}
|
||||||
|
fmt.Fprintf(w, "Paired with %s — WAITING for %s to admit it.\n\n", cfg.HostName, who)
|
||||||
|
fmt.Fprintf(w, "The code was used: %s now lists this computer, but nothing runs for it yet (no lanes).\n", cfg.HostName)
|
||||||
|
fmt.Fprintf(w, "%s is %s, and it admits every other Host:\n", who, why)
|
||||||
|
fmt.Fprintf(w, "%s asks you to approve %s. Once you do, %s is served at once, with no restart.\n", who, cfg.HostName, cfg.HostName)
|
||||||
|
fmt.Fprintf(w, "Until then `privatae-bastion status` shows it as waiting for %s.\n", who)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if cfg.hostDials() {
|
||||||
|
fmt.Fprintf(w, "Paired with %s. Your Host connects to this server; this server never connects to it.\n\n", cfg.HostName)
|
||||||
|
fmt.Fprintf(w, " lanes: over the connections your Host opens to port %s (mutual TLS, the Host's CA pinned, name %s)\n coder runs: none over TCP\n",
|
||||||
|
doorPort(cfg.doorAddr()), tcpServerName)
|
||||||
|
fmt.Fprintf(w, " firewall: this server needs TCP port %s reachable inbound; the bastion keeps its own rule for it in a firewall it manages "+
|
||||||
|
"here (status shows it), and nothing on your Host's network needs opening\n", doorPort(cfg.doorAddr()))
|
||||||
|
fmt.Fprintf(w, " local: http://%s\n\n%s\n", cfg.ListenAddr, pairServeNote())
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if cfg.tcpTransport() {
|
||||||
fmt.Fprintf(w, "Paired with %s over TCP.\n\n", cfg.HostName)
|
fmt.Fprintf(w, "Paired with %s over TCP.\n\n", cfg.HostName)
|
||||||
fmt.Fprintf(w, " lanes: %s (mutual TLS, the Host's CA pinned, name %s)\n coder runs: none over TCP\n", cfg.LaneAddr, tcpServerName)
|
fmt.Fprintf(w, " lanes: %s (mutual TLS, the Host's CA pinned, name %s)\n coder runs: none over TCP\n", cfg.LaneAddr, tcpServerName)
|
||||||
fmt.Fprintf(w, " local: http://%s\n\nStart (or restart) the bastion:\n privatae-bastion run\n", cfg.ListenAddr)
|
fmt.Fprintf(w, " local: http://%s\n\n%s\n", cfg.ListenAddr, pairServeNote())
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
if cfg.unixTransport() && cfg.active() {
|
if cfg.unixTransport() {
|
||||||
fmt.Fprintf(w, "Paired with %s, a Host on this machine.\n\n", cfg.HostName)
|
fmt.Fprintf(w, "Paired with %s, a Host on this machine.\n\n", cfg.HostName)
|
||||||
fmt.Fprintf(w, " lanes: %s (mutual TLS, the Host's CA pinned)\n coder runs: a socket per run in %s\n", cfg.LaneSocket, cfg.RunsDir)
|
fmt.Fprintf(w, " lanes: %s (mutual TLS, the Host's CA pinned)\n coder runs: a socket per run in %s\n", cfg.LaneSocket, cfg.RunsDir)
|
||||||
fmt.Fprintf(w, " local: http://%s\n\nStart (or restart) the bastion:\n privatae-bastion run\n", cfg.ListenAddr)
|
fmt.Fprintf(w, " local: http://%s\n\n%s\n", cfg.ListenAddr, pairServeNote())
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
if !cfg.active() {
|
fmt.Fprintf(w, "Paired with %s.\n\nOne bastion serves every pairing:\n", cfg.HostName)
|
||||||
fmt.Fprintf(w, "Paired with %s — PENDING.\n\n", cfg.HostName)
|
|
||||||
fmt.Fprintln(w, "This machine is anchored, so a new host waits until the anchor host approves it.")
|
|
||||||
fmt.Fprintln(w, "Nothing is started for it yet: no tunnel, no lanes. It shows on the anchor host's")
|
|
||||||
fmt.Fprintln(w, "Network app as a pending pairing; once approved the daemon opens its lanes by itself.")
|
|
||||||
return
|
|
||||||
}
|
|
||||||
fmt.Fprintf(w, "Paired with %s.\n\nOne `privatae-bastion run` serves every pairing:\n", cfg.HostName)
|
|
||||||
for _, c := range all {
|
for _, c := range all {
|
||||||
// The listen address is the CLI's loopback control port for that host
|
// The listen address is the CLI's loopback control port for that host
|
||||||
// (add-folder, git-credential). The local secret that guards it is read
|
// (add-folder, git-credential). The local secret that guards it is read
|
||||||
@@ -373,10 +407,37 @@ func pairReport(w io.Writer, cfg *Config, all []*Config, anchored bool) {
|
|||||||
// operator client to hand it to since the MCP relay was removed.
|
// operator client to hand it to since the MCP relay was removed.
|
||||||
fmt.Fprintf(w, "\n %s\n local: http://%s\n", c.HostName, c.ListenAddr)
|
fmt.Fprintf(w, "\n %s\n local: http://%s\n", c.HostName, c.ListenAddr)
|
||||||
}
|
}
|
||||||
fmt.Fprintf(w, "\nStart (or restart) the tunnels:\n privatae-bastion run\n")
|
fmt.Fprintf(w, "\n%s\n", pairServeNote())
|
||||||
fmt.Fprintf(w, "\ngit to your forge goes through this bastion — one-time setup:\n privatae-bastion git-setup\n")
|
fmt.Fprintf(w, "\ngit to your forge goes through this bastion — one-time setup:\n privatae-bastion git-setup\n")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// pairDaemonRunning: a bastion is serving on this machine (its console
|
||||||
|
// answers, or the system service runs, waiting for its first pairing). A seam
|
||||||
|
// for the suite.
|
||||||
|
var pairDaemonRunning = func() bool { return uiDaemonListening() || systemServiceRunning() }
|
||||||
|
|
||||||
|
// pairServeNote is `pair`'s last line about serving the new pairing: a running
|
||||||
|
// bastion picks it up by itself; otherwise the command that starts this
|
||||||
|
// machine's bastion (the service manager's on a service machine).
|
||||||
|
func pairServeNote() string {
|
||||||
|
if pairDaemonRunning() {
|
||||||
|
return fmt.Sprintf("The bastion running on this machine serves it within %d seconds; nothing needs restarting.",
|
||||||
|
int(supervisePeriod.Seconds()))
|
||||||
|
}
|
||||||
|
return "Start the bastion so it serves it:\n " + runCommandHint()
|
||||||
|
}
|
||||||
|
|
||||||
|
// without is list less drop.
|
||||||
|
func without(list []string, drop string) []string {
|
||||||
|
var out []string
|
||||||
|
for _, s := range list {
|
||||||
|
if s != drop {
|
||||||
|
out = append(out, s)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return out
|
||||||
|
}
|
||||||
|
|
||||||
// pairEnrolNote says what a pairing with no second factor means on this kind
|
// pairEnrolNote says what a pairing with no second factor means on this kind
|
||||||
// of machine, and how to enrol one. hint "" says nothing.
|
// of machine, and how to enrol one. hint "" says nothing.
|
||||||
func pairEnrolNote(w io.Writer, host, hint string) {
|
func pairEnrolNote(w io.Writer, host, hint string) {
|
||||||
@@ -393,19 +454,6 @@ func pairEnrolNote(w io.Writer, host, hint string) {
|
|||||||
"sessions are refused. Enrol it now, so each needs a code from this machine:\n %s\n", host, hint)
|
"sessions are refused. Enrol it now, so each needs a code from this machine:\n %s\n", host, hint)
|
||||||
}
|
}
|
||||||
|
|
||||||
// anchorFirstNetworkedPairing anchors a networked machine that has no anchor
|
|
||||||
// to the pairing just made, when it is the machine's only one and the caller
|
|
||||||
// holds machine authority (see cmdPair). Reports whether it anchored.
|
|
||||||
func anchorFirstNetworkedPairing(cfg *Config, all []*Config) (bool, error) {
|
|
||||||
if boxMode() != modeNetworked || currentAnchor() != nil || len(all) != 1 || !machineAuthorityHeld() {
|
|
||||||
return false, nil
|
|
||||||
}
|
|
||||||
if err := cmdClaimAnchor("", false, "", cfg.HostName); err != nil {
|
|
||||||
return false, fmt.Errorf("paired with %s, but anchoring this networked machine to it failed: %w\n anchor it with: %s", cfg.HostName, err, anchorCommandHint())
|
|
||||||
}
|
|
||||||
return true, nil
|
|
||||||
}
|
|
||||||
|
|
||||||
// redeemURLBase is the platform's enrollment ingress. A variable so a test can
|
// redeemURLBase is the platform's enrollment ingress. A variable so a test can
|
||||||
// serve a redeem response on loopback; nothing outside tests assigns it.
|
// serve a redeem response on loopback; nothing outside tests assigns it.
|
||||||
var redeemURLBase = "https://api.privatae.ai"
|
var redeemURLBase = "https://api.privatae.ai"
|
||||||
@@ -509,7 +557,7 @@ func pairWith(token string, opts pairOpts) (*Config, []*Config, error) {
|
|||||||
if !yes {
|
if !yes {
|
||||||
return nil, nil, fmt.Errorf("nothing was paired: %s stays the only Host this computer serves", second.serving)
|
return nil, nil, fmt.Errorf("nothing was paired: %s stays the only Host this computer serves", second.serving)
|
||||||
}
|
}
|
||||||
existing, state, err = pairPrecheckState(forceActive)
|
existing, state, err = pairPrecheckState(forceActive, handle)
|
||||||
}
|
}
|
||||||
// The CA this pair trusts, as a fingerprint: the pairing code's, or that
|
// The CA this pair trusts, as a fingerprint: the pairing code's, or that
|
||||||
// of the --host-ca file. "" for a platform or unix-socket pairing, whose
|
// of the --host-ca file. "" for a platform or unix-socket pairing, whose
|
||||||
@@ -738,8 +786,9 @@ func commitPairing(cfg, existing *Config, replace bool, state string) (*Config,
|
|||||||
// host renamed when its address moved). unpair() is deliberately not
|
// host renamed when its address moved). unpair() is deliberately not
|
||||||
// reused: it refuses to remove the anchor's own pairing, which is exactly
|
// reused: it refuses to remove the anchor's own pairing, which is exactly
|
||||||
// the case here — the anchor is re-paired like every other host. The anchor
|
// the case here — the anchor is re-paired like every other host. The anchor
|
||||||
// RECORD is untouched by design; anchor.json still names the old host and
|
// RECORD is untouched here; anchor.json still names the old host until
|
||||||
// only `claim-anchor --rotate` may re-sign it.
|
// `claim-anchor --repin` re-signs it, or, for a Host paired again through a
|
||||||
|
// window under its pinned CA, carryAnchorToNewName (pair_window.go) does.
|
||||||
if replace && existing != nil && existing.HostName != cfg.HostName {
|
if replace && existing != nil && existing.HostName != cfg.HostName {
|
||||||
if err := removeStalePairingFile(existing.HostName); err != nil {
|
if err := removeStalePairingFile(existing.HostName); err != nil {
|
||||||
return nil, nil, fmt.Errorf("paired as %s, but the superseded pairing file for %s "+
|
return nil, nil, fmt.Errorf("paired as %s, but the superseded pairing file for %s "+
|
||||||
|
|||||||
@@ -43,7 +43,7 @@ func TestPairAnchorsANetworkedMachineToItsFirstHost(t *testing.T) {
|
|||||||
box(t, true)
|
box(t, true)
|
||||||
writePairingState(t, tMember, pairingPending)
|
writePairingState(t, tMember, pairingPending)
|
||||||
cfg, all := only(t, tMember)
|
cfg, all := only(t, tMember)
|
||||||
anchored, err := anchorFirstNetworkedPairing(cfg, all)
|
anchored, err := anchoredAfterPair(cfg, all)
|
||||||
if err != nil || !anchored {
|
if err != nil || !anchored {
|
||||||
t.Fatalf("the first pairing on a networked box must anchor it: anchored=%v err=%v", anchored, err)
|
t.Fatalf("the first pairing on a networked box must anchor it: anchored=%v err=%v", anchored, err)
|
||||||
}
|
}
|
||||||
@@ -64,7 +64,7 @@ func TestPairAnchorsANetworkedMachineToItsFirstHost(t *testing.T) {
|
|||||||
box(t, false)
|
box(t, false)
|
||||||
writePairing(t, tMember)
|
writePairing(t, tMember)
|
||||||
cfg, all := only(t, tMember)
|
cfg, all := only(t, tMember)
|
||||||
if anchored, err := anchorFirstNetworkedPairing(cfg, all); anchored || err != nil {
|
if anchored, err := anchoredAfterPair(cfg, all); anchored || err != nil {
|
||||||
t.Fatalf("a local machine must not be anchored: %v %v", anchored, err)
|
t.Fatalf("a local machine must not be anchored: %v %v", anchored, err)
|
||||||
}
|
}
|
||||||
if currentAnchor() != nil {
|
if currentAnchor() != nil {
|
||||||
@@ -81,7 +81,7 @@ func TestPairAnchorsANetworkedMachineToItsFirstHost(t *testing.T) {
|
|||||||
}
|
}
|
||||||
writePairingState(t, tMember, pairingPending)
|
writePairingState(t, tMember, pairingPending)
|
||||||
cfg, all := only(t, tMember)
|
cfg, all := only(t, tMember)
|
||||||
if anchored, err := anchorFirstNetworkedPairing(cfg, all); anchored || err != nil {
|
if anchored, err := anchoredAfterPair(cfg, all); anchored || err != nil {
|
||||||
t.Fatalf("an anchored machine must not be re-anchored: %v %v", anchored, err)
|
t.Fatalf("an anchored machine must not be re-anchored: %v %v", anchored, err)
|
||||||
}
|
}
|
||||||
if a := currentAnchor(); a == nil || a.AnchorHost != tAnchor {
|
if a := currentAnchor(); a == nil || a.AnchorHost != tAnchor {
|
||||||
@@ -98,7 +98,7 @@ func TestPairAnchorsANetworkedMachineToItsFirstHost(t *testing.T) {
|
|||||||
writePairing(t, tAnchor)
|
writePairing(t, tAnchor)
|
||||||
writePairingState(t, tMember, pairingPending)
|
writePairingState(t, tMember, pairingPending)
|
||||||
cfg, all := only(t, tMember)
|
cfg, all := only(t, tMember)
|
||||||
if anchored, err := anchorFirstNetworkedPairing(cfg, all); anchored || err != nil {
|
if anchored, err := anchoredAfterPair(cfg, all); anchored || err != nil {
|
||||||
t.Fatalf("with two pairings the person picks the anchor: %v %v", anchored, err)
|
t.Fatalf("with two pairings the person picks the anchor: %v %v", anchored, err)
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
@@ -109,8 +109,14 @@ func TestPairAnchorsANetworkedMachineToItsFirstHost(t *testing.T) {
|
|||||||
writePairingState(t, tMember, pairingPending)
|
writePairingState(t, tMember, pairingPending)
|
||||||
held = false
|
held = false
|
||||||
cfg, all := only(t, tMember)
|
cfg, all := only(t, tMember)
|
||||||
if anchored, err := anchorFirstNetworkedPairing(cfg, all); anchored || err != nil {
|
if anchored, err := anchoredAfterPair(cfg, all); anchored || err != nil {
|
||||||
t.Fatalf("without machine authority nothing is anchored: %v %v", anchored, err)
|
t.Fatalf("without machine authority nothing is anchored: %v %v", anchored, err)
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// anchoredAfterPair is anchorAfterPair's yes or no.
|
||||||
|
func anchoredAfterPair(cfg *Config, all []*Config) (bool, error) {
|
||||||
|
t, err := anchorAfterPair(cfg, all)
|
||||||
|
return t.Taken, err
|
||||||
|
}
|
||||||
|
|||||||
@@ -19,7 +19,7 @@ import (
|
|||||||
|
|
||||||
func pairReportOf(cfg *Config, all []*Config, anchored bool) string {
|
func pairReportOf(cfg *Config, all []*Config, anchored bool) string {
|
||||||
var b strings.Builder
|
var b strings.Builder
|
||||||
pairReport(&b, cfg, all, anchored)
|
pairReport(&b, cfg, all, anchorTake{Taken: anchored, Why: "it is the first Host paired with this networked machine"})
|
||||||
return b.String()
|
return b.String()
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
+29
-14
@@ -219,20 +219,8 @@ func tcpAnswerRefusal(rr tcpRedeemResp, redeem *url.URL, hostCA, opKey string, e
|
|||||||
if !sameCAs(rr.caCert(), hostCA) {
|
if !sameCAs(rr.caCert(), hostCA) {
|
||||||
return errors.New("the Host answered with a CA other than the --host-ca it was paired with — refusing")
|
return errors.New("the Host answered with a CA other than the --host-ca it was paired with — refusing")
|
||||||
}
|
}
|
||||||
pair, err := tls.X509KeyPair([]byte(rr.operatorCert()), []byte(opKey))
|
if err := operatorCertRefusal(rr.operatorCert(), hostCA, opKey); err != nil {
|
||||||
if err != nil {
|
return err
|
||||||
return fmt.Errorf("the Host's operator_cert is not for this bastion's key: %v", err)
|
|
||||||
}
|
|
||||||
leaf, err := x509.ParseCertificate(pair.Certificate[0])
|
|
||||||
if err != nil {
|
|
||||||
return fmt.Errorf("the Host's operator_cert does not parse: %v", err)
|
|
||||||
}
|
|
||||||
pool := x509.NewCertPool()
|
|
||||||
for _, c := range pemCerts(hostCA) {
|
|
||||||
pool.AddCert(c)
|
|
||||||
}
|
|
||||||
if _, err := leaf.Verify(x509.VerifyOptions{Roots: pool, KeyUsages: []x509.ExtKeyUsage{x509.ExtKeyUsageClientAuth}}); err != nil {
|
|
||||||
return fmt.Errorf("the Host's operator_cert is not signed by its CA for client use: %v", err)
|
|
||||||
}
|
}
|
||||||
// Again here: the pairing the answer's name lands on may not be the one
|
// Again here: the pairing the answer's name lands on may not be the one
|
||||||
// the token's handle found before the redeem.
|
// the token's handle found before the redeem.
|
||||||
@@ -250,6 +238,27 @@ func tcpAnswerRefusal(rr tcpRedeemResp, redeem *url.URL, hostCA, opKey string, e
|
|||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// operatorCertRefusal: the operator certificate a Host answered with is for
|
||||||
|
// this bastion's key, and its CA signed it for client use.
|
||||||
|
func operatorCertRefusal(certPEM, hostCA, opKey string) error {
|
||||||
|
pair, err := tls.X509KeyPair([]byte(certPEM), []byte(opKey))
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("the Host's operator_cert is not for this bastion's key: %v", err)
|
||||||
|
}
|
||||||
|
leaf, err := x509.ParseCertificate(pair.Certificate[0])
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("the Host's operator_cert does not parse: %v", err)
|
||||||
|
}
|
||||||
|
pool := x509.NewCertPool()
|
||||||
|
for _, c := range pemCerts(hostCA) {
|
||||||
|
pool.AddCert(c)
|
||||||
|
}
|
||||||
|
if _, err := leaf.Verify(x509.VerifyOptions{Roots: pool, KeyUsages: []x509.ExtKeyUsage{x509.ExtKeyUsageClientAuth}}); err != nil {
|
||||||
|
return fmt.Errorf("the Host's operator_cert is not signed by its CA for client use: %v", err)
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
// tcpPinRefusal is THE PIN, as for a unix pairing: a --replace keeps the CA
|
// tcpPinRefusal is THE PIN, as for a unix pairing: a --replace keeps the CA
|
||||||
// the pairing was made with. pairWithTokenVia asks it before the redeem
|
// the pairing was made with. pairWithTokenVia asks it before the redeem
|
||||||
// dials, because --host-ca is the only root that redeem trusts: under
|
// dials, because --host-ca is the only root that redeem trusts: under
|
||||||
@@ -328,6 +337,9 @@ func tcpLaneDialer(cfg *Config) (func(ctx context.Context) (net.Conn, error), *t
|
|||||||
// localLaneDialer is the lane transport of a pairing with a Host that has no
|
// localLaneDialer is the lane transport of a pairing with a Host that has no
|
||||||
// platform: the lane socket or the lane port.
|
// platform: the lane socket or the lane port.
|
||||||
func localLaneDialer(cfg *Config) (func(ctx context.Context) (net.Conn, error), *tls.Config, error) {
|
func localLaneDialer(cfg *Config) (func(ctx context.Context) (net.Conn, error), *tls.Config, error) {
|
||||||
|
if cfg.hostDials() {
|
||||||
|
return hostDialsLaneDialer(cfg)
|
||||||
|
}
|
||||||
if cfg.tcpTransport() {
|
if cfg.tcpTransport() {
|
||||||
return tcpLaneDialer(cfg)
|
return tcpLaneDialer(cfg)
|
||||||
}
|
}
|
||||||
@@ -336,6 +348,9 @@ func localLaneDialer(cfg *Config) (func(ctx context.Context) (net.Conn, error),
|
|||||||
|
|
||||||
// laneWhere is where a local pairing's lanes go, for the log and status.
|
// laneWhere is where a local pairing's lanes go, for the log and status.
|
||||||
func (c *Config) laneWhere() string {
|
func (c *Config) laneWhere() string {
|
||||||
|
if c.hostDials() {
|
||||||
|
return "connections your Host opens to this server's port " + doorPort(c.doorAddr())
|
||||||
|
}
|
||||||
if c.tcpTransport() {
|
if c.tcpTransport() {
|
||||||
return c.LaneAddr
|
return c.LaneAddr
|
||||||
}
|
}
|
||||||
|
|||||||
File diff suppressed because it is too large
Load Diff
@@ -146,6 +146,9 @@ func handlePairingGrantSync(ws *websocket.Conn, _ string, args []string) {
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
anchorMu.Unlock()
|
anchorMu.Unlock()
|
||||||
|
// A former anchor admitted again has heard it was replaced: its beats
|
||||||
|
// stop saying so (anchor_local.go anchorReplacedNote).
|
||||||
|
clearAnchorReplacedFor(c.HostName)
|
||||||
// Open the lanes now: the user approved on the anchor host and expects the
|
// Open the lanes now: the user approved on the anchor host and expects the
|
||||||
// member host to come up, not to wait for someone to restart the service.
|
// member host to come up, not to wait for someone to restart the service.
|
||||||
started := false
|
started := false
|
||||||
|
|||||||
@@ -0,0 +1,136 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
// pairing_retry.go — each pairing runs on its own.
|
||||||
|
//
|
||||||
|
// Until 0.63.0 one pairing's fatal error (a port it could not bind, a lane
|
||||||
|
// that would not come up, a bad certificate in its file) went to cmdRun and
|
||||||
|
// stopped the whole daemon, so every other Host on the machine went dark with
|
||||||
|
// it, and on Windows the service manager restarted all of them into the same
|
||||||
|
// failure every five seconds. Now that error stops that pairing alone. It is
|
||||||
|
// reported (the log, the machine's events, `status`), and the supervisor
|
||||||
|
// (run.go superviseOnce) starts it again by itself after a pause that doubles
|
||||||
|
// from supervisePeriod up to retryMaxPause, the other pairings serving all
|
||||||
|
// along. A run that stays up for retryResetAfter clears the record.
|
||||||
|
|
||||||
|
import (
|
||||||
|
"encoding/json"
|
||||||
|
"fmt"
|
||||||
|
"os"
|
||||||
|
"path/filepath"
|
||||||
|
"strings"
|
||||||
|
"sync"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
const (
|
||||||
|
retryMaxPause = 5 * time.Minute
|
||||||
|
retryResetAfter = 2 * time.Minute
|
||||||
|
)
|
||||||
|
|
||||||
|
// pairingFailure is one pairing's last fatal error, as status reads it.
|
||||||
|
type pairingFailure struct {
|
||||||
|
Error string `json:"error"`
|
||||||
|
At string `json:"at"`
|
||||||
|
NextTry string `json:"next_try"`
|
||||||
|
Tries int `json:"tries"`
|
||||||
|
}
|
||||||
|
|
||||||
|
var pairingRetry = struct {
|
||||||
|
sync.Mutex
|
||||||
|
next map[string]time.Time
|
||||||
|
tries map[string]int
|
||||||
|
}{next: map[string]time.Time{}, tries: map[string]int{}}
|
||||||
|
|
||||||
|
func pairingFailuresPath() (string, error) {
|
||||||
|
d, err := configDir()
|
||||||
|
if err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
return filepath.Join(d, "pairing_failures.json"), nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// loadPairingFailures is the record status reads; empty when there is none.
|
||||||
|
func loadPairingFailures() map[string]pairingFailure {
|
||||||
|
out := map[string]pairingFailure{}
|
||||||
|
p, err := pairingFailuresPath()
|
||||||
|
if err != nil {
|
||||||
|
return out
|
||||||
|
}
|
||||||
|
if raw, err := os.ReadFile(p); err == nil {
|
||||||
|
_ = json.Unmarshal(raw, &out)
|
||||||
|
}
|
||||||
|
return out
|
||||||
|
}
|
||||||
|
|
||||||
|
func savePairingFailuresLocked(m map[string]pairingFailure) {
|
||||||
|
p, err := pairingFailuresPath()
|
||||||
|
if err != nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if len(m) == 0 {
|
||||||
|
_ = os.Remove(p)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if b, err := json.MarshalIndent(m, "", " "); err == nil {
|
||||||
|
_ = atomicWrite(p, b)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// retryPause is the pause before try n+1 after n failures in a row.
|
||||||
|
func retryPause(n int) time.Duration {
|
||||||
|
d := supervisePeriod
|
||||||
|
for i := 1; i < n && d < retryMaxPause; i++ {
|
||||||
|
d *= 2
|
||||||
|
}
|
||||||
|
return min(d, retryMaxPause)
|
||||||
|
}
|
||||||
|
|
||||||
|
// pairingFailed records host's fatal error and when it is tried again, and
|
||||||
|
// says so. ranFor is how long the run had been up: one that served for
|
||||||
|
// retryResetAfter starts the count again.
|
||||||
|
func pairingFailed(host string, err error, ranFor time.Duration) {
|
||||||
|
pairingRetry.Lock()
|
||||||
|
defer pairingRetry.Unlock()
|
||||||
|
if ranFor >= retryResetAfter {
|
||||||
|
pairingRetry.tries[host] = 0
|
||||||
|
}
|
||||||
|
pairingRetry.tries[host]++
|
||||||
|
n := pairingRetry.tries[host]
|
||||||
|
now := time.Now()
|
||||||
|
next := now.Add(retryPause(n))
|
||||||
|
pairingRetry.next[host] = next
|
||||||
|
m := loadPairingFailures()
|
||||||
|
m[host] = pairingFailure{Error: err.Error(), At: now.UTC().Format(time.RFC3339),
|
||||||
|
NextTry: next.UTC().Format(time.RFC3339), Tries: n}
|
||||||
|
savePairingFailuresLocked(m)
|
||||||
|
why := strings.TrimRight(strings.TrimSpace(err.Error()), ".")
|
||||||
|
line := fmt.Sprintf("stopped: %s. The other Hosts go on being served; it is tried again by itself at %s.",
|
||||||
|
why, next.Local().Format("15:04:05"))
|
||||||
|
fmt.Printf("[%s] %s\n", host, line)
|
||||||
|
recordLocalEvent("pairing", host+" "+line)
|
||||||
|
}
|
||||||
|
|
||||||
|
// pairingRetryDue: host has no failure pending a pause, or its pause is over.
|
||||||
|
func pairingRetryDue(host string) bool {
|
||||||
|
pairingRetry.Lock()
|
||||||
|
defer pairingRetry.Unlock()
|
||||||
|
next, ok := pairingRetry.next[host]
|
||||||
|
return !ok || !time.Now().Before(next)
|
||||||
|
}
|
||||||
|
|
||||||
|
// pairingRecovered clears host's record: its run has stayed up, or it ended
|
||||||
|
// cleanly.
|
||||||
|
func pairingRecovered(host string) {
|
||||||
|
pairingRetry.Lock()
|
||||||
|
defer pairingRetry.Unlock()
|
||||||
|
if _, ok := pairingRetry.next[host]; !ok {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
delete(pairingRetry.next, host)
|
||||||
|
delete(pairingRetry.tries, host)
|
||||||
|
m := loadPairingFailures()
|
||||||
|
if _, ok := m[host]; ok {
|
||||||
|
delete(m, host)
|
||||||
|
savePairingFailuresLocked(m)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,205 @@
|
|||||||
|
//go:build !windows
|
||||||
|
|
||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"encoding/json"
|
||||||
|
"os"
|
||||||
|
"path/filepath"
|
||||||
|
"strings"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
// anchoredWithPending is the S0 machine: anchored to a Host on this machine,
|
||||||
|
// with a remote Host that redeemed its code and waits.
|
||||||
|
func anchoredWithPending(t *testing.T) {
|
||||||
|
t.Helper()
|
||||||
|
localBox(t)
|
||||||
|
writeTCPPairing(t, tLocal, "127.0.0.1:8811", "")
|
||||||
|
if err := writeAnchor("the owner", tLocal); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
pd, _ := pairingsDir()
|
||||||
|
b, _ := json.Marshal(Config{HostName: tRemote, Transport: transportTCP, LaneAddr: "10.0.2.2:28811", WGPrivateKey: "k",
|
||||||
|
State: pairingPending, ListenAddr: "127.0.0.1:7879", Origin: pairingOriginCarried})
|
||||||
|
if err := os.WriteFile(filepath.Join(pd, tRemote+".json"), b, 0o600); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// `pair` on an anchored machine says the code was used, that the Host waits
|
||||||
|
// for the anchor to admit it, and that the anchor asks the person.
|
||||||
|
//
|
||||||
|
// MUTATION: restore the 0.62 text ("a new host waits until the anchor host
|
||||||
|
// approves it"). RESULT: red.
|
||||||
|
func TestPairOnAnAnchoredMachineSaysWhoAdmitsTheHost(t *testing.T) {
|
||||||
|
anchoredWithPending(t)
|
||||||
|
cfg, all := pairingNamed(t, tRemote)
|
||||||
|
out := pairReportOf(cfg, all, false)
|
||||||
|
for _, want := range []string{
|
||||||
|
"Paired with " + tRemote + " — WAITING for " + tLocal + " to admit it.",
|
||||||
|
"The code was used",
|
||||||
|
tLocal + " asks you to approve " + tRemote,
|
||||||
|
"served at once, with no restart",
|
||||||
|
} {
|
||||||
|
if !strings.Contains(out, want) {
|
||||||
|
t.Errorf("pair does not say %q:\n%s", want, out)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if strings.Contains(out, "not answering") || strings.Contains(out, "privatae-bastion run") {
|
||||||
|
t.Errorf("pair names a dead end:\n%s", out)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// `pair` never tells the person to start a bastion that is running: the
|
||||||
|
// running one serves the new pairing by itself. With none running it names
|
||||||
|
// this machine's own start command.
|
||||||
|
//
|
||||||
|
// MUTATION: restore "Start (or restart) the bastion:\n privatae-bastion run".
|
||||||
|
// RESULT: red.
|
||||||
|
func TestPairNeverSaysRunWhenABastionServesTheMachine(t *testing.T) {
|
||||||
|
localBox(t)
|
||||||
|
writeTCPPairing(t, tLocal, "127.0.0.1:8811", "")
|
||||||
|
cfg, all := pairingNamed(t, tLocal)
|
||||||
|
prev := pairDaemonRunning
|
||||||
|
t.Cleanup(func() { pairDaemonRunning = prev })
|
||||||
|
pairDaemonRunning = func() bool { return true }
|
||||||
|
out := pairReportOf(cfg, all, false)
|
||||||
|
if strings.Contains(out, "privatae-bastion run") || !strings.Contains(out, "serves it within 15 seconds; nothing needs restarting") {
|
||||||
|
t.Errorf("with a bastion running:\n%s", out)
|
||||||
|
}
|
||||||
|
pairDaemonRunning = func() bool { return false }
|
||||||
|
out = pairReportOf(cfg, all, false)
|
||||||
|
if !strings.Contains(out, "Start the bastion so it serves it:\n "+runCommandHint()) {
|
||||||
|
t.Errorf("with none running:\n%s", out)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// `status` and `status --json` say a pending Host waits for the anchor to
|
||||||
|
// admit it, never that it is not answering, and the machine is RUNNING when
|
||||||
|
// every Host it may serve is served.
|
||||||
|
//
|
||||||
|
// MUTATION: count pending pairings as served in readStatus. RESULT: red
|
||||||
|
// (PARTLY RUNNING). Drop WaitingFor. RESULT: red.
|
||||||
|
func TestStatusSaysAPendingHostWaitsForTheAnchor(t *testing.T) {
|
||||||
|
anchoredWithPending(t)
|
||||||
|
s, err := readStatus(readOpts{})
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
var pend *statusPairing
|
||||||
|
for i := range s.Pairings {
|
||||||
|
if s.Pairings[i].Host == tRemote {
|
||||||
|
pend = &s.Pairings[i]
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if pend == nil || pend.WaitingFor != tLocal {
|
||||||
|
t.Fatalf("status --json does not say who admits it: %+v", s.Pairings)
|
||||||
|
}
|
||||||
|
raw, _ := json.Marshal(s)
|
||||||
|
if !strings.Contains(string(raw), `"waiting_for":"`+tLocal+`"`) {
|
||||||
|
t.Errorf("the JSON lacks waiting_for: %s", raw)
|
||||||
|
}
|
||||||
|
// As the daemon reads it, with the anchor's own lane answering.
|
||||||
|
s.Running = "yes"
|
||||||
|
for i := range s.Pairings {
|
||||||
|
if s.Pairings[i].Host == tLocal {
|
||||||
|
s.Pairings[i].Answering = true
|
||||||
|
}
|
||||||
|
}
|
||||||
|
var b strings.Builder
|
||||||
|
printStatus(&b, s)
|
||||||
|
out := b.String()
|
||||||
|
if !strings.HasPrefix(out, "RUNNING — serving 1 host(s)") {
|
||||||
|
t.Errorf("headline:\n%s", out)
|
||||||
|
}
|
||||||
|
if !strings.Contains(out, "Waiting for "+tLocal+" to admit it: "+tRemote) ||
|
||||||
|
!strings.Contains(out, "(waiting for "+tLocal+" to admit it)") {
|
||||||
|
t.Errorf("status does not say who admits it:\n%s", out)
|
||||||
|
}
|
||||||
|
if strings.Contains(out, "not answering") {
|
||||||
|
t.Errorf("a pending Host reads as not answering:\n%s", out)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The console says the same, and the page shows it in place of "not answering".
|
||||||
|
//
|
||||||
|
// MUTATION: drop the WaitingFor branch in status.html. RESULT: red.
|
||||||
|
func TestTheConsoleSaysAPendingHostWaitsForTheAnchor(t *testing.T) {
|
||||||
|
anchoredWithPending(t)
|
||||||
|
s := collectUIStatus()
|
||||||
|
if strings.Contains(s.StateNote, "not answering") || !strings.Contains(s.StateNote, "wait(s) for "+tLocal+" to admit them") {
|
||||||
|
t.Errorf("state %q: %q", s.State, s.StateNote)
|
||||||
|
}
|
||||||
|
found := false
|
||||||
|
for _, p := range s.Pairings {
|
||||||
|
found = found || (p.Host == tRemote && p.WaitingFor == tLocal)
|
||||||
|
}
|
||||||
|
if !found {
|
||||||
|
t.Errorf("pairings %+v", s.Pairings)
|
||||||
|
}
|
||||||
|
page, err := os.ReadFile(filepath.Join("uiassets", "status.html"))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
i, j := strings.Index(string(page), "{{if .WaitingFor}}<span class=\"tag warn\">not served until"), strings.Index(string(page), "not answering</span>")
|
||||||
|
if i < 0 || j < 0 || i > j {
|
||||||
|
t.Error("the page shows a pending Host as not answering")
|
||||||
|
}
|
||||||
|
if line := trayStateLine(s); !strings.Contains(line, "waiting for "+tLocal) {
|
||||||
|
t.Errorf("tray: %q", line)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The anchor's heartbeat carries each pending pairing with what the anchor
|
||||||
|
// Host needs for the approval prompt: who admits it, how it would run, where
|
||||||
|
// its Host is, and how it came.
|
||||||
|
//
|
||||||
|
// MUTATION: drop the pending fields in pairingsReport. RESULT: red.
|
||||||
|
func TestTheAnchorsBeatCarriesWhatItNeedsToAskThePerson(t *testing.T) {
|
||||||
|
anchoredWithPending(t)
|
||||||
|
var e *pairingEntry
|
||||||
|
for _, p := range pairingsReport() {
|
||||||
|
if p.HostName == tRemote {
|
||||||
|
p := p
|
||||||
|
e = &p
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if e == nil || e.State != pairingPending || e.WaitingFor != tLocal || e.Transport != "tcp" || e.SameMachine ||
|
||||||
|
e.Origin != pairingOriginCarried || e.Handle != handleOf(tRemote) {
|
||||||
|
t.Fatalf("%+v", e)
|
||||||
|
}
|
||||||
|
for _, p := range pairingsReport() {
|
||||||
|
if p.HostName == tLocal && (p.WaitingFor != "" || p.Origin != "") {
|
||||||
|
t.Errorf("an active pairing carries the pending fields: %+v", p)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
// The unapproved list keeps its four fields.
|
||||||
|
raw, _ := json.Marshal(unapprovedAttempts(time.Now().Add(time.Hour)))
|
||||||
|
if strings.Contains(string(raw), "waiting_for") {
|
||||||
|
t.Errorf("unapproved attempts grew fields: %s", raw)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The installer's last words come from what the service holds: what it serves
|
||||||
|
// and what waits, before the "no Host is needed" line it said whatever the
|
||||||
|
// service served.
|
||||||
|
//
|
||||||
|
// MUTATION: drop the status --json read. RESULT: red.
|
||||||
|
func TestTheInstallerSaysWhatTheServiceServesAndWhatWaits(t *testing.T) {
|
||||||
|
raw, err := os.ReadFile(filepath.Join("..", "deploy", "install.ps1"))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
s := string(raw)
|
||||||
|
read := strings.Index(s, "$st = (& $exe status --json 2>$null | Out-String) | ConvertFrom-Json")
|
||||||
|
waits := strings.Index(s, "waits for $($p.waiting_for) to admit it")
|
||||||
|
none := strings.Index(s, "no Host is needed.")
|
||||||
|
if read < 0 || waits < 0 || none < 0 || !(read < waits && waits < none) {
|
||||||
|
t.Error("the installer's end text does not come from what the service serves")
|
||||||
|
}
|
||||||
|
if !strings.Contains(s, "if ($served -or $waits) {") {
|
||||||
|
t.Error("the 'no Host is needed' line is not kept for a service that serves none")
|
||||||
|
}
|
||||||
|
}
|
||||||
+4
-10
@@ -106,8 +106,9 @@ func runCommandHintFor(goos string) string {
|
|||||||
return "systemctl start privatae-bastion"
|
return "systemctl start privatae-bastion"
|
||||||
}
|
}
|
||||||
|
|
||||||
// restartHint is how to bring the daemon back on THIS machine after a change
|
// restartHintFor is how to bring the daemon back after a change that only
|
||||||
// that only takes at startup.
|
// takes at startup, on goos (claim-anchor and pair no longer need it: a
|
||||||
|
// running bastion follows the anchor and the pairing files by itself).
|
||||||
//
|
//
|
||||||
// It said `systemctl restart privatae-bastion` unconditionally — the third
|
// It said `systemctl restart privatae-bastion` unconditionally — the third
|
||||||
// Linux instruction printed at a Windows user inside one command's output,
|
// Linux instruction printed at a Windows user inside one command's output,
|
||||||
@@ -116,7 +117,7 @@ func runCommandHintFor(goos string) string {
|
|||||||
// service: deploy/install.ps1 installs the exe and registers a logon task. So
|
// service: deploy/install.ps1 installs the exe and registers a logon task. So
|
||||||
// the honest instruction there is to start it again. A networked install on
|
// the honest instruction there is to start it again. A networked install on
|
||||||
// macOS or Windows runs as a system service (sysservice.go), and for that
|
// macOS or Windows runs as a system service (sysservice.go), and for that
|
||||||
// machine restartHint names the service manager's own restart instead.
|
// machine serviceRestartHintFor names the service manager's own restart instead.
|
||||||
//
|
//
|
||||||
// TAKES THE PLATFORM AS AN ARGUMENT, and that is the point. The first version
|
// TAKES THE PLATFORM AS AN ARGUMENT, and that is the point. The first version
|
||||||
// branched on runtime.GOOS directly, so the only machine that could test the
|
// branched on runtime.GOOS directly, so the only machine that could test the
|
||||||
@@ -124,13 +125,6 @@ func runCommandHintFor(goos string) string {
|
|||||||
// passed clean on the Linux builder. That is the same hole that let 'darwin'
|
// passed clean on the Linux builder. That is the same hole that let 'darwin'
|
||||||
// match 'win' in the dashboard: a platform branch nothing off-platform can
|
// match 'win' in the dashboard: a platform branch nothing off-platform can
|
||||||
// reach is a platform branch nothing checks.
|
// reach is a platform branch nothing checks.
|
||||||
func restartHint() string {
|
|
||||||
if systemService.installed && (runtime.GOOS == "darwin" || runtime.GOOS == "windows") {
|
|
||||||
return serviceRestartHintFor(runtime.GOOS)
|
|
||||||
}
|
|
||||||
return restartHintFor(runtime.GOOS)
|
|
||||||
}
|
|
||||||
|
|
||||||
func restartHintFor(goos string) string {
|
func restartHintFor(goos string) string {
|
||||||
if goos == "windows" {
|
if goos == "windows" {
|
||||||
return "Start the bastion again so the change takes: privatae-bastion run\n" +
|
return "Start the bastion again so the change takes: privatae-bastion run\n" +
|
||||||
|
|||||||
@@ -0,0 +1,122 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"os"
|
||||||
|
"path/filepath"
|
||||||
|
"regexp"
|
||||||
|
"strconv"
|
||||||
|
"strings"
|
||||||
|
"testing"
|
||||||
|
)
|
||||||
|
|
||||||
|
// The member repository publishes this tree to strangers byte for byte, and
|
||||||
|
// its release step refuses outright a tree that carries any of the classes
|
||||||
|
// below. Each is checked here as well, so a change that brings one in fails
|
||||||
|
// before it merges, not after a release has been built and signed from it.
|
||||||
|
//
|
||||||
|
// A class is described, never named: a comment says what happened and why, not
|
||||||
|
// on which of our machines, by whom, under which ticket, or on which day it was
|
||||||
|
// decided. Test data is invented (example.com, .example, the 9000 range).
|
||||||
|
//
|
||||||
|
// Not checked here: names held outside this repository (they cannot be listed
|
||||||
|
// in a published file; the release step and the personal-data check read them
|
||||||
|
// from the machine they are kept on), and the two classes the release step
|
||||||
|
// compares against the previous release instead of refusing outright: paths
|
||||||
|
// under root's home directory, which the bastion's own state and its tests of
|
||||||
|
// credential-store refusals legitimately use, and the bastion's own tunnel
|
||||||
|
// addresses in the private range.
|
||||||
|
//
|
||||||
|
// Every pattern is written so that this file does not match it: a bracketed
|
||||||
|
// letter keeps the text from being the word it finds.
|
||||||
|
var publishedInternalClasses = []struct {
|
||||||
|
name string
|
||||||
|
re *regexp.Regexp
|
||||||
|
}{
|
||||||
|
{"a machine of the platform's own fleet",
|
||||||
|
regexp.MustCompile(`mgmt-[12]|platform-meta[l]|entity-poo[l]|edge-vi[n]|edge-hi[l]|dmz-[a-z]+-[0-9]`)},
|
||||||
|
{"a credential store of the platform",
|
||||||
|
regexp.MustCompile(`gitea-[s]kema-credentials|/roo[t]/\.config/git|INTERNAL_API_SECRE[T]`)},
|
||||||
|
{"a ticket id", regexp.MustCompile(`T-[0-9]{4}\b|R-[0-9]{3}\b`)},
|
||||||
|
{"the name of a person or a review agent who worked on the code",
|
||||||
|
regexp.MustCompile(`\b(Fabl[e]|Maddi[e]|Opu[s])\b|[Cc]ase[y]`)},
|
||||||
|
{"a dated decision", regexp.MustCompile(`(Decided|Reported|Measured|measured) 20[0-9]{2}-[0-9]{2}`)},
|
||||||
|
{"a design document reference", regexp.MustCompile(`DESIGN-[a-z]|plan [§]`)},
|
||||||
|
{"the old module path", regexp.MustCompile(`github\.com/privata[e]`)},
|
||||||
|
{"the platform's install directory", regexp.MustCompile(`/opt/privata[e]`)},
|
||||||
|
{"an address in the platform's fleet mesh", regexp.MustCompile(`fd0[0]:aa:`)},
|
||||||
|
}
|
||||||
|
|
||||||
|
// publishedInternalHits returns "class: line N" for every line of src that a
|
||||||
|
// class matches.
|
||||||
|
func publishedInternalHits(src string) []string {
|
||||||
|
var hits []string
|
||||||
|
for i, line := range strings.Split(src, "\n") {
|
||||||
|
for _, c := range publishedInternalClasses {
|
||||||
|
if c.re.MatchString(line) {
|
||||||
|
hits = append(hits, strconv.Itoa(i+1)+": "+c.name)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return hits
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestPublishedSourceNamesNothingInternal(t *testing.T) {
|
||||||
|
root, err := filepath.Abs("..")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
files := publishedFiles(t, root)
|
||||||
|
if len(files) < 50 {
|
||||||
|
t.Fatalf("found only %d files under %s; the scan is not looking at the repository", len(files), root)
|
||||||
|
}
|
||||||
|
var hits []string
|
||||||
|
for _, rel := range files {
|
||||||
|
for _, h := range publishedInternalHits(rel) {
|
||||||
|
hits = append(hits, rel+" (in the file name) "+h[strings.Index(h, " ")+1:])
|
||||||
|
}
|
||||||
|
data, err := os.ReadFile(filepath.Join(root, rel))
|
||||||
|
if err != nil {
|
||||||
|
continue // a tracked file deleted in the working tree
|
||||||
|
}
|
||||||
|
for _, h := range publishedInternalHits(string(data)) {
|
||||||
|
hits = append(hits, rel+":"+h)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
// The lines themselves are not printed: a hit of the first two classes can
|
||||||
|
// be the very value that must not be published, and a CI log is published too.
|
||||||
|
if len(hits) > 0 {
|
||||||
|
t.Errorf("%d published lines name something internal; describe it instead, with invented values:\n %s",
|
||||||
|
len(hits), strings.Join(hits, "\n "))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The check itself: each class fires on a planted line and stays quiet on its
|
||||||
|
// look-alikes. Planted lines carry a "|" that is removed before they are read.
|
||||||
|
func TestPublishedInternalCheckCatchesEachClass(t *testing.T) {
|
||||||
|
live := func(s string) string { return strings.ReplaceAll(s, "|", "") }
|
||||||
|
for _, line := range []string{
|
||||||
|
"seen on mgmt|-2 at noon", "ssh platform-met|al", "the entity-po|ol nodes", "via edge-v|in",
|
||||||
|
"edge-h|il took over", "dmz-ro|uter-1 is up",
|
||||||
|
"read /ro|ot/.config/g|it/creds", "gitea-sk|ema-credentials", "INTERNAL_API_SEC|RET=x",
|
||||||
|
"fixed in T-|1234", "see R-|101.",
|
||||||
|
"Fab|le found it", "per Mad|die", "Op|us said so", "Ca|sey asked", `owner "ca|sey"`,
|
||||||
|
"Decid|ed 2026-10-01: keep it", "measu|red 2026-11-03 on a box",
|
||||||
|
"DESIGN|-bastion.md", "plan| § 4",
|
||||||
|
"github.com/priv|atae/bastion", "/opt/priv|atae/bin", "addr fd0|0:aa::1",
|
||||||
|
} {
|
||||||
|
if len(publishedInternalHits(live(line))) == 0 {
|
||||||
|
t.Errorf("%q: not caught", live(line))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
for _, line := range []string{
|
||||||
|
"mgmt-3 is not ours", "platform metal", "edge-v",
|
||||||
|
"dmz-router", "~/.config/git", "T-123 and T-12345x", "R-1000",
|
||||||
|
"Fables and Opuses", "Maddies", "a case, yes", "decided in 2026",
|
||||||
|
"design doc", "github.com/example/thing", "/opt/example/privatae-bastion",
|
||||||
|
"fd12:3456::a:1", "fdaa::1",
|
||||||
|
} {
|
||||||
|
if hits := publishedInternalHits(live(line)); len(hits) != 0 {
|
||||||
|
t.Errorf("%q: false hit %v", line, hits)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
+63
-37
@@ -11,9 +11,12 @@ package main
|
|||||||
// kernel which account connected. Asked for a read by the account recorded as
|
// kernel which account connected. Asked for a read by the account recorded as
|
||||||
// the machine's owner (owner_account.go), the daemon builds it with the
|
// the machine's owner (owner_account.go), the daemon builds it with the
|
||||||
// machine's own view and answers with it. That is what the owner's console
|
// machine's own view and answers with it. That is what the owner's console
|
||||||
// lane (consolelane.go) already shows that account, with one difference:
|
// lane (consolelane.go) already shows that account, and more that the console
|
||||||
// posture, which the console has no page for, adds the machine's firewall
|
// has no page for: posture (the machine's firewall checks, read as the
|
||||||
// checks, read as the administrator. The delegation tag an agent carries,
|
// administrator); the ops and op grants each Host holds here, its backup
|
||||||
|
// requests and the folders shared with it; this bastion's backup keys (public
|
||||||
|
// halves only); and doctor. All of it is about the owner's own machine, and
|
||||||
|
// the lane answers no other account. The delegation tag an agent carries,
|
||||||
// which the console never shows, is in no read at all (readAgents).
|
// which the console never shows, is in no read at all (readAgents).
|
||||||
// Any other account is refused; where a read means something with its own
|
// Any other account is refused; where a read means something with its own
|
||||||
// permissions (the agents, schedules and tool servers it can see), it gets
|
// permissions (the agents, schedules and tool servers it can see), it gets
|
||||||
@@ -28,9 +31,9 @@ import (
|
|||||||
"errors"
|
"errors"
|
||||||
"fmt"
|
"fmt"
|
||||||
"io"
|
"io"
|
||||||
"net"
|
|
||||||
"os"
|
"os"
|
||||||
"runtime"
|
"runtime"
|
||||||
|
"runtime/debug"
|
||||||
"strconv"
|
"strconv"
|
||||||
"sync"
|
"sync"
|
||||||
"time"
|
"time"
|
||||||
@@ -73,23 +76,30 @@ type machineRead struct {
|
|||||||
|
|
||||||
// machineReads are what the daemon answers over ask.sock, by name.
|
// machineReads are what the daemon answers over ask.sock, by name.
|
||||||
var machineReads = map[string]machineRead{
|
var machineReads = map[string]machineRead{
|
||||||
"status": {build: func(o readOpts) (any, error) { return readStatus(o) }},
|
"status": {build: func(o readOpts) (any, error) { return readStatus(o) }},
|
||||||
"agents": {build: func(o readOpts) (any, error) { return readAgents(o) }},
|
"agents": {build: func(o readOpts) (any, error) { return readAgents(o) }},
|
||||||
"schedules": {build: func(o readOpts) (any, error) { return readSchedules(o) }},
|
"schedules": {build: func(o readOpts) (any, error) { return readSchedules(o) }},
|
||||||
"tool-servers": {build: func(o readOpts) (any, error) { return readToolServers(o) }},
|
"tool-servers": {build: func(o readOpts) (any, error) { return readToolServers(o) }},
|
||||||
"posture": {build: func(o readOpts) (any, error) { return readPosture(o) }, heavy: true},
|
"posture": {build: func(o readOpts) (any, error) { return readPosture(o) }, heavy: true},
|
||||||
"baseline": {build: func(o readOpts) (any, error) { return readBaseline(o) }},
|
"baseline": {build: func(o readOpts) (any, error) { return readBaseline(o) }},
|
||||||
"baseline-diff": {build: func(o readOpts) (any, error) { return readBaselineDiff(o) }, heavy: true},
|
"baseline-diff": {build: func(o readOpts) (any, error) { return readBaselineDiff(o) }, heavy: true},
|
||||||
"activity": {build: func(o readOpts) (any, error) { return readActivity(o) }},
|
"activity": {build: func(o readOpts) (any, error) { return readActivity(o) }},
|
||||||
"report": {build: func(o readOpts) (any, error) { return readReport(o) }, heavy: true},
|
"report": {build: func(o readOpts) (any, error) { return readReport(o) }, heavy: true},
|
||||||
"approvals": {build: func(o readOpts) (any, error) { return readApprovals(o) }},
|
"approvals": {build: func(o readOpts) (any, error) { return readApprovals(o) }},
|
||||||
|
"switches": {build: func(o readOpts) (any, error) { return readSwitches(o) }},
|
||||||
|
"ops": {build: func(o readOpts) (any, error) { return readOps(o) }},
|
||||||
|
"device-approvals": {build: func(o readOpts) (any, error) { return readDeviceApprovals(o) }},
|
||||||
|
"backup-keys": {build: func(o readOpts) (any, error) { return readBackupKeys(o) }},
|
||||||
|
"backup-requests": {build: func(o readOpts) (any, error) { return readBackupRequests(o) }},
|
||||||
|
"backup-shares": {build: func(o readOpts) (any, error) { return readBackupShares(o) }},
|
||||||
|
"doctor": {build: func(o readOpts) (any, error) { return readDoctor(o) }, heavy: true},
|
||||||
}
|
}
|
||||||
|
|
||||||
// readsGoThroughLane: the machine's bastion is a system service this account
|
// readsGoThroughLane: the machine's bastion is a system service this account
|
||||||
// does not administer, so its state is not this process's to read.
|
// does not administer, so its state is not this process's to read.
|
||||||
var readsGoThroughLane = func() bool {
|
var readsGoThroughLane = func() bool {
|
||||||
if runtime.GOOS == "windows" || machineAuthorityHeld() {
|
if machineAuthorityHeld() {
|
||||||
return false // no ask pipe on Windows yet; the administrator reads directly
|
return false // the administrator reads the service's state directly
|
||||||
}
|
}
|
||||||
if runtime.GOOS == "linux" {
|
if runtime.GOOS == "linux" {
|
||||||
return linuxSystemUnitPresent()
|
return linuxSystemUnitPresent()
|
||||||
@@ -145,7 +155,7 @@ func laneRefusalError(cmd string, err error) error {
|
|||||||
if !errors.As(err, &le) {
|
if !errors.As(err, &le) {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
return fmt.Errorf("%s\n As the administrator: sudo -H privatae-bastion %s", le.why, cmd)
|
return fmt.Errorf("%s\n As the administrator: %s", le.why, adminCommandFor(runtime.GOOS == "windows", cmd))
|
||||||
}
|
}
|
||||||
|
|
||||||
// ── the asking side ─────────────────────────────────────────────────────────
|
// ── the asking side ─────────────────────────────────────────────────────────
|
||||||
@@ -155,8 +165,8 @@ func laneRefusalError(cmd string, err error) error {
|
|||||||
var readSockPath = askSockPath
|
var readSockPath = askSockPath
|
||||||
|
|
||||||
func readViaSock(name string, o readOpts, v any) error {
|
func readViaSock(name string, o readOpts, v any) error {
|
||||||
p := readSockPath()
|
p := askLaneAddr(readSockPath())
|
||||||
c, err := net.DialTimeout("unix", p, 3*time.Second)
|
c, err := dialAskLane(readSockPath())
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return &laneError{down: true, why: "nothing answers on " + p + " (" + err.Error() + ")"}
|
return &laneError{down: true, why: "nothing answers on " + p + " (" + err.Error() + ")"}
|
||||||
}
|
}
|
||||||
@@ -170,6 +180,9 @@ func readViaSock(name string, o readOpts, v any) error {
|
|||||||
if err := json.NewDecoder(io.LimitReader(c, readMaxBytes)).Decode(&r); err != nil {
|
if err := json.NewDecoder(io.LimitReader(c, readMaxBytes)).Decode(&r); err != nil {
|
||||||
return &laneError{down: true, why: "the machine's bastion did not answer the read (" + err.Error() + ")"}
|
return &laneError{down: true, why: "the machine's bastion did not answer the read (" + err.Error() + ")"}
|
||||||
}
|
}
|
||||||
|
if !r.OK && r.Failed {
|
||||||
|
return errors.New(r.Why)
|
||||||
|
}
|
||||||
if !r.OK {
|
if !r.OK {
|
||||||
return &laneError{why: r.Why}
|
return &laneError{why: r.Why}
|
||||||
}
|
}
|
||||||
@@ -183,30 +196,30 @@ func readViaSock(name string, o readOpts, v any) error {
|
|||||||
// ── the answering side (the daemon) ─────────────────────────────────────────
|
// ── the answering side (the daemon) ─────────────────────────────────────────
|
||||||
|
|
||||||
type agentReadReply struct {
|
type agentReadReply struct {
|
||||||
OK bool `json:"ok"`
|
OK bool `json:"ok"`
|
||||||
Why string `json:"why,omitempty"`
|
Why string `json:"why,omitempty"`
|
||||||
User string `json:"user,omitempty"`
|
// Failed: the read was answered for this account and could not be
|
||||||
View json.RawMessage `json:"view,omitempty"`
|
// built (Why says why): the administrator would be told the same, so it
|
||||||
|
// is not a refusal. A bastion older than this field says it as one.
|
||||||
|
Failed bool `json:"failed,omitempty"`
|
||||||
|
User string `json:"user,omitempty"`
|
||||||
|
View json.RawMessage `json:"view,omitempty"`
|
||||||
}
|
}
|
||||||
|
|
||||||
// readLaneRefusal says why account uid may not read through the lane, or "".
|
// readLaneRefusalFor says why peer may not read through the lane, or "".
|
||||||
// The owner's account only: the agents, folders and prompts of every
|
// The owner's account only: the agents, folders and prompts of every
|
||||||
// account's sessions are the owner's to see, not another account's.
|
// account's sessions are the owner's to see, not another account's.
|
||||||
func readLaneRefusal(uid uint32, who string) string {
|
func readLaneRefusalFor(p askPeer) string {
|
||||||
owner, ownerName, present, err := ownerAccountLoad()
|
match, ownerName, present, err := laneOwnerMatch(p)
|
||||||
switch {
|
switch {
|
||||||
case err != nil:
|
case err != nil:
|
||||||
return "this machine's owner account cannot be read (" + err.Error() + ")"
|
return "this machine's owner account cannot be read (" + err.Error() + ")"
|
||||||
case !present:
|
case !present:
|
||||||
return "no account is recorded as this machine's owner, so its bastion answers reads only for the " +
|
return "no account is recorded as this machine's owner, so its bastion answers reads only for the " +
|
||||||
"administrator. To read from your own account, the administrator records it once: " +
|
"administrator. To read from your own account, the administrator records it once: " +
|
||||||
"sudo -H privatae-bastion approvals-owner --account " + accountForHint(who)
|
ownerRecordCommand(p)
|
||||||
case owner != uid:
|
case !match:
|
||||||
name := ownerName
|
return "this machine's bastion answers reads only for its owner's account (" + ownerName + "), not " + p.Name
|
||||||
if name == "" {
|
|
||||||
name = "uid " + strconv.FormatUint(uint64(owner), 10)
|
|
||||||
}
|
|
||||||
return "this machine's bastion answers reads only for its owner's account (" + name + "), not " + who
|
|
||||||
}
|
}
|
||||||
return ""
|
return ""
|
||||||
}
|
}
|
||||||
@@ -231,8 +244,12 @@ var readNow = time.Now
|
|||||||
var readSlots = make(chan struct{}, 4)
|
var readSlots = make(chan struct{}, 4)
|
||||||
|
|
||||||
func serveRead(uid uint32, user string, req agentAskRequest) agentReadReply {
|
func serveRead(uid uint32, user string, req agentAskRequest) agentReadReply {
|
||||||
r := agentReadReply{User: user}
|
return serveReadFor(askPeer{UID: uid, Name: user}, req)
|
||||||
if why := readLaneRefusal(uid, user); why != "" {
|
}
|
||||||
|
|
||||||
|
func serveReadFor(p askPeer, req agentAskRequest) agentReadReply {
|
||||||
|
r := agentReadReply{User: p.Name}
|
||||||
|
if why := readLaneRefusalFor(p); why != "" {
|
||||||
r.Why = why
|
r.Why = why
|
||||||
return r
|
return r
|
||||||
}
|
}
|
||||||
@@ -252,7 +269,7 @@ func serveRead(uid uint32, user string, req agentAskRequest) agentReadReply {
|
|||||||
o := readOpts{Since: req.Since, Prompts: req.Prompts, Host: req.Host, Machine: req.Machine}
|
o := readOpts{Since: req.Since, Prompts: req.Prompts, Host: req.Host, Machine: req.Machine}
|
||||||
view, err := runMachineRead(req.Read, spec, o)
|
view, err := runMachineRead(req.Read, spec, o)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
r.Why = err.Error()
|
r.Why, r.Failed = err.Error(), true
|
||||||
return r
|
return r
|
||||||
}
|
}
|
||||||
if len(view) > readMaxBytes-readEnvelope {
|
if len(view) > readMaxBytes-readEnvelope {
|
||||||
@@ -267,7 +284,16 @@ func serveRead(uid uint32, user string, req agentAskRequest) agentReadReply {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func runMachineRead(name string, spec machineRead, o readOpts) ([]byte, error) {
|
func runMachineRead(name string, spec machineRead, o readOpts) ([]byte, error) {
|
||||||
build := func() ([]byte, error) {
|
build := func() (b []byte, err error) {
|
||||||
|
// A read runs inside the daemon that serves every pairing, from code
|
||||||
|
// written for a command's own process: one that panics is that read's
|
||||||
|
// failure, never the daemon's end.
|
||||||
|
defer func() {
|
||||||
|
if p := recover(); p != nil {
|
||||||
|
uilogf("read %s panicked: %v\n%s", name, p, debug.Stack())
|
||||||
|
b, err = nil, fmt.Errorf("the read %s failed inside this bastion (%v); its log has the trace", name, p)
|
||||||
|
}
|
||||||
|
}()
|
||||||
v, err := spec.build(o)
|
v, err := spec.build(o)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
|
|||||||
@@ -7,6 +7,7 @@ import (
|
|||||||
"os"
|
"os"
|
||||||
"path/filepath"
|
"path/filepath"
|
||||||
"strings"
|
"strings"
|
||||||
|
"sync"
|
||||||
"testing"
|
"testing"
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -19,16 +20,10 @@ func laneSock(t *testing.T) {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
t.Cleanup(func() { _ = ln.Close() })
|
// The globals are set before the server goroutine starts and restored only
|
||||||
go func() {
|
// after it and every connection it served have returned: a client's
|
||||||
for {
|
// connect is no happens-before edge the race detector sees, so a server
|
||||||
c, err := ln.Accept()
|
// that read them unordered with these writes is a data race under -race.
|
||||||
if err != nil {
|
|
||||||
return
|
|
||||||
}
|
|
||||||
go askSockServe(c)
|
|
||||||
}
|
|
||||||
}()
|
|
||||||
prevPath, prevLane, prevID := readSockPath, readsGoThroughLane, askPeerIdentityFn
|
prevPath, prevLane, prevID := readSockPath, readsGoThroughLane, askPeerIdentityFn
|
||||||
t.Cleanup(func() { readSockPath, readsGoThroughLane, askPeerIdentityFn = prevPath, prevLane, prevID })
|
t.Cleanup(func() { readSockPath, readsGoThroughLane, askPeerIdentityFn = prevPath, prevLane, prevID })
|
||||||
readSockPath = func() string { return sock }
|
readSockPath = func() string { return sock }
|
||||||
@@ -42,6 +37,20 @@ func laneSock(t *testing.T) {
|
|||||||
}
|
}
|
||||||
return uid, who, err
|
return uid, who, err
|
||||||
}
|
}
|
||||||
|
var served sync.WaitGroup
|
||||||
|
served.Add(1)
|
||||||
|
t.Cleanup(func() { _ = ln.Close(); served.Wait() })
|
||||||
|
go func() {
|
||||||
|
defer served.Done()
|
||||||
|
for {
|
||||||
|
c, err := ln.Accept()
|
||||||
|
if err != nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
served.Add(1)
|
||||||
|
go func() { defer served.Done(); askSockServe(c) }()
|
||||||
|
}
|
||||||
|
}()
|
||||||
}
|
}
|
||||||
|
|
||||||
const laneTestUID = 1000
|
const laneTestUID = 1000
|
||||||
|
|||||||
@@ -0,0 +1,87 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"encoding/json"
|
||||||
|
"errors"
|
||||||
|
"os"
|
||||||
|
"strings"
|
||||||
|
"testing"
|
||||||
|
)
|
||||||
|
|
||||||
|
// The owner's agent reads the switch list, the doctor and the device's asks
|
||||||
|
// from the machine's bastion over its socket; a read the bastion answers but
|
||||||
|
// cannot build comes back as that failure, not as a refusal with the
|
||||||
|
// administrator's command (the administrator would be told the same).
|
||||||
|
func TestTheSliceThreeReadsGoThroughTheLane(t *testing.T) {
|
||||||
|
askFlowWorld(t)
|
||||||
|
laneOwner(t, laneTestUID)
|
||||||
|
laneSock(t)
|
||||||
|
prevSys, prevLatest, prevSandbox := systemInstalled, doctorLatest, doctorSandbox
|
||||||
|
t.Cleanup(func() { systemInstalled, doctorLatest, doctorSandbox = prevSys, prevLatest, prevSandbox })
|
||||||
|
systemInstalled = func() bool { return true }
|
||||||
|
doctorLatest = func() string { return "" }
|
||||||
|
doctorSandbox = func() (bool, string) { return true, "" }
|
||||||
|
out := captureStdout(t)
|
||||||
|
|
||||||
|
if err := cmdSwitch([]string{"--list", "--json"}); err != nil {
|
||||||
|
t.Fatalf("switch --list --json: %v", err)
|
||||||
|
}
|
||||||
|
var sw switchesRead
|
||||||
|
if err := json.Unmarshal([]byte(printedSince(out, 0, "}\n")), &sw); err != nil {
|
||||||
|
t.Fatalf("switch --list --json printed %q (%v)", out(), err)
|
||||||
|
}
|
||||||
|
|
||||||
|
before := len(out())
|
||||||
|
err := cmdDoctor([]string{"--json"})
|
||||||
|
var q quietExit
|
||||||
|
if err != nil && !errors.As(err, &q) {
|
||||||
|
t.Fatalf("doctor through the lane: %v", err)
|
||||||
|
}
|
||||||
|
var d doctorRead
|
||||||
|
if err := json.Unmarshal([]byte(printedSince(out, before, "}\n")), &d); err != nil || len(d.Checks) == 0 {
|
||||||
|
t.Fatalf("doctor --json printed %q (%v)", out()[before:], err)
|
||||||
|
}
|
||||||
|
if c, ok := doctorCheckNamed(d, "owner"); !ok || !c.OK {
|
||||||
|
t.Errorf("the machine's doctor, read by its owner, does not find the owner: %+v", d.Checks)
|
||||||
|
}
|
||||||
|
|
||||||
|
p, err := deviceShownPath()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if err := cmdDeviceApprovals(nil); err != nil {
|
||||||
|
t.Fatalf("device-approvals through the lane: %v", err)
|
||||||
|
}
|
||||||
|
if _, err := os.Stat(p); err == nil {
|
||||||
|
t.Error("device-approvals read through the lane recorded what it printed as shown")
|
||||||
|
}
|
||||||
|
|
||||||
|
// MUTATION: drop `r.Failed = true` in serveRead. RESULT: red, the error
|
||||||
|
// carries the administrator's command.
|
||||||
|
err = cmdOpsList("", true)
|
||||||
|
var le *laneError
|
||||||
|
if err == nil || errors.As(err, &le) || strings.Contains(err.Error(), "As the administrator") {
|
||||||
|
t.Errorf("ops with nothing paired, through the lane: %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// `switch --list` passes the guard beside the system unit, as status does;
|
||||||
|
// `switch` does too since the owner's account switches through the lane
|
||||||
|
// (owneracts.go), and on Windows as well since the ask pipe.
|
||||||
|
func TestTheGuardLetsSwitchListThroughAndNotSwitch(t *testing.T) {
|
||||||
|
prevArgs, prevUnit, prevAuth := os.Args, linuxSystemUnitPresent, systemService.authority
|
||||||
|
t.Cleanup(func() { os.Args, linuxSystemUnitPresent, systemService.authority = prevArgs, prevUnit, prevAuth })
|
||||||
|
linuxSystemUnitPresent = func() bool { return true }
|
||||||
|
systemService.authority = false
|
||||||
|
os.Args = []string{"privatae-bastion", "switch", "--list", "--json"}
|
||||||
|
if err := guardServiceFork("switch"); err != nil {
|
||||||
|
t.Errorf("switch --list beside the system unit: %v", err)
|
||||||
|
}
|
||||||
|
os.Args = []string{"privatae-bastion", "switch", "box", "ops", "off"}
|
||||||
|
if err := guardServiceFork("switch"); err != nil {
|
||||||
|
t.Errorf("switch from the owner's account beside the system unit, before the lane could decide: %v", err)
|
||||||
|
}
|
||||||
|
if err := serviceGuard("windows", serviceGuardKey("switch", os.Args), true, false); err != nil {
|
||||||
|
t.Errorf("switch from the owner's account beside a Windows service, before the ask pipe could decide: %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,520 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"bytes"
|
||||||
|
"encoding/json"
|
||||||
|
"errors"
|
||||||
|
"os"
|
||||||
|
"strings"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
// The switch list as JSON has every row the words have, each family of each
|
||||||
|
// paired host, and an unreadable list reads as every family off.
|
||||||
|
func TestTheSwitchListReadHasEveryRowTheWordsHave(t *testing.T) {
|
||||||
|
uiTestConfigDir(t)
|
||||||
|
const host = "box-one.example"
|
||||||
|
givenPairing(t, host, pairingActive)
|
||||||
|
if err := localDenySet(host, "ops", true); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
v, err := readSwitches(readOpts{})
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if len(v.Switches) != len(localSwitchFamilies()) {
|
||||||
|
t.Fatalf("want one row per family (%d), got %+v", len(localSwitchFamilies()), v.Switches)
|
||||||
|
}
|
||||||
|
var buf bytes.Buffer
|
||||||
|
printSwitches(&buf, v)
|
||||||
|
lines := strings.Split(strings.TrimSpace(buf.String()), "\n")
|
||||||
|
if len(lines) != len(v.Switches) {
|
||||||
|
t.Fatalf("%d rows, %d lines:\n%s", len(v.Switches), len(lines), buf.String())
|
||||||
|
}
|
||||||
|
for i, r := range v.Switches {
|
||||||
|
f := strings.Fields(lines[i])
|
||||||
|
if f[0] != r.Host || f[1] != r.Family || (f[2] == "off") != r.Off {
|
||||||
|
t.Errorf("row %+v printed as %q", r, lines[i])
|
||||||
|
}
|
||||||
|
if r.Family == "ops" && (!r.Off || r.Since == "") {
|
||||||
|
t.Errorf("ops was switched off: %+v", r)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// MUTATION: build rows from f.Off only, ignoring readErr. RESULT: red,
|
||||||
|
// the families read on while the gate refuses them all.
|
||||||
|
path, err := localDenyPath()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if err := os.WriteFile(path, []byte("{not json"), 0o600); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
v, err = readSwitches(readOpts{})
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if v.Unreadable == "" {
|
||||||
|
t.Error("an unreadable list is not said")
|
||||||
|
}
|
||||||
|
for _, r := range v.Switches {
|
||||||
|
if !r.Off {
|
||||||
|
t.Errorf("with the list unreadable, %s %s reads on", r.Host, r.Family)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Read as JSON, the device's asks are a program's, not a person's: nothing is
|
||||||
|
// recorded as shown, so `device-approve all` signs nothing an agent read.
|
||||||
|
func TestDeviceApprovalsAsJSONRecordsNothingShown(t *testing.T) {
|
||||||
|
uiTestConfigDir(t)
|
||||||
|
p, err := deviceShownPath()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if err := cmdDeviceApprovals([]string{"--json"}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if _, err := os.Stat(p); err == nil {
|
||||||
|
t.Error("device-approvals --json recorded what it printed as shown")
|
||||||
|
}
|
||||||
|
if err := cmdDeviceApprovals(nil); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if _, err := os.Stat(p); err != nil {
|
||||||
|
t.Errorf("the words listing recorded nothing as shown: %v", err)
|
||||||
|
}
|
||||||
|
if err := cmdDeviceApprovals([]string{"--jsno"}); err == nil || !strings.Contains(err.Error(), "usage:") {
|
||||||
|
t.Errorf("a stray flag: %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A restore request read leaves the sealed key the host sent, and the one
|
||||||
|
// resealed for it, out of the answer; their digest and the words stay.
|
||||||
|
func TestTheBackupRequestsReadLeavesTheSealedKeysOut(t *testing.T) {
|
||||||
|
uiTestConfigDir(t)
|
||||||
|
const host = "box-one.example"
|
||||||
|
givenPairing(t, host, pairingActive)
|
||||||
|
cfg, err := stepupPairing(host)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
const sealed, resealed = "-----BEGIN AGE ENCRYPTED FILE-----SIDECAR", "-----BEGIN AGE ENCRYPTED FILE-----RESEALED"
|
||||||
|
at := time.Now().UTC().Format(time.RFC3339)
|
||||||
|
// r1 waits, so it still carries the sidecar it came with; r2 was
|
||||||
|
// answered and carries the resealed key.
|
||||||
|
if err := resealSave(cfg.dcnDir(), map[string]*resealRequest{
|
||||||
|
"r1": {ID: "r1", Stamp: "20261101T000000Z", Pairing: host, HostNumber: 7, HostLabel: "home", To: "age1xyz",
|
||||||
|
ToFP: "fp", Sidecar: sealed, SidecarSH: "abc123", At: at, State: "pending"},
|
||||||
|
"r2": {ID: "r2", Stamp: "20261101T000000Z", Pairing: host, HostNumber: 7, HostLabel: "home", To: "age1xyz",
|
||||||
|
ToFP: "fp", SidecarSH: "def456", At: at, State: "done", Resealed: resealed},
|
||||||
|
}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
stored, err := resealRead(cfg.dcnDir())
|
||||||
|
if err != nil || stored["r1"] == nil || stored["r1"].Sidecar != sealed || stored["r2"] == nil || stored["r2"].Resealed != resealed {
|
||||||
|
t.Fatalf("the fixture does not hold both sealed keys: %+v %v", stored, err)
|
||||||
|
}
|
||||||
|
// MUTATION: build the view from *resealRequest itself. RESULT: red, both
|
||||||
|
// sealed keys are in the answer.
|
||||||
|
v, err := readBackupRequests(readOpts{Host: host})
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
b, _ := json.Marshal(v)
|
||||||
|
if strings.Contains(string(b), "SIDECAR") || strings.Contains(string(b), "RESEALED") {
|
||||||
|
t.Errorf("the read carries a sealed key: %s", b)
|
||||||
|
}
|
||||||
|
if len(v.Requests) != 2 || v.Requests[0].SidecarSHA == "" || !strings.Contains(v.Requests[0].Words, "home") {
|
||||||
|
t.Errorf("the requests as read: %+v", v.Requests)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The backup key read carries the public halves only.
|
||||||
|
func TestTheBackupKeysReadHasNoSecretHalf(t *testing.T) {
|
||||||
|
b, err := json.Marshal(backupKeysRead{Keys: []*backupKeyFile{{Identity: "AGE-SECRET-KEY-1SECRET", Recipient: "age1pub",
|
||||||
|
Fingerprint: "fp"}}, Current: "fp"})
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if strings.Contains(string(b), "AGE-SECRET-KEY") {
|
||||||
|
t.Errorf("the backup keys read carries the secret: %s", b)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// agents show takes a pid, or a session name that matches exactly one, the
|
||||||
|
// rule stop keeps.
|
||||||
|
func TestAgentsShowPicksExactlyOneAgent(t *testing.T) {
|
||||||
|
views := []agentView{
|
||||||
|
{agentObs: agentObs{PID: 101, Signature: "claude-code"}, Self: &agentSelf{Name: "shop"}},
|
||||||
|
{agentObs: agentObs{PID: 102, Signature: "claude-code"}, Self: &agentSelf{Name: "twin"}},
|
||||||
|
{agentObs: agentObs{PID: 103, Signature: "aider"}, Self: &agentSelf{Name: "twin"}},
|
||||||
|
}
|
||||||
|
if v, err := pickAgentView(views, "101"); err != nil || v.PID != 101 {
|
||||||
|
t.Errorf("by pid: %+v %v", v, err)
|
||||||
|
}
|
||||||
|
if v, err := pickAgentView(views, "shop"); err != nil || v.PID != 101 {
|
||||||
|
t.Errorf("by name: %+v %v", v, err)
|
||||||
|
}
|
||||||
|
if _, err := pickAgentView(views, "twin"); err == nil || !strings.Contains(err.Error(), "give the pid") {
|
||||||
|
t.Errorf("two sessions with one name: %v", err)
|
||||||
|
}
|
||||||
|
if _, err := pickAgentView(views, "999"); err == nil {
|
||||||
|
t.Error("a pid no agent has was shown")
|
||||||
|
}
|
||||||
|
if _, err := pickAgentView(views, "nobody"); err == nil {
|
||||||
|
t.Error("a name no session has was shown")
|
||||||
|
}
|
||||||
|
if err := cmdAgents([]string{"show"}); err == nil || !strings.Contains(err.Error(), "usage:") {
|
||||||
|
t.Errorf("show with no agent: %v", err)
|
||||||
|
}
|
||||||
|
if err := cmdAgents([]string{"show", "--json"}); err == nil || !strings.Contains(err.Error(), "usage:") {
|
||||||
|
t.Errorf("show --json with no agent: %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The detail view names the file the kernel says the agent runs, and keeps
|
||||||
|
// its command line (which can carry a key) out of the words.
|
||||||
|
func TestAgentsShowKeepsTheCommandLineOutOfTheWords(t *testing.T) {
|
||||||
|
v := agentView{agentObs: anObservedAgent("aider", "/usr/local/bin/aider --api-key sk-THEKEY", 4242)}
|
||||||
|
var b bytes.Buffer
|
||||||
|
printAgentDetail(&b, v, time.Now())
|
||||||
|
out := b.String()
|
||||||
|
if strings.Contains(out, "sk-THEKEY") {
|
||||||
|
t.Errorf("the words carry the command line:\n%s", out)
|
||||||
|
}
|
||||||
|
if !strings.Contains(out, "/usr/local/bin/aider") || !strings.Contains(out, "4242") {
|
||||||
|
t.Errorf("the words do not name the program and pid:\n%s", out)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The file an agent runs is a path whoever placed it chose, so a path built
|
||||||
|
// of terminal control sequences is shown as such, never sent to the terminal.
|
||||||
|
//
|
||||||
|
// MUTATION: row("program", v.Exe). RESULT: red, the escape reaches the words.
|
||||||
|
func TestAgentsShowNeverPrintsControlCharactersFromTheProgramPath(t *testing.T) {
|
||||||
|
v := agentView{agentObs: anObservedAgent("claude-code", "claude", 4242)}
|
||||||
|
v.Exe = "/tmp/\x1b]52;c;cHduZWQ=\x07/\x1b[2Jclaude"
|
||||||
|
var b bytes.Buffer
|
||||||
|
printAgentDetail(&b, v, time.Now())
|
||||||
|
out := b.String()
|
||||||
|
if strings.ContainsAny(out, "\x1b\x07") {
|
||||||
|
t.Errorf("the words carry the program path's control characters: %q", out)
|
||||||
|
}
|
||||||
|
if !strings.Contains(out, `\x1b]52`) {
|
||||||
|
t.Errorf("the program path is not shown as what it is: %q", out)
|
||||||
|
}
|
||||||
|
v.Exe = "/usr/local/bin/claude"
|
||||||
|
b.Reset()
|
||||||
|
printAgentDetail(&b, v, time.Now())
|
||||||
|
if !strings.Contains(b.String(), "program: /usr/local/bin/claude\n") {
|
||||||
|
t.Errorf("a plain path is not shown as is: %q", b.String())
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A read is built in the root daemon now, from code that ran only in a
|
||||||
|
// command's own process before (readOps slices names it finds on disk). One
|
||||||
|
// that panics is that read's failure, and the daemon serving every pairing
|
||||||
|
// stays up.
|
||||||
|
//
|
||||||
|
// MUTATION: drop the recover in runMachineRead. RESULT: red, the suite
|
||||||
|
// itself panics.
|
||||||
|
func TestAReadThatPanicsFailsAndLeavesTheDaemonUp(t *testing.T) {
|
||||||
|
uiTestConfigDir(t)
|
||||||
|
laneOwner(t, 1000)
|
||||||
|
for _, heavy := range []bool{false, true} {
|
||||||
|
machineReads["test-panics"] = machineRead{heavy: heavy, build: func(readOpts) (any, error) {
|
||||||
|
var s []string
|
||||||
|
return s[3], nil
|
||||||
|
}}
|
||||||
|
r := serveRead(1000, "sam", agentAskRequest{Op: "read", Read: "test-panics"})
|
||||||
|
if r.OK || !r.Failed || !strings.Contains(r.Why, "test-panics") {
|
||||||
|
t.Errorf("a read that panics (heavy %v): %+v", heavy, r)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
delete(machineReads, "test-panics")
|
||||||
|
if r := serveRead(1000, "sam", agentAskRequest{Op: "read", Read: "status"}); !r.OK {
|
||||||
|
t.Errorf("after a read panicked, status: %+v", r)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// doctor from an ordinary account beside a system service would, run
|
||||||
|
// directly, check that account's own empty bastion and report it as the
|
||||||
|
// machine's (not running, no owner, no factor). So it is a lane read, as
|
||||||
|
// status is: through ask.sock on Linux and macOS, the ask pipe on Windows.
|
||||||
|
//
|
||||||
|
// MUTATION: drop "doctor" from serviceLaneReads. RESULT: red on every system.
|
||||||
|
func TestDoctorBesideAWindowsServiceIsRefusedAsStatusIs(t *testing.T) {
|
||||||
|
if !serviceGuardedCommands["doctor"] || !serviceLaneReads["doctor"] {
|
||||||
|
t.Error("doctor is not both guarded and a lane read, so it would check an ordinary account's own bastion")
|
||||||
|
}
|
||||||
|
for _, goos := range []string{"linux", "darwin", "windows"} {
|
||||||
|
if err := serviceGuard(goos, "doctor", true, false); err != nil {
|
||||||
|
t.Errorf("%s: doctor beside the service is a lane read: %v", goos, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if err := serviceGuard("windows", "doctor", true, true); err != nil {
|
||||||
|
t.Errorf("the administrator's doctor beside a Windows service: %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// doctorWorld is a machine doctor reads from fixtures only.
|
||||||
|
func doctorWorld(t *testing.T, system bool, latest string) {
|
||||||
|
t.Helper()
|
||||||
|
uiTestConfigDir(t)
|
||||||
|
prevSys, prevLatest, prevSandbox := systemInstalled, doctorLatest, doctorSandbox
|
||||||
|
t.Cleanup(func() { systemInstalled, doctorLatest, doctorSandbox = prevSys, prevLatest, prevSandbox })
|
||||||
|
systemInstalled = func() bool { return system }
|
||||||
|
doctorLatest = func() string { return latest }
|
||||||
|
doctorSandbox = func() (bool, string) { return true, "" }
|
||||||
|
}
|
||||||
|
|
||||||
|
func doctorCheckNamed(d doctorRead, name string) (doctorCheck, bool) {
|
||||||
|
for _, c := range d.Checks {
|
||||||
|
if c.Name == name {
|
||||||
|
return c, true
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return doctorCheck{}, false
|
||||||
|
}
|
||||||
|
|
||||||
|
// With no second factor, doctor says what cannot be approved and the command
|
||||||
|
// that sets one up; with one, it is not a problem.
|
||||||
|
func TestDoctorFindsAMissingSecondFactorAndNamesTheFix(t *testing.T) {
|
||||||
|
doctorWorld(t, false, "")
|
||||||
|
d, err := readDoctor(readOpts{})
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
c, ok := doctorCheckNamed(d, "second factor")
|
||||||
|
if !ok || c.OK || !strings.Contains(c.Fix, "stepup-enroll --machine") || strings.Contains(c.Fix, "sudo") {
|
||||||
|
t.Errorf("no factor, a per-account install: %+v", c)
|
||||||
|
}
|
||||||
|
systemInstalled = func() bool { return true }
|
||||||
|
d, _ = readDoctor(readOpts{})
|
||||||
|
if c, _ := doctorCheckNamed(d, "second factor"); !strings.HasPrefix(c.Fix, "sudo -H privatae-bastion stepup-enroll") &&
|
||||||
|
!strings.Contains(c.Fix, "Administrator") {
|
||||||
|
t.Errorf("no factor, installed for the machine: %+v", c)
|
||||||
|
}
|
||||||
|
dir, err := machineFactorDir()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
enrolFactorAt(t, dir, machineTestSecret)
|
||||||
|
d, _ = readDoctor(readOpts{})
|
||||||
|
if c, _ := doctorCheckNamed(d, "second factor"); !c.OK {
|
||||||
|
t.Errorf("with a factor enrolled: %+v", c)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A newer published version is a problem with the installer as its fix; a
|
||||||
|
// latest version nobody could read is not one.
|
||||||
|
func TestDoctorSaysANewerVersionAndNeverAlarmsOffline(t *testing.T) {
|
||||||
|
doctorWorld(t, false, "999.0.0")
|
||||||
|
prev := clientVersion
|
||||||
|
t.Cleanup(func() { clientVersion = prev })
|
||||||
|
clientVersion = "1.0.0"
|
||||||
|
d, _ := readDoctor(readOpts{})
|
||||||
|
c, _ := doctorCheckNamed(d, "version")
|
||||||
|
if c.OK || !strings.Contains(c.Problem, "999.0.0") || !strings.Contains(c.Fix, "privatae.ai/bastion/install") {
|
||||||
|
t.Errorf("a newer version: %+v", c)
|
||||||
|
}
|
||||||
|
doctorLatest = func() string { return "" }
|
||||||
|
d, _ = readDoctor(readOpts{})
|
||||||
|
if c, _ := doctorCheckNamed(d, "version"); !c.OK {
|
||||||
|
t.Errorf("no answer from privatae.ai reads as a problem: %+v", c)
|
||||||
|
}
|
||||||
|
doctorLatest = func() string { return "1.0.0" }
|
||||||
|
d, _ = readDoctor(readOpts{})
|
||||||
|
if c, _ := doctorCheckNamed(d, "version"); !c.OK {
|
||||||
|
t.Errorf("the latest version reads as a problem: %+v", c)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Installed for the whole machine with no owner recorded, doctor says what
|
||||||
|
// that stops and how to record one; recorded, it names the account.
|
||||||
|
func TestDoctorFindsNoOwnerAccountOnAMachineInstall(t *testing.T) {
|
||||||
|
doctorWorld(t, true, "")
|
||||||
|
d, _ := readDoctor(readOpts{})
|
||||||
|
c, ok := doctorCheckNamed(d, "owner")
|
||||||
|
if !ok || c.OK || !strings.Contains(c.Fix, "approvals-owner") {
|
||||||
|
t.Errorf("no owner: %+v", c)
|
||||||
|
}
|
||||||
|
laneOwner(t, 1000)
|
||||||
|
d, _ = readDoctor(readOpts{})
|
||||||
|
if c, _ := doctorCheckNamed(d, "owner"); !c.OK || !strings.Contains(c.Detail, "sam") {
|
||||||
|
t.Errorf("an owner recorded: %+v", c)
|
||||||
|
}
|
||||||
|
systemInstalled = func() bool { return false }
|
||||||
|
d, _ = readDoctor(readOpts{})
|
||||||
|
if _, ok := doctorCheckNamed(d, "owner"); ok {
|
||||||
|
t.Error("a per-account install was checked for a machine owner")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// An account whose agents' asks are held is named, with the command that
|
||||||
|
// lifts the hold.
|
||||||
|
func TestDoctorNamesAHeldAsker(t *testing.T) {
|
||||||
|
doctorWorld(t, false, "")
|
||||||
|
dir, err := machineFactorDir()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
enrolFactorAt(t, dir, machineTestSecret)
|
||||||
|
now := time.Now()
|
||||||
|
for i := 0; i < quarantineStrikes; i++ {
|
||||||
|
askStrike(dir, "lee", now)
|
||||||
|
}
|
||||||
|
d, _ := readDoctor(readOpts{})
|
||||||
|
c, ok := doctorCheckNamed(d, "held asker")
|
||||||
|
if !ok || c.OK || !strings.Contains(c.Problem, "lee") || !strings.Contains(c.Fix, "quarantine clear --asker lee") {
|
||||||
|
t.Errorf("a held asker: %+v (checks %+v)", c, d.Checks)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// doctor exits 1 when it finds a problem, so a script can branch, and the
|
||||||
|
// lane not answering becomes the check rather than an error.
|
||||||
|
func TestDoctorExitsOneOnAProblemAndSaysTheLane(t *testing.T) {
|
||||||
|
doctorWorld(t, false, "")
|
||||||
|
err := cmdDoctor(nil)
|
||||||
|
var q quietExit
|
||||||
|
if !errors.As(err, &q) || q.code != 1 {
|
||||||
|
t.Errorf("no factor: want exit 1, got %v", err)
|
||||||
|
}
|
||||||
|
if err := cmdDoctor([]string{"--jsno"}); err == nil || !strings.Contains(err.Error(), "usage:") {
|
||||||
|
t.Errorf("a stray flag: %v", err)
|
||||||
|
}
|
||||||
|
if c := laneCheck(&laneError{down: true, why: "nothing answers"}); c.OK || c.Name != "running" || c.Fix == "" {
|
||||||
|
t.Errorf("the lane down: %+v", c)
|
||||||
|
}
|
||||||
|
if c := laneCheck(&laneError{why: "this machine's bastion answers reads only for its owner's account (sam), not lee"}); c.OK ||
|
||||||
|
c.Name != "reads" || !strings.Contains(c.Fix, "doctor") {
|
||||||
|
t.Errorf("the lane refusing: %+v", c)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestTheSliceThreeReadCommandsRefuseStrayFlags(t *testing.T) {
|
||||||
|
for name, cmd := range map[string]func([]string) error{
|
||||||
|
"switch --list": func(a []string) error { return cmdSwitch(append([]string{"--list"}, a...)) },
|
||||||
|
"backup key show": func(a []string) error {
|
||||||
|
return cmdBackup(append([]string{"key", "show"}, a...))
|
||||||
|
},
|
||||||
|
"backup requests": func(a []string) error { return cmdBackup(append([]string{"requests"}, a...)) },
|
||||||
|
"backup shares": func(a []string) error {
|
||||||
|
return cmdBackup(append([]string{"shares", "--with", "h"}, a...))
|
||||||
|
},
|
||||||
|
} {
|
||||||
|
if err := cmd([]string{"--jsno"}); err == nil || !strings.Contains(err.Error(), "usage") {
|
||||||
|
t.Errorf("%s --jsno: %v", name, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Not paired, the command that pairs is said the way it is typed here:
|
||||||
|
// with sudo -H where the bastion is installed for the whole machine.
|
||||||
|
func TestNotPairedSaysThePairCommandForThisInstall(t *testing.T) {
|
||||||
|
doctorWorld(t, true, "")
|
||||||
|
_, err := stepupPairing("")
|
||||||
|
if err == nil || !strings.Contains(err.Error(), asAdmin("pair <token>")) {
|
||||||
|
t.Errorf("not paired, a machine install: %v", err)
|
||||||
|
}
|
||||||
|
if runtimeIsUnix() && !strings.Contains(err.Error(), "sudo -H privatae-bastion pair") {
|
||||||
|
t.Errorf("not paired, a machine install, says no sudo: %v", err)
|
||||||
|
}
|
||||||
|
systemInstalled = func() bool { return false }
|
||||||
|
if _, err := stepupPairing(""); err == nil || strings.Contains(err.Error(), "sudo") {
|
||||||
|
t.Errorf("not paired, a per-account install: %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func runtimeIsUnix() bool { return os.PathSeparator == '/' }
|
||||||
|
|
||||||
|
// doctor asks privatae.ai at update.go's rate: once, then not again within
|
||||||
|
// updateCheckEvery, whether that ask was answered or not; the last answer
|
||||||
|
// stands meanwhile. MUTATION: drop the doctorAskedLoad shortcut. RESULT: red,
|
||||||
|
// every run fetches.
|
||||||
|
func TestDoctorAsksPrivataeAtTheUpdateCheckRate(t *testing.T) {
|
||||||
|
uiTestConfigDir(t)
|
||||||
|
prevFetch, prevNow := doctorFetch, doctorNow
|
||||||
|
t.Cleanup(func() { doctorFetch, doctorNow = prevFetch, prevNow })
|
||||||
|
forget := func() { latestMu.Lock(); latestPublished = ""; latestMu.Unlock() }
|
||||||
|
t.Cleanup(forget)
|
||||||
|
now := time.Date(2026, 11, 2, 0, 0, 0, 0, time.UTC)
|
||||||
|
doctorNow = func() time.Time { return now }
|
||||||
|
fetches, answer := 0, "0.61.0"
|
||||||
|
doctorFetch = func() (string, error) {
|
||||||
|
fetches++
|
||||||
|
if answer == "" {
|
||||||
|
return "", errors.New("no route")
|
||||||
|
}
|
||||||
|
return answer, nil
|
||||||
|
}
|
||||||
|
forget()
|
||||||
|
if v := doctorLatest(); v != "0.61.0" || fetches != 1 {
|
||||||
|
t.Fatalf("first run: %q after %d fetches", v, fetches)
|
||||||
|
}
|
||||||
|
forget() // a new process: nothing in memory
|
||||||
|
now = now.Add(updateCheckEvery - time.Minute)
|
||||||
|
if v := doctorLatest(); v != "0.61.0" || fetches != 1 {
|
||||||
|
t.Errorf("inside the window: %q after %d fetches", v, fetches)
|
||||||
|
}
|
||||||
|
forget()
|
||||||
|
now = now.Add(2 * time.Minute)
|
||||||
|
answer = ""
|
||||||
|
if v := doctorLatest(); v != "0.61.0" || fetches != 2 {
|
||||||
|
t.Errorf("past the window, no answer: %q after %d fetches (the last answer should stand)", v, fetches)
|
||||||
|
}
|
||||||
|
forget()
|
||||||
|
now = now.Add(time.Hour)
|
||||||
|
if v := doctorLatest(); v != "0.61.0" || fetches != 2 {
|
||||||
|
t.Errorf("a failed ask is not repeated inside the window: %q after %d fetches", v, fetches)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A folder the agent chose, holding an escape sequence, is printed quoted in
|
||||||
|
// agents and agents show, never sent to the terminal raw.
|
||||||
|
func TestAnAgentsFolderNeverReachesTheTerminalRaw(t *testing.T) {
|
||||||
|
v := agentView{agentObs: anObservedAgent("aider", "/usr/local/bin/aider", 4242),
|
||||||
|
Folder: "/home/u/\x1b]52;c;cGF3bmVk\x07work", GitBranch: "main"}
|
||||||
|
var b bytes.Buffer
|
||||||
|
printAgents(&b, []agentView{v}, time.Now())
|
||||||
|
printAgentDetail(&b, v, time.Now())
|
||||||
|
if strings.ContainsAny(b.String(), "\x1b\x07") {
|
||||||
|
t.Errorf("a control character reached the output: %q", b.String())
|
||||||
|
}
|
||||||
|
if !strings.Contains(b.String(), `\x1b]52`) {
|
||||||
|
t.Errorf("the folder is not shown at all: %q", b.String())
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The slice-3 reads from an ordinary account beside the service ask the
|
||||||
|
// machine's bastion over its lane on every system (the ask pipe on Windows),
|
||||||
|
// so the guard lets them by. The rest of backup is not guarded.
|
||||||
|
func TestTheSliceThreeReadsAreGuardedBesideAWindowsService(t *testing.T) {
|
||||||
|
for _, line := range [][]string{
|
||||||
|
{"privatae-bastion", "ops", "--json"},
|
||||||
|
{"privatae-bastion", "device-approvals"},
|
||||||
|
{"privatae-bastion", "backup", "requests"},
|
||||||
|
{"privatae-bastion", "backup", "shares", "--with", "h"},
|
||||||
|
{"privatae-bastion", "backup", "key", "show"},
|
||||||
|
} {
|
||||||
|
key := serviceGuardKey(line[1], line)
|
||||||
|
if !serviceGuardedCommands[key] || !serviceLaneReads[key] {
|
||||||
|
t.Errorf("%v is not both guarded and a lane read", line[1:])
|
||||||
|
}
|
||||||
|
for _, goos := range []string{"linux", "darwin", "windows"} {
|
||||||
|
if err := serviceGuard(goos, key, true, false); err != nil {
|
||||||
|
t.Errorf("%s: %v was refused before it could ask the machine's bastion: %v", goos, line[1:], err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
for _, line := range [][]string{
|
||||||
|
{"privatae-bastion", "backup", "reseal", "--sidecar", "f", "--to", "k"},
|
||||||
|
{"privatae-bastion", "backup", "restore-plan", "--dir", "d"},
|
||||||
|
} {
|
||||||
|
if err := serviceGuard("windows", serviceGuardKey(line[1], line), true, false); err != nil {
|
||||||
|
t.Errorf("windows: %v works offline and was refused: %v", line[1:], err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -134,6 +134,26 @@ func TestEveryReadPrintsTheSameAfterTheLane(t *testing.T) {
|
|||||||
func(w *bytes.Buffer, v any) { _ = printDelta(w, v.(deltaReport)) })
|
func(w *bytes.Buffer, v any) { _ = printDelta(w, v.(deltaReport)) })
|
||||||
rep := buildReport(now, now.Add(-7*24*time.Hour))
|
rep := buildReport(now, now.Add(-7*24*time.Hour))
|
||||||
add("report", rep, func(w *bytes.Buffer, v any) { renderReportMarkdown(w, v.(machineReport)) })
|
add("report", rep, func(w *bytes.Buffer, v any) { renderReportMarkdown(w, v.(machineReport)) })
|
||||||
|
add("switches", switchesRead{Switches: []switchRow{{Host: "home", Family: "ops", Off: true, Since: "2026-11-01T00:00:00Z"},
|
||||||
|
{Host: "home", Family: "observe"}}, Unreadable: "the list cannot be read"},
|
||||||
|
func(w *bytes.Buffer, v any) { printSwitches(w, v.(switchesRead)) })
|
||||||
|
add("ops", opsRead{Host: "home", SandboxUnavailable: "the kernel offers no overlay filesystem",
|
||||||
|
Ops: []opRow{{ID: "0123456789ab", Name: "restart-web", Version: "1", Privilege: "root", Summary: "restart nginx"}, {ID: "ba9876543210", NotVerified: "bad signature"}},
|
||||||
|
Grants: []opGrantRow{{ID: "abcd1234", Op: "restart-web", Version: "1", RunsLeft: 2, Until: "2026-11-02", Within: "nginx only"}}},
|
||||||
|
func(w *bytes.Buffer, v any) { printOps(w, v.(opsRead)) })
|
||||||
|
add("device-approvals", deviceApprovalsRead{Asks: []deviceAsk{{ID: "0123456789abcdef", Server: "web-1", At: "2026-11-01", Words: "Restart nginx."}}},
|
||||||
|
func(w *bytes.Buffer, v any) { printDeviceApprovals(w, v.(deviceApprovalsRead), true) })
|
||||||
|
add("backup-keys", backupKeysRead{Keys: []*backupKeyFile{{Recipient: "age1pub", PubB64: "cHVi", Fingerprint: "fp1",
|
||||||
|
CreatedAt: "2026-10-01", Path: "/x/key"}, {Fingerprint: "fp0"}}, Current: "fp1"},
|
||||||
|
func(w *bytes.Buffer, v any) { printBackupKeys(w, v.(backupKeysRead)) })
|
||||||
|
add("backup-requests", backupRequestsRead{Host: "home", SetAside: []string{"/x/reseal.json.aside-1"},
|
||||||
|
Requests: []backupRequestView{{ID: "r1", State: "pending", Words: "r1 [pending]\n Sent by the pairing home."}}},
|
||||||
|
func(w *bytes.Buffer, v any) { printBackupRequests(w, v.(backupRequestsRead)) })
|
||||||
|
add("backup-shares", backupSharesRead{With: "new-home", Shares: []backupShare{{Slug: "old", Dir: "/srv/backups/old", Added: "2026-10-01"}}},
|
||||||
|
func(w *bytes.Buffer, v any) { printBackupShares(w, v.(backupSharesRead)) })
|
||||||
|
add("doctor", doctorRead{Version: "9.9.9", Checks: []doctorCheck{{Name: "running", OK: true, Detail: "Running on its own."},
|
||||||
|
{Name: "second factor", Problem: "No second factor.", Fix: "privatae-bastion stepup-enroll --machine"}}},
|
||||||
|
func(w *bytes.Buffer, v any) { printDoctor(w, v.(doctorRead)) })
|
||||||
|
|
||||||
for name := range machineReads {
|
for name := range machineReads {
|
||||||
if name == "baseline" {
|
if name == "baseline" {
|
||||||
@@ -223,6 +243,27 @@ func zeroLike(v any) decoded {
|
|||||||
case machineReport:
|
case machineReport:
|
||||||
var x machineReport
|
var x machineReport
|
||||||
return decoded{&x, func() any { return x }}
|
return decoded{&x, func() any { return x }}
|
||||||
|
case switchesRead:
|
||||||
|
var x switchesRead
|
||||||
|
return decoded{&x, func() any { return x }}
|
||||||
|
case opsRead:
|
||||||
|
var x opsRead
|
||||||
|
return decoded{&x, func() any { return x }}
|
||||||
|
case deviceApprovalsRead:
|
||||||
|
var x deviceApprovalsRead
|
||||||
|
return decoded{&x, func() any { return x }}
|
||||||
|
case backupKeysRead:
|
||||||
|
var x backupKeysRead
|
||||||
|
return decoded{&x, func() any { return x }}
|
||||||
|
case backupRequestsRead:
|
||||||
|
var x backupRequestsRead
|
||||||
|
return decoded{&x, func() any { return x }}
|
||||||
|
case backupSharesRead:
|
||||||
|
var x backupSharesRead
|
||||||
|
return decoded{&x, func() any { return x }}
|
||||||
|
case doctorRead:
|
||||||
|
var x doctorRead
|
||||||
|
return decoded{&x, func() any { return x }}
|
||||||
}
|
}
|
||||||
panic("no case")
|
panic("no case")
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -6,6 +6,7 @@ import (
|
|||||||
"fmt"
|
"fmt"
|
||||||
"os"
|
"os"
|
||||||
"os/exec"
|
"os/exec"
|
||||||
|
"strconv"
|
||||||
|
|
||||||
"golang.org/x/sys/windows"
|
"golang.org/x/sys/windows"
|
||||||
)
|
)
|
||||||
@@ -53,6 +54,10 @@ func relaunchAfterUpdate() {
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
cmd := exec.Command(self, os.Args[1:]...)
|
cmd := exec.Command(self, os.Args[1:]...)
|
||||||
|
// The new bastion waits for this one to exit before it takes the run
|
||||||
|
// lock (runholder.go takeRunLock); without this it could find the lock
|
||||||
|
// still held, refuse as a second copy, and leave the machine with none.
|
||||||
|
cmd.Env = append(os.Environ(), relaunchOfEnv+"="+strconv.Itoa(os.Getpid()))
|
||||||
cmd.SysProcAttr = &windows.SysProcAttr{
|
cmd.SysProcAttr = &windows.SysProcAttr{
|
||||||
CreationFlags: windows.DETACHED_PROCESS | windows.CREATE_NEW_PROCESS_GROUP,
|
CreationFlags: windows.DETACHED_PROCESS | windows.CREATE_NEW_PROCESS_GROUP,
|
||||||
}
|
}
|
||||||
|
|||||||
+275
-46
@@ -153,6 +153,10 @@ func cmdRun() error {
|
|||||||
go superviseLoop(ctx)
|
go superviseLoop(ctx)
|
||||||
// The machine owner's approved stops (stop_local.go), Host or no Host.
|
// The machine owner's approved stops (stop_local.go), Host or no Host.
|
||||||
go localStopLoop(ctx)
|
go localStopLoop(ctx)
|
||||||
|
// The door's own firewall rules (doorfw.go): one left by a `pair --open`
|
||||||
|
// that was killed, or a pairing that went while nothing ran, is removed
|
||||||
|
// here once nothing uses its port.
|
||||||
|
go doorFirewallSweep(ctx)
|
||||||
// The local UI (ui.go): ONE per machine, not one per pairing, because it
|
// The local UI (ui.go): ONE per machine, not one per pairing, because it
|
||||||
// shows the whole box. Started last so it renders a daemon that is already
|
// shows the whole box. Started last so it renders a daemon that is already
|
||||||
// up, and non-fatal by construction — a machine that cannot bind the UI port
|
// up, and non-fatal by construction — a machine that cannot bind the UI port
|
||||||
@@ -168,13 +172,15 @@ func cmdRun() error {
|
|||||||
select {
|
select {
|
||||||
case <-sig:
|
case <-sig:
|
||||||
fmt.Println("\nshutting down")
|
fmt.Println("\nshutting down")
|
||||||
|
tellReplacedAnchorsBeforeStop()
|
||||||
cancel() // closes every pairing's server + WG device via runPairing's exits
|
cancel() // closes every pairing's server + WG device via runPairing's exits
|
||||||
return nil
|
return nil
|
||||||
case <-shutdownCh:
|
case <-shutdownCh:
|
||||||
// "Stop the bastion" in the tray menu. Deliberately the SAME path as a
|
// "Stop the bastion" in the tray menu. Deliberately the SAME path as a
|
||||||
// signal rather than an os.Exit: a machine that stops serving must tear
|
// signal rather than an os.Exit: a machine that stops serving must tear
|
||||||
// its tunnels down, not vanish and leave the host waiting for a beat.
|
// its tunnels down, not vanish and leave the host waiting for a beat.
|
||||||
fmt.Println("\nstopping — asked from the tray")
|
fmt.Println("\nstopping — " + shutdownWhy)
|
||||||
|
tellReplacedAnchorsBeforeStop()
|
||||||
cancel()
|
cancel()
|
||||||
return nil
|
return nil
|
||||||
case err := <-errc:
|
case err := <-errc:
|
||||||
@@ -245,10 +251,13 @@ func startPairing(cfg *Config) bool {
|
|||||||
pctx, pcancel := context.WithCancel(supervisor.ctx)
|
pctx, pcancel := context.WithCancel(supervisor.ctx)
|
||||||
run := &pairingRun{cancel: pcancel, done: make(chan struct{}), cfg: cfg}
|
run := &pairingRun{cancel: pcancel, done: make(chan struct{}), cfg: cfg}
|
||||||
supervisor.runs[cfg.HostName] = run
|
supervisor.runs[cfg.HostName] = run
|
||||||
errc := supervisor.errc
|
|
||||||
go func() {
|
go func() {
|
||||||
defer close(run.done)
|
defer close(run.done)
|
||||||
|
started := time.Now()
|
||||||
|
// A run that stays up has recovered from any failure before it.
|
||||||
|
up := time.AfterFunc(retryResetAfter, func() { pairingRecovered(cfg.HostName) })
|
||||||
err := runPairing(pctx, cfg)
|
err := runPairing(pctx, cfg)
|
||||||
|
up.Stop()
|
||||||
// Retired BEFORE it leaves the registry: leaving is what lets the
|
// Retired BEFORE it leaves the registry: leaving is what lets the
|
||||||
// pairing start again, and this run's heartbeat may still be running.
|
// pairing start again, and this run's heartbeat may still be running.
|
||||||
retireRun(cfg)
|
retireRun(cfg)
|
||||||
@@ -257,12 +266,15 @@ func startPairing(cfg *Config) bool {
|
|||||||
delete(supervisor.runs, cfg.HostName)
|
delete(supervisor.runs, cfg.HostName)
|
||||||
}
|
}
|
||||||
supervisor.Unlock()
|
supervisor.Unlock()
|
||||||
// nil is a clean exit (ctx cancelled: shutdown or a revoke) and must not
|
// nil is a clean exit (ctx cancelled: shutdown or a revoke). Anything
|
||||||
// take the process down. Anything else is fatal for the whole daemon, as
|
// else stops THIS pairing only: it is reported, and superviseOnce
|
||||||
// before: the supervisor restarts all lanes together, never half-homed.
|
// starts it again after a pause (pairing_retry.go). It used to stop the
|
||||||
if err != nil && errc != nil {
|
// whole daemon, and every other Host with it.
|
||||||
errc <- fmt.Errorf("[%s] %w", cfg.HostName, err)
|
if err != nil && pctx.Err() == nil {
|
||||||
|
pairingFailed(cfg.HostName, err, time.Since(started))
|
||||||
|
return
|
||||||
}
|
}
|
||||||
|
pairingRecovered(cfg.HostName)
|
||||||
}()
|
}()
|
||||||
return true
|
return true
|
||||||
}
|
}
|
||||||
@@ -311,6 +323,9 @@ func superviseOnce() {
|
|||||||
c, ok := onDisk[h]
|
c, ok := onDisk[h]
|
||||||
switch {
|
switch {
|
||||||
case !ok || !c.active():
|
case !ok || !c.active():
|
||||||
|
if ok {
|
||||||
|
tellReplacedAnchor(h)
|
||||||
|
}
|
||||||
fmt.Printf("[%s] no longer active on disk — stopping its tunnel and lanes\n", h)
|
fmt.Printf("[%s] no longer active on disk — stopping its tunnel and lanes\n", h)
|
||||||
stopPairing(h)
|
stopPairing(h)
|
||||||
case r.cfg != nil && c.WGPrivateKey != r.cfg.WGPrivateKey:
|
case r.cfg != nil && c.WGPrivateKey != r.cfg.WGPrivateKey:
|
||||||
@@ -324,12 +339,108 @@ func superviseOnce() {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
for _, c := range cfgs {
|
for _, c := range cfgs {
|
||||||
if c.active() {
|
if c.active() && pairingRetryDue(c.HostName) {
|
||||||
startPairing(c) // no-op when already running
|
startPairing(c) // no-op when already running
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// tellReplacedAnchor: the anchor a Host the rules put first replaced
|
||||||
|
// (anchor_local.go) is told so on one last beat, its enforcing report saying
|
||||||
|
// who is in charge now and that it waits to be admitted, before its lanes stop.
|
||||||
|
func tellReplacedAnchor(h string) {
|
||||||
|
if anchorReplacedNote(h) != nil && lastBeat(h) {
|
||||||
|
fmt.Printf("[%s] no longer in charge of this machine — told it on a last heartbeat\n", h)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// tellReplacedAnchorsBeforeStop is tellReplacedAnchor for every running
|
||||||
|
// pairing the files on disk no longer serve, when the daemon stops: an
|
||||||
|
// installer that pairs a Host on this machine and restarts the service at
|
||||||
|
// once stops the replaced anchor before superviseOnce would have seen it.
|
||||||
|
func tellReplacedAnchorsBeforeStop() {
|
||||||
|
cfgs, err := loadPairings()
|
||||||
|
if err != nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
supervisor.Lock()
|
||||||
|
var running []string
|
||||||
|
for h := range supervisor.runs {
|
||||||
|
running = append(running, h)
|
||||||
|
}
|
||||||
|
supervisor.Unlock()
|
||||||
|
for _, h := range running {
|
||||||
|
if c := pairingFor(cfgs, h); c != nil && c.HostName == h && !c.active() {
|
||||||
|
tellReplacedAnchor(h)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// runBeats are the running pairings' beats, for one last beat before a
|
||||||
|
// pairing stops (superviseOnce).
|
||||||
|
var runBeats = struct {
|
||||||
|
sync.Mutex
|
||||||
|
m map[string]*runBeat
|
||||||
|
}{m: map[string]*runBeat{}}
|
||||||
|
|
||||||
|
// runBeat is one run's beat, serialised. lastBeat beats from superviseOnce's
|
||||||
|
// goroutine while the run's own loop (runBeatLoop) may be beating or failing
|
||||||
|
// over, and neither is safe to run beside the other: maybeRotateEndpoint and
|
||||||
|
// maybeFailover both write cfg.Endpoints and the WG device. Before lastBeat
|
||||||
|
// every beat of a run came from its one loop, so nothing locked them.
|
||||||
|
type runBeat struct {
|
||||||
|
mu sync.Mutex
|
||||||
|
beat func()
|
||||||
|
}
|
||||||
|
|
||||||
|
// do runs f with no beat of this run beside it.
|
||||||
|
func (r *runBeat) do(f func()) {
|
||||||
|
r.mu.Lock()
|
||||||
|
defer r.mu.Unlock()
|
||||||
|
f()
|
||||||
|
}
|
||||||
|
|
||||||
|
// run is one beat.
|
||||||
|
func (r *runBeat) run() { r.do(r.beat) }
|
||||||
|
|
||||||
|
// registerRunBeat records host's beat while its run lasts. The run beats
|
||||||
|
// through the returned runBeat from then on; the func takes it out.
|
||||||
|
func registerRunBeat(host string, beat func()) (*runBeat, func()) {
|
||||||
|
mine := &runBeat{beat: beat}
|
||||||
|
runBeats.Lock()
|
||||||
|
runBeats.m[host] = mine
|
||||||
|
runBeats.Unlock()
|
||||||
|
return mine, func() {
|
||||||
|
runBeats.Lock()
|
||||||
|
if runBeats.m[host] == mine { // a later run of host keeps its own
|
||||||
|
delete(runBeats.m, host)
|
||||||
|
}
|
||||||
|
runBeats.Unlock()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// lastBeatWait bounds the last beat: a Host that does not answer does not hold
|
||||||
|
// the stop.
|
||||||
|
var lastBeatWait = 10 * time.Second
|
||||||
|
|
||||||
|
// lastBeat beats host once more, now, and waits for it (bounded). False when
|
||||||
|
// host has no running beat.
|
||||||
|
func lastBeat(host string) bool {
|
||||||
|
runBeats.Lock()
|
||||||
|
b := runBeats.m[host]
|
||||||
|
runBeats.Unlock()
|
||||||
|
if b == nil {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
done := make(chan struct{})
|
||||||
|
go func() { defer close(done); b.run() }()
|
||||||
|
select {
|
||||||
|
case <-done:
|
||||||
|
case <-time.After(lastBeatWait):
|
||||||
|
}
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
|
||||||
// stopPairing cancels one running pairing and waits (bounded) for its tunnel,
|
// stopPairing cancels one running pairing and waits (bounded) for its tunnel,
|
||||||
// listener and lanes to exit. Returns whether anything was running.
|
// listener and lanes to exit. Returns whether anything was running.
|
||||||
func stopPairing(host string) bool {
|
func stopPairing(host string) bool {
|
||||||
@@ -606,7 +717,13 @@ func runPairing(ctx context.Context, cfg *Config) error {
|
|||||||
// (posture). The device fingerprint is NOT sent here: it is bound at
|
// (posture). The device fingerprint is NOT sent here: it is bound at
|
||||||
// pairing from the operator CSR; the reverse lanes are admitted on the bearer's
|
// pairing from the operator CSR; the reverse lanes are admitted on the bearer's
|
||||||
// binding to that cert, which the host enforces. Authed by the bearer.
|
// binding to that cert, which the host enforces. Authed by the bearer.
|
||||||
|
// Each beat's request carries the run's context, and a stopped run waits
|
||||||
|
// for the heartbeat before it returns, so no beat of this run records a
|
||||||
|
// time, reconciles grants into its folder or acts on a directive after
|
||||||
|
// the pairing has stopped (an unpair or revoke removes those next).
|
||||||
|
beatDone := make(chan struct{})
|
||||||
go func() {
|
go func() {
|
||||||
|
defer close(beatDone)
|
||||||
hbURL := fmt.Sprintf("https://%s:8443/api/network/bastions/heartbeat", cfg.HostName)
|
hbURL := fmt.Sprintf("https://%s:8443/api/network/bastions/heartbeat", cfg.HostName)
|
||||||
hostname, _ := os.Hostname()
|
hostname, _ := os.Hostname()
|
||||||
wgPub := ""
|
wgPub := ""
|
||||||
@@ -616,8 +733,11 @@ func runPairing(ctx context.Context, cfg *Config) error {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
beat := func() {
|
beat := func() {
|
||||||
|
if ctx.Err() != nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
payload := heartbeatPayload(cfg, dev, hostname, wgPub)
|
payload := heartbeatPayload(cfg, dev, hostname, wgPub)
|
||||||
req, err := http.NewRequest(http.MethodPost, hbURL, strings.NewReader(payload))
|
req, err := http.NewRequestWithContext(ctx, http.MethodPost, hbURL, strings.NewReader(payload))
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
@@ -629,11 +749,16 @@ func runPairing(ctx context.Context, cfg *Config) error {
|
|||||||
if !ok {
|
if !ok {
|
||||||
return // a reply past its bound is no answer (lane_bounds.go)
|
return // a reply past its bound is no answer (lane_bounds.go)
|
||||||
}
|
}
|
||||||
|
if ctx.Err() != nil {
|
||||||
|
return // the pairing stopped while this beat was out
|
||||||
|
}
|
||||||
if resp.StatusCode < 300 {
|
if resp.StatusCode < 300 {
|
||||||
// last_ok per pairing (anchor.go): the anchor rotation's
|
// last_ok per pairing (anchor.go): the anchor rotation's
|
||||||
// silence path reads this — 14 days with no 2xx from the
|
// silence path reads this — 14 days with no 2xx from the
|
||||||
// anchor host lets root re-anchor without its consent.
|
// anchor host lets root re-anchor without its consent.
|
||||||
recordPairingOK(cfg.HostName)
|
recordPairingOK(cfg.HostName)
|
||||||
|
// A Host that holds this machine says so; its lanes wait (lanehold.go).
|
||||||
|
laneHoldFor(cfg.HostName).fromBeat(cfg.HostName, beatSaysQuarantined(body))
|
||||||
}
|
}
|
||||||
// Box-wide directives (update, contain, mirror) are anchor-only
|
// Box-wide directives (update, contain, mirror) are anchor-only
|
||||||
// on an anchored box — each takes this pairing's identity and
|
// on an anchored box — each takes this pairing's identity and
|
||||||
@@ -673,13 +798,15 @@ func runPairing(ctx context.Context, cfg *Config) error {
|
|||||||
// box costs 2.9 s because it hashes every executable once, and no beat
|
// box costs 2.9 s because it hashes every executable once, and no beat
|
||||||
// may ever wait on that.
|
// may ever wait on that.
|
||||||
go runDeltaRefresh(ctx)
|
go runDeltaRefresh(ctx)
|
||||||
beat() // first beat: flip online + bind fp now, don't wait a full interval
|
rb, unregisterBeat := registerRunBeat(cfg.HostName, beat)
|
||||||
|
defer unregisterBeat()
|
||||||
|
rb.run() // first beat: flip online + bind fp now, don't wait a full interval
|
||||||
// Every 60 s, and at once after a pairing on this box changes state
|
// Every 60 s, and at once after a pairing on this box changes state
|
||||||
// (beatnow.go), so this Host learns of it without waiting for the tick.
|
// (beatnow.go), so this Host learns of it without waiting for the tick.
|
||||||
// Path failover BEFORE a ticked beat: if the current relay entry has gone
|
// Path failover BEFORE a ticked beat: if the current relay entry has gone
|
||||||
// dead (no handshake for RejectAfterTime) the beat could not reach the
|
// dead (no handshake for RejectAfterTime) the beat could not reach the
|
||||||
// host anyway; move to the next candidate first, no platform round trip.
|
// host anyway; move to the next candidate first, no platform round trip.
|
||||||
runBeatLoop(ctx, 60*time.Second, func() { maybeFailover(cfg, dev, startedAt) }, beat)
|
runBeatLoop(ctx, 60*time.Second, func() { rb.do(func() { maybeFailover(cfg, dev, startedAt) }) }, rb.run)
|
||||||
}()
|
}()
|
||||||
|
|
||||||
srv := &http.Server{Addr: cfg.ListenAddr, Handler: mux}
|
srv := &http.Server{Addr: cfg.ListenAddr, Handler: mux}
|
||||||
@@ -694,6 +821,7 @@ func runPairing(ctx context.Context, cfg *Config) error {
|
|||||||
select {
|
select {
|
||||||
case <-ctx.Done():
|
case <-ctx.Done():
|
||||||
_ = srv.Close()
|
_ = srv.Close()
|
||||||
|
<-beatDone
|
||||||
return nil
|
return nil
|
||||||
case err := <-errc:
|
case err := <-errc:
|
||||||
return err
|
return err
|
||||||
@@ -754,11 +882,17 @@ func runUnixPairing(ctx context.Context, cfg *Config) error {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
// A Host that connects to this server: its door is open while it is
|
||||||
|
// served (hostdoor.go), and closed after the last such pairing stops.
|
||||||
|
if cfg.hostDials() {
|
||||||
|
closeDoor, err := doorOpen(cfg)
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
defer closeDoor()
|
||||||
|
}
|
||||||
lane := cfg.laneWhere()
|
lane := cfg.laneWhere()
|
||||||
upstream := &http.Client{Transport: &http.Transport{
|
upstream := &http.Client{Transport: laneHTTPTransport(dialHost, laneTLS)}
|
||||||
DialContext: func(ctx context.Context, _, _ string) (net.Conn, error) { return dialHost(ctx) },
|
|
||||||
TLSClientConfig: laneTLS.Clone(),
|
|
||||||
}}
|
|
||||||
|
|
||||||
// Coder runs: the box-wide loop, then a unix pairing's run sockets, which
|
// Coder runs: the box-wide loop, then a unix pairing's run sockets, which
|
||||||
// are registered before the harness workers come up so a run-up that
|
// are registered before the harness workers come up so a run-up that
|
||||||
@@ -842,8 +976,10 @@ func runUnixPairing(ctx context.Context, cfg *Config) error {
|
|||||||
|
|
||||||
// The heartbeat: the same body (no WireGuard device, so no allowed IPs
|
// The heartbeat: the same body (no WireGuard device, so no allowed IPs
|
||||||
// and no endpoint) and every directive its reply carries except the two
|
// and no endpoint) and every directive its reply carries except the two
|
||||||
// that move a tunnel.
|
// that move a tunnel. A stopped run waits for it, as runPairing's does.
|
||||||
|
beatDone := make(chan struct{})
|
||||||
go func() {
|
go func() {
|
||||||
|
defer close(beatDone)
|
||||||
hbURL := fmt.Sprintf("https://%s:8443/api/network/bastions/heartbeat", cfg.HostName)
|
hbURL := fmt.Sprintf("https://%s:8443/api/network/bastions/heartbeat", cfg.HostName)
|
||||||
hostname, _ := os.Hostname()
|
hostname, _ := os.Hostname()
|
||||||
wgPub := ""
|
wgPub := ""
|
||||||
@@ -853,7 +989,10 @@ func runUnixPairing(ctx context.Context, cfg *Config) error {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
beat := func() {
|
beat := func() {
|
||||||
req, err := http.NewRequest(http.MethodPost, hbURL, strings.NewReader(heartbeatPayload(cfg, nil, hostname, wgPub)))
|
if ctx.Err() != nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
req, err := http.NewRequestWithContext(ctx, http.MethodPost, hbURL, strings.NewReader(heartbeatPayload(cfg, nil, hostname, wgPub)))
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
@@ -868,8 +1007,12 @@ func runUnixPairing(ctx context.Context, cfg *Config) error {
|
|||||||
if !ok {
|
if !ok {
|
||||||
return // a reply past its bound is no answer (lane_bounds.go)
|
return // a reply past its bound is no answer (lane_bounds.go)
|
||||||
}
|
}
|
||||||
|
if ctx.Err() != nil {
|
||||||
|
return // the pairing stopped while this beat was out
|
||||||
|
}
|
||||||
if resp.StatusCode < 300 {
|
if resp.StatusCode < 300 {
|
||||||
recordPairingOK(cfg.HostName)
|
recordPairingOK(cfg.HostName)
|
||||||
|
laneHoldFor(cfg.HostName).fromBeat(cfg.HostName, beatSaysQuarantined(body))
|
||||||
}
|
}
|
||||||
maybeSelfUpdate(cfg.HostName, cfg.dcnDir(), body)
|
maybeSelfUpdate(cfg.HostName, cfg.dcnDir(), body)
|
||||||
maybeContain(cfg.HostName, cfg.dcnDir(), body)
|
maybeContain(cfg.HostName, cfg.dcnDir(), body)
|
||||||
@@ -884,10 +1027,12 @@ func runUnixPairing(ctx context.Context, cfg *Config) error {
|
|||||||
go runAlertsRefresh(ctx)
|
go runAlertsRefresh(ctx)
|
||||||
go runOtherBastionRefresh(ctx)
|
go runOtherBastionRefresh(ctx)
|
||||||
go runDeltaRefresh(ctx)
|
go runDeltaRefresh(ctx)
|
||||||
beat()
|
rb, unregisterBeat := registerRunBeat(cfg.HostName, beat)
|
||||||
|
defer unregisterBeat()
|
||||||
|
rb.run()
|
||||||
// Every 60 s, and at once after a pairing on this box changes state
|
// Every 60 s, and at once after a pairing on this box changes state
|
||||||
// (beatnow.go).
|
// (beatnow.go).
|
||||||
runBeatLoop(ctx, 60*time.Second, nil, beat)
|
runBeatLoop(ctx, 60*time.Second, nil, rb.run)
|
||||||
}()
|
}()
|
||||||
|
|
||||||
srv := &http.Server{Addr: cfg.ListenAddr, Handler: mux}
|
srv := &http.Server{Addr: cfg.ListenAddr, Handler: mux}
|
||||||
@@ -899,6 +1044,7 @@ func runUnixPairing(ctx context.Context, cfg *Config) error {
|
|||||||
select {
|
select {
|
||||||
case <-ctx.Done():
|
case <-ctx.Done():
|
||||||
_ = srv.Close()
|
_ = srv.Close()
|
||||||
|
<-beatDone
|
||||||
return nil
|
return nil
|
||||||
case err := <-errc:
|
case err := <-errc:
|
||||||
return err
|
return err
|
||||||
@@ -1080,6 +1226,12 @@ type statusRead struct {
|
|||||||
Pairings []statusPairing `json:"pairings"`
|
Pairings []statusPairing `json:"pairings"`
|
||||||
Mode string `json:"mode,omitempty"`
|
Mode string `json:"mode,omitempty"`
|
||||||
Anchor *statusAnchor `json:"anchor,omitempty"`
|
Anchor *statusAnchor `json:"anchor,omitempty"`
|
||||||
|
// LLM: the OpenAI-compatible model server the llm lane serves
|
||||||
|
// (llmlocal.go): set, found on this machine, or none.
|
||||||
|
LLM *statusLLM `json:"llm,omitempty"`
|
||||||
|
// Firewall: the door's way in through this machine's firewall
|
||||||
|
// (doorfw.go): the bastion's own rules, and what it could not do.
|
||||||
|
Firewall *statusFirewall `json:"firewall,omitempty"`
|
||||||
}
|
}
|
||||||
|
|
||||||
type statusPairing struct {
|
type statusPairing struct {
|
||||||
@@ -1096,6 +1248,14 @@ type statusPairing struct {
|
|||||||
Endpoint string `json:"endpoint,omitempty"`
|
Endpoint string `json:"endpoint,omitempty"`
|
||||||
Local string `json:"local"`
|
Local string `json:"local"`
|
||||||
Answering bool `json:"answering"`
|
Answering bool `json:"answering"`
|
||||||
|
// WaitingFor: a pending pairing waits for this Host, the one in charge of
|
||||||
|
// the machine, to admit it (anchor_local.go admitter). Nothing runs for
|
||||||
|
// it until then, so it is never "not answering".
|
||||||
|
WaitingFor string `json:"waiting_for,omitempty"`
|
||||||
|
// Failing: the run last stopped on this error and is tried again by
|
||||||
|
// itself (pairing_retry.go); the other pairings are served meanwhile.
|
||||||
|
// Cleared once a run has stayed up for retryResetAfter.
|
||||||
|
Failing *pairingFailure `json:"failing,omitempty"`
|
||||||
}
|
}
|
||||||
|
|
||||||
type statusAnchor struct {
|
type statusAnchor struct {
|
||||||
@@ -1109,27 +1269,45 @@ func readStatus(readOpts) (statusRead, error) {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
return statusRead{}, fmt.Errorf("this machine's pairings cannot be read: %w", err)
|
return statusRead{}, fmt.Errorf("this machine's pairings cannot be read: %w", err)
|
||||||
}
|
}
|
||||||
s := statusRead{Version: clientVersion, Running: "no", Pairings: []statusPairing{}}
|
s := statusRead{Version: clientVersion, Running: "no", Pairings: []statusPairing{}, Firewall: readDoorFirewallStatus()}
|
||||||
if len(cfgs) == 0 {
|
if len(cfgs) == 0 {
|
||||||
// With no Host the only thing listening is the console, so that is
|
// With no Host the only thing listening is the console, so that is
|
||||||
// what says whether the daemon is up.
|
// what says whether the daemon is up.
|
||||||
if uiDaemonListening() {
|
if uiDaemonListening() {
|
||||||
s.Running = "yes"
|
s.Running = "yes"
|
||||||
}
|
}
|
||||||
|
s.LLM = llmStatus()
|
||||||
return s, nil
|
return s, nil
|
||||||
}
|
}
|
||||||
running := 0
|
running, served := 0, 0
|
||||||
|
who := admitter()
|
||||||
|
failures := loadPairingFailures()
|
||||||
for _, cfg := range cfgs {
|
for _, cfg := range cfgs {
|
||||||
p := statusPairing{Host: cfg.HostName, State: cfg.stateName(), Local: cfg.ListenAddr,
|
p := statusPairing{Host: cfg.HostName, State: cfg.stateName(), Local: cfg.ListenAddr,
|
||||||
Answering: bastionListening(cfg.ListenAddr)}
|
Answering: bastionListening(cfg.ListenAddr)}
|
||||||
if p.Answering {
|
if cfg.invalid == "" && cfg.State == pairingPending && who != "" {
|
||||||
running++
|
p.WaitingFor = who
|
||||||
|
}
|
||||||
|
// Until a run has stayed up for retryResetAfter, its last failure is
|
||||||
|
// shown, whether or not the port answers now.
|
||||||
|
if f, ok := failures[cfg.HostName]; ok && cfg.active() {
|
||||||
|
p.Failing = &f
|
||||||
|
}
|
||||||
|
// Only a pairing that is served counts: one waiting to be admitted
|
||||||
|
// has nothing to answer with.
|
||||||
|
if cfg.active() {
|
||||||
|
served++
|
||||||
|
if p.Answering {
|
||||||
|
running++
|
||||||
|
}
|
||||||
}
|
}
|
||||||
switch {
|
switch {
|
||||||
case cfg.invalid != "":
|
case cfg.invalid != "":
|
||||||
p.Problem = cfg.invalid
|
p.Problem = cfg.invalid
|
||||||
case cfg.unixTransport():
|
case cfg.unixTransport():
|
||||||
p.Transport, p.Lanes, p.Runs = "local", cfg.LaneSocket, cfg.RunsDir
|
p.Transport, p.Lanes, p.Runs = "local", cfg.LaneSocket, cfg.RunsDir
|
||||||
|
case cfg.hostDials():
|
||||||
|
p.Transport, p.Lanes = "tcp", cfg.laneWhere()
|
||||||
case cfg.tcpTransport():
|
case cfg.tcpTransport():
|
||||||
p.Transport, p.Lanes = "tcp", cfg.LaneAddr
|
p.Transport, p.Lanes = "tcp", cfg.LaneAddr
|
||||||
default:
|
default:
|
||||||
@@ -1138,12 +1316,18 @@ func readStatus(readOpts) (statusRead, error) {
|
|||||||
s.Pairings = append(s.Pairings, p)
|
s.Pairings = append(s.Pairings, p)
|
||||||
}
|
}
|
||||||
switch {
|
switch {
|
||||||
case running == len(cfgs):
|
case served == 0:
|
||||||
|
// Nothing to serve yet: the console says whether the daemon is up.
|
||||||
|
if uiDaemonListening() {
|
||||||
|
s.Running = "yes"
|
||||||
|
}
|
||||||
|
case running == served:
|
||||||
s.Running = "yes"
|
s.Running = "yes"
|
||||||
case running > 0:
|
case running > 0:
|
||||||
s.Running = "partly"
|
s.Running = "partly"
|
||||||
}
|
}
|
||||||
s.Mode = boxMode()
|
s.Mode = boxMode()
|
||||||
|
s.LLM = llmStatus()
|
||||||
if a := currentAnchor(); a != nil {
|
if a := currentAnchor(); a != nil {
|
||||||
s.Anchor = &statusAnchor{Host: a.AnchorHost, Owner: a.Owner, Since: a.ClaimedAt}
|
s.Anchor = &statusAnchor{Host: a.AnchorHost, Owner: a.Owner, Since: a.ClaimedAt}
|
||||||
}
|
}
|
||||||
@@ -1189,6 +1373,10 @@ func printStatus(w io.Writer, s statusRead) {
|
|||||||
} else {
|
} else {
|
||||||
fmt.Fprintf(w, "NOT RUNNING, and no Host is connected. Start it with `%s`.\n", runCommandHint())
|
fmt.Fprintf(w, "NOT RUNNING, and no Host is connected. Start it with `%s`.\n", runCommandHint())
|
||||||
}
|
}
|
||||||
|
if s.LLM != nil {
|
||||||
|
fmt.Fprintf(w, "model server: %s\n", s.LLM.words())
|
||||||
|
}
|
||||||
|
printDoorFirewallStatus(w, s.Firewall)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
// IS IT RUNNING, AND WHERE — the first thing status should answer and the
|
// IS IT RUNNING, AND WHERE — the first thing status should answer and the
|
||||||
@@ -1200,22 +1388,41 @@ func printStatus(w io.Writer, s statusRead) {
|
|||||||
// a self-update the bastion has NO console at all — it is serving, and there
|
// a self-update the bastion has NO console at all — it is serving, and there
|
||||||
// is nothing on screen that says so. status printed pairings and mode and
|
// is nothing on screen that says so. status printed pairings and mode and
|
||||||
// never once said whether a daemon was alive.
|
// never once said whether a daemon was alive.
|
||||||
served := 0
|
served, servable := 0, 0
|
||||||
|
waiting := map[string][]string{}
|
||||||
|
var admitters []string
|
||||||
for _, p := range s.Pairings {
|
for _, p := range s.Pairings {
|
||||||
if p.Answering {
|
if p.WaitingFor != "" {
|
||||||
served++
|
if len(waiting[p.WaitingFor]) == 0 {
|
||||||
|
admitters = append(admitters, p.WaitingFor)
|
||||||
|
}
|
||||||
|
waiting[p.WaitingFor] = append(waiting[p.WaitingFor], p.Host)
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
if p.State == pairingActive {
|
||||||
|
servable++
|
||||||
|
if p.Answering {
|
||||||
|
served++
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
switch s.Running {
|
switch {
|
||||||
case "yes":
|
case s.Running == "no":
|
||||||
fmt.Fprintf(w, "RUNNING — serving %d host(s) on this machine.\n", len(s.Pairings))
|
|
||||||
case "partly":
|
|
||||||
fmt.Fprintf(w, "PARTLY RUNNING — %d of %d hosts are being served; the rest are not answering.\n",
|
|
||||||
served, len(s.Pairings))
|
|
||||||
default:
|
|
||||||
fmt.Fprintf(w, "NOT RUNNING — nothing is serving these pairings. Start it with `%s`.\n", runCommandHint())
|
fmt.Fprintf(w, "NOT RUNNING — nothing is serving these pairings. Start it with `%s`.\n", runCommandHint())
|
||||||
|
case servable == 0:
|
||||||
|
fmt.Fprintln(w, "RUNNING — no Host is served yet.")
|
||||||
|
case s.Running == "partly":
|
||||||
|
fmt.Fprintf(w, "PARTLY RUNNING — %d of %d hosts are being served; the rest are not answering.\n",
|
||||||
|
served, servable)
|
||||||
|
default:
|
||||||
|
fmt.Fprintf(w, "RUNNING — serving %d host(s) on this machine.\n", servable)
|
||||||
}
|
}
|
||||||
if served > 0 && runtime.GOOS == "windows" {
|
for _, who := range admitters {
|
||||||
|
hosts := waiting[who]
|
||||||
|
fmt.Fprintf(w, " Waiting for %s to admit it: %s. %s asks you to approve it; it is served from then on.\n",
|
||||||
|
who, strings.Join(hosts, ", "), who)
|
||||||
|
}
|
||||||
|
if served > 0 && runtime.GOOS == "windows" && !systemService.installed {
|
||||||
fmt.Fprintln(w, " (No window? After a self-update it restarts itself detached, so it")
|
fmt.Fprintln(w, " (No window? After a self-update it restarts itself detached, so it")
|
||||||
fmt.Fprintln(w, " has no console. Task Manager → privatae-bastion.exe is where it lives.)")
|
fmt.Fprintln(w, " has no console. Task Manager → privatae-bastion.exe is where it lives.)")
|
||||||
}
|
}
|
||||||
@@ -1226,7 +1433,10 @@ func printStatus(w io.Writer, s statusRead) {
|
|||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
live := "not answering"
|
live := "not answering"
|
||||||
if p.Answering {
|
switch {
|
||||||
|
case p.WaitingFor != "":
|
||||||
|
live = "waiting for " + p.WaitingFor + " to admit it"
|
||||||
|
case p.Answering:
|
||||||
live = "answering"
|
live = "answering"
|
||||||
}
|
}
|
||||||
switch p.Transport {
|
switch p.Transport {
|
||||||
@@ -1240,11 +1450,19 @@ func printStatus(w io.Writer, s statusRead) {
|
|||||||
fmt.Fprintf(w, "paired with: %s [%s]\n tunnel: %s -> %s via %s\n local: http://%s (%s)\n",
|
fmt.Fprintf(w, "paired with: %s [%s]\n tunnel: %s -> %s via %s\n local: http://%s (%s)\n",
|
||||||
p.Host, p.State, p.BastionIP, p.HostIP, p.Endpoint, p.Local, live)
|
p.Host, p.State, p.BastionIP, p.HostIP, p.Endpoint, p.Local, live)
|
||||||
}
|
}
|
||||||
|
if f := p.Failing; f != nil {
|
||||||
|
fmt.Fprintf(w, " last stopped: %s (at %s, try %d); tried again by itself from %s, the other Hosts served meanwhile\n",
|
||||||
|
strings.TrimRight(f.Error, "."), uiWhen(f.At), f.Tries, uiWhen(f.NextTry))
|
||||||
|
}
|
||||||
}
|
}
|
||||||
fmt.Fprintf(w, "mode: %s\n", s.Mode)
|
fmt.Fprintf(w, "mode: %s\n", s.Mode)
|
||||||
if a := s.Anchor; a != nil {
|
if a := s.Anchor; a != nil {
|
||||||
fmt.Fprintf(w, "anchor: %s (owner %q, since %s)\n", a.Host, a.Owner, a.Since)
|
fmt.Fprintf(w, "anchor: %s (owner %q, since %s)\n", a.Host, a.Owner, a.Since)
|
||||||
}
|
}
|
||||||
|
if s.LLM != nil {
|
||||||
|
fmt.Fprintf(w, "model server: %s\n", s.LLM.words())
|
||||||
|
}
|
||||||
|
printDoorFirewallStatus(w, s.Firewall)
|
||||||
}
|
}
|
||||||
|
|
||||||
// ollamaModels reports whether a local ollama with the embeddings API answers
|
// ollamaModels reports whether a local ollama with the embeddings API answers
|
||||||
@@ -1315,12 +1533,18 @@ func ollamaModelsAt(addrs []string) (bool, []string) {
|
|||||||
const llmForwardPort = 18080
|
const llmForwardPort = 18080
|
||||||
|
|
||||||
// openAICompatModels detects a non-ollama LLM server (llama.cpp llama-server,
|
// openAICompatModels detects a non-ollama LLM server (llama.cpp llama-server,
|
||||||
// vLLM, anything OpenAI-compatible) via GET /v1/models. Only PRIVATAE_LLM_ADDR is
|
// vLLM, anything OpenAI-compatible) via GET /v1/models at llmTarget:
|
||||||
// probed — unlike ollama there is no conventional default port worth guessing,
|
// PRIVATAE_LLM_ADDR, or the server found on this machine's loopback
|
||||||
// and the operator setting the env IS the opt-in. Same 200-is-alive rule as
|
// (llmlocal.go). Same 200-is-alive rule as /api/tags: a live server with an
|
||||||
// /api/tags: a live server with an unparseable list still counts.
|
// unparseable list still counts. A found server that no longer answers is
|
||||||
|
// asked for again (llmTargetFailed).
|
||||||
func openAICompatModels() (bool, []string) {
|
func openAICompatModels() (bool, []string) {
|
||||||
return openAICompatModelsAt(llmTarget())
|
t := llmTarget()
|
||||||
|
ok, models := openAICompatModelsAt(t)
|
||||||
|
if !ok {
|
||||||
|
llmTargetFailed(t)
|
||||||
|
}
|
||||||
|
return ok, models
|
||||||
}
|
}
|
||||||
|
|
||||||
// openAICompatModelsAt is openAICompatModels' probe of one address.
|
// openAICompatModelsAt is openAICompatModels' probe of one address.
|
||||||
@@ -1368,14 +1592,14 @@ func localOllamaAddr() string {
|
|||||||
|
|
||||||
// serveLLMForward is serveOllamaForward's twin for the OpenAI-compatible
|
// serveLLMForward is serveOllamaForward's twin for the OpenAI-compatible
|
||||||
// server: host dials <bastion tunnel IP>:18080, we proxy raw TCP to
|
// server: host dials <bastion tunnel IP>:18080, we proxy raw TCP to
|
||||||
// PRIVATAE_LLM_ADDR. Only runs when the env is set (the operator's opt-in).
|
// llmTarget (PRIVATAE_LLM_ADDR, or the server found on this machine, llmlocal.go).
|
||||||
// The "llm-openai" heartbeat capability is the host's signal that this
|
// The "llm-openai" heartbeat capability is the host's signal that this
|
||||||
// listener exists and speaks the /v1 dialect.
|
// listener exists and speaks the /v1 dialect.
|
||||||
func serveLLMForward(ctx context.Context, self string, tnet *netstack.Net, gwIP netip.Addr) {
|
func serveLLMForward(ctx context.Context, self string, tnet *netstack.Net, gwIP netip.Addr) {
|
||||||
target := llmTarget()
|
// Listening whether or not a server is there now: the one found on this
|
||||||
if target == "" {
|
// machine (llmlocal.go) may start after the bastion, and the beat
|
||||||
return
|
// advertises the lane only while llmTarget names one. Each connection
|
||||||
}
|
// goes to the server llmTarget names at that moment.
|
||||||
ln, err := tnet.ListenTCP(&net.TCPAddr{IP: gwIP.AsSlice(), Port: llmForwardPort})
|
ln, err := tnet.ListenTCP(&net.TCPAddr{IP: gwIP.AsSlice(), Port: llmForwardPort})
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return
|
return
|
||||||
@@ -1390,6 +1614,11 @@ func serveLLMForward(ctx context.Context, self string, tnet *netstack.Net, gwIP
|
|||||||
if refused(in) {
|
if refused(in) {
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
|
target := llmTarget()
|
||||||
|
if target == "" {
|
||||||
|
_ = in.Close()
|
||||||
|
continue
|
||||||
|
}
|
||||||
// A pairing whose grant NAMES models gets an HTTP-aware proxy
|
// A pairing whose grant NAMES models gets an HTTP-aware proxy
|
||||||
// that checks the model on each request; one with a free hand gets the
|
// that checks the model on each request; one with a free hand gets the
|
||||||
// raw splice this lane has always been (inferencefilter.go).
|
// raw splice this lane has always been (inferencefilter.go).
|
||||||
|
|||||||
@@ -0,0 +1,58 @@
|
|||||||
|
//go:build linux
|
||||||
|
|
||||||
|
// A pairing's run and its heartbeat stop together (run.go): uses the serve
|
||||||
|
// lane's fixtures (servelane_linux_test.go), so it carries the same build tag.
|
||||||
|
|
||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"os"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
// A pairing stopped while a beat is out acts on nothing that beat brings
|
||||||
|
// back. The run waits for its heartbeat and the beat's request ends with the
|
||||||
|
// run, so its last-OK time, and anything else the reply would have set off
|
||||||
|
// (a grant reconcile into the pairing's folder, a contain, an update), never
|
||||||
|
// lands after the stop, when an unpair or a revoke removes what is left.
|
||||||
|
func TestAStoppedPairingsLastBeatWritesNothingAfterTheStop(t *testing.T) {
|
||||||
|
h, cfg := serveLaneBox(t, "beat-stop.example.test")
|
||||||
|
arrived, release := make(chan struct{}, 1), make(chan struct{})
|
||||||
|
h.mu.Lock()
|
||||||
|
h.beatArrived, h.beatRelease = arrived, release
|
||||||
|
h.mu.Unlock()
|
||||||
|
released := false
|
||||||
|
t.Cleanup(func() {
|
||||||
|
if !released {
|
||||||
|
close(release)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
ctx, cancel := context.WithCancel(context.Background())
|
||||||
|
defer cancel()
|
||||||
|
done := make(chan error, 1)
|
||||||
|
go func() { done <- runPairing(ctx, cfg) }()
|
||||||
|
select {
|
||||||
|
case <-arrived:
|
||||||
|
case <-time.After(10 * time.Second):
|
||||||
|
t.Fatal("no beat reached the Host")
|
||||||
|
}
|
||||||
|
cancel()
|
||||||
|
select {
|
||||||
|
case <-done:
|
||||||
|
case <-time.After(5 * time.Second):
|
||||||
|
t.Fatal("the pairing did not stop while its beat was out")
|
||||||
|
}
|
||||||
|
// The Host answers the beat only now, after the run has returned.
|
||||||
|
close(release)
|
||||||
|
released = true
|
||||||
|
time.Sleep(500 * time.Millisecond)
|
||||||
|
p, err := pairingStatePath()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if _, err := os.Stat(p); err == nil {
|
||||||
|
t.Fatal("the stopped pairing's last beat recorded its time after the stop")
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -8,6 +8,9 @@ import (
|
|||||||
"os"
|
"os"
|
||||||
"path/filepath"
|
"path/filepath"
|
||||||
"sync/atomic"
|
"sync/atomic"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"golang.org/x/sys/windows"
|
||||||
)
|
)
|
||||||
|
|
||||||
// runGuardFile holds the "one running bastion" lock for the life of this
|
// runGuardFile holds the "one running bastion" lock for the life of this
|
||||||
@@ -72,8 +75,8 @@ func refuseVisibly(shown uiNotice, err error) error {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// cannotStart is the wording for the two I/O failures below. They have no
|
// cannotStart is the wording for the two I/O failures below. They have no
|
||||||
// prepared words the way the already-running case does (secondRunNotice,
|
// prepared words the way the already-running case does (secondRunWords,
|
||||||
// notify.go), and the error itself is the most accurate thing there is to say:
|
// runholder.go), and the error itself is the most accurate thing there is to say:
|
||||||
// both mean the config directory is unusable, which is not a state anyone can be
|
// both mean the config directory is unusable, which is not a state anyone can be
|
||||||
// given advice about from here.
|
// given advice about from here.
|
||||||
func cannotStart(err error) uiNotice {
|
func cannotStart(err error) uiNotice {
|
||||||
@@ -90,19 +93,36 @@ func guardSingleRun() error {
|
|||||||
err = fmt.Errorf("cannot open the run lock: %w", err)
|
err = fmt.Errorf("cannot open the run lock: %w", err)
|
||||||
return refuseVisibly(cannotStart(err), err)
|
return refuseVisibly(cannotStart(err), err)
|
||||||
}
|
}
|
||||||
if err := flockFileNB(f); err != nil {
|
// Relaunched by the self-update of the bastion this one replaces, which
|
||||||
|
// holds the lock until it has exited (runholder.go).
|
||||||
|
if err := takeRunLock(lockTry(f), relaunchOf(), waitProcessExit,
|
||||||
|
30*time.Second, time.Now, time.Sleep); err != nil {
|
||||||
_ = f.Close()
|
_ = f.Close()
|
||||||
// The dialog and the console get DIFFERENT words for the same fact, and
|
// The dialog and the console get DIFFERENT words for the same fact, and
|
||||||
// that is on purpose: this text is laid out for a terminal — indented
|
// that is on purpose: the console's are laid out for a terminal, with
|
||||||
// continuation lines, and "you can close this window" meaning the console
|
// indented continuation lines (secondRunWords).
|
||||||
// window it is being printed into. secondRunNotice says it for a dialog.
|
h, known := readRunHolder(d)
|
||||||
return refuseVisibly(secondRunNotice(), errors.New(
|
text, notice := secondRunWords(h, known)
|
||||||
"a bastion is already running on this machine — that one is serving "+
|
return refuseVisibly(notice, errors.New(text))
|
||||||
"your hosts, and a second would fight it for the same local ports.\n"+
|
|
||||||
" Nothing is wrong: you can close this window.\n"+
|
|
||||||
" If you believe the running one is dead, stop it (Task Manager → "+
|
|
||||||
"privatae-bastion.exe) and run this again"))
|
|
||||||
}
|
}
|
||||||
runGuardFile.Store(f)
|
runGuardFile.Store(f)
|
||||||
|
writeRunHolder(d, stdinIsTerminal())
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// lockTry is one attempt at f's lock. Outside guardSingleRun, whose every
|
||||||
|
// return is a refusal shown to the person (TestEveryRunGuardRefusalIsVisible).
|
||||||
|
func lockTry(f *os.File) func() error {
|
||||||
|
return func() error { return flockFileNB(f) }
|
||||||
|
}
|
||||||
|
|
||||||
|
// waitProcessExit waits up to d for process pid to exit. A process that
|
||||||
|
// cannot be opened has exited already, or is not ours to wait on.
|
||||||
|
func waitProcessExit(pid int, d time.Duration) {
|
||||||
|
h, err := windows.OpenProcess(windows.SYNCHRONIZE, false, uint32(pid))
|
||||||
|
if err != nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
defer windows.CloseHandle(h)
|
||||||
|
_, _ = windows.WaitForSingleObject(h, uint32(d/time.Millisecond))
|
||||||
|
}
|
||||||
|
|||||||
@@ -0,0 +1,141 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
// runholder.go — what a second start on Windows is told about the first.
|
||||||
|
//
|
||||||
|
// A bastion that finds its run lock held (runguard_windows.go) used to say
|
||||||
|
// only that one was running, and that if it seemed dead it could be ended in
|
||||||
|
// Task Manager. On a machine where `privatae-bastion ui` then failed, that
|
||||||
|
// was the one thing to try, so a running bastion was killed for a symptom
|
||||||
|
// that was not its. The bastion that holds the lock now writes who it is
|
||||||
|
// beside it, and the refusal names it: its process, its program, how it was
|
||||||
|
// started, and the commands that open, check and restart it.
|
||||||
|
//
|
||||||
|
// And the relaunch after a self-update (relaunch_windows.go) starts the new
|
||||||
|
// binary while the old one still holds the lock, a few milliseconds from
|
||||||
|
// exiting. The new one waits for it (takeRunLock) rather than refusing and
|
||||||
|
// leaving the machine with no bastion at all.
|
||||||
|
|
||||||
|
import (
|
||||||
|
"encoding/json"
|
||||||
|
"fmt"
|
||||||
|
"os"
|
||||||
|
"path/filepath"
|
||||||
|
"strconv"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
type runHolder struct {
|
||||||
|
PID int `json:"pid"`
|
||||||
|
Program string `json:"program,omitempty"`
|
||||||
|
Started string `json:"started,omitempty"` // RFC3339
|
||||||
|
Service bool `json:"service,omitempty"` // the Windows service
|
||||||
|
Console bool `json:"console,omitempty"` // started from a terminal
|
||||||
|
}
|
||||||
|
|
||||||
|
func runHolderPath(dir string) string { return filepath.Join(dir, "run.holder.json") }
|
||||||
|
|
||||||
|
// writeRunHolder records this process as the lock's holder. Best effort: a
|
||||||
|
// refusal without it is only less specific.
|
||||||
|
func writeRunHolder(dir string, console bool) {
|
||||||
|
h := runHolder{PID: os.Getpid(), Started: time.Now().UTC().Format(time.RFC3339),
|
||||||
|
Service: runningAsService, Console: console}
|
||||||
|
if exe, err := os.Executable(); err == nil {
|
||||||
|
h.Program = exe
|
||||||
|
}
|
||||||
|
if raw, err := json.Marshal(h); err == nil {
|
||||||
|
_ = atomicWrite(runHolderPath(dir), raw)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func readRunHolder(dir string) (runHolder, bool) {
|
||||||
|
var h runHolder
|
||||||
|
raw, err := os.ReadFile(runHolderPath(dir))
|
||||||
|
if err != nil || json.Unmarshal(raw, &h) != nil || h.PID <= 0 {
|
||||||
|
return runHolder{}, false
|
||||||
|
}
|
||||||
|
return h, true
|
||||||
|
}
|
||||||
|
|
||||||
|
// secondRunWords is the refusal of a second start, for the terminal and for
|
||||||
|
// the dialog a start with no console shows. known is false
|
||||||
|
// when the running bastion left no record (an older version holds the lock).
|
||||||
|
func secondRunWords(h runHolder, known bool) (console string, dialog uiNotice) {
|
||||||
|
what := "A bastion is already running on this machine"
|
||||||
|
restart := "Get-Process privatae-bastion | Format-List Id, Path, StartTime shows it; " +
|
||||||
|
"Stop-Process -Id <its Id>, then Start-ScheduledTask -TaskName " + winServiceName
|
||||||
|
if known {
|
||||||
|
how := "in the background (its sign-in task, or itself after an update)"
|
||||||
|
switch {
|
||||||
|
case h.Service:
|
||||||
|
how = "as the " + winServiceName + " service"
|
||||||
|
case h.Console:
|
||||||
|
how = "from a terminal"
|
||||||
|
}
|
||||||
|
what += " (process " + strconv.Itoa(h.PID)
|
||||||
|
if h.Program != "" {
|
||||||
|
what += ", " + h.Program
|
||||||
|
}
|
||||||
|
if t, err := time.Parse(time.RFC3339, h.Started); err == nil {
|
||||||
|
what += ", started " + t.Local().Format("2 Jan 15:04")
|
||||||
|
}
|
||||||
|
what += ", " + how + ")"
|
||||||
|
switch {
|
||||||
|
case h.Service:
|
||||||
|
restart = "Restart-Service " + winServiceName + " (from an Administrator terminal)"
|
||||||
|
default:
|
||||||
|
restart = "Stop-Process -Id " + strconv.Itoa(h.PID) + ", then start it again: Start-ScheduledTask -TaskName " +
|
||||||
|
winServiceName + " (or privatae-bastion run)"
|
||||||
|
}
|
||||||
|
}
|
||||||
|
console = fmt.Sprintf("%s.\n"+
|
||||||
|
" It is the one serving your Hosts, and a second copy would fight it for the same local ports,\n"+
|
||||||
|
" so this one is stopping. Nothing is wrong, and nothing needs ending.\n"+
|
||||||
|
" To open it: privatae-bastion ui\n"+
|
||||||
|
" To check it: privatae-bastion status\n"+
|
||||||
|
" To restart it: %s", what, restart)
|
||||||
|
dialog = uiNotice{
|
||||||
|
Title: "Privatae bastion is already running",
|
||||||
|
Body: what + ".\r\n\r\n" +
|
||||||
|
"It is the one serving your Hosts. A second copy would fight it for the same local ports, so this one " +
|
||||||
|
"is stopping. Nothing is wrong, and nothing needs ending.\r\n\r\n" +
|
||||||
|
"To open it, run: privatae-bastion ui\r\n" +
|
||||||
|
"To restart it: " + restart,
|
||||||
|
}
|
||||||
|
return console, dialog
|
||||||
|
}
|
||||||
|
|
||||||
|
// relaunchOfEnv names, in the environment of a bastion started by its
|
||||||
|
// predecessor's self-update, the predecessor's process id.
|
||||||
|
const relaunchOfEnv = "PRIVATAE_BASTION_RELAUNCH_OF"
|
||||||
|
|
||||||
|
// takeRunLock takes the run lock with try. A bastion relaunched by its
|
||||||
|
// predecessor (replaces > 0) first waits up to patience for that process to
|
||||||
|
// exit (waitExit), then tries again until patience has passed: the lock is
|
||||||
|
// released as the predecessor's handles close, a moment after it exits.
|
||||||
|
func takeRunLock(try func() error, replaces int, waitExit func(pid int, d time.Duration), patience time.Duration,
|
||||||
|
now func() time.Time, sleep func(time.Duration)) error {
|
||||||
|
if replaces <= 0 {
|
||||||
|
return try()
|
||||||
|
}
|
||||||
|
deadline := now().Add(patience)
|
||||||
|
waitExit(replaces, patience)
|
||||||
|
for {
|
||||||
|
err := try()
|
||||||
|
if err == nil || !now().Before(deadline) {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
sleep(200 * time.Millisecond)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// relaunchOf reads relaunchOfEnv once and clears it, so nothing this process
|
||||||
|
// starts inherits it.
|
||||||
|
func relaunchOf() int {
|
||||||
|
v := os.Getenv(relaunchOfEnv)
|
||||||
|
_ = os.Unsetenv(relaunchOfEnv)
|
||||||
|
pid, err := strconv.Atoi(v)
|
||||||
|
if err != nil || pid <= 0 {
|
||||||
|
return 0
|
||||||
|
}
|
||||||
|
return pid
|
||||||
|
}
|
||||||
@@ -0,0 +1,81 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"os"
|
||||||
|
"path/filepath"
|
||||||
|
"regexp"
|
||||||
|
"strings"
|
||||||
|
"testing"
|
||||||
|
)
|
||||||
|
|
||||||
|
// Every script in scripts/ that starts a bastion in namespaces of its own
|
||||||
|
// hides ALL of /run and /tmp, never a chosen subdirectory of them, and refuses
|
||||||
|
// to go on while it can still see the machine's own bastion. A run that put a
|
||||||
|
// tmpfs over /run/privatae but not /run/privatae-bastion replaced a live
|
||||||
|
// bastion's ask.sock and context.sock on the machine running the tests.
|
||||||
|
//
|
||||||
|
// MUTATION: the e2e script's /run mount back to /run/privatae alone. RESULT: red.
|
||||||
|
// MUTATION: drop its guard for /run/privatae-bastion. RESULT: red.
|
||||||
|
// MUTATION: move the guard after the first start of the bastion. RESULT: red.
|
||||||
|
// MUTATION: drop the PID 1 check before the first mount. RESULT: red.
|
||||||
|
func TestNamespaceScriptsHideAllOfRunAndTmpAndRefuseToSeeTheLiveBastion(t *testing.T) {
|
||||||
|
paths, err := filepath.Glob(filepath.Join("..", "scripts", "*.sh"))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
n := 0
|
||||||
|
for _, p := range paths {
|
||||||
|
raw, err := os.ReadFile(p)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
s := string(raw)
|
||||||
|
if !strings.Contains(s, "unshare") {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
n++
|
||||||
|
name := filepath.Base(p)
|
||||||
|
lines := strings.Split(s, "\n")
|
||||||
|
at := func(re string) int {
|
||||||
|
r := regexp.MustCompile(re)
|
||||||
|
for i, l := range lines {
|
||||||
|
if strings.HasPrefix(strings.TrimSpace(l), "#") {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
if r.MatchString(l) {
|
||||||
|
return i
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return -1
|
||||||
|
}
|
||||||
|
runAt := at(`mount -t tmpfs tmpfs /run\s*$`)
|
||||||
|
tmpAt := at(`mount -t tmpfs tmpfs /tmp\s*$`)
|
||||||
|
if runAt < 0 || tmpAt < 0 {
|
||||||
|
t.Errorf("%s: no tmpfs over all of /run (%d) and /tmp (%d)", name, runAt, tmpAt)
|
||||||
|
}
|
||||||
|
if i := at(`mount -t tmpfs tmpfs /(run|tmp)/`); i >= 0 && (runAt < 0 || i < runAt) {
|
||||||
|
t.Errorf("%s:%d hides a subdirectory of /run or /tmp instead of all of it: %s", name, i+1, lines[i])
|
||||||
|
}
|
||||||
|
guard := at(`/run/privatae-bastion`)
|
||||||
|
if guard < 0 || guard < runAt || guard < tmpAt {
|
||||||
|
t.Errorf("%s: no guard, after hiding /run and /tmp, that refuses to run while /run/privatae-bastion is visible", name)
|
||||||
|
}
|
||||||
|
if i := at(`"\$B"|privatae-bastion" (run|pair)|\$BAST`); i >= 0 && guard > i {
|
||||||
|
t.Errorf("%s:%d starts a bastion before the guard", name, i+1)
|
||||||
|
}
|
||||||
|
if at(`unshare .*--pid`) < 0 || at(`unshare .*--mount`) < 0 || at(`unshare .*--net`) < 0 {
|
||||||
|
t.Errorf("%s: a bastion runs in private PID, mount and network namespaces", name)
|
||||||
|
}
|
||||||
|
// The re-exec into the namespaces is chosen by an environment variable
|
||||||
|
// (E2E_INNER): one set by the caller skips the unshare, and every mount
|
||||||
|
// below then lands on this machine's own /run. So before any mount the
|
||||||
|
// script proves it is PID 1 of a namespace of its own.
|
||||||
|
pid1 := at(`\[ "?\$\$"? (=|-eq) "?1"? \]`)
|
||||||
|
if m := at(`^\s*(mount|mkdir -p [^;&]*&& mount) `); pid1 < 0 || (m >= 0 && pid1 > m) {
|
||||||
|
t.Errorf("%s: no check, before its first mount (line %d), that it runs as PID 1 of its own namespace (line %d)", name, m+1, pid1+1)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if n == 0 {
|
||||||
|
t.Fatal("no namespace script found: the glob is wrong")
|
||||||
|
}
|
||||||
|
}
|
||||||
+10
-5
@@ -607,16 +607,16 @@ func serveTargetNoticeClear(self string, s serveService) {
|
|||||||
// pairing's workers exit.
|
// pairing's workers exit.
|
||||||
func runServeWorkers(pctx context.Context, self, dcnDir, wsURL string, tlsCfg *tls.Config,
|
func runServeWorkers(pctx context.Context, self, dcnDir, wsURL string, tlsCfg *tls.Config,
|
||||||
dialHost func(ctx context.Context) (net.Conn, error), bearer string, n int) {
|
dialHost func(ctx context.Context) (net.Conn, error), bearer string, n int) {
|
||||||
dialer := &websocket.Dialer{
|
dialer := laneWSDialer(tlsCfg, dialHost)
|
||||||
NetDialContext: func(ctx context.Context, network, addr string) (net.Conn, error) { return dialHost(ctx) },
|
|
||||||
TLSClientConfig: tlsCfg,
|
|
||||||
HandshakeTimeout: 20 * time.Second,
|
|
||||||
}
|
|
||||||
var spawn func()
|
var spawn func()
|
||||||
spawn = func() {
|
spawn = func() {
|
||||||
go func() {
|
go func() {
|
||||||
wait := 3 * time.Second
|
wait := 3 * time.Second
|
||||||
|
hold := laneHoldFor(self)
|
||||||
for pctx.Err() == nil {
|
for pctx.Err() == nil {
|
||||||
|
if !hold.waitClear(pctx) {
|
||||||
|
return
|
||||||
|
}
|
||||||
ctx, cancel := context.WithTimeout(pctx, 25*time.Second)
|
ctx, cancel := context.WithTimeout(pctx, 25*time.Second)
|
||||||
ws, resp, err := dialer.DialContext(ctx, wsURL, http.Header{})
|
ws, resp, err := dialer.DialContext(ctx, wsURL, http.Header{})
|
||||||
cancel()
|
cancel()
|
||||||
@@ -635,6 +635,7 @@ func runServeWorkers(pctx context.Context, self, dcnDir, wsURL string, tlsCfg *t
|
|||||||
sleepCtx(pctx, time.Second)
|
sleepCtx(pctx, time.Second)
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
|
held := watchHeldClose(ws)
|
||||||
stopKA := armWSKeepalive(ws)
|
stopKA := armWSKeepalive(ws)
|
||||||
unpark := context.AfterFunc(pctx, func() { _ = ws.Close() })
|
unpark := context.AfterFunc(pctx, func() { _ = ws.Close() })
|
||||||
took := serveJob(ws, self, dcnDir, spawn)
|
took := serveJob(ws, self, dcnDir, spawn)
|
||||||
@@ -644,6 +645,10 @@ func runServeWorkers(pctx context.Context, self, dcnDir, wsURL string, tlsCfg *t
|
|||||||
if took {
|
if took {
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
if held() {
|
||||||
|
hold.refused(self) // the Host holds this machine (lanehold.go)
|
||||||
|
continue
|
||||||
|
}
|
||||||
// Closed while parked (a Host restart), or the job refused: not
|
// Closed while parked (a Host restart), or the job refused: not
|
||||||
// straight back, so a Host that closes or misuses every worker is
|
// straight back, so a Host that closes or misuses every worker is
|
||||||
// not dialled in a loop.
|
// not dialled in a loop.
|
||||||
|
|||||||
@@ -40,12 +40,15 @@ import (
|
|||||||
// serveHost is a Host's lane port as the serve lane meets it: the lane
|
// serveHost is a Host's lane port as the serve lane meets it: the lane
|
||||||
// port's mutual TLS, every worker route kept parked, each beat recorded
|
// port's mutual TLS, every worker route kept parked, each beat recorded
|
||||||
// whole, and each /bastion-serve worker handed to the test once it has sent
|
// whole, and each /bastion-serve worker handed to the test once it has sent
|
||||||
// its hello.
|
// its hello. With beatRelease set, each beat's reply waits for it to close,
|
||||||
|
// and the first beat to arrive says so on beatArrived.
|
||||||
type serveHost struct {
|
type serveHost struct {
|
||||||
mu sync.Mutex
|
mu sync.Mutex
|
||||||
beats []map[string]any
|
beats []map[string]any
|
||||||
hellos []string
|
hellos []string
|
||||||
workers chan *websocket.Conn
|
workers chan *websocket.Conn
|
||||||
|
beatArrived chan struct{}
|
||||||
|
beatRelease chan struct{}
|
||||||
}
|
}
|
||||||
|
|
||||||
func startServeHost(t *testing.T, raw net.Listener, cert tls.Certificate, clientCA *testCA) *serveHost {
|
func startServeHost(t *testing.T, raw net.Listener, cert tls.Certificate, clientCA *testCA) *serveHost {
|
||||||
@@ -62,7 +65,15 @@ func startServeHost(t *testing.T, raw net.Listener, cert tls.Certificate, client
|
|||||||
_ = json.NewDecoder(r.Body).Decode(&m)
|
_ = json.NewDecoder(r.Body).Decode(&m)
|
||||||
h.mu.Lock()
|
h.mu.Lock()
|
||||||
h.beats = append(h.beats, m)
|
h.beats = append(h.beats, m)
|
||||||
|
arrived, release := h.beatArrived, h.beatRelease
|
||||||
h.mu.Unlock()
|
h.mu.Unlock()
|
||||||
|
if release != nil {
|
||||||
|
select {
|
||||||
|
case arrived <- struct{}{}:
|
||||||
|
default:
|
||||||
|
}
|
||||||
|
<-release
|
||||||
|
}
|
||||||
_, _ = w.Write([]byte("{}"))
|
_, _ = w.Write([]byte("{}"))
|
||||||
})
|
})
|
||||||
mux.HandleFunc("/bastion-serve", func(w http.ResponseWriter, r *http.Request) {
|
mux.HandleFunc("/bastion-serve", func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
|||||||
@@ -0,0 +1,829 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
// servicecarry.go — an install that moves a machine's bastion from an account
|
||||||
|
// to the system service brings that bastion's state with it.
|
||||||
|
//
|
||||||
|
// THE PROBLEM. A bastion installed for one account keeps its pairings, keys,
|
||||||
|
// grants and audit under that account's profile. The Windows service keeps
|
||||||
|
// its own under LocalSystem's (sysservice.go). Until this, the switch started
|
||||||
|
// the service with empty state: the per-user bastion was stopped and removed
|
||||||
|
// by the installer, the service had no pairing, and the machine went silent to
|
||||||
|
// every Host it served until someone paired it again by hand. The installer's
|
||||||
|
// header said so; nothing else did.
|
||||||
|
//
|
||||||
|
// THE CARRY. `service install` (elevated) moves the account's state folder
|
||||||
|
// into the service's before the service starts, when the service has no
|
||||||
|
// pairing of its own yet:
|
||||||
|
//
|
||||||
|
// - a service that already serves a Host takes the account's pairings too,
|
||||||
|
// with no question (a move to the service never leaves a pairing
|
||||||
|
// behind). Only the pairings for Hosts the service does not serve
|
||||||
|
// come in, each with its own folders and a loopback port of its own
|
||||||
|
// (carryAddedHosts); nothing of the account's that the service keeps
|
||||||
|
// machine-wide (keys, owner, code, anchor, mode, audit) ever becomes the
|
||||||
|
// service's. On an anchored machine each added pairing waits, pending,
|
||||||
|
// for the anchor Host to admit it, as any new pairing there does; on an
|
||||||
|
// unanchored one it is served as it was;
|
||||||
|
// - not while a bastion still runs from that folder (its run lock is held,
|
||||||
|
// waited for a moment), and the lock is held through the copy, the check
|
||||||
|
// and the emptying, so none starts in the middle;
|
||||||
|
// - a file the service already has is kept, the service's own; where the
|
||||||
|
// account's version differs, it is kept beside it (carryAsideSuffix);
|
||||||
|
// - every path in the carried JSON that names the old folder is rewritten
|
||||||
|
// to the new one (a pairing's context, DCN and backup folders);
|
||||||
|
// - every file written is read back and compared, and every pairing must
|
||||||
|
// be in the service's folder, before anything is removed; a copy that
|
||||||
|
// fails takes back what it wrote, so a later install carries it again;
|
||||||
|
// - then the account's folder is removed, so the pairing's keys and bearer
|
||||||
|
// no longer sit where any program running as that account can read them.
|
||||||
|
// One that will not go is said, and the service still starts.
|
||||||
|
//
|
||||||
|
// The decisions are here, untagged, so the suite runs them on every platform;
|
||||||
|
// finding the account's folder is in sysservice_windows.go.
|
||||||
|
|
||||||
|
import (
|
||||||
|
"bytes"
|
||||||
|
"encoding/json"
|
||||||
|
"errors"
|
||||||
|
"fmt"
|
||||||
|
"io/fs"
|
||||||
|
"os"
|
||||||
|
"path/filepath"
|
||||||
|
"runtime"
|
||||||
|
"sort"
|
||||||
|
"strconv"
|
||||||
|
"strings"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
// The carry's file operations, so the suite can fail one part way.
|
||||||
|
var (
|
||||||
|
carryWriteFile = os.WriteFile
|
||||||
|
carryRemoveAll = os.RemoveAll
|
||||||
|
)
|
||||||
|
|
||||||
|
// carryAsideSuffix names the account's version of a file the service already
|
||||||
|
// had, kept beside the service's own: the account's folder is removed after
|
||||||
|
// the carry, and its version would go with it.
|
||||||
|
const carryAsideSuffix = ".from-account"
|
||||||
|
|
||||||
|
// carryLockPatience is how long the carry waits for the account's run lock.
|
||||||
|
// The installer stops the account's bastion just before (Stop-Process), and
|
||||||
|
// Windows releases a killed process's file locks a moment after it is gone.
|
||||||
|
var carryLockPatience = 10 * time.Second
|
||||||
|
|
||||||
|
// carrySkip are the files that belong to a running bastion, not to its state.
|
||||||
|
var carrySkip = map[string]bool{"run.lock": true, "run.holder.json": true, "pairings.lock": true,
|
||||||
|
"ui.addr": true, "bastion.log": true, "bastion.log.1": true}
|
||||||
|
|
||||||
|
// carryResult is what a carry did.
|
||||||
|
type carryResult struct {
|
||||||
|
Hosts []string // the pairings carried, by Host
|
||||||
|
Kept int // files the service already had, left as they were
|
||||||
|
// Aside are the files the service already had whose account version
|
||||||
|
// differed; that version is beside each, named with carryAsideSuffix.
|
||||||
|
Aside []string
|
||||||
|
Note string // why nothing was carried, when nothing was
|
||||||
|
// Beside: the Hosts the service already served, when Hosts were added
|
||||||
|
// beside them (carryAddedHosts); Hosts are then the ones added.
|
||||||
|
Beside []string
|
||||||
|
// Pending: the added pairings wait for the machine's anchor to admit them;
|
||||||
|
// Anchor names it.
|
||||||
|
Pending bool
|
||||||
|
Anchor string
|
||||||
|
// Stayed: the account's pairings for Hosts the service already served,
|
||||||
|
// left in the account's folder.
|
||||||
|
Stayed []string
|
||||||
|
// Left: the pairings are in the service, but the account's folder could
|
||||||
|
// not be removed, and still holds copies of their keys.
|
||||||
|
Left string
|
||||||
|
}
|
||||||
|
|
||||||
|
// pairingHosts lists the Hosts dir/pairings holds a pairing for. A Host's
|
||||||
|
// signed grant beside it (pairingGrantSuffix) is not a pairing (loadPairings).
|
||||||
|
func pairingHosts(dir string) ([]string, error) {
|
||||||
|
ents, err := os.ReadDir(filepath.Join(dir, "pairings"))
|
||||||
|
if errors.Is(err, fs.ErrNotExist) {
|
||||||
|
return nil, nil
|
||||||
|
}
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
var hosts []string
|
||||||
|
for _, e := range ents {
|
||||||
|
if !e.IsDir() && strings.HasSuffix(e.Name(), ".json") && !strings.HasSuffix(e.Name(), pairingGrantSuffix) {
|
||||||
|
hosts = append(hosts, strings.TrimSuffix(e.Name(), ".json"))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
sort.Strings(hosts)
|
||||||
|
return hosts, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// carryLock takes the account's run lock, waiting up to carryLockPatience for
|
||||||
|
// a bastion that is exiting to let it go.
|
||||||
|
func carryLock(f *os.File) error {
|
||||||
|
deadline := time.Now().Add(carryLockPatience)
|
||||||
|
for {
|
||||||
|
err := flockFileNB(f)
|
||||||
|
if err == nil || !time.Now().Before(deadline) {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
time.Sleep(200 * time.Millisecond)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// carryTakeLock takes the account folder's run lock for a carry and returns
|
||||||
|
// what lets it go. It is held until only the lock itself is left to remove, so
|
||||||
|
// no bastion starts from the folder while it is copied, checked and emptied;
|
||||||
|
// letting it go twice is harmless.
|
||||||
|
func carryTakeLock(from string) (func(), error) {
|
||||||
|
lock, err := os.OpenFile(filepath.Join(from, "run.lock"), os.O_CREATE|os.O_RDWR, 0o600)
|
||||||
|
if err != nil {
|
||||||
|
return nil, fmt.Errorf("cannot open the run lock under %s: %w", from, err)
|
||||||
|
}
|
||||||
|
if err := carryLock(lock); err != nil {
|
||||||
|
_ = lock.Close()
|
||||||
|
return nil, fmt.Errorf("a bastion is still running from %s (it holds that folder's run lock), so its pairings "+
|
||||||
|
"were not moved into the service. Stop it, then run `privatae-bastion service install` again", from)
|
||||||
|
}
|
||||||
|
locked := true
|
||||||
|
return func() {
|
||||||
|
if locked {
|
||||||
|
_ = lock.Close()
|
||||||
|
locked = false
|
||||||
|
}
|
||||||
|
}, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// carryStateInto moves the bastion state at from into to (see the header).
|
||||||
|
func carryStateInto(from, to string) (carryResult, error) {
|
||||||
|
var res carryResult
|
||||||
|
if from == "" || samePath(from, to) {
|
||||||
|
return res, nil
|
||||||
|
}
|
||||||
|
// Only ever a bastion's own folder: from is removed at the end.
|
||||||
|
if filepath.Base(filepath.Clean(from)) != "privatae-bastion" {
|
||||||
|
return res, fmt.Errorf("%s is not a bastion's state folder; nothing was moved", from)
|
||||||
|
}
|
||||||
|
hosts, err := pairingHosts(from)
|
||||||
|
if err != nil {
|
||||||
|
return res, fmt.Errorf("cannot read the pairings under %s: %w", from, err)
|
||||||
|
}
|
||||||
|
if len(hosts) == 0 {
|
||||||
|
return res, nil
|
||||||
|
}
|
||||||
|
have, err := pairingHosts(to)
|
||||||
|
if err != nil {
|
||||||
|
return res, fmt.Errorf("cannot read the service's pairings under %s: %w", to, err)
|
||||||
|
}
|
||||||
|
if len(have) > 0 {
|
||||||
|
return carryAddedHosts(from, to, hosts, have)
|
||||||
|
}
|
||||||
|
unlock, err := carryTakeLock(from)
|
||||||
|
if err != nil {
|
||||||
|
return res, err
|
||||||
|
}
|
||||||
|
defer unlock()
|
||||||
|
// A copy that fails takes back every file it wrote: a service left with
|
||||||
|
// some of the pairings serves a Host, so no later install would carry the
|
||||||
|
// rest, and the service would serve only those few.
|
||||||
|
written, kept, aside, err := copyStateTree(from, to)
|
||||||
|
undo := func() {
|
||||||
|
for p := range written {
|
||||||
|
_ = os.Remove(p)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if err != nil {
|
||||||
|
undo()
|
||||||
|
return res, fmt.Errorf("could not copy %s into the service's %s: %w. Nothing was removed from %s", from, to, err, from)
|
||||||
|
}
|
||||||
|
for p, want := range written {
|
||||||
|
got, err := os.ReadFile(p)
|
||||||
|
if err != nil || !bytes.Equal(got, want) {
|
||||||
|
undo()
|
||||||
|
return res, fmt.Errorf("%s did not read back as written; nothing was removed from %s", p, from)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
// Every pairing counted above is in the service's folder, or nothing is
|
||||||
|
// removed: a source the walk could not enter (a link) copies nothing.
|
||||||
|
got, err := pairingHosts(to)
|
||||||
|
if err != nil || strings.Join(got, "\x00") != strings.Join(hosts, "\x00") {
|
||||||
|
undo()
|
||||||
|
return res, fmt.Errorf("the service's folder %s holds the pairings %v after the copy, not %v; nothing was "+
|
||||||
|
"removed from %s", to, got, hosts, from)
|
||||||
|
}
|
||||||
|
res.Hosts, res.Kept, res.Aside = hosts, kept, aside
|
||||||
|
// From here the service has everything, so a folder that will not go is
|
||||||
|
// said, not a failure: failing would leave the service stopped.
|
||||||
|
var leftErr error
|
||||||
|
ents, err := os.ReadDir(from)
|
||||||
|
if err != nil {
|
||||||
|
leftErr = err
|
||||||
|
}
|
||||||
|
for _, e := range ents {
|
||||||
|
if e.Name() == "run.lock" {
|
||||||
|
continue // open here; Windows will not delete an open file
|
||||||
|
}
|
||||||
|
if err := carryRemoveAll(filepath.Join(from, e.Name())); err != nil && leftErr == nil {
|
||||||
|
leftErr = err
|
||||||
|
}
|
||||||
|
}
|
||||||
|
unlock()
|
||||||
|
if err := carryRemoveAll(from); err != nil && leftErr == nil {
|
||||||
|
leftErr = err
|
||||||
|
}
|
||||||
|
if leftErr != nil {
|
||||||
|
res.Left = fmt.Sprintf("%s could not be removed (%v). It still holds copies of the pairings' keys: delete that folder",
|
||||||
|
from, leftErr)
|
||||||
|
}
|
||||||
|
return res, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// copyStateTree copies from into to, file by file, and returns what it wrote
|
||||||
|
// (path to content, so far when it fails), how many files to already had,
|
||||||
|
// and which of those differed from the account's (see carryAsideSuffix).
|
||||||
|
// JSON files have every string that names a path under from rewritten to the
|
||||||
|
// same path under to. The pairing files go last: a service that starts
|
||||||
|
// meanwhile serves a pairing only once its file is there, and by then
|
||||||
|
// everything it reads is too.
|
||||||
|
func copyStateTree(from, to string) (map[string][]byte, int, []string, error) {
|
||||||
|
type item struct {
|
||||||
|
src, dst string
|
||||||
|
name string
|
||||||
|
}
|
||||||
|
var first, last []item
|
||||||
|
written := map[string][]byte{}
|
||||||
|
err := filepath.WalkDir(from, func(p string, d fs.DirEntry, err error) error {
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
rel, err := filepath.Rel(from, p)
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
dst := filepath.Join(to, rel)
|
||||||
|
switch {
|
||||||
|
case d.IsDir():
|
||||||
|
return os.MkdirAll(dst, 0o700)
|
||||||
|
case !d.Type().IsRegular():
|
||||||
|
return nil // a link or a device is never part of the state
|
||||||
|
case rel == d.Name() && carrySkip[d.Name()]:
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
it := item{p, dst, d.Name()}
|
||||||
|
if filepath.Dir(rel) == "pairings" {
|
||||||
|
last = append(last, it)
|
||||||
|
} else {
|
||||||
|
first = append(first, it)
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
})
|
||||||
|
if err != nil {
|
||||||
|
return written, 0, nil, err
|
||||||
|
}
|
||||||
|
kept := 0
|
||||||
|
var aside []string
|
||||||
|
write := func(p string, data []byte) error {
|
||||||
|
if err := carryWriteFile(p, data, 0o600); err != nil {
|
||||||
|
_ = os.Remove(p)
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
written[p] = data
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
for _, it := range append(first, last...) {
|
||||||
|
data, err := os.ReadFile(it.src)
|
||||||
|
if err != nil {
|
||||||
|
return written, 0, nil, err
|
||||||
|
}
|
||||||
|
if strings.HasSuffix(it.name, ".json") {
|
||||||
|
data = rebaseJSONPaths(data, from, to)
|
||||||
|
}
|
||||||
|
if _, err := os.Lstat(it.dst); err == nil {
|
||||||
|
kept++
|
||||||
|
if have, err := os.ReadFile(it.dst); err == nil && bytes.Equal(have, data) {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
p := it.dst + carryAsideSuffix
|
||||||
|
if _, err := os.Lstat(p); err == nil {
|
||||||
|
return written, 0, nil, fmt.Errorf("%s is already there; the account's %s was not put beside the "+
|
||||||
|
"service's", p, it.name)
|
||||||
|
}
|
||||||
|
if err := write(p, data); err != nil {
|
||||||
|
return written, 0, nil, err
|
||||||
|
}
|
||||||
|
aside = append(aside, p)
|
||||||
|
continue
|
||||||
|
} else if !errors.Is(err, fs.ErrNotExist) {
|
||||||
|
return written, 0, nil, err
|
||||||
|
}
|
||||||
|
if err := write(it.dst, data); err != nil {
|
||||||
|
return written, 0, nil, err
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return written, kept, aside, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// rebaseJSONPaths rewrites every string in a JSON document that is from, or a
|
||||||
|
// path under it, to the same path under to. A document that does not parse is
|
||||||
|
// returned as it was.
|
||||||
|
func rebaseJSONPaths(data []byte, from, to string) []byte {
|
||||||
|
var v any
|
||||||
|
dec := json.NewDecoder(bytes.NewReader(data))
|
||||||
|
dec.UseNumber()
|
||||||
|
if err := dec.Decode(&v); err != nil {
|
||||||
|
return data
|
||||||
|
}
|
||||||
|
changed := false
|
||||||
|
var walk func(any) any
|
||||||
|
walk = func(x any) any {
|
||||||
|
switch t := x.(type) {
|
||||||
|
case string:
|
||||||
|
if r, ok := rebasePath(t, from, to); ok {
|
||||||
|
changed = true
|
||||||
|
return r
|
||||||
|
}
|
||||||
|
case []any:
|
||||||
|
for i := range t {
|
||||||
|
t[i] = walk(t[i])
|
||||||
|
}
|
||||||
|
case map[string]any:
|
||||||
|
for k := range t {
|
||||||
|
t[k] = walk(t[k])
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return x
|
||||||
|
}
|
||||||
|
v = walk(v)
|
||||||
|
if !changed {
|
||||||
|
return data
|
||||||
|
}
|
||||||
|
out, err := json.MarshalIndent(v, "", " ")
|
||||||
|
if err != nil {
|
||||||
|
return data
|
||||||
|
}
|
||||||
|
return out
|
||||||
|
}
|
||||||
|
|
||||||
|
// rebasePath is p moved from under from to under to, and whether p was there.
|
||||||
|
func rebasePath(p, from, to string) (string, bool) {
|
||||||
|
sep := string(filepath.Separator)
|
||||||
|
f := strings.TrimRight(from, `\/`)
|
||||||
|
switch {
|
||||||
|
case samePath(p, f):
|
||||||
|
return to, true
|
||||||
|
case len(p) > len(f) && samePath(p[:len(f)], f) && (p[len(f)] == '\\' || p[len(f)] == '/'):
|
||||||
|
return strings.TrimRight(to, `\/`) + sep + strings.TrimLeft(p[len(f):], `\/`), true
|
||||||
|
}
|
||||||
|
return p, false
|
||||||
|
}
|
||||||
|
|
||||||
|
// samePath compares two paths as this platform's filesystem does: without
|
||||||
|
// case on Windows.
|
||||||
|
func samePath(a, b string) bool {
|
||||||
|
a, b = filepath.Clean(a), filepath.Clean(b)
|
||||||
|
if runtime.GOOS == "windows" {
|
||||||
|
return strings.EqualFold(a, b)
|
||||||
|
}
|
||||||
|
return a == b
|
||||||
|
}
|
||||||
|
|
||||||
|
// carryReport is what `service install` says of a carry.
|
||||||
|
func carryReport(r carryResult, from string) string {
|
||||||
|
switch {
|
||||||
|
case r.Note != "":
|
||||||
|
return " " + sentenceCase(r.Note) + "."
|
||||||
|
case len(r.Hosts) == 0:
|
||||||
|
return ""
|
||||||
|
}
|
||||||
|
s := " Moved this machine's pairings into the service from " + from + ": " + strings.Join(r.Hosts, ", ") +
|
||||||
|
". They go on serving as they were; nothing needs pairing again."
|
||||||
|
if len(r.Beside) > 0 {
|
||||||
|
s = " Added " + strings.Join(r.Hosts, ", ") + " to the service, beside " + strings.Join(r.Beside, ", ") +
|
||||||
|
", from " + from + "; nothing needs pairing again."
|
||||||
|
if !r.Pending {
|
||||||
|
s += " Each goes on serving as it was."
|
||||||
|
}
|
||||||
|
if r.Pending {
|
||||||
|
if r.Anchor != "" {
|
||||||
|
s += " Each waits until " + r.Anchor + ", the Host in charge of this machine, admits it: " + r.Anchor +
|
||||||
|
" asks you to approve it, and it is served from then on."
|
||||||
|
} else {
|
||||||
|
s += " Each waits until the Host in charge of this machine admits it."
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if len(r.Stayed) > 0 {
|
||||||
|
s += " The service already served " + strings.Join(r.Stayed, ", ") + ", so your account's pairing for it " +
|
||||||
|
"was left in " + from + "."
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if r.Kept > 0 {
|
||||||
|
s += fmt.Sprintf(" %d file(s) the service already had were kept as the service's.", r.Kept)
|
||||||
|
}
|
||||||
|
if len(r.Aside) > 0 {
|
||||||
|
s += " Your account's own version of " + strconv.Itoa(len(r.Aside)) + " of them differed, and is kept " +
|
||||||
|
"beside it in the service's folder as: " + strings.Join(r.Aside, ", ") + "."
|
||||||
|
}
|
||||||
|
if r.Left != "" {
|
||||||
|
s += "\n " + sentenceCase(r.Left) + "."
|
||||||
|
}
|
||||||
|
return s
|
||||||
|
}
|
||||||
|
|
||||||
|
// carryHostRoots are the folders under from that belong to host's pairing
|
||||||
|
// alone (config.go contextRoot, dcnDir; backupfetch.go backupRootPath;
|
||||||
|
// mirror.go mirrorDir), and any other folder or file its pairing names under
|
||||||
|
// from, relative to from. A pairing that keeps its state in a folder every
|
||||||
|
// pairing shares (the layout before 0.10.0, migrateLegacyConfig) is refused:
|
||||||
|
// that folder is not its alone to move.
|
||||||
|
func carryHostRoots(raw []byte, from, host string) ([]string, error) {
|
||||||
|
roots := map[string]bool{}
|
||||||
|
for _, top := range []string{"context", "dcn", "backups", "mirror"} {
|
||||||
|
roots[filepath.Join(top, host)] = true
|
||||||
|
}
|
||||||
|
var v any
|
||||||
|
dec := json.NewDecoder(bytes.NewReader(raw))
|
||||||
|
dec.UseNumber()
|
||||||
|
if err := dec.Decode(&v); err != nil {
|
||||||
|
return nil, fmt.Errorf("the pairing for %s does not read: %w", host, err)
|
||||||
|
}
|
||||||
|
var walkErr error
|
||||||
|
var walk func(any)
|
||||||
|
walk = func(x any) {
|
||||||
|
switch t := x.(type) {
|
||||||
|
case string:
|
||||||
|
if _, ok := rebasePath(t, from, from); !ok {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
rel, err := filepath.Rel(from, t)
|
||||||
|
if err != nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
first := strings.SplitN(filepath.ToSlash(rel), "/", 2)[0]
|
||||||
|
switch {
|
||||||
|
case first == "pairings":
|
||||||
|
return
|
||||||
|
case rel == "." || !strings.Contains(filepath.ToSlash(rel), "/"):
|
||||||
|
if walkErr == nil {
|
||||||
|
walkErr = fmt.Errorf("the pairing for %s keeps its state in %s, which every pairing under %s "+
|
||||||
|
"shares, so it was not added", host, t, from)
|
||||||
|
}
|
||||||
|
return
|
||||||
|
}
|
||||||
|
roots[rel] = true
|
||||||
|
case []any:
|
||||||
|
for _, e := range t {
|
||||||
|
walk(e)
|
||||||
|
}
|
||||||
|
case map[string]any:
|
||||||
|
for _, e := range t {
|
||||||
|
walk(e)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
walk(v)
|
||||||
|
if walkErr != nil {
|
||||||
|
return nil, walkErr
|
||||||
|
}
|
||||||
|
var out []string
|
||||||
|
for r := range roots {
|
||||||
|
out = append(out, r)
|
||||||
|
}
|
||||||
|
sort.Strings(out)
|
||||||
|
// A root inside another is the other's already.
|
||||||
|
var kept []string
|
||||||
|
for _, r := range out {
|
||||||
|
inside := false
|
||||||
|
for _, k := range kept {
|
||||||
|
if strings.HasPrefix(filepath.ToSlash(r)+"/", filepath.ToSlash(k)+"/") {
|
||||||
|
inside = true
|
||||||
|
break
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if !inside {
|
||||||
|
kept = append(kept, r)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return kept, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// carryUsedAddrs are the loopback addresses the service's own pairings hold:
|
||||||
|
// their control ports and git proxies (config.go nextListenAddr,
|
||||||
|
// nextGitProxyAddr). An added pairing that held one of them in the account
|
||||||
|
// would fail to bind beside the pairing that has it here.
|
||||||
|
func carryUsedAddrs(to string) (map[string]bool, error) {
|
||||||
|
used := map[string]bool{}
|
||||||
|
hosts, err := pairingHosts(to)
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
for _, h := range hosts {
|
||||||
|
raw, err := os.ReadFile(filepath.Join(to, "pairings", h+".json"))
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
var c Config
|
||||||
|
if err := json.Unmarshal(raw, &c); err != nil {
|
||||||
|
return nil, fmt.Errorf("the service's pairing for %s does not read: %w", h, err)
|
||||||
|
}
|
||||||
|
used[c.ListenAddr], used[c.GitProxyAddr] = true, true
|
||||||
|
}
|
||||||
|
delete(used, "")
|
||||||
|
return used, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// carryFreeAddr is the first loopback port from start up that used does not
|
||||||
|
// hold, marked used.
|
||||||
|
func carryFreeAddr(start int, used map[string]bool) string {
|
||||||
|
for port := start; ; port++ {
|
||||||
|
addr := fmt.Sprintf("127.0.0.1:%d", port)
|
||||||
|
if !used[addr] {
|
||||||
|
used[addr] = true
|
||||||
|
return addr
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// carriedPairing is an account's pairing as the service keeps it: its paths
|
||||||
|
// moved under to, its loopback ports its own among the service's, and on an
|
||||||
|
// anchored machine pending, as `pair` writes any new pairing there
|
||||||
|
// (pairPrecheckState). Every other field, its keys and bearer included, is
|
||||||
|
// as it was.
|
||||||
|
func carriedPairing(raw []byte, from, to string, used map[string]bool, anchored bool) ([]byte, error) {
|
||||||
|
var m map[string]any
|
||||||
|
dec := json.NewDecoder(bytes.NewReader(rebaseJSONPaths(raw, from, to)))
|
||||||
|
dec.UseNumber()
|
||||||
|
if err := dec.Decode(&m); err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
la, _ := m["listen_addr"].(string)
|
||||||
|
if la == "" || used[la] {
|
||||||
|
la = carryFreeAddr(7878, used)
|
||||||
|
}
|
||||||
|
used[la] = true
|
||||||
|
m["listen_addr"] = la
|
||||||
|
if ga, _ := m["git_proxy_addr"].(string); ga != "" {
|
||||||
|
if used[ga] {
|
||||||
|
ga = carryFreeAddr(7978, used)
|
||||||
|
}
|
||||||
|
used[ga] = true
|
||||||
|
m["git_proxy_addr"] = ga
|
||||||
|
}
|
||||||
|
// On a machine an organisation's policy governs, a Host it does not name
|
||||||
|
// waits for the one it does, anchored yet or not, as `pair` writes it
|
||||||
|
// (pairPrecheckState).
|
||||||
|
host, _ := m["host_name"].(string)
|
||||||
|
if p := currentAnchorPolicy(); anchored || (p != nil && !policyNames(p, host)) {
|
||||||
|
m["state"] = pairingPending
|
||||||
|
}
|
||||||
|
m["origin"] = pairingOriginCarried
|
||||||
|
return json.MarshalIndent(m, "", " ")
|
||||||
|
}
|
||||||
|
|
||||||
|
// carryAddedHosts adds the account's pairings for Hosts the service does not
|
||||||
|
// serve to a service that serves others (see the
|
||||||
|
// header). The account's pairings for Hosts the service already serves stay
|
||||||
|
// where they are. When none stays, the rest of the account's folder (its
|
||||||
|
// keys, owner, code, anchor, mode, audit) is kept beside the service's own
|
||||||
|
// files with carryAsideSuffix, never in their place, and the folder is
|
||||||
|
// removed, as a whole carry removes it.
|
||||||
|
func carryAddedHosts(from, to string, hosts, have []string) (carryResult, error) {
|
||||||
|
var res carryResult
|
||||||
|
serving := map[string]bool{}
|
||||||
|
for _, h := range have {
|
||||||
|
serving[h] = true
|
||||||
|
}
|
||||||
|
var add, stay []string
|
||||||
|
for _, h := range hosts {
|
||||||
|
if serving[h] {
|
||||||
|
stay = append(stay, h)
|
||||||
|
} else {
|
||||||
|
add = append(add, h)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if len(add) == 0 {
|
||||||
|
res.Note = fmt.Sprintf("the service already serves every Host the pairings under %s are for (%s), so nothing "+
|
||||||
|
"was added", from, strings.Join(hosts, ", "))
|
||||||
|
return res, nil
|
||||||
|
}
|
||||||
|
unlock, err := carryTakeLock(from)
|
||||||
|
if err != nil {
|
||||||
|
return res, err
|
||||||
|
}
|
||||||
|
defer unlock()
|
||||||
|
_, aerr := os.Lstat(filepath.Join(to, "anchor.json"))
|
||||||
|
anchored := aerr == nil
|
||||||
|
anchorName := ""
|
||||||
|
if raw, err := os.ReadFile(filepath.Join(to, "anchor.json")); err == nil {
|
||||||
|
var a struct {
|
||||||
|
AnchorHost string `json:"anchor_host"`
|
||||||
|
}
|
||||||
|
if json.Unmarshal(raw, &a) == nil && validHostName(a.AnchorHost) {
|
||||||
|
anchorName = a.AnchorHost
|
||||||
|
}
|
||||||
|
}
|
||||||
|
used, err := carryUsedAddrs(to)
|
||||||
|
if err != nil {
|
||||||
|
return res, fmt.Errorf("cannot read the service's pairings under %s: %w", to, err)
|
||||||
|
}
|
||||||
|
|
||||||
|
type item struct {
|
||||||
|
rel string
|
||||||
|
data []byte // set: written as it is; nil: read from from and rebased
|
||||||
|
aside bool // kept beside the service's file of that name, never in its place
|
||||||
|
}
|
||||||
|
var items, last []item
|
||||||
|
carried := map[string]bool{} // rel paths (and roots) this carry moves
|
||||||
|
for _, h := range add {
|
||||||
|
praw, err := os.ReadFile(filepath.Join(from, "pairings", h+".json"))
|
||||||
|
if err != nil {
|
||||||
|
return res, fmt.Errorf("cannot read the pairing for %s under %s: %w", h, from, err)
|
||||||
|
}
|
||||||
|
roots, err := carryHostRoots(praw, from, h)
|
||||||
|
if err != nil {
|
||||||
|
return res, err
|
||||||
|
}
|
||||||
|
for _, r := range roots {
|
||||||
|
carried[r] = true
|
||||||
|
err := filepath.WalkDir(filepath.Join(from, r), func(p string, d fs.DirEntry, err error) error {
|
||||||
|
if errors.Is(err, fs.ErrNotExist) {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
if !d.Type().IsRegular() {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
rel, err := filepath.Rel(from, p)
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
items = append(items, item{rel: rel})
|
||||||
|
return nil
|
||||||
|
})
|
||||||
|
if err != nil {
|
||||||
|
return res, fmt.Errorf("cannot read %s: %w", filepath.Join(from, r), err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
data, err := carriedPairing(praw, from, to, used, anchored)
|
||||||
|
if err != nil {
|
||||||
|
return res, fmt.Errorf("the pairing for %s does not read: %w", h, err)
|
||||||
|
}
|
||||||
|
prel := filepath.Join("pairings", h+".json")
|
||||||
|
grel := filepath.Join("pairings", h+pairingGrantSuffix)
|
||||||
|
carried[prel] = true
|
||||||
|
last = append(last, item{rel: prel, data: data})
|
||||||
|
// A grant is the anchor's word for this machine. On an anchored
|
||||||
|
// machine the account's grant was another anchor's, and the pairing
|
||||||
|
// waits for this one's instead; it is kept beside, like any file of
|
||||||
|
// the account's the service does not take.
|
||||||
|
if _, err := os.Lstat(filepath.Join(from, grel)); err == nil && !anchored {
|
||||||
|
carried[grel] = true
|
||||||
|
last = append(last, item{rel: grel})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if len(stay) == 0 {
|
||||||
|
// Nothing stays: the rest of the folder goes beside the service's.
|
||||||
|
err := filepath.WalkDir(from, func(p string, d fs.DirEntry, err error) error {
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
rel, err := filepath.Rel(from, p)
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
if carried[rel] {
|
||||||
|
if d.IsDir() {
|
||||||
|
return filepath.SkipDir
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
if !d.Type().IsRegular() || (rel == d.Name() && carrySkip[d.Name()]) {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
items = append(items, item{rel: rel, aside: true})
|
||||||
|
return nil
|
||||||
|
})
|
||||||
|
if err != nil {
|
||||||
|
return res, fmt.Errorf("cannot read %s: %w", from, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
written := map[string][]byte{}
|
||||||
|
undo := func() {
|
||||||
|
for p := range written {
|
||||||
|
_ = os.Remove(p)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
for _, it := range append(items, last...) {
|
||||||
|
data := it.data
|
||||||
|
if data == nil {
|
||||||
|
if data, err = os.ReadFile(filepath.Join(from, it.rel)); err != nil {
|
||||||
|
undo()
|
||||||
|
return res, fmt.Errorf("cannot read %s: %w. Nothing was removed from %s", filepath.Join(from, it.rel), err, from)
|
||||||
|
}
|
||||||
|
if strings.HasSuffix(it.rel, ".json") {
|
||||||
|
data = rebaseJSONPaths(data, from, to)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
dst := filepath.Join(to, it.rel)
|
||||||
|
if it.aside {
|
||||||
|
dst += carryAsideSuffix
|
||||||
|
}
|
||||||
|
if have, err := os.ReadFile(dst); err == nil {
|
||||||
|
if bytes.Equal(have, data) {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
if !it.aside {
|
||||||
|
res.Kept++
|
||||||
|
dst += carryAsideSuffix
|
||||||
|
if _, err := os.Lstat(dst); err == nil {
|
||||||
|
undo()
|
||||||
|
return res, fmt.Errorf("%s is already there; the account's %s was not put beside the service's. "+
|
||||||
|
"Nothing was removed from %s", dst, it.rel, from)
|
||||||
|
}
|
||||||
|
res.Aside = append(res.Aside, dst)
|
||||||
|
} else {
|
||||||
|
undo()
|
||||||
|
return res, fmt.Errorf("%s is already there; the account's %s was not put beside it. Nothing was "+
|
||||||
|
"removed from %s", dst, it.rel, from)
|
||||||
|
}
|
||||||
|
} else if !errors.Is(err, fs.ErrNotExist) {
|
||||||
|
undo()
|
||||||
|
return res, err
|
||||||
|
}
|
||||||
|
if err := os.MkdirAll(filepath.Dir(dst), 0o700); err != nil {
|
||||||
|
undo()
|
||||||
|
return res, err
|
||||||
|
}
|
||||||
|
if err := carryWriteFile(dst, data, 0o600); err != nil {
|
||||||
|
_ = os.Remove(dst)
|
||||||
|
undo()
|
||||||
|
return res, fmt.Errorf("could not write %s: %w. Nothing was removed from %s", dst, err, from)
|
||||||
|
}
|
||||||
|
written[dst] = data
|
||||||
|
}
|
||||||
|
for p, want := range written {
|
||||||
|
got, err := os.ReadFile(p)
|
||||||
|
if err != nil || !bytes.Equal(got, want) {
|
||||||
|
undo()
|
||||||
|
return res, fmt.Errorf("%s did not read back as written; nothing was removed from %s", p, from)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
got, err := pairingHosts(to)
|
||||||
|
if err != nil {
|
||||||
|
undo()
|
||||||
|
return res, err
|
||||||
|
}
|
||||||
|
in := map[string]bool{}
|
||||||
|
for _, h := range got {
|
||||||
|
in[h] = true
|
||||||
|
}
|
||||||
|
for _, h := range append(append([]string{}, have...), add...) {
|
||||||
|
if !in[h] {
|
||||||
|
undo()
|
||||||
|
return res, fmt.Errorf("the service's folder %s holds the pairings %v after the copy, not %s's; nothing "+
|
||||||
|
"was removed from %s", to, got, h, from)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
res.Hosts, res.Beside, res.Pending, res.Stayed, res.Anchor = add, have, anchored, stay, anchorName
|
||||||
|
|
||||||
|
// From here the service has every added pairing, so what will not go is
|
||||||
|
// said, not a failure.
|
||||||
|
var leftErr error
|
||||||
|
if len(stay) > 0 {
|
||||||
|
var rels []string
|
||||||
|
for r := range carried {
|
||||||
|
rels = append(rels, r)
|
||||||
|
}
|
||||||
|
sort.Strings(rels)
|
||||||
|
for _, r := range rels {
|
||||||
|
if err := carryRemoveAll(filepath.Join(from, r)); err != nil && leftErr == nil {
|
||||||
|
leftErr = err
|
||||||
|
}
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
ents, err := os.ReadDir(from)
|
||||||
|
if err != nil {
|
||||||
|
leftErr = err
|
||||||
|
}
|
||||||
|
for _, e := range ents {
|
||||||
|
if e.Name() == "run.lock" {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
if err := carryRemoveAll(filepath.Join(from, e.Name())); err != nil && leftErr == nil {
|
||||||
|
leftErr = err
|
||||||
|
}
|
||||||
|
}
|
||||||
|
unlock()
|
||||||
|
if err := carryRemoveAll(from); err != nil && leftErr == nil {
|
||||||
|
leftErr = err
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if leftErr != nil {
|
||||||
|
res.Left = fmt.Sprintf("part of %s could not be removed (%v). It may still hold copies of the added pairings' "+
|
||||||
|
"keys: delete those files", from, leftErr)
|
||||||
|
}
|
||||||
|
return res, nil
|
||||||
|
}
|
||||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user